Title: [294357] releases/WebKitGTK/webkit-2.36/Tools
Revision
294357
Author
ape...@igalia.com
Date
2022-05-17 16:17:45 -0700 (Tue, 17 May 2022)

Log Message

Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
https://bugs.webkit.org/show_bug.cgi?id=240543

Unreviewed build fix.

* Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
shebang to use "python3", and pass an "encoding" argument to the Popen
constructor to read strings instead of bytes from the subprocess pipe.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.36/Tools/ChangeLog (294356 => 294357)


--- releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-05-17 23:17:39 UTC (rev 294356)
+++ releases/WebKitGTK/webkit-2.36/Tools/ChangeLog	2022-05-17 23:17:45 UTC (rev 294357)
@@ -1,3 +1,14 @@
+2022-05-17  Adrian Perez de Castro  <ape...@igalia.com>
+
+        Fix Tools/Scripts/check-for-invalid-symbols-in-version-script
+        https://bugs.webkit.org/show_bug.cgi?id=240543
+
+        Unreviewed build fix.
+
+        * Tools/Scripts/check-for-invalid-symbols-in-version-script: Change
+        shebang to use "python3", and pass an "encoding" argument to the Popen
+        constructor to read strings instead of bytes from the subprocess pipe.
+
 2022-03-03  Lauro Moura  <lmo...@igalia.com>
 
         [Python3] Switch a few more glib scripts to Python3

Modified: releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script (294356 => 294357)


--- releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script	2022-05-17 23:17:39 UTC (rev 294356)
+++ releases/WebKitGTK/webkit-2.36/Tools/Scripts/check-for-invalid-symbols-in-version-script	2022-05-17 23:17:45 UTC (rev 294357)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 import subprocess
 import sys
@@ -25,7 +25,7 @@
 
 
 symbols = script_symbols(sys.argv[1])
-p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE)
+p = subprocess.Popen(['objdump', '-t', '-C', sys.argv[2]], stdout=subprocess.PIPE, encoding="ascii")
 data = ""
 
 symbols = []
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to