Title: [295494] trunk/LayoutTests
- Revision
- 295494
- Author
- commit-qu...@webkit.org
- Date
- 2022-06-13 11:49:32 -0700 (Mon, 13 Jun 2022)
Log Message
Regression (r268615) : [ macOS ] webanimations/relative-ordering-of-translate-and-rotate-properties-accelerated.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=230863
<rdar://83593809>
Patch by Antoine Quint <grao...@apple.com> on 2022-06-13
Reviewed by Dean Jackson.
Use the tried and true technique of waiting for animations to be ready and three animation frames
to ensure all accelerated animations have been committed.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/webanimations/resources/wait-until-animations-are-committed.js:
Canonical link: https://commits.webkit.org/251499@main
Modified Paths
Diff
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (295493 => 295494)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-06-13 18:20:38 UTC (rev 295493)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2022-06-13 18:49:32 UTC (rev 295494)
@@ -1477,8 +1477,6 @@
# rdar://80342885 ([ Monterey wk1 arm64 ] webanimations/accelerated-transition-by-removing-property.html is a flaky image only failure)
[ Monterey arm64 ] webanimations/accelerated-transition-by-removing-property.html [ Pass ImageOnlyFailure ]
-webkit.org/b/230863 webanimations/relative-ordering-of-translate-and-rotate-properties-accelerated.html [ Pass ImageOnlyFailure ]
-
webkit.org/b/223816 [ arm64 ] platform/mac/fast/objc/webScriptObject-hasWebScriptKey.html [ Failure ]
# rdar://80346975
Modified: trunk/LayoutTests/webanimations/resources/wait-until-animations-are-committed.js (295493 => 295494)
--- trunk/LayoutTests/webanimations/resources/wait-until-animations-are-committed.js 2022-06-13 18:20:38 UTC (rev 295493)
+++ trunk/LayoutTests/webanimations/resources/wait-until-animations-are-committed.js 2022-06-13 18:49:32 UTC (rev 295494)
@@ -1,15 +1,12 @@
(async () => {
- if (!window.testRunner)
- return;
+ window.testRunner?.waitUntilDone();
- testRunner.waitUntilDone();
+ await Promise.all(document.getAnimations().map(animation => animation.ready));
- const script = document.createElement("script");
- script.src = ""
- script.addEventListener("load", async event => {
- await UIHelper.ensureStablePresentationUpdate();
- testRunner.notifyDone();
- });
- document.body.appendChild(script);
+ await new Promise(requestAnimationFrame);
+ await new Promise(requestAnimationFrame);
+ await new Promise(requestAnimationFrame);
+
+ window.testRunner?.notifyDone();
})();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
