Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 21a5d7f6e5b2c3d4fc502f6f1969461856260a43
https://github.com/WebKit/WebKit/commit/21a5d7f6e5b2c3d4fc502f6f1969461856260a43
Author: Wenson Hsieh <wenson_hs...@apple.com>
Date: 2023-10-23 (Mon, 23 Oct 2023)
Changed paths:
M Source/WebKit/UIProcess/WebContextMenuProxy.h
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h
M Source/WebKit/UIProcess/mac/WebPageProxyMac.mm
Log Message:
-----------
[Cocoa] Make WebContextMenuProxy::copySubjectResult return a `RetainPtr`
https://bugs.webkit.org/show_bug.cgi?id=263567
Reviewed by Tim Horton.
Clarify the ownership model around this method by returning a `RetainPtr`, and
additionally rename
the method so that it doesn't read like it copies the result.
* Source/WebKit/UIProcess/WebContextMenuProxy.h:
(WebKit::WebContextMenuProxy::imageForCopySubject const):
(WebKit::WebContextMenuProxy::copySubjectResult const): Deleted.
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.h:
* Source/WebKit/UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::handleContextMenuCopySubject):
Canonical link: https://commits.webkit.org/269695@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
