Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 53f8f07b250856cd134cedc5466ff64eb12cd778
      
https://github.com/WebKit/WebKit/commit/53f8f07b250856cd134cedc5466ff64eb12cd778
  Author: Mike Wyrzykowski <mwyrzykow...@apple.com>
  Date:   2023-10-23 (Mon, 23 Oct 2023)

  Changed paths:
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/Texture.mm

  Log Message:
  -----------
  [WebGPU] mip level validation is not handled correctly in 
copyBuffer/TextureToBuffer/Texture
https://bugs.webkit.org/show_bug.cgi?id=254175
<radar://106958194>

Reviewed by Tadeu Zagallo.

Fix some validation that was preventing imageCopy tests from working.

Compressed texture formats are still not fully working, but all the other cases 
pass.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUCommandEncoderImpl.cpp:
(WebCore::WebGPU::CommandEncoderImpl::copyBufferToTexture):
(WebCore::WebGPU::CommandEncoderImpl::copyTextureToBuffer):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::validateImageCopyBuffer):
(WebGPU::CommandEncoder::copyBufferToTexture):
(WebGPU::CommandEncoder::copyTextureToBuffer):
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::writeTexture):
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/Texture.mm:
(WebGPU::Texture::isCompressedFormat):
(WebGPU::Device::validateCreateTexture):
(WebGPU::Texture::validateImageCopyTexture):
(WebGPU::Texture::validateLinearTextureData):
(WebGPU::isCompressedFormat): Deleted.

Canonical link: https://commits.webkit.org/269667@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to