date:20120712

[webkit-changes] [122421] trunk/Source/WebCore

2012-07-12 Thread mrowe

Title: [122421] trunk/Source/WebCore








Revision 122421
Author mr...@apple.com
Date 2012-07-11 23:18:09 -0700 (Wed, 11 Jul 2012)


Log Message
http://webkit.org/b/91051 Fix the Qt Mac build after r122400.

Qt on Mac builds with a deployment target of OS X 10.5. However, it was not been setting
BUILDING_ON_LEOPARD / TARGETING_LEOPARD and thus was falling down code paths in DisplaySleepDisabler.cpp
that were specific to Snow Leopard and newer. After the removal of BUILDING_ON_LEOPARD
and TARGETING_LEOPARD it ended up falling down the correct Leopard-compatible code path,
which revealed that the code made assumptions about which headers had already been included.

* platform/mac/DisplaySleepDisabler.cpp: Include CoreServices/CoreServices.h to pull in
a declaration of UpdateSystemActivity when targeting Leopard.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/DisplaySleepDisabler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122420 => 122421)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 05:33:03 UTC (rev 122420)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 06:18:09 UTC (rev 122421)
@@ -1,3 +1,16 @@
+2012-07-11  Mark Rowe  mr...@apple.com
+
+http://webkit.org/b/91051 Fix the Qt Mac build after r122400.
+
+Qt on Mac builds with a deployment target of OS X 10.5. However, it was not been setting
+BUILDING_ON_LEOPARD / TARGETING_LEOPARD and thus was falling down code paths in DisplaySleepDisabler.cpp
+that were specific to Snow Leopard and newer. After the removal of BUILDING_ON_LEOPARD
+and TARGETING_LEOPARD it ended up falling down the correct Leopard-compatible code path,
+which revealed that the code made assumptions about which headers had already been included.
+
+* platform/mac/DisplaySleepDisabler.cpp: Include CoreServices/CoreServices.h to pull in
+a declaration of UpdateSystemActivity when targeting Leopard.
+
 2012-07-11  Matt Falkenhagen  fal...@chromium.org
 
 Add dialog element feature toggle to InternalSettings


Modified: trunk/Source/WebCore/platform/mac/DisplaySleepDisabler.cpp (122420 => 122421)

--- trunk/Source/WebCore/platform/mac/DisplaySleepDisabler.cpp	2012-07-12 05:33:03 UTC (rev 122420)
+++ trunk/Source/WebCore/platform/mac/DisplaySleepDisabler.cpp	2012-07-12 06:18:09 UTC (rev 122421)
@@ -31,6 +31,7 @@
 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
 #include wtf/UnusedParam.h
+#include CoreServices/CoreServices.h
 #endif
 
 namespace WebCore {
@@ -57,7 +58,7 @@
 {
 IOPMAssertionRelease(m_disableDisplaySleepAssertion);
 }
-
+
 #if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
 void DisplaySleepDisabler::systemActivityTimerFired(TimerDisplaySleepDisabler*)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122422] trunk

2012-07-12 Thread tkent

Title: [122422] trunk








Revision 122422
Author tk...@chromium.org
Date 2012-07-12 00:31:14 -0700 (Thu, 12 Jul 2012)


Log Message
Do not save the form state signature if nothing is saved
https://bugs.webkit.org/show_bug.cgi?id=91050

Reviewed by Hajime Morita.

Source/WebCore:

This change will reduce the size of HistoyItem.

Test: fast/forms/state-restore-empty-state.html

* html/FormController.cpp:
(WebCore::FormController::formElementsState):
If stateVector has only the signature string, clear it.

LayoutTests:

* fast/forms/resources/state-restore-empty-state-1.html: Added.
* fast/forms/state-restore-empty-state-expected.txt: Added.
* fast/forms/state-restore-empty-state.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/FormController.cpp


Added Paths

trunk/LayoutTests/fast/forms/resources/state-restore-empty-state-1.html
trunk/LayoutTests/fast/forms/state-restore-empty-state-expected.txt
trunk/LayoutTests/fast/forms/state-restore-empty-state.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122421 => 122422)

--- trunk/LayoutTests/ChangeLog	2012-07-12 06:18:09 UTC (rev 122421)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 07:31:14 UTC (rev 122422)
@@ -1,3 +1,14 @@
+2012-07-12  Kent Tamura  tk...@chromium.org
+
+Do not save the form state signature if nothing is saved
+https://bugs.webkit.org/show_bug.cgi?id=91050
+
+Reviewed by Hajime Morita.
+
+* fast/forms/resources/state-restore-empty-state-1.html: Added.
+* fast/forms/state-restore-empty-state-expected.txt: Added.
+* fast/forms/state-restore-empty-state.html: Added.
+
 2012-07-11  Matt Falkenhagen  fal...@chromium.org
 
 Add dialog element feature toggle to InternalSettings


Added: trunk/LayoutTests/fast/forms/resources/state-restore-empty-state-1.html (0 => 122422)

--- trunk/LayoutTests/fast/forms/resources/state-restore-empty-state-1.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/resources/state-restore-empty-state-1.html	2012-07-12 07:31:14 UTC (rev 122422)
@@ -0,0 +1,13 @@
+script src=""
+script
+description('State vector should be empty if nothing is saved.');
+if (window.internals) {
+var states = internals.formControlStateOfPreviousHistoryItem();
+shouldBe('states.length', '0');
+} else {
+debug('Need window.internals.formControlStateOfPreviousHistoryItem().');
+}
+jsTestIsAsync = true;
+finishJSTest();
+/script
+script src=""


Added: trunk/LayoutTests/fast/forms/state-restore-empty-state-expected.txt (0 => 122422)

--- trunk/LayoutTests/fast/forms/state-restore-empty-state-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/state-restore-empty-state-expected.txt	2012-07-12 07:31:14 UTC (rev 122422)
@@ -0,0 +1,10 @@
+State vector should be empty if nothing is saved.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS states.length is 0
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/state-restore-empty-state.html (0 => 122422)

--- trunk/LayoutTests/fast/forms/state-restore-empty-state.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/state-restore-empty-state.html	2012-07-12 07:31:14 UTC (rev 122422)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+
+input type=submit
+
+script
+jsTestIsAsync = true;
+
+window._onload_ = function() {
+setTimeout(function() {
+location.href = '';
+}, 0);
+};
+/script
+script src=""
+/body


Modified: trunk/Source/WebCore/ChangeLog (122421 => 122422)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 06:18:09 UTC (rev 122421)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 07:31:14 UTC (rev 122422)
@@ -1,3 +1,18 @@
+2012-07-12  Kent Tamura  tk...@chromium.org
+
+Do not save the form state signature if nothing is saved
+https://bugs.webkit.org/show_bug.cgi?id=91050
+
+Reviewed by Hajime Morita.
+
+This change will reduce the size of HistoyItem.
+
+Test: fast/forms/state-restore-empty-state.html
+
+* html/FormController.cpp:
+(WebCore::FormController::formElementsState):
+If stateVector has only the signature string, clear it.
+
 2012-07-11  Mark Rowe  mr...@apple.com
 
 http://webkit.org/b/91051 Fix the Qt Mac build after r122400.


Modified: trunk/Source/WebCore/html/FormController.cpp (122421 => 122422)

--- trunk/Source/WebCore/html/FormController.cpp	2012-07-12 06:18:09 UTC (rev 122421)
+++ trunk/Source/WebCore/html/FormController.cpp	2012-07-12 07:31:14 UTC (rev 122422)
@@ -172,6 +172,9 @@
 stateVector.append(keyGenerator-formKey(*elementWithState).string());
 elementWithState-saveFormControlState().serializeTo(stateVector);
 }
+bool hasOnlySignature = stateVector.size() == 1;
+if (hasOnlySignature)
+stateVector.clear();
 return stateVector;
 }

[webkit-changes] [122423] trunk/Source/JavaScriptCore

2012-07-12 Thread ossy

Title: [122423] trunk/Source/_javascript_Core








Revision 122423
Author o...@webkit.org
Date 2012-07-12 00:53:08 -0700 (Thu, 12 Jul 2012)


Log Message
Remove dead code after r122392.
https://bugs.webkit.org/show_bug.cgi?id=91049

Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (122422 => 122423)

--- trunk/Source/_javascript_Core/ChangeLog	2012-07-12 07:31:14 UTC (rev 122422)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-07-12 07:53:08 UTC (rev 122423)
@@ -1,3 +1,13 @@
+2012-07-12  Csaba Osztrogonác  o...@webkit.org
+
+Remove dead code after r122392.
+https://bugs.webkit.org/show_bug.cgi?id=91049
+
+Reviewed by Filip Pizlo.
+
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::emitCall):
+
 2012-07-11  Adenilson Cavalcanti  cavalcan...@gmail.com
 
 Build fix + remove dead code


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (122422 => 122423)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2012-07-12 07:31:14 UTC (rev 122422)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp	2012-07-12 07:53:08 UTC (rev 122423)
@@ -953,14 +953,8 @@
 
 void SpeculativeJIT::emitCall(Node node)
 {
-P_DFGOperation_E slowCallFunction;
-
-if (node.op() == Call)
-slowCallFunction = operationLinkCall;
-else {
+if (node.op() != Call)
 ASSERT(node.op() == Construct);
-slowCallFunction = operationLinkConstruct;
-}
 
 // For constructors, the this argument is not passed but we have to make space
 // for it.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122424] trunk/Source/WebCore

2012-07-12 Thread pdr

Title: [122424] trunk/Source/WebCore








Revision 122424
Author p...@google.com
Date 2012-07-12 01:10:23 -0700 (Thu, 12 Jul 2012)


Log Message
Refactor RenderSVGShape bounding box code
https://bugs.webkit.org/show_bug.cgi?id=90655

Reviewed by Nikolas Zimmermann.

RenderSVGShape::objectBoundingBox worked differently than RenderSVGShape::strokeBoundingBox by
not caching the object bounding box and instead computing it on each call. For consistency and
performance objectBoundingBox has been refactored to return a cached value.

createShape has been renamed updateShapeFromElement for understandability. updateShapeFromElement
now updates the internal state of the shape (bounding boxes, etc) from the associated element.
RenderSVGShape::inflateWithStrokeAndMarkerBounds has been merged into
RenderSVGShape::calculateStrokeBoundingBox which is called from updateShapeFromElement.

After this change all bounding box computation is now handled in updateShapeFromElement. Because
subclasses override updateShapeFromElement it will be easy for them to have custom bounding box
code there (as will happen for RenderSVGPath in a followup patch).

strokeBoundingBox and objectBoundingBox are now able to return their cached values immediately
in RenderSVGRect and RenderSVGEllipse instead of checking their fallback state on each call.

Additionally, to save space RenderSVGEllipse and RenderSVGRect now use the m_fillBoundingBox and
m_strokeBoundingBox of RenderSVGShape instead of having their own.

This patch also removes setStrokeAndMarkerBoundingBox that was previously dead code.

No new tests, just a refactoring.

* rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGEllipse::fillShape):
(WebCore::RenderSVGEllipse::strokeShape):
(WebCore::RenderSVGEllipse::shapeDependentStrokeContains):
* rendering/svg/RenderSVGEllipse.h:
(RenderSVGEllipse):
(WebCore::RenderSVGEllipse::isEmpty):
* rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGRect::fillShape):
(WebCore::RenderSVGRect::strokeShape):
(WebCore::RenderSVGRect::shapeDependentStrokeContains):
(WebCore::RenderSVGRect::shapeDependentFillContains):
* rendering/svg/RenderSVGRect.h:
(RenderSVGRect):
(WebCore::RenderSVGRect::isEmpty):
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::calculateObjectBoundingBox):
(WebCore::RenderSVGShape::calculateStrokeBoundingBox):
(WebCore::RenderSVGShape::updateRepaintBoundingBox):
* rendering/svg/RenderSVGShape.h:
(RenderSVGShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGEllipse.h
trunk/Source/WebCore/rendering/svg/RenderSVGRect.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGRect.h
trunk/Source/WebCore/rendering/svg/RenderSVGShape.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGShape.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (122423 => 122424)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 07:53:08 UTC (rev 122423)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 08:10:23 UTC (rev 122424)
@@ -1,3 +1,64 @@
+2012-07-12  Philip Rogers  p...@google.com
+
+Refactor RenderSVGShape bounding box code
+https://bugs.webkit.org/show_bug.cgi?id=90655
+
+Reviewed by Nikolas Zimmermann.
+
+RenderSVGShape::objectBoundingBox worked differently than RenderSVGShape::strokeBoundingBox by
+not caching the object bounding box and instead computing it on each call. For consistency and
+performance objectBoundingBox has been refactored to return a cached value.
+
+createShape has been renamed updateShapeFromElement for understandability. updateShapeFromElement
+now updates the internal state of the shape (bounding boxes, etc) from the associated element.
+RenderSVGShape::inflateWithStrokeAndMarkerBounds has been merged into
+RenderSVGShape::calculateStrokeBoundingBox which is called from updateShapeFromElement.
+
+After this change all bounding box computation is now handled in updateShapeFromElement. Because
+subclasses override updateShapeFromElement it will be easy for them to have custom bounding box
+code there (as will happen for RenderSVGPath in a followup patch).
+
+strokeBoundingBox and objectBoundingBox are now able to return their cached values immediately
+in RenderSVGRect and RenderSVGEllipse instead of checking their fallback state on each call.
+
+Additionally, to save space RenderSVGEllipse and RenderSVGRect now use the m_fillBoundingBox and
+m_strokeBoundingBox of RenderSVGShape instead of having their own.
+
+This patch also removes setStrokeAndMarkerBoundingBox that

[webkit-changes] [122426] trunk/Source/WebKit2

2012-07-12 Thread commit-queue

Title: [122426] trunk/Source/WebKit2








Revision 122426
Author commit-qu...@webkit.org
Date 2012-07-12 01:35:36 -0700 (Thu, 12 Jul 2012)


Log Message
[WK2][EFL] Add policy client to Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=90953

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-12
Reviewed by Kenneth Rohde Christiansen.

Emit new policy,decision,navigation and policy,decision,new,window
on the Ewk_View when policy decisions should be taken by the client.

A new Ewk_Navigation_Policy_Decision type is introduced to provide
information about the navigation request and make a decision.
By default, the navigation request is accepted.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_navigation_policy_decision.cpp: Added.
(_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):
(ewk_navigation_policy_navigation_type_get):
(ewk_navigation_policy_mouse_button_get):
(ewk_navigation_policy_modifiers_get):
(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):
(ewk_navigation_policy_decision_accept):
(ewk_navigation_policy_decision_reject):
(ewk_navigation_policy_decision_download):
(ewk_navigation_policy_decision_new):
* UIProcess/API/efl/ewk_navigation_policy_decision.h: Added.
* UIProcess/API/efl/ewk_navigation_policy_decision_private.h: Added.
* UIProcess/API/efl/ewk_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_navigation_policy_decision):
(ewk_view_new_window_policy_decision):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_policy_client.cpp: Added.
(toEwkView):
(decidePolicyForNavigationAction):
(decidePolicyForNewWindowAction):
(ewk_view_policy_client_attach):
* UIProcess/API/efl/ewk_view_policy_client_private.h: Added.
* UIProcess/API/efl/ewk_view_private.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
trunk/Source/WebKit2/UIProcess/API/efl/EWebKit2.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_private.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision_private.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_private.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view_policy_client_private.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122425 => 122426)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 08:12:52 UTC (rev 122425)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 08:35:36 UTC (rev 122426)
@@ -1,3 +1,47 @@
+2012-07-12  Christophe Dumez  christophe.du...@intel.com
+
+[WK2][EFL] Add policy client to Ewk_View
+https://bugs.webkit.org/show_bug.cgi?id=90953
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Emit new policy,decision,navigation and policy,decision,new,window
+on the Ewk_View when policy decisions should be taken by the client.
+
+A new Ewk_Navigation_Policy_Decision type is introduced to provide
+information about the navigation request and make a decision.
+By default, the navigation request is accepted.
+
+* PlatformEfl.cmake:
+* UIProcess/API/efl/EWebKit2.h:
+* UIProcess/API/efl/ewk_navigation_policy_decision.cpp: Added.
+(_Ewk_Navigation_Policy_Decision):
+(ewk_navigation_policy_decision_free):
+(ewk_navigation_policy_navigation_type_get):
+(ewk_navigation_policy_mouse_button_get):
+(ewk_navigation_policy_modifiers_get):
+(ewk_navigation_policy_frame_name_get):
+(ewk_navigation_policy_request_get):
+(ewk_navigation_policy_decision_accept):
+(ewk_navigation_policy_decision_reject):
+(ewk_navigation_policy_decision_download):
+(ewk_navigation_policy_decision_new):
+* UIProcess/API/efl/ewk_navigation_policy_decision.h: Added.
+* UIProcess/API/efl/ewk_navigation_policy_decision_private.h: Added.
+* UIProcess/API/efl/ewk_private.h: Added.
+* UIProcess/API/efl/ewk_view.cpp:
+(ewk_view_base_add):
+(ewk_view_navigation_policy_decision):
+(ewk_view_new_window_policy_decision):
+* UIProcess/API/efl/ewk_view.h:
+* UIProcess/API/efl/ewk_view_policy_client.cpp: Added.
+(toEwkView):
+(decidePolicyForNavigationAction):
+(decidePolicyForNewWindowAction):
+(ewk_view_policy_client_attach):
+* UIProcess/API/efl/ewk_view_policy_client_private.h: Added.
+* UIProcess/API/efl/ewk_view_private.h:
+
 2012-07-11  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add webkit_cookie_manager_set_persistent_storage() to WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/PlatformEfl.cmake

[webkit-changes] [122427] trunk/Source/WebKit

2012-07-12 Thread commit-queue

Title: [122427] trunk/Source/WebKit








Revision 122427
Author commit-qu...@webkit.org
Date 2012-07-12 01:38:08 -0700 (Thu, 12 Jul 2012)


Log Message
Typo in path in generate-webkitversion.pl
https://bugs.webkit.org/show_bug.cgi?id=90883

Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-07-12
Reviewed by Mark Rowe.

Correct default path to version config file. In practice it wasn't a problem because only the Qt
build system seems to use the script right now and passes the path to the version file as a
command line parameter.

* scripts/generate-webkitversion.pl:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/scripts/generate-webkitversion.pl




Diff

Modified: trunk/Source/WebKit/ChangeLog (122426 => 122427)

--- trunk/Source/WebKit/ChangeLog	2012-07-12 08:35:36 UTC (rev 122426)
+++ trunk/Source/WebKit/ChangeLog	2012-07-12 08:38:08 UTC (rev 122427)
@@ -1,3 +1,16 @@
+2012-07-12  Simon Hausmann  simon.hausm...@nokia.com
+
+Typo in path in generate-webkitversion.pl
+https://bugs.webkit.org/show_bug.cgi?id=90883
+
+Reviewed by Mark Rowe.
+
+Correct default path to version config file. In practice it wasn't a problem because only the Qt
+build system seems to use the script right now and passes the path to the version file as a
+command line parameter.
+
+* scripts/generate-webkitversion.pl:
+
 2012-07-11  Crystal Zhang  haizh...@rim.com
 
 [BlackBerry] Implement Date/Time picker


Modified: trunk/Source/WebKit/scripts/generate-webkitversion.pl (122426 => 122427)

--- trunk/Source/WebKit/scripts/generate-webkitversion.pl	2012-07-12 08:35:36 UTC (rev 122426)
+++ trunk/Source/WebKit/scripts/generate-webkitversion.pl	2012-07-12 08:38:08 UTC (rev 122427)
@@ -45,7 +45,7 @@
 my $major_version = ;
 my $minor_version = ;
 # The appropriate Apple-maintained Version.xcconfig file for WebKit version information is in WebKit/mac/Configurations/.
-my $configFile = ./Soure/WebKit/mac/Configurations/Version.xcconfig;
+my $configFile = ./Source/WebKit/mac/Configurations/Version.xcconfig;
 my $outputDir = ;
 
 GetOptions('config=s' = \$configFile,






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122428] trunk/Source/WebKit2

2012-07-12 Thread carlosgc

Title: [122428] trunk/Source/WebKit2








Revision 122428
Author carlo...@webkit.org
Date 2012-07-12 01:38:16 -0700 (Thu, 12 Jul 2012)


Log Message
[WK2] Performance issue in FindController::findString
https://bugs.webkit.org/show_bug.cgi?id=78132

Patch by Sergio Villar Senin svil...@igalia.com on 2012-07-12
Reviewed by Anders Carlsson.

FindController should not unmark all text matches by default. It
will be done only if the string is not found or if
markAllTextMatches() is called. This will allow clients to look
for the next/previous without having to unmark() + mark() all the
text matches for every single search operation.

* UIProcess/API/gtk/WebKitFindController.cpp:
(webKitFindControllerPerform):
(webkit_find_controller_search_next):
(webkit_find_controller_search_previous):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::findString):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122427 => 122428)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 08:38:08 UTC (rev 122427)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 08:38:16 UTC (rev 122428)
@@ -1,3 +1,24 @@
+2012-07-12  Sergio Villar Senin  svil...@igalia.com
+
+[WK2] Performance issue in FindController::findString
+https://bugs.webkit.org/show_bug.cgi?id=78132
+
+Reviewed by Anders Carlsson.
+
+FindController should not unmark all text matches by default. It
+will be done only if the string is not found or if
+markAllTextMatches() is called. This will allow clients to look
+for the next/previous without having to unmark() + mark() all the
+text matches for every single search operation.
+
+* UIProcess/API/gtk/WebKitFindController.cpp:
+(webKitFindControllerPerform):
+(webkit_find_controller_search_next):
+(webkit_find_controller_search_previous):
+* WebProcess/WebPage/FindController.cpp:
+(WebKit::FindController::updateFindUIAfterPageScroll):
+(WebKit::FindController::findString):
+
 2012-07-12  Christophe Dumez  christophe.du...@intel.com
 
 [WK2][EFL] Add policy client to Ewk_View


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp (122427 => 122428)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp	2012-07-12 08:38:08 UTC (rev 122427)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp	2012-07-12 08:38:16 UTC (rev 122428)
@@ -48,6 +48,7 @@
 
 typedef enum {
 FindOperation,
+FindNextPrevOperation,
 CountOperation
 } WebKitFindControllerOperation;
 
@@ -345,17 +346,22 @@
 WKRetainPtrWKStringRef wkSearchText(AdoptWK, WKStringCreateWithUTF8CString(findController-priv-searchText.data()));
 WKPageRef wkPage = getWKPageFromWebKitWebView(findController-priv-webView);
 
-if (operation == FindOperation) {
-// Unconditionally highlight text matches. WK1 API was forcing
-// clients to enable/disable highlighting. Since most of them
-// (all?) where using highlighting we decided to simplify the
-// WK2 API and unconditionally show highlights.
-wkFindOptions = static_castWKFindOptions(findController-priv-findOptions | kWKFindOptionsShowHighlight);
-WKPageFindString(wkPage, wkSearchText.get(), wkFindOptions, findController-priv-maxMatchCount);
+if (operation == CountOperation) {
+WKPageCountStringMatches(wkPage, wkSearchText.get(), wkFindOptions, findController-priv-maxMatchCount);
 return;
 }
 
-WKPageCountStringMatches(wkPage, wkSearchText.get(), wkFindOptions, findController-priv-maxMatchCount);
+if (operation == FindOperation)
+// Unconditionally highlight text matches when the search
+// starts. WK1 API was forcing clients to enable/disable
+// highlighting. Since most of them (all?) where using that
+// feature we decided to simplify the WK2 API and
+// unconditionally show highlights. Both search_next() and
+// search_prev() should not enable highlighting to avoid an
+// extra unmarkAllTextMatches() + markAllTextMatches()
+wkFindOptions = static_castWKFindOptions(findController-priv-findOptions | kWKFindOptionsShowHighlight);
+
+WKPageFindString(wkPage, wkSearchText.get(), wkFindOptions, findController-priv-maxMatchCount);
 }
 
 static inline void webKitFindControllerSetSearchData(WebKitFindController* findController, const gchar* searchText, guint32 findOptions, guint maxMatchCount)
@@ -415,7 +421,8 @@
 g_return_if_fail(WEBKIT_IS_FIND_CONTROLLER(findController));
 
 findController-priv-findOptions = findController-priv-findOptions  ~WEBKIT_FIND_OPTIONS_BACKWARDS;
-webKitFindControllerPerform(findController, FindOperation);
+

[webkit-changes] [122429] trunk/Source/WebKit2

2012-07-12 Thread carlosgc

Title: [122429] trunk/Source/WebKit2








Revision 122429
Author carlo...@webkit.org
Date 2012-07-12 01:57:32 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed. Fix GTK+ debug build after r122425.

* WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp:
(webkitSoupCookieJarSqliteNew):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122428 => 122429)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 08:38:16 UTC (rev 122428)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 08:57:32 UTC (rev 122429)
@@ -1,3 +1,10 @@
+2012-07-12  Carlos Garcia Campos  cgar...@igalia.com
+
+Unreviewed. Fix GTK+ debug build after r122425.
+
+* WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp:
+(webkitSoupCookieJarSqliteNew):
+
 2012-07-12  Sergio Villar Senin  svil...@igalia.com
 
 [WK2] Performance issue in FindController::findString


Modified: trunk/Source/WebKit2/WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp (122428 => 122429)

--- trunk/Source/WebKit2/WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp	2012-07-12 08:38:16 UTC (rev 122428)
+++ trunk/Source/WebKit2/WebProcess/Cookies/soup/WebKitSoupCookieJarSqlite.cpp	2012-07-12 08:57:32 UTC (rev 122429)
@@ -216,7 +216,7 @@
 
 SoupCookieJar* webkitSoupCookieJarSqliteNew(const String databasePath)
 {
-ASSERT(!priv-databasePath.isEmpty());
+ASSERT(!databasePath.isEmpty());
 WebKitSoupCookieJarSqlite* sqliteJar = WEBKIT_SOUP_COOKIE_JAR_SQLITE(g_object_new(WEBKIT_TYPE_SOUP_COOKIE_JAR_SQLITE, NULL));
 sqliteJar-priv-databasePath = databasePath;
 webkitSoupCookieJarSqliteLoad(sqliteJar);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122430] trunk/Source/WebCore

2012-07-12 Thread yosin

Title: [122430] trunk/Source/WebCore








Revision 122430
Author yo...@chromium.org
Date 2012-07-12 02:00:18 -0700 (Thu, 12 Jul 2012)


Log Message
REGRESSION(r122184): LocaleMac::currentLocale should use current locale rather than newly create locale object.
https://bugs.webkit.org/show_bug.cgi?id=91057

Reviewed by Kent Tamura.

This patch changes NSLocale object of LocaleMac::m_locale variable to
current NSLocale object rather than newly created NSLocale object from
locale identifier.

No new tests. We don't have way to change system preferences from
test scripts and restoring them. To test this patch, we need to do so.

* platform/text/mac/LocaleMac.h:
(LocaleMac): Added a constructor which takes NSLocale object.
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::LocaleMac): Added a constructor which takes NSLocale object.
(WebCore::LocaleMac::currentLocale): Changed to construct LocaleMac object from NSLocale object rather than locale identifier.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/mac/LocaleMac.h
trunk/Source/WebCore/platform/text/mac/LocaleMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (122429 => 122430)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 08:57:32 UTC (rev 122429)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 09:00:18 UTC (rev 122430)
@@ -1,3 +1,23 @@
+2012-07-12  Yoshifumi Inoue  yo...@chromium.org
+
+REGRESSION(r122184): LocaleMac::currentLocale should use current locale rather than newly create locale object. 
+https://bugs.webkit.org/show_bug.cgi?id=91057
+
+Reviewed by Kent Tamura.
+
+This patch changes NSLocale object of LocaleMac::m_locale variable to
+current NSLocale object rather than newly created NSLocale object from
+locale identifier.
+
+No new tests. We don't have way to change system preferences from
+test scripts and restoring them. To test this patch, we need to do so.
+
+* platform/text/mac/LocaleMac.h:
+(LocaleMac): Added a constructor which takes NSLocale object.
+* platform/text/mac/LocaleMac.mm:
+(WebCore::LocaleMac::LocaleMac): Added a constructor which takes NSLocale object.
+(WebCore::LocaleMac::currentLocale): Changed to construct LocaleMac object from NSLocale object rather than locale identifier.
+
 2012-07-11  Carlos Garcia Campos  cgar...@igalia.com
 
 [GTK] Add webkit_cookie_manager_set_persistent_storage() to WebKit2 GTK+ API


Modified: trunk/Source/WebCore/platform/text/mac/LocaleMac.h (122429 => 122430)

--- trunk/Source/WebCore/platform/text/mac/LocaleMac.h	2012-07-12 08:57:32 UTC (rev 122429)
+++ trunk/Source/WebCore/platform/text/mac/LocaleMac.h	2012-07-12 09:00:18 UTC (rev 122430)
@@ -65,6 +65,7 @@
 #endif
 
 private:
+explicit LocaleMac(NSLocale*);
 explicit LocaleMac(const String);
 NSDateFormatter *createShortDateFormatter();
 


Modified: trunk/Source/WebCore/platform/text/mac/LocaleMac.mm (122429 => 122430)

--- trunk/Source/WebCore/platform/text/mac/LocaleMac.mm	2012-07-12 08:57:32 UTC (rev 122429)
+++ trunk/Source/WebCore/platform/text/mac/LocaleMac.mm	2012-07-12 09:00:18 UTC (rev 122430)
@@ -55,6 +55,11 @@
 return formatter;
 }
 
+LocaleMac::LocaleMac(NSLocale* locale)
+: m_locale(locale)
+{
+}
+
 LocaleMac::LocaleMac(const String localeIdentifier)
 : m_locale([[NSLocale alloc] initWithLocaleIdentifier:localeIdentifier])
 {
@@ -71,7 +76,7 @@
 
 LocaleMac* LocaleMac::currentLocale()
 {
-static LocaleMac* currentLocale = LocaleMac::create([[NSLocale currentLocale] localeIdentifier]).leakPtr();
+static LocaleMac* currentLocale = new LocaleMac([NSLocale currentLocale]);
 return currentLocale;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122432] trunk

2012-07-12 Thread morrita

Title: [122432] trunk








Revision 122432
Author morr...@google.com
Date 2012-07-12 02:11:17 -0700 (Thu, 12 Jul 2012)


Log Message
[Shadow DOM] video with shadow crashes
https://bugs.webkit.org/show_bug.cgi?id=91055

Reviewed by Kent Tamura.

Source/WebCore:

This is similar to Bug 90480, where an undesired renderer is created by
locating an insertion point on the shadow boundary.

This change adds a guard for such case by cheking whether the
source node of each to-be-created renderer comes from the UA shadow
tree, which is allowed to have a renderer.

Test: fast/dom/shadow/insertion-point-video-crash.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::childShouldCreateRenderer): Added a check.
(WebCore::HTMLMediaElement::mediaControls): Added const.
(WebCore::HTMLMediaElement::hasMediaControls): Added const.
* html/HTMLMediaElement.h:
(HTMLMediaElement):

LayoutTests:

* fast/dom/shadow/insertion-point-video-crash-expected.txt: Added.
* fast/dom/shadow/insertion-point-video-crash.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h


Added Paths

trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash-expected.txt
trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122431 => 122432)

--- trunk/LayoutTests/ChangeLog	2012-07-12 09:07:24 UTC (rev 122431)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 09:11:17 UTC (rev 122432)
@@ -1,3 +1,13 @@
+2012-07-12  MORITA Hajime  morr...@google.com
+
+[Shadow DOM] video with shadow crashes
+https://bugs.webkit.org/show_bug.cgi?id=91055
+
+Reviewed by Kent Tamura.
+
+* fast/dom/shadow/insertion-point-video-crash-expected.txt: Added.
+* fast/dom/shadow/insertion-point-video-crash.html: Added.
+
 2012-07-12  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening. Skip new failing test introduced in r122399


Added: trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash-expected.txt (0 => 122432)

--- trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash-expected.txt	2012-07-12 09:11:17 UTC (rev 122432)
@@ -0,0 +1,2 @@
+PASS unless crash
+


Added: trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash.html (0 => 122432)

--- trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/shadow/insertion-point-video-crash.html	2012-07-12 09:11:17 UTC (rev 122432)
@@ -0,0 +1,31 @@
+!DOCTYPE html
+html
+head
+script src=""
+/head
+body
+script
+jsTestIsAsync = true;
+function boom() {
+divNode = document.createElement('div');
+document.documentElement.appendChild(divNode);
+divShadow1 = new WebKitShadowRoot(divNode);
+divShadow2 = new WebKitShadowRoot(divNode);
+
+videoNode = document.createElement('video');
+divShadow2.appendChild(videoNode);
+
+shadowNode = document.createElement('shadow');
+videoNode.appendChild(shadowNode);
+
+text = document.createTextNode('Hello');
+divShadow1.appendChild(text);
+
+testPassed(unless crash);
+finishJSTest();
+}
+
+window._onload_ = boom;
+/script
+/body
+/html


Modified: trunk/Source/WebCore/ChangeLog (122431 => 122432)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 09:07:24 UTC (rev 122431)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 09:11:17 UTC (rev 122432)
@@ -1,3 +1,26 @@
+2012-07-12  MORITA Hajime  morr...@google.com
+
+[Shadow DOM] video with shadow crashes
+https://bugs.webkit.org/show_bug.cgi?id=91055
+
+Reviewed by Kent Tamura.
+
+This is similar to Bug 90480, where an undesired renderer is created by
+locating an insertion point on the shadow boundary.
+
+This change adds a guard for such case by cheking whether the
+source node of each to-be-created renderer comes from the UA shadow
+tree, which is allowed to have a renderer.
+
+Test: fast/dom/shadow/insertion-point-video-crash.html
+
+* html/HTMLMediaElement.cpp:
+(WebCore::HTMLMediaElement::childShouldCreateRenderer): Added a check.
+(WebCore::HTMLMediaElement::mediaControls): Added const.
+(WebCore::HTMLMediaElement::hasMediaControls): Added const.
+* html/HTMLMediaElement.h:
+(HTMLMediaElement):
+
 2012-07-12  Yoshifumi Inoue  yo...@chromium.org
 
 REGRESSION(r122184): LocaleMac::currentLocale should use current locale rather than newly create locale object. 


Modified: trunk/Source/WebCore/html/HTMLMediaElement.cpp (122431 => 122432)

--- trunk/Source/WebCore/html/HTMLMediaElement.cpp	2012-07-12 09:07:24 UTC (rev 122431)
+++ trunk/Source/WebCore/html/HTMLMediaElement.cpp	2012-07-12 09:11:17 UTC (rev 122432)
@@

[webkit-changes] [122435] trunk

2012-07-12 Thread commit-queue

Title: [122435] trunk








Revision 122435
Author commit-qu...@webkit.org
Date 2012-07-12 02:46:55 -0700 (Thu, 12 Jul 2012)


Log Message
[IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
https://bugs.webkit.org/show_bug.cgi?id=90867

Patch by Xingnan Wang xingnan.w...@intel.com on 2012-07-12
Reviewed by Tony Chang.

Source/WebCore:

In the latest W3C spec upperOpen/lowerOpen are set to true in lowerBound()/upperBound(), which
we should keep aligned with.

No new tests - updated storage/indexeddb/keyrange.html to match new behavior.

* Modules/indexeddb/IDBKeyRange.cpp:
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):

LayoutTests:

* storage/indexeddb/keyrange-expected.txt:
* storage/indexeddb/resources/keyrange.js:
(checkLowerBoundKeyRange):
(checkUpperBoundKeyRange):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt
trunk/LayoutTests/storage/indexeddb/resources/keyrange.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (122434 => 122435)

--- trunk/LayoutTests/ChangeLog	2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 09:46:55 UTC (rev 122435)
@@ -1,3 +1,15 @@
+2012-07-12  Xingnan Wang  xingnan.w...@intel.com
+
+[IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()
+https://bugs.webkit.org/show_bug.cgi?id=90867
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/keyrange-expected.txt:
+* storage/indexeddb/resources/keyrange.js:
+(checkLowerBoundKeyRange):
+(checkUpperBoundKeyRange):
+
 2012-07-12  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening. Skip the new failing test.


Modified: trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt (122434 => 122435)

--- trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt	2012-07-12 09:37:29 UTC (rev 122434)
+++ trunk/LayoutTests/storage/indexeddb/keyrange-expected.txt	2012-07-12 09:46:55 UTC (rev 122435)
@@ -43,92 +43,92 @@
 PASS keyRange.lower is 10
 PASS keyRange.lowerOpen is true
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound(11,false)
 PASS keyRange.lower is 11
 PASS keyRange.lowerOpen is false
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound(12,undefined)
 PASS keyRange.lower is 12
 PASS keyRange.lowerOpen is false
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound(10.1,true)
 PASS keyRange.lower is 10.1
 PASS keyRange.lowerOpen is true
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound(11.2,false)
 PASS keyRange.lower is 11.2
 PASS keyRange.lowerOpen is false
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound(12.3,undefined)
 PASS keyRange.lower is 12.3
 PASS keyRange.lowerOpen is false
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound('aa',true)
 PASS keyRange.lower is 'aa'
 PASS keyRange.lowerOpen is true
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound('ab',false)
 PASS keyRange.lower is 'ab'
 PASS keyRange.lowerOpen is false
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.lowerBound('ac',undefined)
 PASS keyRange.lower is 'ac'
 PASS keyRange.lowerOpen is false
 PASS keyRange.upper is null
-PASS keyRange.upperOpen is false
+PASS keyRange.upperOpen is true
 IDBKeyRange.upperBound(20,true)
 PASS keyRange.upper is 20
 PASS keyRange.upperOpen is true
 PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
 IDBKeyRange.upperBound(21,false)
 PASS keyRange.upper is 21
 PASS keyRange.upperOpen is false
 PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
 IDBKeyRange.upperBound(22,undefined)
 PASS keyRange.upper is 22
 PASS keyRange.upperOpen is false
 PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
 IDBKeyRange.upperBound(20.2,true)
 PASS keyRange.upper is 20.2
 PASS keyRange.upperOpen is true
 PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
 IDBKeyRange.upperBound(21.3,false)
 PASS keyRange.upper is 21.3
 PASS keyRange.upperOpen is false
 PASS keyRange.lower is null
-PASS keyRange.lowerOpen is false
+PASS keyRange.lowerOpen is true
 IDBKeyRange.upperBound(22.4,undefined)
 PASS keyRange.upper is 22.4
 PASS keyRange.upperOpen is false
 PASS keyRange.lower is null
-PASS keyRange.lowerOpen

[webkit-changes] [122436] trunk/LayoutTests

2012-07-12 Thread vsevik

Title: [122436] trunk/LayoutTests








Revision 122436
Author vse...@chromium.org
Date 2012-07-12 03:02:54 -0700 (Thu, 12 Jul 2012)


Log Message
REGRESSION(r122327): It made http/tests/inspector/network/network-request-revision-content.html fail on Lion, Qt
https://bugs.webkit.org/show_bug.cgi?id=90979

Reviewed by Pavel Feldman.

* http/tests/inspector/network/network-request-revision-content-expected.txt:
* http/tests/inspector/network/network-request-revision-content.html:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt
trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html
trunk/LayoutTests/platform/qt/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (122435 => 122436)

--- trunk/LayoutTests/ChangeLog	2012-07-12 09:46:55 UTC (rev 122435)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 10:02:54 UTC (rev 122436)
@@ -1,3 +1,14 @@
+2012-07-12  Vsevolod Vlasov  vse...@chromium.org
+
+REGRESSION(r122327): It made http/tests/inspector/network/network-request-revision-content.html fail on Lion, Qt
+https://bugs.webkit.org/show_bug.cgi?id=90979
+
+Reviewed by Pavel Feldman.
+
+* http/tests/inspector/network/network-request-revision-content-expected.txt:
+* http/tests/inspector/network/network-request-revision-content.html:
+* platform/qt/Skipped:
+
 2012-07-12  Xingnan Wang  xingnan.w...@intel.com
 
 [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()


Modified: trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt (122435 => 122436)

--- trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt	2012-07-12 09:46:55 UTC (rev 122435)
+++ trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content-expected.txt	2012-07-12 10:02:54 UTC (rev 122436)
@@ -1,7 +1,6 @@
-CONSOLE MESSAGE: line 1: Done.
 Tests how revision requests content if original content was not loaded yet.
 
 Bug 63631
-http://127.0.0.1:8000/inspector/network/resources/script.js
+http://127.0.0.1:8000/inspector/network/resource/style.css
 
 


Modified: trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html (122435 => 122436)

--- trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html	2012-07-12 09:46:55 UTC (rev 122435)
+++ trunk/LayoutTests/http/tests/inspector/network/network-request-revision-content.html	2012-07-12 10:02:54 UTC (rev 122436)
@@ -2,24 +2,28 @@
 head
 script src=""
 script
-function loadScript()
+function loadStylesheet()
 {
-var js = document.createElement(script);
-js.src = ""
-document.head.appendChild(js);
+var css = document.createElement(link);
+css.rel = stylesheet;
+css.type = text/css;
+css.href = ""
+document.head.appendChild(css);
 }
 
 function test()
 {
 InspectorTest.addConsoleSniffer(step2, true);
-InspectorTest.evaluateInPage(loadScript());
+InspectorTest.addSniffer(WebInspector.StylesUISourceCodeProvider.prototype, _resourceAdded, true);
+InspectorTest.evaluateInPage(loadStylesheet());
 
 var resource;
-function step2(msg)
+function step2(event)
 {
 var request = WebInspector.panels.network.requests[WebInspector.panels.network.requests.length - 1];
 uiSourceCode = WebInspector.workspace.uiSourceCodeForURL(request.url);
-resource = WebInspector.resourceForURL(request.url);
+if (!uiSourceCode)
+return;
 uiSourceCode.addRevision();
 uiSourceCode.history[0].requestContent(step3);
 }


Modified: trunk/LayoutTests/platform/qt/Skipped (122435 => 122436)

--- trunk/LayoutTests/platform/qt/Skipped	2012-07-12 09:46:55 UTC (rev 122435)
+++ trunk/LayoutTests/platform/qt/Skipped	2012-07-12 10:02:54 UTC (rev 122436)
@@ -695,10 +695,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=87208
 http/tests/cookies/js-get-and-set-http-only-cookie.html
 
-# REGRESSION(r122327): It made http/tests/inspector/network/network-request-revision-content.html fail on Lion, Qt
-# https://bugs.webkit.org/show_bug.cgi?id=90979
-http/tests/inspector/network/network-request-revision-content.html
-
 # === #
 #   Failing xmlhttprequest tests  #
 # === #






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122437] trunk/LayoutTests

2012-07-12 Thread caseq

Title: [122437] trunk/LayoutTests








Revision 122437
Author ca...@chromium.org
Date 2012-07-12 03:04:31 -0700 (Thu, 12 Jul 2012)


Log Message
Layout Test inspector/timeline/timeline-dom-content-loaded-event.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90984

Reviewed by Vsevolod Vlasov.

- remove test flakiness by only outputting result when page completed reload;

* inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
* inspector/timeline/timeline-dom-content-loaded-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt
trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122436 => 122437)

--- trunk/LayoutTests/ChangeLog	2012-07-12 10:02:54 UTC (rev 122436)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 10:04:31 UTC (rev 122437)
@@ -1,3 +1,15 @@
+2012-07-11  Andrey Kosyakov  ca...@chromium.org
+
+Layout Test inspector/timeline/timeline-dom-content-loaded-event.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=90984
+
+Reviewed by Vsevolod Vlasov.
+
+- remove test flakiness by only outputting result when page completed reload;
+
+* inspector/timeline/timeline-dom-content-loaded-event-expected.txt:
+* inspector/timeline/timeline-dom-content-loaded-event.html:
+
 2012-07-12  Vsevolod Vlasov  vse...@chromium.org
 
 REGRESSION(r122327): It made http/tests/inspector/network/network-request-revision-content.html fail on Lion, Qt


Modified: trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt (122436 => 122437)

--- trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt	2012-07-12 10:02:54 UTC (rev 122436)
+++ trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event-expected.txt	2012-07-12 10:04:31 UTC (rev 122437)
@@ -1,5 +1,6 @@
 Tests the DOM content loaded event.
 
+Page reloaded.
 MarkDOMContent Properties:
 {
 startTime : number
@@ -11,5 +12,4 @@
 totalHeapSize : number
 counters : object
 }
-Page reloaded.
 


Modified: trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html (122436 => 122437)

--- trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html	2012-07-12 10:02:54 UTC (rev 122436)
+++ trunk/LayoutTests/inspector/timeline/timeline-dom-content-loaded-event.html	2012-07-12 10:04:31 UTC (rev 122437)
@@ -14,14 +14,15 @@
 
 function contentEvent()
 {
-InspectorTest.printTimelineRecords(MarkDOMContent);
 InspectorTest.stopTimeline(finish);
 }
 
 function finish()
 {
-if (++finishCalled === 2)
-InspectorTest.completeTest();
+if (++finishCalled  2)
+return;
+InspectorTest.printTimelineRecords(MarkDOMContent);
+InspectorTest.completeTest();
 }
 }
 


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122436 => 122437)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 10:02:54 UTC (rev 122436)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 10:04:31 UTC (rev 122437)
@@ -3744,9 +3744,5 @@
 BUGWK90980 LINUX MAC DEBUG : fast/forms/textarea/textarea-state-restore.html = PASS TIMEOUT
 BUGWK90980 WIN : fast/forms/textarea/textarea-state-restore.html = PASS TIMEOUT
 
-// Started failing after r122312
-BUGWK91041 LINUX WIN : inspector/timeline/timeline-dom-content-loaded-event.html = TEXT
-BUGWK91041 MAC : inspector/timeline/timeline-dom-content-loaded-event.html = TIMEOUT
-
 // Started crashing after r122359
 BUGWK91047 DEBUG : html5lib/runner.html = CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122438] trunk/Source/WebKit2

2012-07-12 Thread abecsi

Title: [122438] trunk/Source/WebKit2








Revision 122438
Author abe...@webkit.org
Date 2012-07-12 03:04:42 -0700 (Thu, 12 Jul 2012)


Log Message
[Qt][WK2] ASSERT: !m_viewportItem-isMoving() in QtViewportHandler::flickMoveEnded()
https://bugs.webkit.org/show_bug.cgi?id=90875

Reviewed by Kenneth Rohde Christiansen.

Since MultiPointTouchArea and PinchArea use the childMouseEventFilter
method to filter touch events and because Flickable filters child mouse
events the canvas calls this function before propagating the touch event
to the WebView. Since Flickable does not accept touch events the canvas
tries to propagate a synthesized mouse event through the base class
childMouseEventFilter function which is accepted by Flickable and
interferes with the input events we send to Flicakble hence messes up
the internal state of the WebView.
This patch reimplements the virtual childMouseEventFilter method so that all
the mouse and touch events can be processed by WebKit before they arrive to
Flickable.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::childMouseEventFilter):
* UIProcess/API/qt/qquickwebview_p.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageEventHandler.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122437 => 122438)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 10:04:31 UTC (rev 122437)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 10:04:42 UTC (rev 122438)
@@ -1,3 +1,26 @@
+2012-07-11  Andras Becsi  andras.be...@nokia.com
+
+[Qt][WK2] ASSERT: !m_viewportItem-isMoving() in QtViewportHandler::flickMoveEnded()
+https://bugs.webkit.org/show_bug.cgi?id=90875
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Since MultiPointTouchArea and PinchArea use the childMouseEventFilter
+method to filter touch events and because Flickable filters child mouse
+events the canvas calls this function before propagating the touch event
+to the WebView. Since Flickable does not accept touch events the canvas
+tries to propagate a synthesized mouse event through the base class
+childMouseEventFilter function which is accepted by Flickable and
+interferes with the input events we send to Flicakble hence messes up
+the internal state of the WebView.
+This patch reimplements the virtual childMouseEventFilter method so that all
+the mouse and touch events can be processed by WebKit before they arrive to
+Flickable.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebView::childMouseEventFilter):
+* UIProcess/API/qt/qquickwebview_p.h:
+
 2012-07-12  Carlos Garcia Campos  cgar...@igalia.com
 
 Unreviewed. Fix GTK+ debug build after r122425.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (122437 => 122438)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-07-12 10:04:31 UTC (rev 122437)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-07-12 10:04:42 UTC (rev 122438)
@@ -1655,6 +1655,38 @@
 WTF::initializeMainThread();
 }
 
+bool QQuickWebView::childMouseEventFilter(QQuickItem* item, QEvent* event)
+{
+if (!isVisible() || !isEnabled() || !s_flickableViewportEnabled)
+return QQuickFlickable::childMouseEventFilter(item, event);
+
+// This function is used by MultiPointTouchArea and PinchArea to filter
+// touch events, thus to hinder the canvas from sending synthesized
+// mouse events to the Flickable implementation we need to reimplement
+// childMouseEventFilter and filter incoming touch events as well.
+
+switch (event-type()) {
+case QEvent::MouseButtonPress:
+mousePressEvent(static_castQMouseEvent*(event));
+return event-isAccepted();
+case QEvent::MouseMove:
+mouseMoveEvent(static_castQMouseEvent*(event));
+return event-isAccepted();
+case QEvent::MouseButtonRelease:
+mouseReleaseEvent(static_castQMouseEvent*(event));
+return event-isAccepted();
+case QEvent::TouchBegin:
+case QEvent::TouchUpdate:
+case QEvent::TouchEnd:
+touchEvent(static_castQTouchEvent*(event));
+return event-isAccepted();
+default:
+break;
+}
+
+return QQuickFlickable::childMouseEventFilter(item, event);
+}
+
 void QQuickWebView::geometryChanged(const QRectF newGeometry, const QRectF oldGeometry)
 {
 Q_D(QQuickWebView);


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h (122437 => 122438)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2012-07-12 10:04:31 UTC (rev 122437)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h	2012-07-12 10:04:42 UTC (rev 122438)
@@ -168,6 +168,7 @@
 void navigationRequested(QWebNavigationRequest* request);
 
 protected:
+virtual bool childMouseEventFilter(QQuickItem*,

[webkit-changes] [122439] trunk/LayoutTests

2012-07-12 Thread commit-queue

Title: [122439] trunk/LayoutTests








Revision 122439
Author commit-qu...@webkit.org
Date 2012-07-12 03:08:50 -0700 (Thu, 12 Jul 2012)


Log Message
[GTK] Gardening: rebaseline after r122414
https://bugs.webkit.org/show_bug.cgi?id=91064

Unreviewed gardening. Add new baseline after r122414
for fast/forms/state-restore-skip-stateless.html

Patch by Simon Pena sp...@igalia.com on 2012-07-12

* platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (122438 => 122439)

--- trunk/LayoutTests/ChangeLog	2012-07-12 10:04:42 UTC (rev 122438)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 10:08:50 UTC (rev 122439)
@@ -1,3 +1,13 @@
+2012-07-12  Simon Pena  sp...@igalia.com
+
+[GTK] Gardening: rebaseline after r122414
+https://bugs.webkit.org/show_bug.cgi?id=91064
+
+Unreviewed gardening. Add new baseline after r122414
+for fast/forms/state-restore-skip-stateless.html
+
+* platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt: Added.
+
 2012-07-11  Andrey Kosyakov  ca...@chromium.org
 
 Layout Test inspector/timeline/timeline-dom-content-loaded-event.html is failing


Added: trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt (0 => 122439)

--- trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt	2012-07-12 10:08:50 UTC (rev 122439)
@@ -0,0 +1,28 @@
+CONSOLE MESSAGE: line 44: Test if state of stateless form control types are not saved.
+CONSOLE MESSAGE: line 8: Form state vector:
+CONSOLE MESSAGE: line 8: name02, hidden, No owner, 0, 
+CONSOLE MESSAGE: line 8: name03, text, No owner, 0, 
+CONSOLE MESSAGE: line 8: name04, tel, No owner, 0, 
+CONSOLE MESSAGE: line 8: name05, url, No owner, 0, 
+CONSOLE MESSAGE: line 8: name06, email, No owner, 0, 
+CONSOLE MESSAGE: line 8: name07, text, No owner, 0, 
+CONSOLE MESSAGE: line 8: name14, number, No owner, 0, 
+CONSOLE MESSAGE: line 8: name15, range, No owner, 1, 
+CONSOLE MESSAGE: line 8: 50, name17, checkbox, No owner, 
+CONSOLE MESSAGE: line 8: 1, off, name18, radio, 
+CONSOLE MESSAGE: line 8: No owner, 1, off, name19, 
+CONSOLE MESSAGE: line 8: file, No owner, 0, , 
+CONSOLE MESSAGE: line 8: button, No owner, 0, name20, 
+CONSOLE MESSAGE: line 8: submit, No owner, 0, name21, 
+CONSOLE MESSAGE: line 8: reset, No owner, 0, name22, 
+CONSOLE MESSAGE: line 8: button, No owner, 0, name26, 
+CONSOLE MESSAGE: line 8: select-one, No owner, 0, name27, 
+CONSOLE MESSAGE: line 8: select-multiple, No owner, 0, name28, 
+CONSOLE MESSAGE: line 8: textarea, No owner, 0, name29, 
+CONSOLE MESSAGE: line 8: keygen, No owner, 0, , 
+CONSOLE MESSAGE: line 13: select-one, No owner, 0, 
+CONSOLE MESSAGE: line 14: 
+PASS successfullyParsed is true
+
+TEST COMPLETE
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122440] trunk/Tools

2012-07-12 Thread commit-queue

Title: [122440] trunk/Tools








Revision 122440
Author commit-qu...@webkit.org
Date 2012-07-12 03:29:53 -0700 (Thu, 12 Jul 2012)


Log Message
[Qt] Internal symbols are exported on Linux
https://bugs.webkit.org/show_bug.cgi?id=90981

Patch by Simon Hausmann simon.hausm...@nokia.com on 2012-07-12
Reviewed by Jocelyn Turcotte.

I should've re-enabled ELF symbol visibility when removing the symbol map in
r106650.

* qmake/mkspecs/features/default_post.prf:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/default_post.prf




Diff

Modified: trunk/Tools/ChangeLog (122439 => 122440)

--- trunk/Tools/ChangeLog	2012-07-12 10:08:50 UTC (rev 122439)
+++ trunk/Tools/ChangeLog	2012-07-12 10:29:53 UTC (rev 122440)
@@ -1,3 +1,15 @@
+2012-07-12  Simon Hausmann  simon.hausm...@nokia.com
+
+[Qt] Internal symbols are exported on Linux
+https://bugs.webkit.org/show_bug.cgi?id=90981
+
+Reviewed by Jocelyn Turcotte.
+
+I should've re-enabled ELF symbol visibility when removing the symbol map in
+r106650.
+
+* qmake/mkspecs/features/default_post.prf:
+
 2012-07-11  Mark Rowe  mr...@apple.com
 
 http://webkit.org/b/91024 Build against the latest SDK when targeting older OS X versions.


Modified: trunk/Tools/qmake/mkspecs/features/default_post.prf (122439 => 122440)

--- trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-07-12 10:08:50 UTC (rev 122439)
+++ trunk/Tools/qmake/mkspecs/features/default_post.prf	2012-07-12 10:29:53 UTC (rev 122440)
@@ -140,7 +140,7 @@
 win32-msvc*|win32-icc: INCLUDEPATH += $$ROOT_WEBKIT_DIR/Source/_javascript_Core/os-win32
 
 !plugin {
-!linux-g++*:!linux-icc*:contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
+contains(QT_CONFIG, reduce_exports):CONFIG += hide_symbols
 unix:contains(QT_CONFIG, reduce_relocations):CONFIG += bsymbolic_functions
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122441] trunk/LayoutTests

2012-07-12 Thread commit-queue

Title: [122441] trunk/LayoutTests








Revision 122441
Author commit-qu...@webkit.org
Date 2012-07-12 03:44:04 -0700 (Thu, 12 Jul 2012)


Log Message
[GTK] Rebaseline after 122416 and r122408
https://bugs.webkit.org/show_bug.cgi?id=91066

Unreviewed gardening.

Rebaseline fast/multicol/table-vertical-align.html
after r122416 (which updated results missing after the fix
from r122408)

Patch by Simon Pena sp...@igalia.com on 2012-07-12

* platform/gtk/fast/multicol/table-vertical-align-expected.png:
* platform/gtk/fast/multicol/table-vertical-align-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.png
trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (122440 => 122441)

--- trunk/LayoutTests/ChangeLog	2012-07-12 10:29:53 UTC (rev 122440)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 10:44:04 UTC (rev 122441)
@@ -1,5 +1,19 @@
 2012-07-12  Simon Pena  sp...@igalia.com
 
+[GTK] Rebaseline after 122416 and r122408
+https://bugs.webkit.org/show_bug.cgi?id=91066
+
+Unreviewed gardening.
+
+Rebaseline fast/multicol/table-vertical-align.html
+after r122416 (which updated results missing after the fix
+from r122408)
+
+* platform/gtk/fast/multicol/table-vertical-align-expected.png:
+* platform/gtk/fast/multicol/table-vertical-align-expected.txt:
+
+2012-07-12  Simon Pena  sp...@igalia.com
+
 [GTK] Gardening: rebaseline after r122414
 https://bugs.webkit.org/show_bug.cgi?id=91064
 


Modified: trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt (122440 => 122441)

--- trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt	2012-07-12 10:29:53 UTC (rev 122440)
+++ trunk/LayoutTests/platform/gtk/fast/multicol/table-vertical-align-expected.txt	2012-07-12 10:44:04 UTC (rev 122441)
@@ -141,7 +141,7 @@
 RenderTable {TABLE} at (0,0) size 376x1166 [border: (1px outset #808080)]
   RenderTableSection {TBODY} at (1,1) size 374x1164
 RenderTableRow {TR} at (0,0) size 374x1127
-  RenderTableCell {TD} at (0,0) size 140x1127 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+  RenderTableCell {TD} at (0,0) size 140x1164 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
 RenderText {#text} at (11,11) size 105x37
   text run at (11,11) width 105: This cell has lots
   text run at (11,29) width 44: of text.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122444] trunk/Source

2012-07-12 Thread commit-queue

Title: [122444] trunk/Source








Revision 122444
Author commit-qu...@webkit.org
Date 2012-07-12 04:18:05 -0700 (Thu, 12 Jul 2012)


Log Message
[BlackBerry] Cannot use digest proxy auth and NTLM auth at the same time
https://bugs.webkit.org/show_bug.cgi?id=91054

Patch by Jonathan Dong jonathan.d...@torchmobile.com.cn on 2012-07-12
Reviewed by George Staikos.

Source/WebCore:

Added an interface function syncProxyCredential() in class
PageClientBlackBerry, which is responsible to notify WebPageClient
to synchronize proxy credential to the chrome process.

Internally reviewed by Jason Liu jason@torchmobile.com.cn

No new tests since there's no functional change.

* platform/blackberry/PageClientBlackBerry.h:
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::storeCredentials): Remember the accepted proxy
credential and notify webpage client to synchronize it.

Source/WebKit/blackberry:

Implemented interface function syncProxyCredential() derived
from class PageClientBlackBerry.

Internally reviewed by Jason Liu jason@torchmobile.com.cn

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::syncProxyCredential):
(WebKit):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h
trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/Api/WebPageClient.h
trunk/Source/WebKit/blackberry/Api/WebPage_p.h
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (122443 => 122444)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 11:16:21 UTC (rev 122443)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 11:18:05 UTC (rev 122444)
@@ -1,3 +1,23 @@
+2012-07-12  Jonathan Dong  jonathan.d...@torchmobile.com.cn
+
+[BlackBerry] Cannot use digest proxy auth and NTLM auth at the same time
+https://bugs.webkit.org/show_bug.cgi?id=91054
+
+Reviewed by George Staikos.
+
+Added an interface function syncProxyCredential() in class
+PageClientBlackBerry, which is responsible to notify WebPageClient
+to synchronize proxy credential to the chrome process.
+
+Internally reviewed by Jason Liu jason@torchmobile.com.cn
+
+No new tests since there's no functional change.
+
+* platform/blackberry/PageClientBlackBerry.h:
+* platform/network/blackberry/NetworkJob.cpp:
+(WebCore::NetworkJob::storeCredentials): Remember the accepted proxy
+credential and notify webpage client to synchronize it.
+
 2012-07-12  Xingnan Wang  xingnan.w...@intel.com
 
 [IndexedDB] upperOpen set to true in lowerBound()/lowerOpen set to true in upperBound()


Modified: trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h (122443 => 122444)

--- trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h	2012-07-12 11:16:21 UTC (rev 122443)
+++ trunk/Source/WebCore/platform/blackberry/PageClientBlackBerry.h	2012-07-12 11:18:05 UTC (rev 122444)
@@ -72,6 +72,7 @@
 virtual bool isVisible() const = 0;
 virtual bool authenticationChallenge(const WebCore::KURL, const WebCore::ProtectionSpace, WebCore::Credential) = 0;
 virtual SaveCredentialType notifyShouldSaveCredential(bool) = 0;
+virtual void syncProxyCredential(const WebCore::Credential) = 0;
 };
 
 #endif // PageClientBlackBerry_h


Modified: trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp (122443 => 122444)

--- trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-07-12 11:16:21 UTC (rev 122443)
+++ trunk/Source/WebCore/platform/network/blackberry/NetworkJob.cpp	2012-07-12 11:18:05 UTC (rev 122444)
@@ -800,6 +800,12 @@
 
 CredentialStorage::set(challenge.proposedCredential(), challenge.protectionSpace(), m_response.url());
 challenge.setStored(true);
+
+if (challenge.protectionSpace().serverType() == ProtectionSpaceProxyHTTP) {
+BlackBerry::Platform::Client::get()-setProxyCredential(challenge.proposedCredential().user().utf8().data(),
+challenge.proposedCredential().password().utf8().data());
+m_frame-page()-chrome()-client()-platformPageClient()-syncProxyCredential(challenge.proposedCredential());
+}
 }
 
 void NetworkJob::purgeCredentials()


Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (122443 => 122444)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-07-12 11:16:21 UTC (rev 122443)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-07-12 11:18:05 UTC (rev 122444)
@@ -2343,6 +2343,11 @@
 return static_castPageClientBlackBerry::SaveCredentialType(m_client-notifyShouldSaveCredential(isNew));
 }
 
+void WebPagePrivate::syncProxyCredential(const WebCore::Credential credential)
+{
+m_client-syncProxyCredential(credential.user().utf8().data(),

[webkit-changes] [122446] trunk/Source/WebCore

2012-07-12 Thread antti

Title: [122446] trunk/Source/WebCore








Revision 122446
Author an...@apple.com
Date 2012-07-12 04:41:20 -0700 (Thu, 12 Jul 2012)


Log Message
Failure to dispatch didFinishLoadForFrame if font load fails synchronously 
https://bugs.webkit.org/show_bug.cgi?id=91018

Reviewed by Enrica Casucci.

New font loads may be triggered by layout after the document load is complete but before we have dispatched
didFinishLoading for the frame. If the load fails synchronously we might fail to ever invoke 
FrameLoader::checkLoadComplete and so fail to dispatch didFinishLoading.

Make sure this doesn't happen by calling FrameLoader::checkLoadComplete explicitly after triggering font loads.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSFontSelector.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122445 => 122446)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 11:26:27 UTC (rev 122445)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 11:41:20 UTC (rev 122446)
@@ -1,3 +1,19 @@
+2012-07-11  Antti Koivisto  an...@apple.com
+
+Failure to dispatch didFinishLoadForFrame if font load fails synchronously 
+https://bugs.webkit.org/show_bug.cgi?id=91018
+
+Reviewed by Enrica Casucci.
+
+New font loads may be triggered by layout after the document load is complete but before we have dispatched
+didFinishLoading for the frame. If the load fails synchronously we might fail to ever invoke 
+FrameLoader::checkLoadComplete and so fail to dispatch didFinishLoading.
+
+Make sure this doesn't happen by calling FrameLoader::checkLoadComplete explicitly after triggering font loads.
+
+* css/CSSFontSelector.cpp:
+(WebCore::CSSFontSelector::beginLoadTimerFired):
+
 2012-07-12  Gyuyoung Kim  gyuyoung@samsung.com
 
 Register protocol handler files should be in Modules/protocolhandler


Modified: trunk/Source/WebCore/css/CSSFontSelector.cpp (122445 => 122446)

--- trunk/Source/WebCore/css/CSSFontSelector.cpp	2012-07-12 11:26:27 UTC (rev 122445)
+++ trunk/Source/WebCore/css/CSSFontSelector.cpp	2012-07-12 11:41:20 UTC (rev 122446)
@@ -586,6 +586,10 @@
 }
 // Ensure that if the request count reaches zero, the frame loader will know about it.
 cachedResourceLoader-loadDone();
+// New font loads may be triggered by layout after the document load is complete but before we have dispatched
+// didFinishLoading for the frame. Make sure the delegate is always dispatched by checking explicitly.
+if (m_document  m_document-frame())
+m_document-frame()-loader()-checkLoadComplete();
 }
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122447] trunk/Source/WebCore

2012-07-12 Thread morrita

Title: [122447] trunk/Source/WebCore








Revision 122447
Author morr...@google.com
Date 2012-07-12 04:54:26 -0700 (Thu, 12 Jul 2012)


Log Message
Typo: ParentTranversalDetails should be ParentTraversalDetails
https://bugs.webkit.org/show_bug.cgi?id=91059

Reviewed by Andreas Kling.

Did a bare rename from ParentTranversalDetails to ParentTraversalDetails

No new tests, just a rename.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseInsertionPoint):
(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseShadowRoot):
(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didFindNode):
(WebCore::ComposedShadowTreeWalker::findParent):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
* dom/ComposedShadowTreeWalker.h:
(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::ParentTraversalDetails):
(ComposedShadowTreeWalker):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp
trunk/Source/WebCore/dom/ComposedShadowTreeWalker.h
trunk/Source/WebCore/dom/NodeRenderingContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (122446 => 122447)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 11:41:20 UTC (rev 122446)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 11:54:26 UTC (rev 122447)
@@ -1,3 +1,29 @@
+2012-07-12  MORITA Hajime  morr...@google.com
+
+Typo: ParentTranversalDetails should be ParentTraversalDetails
+https://bugs.webkit.org/show_bug.cgi?id=91059
+
+Reviewed by Andreas Kling.
+
+Did a bare rename from ParentTranversalDetails to ParentTraversalDetails
+
+No new tests, just a rename.
+
+* dom/ComposedShadowTreeWalker.cpp:
+(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseInsertionPoint):
+(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseShadowRoot):
+(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::didFindNode):
+(WebCore::ComposedShadowTreeWalker::findParent):
+(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
+(WebCore::ComposedShadowTreeWalker::traverseParent):
+(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
+(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
+* dom/ComposedShadowTreeWalker.h:
+(WebCore::ComposedShadowTreeWalker::ParentTraversalDetails::ParentTraversalDetails):
+(ComposedShadowTreeWalker):
+* dom/NodeRenderingContext.h:
+(NodeRenderingContext):
+
 2012-07-11  Antti Koivisto  an...@apple.com
 
 Failure to dispatch didFinishLoadForFrame if font load fails synchronously 


Modified: trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp (122446 => 122447)

--- trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp	2012-07-12 11:41:20 UTC (rev 122446)
+++ trunk/Source/WebCore/dom/ComposedShadowTreeWalker.cpp	2012-07-12 11:54:26 UTC (rev 122447)
@@ -51,18 +51,18 @@
 return 0;
 }
 
-inline void ComposedShadowTreeWalker::ParentTranversalDetails::didTraverseInsertionPoint(InsertionPoint* insertionPoint)
+inline void ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseInsertionPoint(InsertionPoint* insertionPoint)
 {
 if (!m_insertionPoint)
 m_insertionPoint = insertionPoint;
 }
 
-inline void ComposedShadowTreeWalker::ParentTranversalDetails::didTraverseShadowRoot(const ShadowRoot* root)
+inline void ComposedShadowTreeWalker::ParentTraversalDetails::didTraverseShadowRoot(const ShadowRoot* root)
 {
 m_resetStyleInheritance  = m_resetStyleInheritance || root-resetStyleInheritance();
 }
 
-inline void ComposedShadowTreeWalker::ParentTranversalDetails::didFindNode(ContainerNode* node)
+inline void ComposedShadowTreeWalker::ParentTraversalDetails::didFindNode(ContainerNode* node)
 {
 if (!m_outOfComposition)
 m_node = node;
@@ -75,7 +75,7 @@
 return walker;
 }
 
-void ComposedShadowTreeWalker::findParent(const Node* node, ParentTranversalDetails* details)
+void ComposedShadowTreeWalker::findParent(const Node* node, ParentTraversalDetails* details)
 {
 ComposedShadowTreeWalker walker(node, CrossUpperBoundary, CanStartFromShadowBoundary);
 ContainerNode* found = toContainerNode(walker.traverseParent(walker.get(), details));
@@ -203,7 +203,7 @@
 return 0;
 }
 
-inline Node* ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents(const Node* node, ParentTranversalDetails* details) const
+inline Node* ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents(const Node* node, ParentTraversalDetails* details) const
 {
 ASSERT(node);

[webkit-changes] [122448] trunk/LayoutTests

2012-07-12 Thread zandobersek

Title: [122448] trunk/LayoutTests








Revision 122448
Author zandober...@gmail.com
Date 2012-07-12 05:05:28 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed GTK gardening, fixing a typo in test's filename in TestExpectations.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122447 => 122448)

--- trunk/LayoutTests/ChangeLog	2012-07-12 11:54:26 UTC (rev 122447)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 12:05:28 UTC (rev 122448)
@@ -1,3 +1,9 @@
+2012-07-12  Zan Dobersek  zandober...@gmail.com
+
+Unreviewed GTK gardening, fixing a typo in test's filename in TestExpectations.
+
+* platform/gtk/TestExpectations:
+
 2012-07-12  Ádám Kallai  ka...@inf.u-szeged.hu
 
 [Qt] Unreviewed gardening.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (122447 => 122448)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-12 11:54:26 UTC (rev 122447)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-12 12:05:28 UTC (rev 122448)
@@ -1252,7 +1252,7 @@
 
 BUGWK89231 : fast/js/global-constructors.html = TEXT
 
-BUGWK91009 DEBUG : fast/xsl/xslt-missing-namespace-in-xsl.xml = TEXT
+BUGWK91009 DEBUG : fast/xsl/xslt-missing-namespace-in-xslt.xml = TEXT
 
 //
 // End of Tests failing






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122449] trunk

2012-07-12 Thread fmalita

Title: [122449] trunk








Revision 122449
Author fmal...@chromium.org
Date 2012-07-12 05:26:03 -0700 (Thu, 12 Jul 2012)


Log Message
Incorrect handling of chained pending resources in SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=89686

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Currently SVGUseElement builds the shadow tree when the target first
becomes available. This is normally OK, but if the target itself (or
one of its children) is a use element with pending resources, then
the shadow expansion only captures the current state of the tree and
never gets updated when the pending resource becomes available.

In order to support arbitrary use-on-use constructs, this patch
tracks nested use dependencies and rebuilds the dependent trees
whenever the target gets updated.

Tests: svg/custom/use-nested-expected.svg
   svg/custom/use-nested.svg

* svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom): removedFrom needs to be called up the inheritance chain
before invoking removeAllElementReferencesForTarget. Otherwise we could end up finding the
element being removed as a valid target in SVGUseElement::buildInstanceTree because its
InDocument flag is not cleared yet.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::~SVGUseElement):
(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::buildInstanceTree):
* svg/SVGUseElement.h:
(SVGUseElement):
Track use - use dependencies using SVGDocumentExtensions'
m_elementDependencies framework and ensure dependent trees are rebuilt
when the target itself gets rebuilt.

LayoutTests:

Added reftest to verify that nested/indirect use constructs are
handled correctly WRT pending resource tracking.

Also updated the svg/hixie/error/017-expected.txt to match the current
results. Per comments in SVGUseElement::buildShadowAndInstanceTree, the
new behavior is correct: use cycles are to be ignored.

* platform/chromium-win/svg/hixie/error/017-expected.txt:
* platform/efl/svg/hixie/error/017-expected.txt:
* platform/gtk/svg/hixie/error/017-expected.txt:
* platform/mac/svg/hixie/error/017-expected.txt:
* platform/qt/svg/hixie/error/017-expected.txt:
* svg/custom/use-nested-expected.svg: Added.
* svg/custom/use-nested.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/efl/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/gtk/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/mac/svg/hixie/error/017-expected.txt
trunk/LayoutTests/platform/qt/svg/hixie/error/017-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/svg/SVGElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.cpp
trunk/Source/WebCore/svg/SVGUseElement.h


Added Paths

trunk/LayoutTests/svg/custom/use-nested-expected.svg
trunk/LayoutTests/svg/custom/use-nested.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (122448 => 122449)

--- trunk/LayoutTests/ChangeLog	2012-07-12 12:05:28 UTC (rev 122448)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 12:26:03 UTC (rev 122449)
@@ -1,3 +1,25 @@
+2012-07-12  Florin Malita  fmal...@chromium.org
+
+Incorrect handling of chained pending resources in SVGUseElement
+https://bugs.webkit.org/show_bug.cgi?id=89686
+
+Reviewed by Nikolas Zimmermann.
+
+Added reftest to verify that nested/indirect use constructs are
+handled correctly WRT pending resource tracking.
+
+Also updated the svg/hixie/error/017-expected.txt to match the current
+results. Per comments in SVGUseElement::buildShadowAndInstanceTree, the
+new behavior is correct: use cycles are to be ignored.
+
+* platform/chromium-win/svg/hixie/error/017-expected.txt:
+* platform/efl/svg/hixie/error/017-expected.txt:
+* platform/gtk/svg/hixie/error/017-expected.txt:
+* platform/mac/svg/hixie/error/017-expected.txt:
+* platform/qt/svg/hixie/error/017-expected.txt:
+* svg/custom/use-nested-expected.svg: Added.
+* svg/custom/use-nested.svg: Added.
+
 2012-07-12  Zan Dobersek  zandober...@gmail.com
 
 Unreviewed GTK gardening, fixing a typo in test's filename in TestExpectations.


Modified: trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt (122448 => 122449)

--- trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt	2012-07-12 12:05:28 UTC (rev 122448)
+++ trunk/LayoutTests/platform/chromium-win/svg/hixie/error/017-expected.txt	2012-07-12 12:26:03 UTC (rev 122449)
@@ -5,12 +5,8 @@
 RenderSVGHiddenContainer {defs} at (0,0) size 0x0
   RenderSVGContainer {g} at (0,0) size 0x0
 RenderSVGContainer {use} at (0,0) size 0x0
-  RenderSVGContainer {g} at (0,0) size 0x0
-RenderSVGContainer {g} at (0,0) size 0x0
   RenderSVGContainer {g} at (0,0) size 0x0

[webkit-changes] [122452] trunk/Source/WebKit2

2012-07-12 Thread commit-queue

Title: [122452] trunk/Source/WebKit2








Revision 122452
Author commit-qu...@webkit.org
Date 2012-07-12 06:39:22 -0700 (Thu, 12 Jul 2012)


Log Message
[EFL] [WK2] regression(r122411) Crashes in Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=91068

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-12
Reviewed by Kentaro Hara.

Avoid using calloc() to allocate memory for structures
and use new operator instead. calloc() causes unwanted
behavior when allocing a structure which contains
non-pointer types (e.g. a HashMap) and leads to
crashes.

* UIProcess/API/efl/ewk_context.cpp:
(_Ewk_Context::_Ewk_Context):
* UIProcess/API/efl/ewk_intent.cpp:
(_Ewk_Intent):
(_Ewk_Intent::_Ewk_Intent):
(ewk_intent_unref):
(ewk_intent_new):
* UIProcess/API/efl/ewk_intent_service.cpp:
(_Ewk_Intent_Service):
(_Ewk_Intent_Service::_Ewk_Intent_Service):
(ewk_intent_service_unref):
(ewk_intent_service_new):
* UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
(_Ewk_Navigation_Policy_Decision):
(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
(ewk_navigation_policy_decision_free):
(ewk_navigation_policy_decision_new):
* UIProcess/API/efl/ewk_url_request.cpp:
(_Ewk_Url_Request):
(_Ewk_Url_Request::_Ewk_Url_Request):
(ewk_url_request_unref):
(ewk_url_request_new):
* UIProcess/API/efl/ewk_url_response.cpp:
(_Ewk_Url_Response):
(_Ewk_Url_Response::_Ewk_Url_Response):
(ewk_url_response_unref):
(ewk_url_response_new):
* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
* UIProcess/API/efl/ewk_web_error.cpp:
(_Ewk_Web_Error):
(_Ewk_Web_Error::_Ewk_Web_Error):
(ewk_web_error_free):
(ewk_web_error_new):
* UIProcess/API/efl/ewk_web_resource.cpp:
(_Ewk_Web_Resource):
(_Ewk_Web_Resource::_Ewk_Web_Resource):
(ewk_web_resource_unref):
(ewk_web_resource_new):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_intent.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_intent_service.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_navigation_policy_decision.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_request.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_url_response.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_view.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_error.cpp
trunk/Source/WebKit2/UIProcess/API/efl/ewk_web_resource.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122451 => 122452)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 13:32:42 UTC (rev 122451)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 13:39:22 UTC (rev 122452)
@@ -1,3 +1,59 @@
+2012-07-12  Christophe Dumez  christophe.du...@intel.com
+
+[EFL] [WK2] regression(r122411) Crashes in Ewk_View
+https://bugs.webkit.org/show_bug.cgi?id=91068
+
+Reviewed by Kentaro Hara.
+
+Avoid using calloc() to allocate memory for structures
+and use new operator instead. calloc() causes unwanted
+behavior when allocing a structure which contains
+non-pointer types (e.g. a HashMap) and leads to
+crashes.
+
+* UIProcess/API/efl/ewk_context.cpp:
+(_Ewk_Context::_Ewk_Context):
+* UIProcess/API/efl/ewk_intent.cpp:
+(_Ewk_Intent):
+(_Ewk_Intent::_Ewk_Intent):
+(ewk_intent_unref):
+(ewk_intent_new):
+* UIProcess/API/efl/ewk_intent_service.cpp:
+(_Ewk_Intent_Service):
+(_Ewk_Intent_Service::_Ewk_Intent_Service):
+(ewk_intent_service_unref):
+(ewk_intent_service_new):
+* UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
+(_Ewk_Navigation_Policy_Decision):
+(_Ewk_Navigation_Policy_Decision::_Ewk_Navigation_Policy_Decision):
+(ewk_navigation_policy_decision_free):
+(ewk_navigation_policy_decision_new):
+* UIProcess/API/efl/ewk_url_request.cpp:
+(_Ewk_Url_Request):
+(_Ewk_Url_Request::_Ewk_Url_Request):
+(ewk_url_request_unref):
+(ewk_url_request_new):
+* UIProcess/API/efl/ewk_url_response.cpp:
+(_Ewk_Url_Response):
+(_Ewk_Url_Response::_Ewk_Url_Response):
+(ewk_url_response_unref):
+(ewk_url_response_new):
+* UIProcess/API/efl/ewk_view.cpp:
+(_Ewk_View_Private_Data):
+(_Ewk_View_Private_Data::_Ewk_View_Private_Data):
+(_ewk_view_priv_new):
+(_ewk_view_priv_del):
+* UIProcess/API/efl/ewk_web_error.cpp:
+(_Ewk_Web_Error):
+(_Ewk_Web_Error::_Ewk_Web_Error):
+(ewk_web_error_free):
+(ewk_web_error_new):
+* UIProcess/API/efl/ewk_web_resource.cpp:
+(_Ewk_Web_Resource):
+(_Ewk_Web_Resource::_Ewk_Web_Resource):
+(ewk_web_resource_unref):
+(ewk_web_resource_new):
+
 2012-07-11  Andras Becsi  andras.be...@nokia.com
 
 [Qt][WK2] ASSERT: !m_viewportItem-isMoving()

[webkit-changes] [122453] trunk/Source/WebKit2

2012-07-12 Thread commit-queue

Title: [122453] trunk/Source/WebKit2








Revision 122453
Author commit-qu...@webkit.org
Date 2012-07-12 06:44:25 -0700 (Thu, 12 Jul 2012)


Log Message
[EFL][WK2] Browser crashes running BatteryStatus tests.
https://bugs.webkit.org/show_bug.cgi?id=91065

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-07-12
Reviewed by Kentaro Hara.

clientInfo was incorrectly casted to BatteryProviderEfl in helper
function. This patch fixes the issue.

* UIProcess/API/efl/BatteryProvider.cpp:
(toBatteryProvider):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122452 => 122453)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 13:39:22 UTC (rev 122452)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 13:44:25 UTC (rev 122453)
@@ -1,3 +1,16 @@
+2012-07-12  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL][WK2] Browser crashes running BatteryStatus tests.
+https://bugs.webkit.org/show_bug.cgi?id=91065
+
+Reviewed by Kentaro Hara.
+
+clientInfo was incorrectly casted to BatteryProviderEfl in helper
+function. This patch fixes the issue.
+
+* UIProcess/API/efl/BatteryProvider.cpp:
+(toBatteryProvider):
+
 2012-07-12  Christophe Dumez  christophe.du...@intel.com
 
 [EFL] [WK2] regression(r122411) Crashes in Ewk_View


Modified: trunk/Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp (122452 => 122453)

--- trunk/Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp	2012-07-12 13:39:22 UTC (rev 122452)
+++ trunk/Source/WebKit2/UIProcess/API/efl/BatteryProvider.cpp	2012-07-12 13:44:25 UTC (rev 122453)
@@ -35,9 +35,9 @@
 using namespace WebCore;
 using namespace WebKit;
 
-static inline BatteryProviderEfl* toBatteryProvider(const void* clientInfo)
+static inline BatteryProvider* toBatteryProvider(const void* clientInfo)
 {
-return static_castBatteryProviderEfl*(const_castvoid*(clientInfo));
+return static_castBatteryProvider*(const_castvoid*(clientInfo));
 }
 
 static void startUpdatingCallback(WKBatteryManagerRef batteryManager, const void* clientInfo)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122454] trunk/Source/WebCore

2012-07-12 Thread vsevik

Title: [122454] trunk/Source/WebCore








Revision 122454
Author vse...@chromium.org
Date 2012-07-12 07:06:30 -0700 (Thu, 12 Jul 2012)


Log Message
Web Inspector: [Regression] Stale revisions should be removed on navigation.
https://bugs.webkit.org/show_bug.cgi?id=91080

Reviewed by Pavel Feldman.

Moved all the code responsible for script mapping resetting to Workspace.
Stale revisions are removed in Workspace._reset now.

* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._restoreRevisionHistory):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
(WebInspector.Workspace.prototype._reset):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js
trunk/Source/WebCore/inspector/front-end/StylesPanel.js
trunk/Source/WebCore/inspector/front-end/UISourceCode.js
trunk/Source/WebCore/inspector/front-end/Workspace.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122453 => 122454)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 13:44:25 UTC (rev 122453)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 14:06:30 UTC (rev 122454)
@@ -1,3 +1,25 @@
+2012-07-12  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: [Regression] Stale revisions should be removed on navigation.
+https://bugs.webkit.org/show_bug.cgi?id=91080
+
+Reviewed by Pavel Feldman.
+
+Moved all the code responsible for script mapping resetting to Workspace.
+Stale revisions are removed in Workspace._reset now.
+
+* inspector/front-end/ScriptSnippetModel.js:
+(WebInspector.ScriptSnippetModel):
+* inspector/front-end/StylesPanel.js:
+(WebInspector.StylesUISourceCodeProvider):
+(WebInspector.StylesUISourceCodeProvider.prototype._populate):
+(WebInspector.StylesUISourceCodeProvider.prototype.reset):
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode.prototype._restoreRevisionHistory):
+* inspector/front-end/Workspace.js:
+(WebInspector.Workspace):
+(WebInspector.Workspace.prototype._reset):
+
 2012-07-12  Andreas Kling  kl...@webkit.org
 
 Make ElementAttributeData a variable-sized object to reduce memory use.


Modified: trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js (122453 => 122454)

--- trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js	2012-07-12 13:44:25 UTC (rev 122453)
+++ trunk/Source/WebCore/inspector/front-end/ScriptSnippetModel.js	2012-07-12 14:06:30 UTC (rev 122454)
@@ -41,8 +41,6 @@
 this._snippetStorage = new WebInspector.SnippetStorage(script, Script snippet #);
 this._lastSnippetEvaluationIndexSetting = WebInspector.settings.createSetting(lastSnippetEvaluationIndex, 0);
 this._snippetScriptMapping = new WebInspector.SnippetScriptMapping(this);
-
-WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.CachedResourcesLoaded, this._reset, this);
 }
 
 WebInspector.ScriptSnippetModel.snippetSourceURLPrefix = snippets:///;


Modified: trunk/Source/WebCore/inspector/front-end/StylesPanel.js (122453 => 122454)

--- trunk/Source/WebCore/inspector/front-end/StylesPanel.js	2012-07-12 13:44:25 UTC (rev 122453)
+++ trunk/Source/WebCore/inspector/front-end/StylesPanel.js	2012-07-12 14:06:30 UTC (rev 122454)
@@ -33,10 +33,11 @@
  */
 WebInspector.StylesUISourceCodeProvider = function()
 {
-WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.CachedResourcesLoaded, this._initialize, this);
-WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.WillLoadCachedResources, this.reset, this);
-
+/**
+ * @type {Array.WebInspector.UISourceCode}
+ */
 this._uiSourceCodes = [];
+WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, this._resourceAdded, this);
 }
 
 WebInspector.StylesUISourceCodeProvider.prototype = {
@@ -48,11 +49,8 @@
 return this._uiSourceCodes;
 },
 
-_initialize: function()
+_populate: function()
 {
-if (this._initialized)
-return;
-
 function populateFrame(frame)
 {
 for (var i = 0; i  frame.childFrames.length; ++i)
@@ -62,10 +60,8 @@
 for (var i = 0; i  resources.length; ++i)
 this._resourceAdded({data:resources[i]});
 }
-populateFrame.call(this, WebInspector.resourceTreeModel.mainFrame);
 
-WebInspector.resourceTreeModel.addEventListener(WebInspector.ResourceTreeModel.EventTypes.ResourceAdded, this._resourceAdded, this);
-this._initialized = true;
+

[webkit-changes] [122455] trunk/LayoutTests

2012-07-12 Thread commit-queue

Title: [122455] trunk/LayoutTests








Revision 122455
Author commit-qu...@webkit.org
Date 2012-07-12 07:13:15 -0700 (Thu, 12 Jul 2012)


Log Message
[GTK] Gardening: rebaseline after r122414
https://bugs.webkit.org/show_bug.cgi?id=91064

Unreviewed gardening.

Added the right -expected results for the
fast/forms/state-restore-skip-stateless.html test after
r122414

Patch by Simon Pena sp...@igalia.com on 2012-07-12

* platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (122454 => 122455)

--- trunk/LayoutTests/ChangeLog	2012-07-12 14:06:30 UTC (rev 122454)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 14:13:15 UTC (rev 122455)
@@ -1,3 +1,16 @@
+2012-07-12  Simon Pena  sp...@igalia.com
+
+[GTK] Gardening: rebaseline after r122414
+https://bugs.webkit.org/show_bug.cgi?id=91064
+
+Unreviewed gardening.
+
+Added the right -expected results for the
+fast/forms/state-restore-skip-stateless.html test after
+r122414
+
+* platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt:
+
 2012-07-12  Luciano Wolf  luciano.w...@openbossa.org
 
 [Qt] [Part 1] platform/qt/css1 tests needs update after rebaseline and new testfonts


Modified: trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt (122454 => 122455)

--- trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt	2012-07-12 14:06:30 UTC (rev 122454)
+++ trunk/LayoutTests/platform/gtk/fast/forms/state-restore-skip-stateless-expected.txt	2012-07-12 14:13:15 UTC (rev 122455)
@@ -11,15 +11,10 @@
 CONSOLE MESSAGE: line 8: 50, name17, checkbox, No owner, 
 CONSOLE MESSAGE: line 8: 1, off, name18, radio, 
 CONSOLE MESSAGE: line 8: No owner, 1, off, name19, 
-CONSOLE MESSAGE: line 8: file, No owner, 0, , 
-CONSOLE MESSAGE: line 8: button, No owner, 0, name20, 
-CONSOLE MESSAGE: line 8: submit, No owner, 0, name21, 
-CONSOLE MESSAGE: line 8: reset, No owner, 0, name22, 
-CONSOLE MESSAGE: line 8: button, No owner, 0, name26, 
+CONSOLE MESSAGE: line 8: file, No owner, 0, name26, 
 CONSOLE MESSAGE: line 8: select-one, No owner, 0, name27, 
 CONSOLE MESSAGE: line 8: select-multiple, No owner, 0, name28, 
-CONSOLE MESSAGE: line 8: textarea, No owner, 0, name29, 
-CONSOLE MESSAGE: line 8: keygen, No owner, 0, , 
+CONSOLE MESSAGE: line 8: textarea, No owner, 0, , 
 CONSOLE MESSAGE: line 13: select-one, No owner, 0, 
 CONSOLE MESSAGE: line 14: 
 PASS successfullyParsed is true






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122456] trunk/LayoutTests

2012-07-12 Thread commit-queue

Title: [122456] trunk/LayoutTests








Revision 122456
Author commit-qu...@webkit.org
Date 2012-07-12 07:19:25 -0700 (Thu, 12 Jul 2012)


Log Message
[EFL] Gardening after r122408 and r122414
https://bugs.webkit.org/show_bug.cgi?id=91069

Unreviewed gardening. Add new baseline for state-restore-skip-stateless.html
after r122414 and update expected results for table-vertical-align.html after
r122408.

Patch by Sudarsana Nagineni sudarsana.nagin...@linux.intel.com on 2012-07-12

* platform/efl/fast/forms/state-restore-skip-stateless-expected.txt:
* platform/efl/fast/multicol/table-vertical-align-expected.png:
* platform/efl/fast/multicol/table-vertical-align-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/efl/fast/multicol/table-vertical-align-expected.png
trunk/LayoutTests/platform/efl/fast/multicol/table-vertical-align-expected.txt


Added Paths

trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (122455 => 122456)

--- trunk/LayoutTests/ChangeLog	2012-07-12 14:13:15 UTC (rev 122455)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 14:19:25 UTC (rev 122456)
@@ -1,3 +1,16 @@
+2012-07-12  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
+
+[EFL] Gardening after r122408 and r122414
+https://bugs.webkit.org/show_bug.cgi?id=91069
+
+Unreviewed gardening. Add new baseline for state-restore-skip-stateless.html
+after r122414 and update expected results for table-vertical-align.html after
+r122408.
+
+* platform/efl/fast/forms/state-restore-skip-stateless-expected.txt:
+* platform/efl/fast/multicol/table-vertical-align-expected.png:
+* platform/efl/fast/multicol/table-vertical-align-expected.txt:
+
 2012-07-12  Simon Pena  sp...@igalia.com
 
 [GTK] Gardening: rebaseline after r122414


Added: trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt (0 => 122456)

--- trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/efl/fast/forms/state-restore-skip-stateless-expected.txt	2012-07-12 14:19:25 UTC (rev 122456)
@@ -0,0 +1,23 @@
+CONSOLE MESSAGE: line 44: Test if state of stateless form control types are not saved.
+CONSOLE MESSAGE: line 8: Form state vector:
+CONSOLE MESSAGE: line 8: name02, hidden, No owner, 0, 
+CONSOLE MESSAGE: line 8: name03, text, No owner, 0, 
+CONSOLE MESSAGE: line 8: name04, tel, No owner, 0, 
+CONSOLE MESSAGE: line 8: name05, url, No owner, 0, 
+CONSOLE MESSAGE: line 8: name06, email, No owner, 0, 
+CONSOLE MESSAGE: line 8: name07, text, No owner, 0, 
+CONSOLE MESSAGE: line 8: name14, number, No owner, 0, 
+CONSOLE MESSAGE: line 8: name15, range, No owner, 1, 
+CONSOLE MESSAGE: line 8: 50, name17, checkbox, No owner, 
+CONSOLE MESSAGE: line 8: 1, off, name18, radio, 
+CONSOLE MESSAGE: line 8: No owner, 1, off, name19, 
+CONSOLE MESSAGE: line 8: file, No owner, 0, name26, 
+CONSOLE MESSAGE: line 8: select-one, No owner, 0, name27, 
+CONSOLE MESSAGE: line 8: select-multiple, No owner, 0, name28, 
+CONSOLE MESSAGE: line 8: textarea, No owner, 0, , 
+CONSOLE MESSAGE: line 13: select-one, No owner, 0, 
+CONSOLE MESSAGE: line 14: 
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Modified: trunk/LayoutTests/platform/efl/fast/multicol/table-vertical-align-expected.png

(Binary files differ)


Modified: trunk/LayoutTests/platform/efl/fast/multicol/table-vertical-align-expected.txt (122455 => 122456)

--- trunk/LayoutTests/platform/efl/fast/multicol/table-vertical-align-expected.txt	2012-07-12 14:13:15 UTC (rev 122455)
+++ trunk/LayoutTests/platform/efl/fast/multicol/table-vertical-align-expected.txt	2012-07-12 14:19:25 UTC (rev 122456)
@@ -141,7 +141,7 @@
 RenderTable {TABLE} at (0,0) size 376x1166 [border: (1px outset #808080)]
   RenderTableSection {TBODY} at (1,1) size 374x1164
 RenderTableRow {TR} at (0,0) size 374x1127
-  RenderTableCell {TD} at (0,0) size 140x1127 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
+  RenderTableCell {TD} at (0,0) size 140x1164 [border: (1px inset #808080)] [r=0 c=0 rs=1 cs=1]
 RenderText {#text} at (11,11) size 105x37
   text run at (11,11) width 105: This cell has lots
   text run at (11,29) width 44: of text.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122460] trunk/Source/WebCore

2012-07-12 Thread vsevik

Title: [122460] trunk/Source/WebCore








Revision 122460
Author vse...@chromium.org
Date 2012-07-12 08:22:52 -0700 (Thu, 12 Jul 2012)


Log Message
Web Inspector: Revision history view should be updated when uiSourceCodes are removed or replaced.
https://bugs.webkit.org/show_bug.cgi?id=91095

Reviewed by Pavel Feldman.

RevisionHistoryView is now reset in WorkspaceReset event handler.
UISourceCodes are now removed from RevisionHistoryView when uiSourceCode is removed or replace.

* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView):
(WebInspector.RevisionHistoryView.prototype._clearHistory):
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
(WebInspector.RevisionHistoryView.prototype._uiSourceCodeReplaced):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._reset):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122459 => 122460)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 15:01:08 UTC (rev 122459)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 15:22:52 UTC (rev 122460)
@@ -1,3 +1,21 @@
+2012-07-12  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Revision history view should be updated when uiSourceCodes are removed or replaced.
+https://bugs.webkit.org/show_bug.cgi?id=91095
+
+Reviewed by Pavel Feldman.
+
+RevisionHistoryView is now reset in WorkspaceReset event handler.
+UISourceCodes are now removed from RevisionHistoryView when uiSourceCode is removed or replace.
+
+* inspector/front-end/RevisionHistoryView.js:
+(WebInspector.RevisionHistoryView):
+(WebInspector.RevisionHistoryView.prototype._clearHistory):
+(WebInspector.RevisionHistoryView.prototype._uiSourceCodeRemoved):
+(WebInspector.RevisionHistoryView.prototype._uiSourceCodeReplaced):
+* inspector/front-end/ScriptsPanel.js:
+(WebInspector.ScriptsPanel.prototype._reset):
+
 2012-07-12  Dongwoo Im  dw...@samsung.com
 
 InspectorFileSystemAgent.cpp have to include File.h explicitly


Modified: trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js (122459 => 122460)

--- trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js	2012-07-12 15:01:08 UTC (rev 122459)
+++ trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js	2012-07-12 15:22:52 UTC (rev 122460)
@@ -55,6 +55,9 @@
 
 WebInspector.workspace.uiSourceCodes().forEach(populateRevisions.bind(this));
 WebInspector.workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeContentCommitted, this._revisionAdded, this);
+WebInspector.workspace.addEventListener(WebInspector.UISourceCodeProvider.Events.UISourceCodeReplaced, this._uiSourceCodeReplaced, this);
+WebInspector.workspace.addEventListener(WebInspector.UISourceCodeProvider.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
+WebInspector.workspace.addEventListener(WebInspector.Workspace.Events.WorkspaceReset, this._reset.bind(this, false), this);
 
 this._statusElement = document.createElement(span);
 this._statusElement.textContent = WebInspector.UIString(Local modifications);
@@ -73,12 +76,6 @@
 view._revealUISourceCode(uiSourceCode);
 }
 
-WebInspector.RevisionHistoryView.reset = function()
-{
-if (WebInspector.RevisionHistoryView._view)
-WebInspector.RevisionHistoryView._view._reset();
-}
-
 WebInspector.RevisionHistoryView.prototype = {
 /**
  * @param {WebInspector.UISourceCode} uiSourceCode
@@ -126,15 +123,7 @@
  */
 _clearHistory: function(uiSourceCode)
 {
-uiSourceCode.revertAndClearHistory(historyCleared.bind(this));
-
-function historyCleared()
-{
-var uiSourceCodeItem = this._uiSourceCodeItems.get(uiSourceCode);
-this._treeOutline.removeChild(uiSourceCodeItem);
-this._uiSourceCodeItems.remove(uiSourceCode);
-}
-
+uiSourceCode.revertAndClearHistory(this._removeUISourceCode.bind(this));
 },
 
 _revisionAdded: function(event)
@@ -165,6 +154,33 @@
 }
 },
 
+_uiSourceCodeRemoved: function(event)
+{
+var uiSourceCode = /** @type {WebInspector.UISourceCode} */ event.data;
+this._removeUISourceCode(uiSourceCode);
+},
+
+/**
+ * @param {WebInspector.Event} event
+ */
+_uiSourceCodeReplaced: function(event)
+{
+var oldUISourceCode = /** @type {WebInspector.UISourceCode} */ event.data.oldUISourceCode;
+var uiSourceCode = /** @type {WebInspector.UISourceCode} */ event.data.uiSourceCode;
+this._removeUISourceCode(oldUISourceCode);
+this._revealUISourceCode(uiSourceCode);
+},
+
+/**
+ * @param {WebInspector.UISourceCode} uiSourceCode
+ */
+_removeUISourceCode: function(uiSourceCode)
+

[webkit-changes] [122461] trunk/Source/WebKit/chromium

2012-07-12 Thread leandrogracia

Title: [122461] trunk/Source/WebKit/chromium








Revision 122461
Author leandrogra...@chromium.org
Date 2012-07-12 08:30:55 -0700 (Thu, 12 Jul 2012)


Log Message
[Chromium] Remove unrequired API in WebSurroundingText.
https://bugs.webkit.org/show_bug.cgi?id=91067

Reviewed by Adam Barth.

Remove the unused first initialize method from WebSurroundingText.
Now both Chromium and LayoutTestController use the second method.

* public/WebSurroundingText.h:
(WebSurroundingText):
* src/WebSurroundingText.cpp:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSurroundingText.h
trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122460 => 122461)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 15:22:52 UTC (rev 122460)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 15:30:55 UTC (rev 122461)
@@ -1,3 +1,17 @@
+2012-07-12  Leandro Gracia Gil  leandrogra...@chromium.org
+
+[Chromium] Remove unrequired API in WebSurroundingText.
+https://bugs.webkit.org/show_bug.cgi?id=91067
+
+Reviewed by Adam Barth.
+
+Remove the unused first initialize method from WebSurroundingText.
+Now both Chromium and LayoutTestController use the second method.
+
+* public/WebSurroundingText.h:
+(WebSurroundingText):
+* src/WebSurroundingText.cpp:
+
 2012-07-11  Mark Rowe  mr...@apple.com
 
 http://webkit.org/b/91015 Remove BUILDING_ON / TARGETING macros in favor of system availability macros


Modified: trunk/Source/WebKit/chromium/public/WebSurroundingText.h (122460 => 122461)

--- trunk/Source/WebKit/chromium/public/WebSurroundingText.h	2012-07-12 15:22:52 UTC (rev 122460)
+++ trunk/Source/WebKit/chromium/public/WebSurroundingText.h	2012-07-12 15:30:55 UTC (rev 122461)
@@ -48,10 +48,6 @@
 WEBKIT_EXPORT bool isNull() const;
 WEBKIT_EXPORT void reset();
 
-// Initializes the object go get the surrounding text centered in the position described by the hit test.
-// The maximum length of the contents retrieved is defined by maxLength.
-WEBKIT_EXPORT void initialize(const WebHitTestResult, size_t maxLength);
-
 // Initializes the object to get the surrounding text centered in the position relative to a provided node.
 // The maximum length of the contents retrieved is defined by maxLength.
 WEBKIT_EXPORT void initialize(const WebNode, const WebPoint, size_t maxLength);


Modified: trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp (122460 => 122461)

--- trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp	2012-07-12 15:22:52 UTC (rev 122460)
+++ trunk/Source/WebKit/chromium/src/WebSurroundingText.cpp	2012-07-12 15:30:55 UTC (rev 122461)
@@ -40,15 +40,6 @@
 
 namespace WebKit {
 
-void WebSurroundingText::initialize(const WebHitTestResult hitTestResult, size_t maxLength)
-{
-Node* node = hitTestResult.node().unwrapNode();
-if (!node || !node-renderer())
-return;
-
-m_private.reset(new SurroundingText(VisiblePosition(node-renderer()-positionForPoint(static_castIntPoint(hitTestResult.localPoint(, maxLength));
-}
-
 void WebSurroundingText::initialize(const WebNode webNode, const WebPoint nodePoint, size_t maxLength)
 {
 const Node* node = webNode.constUnwrapNode();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122462] trunk/Source

2012-07-12 Thread allan . jensen

Title: [122462] trunk/Source








Revision 122462
Author allan.jen...@nokia.com
Date 2012-07-12 08:34:35 -0700 (Thu, 12 Jul 2012)


Log Message
[Qt] Implement MemoryUsageSupport
https://bugs.webkit.org/show_bug.cgi?id=91094

Reviewed by Adam Barth.

Source/_javascript_Core:

Compile in MemoryStatistics so we can make use of the interface.

* Target.pri:

Source/WebCore:

Implements Qt versions of the memory-usage functions using the information we have available
from the various memory systems used in WebKit.

Also gets rid of a redundant indirection in V8GCController.

* Target.pri:
* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::gcEpilogue):
(WebCore::V8GCController::checkMemoryUsage):
* platform/qt/MemoryUsageSupportQt.cpp: Added.
(WebCore::mallocMemoryUsage):
(WebCore::memoryUsageKB):
(WebCore::actualMemoryUsageKB):
(WebCore::MemoryUsageSupport::memoryUsageMB):
(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
(WebCore::MemoryUsageSupport::lowMemoryUsageMB):
(WebCore::MemoryUsageSupport::highMemoryUsageMB):
(WebCore::MemoryUsageSupport::highUsageDeltaMB):
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
* platform/qt/PlatformSupport.h:
(PlatformSupport):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Target.pri
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri
trunk/Source/WebCore/bindings/v8/V8GCController.cpp
trunk/Source/WebCore/platform/qt/PlatformSupport.h


Added Paths

trunk/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (122461 => 122462)

--- trunk/Source/_javascript_Core/ChangeLog	2012-07-12 15:30:55 UTC (rev 122461)
+++ trunk/Source/_javascript_Core/ChangeLog	2012-07-12 15:34:35 UTC (rev 122462)
@@ -1,3 +1,14 @@
+2012-07-12  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+[Qt] Implement MemoryUsageSupport
+https://bugs.webkit.org/show_bug.cgi?id=91094
+
+Reviewed by Adam Barth.
+
+Compile in MemoryStatistics so we can make use of the interface.
+
+* Target.pri:
+
 2012-07-12  Csaba Osztrogonác  o...@webkit.org
 
 Remove dead code after r122392.


Modified: trunk/Source/_javascript_Core/Target.pri (122461 => 122462)

--- trunk/Source/_javascript_Core/Target.pri	2012-07-12 15:30:55 UTC (rev 122461)
+++ trunk/Source/_javascript_Core/Target.pri	2012-07-12 15:34:35 UTC (rev 122462)
@@ -218,6 +218,7 @@
 runtime/LiteralParser.cpp \
 runtime/Lookup.cpp \
 runtime/MathObject.cpp \
+runtime/MemoryStatistics.cpp \
 runtime/NameConstructor.cpp \
 runtime/NameInstance.cpp \
 runtime/NamePrototype.cpp \


Modified: trunk/Source/WebCore/ChangeLog (122461 => 122462)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 15:30:55 UTC (rev 122461)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 15:34:35 UTC (rev 122462)
@@ -1,3 +1,32 @@
+2012-07-12  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+[Qt] Implement MemoryUsageSupport
+https://bugs.webkit.org/show_bug.cgi?id=91094
+
+Reviewed by Adam Barth.
+
+Implements Qt versions of the memory-usage functions using the information we have available
+from the various memory systems used in WebKit.
+
+Also gets rid of a redundant indirection in V8GCController.
+
+* Target.pri:
+* bindings/v8/V8GCController.cpp:
+(WebCore::V8GCController::gcEpilogue):
+(WebCore::V8GCController::checkMemoryUsage):
+* platform/qt/MemoryUsageSupportQt.cpp: Added.
+(WebCore::mallocMemoryUsage):
+(WebCore::memoryUsageKB):
+(WebCore::actualMemoryUsageKB):
+(WebCore::MemoryUsageSupport::memoryUsageMB):
+(WebCore::MemoryUsageSupport::actualMemoryUsageMB):
+(WebCore::MemoryUsageSupport::lowMemoryUsageMB):
+(WebCore::MemoryUsageSupport::highMemoryUsageMB):
+(WebCore::MemoryUsageSupport::highUsageDeltaMB):
+(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
+* platform/qt/PlatformSupport.h:
+(PlatformSupport):
+
 2012-07-12  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Revision history view should be updated when uiSourceCodes are removed or replaced.


Modified: trunk/Source/WebCore/Target.pri (122461 => 122462)

--- trunk/Source/WebCore/Target.pri	2012-07-12 15:30:55 UTC (rev 122461)
+++ trunk/Source/WebCore/Target.pri	2012-07-12 15:34:35 UTC (rev 122462)
@@ -1167,7 +1167,7 @@
 platform/LinkHash.cpp \
 platform/Logging.cpp \
 platform/MemoryPressureHandler.cpp \
-platform/MemoryUsageSupport.cpp \
+platform/qt/MemoryUsageSupportQt.cpp \
 platform/MIMETypeRegistry.cpp \
 platform/mock/DeviceMotionClientMock.cpp \
 platform/mock/DeviceOrientationClientMock.cpp \


Modified: trunk/Source/WebCore/bindings/v8/V8GCController.cpp (122461 => 122462)

--- trunk/Source/WebCore/bindings/v8/V8GCController.cpp	2012-07-12 15:30:55 UTC (rev 122461)
+++

[webkit-changes] [122463] trunk

2012-07-12 Thread jsbell

Title: [122463] trunk








Revision 122463
Author jsb...@chromium.org
Date 2012-07-12 08:38:14 -0700 (Thu, 12 Jul 2012)


Log Message
IndexedDB: ASSERT hit calling open from callback in Worker
https://bugs.webkit.org/show_bug.cgi?id=90832

Reviewed by Kentaro Hara.

Source/WebCore:

GroupSettings are used to provide the backing store path in some
ports. Accessing those settings from a Worker was added, but the
access referenced thread startup data that is cleared before the
run loop, so an IDBFactory.open() call executed asynchronously
would dereference a null pointer. Plumb the settings startup
data into the context itself, like all of the other properties.

Test: storage/indexeddb/open-twice-workers.html

* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* workers/DedicatedWorkerContext.cpp:
(WebCore::DedicatedWorkerContext::DedicatedWorkerContext):
* workers/DedicatedWorkerContext.h:
(WebCore::DedicatedWorkerContext::create):
(DedicatedWorkerContext):
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::createWorkerContext):
* workers/DedicatedWorkerThread.h:
(DedicatedWorkerThread):
* workers/SharedWorkerContext.cpp:
(WebCore::SharedWorkerContext::SharedWorkerContext):
* workers/SharedWorkerContext.h:
(WebCore::SharedWorkerContext::create):
(SharedWorkerContext):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::createWorkerContext):
* workers/SharedWorkerThread.h:
(SharedWorkerThread):
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::WorkerContext):
* workers/WorkerContext.h:
(WebCore::WorkerContext::groupSettings):
(WorkerContext):
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
* workers/WorkerThread.h:
(WorkerThread):

LayoutTests:

Call IDBFactory.open() twice from a worker - once from the initial worker
script evaluation, and once in a callback after the worker thread data
has been purged.

* storage/indexeddb/open-twice-workers-expected.txt: Added.
* storage/indexeddb/open-twice-workers.html: Added.
* storage/indexeddb/resources/open-twice.js: Added.
(test):
(openAnother):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp
trunk/Source/WebCore/workers/DedicatedWorkerContext.cpp
trunk/Source/WebCore/workers/DedicatedWorkerContext.h
trunk/Source/WebCore/workers/DedicatedWorkerThread.cpp
trunk/Source/WebCore/workers/DedicatedWorkerThread.h
trunk/Source/WebCore/workers/SharedWorkerContext.cpp
trunk/Source/WebCore/workers/SharedWorkerContext.h
trunk/Source/WebCore/workers/SharedWorkerThread.cpp
trunk/Source/WebCore/workers/SharedWorkerThread.h
trunk/Source/WebCore/workers/WorkerContext.cpp
trunk/Source/WebCore/workers/WorkerContext.h
trunk/Source/WebCore/workers/WorkerThread.cpp
trunk/Source/WebCore/workers/WorkerThread.h


Added Paths

trunk/LayoutTests/storage/indexeddb/open-twice-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/open-twice-workers.html
trunk/LayoutTests/storage/indexeddb/resources/open-twice.js




Diff

Modified: trunk/LayoutTests/ChangeLog (122462 => 122463)

--- trunk/LayoutTests/ChangeLog	2012-07-12 15:34:35 UTC (rev 122462)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 15:38:14 UTC (rev 122463)
@@ -1,3 +1,20 @@
+2012-07-12  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: ASSERT hit calling open from callback in Worker
+https://bugs.webkit.org/show_bug.cgi?id=90832
+
+Reviewed by Kentaro Hara.
+
+Call IDBFactory.open() twice from a worker - once from the initial worker
+script evaluation, and once in a callback after the worker thread data
+has been purged.
+
+* storage/indexeddb/open-twice-workers-expected.txt: Added.
+* storage/indexeddb/open-twice-workers.html: Added.
+* storage/indexeddb/resources/open-twice.js: Added.
+(test):
+(openAnother):
+
 2012-07-12  Kristóf Kosztyó  kkris...@inf.u-szeged.hu
 
 [Qt] platform/qt/css3 tests needs update after rebaseline


Added: trunk/LayoutTests/storage/indexeddb/open-twice-workers-expected.txt (0 => 122463)

--- trunk/LayoutTests/storage/indexeddb/open-twice-workers-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/open-twice-workers-expected.txt	2012-07-12 15:38:14 UTC (rev 122463)
@@ -0,0 +1,14 @@
+[Worker] Test opening twice
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Starting worker: resources/open-twice.js
+[Worker] indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+[Worker] 
+[Worker] indexedDB.open('open-twice1')
+[Worker] indexedDB.open('open-twice2')
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/storage/indexeddb/open-twice-workers.html (0 => 122463)

--- trunk/LayoutTests/storage/indexeddb/open-twice-workers.html	(rev 0)
+++

[webkit-changes] [122464] trunk/LayoutTests

2012-07-12 Thread abarth

Title: [122464] trunk/LayoutTests








Revision 122464
Author aba...@webkit.org
Date 2012-07-12 08:52:30 -0700 (Thu, 12 Jul 2012)


Log Message
Parse the viewport meta tag like iOS
https://bugs.webkit.org/show_bug.cgi?id=72722

Reviewed by Alexey Proskuryakov.

Our parsing appears to match iOS already.  This patch simply adds tests
that show that we agree on these cases.

* fast/viewport/viewport-133-expected.txt: Added.
* fast/viewport/viewport-133.html: Added.
* fast/viewport/viewport-134-expected.txt: Added.
* fast/viewport/viewport-134.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/viewport/viewport-133-expected.txt
trunk/LayoutTests/fast/viewport/viewport-133.html
trunk/LayoutTests/fast/viewport/viewport-134-expected.txt
trunk/LayoutTests/fast/viewport/viewport-134.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122463 => 122464)

--- trunk/LayoutTests/ChangeLog	2012-07-12 15:38:14 UTC (rev 122463)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 15:52:30 UTC (rev 122464)
@@ -1,3 +1,18 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+Parse the viewport meta tag like iOS
+https://bugs.webkit.org/show_bug.cgi?id=72722
+
+Reviewed by Alexey Proskuryakov.
+
+Our parsing appears to match iOS already.  This patch simply adds tests
+that show that we agree on these cases.
+
+* fast/viewport/viewport-133-expected.txt: Added.
+* fast/viewport/viewport-133.html: Added.
+* fast/viewport/viewport-134-expected.txt: Added.
+* fast/viewport/viewport-134.html: Added.
+
 2012-07-12  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: ASSERT hit calling open from callback in Worker


Added: trunk/LayoutTests/fast/viewport/viewport-133-expected.txt (0 => 122464)

--- trunk/LayoutTests/fast/viewport/viewport-133-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-133-expected.txt	2012-07-12 15:52:30 UTC (rev 122464)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 3: Viewport argument value 10; for key minimum-scale was truncated to its numeric prefix.
+ALERT: viewport size 980x1078 scale 10 with limits [10, 10] and userScalable true
+


Added: trunk/LayoutTests/fast/viewport/viewport-133.html (0 => 122464)

--- trunk/LayoutTests/fast/viewport/viewport-133.html	(rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-133.html	2012-07-12 15:52:30 UTC (rev 122464)
@@ -0,0 +1,13 @@
+head
+titleViewport META with semi-colons minimum-scale=10; maximum-scale=0.1./title
+meta name=viewport content=minimum-scale=10; maximum-scale=0.1
+script
+function test() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));
+}
+}
+/script
+/head
+body _onload_=test();


Added: trunk/LayoutTests/fast/viewport/viewport-134-expected.txt (0 => 122464)

--- trunk/LayoutTests/fast/viewport/viewport-134-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-134-expected.txt	2012-07-12 15:52:30 UTC (rev 122464)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 3: Viewport argument value device-width; for key width not recognized. Content ignored.
+ALERT: viewport size 160x176 scale 2 with limits [2, 5] and userScalable true
+


Added: trunk/LayoutTests/fast/viewport/viewport-134.html (0 => 122464)

--- trunk/LayoutTests/fast/viewport/viewport-134.html	(rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-134.html	2012-07-12 15:52:30 UTC (rev 122464)
@@ -0,0 +1,13 @@
+head
+titleViewport META with semi-colons width=device-width; initial-scale=2./title
+meta name=viewport content=width=device-width; initial-scale=2
+script
+function test() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));
+}
+}
+/script
+/head
+body _onload_=test();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122465] trunk/Source/WebCore

2012-07-12 Thread pfeldman

Title: [122465] trunk/Source/WebCore








Revision 122465
Author pfeld...@chromium.org
Date 2012-07-12 08:54:04 -0700 (Thu, 12 Jul 2012)


Log Message
Web Inspector: beautify find bar looks, simplify search update routines.
https://bugs.webkit.org/show_bug.cgi?id=91087

Reviewed by Vsevolod Vlasov.

This change updates the looks to the one on the screenshots and simplifies match count update routines.

* inspector/front-end/SearchController.js:
(WebInspector.SearchController.onMatchesMouseDown):
(WebInspector.SearchController):
(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
(WebInspector.SearchController.prototype.activePanelChanged):
(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
(WebInspector.SearchController.prototype._onKeyDown):
(WebInspector.SearchController.prototype._onInput):
(WebInspector.SearchController.prototype._onNextButtonSearch):
(WebInspector.SearchController.prototype._onPrevButtonSearch):
(WebInspector.SearchController.prototype._performSearch):
* inspector/front-end/inspector.css:
(#search):
(#search:focus):
(.toolbar-search-navigation-controls):
(.toolbar-search-navigation):
(.toolbar-search-navigation.enabled:hover):
(.toolbar-search-navigation.enabled, .toolbar-search-navigation.enabled:active):
(.toolbar-search):
(.toolbar-search-control):
(.search-results-matches):
(.inspector-footer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/ConsolePanel.js
trunk/Source/WebCore/inspector/front-end/ProfilesPanel.js
trunk/Source/WebCore/inspector/front-end/SearchController.js
trunk/Source/WebCore/inspector/front-end/SourceFrame.js
trunk/Source/WebCore/inspector/front-end/inspector.css




Diff

Modified: trunk/Source/WebCore/ChangeLog (122464 => 122465)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 15:52:30 UTC (rev 122464)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 15:54:04 UTC (rev 122465)
@@ -1,3 +1,36 @@
+2012-07-12  Pavel Feldman  pfeld...@chromium.org
+
+Web Inspector: beautify find bar looks, simplify search update routines.
+https://bugs.webkit.org/show_bug.cgi?id=91087
+
+Reviewed by Vsevolod Vlasov.
+
+This change updates the looks to the one on the screenshots and simplifies match count update routines.
+
+* inspector/front-end/SearchController.js:
+(WebInspector.SearchController.onMatchesMouseDown):
+(WebInspector.SearchController):
+(WebInspector.SearchController.prototype.activePanelChanged.performPanelSearch):
+(WebInspector.SearchController.prototype.activePanelChanged):
+(WebInspector.SearchController.prototype._updateSearchNavigationButtonState):
+(WebInspector.SearchController.prototype._updateSearchMatchesCountAndCurrentMatchIndex):
+(WebInspector.SearchController.prototype._onKeyDown):
+(WebInspector.SearchController.prototype._onInput):
+(WebInspector.SearchController.prototype._onNextButtonSearch):
+(WebInspector.SearchController.prototype._onPrevButtonSearch):
+(WebInspector.SearchController.prototype._performSearch):
+* inspector/front-end/inspector.css:
+(#search):
+(#search:focus):
+(.toolbar-search-navigation-controls):
+(.toolbar-search-navigation):
+(.toolbar-search-navigation.enabled:hover):
+(.toolbar-search-navigation.enabled, .toolbar-search-navigation.enabled:active):
+(.toolbar-search):
+(.toolbar-search-control):
+(.search-results-matches):
+(.inspector-footer):
+
 2012-07-12  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: ASSERT hit calling open from callback in Worker


Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (122464 => 122465)

--- trunk/Source/WebCore/English.lproj/localizedStrings.js	2012-07-12 15:52:30 UTC (rev 122464)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js	2012-07-12 15:54:04 UTC (rev 122465)
@@ -719,4 +719,4 @@
 localizedStrings[Encoded Data Length] = Encoded Data Length;
 localizedStrings[%d Bytes] = %d Bytes;
 localizedStrings[Time End] = Time End;
-localizedStrings[Search:] = Search:;
+localizedStrings[Find] = Find;


Modified: trunk/Source/WebCore/inspector/front-end/ConsolePanel.js (122464 => 122465)

--- trunk/Source/WebCore/inspector/front-end/ConsolePanel.js	2012-07-12 15:52:30 UTC (rev 122464)
+++ trunk/Source/WebCore/inspector/front-end/ConsolePanel.js	2012-07-12 15:54:04 UTC (rev 122465)
@@ -127,6 +127,7 @@
 {
 this._clearCurrentSearchResultHighlight();
 this._currentSearchResultIndex = index;
+WebInspector.searchController.updateCurrentMatchIndex(this._currentSearchResultIndex, this);
 this._searchResults[index].highlightSearchResults(this._searchRegex);
 },
 


Modified:

[webkit-changes] [122466] trunk/Source/WebCore

2012-07-12 Thread loislo

Title: [122466] trunk/Source/WebCore








Revision 122466
Author loi...@chromium.org
Date 2012-07-12 08:59:49 -0700 (Thu, 12 Jul 2012)


Log Message
Web Inspector: fix native memory instrumentation code for the bindings instrumentation.
https://bugs.webkit.org/show_bug.cgi?id=91096

The instrumented class has to have instrumentation method which reports class size and type and
the member objects and pointers.

Sample:
void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
{
memoryObjectInfo-reportObjectInfo(this, MemoryInstrumentation::DOM); // report object size and type.
TreeSharedNode, ContainerNode::reportMemoryUsage(memoryObjectInfo); // call base class instrumentation.
ScriptWrappable::reportMemoryUsage(memoryObjectInfo); // call base class instrumentation.
memoryObjectInfo-reportPointer(m_document, MemoryInstrumentation::DOM); // report uninstrumented pointer.
memoryObjectInfo-reportInstrumentedPointer(m_next); // report instrumented pointer.
memoryObjectInfo-reportInstrumentedObject(m_anObject); // report instrumented object.
}

Reviewed by Pavel Feldman.

Existing tests for native memory instrumentation.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/DOMDataStore.h:
(WebCore):
(DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::ChunkedTable::reportMemoryUsage):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::collectBindingMemoryInfo):
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
(WebCore::StringCache::reportMemoryUsage):
* bindings/v8/V8Binding.h:
(WebCore):
(StringCache):
(V8BindingPerIsolateData):
* bindings/v8/V8DOMMap.h:
(WebCore):
(AbstractWeakReferenceMap):
* inspector/InspectorMemoryAgent.cpp:
(WebCore):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp
trunk/Source/WebCore/bindings/v8/DOMDataStore.h
trunk/Source/WebCore/bindings/v8/IntrusiveDOMWrapperMap.h
trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8DOMMap.h
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122465 => 122466)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 15:54:04 UTC (rev 122465)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 15:59:49 UTC (rev 122466)
@@ -1,3 +1,48 @@
+2012-07-12  Ilya Tikhonovsky  loi...@chromium.org
+
+Web Inspector: fix native memory instrumentation code for the bindings instrumentation.
+https://bugs.webkit.org/show_bug.cgi?id=91096
+
+The instrumented class has to have instrumentation method which reports class size and type and
+the member objects and pointers.
+
+Sample:
+void Node::reportMemoryUsage(MemoryObjectInfo* memoryObjectInfo) const
+{
+memoryObjectInfo-reportObjectInfo(this, MemoryInstrumentation::DOM); // report object size and type.
+TreeSharedNode, ContainerNode::reportMemoryUsage(memoryObjectInfo); // call base class instrumentation.
+ScriptWrappable::reportMemoryUsage(memoryObjectInfo); // call base class instrumentation.
+memoryObjectInfo-reportPointer(m_document, MemoryInstrumentation::DOM); // report uninstrumented pointer.
+memoryObjectInfo-reportInstrumentedPointer(m_next); // report instrumented pointer.
+memoryObjectInfo-reportInstrumentedObject(m_anObject); // report instrumented object.
+}
+
+Reviewed by Pavel Feldman.
+
+Existing tests for native memory instrumentation.
+
+* bindings/v8/DOMDataStore.cpp:
+(WebCore::DOMDataStore::reportMemoryUsage):
+* bindings/v8/DOMDataStore.h:
+(WebCore):
+(DOMDataStore):
+* bindings/v8/IntrusiveDOMWrapperMap.h:
+(WebCore::ChunkedTable::reportMemoryUsage):
+* bindings/v8/ScriptProfiler.cpp:
+(WebCore::ScriptProfiler::collectBindingMemoryInfo):
+* bindings/v8/V8Binding.cpp:
+(WebCore::V8BindingPerIsolateData::reportMemoryUsage):
+(WebCore::StringCache::reportMemoryUsage):
+* bindings/v8/V8Binding.h:
+(WebCore):
+(StringCache):
+(V8BindingPerIsolateData):
+* bindings/v8/V8DOMMap.h:
+(WebCore):
+(AbstractWeakReferenceMap):
+* inspector/InspectorMemoryAgent.cpp:
+(WebCore):
+
 2012-07-12  Pavel Feldman  pfeld...@chromium.org
 
 Web Inspector: beautify find bar looks, simplify search update routines.


Modified: trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp (122465 => 122466)

--- trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp	2012-07-12 15:54:04 UTC (rev 122465)
+++ trunk/Source/WebCore/bindings/v8/DOMDataStore.cpp	2012-07-12 15:59:49 UTC (rev 122466)
@@ -119,13 +119,13 @@
 return 0;
 }
 
-void

[webkit-changes] [122467] trunk

2012-07-12 Thread commit-queue

Title: [122467] trunk








Revision 122467
Author commit-qu...@webkit.org
Date 2012-07-12 09:01:01 -0700 (Thu, 12 Jul 2012)


Log Message
[GTK] Implement disableImageLoading in DRT
https://bugs.webkit.org/show_bug.cgi?id=87973

Patch by Arnaud Renevier a...@renevier.net on 2012-07-12
Reviewed by Martin Robinson.

Tools:

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::disableImageLoading):

LayoutTests:

Add TEXT expectation to favicon-loads-with-icon-loading-override.html
which was only working by accident.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp
trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (122466 => 122467)

--- trunk/LayoutTests/ChangeLog	2012-07-12 15:59:49 UTC (rev 122466)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 16:01:01 UTC (rev 122467)
@@ -1,3 +1,15 @@
+2012-07-12  Arnaud Renevier  a...@renevier.net
+
+[GTK] Implement disableImageLoading in DRT
+https://bugs.webkit.org/show_bug.cgi?id=87973
+
+Reviewed by Martin Robinson.
+
+Add TEXT expectation to favicon-loads-with-icon-loading-override.html
+which was only working by accident.
+
+* platform/gtk/TestExpectations:
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 Parse the viewport meta tag like iOS


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (122466 => 122467)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-12 15:59:49 UTC (rev 122466)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-12 16:01:01 UTC (rev 122467)
@@ -1210,7 +1210,7 @@
 
 BUGWK87088 : fast/js/names.html = TEXT
 
-BUGWK87973 : http/tests/misc/favicon-loads-with-images-disabled.html = TEXT
+BUGWKGTK   : http/tests/misc/favicon-loads-with-icon-loading-override.html = TEXT
 
 BUGWK84102 : fast/profiler/dead-time.html = TEXT
 BUGWK84102 : fast/profiler/stop-profiling-after-setTimeout.html = TEXT


Modified: trunk/Tools/ChangeLog (122466 => 122467)

--- trunk/Tools/ChangeLog	2012-07-12 15:59:49 UTC (rev 122466)
+++ trunk/Tools/ChangeLog	2012-07-12 16:01:01 UTC (rev 122467)
@@ -1,3 +1,15 @@
+2012-07-12  Arnaud Renevier  a...@renevier.net
+
+[GTK] Implement disableImageLoading in DRT
+https://bugs.webkit.org/show_bug.cgi?id=87973
+
+Reviewed by Martin Robinson.
+
+* DumpRenderTree/gtk/DumpRenderTree.cpp:
+(resetDefaultsToConsistentValues):
+* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
+(LayoutTestController::disableImageLoading):
+
 2012-07-12  Simon Hausmann  simon.hausm...@nokia.com
 
 [Qt] Internal symbols are exported on Linux


Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (122466 => 122467)

--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2012-07-12 15:59:49 UTC (rev 122466)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2012-07-12 16:01:01 UTC (rev 122467)
@@ -464,6 +464,7 @@
  enable-caret-browsing, FALSE,
  enable-page-cache, FALSE,
  auto-resize-window, TRUE,
+ auto-load-images, TRUE,
  enable-java-applet, FALSE,
  enable-plugins, TRUE,
  enable-hyperlink-auditing, FALSE,


Modified: trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp (122466 => 122467)

--- trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp	2012-07-12 15:59:49 UTC (rev 122466)
+++ trunk/Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp	2012-07-12 16:01:01 UTC (rev 122467)
@@ -449,8 +449,11 @@
 
 void LayoutTestController::disableImageLoading()
 {
-// FIXME: Implement for testing fix for https://bugs.webkit.org/show_bug.cgi?id=27896
-// Also need to make sure image loading is re-enabled for each new test.
+WebKitWebView* view = webkit_web_frame_get_web_view(mainFrame);
+ASSERT(view);
+
+WebKitWebSettings* settings = webkit_web_view_get_settings(view);
+g_object_set(G_OBJECT(settings), auto-load-images, FALSE, NULL);
 }
 
 void LayoutTestController::setMockDeviceOrientation(bool canProvideAlpha, double alpha, bool canProvideBeta, double beta, bool canProvideGamma, double gamma)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122468] trunk/Source/WebCore

2012-07-12 Thread vsevik

Title: [122468] trunk/Source/WebCore








Revision 122468
Author vse...@chromium.org
Date 2012-07-12 09:17:46 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed r122460 inspector closure compilation fix follow up.

* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122467 => 122468)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 16:01:01 UTC (rev 122467)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 16:17:46 UTC (rev 122468)
@@ -1,3 +1,10 @@
+2012-07-12  Vsevolod Vlasov  vse...@chromium.org
+
+Unreviewed r122460 inspector closure compilation fix follow up.
+
+* inspector/front-end/RevisionHistoryView.js:
+(WebInspector.RevisionHistoryView):
+
 2012-07-12  Ilya Tikhonovsky  loi...@chromium.org
 
 Web Inspector: fix native memory instrumentation code for the bindings instrumentation.


Modified: trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js (122467 => 122468)

--- trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js	2012-07-12 16:01:01 UTC (rev 122467)
+++ trunk/Source/WebCore/inspector/front-end/RevisionHistoryView.js	2012-07-12 16:17:46 UTC (rev 122468)
@@ -57,7 +57,7 @@
 WebInspector.workspace.addEventListener(WebInspector.Workspace.Events.UISourceCodeContentCommitted, this._revisionAdded, this);
 WebInspector.workspace.addEventListener(WebInspector.UISourceCodeProvider.Events.UISourceCodeReplaced, this._uiSourceCodeReplaced, this);
 WebInspector.workspace.addEventListener(WebInspector.UISourceCodeProvider.Events.UISourceCodeRemoved, this._uiSourceCodeRemoved, this);
-WebInspector.workspace.addEventListener(WebInspector.Workspace.Events.WorkspaceReset, this._reset.bind(this, false), this);
+WebInspector.workspace.addEventListener(WebInspector.Workspace.Events.WorkspaceReset, this._reset, this);
 
 this._statusElement = document.createElement(span);
 this._statusElement.textContent = WebInspector.UIString(Local modifications);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122469] trunk/Source/WebKit/blackberry

2012-07-12 Thread commit-queue

Title: [122469] trunk/Source/WebKit/blackberry








Revision 122469
Author commit-qu...@webkit.org
Date 2012-07-12 09:35:57 -0700 (Thu, 12 Jul 2012)


Log Message
[BlackBerry] WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
https://bugs.webkit.org/show_bug.cgi?id=91002

Patch by Pawel Chomicki pchomi...@rim.com on 2012-07-12
Reviewed by Antonio Gomes.
Reviewed internally by Genevieve Mak.

Updated DEBUG_TOUCH_EVENTS section of touchEvent method to utilize
Platform::TouchEvent's toString method.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (122468 => 122469)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-07-12 16:17:46 UTC (rev 122468)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-07-12 16:35:57 UTC (rev 122469)
@@ -4129,37 +4129,7 @@
 bool WebPage::touchEvent(const Platform::TouchEvent event)
 {
 #if DEBUG_TOUCH_EVENTS
-switch (event.m_type) {
-case Platform::TouchEvent::TouchEnd:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent Touch End);
-break;
-case Platform::TouchEvent::TouchStart:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent Touch Start);
-break;
-case Platform::TouchEvent::TouchMove:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent Touch Move);
-break;
-case Platform::TouchEvent::TouchCancel:
-Platform::log(Platform::LogLevelCritical, WebPage::touchCancel Touch Cancel);
-break;
-}
-
-for (unsigned i = 0; i  event.m_points.size(); i++) {
-switch (event.m_points[i].m_state) {
-case Platform::TouchPoint::TouchPressed:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent %d Touch Pressed (%d, %d), event.m_points[i].m_id, event.m_points[i].m_pos.x(), event.m_points[i].m_pos.y());
-break;
-case Platform::TouchPoint::TouchReleased:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent %d Touch Released (%d, %d), event.m_points[i].m_id, event.m_points[i].m_pos.x(), event.m_points[i].m_pos.y());
-break;
-case Platform::TouchPoint::TouchMoved:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent %d Touch Moved (%d, %d), event.m_points[i].m_id, event.m_points[i].m_pos.x(), event.m_points[i].m_pos.y());
-break;
-case Platform::TouchPoint::TouchStationary:
-Platform::log(Platform::LogLevelCritical, WebPage::touchEvent %d Touch Stationary (%d, %d), event.m_points[i].m_id, event.m_points[i].m_pos.x(), event.m_points[i].m_pos.y());
-break;
-}
-}
+BBLOG(LogLevelCritical, %s, event.toString().c_str());
 #endif
 
 #if ENABLE(TOUCH_EVENTS)


Modified: trunk/Source/WebKit/blackberry/ChangeLog (122468 => 122469)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-07-12 16:17:46 UTC (rev 122468)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-07-12 16:35:57 UTC (rev 122469)
@@ -1,3 +1,17 @@
+2012-07-12  Pawel Chomicki  pchomi...@rim.com
+
+[BlackBerry] WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.
+https://bugs.webkit.org/show_bug.cgi?id=91002
+
+Reviewed by Antonio Gomes.
+Reviewed internally by Genevieve Mak.
+
+Updated DEBUG_TOUCH_EVENTS section of touchEvent method to utilize
+Platform::TouchEvent's toString method.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPage::touchEvent):
+
 2012-07-12  Jonathan Dong  jonathan.d...@torchmobile.com.cn
 
 [BlackBerry] Cannot use digest proxy auth and NTLM auth at the same time






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122470] trunk/Source/WebCore

2012-07-12 Thread vsevik

Title: [122470] trunk/Source/WebCore








Revision 122470
Author vse...@chromium.org
Date 2012-07-12 09:37:18 -0700 (Thu, 12 Jul 2012)


Log Message
Web Inspector: Remove resources panel edited resources search support.
https://bugs.webkit.org/show_bug.cgi?id=91101

Reviewed by Pavel Feldman.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.performSearch.callback):
(WebInspector.ResourcesPanel.prototype.performSearch):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122469 => 122470)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 16:35:57 UTC (rev 122469)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 16:37:18 UTC (rev 122470)
@@ -1,5 +1,16 @@
 2012-07-12  Vsevolod Vlasov  vse...@chromium.org
 
+Web Inspector: Remove resources panel edited resources search support.
+https://bugs.webkit.org/show_bug.cgi?id=91101
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/ResourcesPanel.js:
+(WebInspector.ResourcesPanel.prototype.performSearch.callback):
+(WebInspector.ResourcesPanel.prototype.performSearch):
+
+2012-07-12  Vsevolod Vlasov  vse...@chromium.org
+
 Unreviewed r122460 inspector closure compilation fix follow up.
 
 * inspector/front-end/RevisionHistoryView.js:


Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (122469 => 122470)

--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js	2012-07-12 16:35:57 UTC (rev 122469)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js	2012-07-12 16:37:18 UTC (rev 122470)
@@ -641,16 +641,6 @@
 var regex = WebInspector.SourceFrame.createSearchRegex(query);
 var totalMatchesCount = 0;
 
-function searchInEditedResource(treeElement)
-{
-var resource = treeElement.representedObject;
-if (resource.history.length == 0)
-return;
-var matchesCount = countRegexMatches(regex, resource.content)
-treeElement.searchMatchesFound(matchesCount);
-totalMatchesCount += matchesCount;
-}
-
 function callback(error, result)
 {
 if (!error) {
@@ -667,8 +657,6 @@
 if (!resource)
 continue;
 
-if (resource.history.length  0)
-continue; // Skip edited resources.
 this._findTreeElementForResource(resource).searchMatchesFound(searchResult.matchesCount);
 totalMatchesCount += searchResult.matchesCount;
 }
@@ -681,7 +669,6 @@
 this.jumpToNextSearchResult();
 }
 
-this._forAllResourceTreeElements(searchInEditedResource.bind(this));
 PageAgent.searchInResources(regex.source, !regex.ignoreCase, true, callback.bind(this));
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122471] trunk/LayoutTests

2012-07-12 Thread abarth

Title: [122471] trunk/LayoutTests








Revision 122471
Author aba...@webkit.org
Date 2012-07-12 09:44:28 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed. Remove a large number of empty directories.

* platform/chromium-win-vista: Removed.
* platform/chromium-win-vista/canvas: Removed.
* platform/chromium-win-vista/canvas/philip: Removed.
* platform/chromium-win-vista/canvas/philip/tests: Removed.
* platform/chromium-win-vista/compositing: Removed.
* platform/chromium-win-vista/compositing/geometry: Removed.
* platform/chromium-win-vista/compositing/overflow: Removed.
* platform/chromium-win-vista/compositing/shadows: Removed.
* platform/chromium-win-vista/css1: Removed.
* platform/chromium-win-vista/css1/font_properties: Removed.
* platform/chromium-win-vista/css1/text_properties: Removed.
* platform/chromium-win-vista/css1/units: Removed.
* platform/chromium-win-vista/css2.1: Removed.
* platform/chromium-win-vista/css3: Removed.
* platform/chromium-win-vista/css3/selectors3: Removed.
* platform/chromium-win-vista/css3/selectors3/html: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml: Removed.
* platform/chromium-win-vista/css3/selectors3/xml: Removed.
* platform/chromium-win-vista/editing: Removed.
* platform/chromium-win-vista/editing/inserting: Removed.
* platform/chromium-win-vista/editing/pasteboard: Removed.
* platform/chromium-win-vista/editing/style: Removed.
* platform/chromium-win-vista/fast: Removed.
* platform/chromium-win-vista/fast/backgrounds: Removed.
* platform/chromium-win-vista/fast/backgrounds/repeat: Removed.
* platform/chromium-win-vista/fast/backgrounds/size: Removed.
* platform/chromium-win-vista/fast/block: Removed.
* platform/chromium-win-vista/fast/block/positioning: Removed.
* platform/chromium-win-vista/fast/box-shadow: Removed.
* platform/chromium-win-vista/fast/canvas: Removed.
* platform/chromium-win-vista/fast/canvas/webgl: Removed.
* platform/chromium-win-vista/fast/compact: Removed.
* platform/chromium-win-vista/fast/css: Removed.
* platform/chromium-win-vista/fast/dom: Removed.
* platform/chromium-win-vista/fast/dom/Document: Removed.
* platform/chromium-win-vista/fast/dom/HTMLAnchorElement: Removed.
* platform/chromium-win-vista/fast/dom/HTMLMeterElement: Removed.
* platform/chromium-win-vista/fast/dom/HTMLProgressElement: Removed.
* platform/chromium-win-vista/fast/forms: Removed.
* platform/chromium-win-vista/fast/inline: Removed.
* platform/chromium-win-vista/fast/inline-block: Removed.
* platform/chromium-win-vista/fast/js: Removed.
* platform/chromium-win-vista/fast/media: Removed.
* platform/chromium-win-vista/fast/multicol: Removed.
* platform/chromium-win-vista/fast/multicol/vertical-rl: Removed.
* platform/chromium-win-vista/fast/parser: Removed.
* platform/chromium-win-vista/fast/repaint: Removed.
* platform/chromium-win-vista/fast/replaced: Removed.
* platform/chromium-win-vista/fast/sub-pixel: Removed.
* platform/chromium-win-vista/fast/sub-pixel/selection: Removed.
* platform/chromium-win-vista/fast/table: Removed.
* platform/chromium-win-vista/fast/text: Removed.
* platform/chromium-win-vista/fast/text/international: Removed.
* platform/chromium-win-vista/fast/text/whitespace: Removed.
* platform/chromium-win-vista/fast/writing-mode: Removed.
* platform/chromium-win-vista/http: Removed.
* platform/chromium-win-vista/http/tests: Removed.
* platform/chromium-win-vista/http/tests/appcache: Removed.
* platform/chromium-win-vista/http/tests/loading: Removed.
* platform/chromium-win-vista/http/tests/media: Removed.
* platform/chromium-win-vista/http/tests/misc: Removed.
* platform/chromium-win-vista/http/tests/multipart: Removed.
* platform/chromium-win-vista/http/tests/security: Removed.
* platform/chromium-win-vista/http/tests/security/aboutBlank: Removed.
* platform/chromium-win-vista/media: Removed.
* platform/chromium-win-vista/platform: Removed.
* platform/chromium-win-vista/platform/chromium: Removed.
* platform/chromium-win-vista/platform/chromium/compositing: Removed.
* platform/chromium-win-vista/platform/chromium/fast: Removed.
* platform/chromium-win-vista/platform/chromium/fast/text: Removed.
* platform/chromium-win-vista/platform/chromium/virtual: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas: Removed.
* platform/chromium-win-vista/svg: Removed.
* platform/chromium-win-vista/svg/W3C-I18N: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE: Removed.
* platform/chromium-win-vista/svg/as-image: Removed.
* platform/chromium-win-vista/svg/as-object: Removed.
* platform/chromium-win-vista/svg/batik: Removed.
* platform/chromium-win-vista/svg/batik/paints: Removed.
* platform/chromium-win-vista/svg/batik/text: Removed.
* platform/chromium-win-vista/svg/carto.net: Removed.
*

[webkit-changes] [122472] trunk/Source/WebKit/chromium

2012-07-12 Thread peter

Title: [122472] trunk/Source/WebKit/chromium








Revision 122472
Author pe...@chromium.org
Date 2012-07-12 09:52:08 -0700 (Thu, 12 Jul 2012)


Log Message
[Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90989

Reviewed by Adam Barth.

Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk
targets for Android, making sure that we're generating the packages.

* All.gyp:

Modified Paths

trunk/Source/WebKit/chromium/All.gyp
trunk/Source/WebKit/chromium/ChangeLog




Diff

Modified: trunk/Source/WebKit/chromium/All.gyp (122471 => 122472)

--- trunk/Source/WebKit/chromium/All.gyp	2012-07-12 16:44:28 UTC (rev 122471)
+++ trunk/Source/WebKit/chromium/All.gyp	2012-07-12 16:52:08 UTC (rev 122472)
@@ -47,7 +47,9 @@
 'conditions': [
 ['OS==android', {
 'dependencies': [
+'WebKitUnitTests.gyp:webkit_unit_tests_apk',
 '../../../Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:DumpRenderTree_apk',
+'../../../Tools/TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:TestWebKitAPI_apk',
 ],
 }],
 ],


Modified: trunk/Source/WebKit/chromium/ChangeLog (122471 => 122472)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 16:44:28 UTC (rev 122471)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 16:52:08 UTC (rev 122472)
@@ -1,3 +1,15 @@
+2012-07-12  Peter Beverloo  pe...@chromium.org
+
+[Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests
+https://bugs.webkit.org/show_bug.cgi?id=90989
+
+Reviewed by Adam Barth.
+
+Add dependencies on the webkit_unit_tests_apk and TestWebKitAPI_apk
+targets for Android, making sure that we're generating the packages.
+
+* All.gyp:
+
 2012-07-12  Leandro Gracia Gil  leandrogra...@chromium.org
 
 [Chromium] Remove unrequired API in WebSurroundingText.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122474] trunk/Source/WebCore

2012-07-12 Thread allan . jensen

Title: [122474] trunk/Source/WebCore








Revision 122474
Author allan.jen...@nokia.com
Date 2012-07-12 10:07:16 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed. Build fix for r122462.

* platform/qt/MemoryUsageSupportQt.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122473 => 122474)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 17:01:59 UTC (rev 122473)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 17:07:16 UTC (rev 122474)
@@ -1,3 +1,9 @@
+2012-07-12  Allan Sandfeld Jensen  allan.jen...@nokia.com
+
+Unreviewed. Build fix for r122462.
+
+* platform/qt/MemoryUsageSupportQt.cpp:
+
 2012-07-12  Vsevolod Vlasov  vse...@chromium.org
 
 Web Inspector: Remove resources panel edited resources search support.


Modified: trunk/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp (122473 => 122474)

--- trunk/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp	2012-07-12 17:01:59 UTC (rev 122473)
+++ trunk/Source/WebCore/platform/qt/MemoryUsageSupportQt.cpp	2012-07-12 17:07:16 UTC (rev 122474)
@@ -22,7 +22,7 @@
 #include MemoryUsageSupport.h
 
 #include JSDOMWindow.h
-#include _javascript_Core/MemoryStatistics.h
+#include runtime/MemoryStatistics.h
 #include wtf/FastMalloc.h
 
 #if OS(LINUX)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122476] trunk/Source/WebKit/blackberry

2012-07-12 Thread commit-queue

Title: [122476] trunk/Source/WebKit/blackberry








Revision 122476
Author commit-qu...@webkit.org
Date 2012-07-12 10:10:56 -0700 (Thu, 12 Jul 2012)


Log Message
WebPage::executeJavaScriptFunction crashes when there is an exception
https://bugs.webkit.org/show_bug.cgi?id=91098
RIM PR #149294

When there is an exception currently the code tries to get the string of
the exception via JSValueToStringCopy to pass back, but this cases a
crash inside _javascript_Core, so change it to simply return false and not
set the return value with the exception string.

Patch by Benjamin C Meyer bme...@rim.com on 2012-07-12
Reviewed by George Staikos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):

Modified Paths

trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog




Diff

Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (122475 => 122476)

--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-07-12 17:10:43 UTC (rev 122475)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp	2012-07-12 17:10:56 UTC (rev 122476)
@@ -881,9 +881,8 @@
 
 JSObjectRef functionObject = obj;
 JSValueRef result = 0;
-JSValueRef exception;
 if (functionObject  thisObject)
-result = JSObjectCallAsFunction(ctx, functionObject, thisObject, args.size(), argListRef.data(), exception);
+result = JSObjectCallAsFunction(ctx, functionObject, thisObject, args.size(), argListRef.data(), 0);
 
 for (unsigned i = 0; i  args.size(); ++i)
 JSStringRelease(argList[i]);
@@ -892,11 +891,6 @@
 
 if (!value) {
 returnType = JSException;
-JSStringRef stringRef = JSValueToStringCopy(ctx, exception, 0);
-size_t bufferSize = JSStringGetMaximumUTF8CStringSize(stringRef);
-WTF::Vectorchar buffer(bufferSize);
-JSStringGetUTF8CString(stringRef, buffer.data(), bufferSize);
-returnValue = WebString::fromUtf8(buffer.data());
 return false;
 }
 


Modified: trunk/Source/WebKit/blackberry/ChangeLog (122475 => 122476)

--- trunk/Source/WebKit/blackberry/ChangeLog	2012-07-12 17:10:43 UTC (rev 122475)
+++ trunk/Source/WebKit/blackberry/ChangeLog	2012-07-12 17:10:56 UTC (rev 122476)
@@ -1,3 +1,19 @@
+2012-07-12  Benjamin C Meyer  bme...@rim.com
+
+WebPage::executeJavaScriptFunction crashes when there is an exception
+https://bugs.webkit.org/show_bug.cgi?id=91098
+RIM PR #149294
+
+When there is an exception currently the code tries to get the string of
+the exception via JSValueToStringCopy to pass back, but this cases a
+crash inside _javascript_Core, so change it to simply return false and not
+set the return value with the exception string.
+
+Reviewed by George Staikos.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPage::executeJavaScriptFunction):
+
 2012-07-12  Pawel Chomicki  pchomi...@rim.com
 
 [BlackBerry] WebPage::touchEvent() should use Platform::TouchEvent's toString() for debugging.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122475] trunk/LayoutTests

2012-07-12 Thread jsbell

Title: [122475] trunk/LayoutTests








Revision 122475
Author jsb...@chromium.org
Date 2012-07-12 10:10:43 -0700 (Thu, 12 Jul 2012)


Log Message
IndexedDB: Verify internal delete pending flag on database
https://bugs.webkit.org/show_bug.cgi?id=90995

Reviewed by Tony Chang.

Verify the behavior required by the spec that an open() following
a deleteDatabase() is delayed and returns a new database.

* storage/indexeddb/database-deletepending-flag-expected.txt: Added.
* storage/indexeddb/database-deletepending-flag.html: Added.
* storage/indexeddb/resources/database-deletepending-flag.js: Added.
(test):
(openConnection.request.onsuccess.request.onsuccess):
(openConnection.request.onsuccess):
(openConnection):
(testDatabaseDelete.connection.onversionchange):
(testDatabaseDelete.deleteRequest.onblocked):
(testDatabaseDelete.deleteRequest.onsuccess):
(testDatabaseDelete.openRequest.onsuccess):
(testDatabaseDelete):

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/storage/indexeddb/database-deletepending-flag-expected.txt
trunk/LayoutTests/storage/indexeddb/database-deletepending-flag.html
trunk/LayoutTests/storage/indexeddb/resources/database-deletepending-flag.js




Diff

Modified: trunk/LayoutTests/ChangeLog (122474 => 122475)

--- trunk/LayoutTests/ChangeLog	2012-07-12 17:07:16 UTC (rev 122474)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 17:10:43 UTC (rev 122475)
@@ -1,3 +1,26 @@
+2012-07-12  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: Verify internal delete pending flag on database
+https://bugs.webkit.org/show_bug.cgi?id=90995
+
+Reviewed by Tony Chang.
+
+Verify the behavior required by the spec that an open() following
+a deleteDatabase() is delayed and returns a new database.
+
+* storage/indexeddb/database-deletepending-flag-expected.txt: Added.
+* storage/indexeddb/database-deletepending-flag.html: Added.
+* storage/indexeddb/resources/database-deletepending-flag.js: Added.
+(test):
+(openConnection.request.onsuccess.request.onsuccess):
+(openConnection.request.onsuccess):
+(openConnection):
+(testDatabaseDelete.connection.onversionchange):
+(testDatabaseDelete.deleteRequest.onblocked):
+(testDatabaseDelete.deleteRequest.onsuccess):
+(testDatabaseDelete.openRequest.onsuccess):
+(testDatabaseDelete):
+
 2012-07-12  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 Move nodesFromRect tests to separate sub-directory.


Added: trunk/LayoutTests/storage/indexeddb/database-deletepending-flag-expected.txt (0 => 122475)

--- trunk/LayoutTests/storage/indexeddb/database-deletepending-flag-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/database-deletepending-flag-expected.txt	2012-07-12 17:10:43 UTC (rev 122475)
@@ -0,0 +1,49 @@
+Test IndexedDB IDBDatabase internal delete pending flag
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+
+dbname = self.location.pathname
+indexedDB.deleteDatabase(dbname)
+
+Open a connection and set a sentinel version:
+version = '10'
+request = indexedDB.open(dbname)
+connection = request.result
+request = connection.setVersion(version)
+PASS connection.version is version
+connection.createObjectStore('store')
+PASS connection.objectStoreNames.length is 1
+
+Issue a delete request against the database - should be blocked by the open connection:
+deleteRequest = indexedDB.deleteDatabase(dbname)
+state = 0
+
+Open a second connection - should be delayed:
+openRequest = indexedDB.open(dbname)
+
+connection received versionchange event - ignoring.
+PASS ++state is 1
+
+deleteRequest received blocked event.
+PASS ++state is 2
+connection.close()
+deleteRequest should now be unblocked.
+
+deleteRequest received success event.
+PASS ++state is 3
+openRequest should now be unblocked.
+
+PASS openRequest received success event.
+PASS ++state is 4
+connection2 = openRequest.result
+connection2 should reference a different database:
+PASS connection2.version == connection.version is false
+PASS connection2.objectStoreNames.length is 0
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/storage/indexeddb/database-deletepending-flag.html (0 => 122475)

--- trunk/LayoutTests/storage/indexeddb/database-deletepending-flag.html	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/database-deletepending-flag.html	2012-07-12 17:10:43 UTC (rev 122475)
@@ -0,0 +1,10 @@
+html
+head
+script src=""
+script src=""
+/head
+body
+script src=""
+script src=""
+/body
+/html


Added: trunk/LayoutTests/storage/indexeddb/resources/database-deletepending-flag.js (0 => 122475)

--- trunk/LayoutTests/storage/indexeddb/resources/database-deletepending-flag.js	(rev 0)
+++

[webkit-changes] [122477] trunk/Source/WebKit/chromium

2012-07-12 Thread commit-queue

Title: [122477] trunk/Source/WebKit/chromium








Revision 122477
Author commit-qu...@webkit.org
Date 2012-07-12 10:11:39 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium][Mac] r122400 broke 10.6 build
https://bugs.webkit.org/show_bug.cgi?id=91103

Patch by Robert Sesek rse...@chromium.org on 2012-07-12
Reviewed by Tony Chang.

Use the right availability macros for forward-declaring methods and
defining constants.

* src/mac/WebInputEventFactory.mm:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122476 => 122477)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 17:10:56 UTC (rev 122476)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 17:11:39 UTC (rev 122477)
@@ -1,3 +1,15 @@
+2012-07-12  Robert Sesek  rse...@chromium.org
+
+[chromium][Mac] r122400 broke 10.6 build
+https://bugs.webkit.org/show_bug.cgi?id=91103
+
+Reviewed by Tony Chang.
+
+Use the right availability macros for forward-declaring methods and
+defining constants.
+
+* src/mac/WebInputEventFactory.mm:
+
 2012-07-12  Peter Beverloo  pe...@chromium.org
 
 [Chromium] Enable building APKs for TestWebKitAPI and webkit_unit_tests


Modified: trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm (122476 => 122477)

--- trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm	2012-07-12 17:10:56 UTC (rev 122476)
+++ trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm	2012-07-12 17:11:39 UTC (rev 122477)
@@ -28,13 +28,14 @@
 #include WebInputEventFactory.h
 
 #include ApplicationServices/ApplicationServices.h
+#include Availability.h
 #import Cocoa/Cocoa.h
 
 #import KeyEventCocoa.h
 #include WebInputEvent.h
 #include wtf/ASCIICType.h
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1060
+#if __MAC_OS_X_VERSION_MAX_ALLOWED  1070
 
 // Additional Lion APIs.
 enum {
@@ -53,9 +54,9 @@
 - (NSEventPhase)momentumPhase;
 @end
 
-#endif  // __MAC_OS_X_VERSION_MIN_REQUIRED = 1060
+#endif  // __MAC_OS_X_VERSION_MAX_ALLOWED  1070
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
+#if __MAC_OS_X_VERSION_MAX_ALLOWED = 1050
 
 // These are not defined in the 10.5 SDK but are defined in later SDKs inside
 // a MAC_OS_X_VERSION_MAX_ALLOWED = MAC_OS_X_VERSION_10_5 #ifdef.
@@ -64,7 +65,7 @@
 NSEventTypeEndGesture   = 20
 };
 
-#endif  // __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
+#endif  // __MAC_OS_X_VERSION_MAX_ALLOWED = 1050
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122478] trunk/Source/WebKit2

2012-07-12 Thread commit-queue

Title: [122478] trunk/Source/WebKit2








Revision 122478
Author commit-qu...@webkit.org
Date 2012-07-12 10:21:06 -0700 (Thu, 12 Jul 2012)


Log Message
[Qt][WK2] Implement web notifications support
https://bugs.webkit.org/show_bug.cgi?id=80702

Patch by Adenilson Cavalcanti cavalcan...@gmail.com on 2012-07-12
Reviewed by Noam Rosenthal.

Adding a new type of permission request for Desktop Notifications (plus required code
to register the handle for this requests).

* UIProcess/API/qt/qwebpermissionrequest.cpp:
(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
(QWebPermissionRequestPrivate):
(QWebPermissionRequest::create):
(QWebPermissionRequest::QWebPermissionRequest):
(QWebPermissionRequest::setAllow):
* UIProcess/API/qt/qwebpermissionrequest_p.h:
* UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Added.
* UIProcess/API/qt/tests/qmltests/common/notification.html: Added.
* UIProcess/qt/QtWebPageUIClient.cpp:
(WebKit::QtWebPageUIClient::QtWebPageUIClient):
(WebKit::QtWebPageUIClient::policyForNotificationPermissionRequest):
(WebKit):
* UIProcess/qt/QtWebPageUIClient.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest_p.h
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.cpp
trunk/Source/WebKit2/UIProcess/qt/QtWebPageUIClient.h


Added Paths

trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml
trunk/Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/notification.html




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122477 => 122478)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 17:11:39 UTC (rev 122477)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 17:21:06 UTC (rev 122478)
@@ -1,3 +1,28 @@
+2012-07-12  Adenilson Cavalcanti  cavalcan...@gmail.com
+
+[Qt][WK2] Implement web notifications support
+https://bugs.webkit.org/show_bug.cgi?id=80702
+
+Reviewed by Noam Rosenthal.
+
+Adding a new type of permission request for Desktop Notifications (plus required code
+to register the handle for this requests).
+
+* UIProcess/API/qt/qwebpermissionrequest.cpp:
+(QWebPermissionRequestPrivate::QWebPermissionRequestPrivate):
+(QWebPermissionRequestPrivate):
+(QWebPermissionRequest::create):
+(QWebPermissionRequest::QWebPermissionRequest):
+(QWebPermissionRequest::setAllow):
+* UIProcess/API/qt/qwebpermissionrequest_p.h:
+* UIProcess/API/qt/tests/qmltests/WebView/tst_notification.qml: Added.
+* UIProcess/API/qt/tests/qmltests/common/notification.html: Added.
+* UIProcess/qt/QtWebPageUIClient.cpp:
+(WebKit::QtWebPageUIClient::QtWebPageUIClient):
+(WebKit::QtWebPageUIClient::policyForNotificationPermissionRequest):
+(WebKit):
+* UIProcess/qt/QtWebPageUIClient.h:
+
 2012-07-12  Sudarsana Nagineni  sudarsana.nagin...@linux.intel.com
 
 [EFL][WK2] Browser crashes running BatteryStatus tests.


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp (122477 => 122478)

--- trunk/Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp	2012-07-12 17:11:39 UTC (rev 122477)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp	2012-07-12 17:21:06 UTC (rev 122478)
@@ -25,13 +25,13 @@
 #include WebKit2/WKBase.h
 #include WebKit2/WKRetainPtr.h
 
-
 class QWebPermissionRequestPrivate : public QSharedData {
 public:
-QWebPermissionRequestPrivate(WKSecurityOriginRef securityOrigin, WKGeolocationPermissionRequestRef permissionRequest)
+QWebPermissionRequestPrivate(WKSecurityOriginRef securityOrigin, WKGeolocationPermissionRequestRef geo = 0, WKNotificationPermissionRequestRef notify = 0, QWebPermissionRequest::RequestType reqType = QWebPermissionRequest::Geolocation)
 : origin(securityOrigin)
-, type(QWebPermissionRequest::Geolocation)
-, request(permissionRequest)
+, geolocationRequest(geo)
+, notificationRequest(notify)
+, type(reqType)
 , allow(false)
 {
 WKRetainPtrWKStringRef url = ""
@@ -48,8 +48,9 @@
 }
 
 WKRetainPtrWKSecurityOriginRef origin;
+WKRetainPtrWKGeolocationPermissionRequestRef geolocationRequest;
+WKRetainPtrWKNotificationPermissionRequestRef notificationRequest;
 QWebPermissionRequest::RequestType type;
-WKRetainPtrWKGeolocationPermissionRequestRef request;
 QtWebSecurityOrigin securityInfo;
 bool allow;
 };
@@ -59,9 +60,18 @@
 return new QWebPermissionRequest(origin, request);
 }
 
-QWebPermissionRequest::QWebPermissionRequest(WKSecurityOriginRef securityOrigin, WKGeolocationPermissionRequestRef permissionRequest, QObject* parent)
+QWebPermissionRequest* QWebPermissionRequest::create(WKSecurityOriginRef origin, WKNotificationPermissionRequestRef request)
+{
+return new QWebPermissionRequest(origin, 0, request,

[webkit-changes] [122479] trunk/Source/WebKit/chromium

2012-07-12 Thread tony

Title: [122479] trunk/Source/WebKit/chromium








Revision 122479
Author t...@chromium.org
Date 2012-07-12 10:29:42 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed, rolling out r122477.
http://trac.webkit.org/changeset/122477
https://bugs.webkit.org/show_bug.cgi?id=91103

Broke Chromium Mac build

* src/mac/WebInputEventFactory.mm:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122478 => 122479)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 17:21:06 UTC (rev 122478)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 17:29:42 UTC (rev 122479)
@@ -1,3 +1,13 @@
+2012-07-12  Tony Chang  t...@chromium.org
+
+Unreviewed, rolling out r122477.
+http://trac.webkit.org/changeset/122477
+https://bugs.webkit.org/show_bug.cgi?id=91103
+
+Broke Chromium Mac build
+
+* src/mac/WebInputEventFactory.mm:
+
 2012-07-12  Robert Sesek  rse...@chromium.org
 
 [chromium][Mac] r122400 broke 10.6 build


Modified: trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm (122478 => 122479)

--- trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm	2012-07-12 17:21:06 UTC (rev 122478)
+++ trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm	2012-07-12 17:29:42 UTC (rev 122479)
@@ -28,14 +28,13 @@
 #include WebInputEventFactory.h
 
 #include ApplicationServices/ApplicationServices.h
-#include Availability.h
 #import Cocoa/Cocoa.h
 
 #import KeyEventCocoa.h
 #include WebInputEvent.h
 #include wtf/ASCIICType.h
 
-#if __MAC_OS_X_VERSION_MAX_ALLOWED  1070
+#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1060
 
 // Additional Lion APIs.
 enum {
@@ -54,9 +53,9 @@
 - (NSEventPhase)momentumPhase;
 @end
 
-#endif  // __MAC_OS_X_VERSION_MAX_ALLOWED  1070
+#endif  // __MAC_OS_X_VERSION_MIN_REQUIRED = 1060
 
-#if __MAC_OS_X_VERSION_MAX_ALLOWED = 1050
+#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
 
 // These are not defined in the 10.5 SDK but are defined in later SDKs inside
 // a MAC_OS_X_VERSION_MAX_ALLOWED = MAC_OS_X_VERSION_10_5 #ifdef.
@@ -65,7 +64,7 @@
 NSEventTypeEndGesture   = 20
 };
 
-#endif  // __MAC_OS_X_VERSION_MAX_ALLOWED = 1050
+#endif  // __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122480] branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp

2012-07-12 Thread rjkroege

Title: [122480] branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp








Revision 122480
Author rjkro...@chromium.org
Date 2012-07-12 10:33:48 -0700 (Thu, 12 Jul 2012)


Log Message
Merge 122382 - [chromium] [regression] Don't use ScrollByPrecisePixels on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=91020

Reviewed by Adam Barth.

A change in https://bugs.webkit.org/show_bug.cgi?id=87535 to
improve the operation of smooth scrolling incorrectly caused
Chromium Mac to use the wrong scroll granularity on
hasPreciseScrollingDeltas() == true wheelevent scrolls.
Exclude the change on the Chromium Mac platform.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent): Adjusted #ifdef to exclude Chromium
Mac from ScrollByPrecisePixels change.


TBR=rjkro...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10693166

Modified Paths

branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp




Diff

Modified: branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp (122479 => 122480)

--- branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp	2012-07-12 17:29:42 UTC (rev 122479)
+++ branches/chromium/1180/Source/WebCore/platform/ScrollAnimator.cpp	2012-07-12 17:33:48 UTC (rev 122480)
@@ -91,7 +91,7 @@
 
 bool handled = false;
 
-#if PLATFORM(CHROMIUM)
+#if PLATFORM(CHROMIUM)  !OS(DARWIN)
 ScrollGranularity granularity = e.hasPreciseScrollingDeltas() ? ScrollByPrecisePixel : ScrollByPixel;
 #else
 ScrollGranularity granularity = ScrollByPixel;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122481] trunk/Tools

2012-07-12 Thread ojan

Title: [122481] trunk/Tools








Revision 122481
Author o...@chromium.org
Date 2012-07-12 10:57:41 -0700 (Thu, 12 Jul 2012)


Log Message
Allow putting ranges in user.py list prompts
https://bugs.webkit.org/show_bug.cgi?id=91115

Reviewed by Adam Barth.

Ranges are inclusive and denoted by a dash. This is useful for rebaselining a whole port
since the items are listed with each port's builders being contiguous.

* Scripts/webkitpy/common/system/user.py:
(User._wait_on_list_response):
* Scripts/webkitpy/common/system/user_unittest.py:
(UserTest.test_prompt_with_multiple_lists.run_prompt_test):
(UserTest.test_prompt_with_multiple_lists):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/user.py
trunk/Tools/Scripts/webkitpy/common/system/user_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (122480 => 122481)

--- trunk/Tools/ChangeLog	2012-07-12 17:33:48 UTC (rev 122480)
+++ trunk/Tools/ChangeLog	2012-07-12 17:57:41 UTC (rev 122481)
@@ -1,3 +1,19 @@
+2012-07-12  Ojan Vafai  o...@chromium.org
+
+Allow putting ranges in user.py list prompts
+https://bugs.webkit.org/show_bug.cgi?id=91115
+
+Reviewed by Adam Barth.
+
+Ranges are inclusive and denoted by a dash. This is useful for rebaselining a whole port
+since the items are listed with each port's builders being contiguous.
+
+* Scripts/webkitpy/common/system/user.py:
+(User._wait_on_list_response):
+* Scripts/webkitpy/common/system/user_unittest.py:
+(UserTest.test_prompt_with_multiple_lists.run_prompt_test):
+(UserTest.test_prompt_with_multiple_lists):
+
 2012-07-12  Arnaud Renevier  a...@renevier.net
 
 [GTK] Implement disableImageLoading in DRT


Modified: trunk/Tools/Scripts/webkitpy/common/system/user.py (122480 => 122481)

--- trunk/Tools/Scripts/webkitpy/common/system/user.py	2012-07-12 17:33:48 UTC (rev 122480)
+++ trunk/Tools/Scripts/webkitpy/common/system/user.py	2012-07-12 17:57:41 UTC (rev 122481)
@@ -90,13 +90,21 @@
 def _wait_on_list_response(cls, list_items, can_choose_multiple, raw_input):
 while True:
 if can_choose_multiple:
-response = cls.prompt(Enter one or more numbers (comma-separated), or \all\: , raw_input=raw_input)
+response = cls.prompt(Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or \all\: , raw_input=raw_input)
 if not response.strip() or response == all:
 return list_items
+
 try:
-indices = [int(r) - 1 for r in re.split(\s*,\s*, response)]
+indices = []
+for value in re.split(\s*,\s*, response):
+parts = value.split('-')
+if len(parts) == 2:
+indices += range(int(parts[0]) - 1, int(parts[1]))
+else:
+indices.append(int(value) - 1)
 except ValueError, err:
 continue
+
 return [list_items[i] for i in indices]
 else:
 try:


Modified: trunk/Tools/Scripts/webkitpy/common/system/user_unittest.py (122480 => 122481)

--- trunk/Tools/Scripts/webkitpy/common/system/user_unittest.py	2012-07-12 17:33:48 UTC (rev 122480)
+++ trunk/Tools/Scripts/webkitpy/common/system/user_unittest.py	2012-07-12 17:57:41 UTC (rev 122481)
@@ -59,9 +59,9 @@
 actual_result = output_capture.assert_outputs(
 self,
 User.prompt_with_multiple_lists,
-args=[title, [subtitle1, subtitle2], [[foo, bar], [foobar, barbaz]]],
+args=[title, [subtitle1, subtitle2], [[foo, bar], [foobar, barbaz, foobaz]]],
 kwargs={can_choose_multiple: can_choose_multiple, raw_input: mock_raw_input},
-expected_stdout=title\n\nsubtitle1\n 1. foo\n 2. bar\n\nsubtitle2\n 3. foobar\n 4. barbaz\n)
+expected_stdout=title\n\nsubtitle1\n 1. foo\n 2. bar\n\nsubtitle2\n 3. foobar\n 4. barbaz\n 5. foobaz\n)
 self.assertEqual(actual_result, expected_result)
 self.assertEqual(len(inputs), 0)
 
@@ -69,13 +69,17 @@
 run_prompt_test([badinput, 2], bar)
 run_prompt_test([3], foobar)
 run_prompt_test([4], barbaz)
+run_prompt_test([5], foobaz)
 
 run_prompt_test([1,2], [foo, bar], can_choose_multiple=True)
+run_prompt_test([1-3], [foo, bar, foobar], can_choose_multiple=True)
+run_prompt_test([1-2,3], [foo, bar, foobar], can_choose_multiple=True)
+run_prompt_test([2-1,3], [foobar], can_choose_multiple=True)
 run_prompt_test([  1,  2   ], [foo, bar], can_choose_multiple=True)
-run_prompt_test([all], [foo, bar, 'foobar', 'barbaz'], can_choose_multiple=True)
-run_prompt_test([], [foo, bar, 'foobar', 'barbaz'], can_choose_multiple=True)
-run_prompt_test([  ],

[webkit-changes] [122482] trunk/Source/WebCore

2012-07-12 Thread vsevik

Title: [122482] trunk/Source/WebCore








Revision 122482
Author vse...@chromium.org
Date 2012-07-12 10:59:02 -0700 (Thu, 12 Jul 2012)


Log Message
Web Inspector: Simplify UISourceCode code after moving revisions support inside it.
https://bugs.webkit.org/show_bug.cgi?id=91118

Reviewed by Pavel Feldman.

* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype._setContent):
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
(WebInspector.Revision.prototype.revertToThis):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/UISourceCode.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (122481 => 122482)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 17:57:41 UTC (rev 122481)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 17:59:02 UTC (rev 122482)
@@ -1,3 +1,18 @@
+2012-07-12  Vsevolod Vlasov  vse...@chromium.org
+
+Web Inspector: Simplify UISourceCode code after moving revisions support inside it.
+https://bugs.webkit.org/show_bug.cgi?id=91118
+
+Reviewed by Pavel Feldman.
+
+* inspector/front-end/UISourceCode.js:
+(WebInspector.UISourceCode.prototype._setContent):
+(WebInspector.UISourceCode.prototype.revertToOriginal):
+(WebInspector.UISourceCode.prototype.revertAndClearHistory):
+(WebInspector.UISourceCode.prototype.contentChanged):
+(WebInspector.UISourceCode.prototype.commitWorkingCopy):
+(WebInspector.Revision.prototype.revertToThis):
+
 2012-07-12  Allan Sandfeld Jensen  allan.jen...@nokia.com
 
 Unreviewed. Build fix for r122462.


Modified: trunk/Source/WebCore/inspector/front-end/UISourceCode.js (122481 => 122482)

--- trunk/Source/WebCore/inspector/front-end/UISourceCode.js	2012-07-12 17:57:41 UTC (rev 122481)
+++ trunk/Source/WebCore/inspector/front-end/UISourceCode.js	2012-07-12 17:59:02 UTC (rev 122482)
@@ -149,14 +149,11 @@
 
 /**
  * @param {string} newContent
- * @param {function(?string)} callback
  */
-_setContent: function(newContent, callback)
+_setContent: function(newContent)
 {
-if (!this.isEditable())
-return;
 this.setWorkingCopy(newContent);
-this.commitWorkingCopy(callback);
+this.commitWorkingCopy(function() {});
 },
 
 /**
@@ -206,22 +203,24 @@

 revertToOriginal: function()
 {
-function revert(content)
+/**
+ * @param {?string} content
+ * @param {boolean} contentEncoded
+ * @param {string} mimeType
+ */
+  function callback(content, contentEncoded, mimeType)
 {
-this._setContent(content, function() {});
+this._setContent();
 }
-this.requestOriginalContent(revert.bind(this));
+
+this.requestOriginalContent(callback.bind(this));
 },
 
 revertAndClearHistory: function(callback)
 {
 function revert(content)
 {
-this._setContent(content, clearHistory.bind(this));
-}
-
-function clearHistory()
-{
+this._setContent(content);
 this._clearRevisionHistory();
 this.history = [];
 callback();
@@ -236,9 +235,6 @@
  */
 contentChanged: function(newContent, mimeType)
 {
-if (this._committingWorkingCopy)
-return;
-
 this._content = newContent;
 this._mimeType = mimeType;
 this._contentLoaded = true;
@@ -294,12 +290,8 @@
 }
 
 var newContent = this._workingCopy;
-this._committingWorkingCopy = true;
 this.workingCopyCommitted(callback);
 this.addRevision(newContent);
-delete this._committingWorkingCopy;
-this.contentChanged(newContent, this._mimeType);
-
 },
 
 /**
@@ -619,7 +611,7 @@
 function revert(content)
 {
 if (this._uiSourceCode._content !== content)
-this._uiSourceCode._setContent(content, function() {});
+this._uiSourceCode._setContent(content);
 }
 this.requestContent(revert.bind(this));
 },






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122483] trunk/Source/WebKit/chromium

2012-07-12 Thread abarth

Title: [122483] trunk/Source/WebKit/chromium








Revision 122483
Author aba...@webkit.org
Date 2012-07-12 11:04:28 -0700 (Thu, 12 Jul 2012)


Log Message
[Chromium] Delete last mention of Hixie76 in WebKit/chromium
https://bugs.webkit.org/show_bug.cgi?id=91099

Reviewed by Tony Chang.

This deprecated API is no longer used anywhere.

* public/WebSettings.h:
(WebKit::WebSettings::setDefaultDeviceScaleFactor):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122482 => 122483)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 17:59:02 UTC (rev 122482)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 18:04:28 UTC (rev 122483)
@@ -1,3 +1,15 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+[Chromium] Delete last mention of Hixie76 in WebKit/chromium
+https://bugs.webkit.org/show_bug.cgi?id=91099
+
+Reviewed by Tony Chang.
+
+This deprecated API is no longer used anywhere.
+
+* public/WebSettings.h:
+(WebKit::WebSettings::setDefaultDeviceScaleFactor):
+
 2012-07-12  Tony Chang  t...@chromium.org
 
 Unreviewed, rolling out r122477.


Modified: trunk/Source/WebKit/chromium/public/WebSettings.h (122482 => 122483)

--- trunk/Source/WebKit/chromium/public/WebSettings.h	2012-07-12 17:59:02 UTC (rev 122482)
+++ trunk/Source/WebKit/chromium/public/WebSettings.h	2012-07-12 18:04:28 UTC (rev 122483)
@@ -160,7 +160,6 @@
 
 // DEPRECATED
 virtual void setDefaultDeviceScaleFactor(int) { }
-virtual void setHixie76WebSocketProtocolEnabled(bool) { }
 
 protected:
 ~WebSettings() { }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122485] trunk/Source/WebKit/chromium

2012-07-12 Thread tony

Title: [122485] trunk/Source/WebKit/chromium








Revision 122485
Author t...@chromium.org
Date 2012-07-12 11:20:35 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed.  Rolled DEPS.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122484 => 122485)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 18:14:09 UTC (rev 122484)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 18:20:35 UTC (rev 122485)
@@ -1,3 +1,9 @@
+2012-07-12  Tony Chang  t...@chromium.org
+
+Unreviewed.  Rolled DEPS.
+
+* DEPS:
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 [Chromium] Delete last mention of Hixie76 in WebKit/chromium


Modified: trunk/Source/WebKit/chromium/DEPS (122484 => 122485)

--- trunk/Source/WebKit/chromium/DEPS	2012-07-12 18:14:09 UTC (rev 122484)
+++ trunk/Source/WebKit/chromium/DEPS	2012-07-12 18:20:35 UTC (rev 122485)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '146218'
+  'chromium_rev': '146381'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122486] trunk

2012-07-12 Thread tony

Title: [122486] trunk








Revision 122486
Author t...@chromium.org
Date 2012-07-12 11:22:39 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] Remove drag and drop API methods that are no longer used
https://bugs.webkit.org/show_bug.cgi?id=90996

Reviewed by Adam Barth.

Source/WebKit/chromium:

In r117327, we added a parameter for modifier keys to these methods.
Chromium has since switched to using the methods that require the
extra parameter so we can remove these methods.

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):
* src/WebViewImpl.h:
(WebViewImpl):

Tools:

Migrate DRT to use the methods that take modifier keys.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::doDragDrop):
(EventSender::doMouseUp):
(EventSender::doMouseMove):
(EventSender::beginDragWithFiles):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebView.h
trunk/Source/WebKit/chromium/src/WebViewImpl.cpp
trunk/Source/WebKit/chromium/src/WebViewImpl.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/EventSender.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122485 => 122486)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 18:20:35 UTC (rev 122485)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 18:22:39 UTC (rev 122486)
@@ -1,5 +1,24 @@
 2012-07-12  Tony Chang  t...@chromium.org
 
+[chromium] Remove drag and drop API methods that are no longer used
+https://bugs.webkit.org/show_bug.cgi?id=90996
+
+Reviewed by Adam Barth.
+
+In r117327, we added a parameter for modifier keys to these methods.
+Chromium has since switched to using the methods that require the
+extra parameter so we can remove these methods.
+
+* public/WebView.h:
+(WebView):
+* src/WebViewImpl.cpp:
+(WebKit::WebViewImpl::dragTargetDragEnter):
+(WebKit::WebViewImpl::dragTargetDragOver):
+* src/WebViewImpl.h:
+(WebViewImpl):
+
+2012-07-12  Tony Chang  t...@chromium.org
+
 Unreviewed.  Rolled DEPS.
 
 * DEPS:


Modified: trunk/Source/WebKit/chromium/public/WebView.h (122485 => 122486)

--- trunk/Source/WebKit/chromium/public/WebView.h	2012-07-12 18:20:35 UTC (rev 122485)
+++ trunk/Source/WebKit/chromium/public/WebView.h	2012-07-12 18:22:39 UTC (rev 122486)
@@ -317,29 +317,17 @@
 
 // Callback methods when a drag-and-drop operation is trying to drop
 // something on the WebView.
-// FIXME: Remove this method after chromium changes catch up.
 virtual WebDragOperation dragTargetDragEnter(
 const WebDragData,
 const WebPoint clientPoint, const WebPoint screenPoint,
-WebDragOperationsMask operationsAllowed) = 0;
-virtual WebDragOperation dragTargetDragEnter(
-const WebDragData,
-const WebPoint clientPoint, const WebPoint screenPoint,
 WebDragOperationsMask operationsAllowed,
 int keyModifiers) = 0;
-// FIXME: Remove this method after chromium changes catch up.
 virtual WebDragOperation dragTargetDragOver(
 const WebPoint clientPoint, const WebPoint screenPoint,
-WebDragOperationsMask operationsAllowed) = 0;
-virtual WebDragOperation dragTargetDragOver(
-const WebPoint clientPoint, const WebPoint screenPoint,
 WebDragOperationsMask operationsAllowed,
 int keyModifiers) = 0;
 virtual void dragTargetDragLeave() = 0;
-// FIXME: Remove this method after chromium changes catch up.
 virtual void dragTargetDrop(
-const WebPoint clientPoint, const WebPoint screenPoint) = 0;
-virtual void dragTargetDrop(
 const WebPoint clientPoint, const WebPoint screenPoint,
 int keyModifiers) = 0;
 


Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (122485 => 122486)

--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-07-12 18:20:35 UTC (rev 122485)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2012-07-12 18:22:39 UTC (rev 122486)
@@ -2796,15 +2796,6 @@
 const WebDragData webDragData,
 const WebPoint clientPoint,
 const WebPoint screenPoint,
-WebDragOperationsMask operationsAllowed)
-{
-return dragTargetDragEnter(webDragData, clientPoint, screenPoint, operationsAllowed, 0);
-}
-
-WebDragOperation WebViewImpl::dragTargetDragEnter(
-const WebDragData webDragData,
-const WebPoint clientPoint,
-const WebPoint screenPoint,
 WebDragOperationsMask operationsAllowed,
 int keyModifiers)
 {
@@ -2819,14 +2810,6 @@
 WebDragOperation WebViewImpl::dragTargetDragOver(
 const WebPoint clientPoint,
 const WebPoint screenPoint,
-WebDragOperationsMask operationsAllowed)
-{
-return dragTargetDragOver(clientPoint, screenPoint, operationsAllowed, 0);
-}
-
-WebDragOperation WebViewImpl::dragTargetDragOver(
-const WebPoint clientPoint,
-const WebPoint screenPoint,

[webkit-changes] [122487] trunk/LayoutTests

2012-07-12 Thread wjmaclean

Title: [122487] trunk/LayoutTests








Revision 122487
Author wjmacl...@chromium.org
Date 2012-07-12 11:24:50 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] Unreviewed gardening. inspector/elements/edit-dom-actions.html is timing out on Win Debug.
https://bugs.webkit.org/show_bug.cgi?id=60109

This test has recently started timing out on Win Debug bots. It was already slow, but has gotten much worse,
but times are also quite variable.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122486 => 122487)

--- trunk/LayoutTests/ChangeLog	2012-07-12 18:22:39 UTC (rev 122486)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 18:24:50 UTC (rev 122487)
@@ -1,3 +1,13 @@
+2012-07-12  W. James MacLean  wjmacl...@chromium.org
+
+[chromium] Unreviewed gardening. inspector/elements/edit-dom-actions.html is timing out on Win Debug.
+https://bugs.webkit.org/show_bug.cgi?id=60109
+
+This test has recently started timing out on Win Debug bots. It was already slow, but has gotten much worse,
+but times are also quite variable.
+
+* platform/chromium/TestExpectations:
+
 2012-07-12  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: Verify internal delete pending flag on database


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122486 => 122487)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 18:22:39 UTC (rev 122486)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 18:24:50 UTC (rev 122487)
@@ -968,7 +968,7 @@
 BUGWK82894 SKIP DEBUG : inspector/profiler/heap-snapshot-inspect-dom-wrapper.html = PASS
 
 BUGWK60109 WIN RELEASE : inspector/elements/edit-dom-actions.html = PASS TEXT
-BUGWK60109 SLOW WIN DEBUG : inspector/elements/edit-dom-actions.html = PASS TEXT
+BUGWK60109 SLOW WIN DEBUG : inspector/elements/edit-dom-actions.html = PASS TEXT TIMEOUT
 
 BUGWK72434 LINUX WIN : inspector/styles/svg-style.xhtml = PASS TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122488] trunk/Source/WebCore

2012-07-12 Thread commit-queue

Title: [122488] trunk/Source/WebCore








Revision 122488
Author commit-qu...@webkit.org
Date 2012-07-12 11:31:09 -0700 (Thu, 12 Jul 2012)


Log Message
storage tests are flaky (crashing) on windows
https://bugs.webkit.org/show_bug.cgi?id=90469

Patch by James Weatherall w...@chromium.org on 2012-07-12
Reviewed by Kentaro Hara.

Add a missing check that the underlying V8 object reference in a V8 NPObject is valid, and zero the NPObject's rootObject member when disposing it, to ensure that it won't be mistakenly touched after that point.

This patch is intended to resolve flakiness in the storage tests including:
  storage/indexeddb/mozilla/indexes.html
  storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
  storage/websql/multiple-databases-garbage-collection.html

* bindings/v8/NPV8Object.cpp:
(WebCore::disposeUnderlyingV8Object):
Zero the NPObject's underlying rootObject.
(_NPN_EvaluateHelper):
Add check that the underlying V8 object reference is valid.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/NPV8Object.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122487 => 122488)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 18:24:50 UTC (rev 122487)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 18:31:09 UTC (rev 122488)
@@ -1,3 +1,23 @@
+2012-07-12  James Weatherall  w...@chromium.org
+
+storage tests are flaky (crashing) on windows
+https://bugs.webkit.org/show_bug.cgi?id=90469
+
+Reviewed by Kentaro Hara.
+
+Add a missing check that the underlying V8 object reference in a V8 NPObject is valid, and zero the NPObject's rootObject member when disposing it, to ensure that it won't be mistakenly touched after that point.
+
+This patch is intended to resolve flakiness in the storage tests including:
+  storage/indexeddb/mozilla/indexes.html
+  storage/indexeddb/mozilla/key-requirements-inline-and-passed.html
+  storage/websql/multiple-databases-garbage-collection.html
+
+* bindings/v8/NPV8Object.cpp:
+(WebCore::disposeUnderlyingV8Object):
+Zero the NPObject's underlying rootObject.
+(_NPN_EvaluateHelper):
+Add check that the underlying V8 object reference is valid.
+
 2012-07-12  No'am Rosenthal  noam.rosent...@nokia.com
 
 Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics


Modified: trunk/Source/WebCore/bindings/v8/NPV8Object.cpp (122487 => 122488)

--- trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2012-07-12 18:24:50 UTC (rev 122487)
+++ trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2012-07-12 18:31:09 UTC (rev 122488)
@@ -186,6 +186,7 @@
 #endif
 v8NpObject-v8Object.Dispose();
 v8NpObject-v8Object.Clear();
+v8NpObject-rootObject = 0;
 }
 
 } // namespace WebCore
@@ -320,6 +321,9 @@
 
 if (npObject-_class != npScriptObjectClass)
 return false;
+V8NPObject* v8NpObject = reinterpret_castV8NPObject*(npObject);
+if (v8NpObject-v8Object.IsEmpty())
+return false;
 
 v8::HandleScope handleScope;
 v8::Handlev8::Context context = toV8Context(npp, npObject);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122489] trunk/Source/WebCore

2012-07-12 Thread hyatt

Title: [122489] trunk/Source/WebCore








Revision 122489
Author hy...@apple.com
Date 2012-07-12 11:46:53 -0700 (Thu, 12 Jul 2012)


Log Message
https://bugs.webkit.org/show_bug.cgi?id=91000
REGRESSION (r122244): Overflow elements don't shrink as much as they should.

Reviewed by Simon Fraser.

This is a fix for a a regression from https://bugs.webkit.org/show_bug.cgi?id=90646.

I incorrectly analyzed the issue with Robert Hogan's negative margin patch and fooled myself into putting back
in an incorrect minimum width check from long ago.

What should have happened in the test case I patched is that the overflow element should shrink to 0. The issue 
with improving the logical top estimate in the previous patch is it made the clear delta become 0. This in turn
exposed a bug in our clearing algorithm with Robert's changes where you could need a relayout even if you didn't
actually move. This issue only occurs because the floats list is getting changed mid-layout because of negative margins.

The patch changes getClearDelta to call setChildNeedsLayout(true) on children whose widths change even when their
positions do not. In effect this dynamic addition of new floats after you have done a layout on the child already means
that you can need to lay out again despite not actually having to move.

To handle this, the code that does the relayout is now called if the child needs a relayout. This is done even if
the logical top estimate matches the final position.

No new tests required, since the test in fast/block/float is now correctly covering the issue.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122488 => 122489)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 18:31:09 UTC (rev 122488)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 18:46:53 UTC (rev 122489)
@@ -1,3 +1,35 @@
+2012-07-11  David Hyatt  hy...@apple.com
+
+https://bugs.webkit.org/show_bug.cgi?id=91000
+REGRESSION (r122244): Overflow elements don't shrink as much as they should.
+
+Reviewed by Simon Fraser.
+
+This is a fix for a a regression from https://bugs.webkit.org/show_bug.cgi?id=90646.
+
+I incorrectly analyzed the issue with Robert Hogan's negative margin patch and fooled myself into putting back
+in an incorrect minimum width check from long ago.
+
+What should have happened in the test case I patched is that the overflow element should shrink to 0. The issue 
+with improving the logical top estimate in the previous patch is it made the clear delta become 0. This in turn
+exposed a bug in our clearing algorithm with Robert's changes where you could need a relayout even if you didn't
+actually move. This issue only occurs because the floats list is getting changed mid-layout because of negative margins.
+
+The patch changes getClearDelta to call setChildNeedsLayout(true) on children whose widths change even when their
+positions do not. In effect this dynamic addition of new floats after you have done a layout on the child already means
+that you can need to lay out again despite not actually having to move.
+
+To handle this, the code that does the relayout is now called if the child needs a relayout. This is done even if
+the logical top estimate matches the final position.
+
+No new tests required, since the test in fast/block/float is now correctly covering the issue.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::layoutBlockChild):
+(WebCore::RenderBlock::getClearDelta):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
+
 2012-07-12  James Weatherall  w...@chromium.org
 
 storage tests are flaky (crashing) on windows


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (122488 => 122489)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-07-12 18:31:09 UTC (rev 122488)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2012-07-12 18:46:53 UTC (rev 122489)
@@ -2427,7 +2427,9 @@
 setLogicalTopForChild(child, logicalTopAfterClear, ApplyLayoutDelta);
 
 // Now we have a final top position.  See if it really does end up being different from our estimate.
-if (logicalTopAfterClear != logicalTopEstimate) {
+// clearFloatsIfNeeded can also mark the child as needing a layout even though we didn't move. This happens
+// when collapseMargins dynamically adds overhanging floats because of a child with negative margins.
+if (logicalTopAfterClear != logicalTopEstimate || child-needsLayout()) {
 if

[webkit-changes] [122491] trunk/Source/WTF

2012-07-12 Thread mjs

Title: [122491] trunk/Source/WTF








Revision 122491
Author m...@apple.com
Date 2012-07-12 12:12:08 -0700 (Thu, 12 Jul 2012)


Log Message
Document ListHashSet iteration guarantees
https://bugs.webkit.org/show_bug.cgi?id=91106

Reviewed by Eric Seidel.

* wtf/ListHashSet.h:
(WTF): Expand class comment to document this.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ListHashSet.h




Diff

Modified: trunk/Source/WTF/ChangeLog (122490 => 122491)

--- trunk/Source/WTF/ChangeLog	2012-07-12 19:02:04 UTC (rev 122490)
+++ trunk/Source/WTF/ChangeLog	2012-07-12 19:12:08 UTC (rev 122491)
@@ -1,3 +1,13 @@
+2012-07-12  Maciej Stachowiak  m...@apple.com
+
+Document ListHashSet iteration guarantees
+https://bugs.webkit.org/show_bug.cgi?id=91106
+
+Reviewed by Eric Seidel.
+
+* wtf/ListHashSet.h:
+(WTF): Expand class comment to document this.
+
 2012-07-11  Mark Rowe  mr...@apple.com
 
 http://webkit.org/b/91024 Build against the latest SDK when targeting older OS X versions.


Modified: trunk/Source/WTF/wtf/ListHashSet.h (122490 => 122491)

--- trunk/Source/WTF/wtf/ListHashSet.h	2012-07-12 19:02:04 UTC (rev 122490)
+++ trunk/Source/WTF/wtf/ListHashSet.h	2012-07-12 19:12:08 UTC (rev 122491)
@@ -34,6 +34,10 @@
 // order - iterating it will always give back values in the order
 // in which they are added.
 
+// Unlike iteration of most WTF Hash data structures, iteration is
+// guaranteed safe against mutation of the ListHashSet, except for
+// removal of the item currently pointed to by a given iterator.
+
 // In theory it would be possible to add prepend, insertAfter
 // and an append that moves the element to the end even if already present,
 // but unclear yet if these are needed.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122492] trunk/LayoutTests

2012-07-12 Thread abarth

Title: [122492] trunk/LayoutTests








Revision 122492
Author aba...@webkit.org
Date 2012-07-12 12:22:39 -0700 (Thu, 12 Jul 2012)


Log Message
LayoutTests/platform/google-chrome-linux32 and google-chrome-linux64 are empty and should be removed
https://bugs.webkit.org/show_bug.cgi?id=91114

Reviewed by Tony Chang.

These directories are empty and haven't been touched in over a year.
We should remove them.

* platform/google-chrome-linux32: Removed.
* platform/google-chrome-linux32/README: Removed.
* platform/google-chrome-linux64: Removed.
* platform/google-chrome-linux64/README: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/google-chrome-linux32/README
trunk/LayoutTests/platform/google-chrome-linux64/README




Diff

Modified: trunk/LayoutTests/ChangeLog (122491 => 122492)

--- trunk/LayoutTests/ChangeLog	2012-07-12 19:12:08 UTC (rev 122491)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 19:22:39 UTC (rev 122492)
@@ -1,3 +1,18 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+LayoutTests/platform/google-chrome-linux32 and google-chrome-linux64 are empty and should be removed
+https://bugs.webkit.org/show_bug.cgi?id=91114
+
+Reviewed by Tony Chang.
+
+These directories are empty and haven't been touched in over a year.
+We should remove them.
+
+* platform/google-chrome-linux32: Removed.
+* platform/google-chrome-linux32/README: Removed.
+* platform/google-chrome-linux64: Removed.
+* platform/google-chrome-linux64/README: Removed.
+
 2012-07-12  W. James MacLean  wjmacl...@chromium.org
 
 [chromium] Unreviewed gardening. Re-baseline expected text for fast/multicol/table-vertical-align.html


Deleted: trunk/LayoutTests/platform/google-chrome-linux32/README (122491 => 122492)

--- trunk/LayoutTests/platform/google-chrome-linux32/README	2012-07-12 19:12:08 UTC (rev 122491)
+++ trunk/LayoutTests/platform/google-chrome-linux32/README	2012-07-12 19:22:39 UTC (rev 122492)
@@ -1,6 +0,0 @@
-This directory contains results for official builds of Chromium.  Due to some
-compiler flag differences that impact some floating point operations, some
-tests have slightly different results from chromium-linux.
-
-This directory does not need to have a Skipped file since it uses
-new-run-webkit-tests.


Deleted: trunk/LayoutTests/platform/google-chrome-linux64/README (122491 => 122492)

--- trunk/LayoutTests/platform/google-chrome-linux64/README	2012-07-12 19:12:08 UTC (rev 122491)
+++ trunk/LayoutTests/platform/google-chrome-linux64/README	2012-07-12 19:22:39 UTC (rev 122492)
@@ -1,6 +0,0 @@
-This directory contains results for official builds of Chromium.  Due to some
-compiler flag differences that impact some floating point operations, some
-tests have slightly different results from chromium-linux.
-
-This directory does not need to have a Skipped file since it uses
-new-run-webkit-tests.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122493] trunk/LayoutTests

2012-07-12 Thread wjmaclean

Title: [122493] trunk/LayoutTests








Revision 122493
Author wjmacl...@chromium.org
Date 2012-07-12 12:49:33 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] Unreviewed gardening. Layout Test storage/indexeddb/constants.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=91133

Has started to crash occassionally on WebKitWin, cause unknown.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122492 => 122493)

--- trunk/LayoutTests/ChangeLog	2012-07-12 19:22:39 UTC (rev 122492)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 19:49:33 UTC (rev 122493)
@@ -1,3 +1,13 @@
+2012-07-12  W. James MacLean  wjmacl...@chromium.org
+
+
+[chromium] Unreviewed gardening. Layout Test storage/indexeddb/constants.html is flaky.
+https://bugs.webkit.org/show_bug.cgi?id=91133
+
+Has started to crash occassionally on WebKitWin, cause unknown.
+
+* platform/chromium/TestExpectations:
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 LayoutTests/platform/google-chrome-linux32 and google-chrome-linux64 are empty and should be removed


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122492 => 122493)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 19:22:39 UTC (rev 122492)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 19:49:33 UTC (rev 122493)
@@ -3746,3 +3746,6 @@
 
 // Started crashing after r122359
 BUGWK91047 DEBUG : html5lib/runner.html = CRASH
+
+// Started crashing after 122286
+BUGWK91133 WIN : storage/indexeddb/constants.html = PASS CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122494] trunk/Source/WebCore

2012-07-12 Thread barraclough

Title: [122494] trunk/Source/WebCore








Revision 122494
Author barraclo...@apple.com
Date 2012-07-12 12:59:23 -0700 (Thu, 12 Jul 2012)


Log Message
Threadsafety issues in WebScriptObject
https://bugs.webkit.org/show_bug.cgi?id=90849

Reviewed by Filip Pizlo  Oliver Hunt.

Updated fix for this bug. Taking the JSC API lock from WebScriptObject::release
may not be safe; better to just guard the JSWrapperCache with its own spinlock.

* bindings/objc/WebScriptObject.mm:
(WebCore::getJSWrapper):
- Added spinlock; also retain/autorelease the returned wrapper - it is unsafe
  to wait for the caller to do so, due to a race condition vs release removing
  the wrapper from the map.
(WebCore::addJSWrapper):
- Take the spinlock guarding the cache.
(WebCore::removeJSWrapper):
- Take the spinlock guarding the cache.
(WebCore::removeJSWrapperIfRetainCountOne):
- Take the spinlock guarding the cache, remove the wrapper if retainCount is one.
(WebCore::createJSWrapper):
- Remove the API lock; this method no longer needs to retain/autorelease (this is
  done by getJSWrapper).
(-[WebScriptObject _setImp:originRootObject:rootObject:]):
- Remove the API lock.
(-[WebScriptObject release]):
- Remove the API lock, retainCount check moved into removeJSWrapperIfRetainCountOne.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/objc/WebScriptObject.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (122493 => 122494)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 19:49:33 UTC (rev 122493)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 19:59:23 UTC (rev 122494)
@@ -1,3 +1,32 @@
+2012-07-12  Gavin Barraclough  barraclo...@apple.com
+
+Threadsafety issues in WebScriptObject
+https://bugs.webkit.org/show_bug.cgi?id=90849
+
+Reviewed by Filip Pizlo  Oliver Hunt.
+
+Updated fix for this bug. Taking the JSC API lock from WebScriptObject::release
+may not be safe; better to just guard the JSWrapperCache with its own spinlock.
+
+* bindings/objc/WebScriptObject.mm:
+(WebCore::getJSWrapper):
+- Added spinlock; also retain/autorelease the returned wrapper - it is unsafe
+  to wait for the caller to do so, due to a race condition vs release removing
+  the wrapper from the map.
+(WebCore::addJSWrapper):
+- Take the spinlock guarding the cache.
+(WebCore::removeJSWrapper):
+- Take the spinlock guarding the cache.
+(WebCore::removeJSWrapperIfRetainCountOne):
+- Take the spinlock guarding the cache, remove the wrapper if retainCount is one.
+(WebCore::createJSWrapper):
+- Remove the API lock; this method no longer needs to retain/autorelease (this is
+  done by getJSWrapper).
+(-[WebScriptObject _setImp:originRootObject:rootObject:]):
+- Remove the API lock.
+(-[WebScriptObject release]):
+- Remove the API lock, retainCount check moved into removeJSWrapperIfRetainCountOne.
+
 2012-07-11  David Hyatt  hy...@apple.com
 
 https://bugs.webkit.org/show_bug.cgi?id=91000


Modified: trunk/Source/WebCore/bindings/objc/WebScriptObject.mm (122493 => 122494)

--- trunk/Source/WebCore/bindings/objc/WebScriptObject.mm	2012-07-12 19:49:33 UTC (rev 122493)
+++ trunk/Source/WebCore/bindings/objc/WebScriptObject.mm	2012-07-12 19:59:23 UTC (rev 122494)
@@ -50,6 +50,7 @@
 #import runtime/JSLock.h
 #import runtime/Completion.h
 #import runtime/Completion.h
+#import wtf/TCSpinLock.h
 #import wtf/Threading.h
 
 
@@ -60,16 +61,24 @@
 namespace WebCore {
 
 static NSMapTable* JSWrapperCache;
+static SpinLock spinLock = SPINLOCK_INITIALIZER;
 
 NSObject* getJSWrapper(JSObject* impl)
 {
+ASSERT(isMainThread());
+SpinLockHolder holder(spinLock);
+
 if (!JSWrapperCache)
 return nil;
-return static_castNSObject*(NSMapGet(JSWrapperCache, impl));
+NSObject* wrapper = static_castNSObject*(NSMapGet(JSWrapperCache, impl));
+return wrapper ? [[wrapper retain] autorelease] : nil;
 }
 
 void addJSWrapper(NSObject* wrapper, JSObject* impl)
 {
+ASSERT(isMainThread());
+SpinLockHolder holder(spinLock);
+
 if (!JSWrapperCache)
 JSWrapperCache = createWrapperCache();
 NSMapInsert(JSWrapperCache, impl, wrapper);
@@ -77,18 +86,27 @@
 
 void removeJSWrapper(JSObject* impl)
 {
+SpinLockHolder holder(spinLock);
+
 if (!JSWrapperCache)
 return;
 NSMapRemove(JSWrapperCache, impl);
 }
 
+static void removeJSWrapperIfRetainCountOne(NSObject* wrapper, JSObject* impl)
+{
+SpinLockHolder holder(spinLock);
+
+if (!JSWrapperCache)
+return;
+if ([wrapper retainCount] == 1)
+NSMapRemove(JSWrapperCache, impl);
+}
+
 id createJSWrapper(JSC::JSObject* object, PassRefPtrJSC::Bindings::RootObject origin, PassRefPtrJSC::Bindings::RootObject root)
 {
-// NSMap is not thread safe, hold the JSC API lock;

[webkit-changes] [122495] trunk/LayoutTests

2012-07-12 Thread aestes

Title: [122495] trunk/LayoutTests








Revision 122495
Author aes...@apple.com
Date 2012-07-12 13:04:17 -0700 (Thu, 12 Jul 2012)


Log Message
[Mac] input-in-table-cell-no-value.html fails due to INPUT_TYPE_DATE being disabled.

* platform/mac/TestExpectations: Mark input-in-table-cell-no-value.html
as expected to fail.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122494 => 122495)

--- trunk/LayoutTests/ChangeLog	2012-07-12 19:59:23 UTC (rev 122494)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 20:04:17 UTC (rev 122495)
@@ -1,3 +1,10 @@
+2012-07-12  Andy Estes  aes...@apple.com
+
+[Mac] input-in-table-cell-no-value.html fails due to INPUT_TYPE_DATE being disabled.
+
+* platform/mac/TestExpectations: Mark input-in-table-cell-no-value.html
+as expected to fail.
+
 2012-07-12  W. James MacLean  wjmacl...@chromium.org
 
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (122494 => 122495)

--- trunk/LayoutTests/platform/mac/TestExpectations	2012-07-12 19:59:23 UTC (rev 122494)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2012-07-12 20:04:17 UTC (rev 122495)
@@ -292,3 +292,6 @@
 
 // Dialog element is not yet enabled.
 BUGWK84635 SKIP : fast/dom/HTMLDialogElement = TEXT
+
+// INPUT_TYPE_DATE is not enabled on the Mac
+BUGWK90987 : fast/forms/input-in-table-cell-no-value.html = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122496] trunk/Source/WebKit/chromium

2012-07-12 Thread commit-queue

Title: [122496] trunk/Source/WebKit/chromium








Revision 122496
Author commit-qu...@webkit.org
Date 2012-07-12 13:19:04 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium][Mac] r122400 broke 10.6 build
https://bugs.webkit.org/show_bug.cgi?id=91103

Patch by Robert Sesek rse...@chromium.org on 2012-07-12
Reviewed by Tony Chang.

Use the right availability macros for forward-declaring methods and
defining constants.

* src/mac/WebInputEventFactory.mm:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122495 => 122496)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 20:04:17 UTC (rev 122495)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 20:19:04 UTC (rev 122496)
@@ -1,3 +1,15 @@
+2012-07-12  Robert Sesek  rse...@chromium.org
+
+[chromium][Mac] r122400 broke 10.6 build
+https://bugs.webkit.org/show_bug.cgi?id=91103
+
+Reviewed by Tony Chang.
+
+Use the right availability macros for forward-declaring methods and
+defining constants.
+
+* src/mac/WebInputEventFactory.mm:
+
 2012-07-12  Tony Chang  t...@chromium.org
 
 [chromium] Remove drag and drop API methods that are no longer used


Modified: trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm (122495 => 122496)

--- trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm	2012-07-12 20:04:17 UTC (rev 122495)
+++ trunk/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm	2012-07-12 20:19:04 UTC (rev 122496)
@@ -34,7 +34,7 @@
 #include WebInputEvent.h
 #include wtf/ASCIICType.h
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED = 1060
+#if __MAC_OS_X_VERSION_MAX_ALLOWED  1070
 
 // Additional Lion APIs.
 enum {
@@ -53,9 +53,11 @@
 - (NSEventPhase)momentumPhase;
 @end
 
-#endif  // __MAC_OS_X_VERSION_MIN_REQUIRED = 1060
+#endif  // __MAC_OS_X_VERSION_MAX_ALLOWED  1070
 
-#if __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
+// Do not __MAC_OS_X_VERSION_MAX_ALLOWED here because of a bug in the 10.5 SDK,
+// see http://lists.webkit.org/pipermail/webkit-dev/2012-July/021442.html.
+#if MAC_OS_X_VERSION_MAX_ALLOWED = 1050
 
 // These are not defined in the 10.5 SDK but are defined in later SDKs inside
 // a MAC_OS_X_VERSION_MAX_ALLOWED = MAC_OS_X_VERSION_10_5 #ifdef.
@@ -64,7 +66,7 @@
 NSEventTypeEndGesture   = 20
 };
 
-#endif  // __MAC_OS_X_VERSION_MIN_REQUIRED == 1050
+#endif  // MAC_OS_X_VERSION_MAX_ALLOWED = 1050
 
 namespace WebKit {
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122497] trunk/Tools

2012-07-12 Thread dpranke

Title: [122497] trunk/Tools








Revision 122497
Author dpra...@chromium.org
Date 2012-07-12 13:22:46 -0700 (Thu, 12 Jul 2012)


Log Message
nrwt: reimplement manager_worker_broker in a much simpler form
https://bugs.webkit.org/show_bug.cgi?id=90513

Reviewed by Ojan Vafai.

This is a wholesale replacement of the MessagePool() implementation
and the other classes in manager_worker_broker.py. All of the
BrokerConnection*, Broker*, etc. classes are gone, and there are now
just a MessagePool class and a _Worker class. Happiness ensues.

I'm removing manager_worker_broker_unittest.py as well; we get
nearly complete coverage from the integration tests, and will
get more coverage when test-webkitpy moves to use this as well,
so having unit tests seems like unnecessary overhead. (running
coverage numbers with test-webkitpy shows that pretty much the only
uncovered lines are lines that are only run in the child processes,
which coverage doesn't handle at the moment).

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_MessagePool.__init__):
(_MessagePool.run):
(_MessagePool._start_workers):
(_MessagePool):
(_MessagePool.wait):
(_MessagePool._close):
(_MessagePool._handle_done):
(_MessagePool._can_pickle):
(_MessagePool._loop):
(WorkerException):
(_Message.__init__):
(_Message.__repr__):
(_Worker):
(_Worker.__init__):
(_Worker.terminate):
(_Worker._close):
(_Worker.run):
(_Worker.post):
(_Worker.yield_to_caller):
(_Worker._post):
(_Worker._raise):
(_Worker._set_up_logging):
(_WorkerLogHandler.__init__):
(_WorkerLogHandler.emit):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py


Removed Paths

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (122496 => 122497)

--- trunk/Tools/ChangeLog	2012-07-12 20:19:04 UTC (rev 122496)
+++ trunk/Tools/ChangeLog	2012-07-12 20:22:46 UTC (rev 122497)
@@ -1,3 +1,50 @@
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
+nrwt: reimplement manager_worker_broker in a much simpler form
+https://bugs.webkit.org/show_bug.cgi?id=90513
+
+Reviewed by Ojan Vafai.
+
+This is a wholesale replacement of the MessagePool() implementation
+and the other classes in manager_worker_broker.py. All of the
+BrokerConnection*, Broker*, etc. classes are gone, and there are now
+just a MessagePool class and a _Worker class. Happiness ensues.
+ 
+I'm removing manager_worker_broker_unittest.py as well; we get
+nearly complete coverage from the integration tests, and will
+get more coverage when test-webkitpy moves to use this as well,
+so having unit tests seems like unnecessary overhead. (running
+coverage numbers with test-webkitpy shows that pretty much the only
+uncovered lines are lines that are only run in the child processes,
+which coverage doesn't handle at the moment).
+ 
+* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
+(_MessagePool.__init__):
+(_MessagePool.run):
+(_MessagePool._start_workers):
+(_MessagePool):
+(_MessagePool.wait):
+(_MessagePool._close):
+(_MessagePool._handle_done):
+(_MessagePool._can_pickle):
+(_MessagePool._loop):
+(WorkerException):
+(_Message.__init__):
+(_Message.__repr__):
+(_Worker):
+(_Worker.__init__):
+(_Worker.terminate):
+(_Worker._close):
+(_Worker.run):
+(_Worker.post):
+(_Worker.yield_to_caller):
+(_Worker._post):
+(_Worker._raise):
+(_Worker._set_up_logging):
+(_WorkerLogHandler.__init__):
+(_WorkerLogHandler.emit):
+* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Removed.
+
 2012-07-12  Tony Chang  t...@chromium.org
 
 [chromium] Remove drag and drop API methods that are no longer used


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py (122496 => 122497)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py	2012-07-12 20:19:04 UTC (rev 122496)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py	2012-07-12 20:22:46 UTC (rev 122497)
@@ -31,8 +31,6 @@
 import cPickle
 import logging
 import multiprocessing
-import optparse
-import os
 import Queue
 import sys
 import time
@@ -47,13 +45,6 @@
 _log = logging.getLogger(__name__)
 
 
-#
-# Topic names for Manager - Worker messaging
-#
-MANAGER_TOPIC = 'managers'
-ANY_WORKER_TOPIC = 'workers'
-
-
 def get(caller, worker_factory, num_workers, worker_startup_delay_secs=0.0, host=None):
 Returns an object that exposes a run() method that takes a list of test shards and runs them in

[webkit-changes] [122499] trunk/LayoutTests

2012-07-12 Thread dpranke

Title: [122499] trunk/LayoutTests








Revision 122499
Author dpra...@chromium.org
Date 2012-07-12 13:39:20 -0700 (Thu, 12 Jul 2012)


Log Message
2012-07-12  Dirk Pranke  dpra...@chromium.org

Remove chromium-mac-leopard baselines.

Rubber-stamped by Tony Chang.

Chromium no longer actively supports the Leopard (10.5) version
of Mac OS and doesn't have any bots running it, so we don't need
the baselines any more.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/chromium-mac-leopard/




Diff

Modified: trunk/LayoutTests/ChangeLog (122498 => 122499)

--- trunk/LayoutTests/ChangeLog	2012-07-12 20:31:09 UTC (rev 122498)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 20:39:20 UTC (rev 122499)
@@ -1,3 +1,13 @@
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
+Remove chromium-mac-leopard baselines.
+
+Rubber-stamped by Tony Chang.
+
+Chromium no longer actively supports the Leopard (10.5) version
+of Mac OS and doesn't have any bots running it, so we don't need
+the baselines any more.
+
 2012-07-12  Andy Estes  aes...@apple.com
 
 [Mac] input-in-table-cell-no-value.html fails due to INPUT_TYPE_DATE being disabled.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122500] trunk/Source/WebKit2

2012-07-12 Thread commit-queue

Title: [122500] trunk/Source/WebKit2








Revision 122500
Author commit-qu...@webkit.org
Date 2012-07-12 13:44:45 -0700 (Thu, 12 Jul 2012)


Log Message
[WK2] Add missing Network Information API integration to WebContext and WebPage
https://bugs.webkit.org/show_bug.cgi?id=90781

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-12
Reviewed by Anders Carlsson.

Integrate Network Information API to WebPage, WebContext and
properly route messages to the WebNetworkInfoManagerProxy.
Without this, the Network Information tests are crashing for
WebKit2.

* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
* UIProcess/WebContext.h:
(WebKit):
(WebContext):
(WebKit::WebContext::networkInfoManagerProxy):
* UIProcess/WebNetworkInfoManagerProxy.cpp:
(WebKit::WebNetworkInfoManagerProxy::didReceiveSyncMessage):
(WebKit):
* UIProcess/WebNetworkInfoManagerProxy.h:
(WebNetworkInfoManagerProxy):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
trunk/Source/WebKit2/UIProcess/WebNetworkInfoManagerProxy.cpp
trunk/Source/WebKit2/UIProcess/WebNetworkInfoManagerProxy.h
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122499 => 122500)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 20:39:20 UTC (rev 122499)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 20:44:45 UTC (rev 122500)
@@ -1,3 +1,36 @@
+2012-07-12  Christophe Dumez  christophe.du...@intel.com
+
+[WK2] Add missing Network Information API integration to WebContext and WebPage
+https://bugs.webkit.org/show_bug.cgi?id=90781
+
+Reviewed by Anders Carlsson.
+
+Integrate Network Information API to WebPage, WebContext and
+properly route messages to the WebNetworkInfoManagerProxy.
+Without this, the Network Information tests are crashing for
+WebKit2.
+
+* UIProcess/WebContext.cpp:
+(WebKit::WebContext::WebContext):
+(WebKit::WebContext::~WebContext):
+(WebKit::WebContext::disconnectProcess):
+(WebKit::WebContext::didReceiveMessage):
+(WebKit::WebContext::didReceiveSyncMessage):
+* UIProcess/WebContext.h:
+(WebKit):
+(WebContext):
+(WebKit::WebContext::networkInfoManagerProxy):
+* UIProcess/WebNetworkInfoManagerProxy.cpp:
+(WebKit::WebNetworkInfoManagerProxy::didReceiveSyncMessage):
+(WebKit):
+* UIProcess/WebNetworkInfoManagerProxy.h:
+(WebNetworkInfoManagerProxy):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::didReceiveMessage):
+(WebKit::WebProcessProxy::didReceiveSyncMessage):
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::WebPage):
+
 2012-07-12  No'am Rosenthal  noam.rosent...@nokia.com
 
 Move TextureMapperAnimation and texmap/LayerTransform to platform/graphics


Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (122499 => 122500)

--- trunk/Source/WebKit2/UIProcess/WebContext.cpp	2012-07-12 20:39:20 UTC (rev 122499)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp	2012-07-12 20:44:45 UTC (rev 122500)
@@ -70,6 +70,10 @@
 #include WebBatteryManagerProxy.h
 #endif
 
+#if ENABLE(NETWORK_INFO)
+#include WebNetworkInfoManagerProxy.h
+#endif
+
 #if USE(SOUP)
 #include WebSoupRequestManagerProxy.h
 #endif
@@ -143,6 +147,9 @@
 , m_iconDatabase(WebIconDatabase::create(this))
 , m_keyValueStorageManagerProxy(WebKeyValueStorageManagerProxy::create(this))
 , m_mediaCacheManagerProxy(WebMediaCacheManagerProxy::create(this))
+#if ENABLE(NETWORK_INFO)
+, m_networkInfoManagerProxy(WebNetworkInfoManagerProxy::create(this))
+#endif
 , m_notificationManagerProxy(WebNotificationManagerProxy::create(this))
 , m_pluginSiteDataManager(WebPluginSiteDataManager::create(this))
 , m_resourceCacheManagerProxy(WebResourceCacheManagerProxy::create(this))
@@ -210,6 +217,11 @@
 
 m_mediaCacheManagerProxy-invalidate();
 m_mediaCacheManagerProxy-clearContext();
+
+#if ENABLE(NETWORK_INFO)
+m_networkInfoManagerProxy-invalidate();
+m_networkInfoManagerProxy-clearContext();
+#endif
 
 m_notificationManagerProxy-invalidate();
 m_notificationManagerProxy-clearContext();
@@ -418,6 +430,9 @@
 m_geolocationManagerProxy-invalidate();
 m_keyValueStorageManagerProxy-invalidate();
 m_mediaCacheManagerProxy-invalidate();
+#if ENABLE(NETWORK_INFO)
+m_networkInfoManagerProxy-invalidate();
+#endif

[webkit-changes] [122501] trunk

2012-07-12 Thread commit-queue

Title: [122501] trunk








Revision 122501
Author commit-qu...@webkit.org
Date 2012-07-12 13:48:39 -0700 (Thu, 12 Jul 2012)


Log Message
Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.
https://bugs.webkit.org/show_bug.cgi?id=9493

Patch by Pravin D pravind@gmail.com on 2012-07-12
Reviewed by Andy Estes.

Source/WebCore:

When the width of the container is zero percent/fixed value then the width of the replaced element must also be zero.

Test: fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
  When the containing block's available width is zero there can be two cases.
  The containing block is floated/positioned in which case the width of the replaced child element must be its instrinsic width.
  On the other hand if the width of the container is specified to be either zero percent or fixed value then the width of the
  replaced elment must be zero.

LayoutTests:

* fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added.
* fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added.
* fast/css/resources/red-box.png: Added.
  Image resource file for the test case.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp


Added Paths

trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html
trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html
trunk/LayoutTests/fast/css/resources/red-box.png




Diff

Modified: trunk/LayoutTests/ChangeLog (122500 => 122501)

--- trunk/LayoutTests/ChangeLog	2012-07-12 20:44:45 UTC (rev 122500)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 20:48:39 UTC (rev 122501)
@@ -1,3 +1,15 @@
+2012-07-12  Pravin D  pravind@gmail.com
+
+Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.
+https://bugs.webkit.org/show_bug.cgi?id=9493
+
+Reviewed by Andy Estes.
+
+* fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html: Added.
+* fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html: Added.
+* fast/css/resources/red-box.png: Added.
+  Image resource file for the test case.
+
 2012-07-12  Dirk Pranke  dpra...@chromium.org
 
 Remove chromium-mac-leopard baselines.


Added: trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html (0 => 122501)

--- trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container-expected.html	2012-07-12 20:48:39 UTC (rev 122501)
@@ -0,0 +1,20 @@
+!DOCTYPE html
+html
+head
+titleTest case for https://bugs.webkit.org/show_bug.cgi?id=9493/title
+style type=text/css
+  #fixedContainer { width: 0px }
+  #percentContainer { width: 0% }
+/style
+/head
+body
+ h4 There should be no red squares visible below. /h4
+ div style=background-color:green;position:absolute;width:64px;height:64px
+   div id=fixedContainer/div
+ /div
+  div style=background-color:green;position:absolute;width:64px;height:64px;top:130px
+   div id=percentContainer/div
+  /div
+ /div
+/body
+/html


Added: trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html (0 => 122501)

--- trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html	(rev 0)
+++ trunk/LayoutTests/fast/css/percent-width-img-inside-zero-percent-and-fixed-container.html	2012-07-12 20:48:39 UTC (rev 122501)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+html
+head
+titleTest case for https://bugs.webkit.org/show_bug.cgi?id=9493/title
+style type=text/css
+  #fixedContainer { width: 0px }
+  #percentContainer { width: 0% }
+  .test { width: 100%; }
+/style
+/head
+body
+ h4 There should be no red squares visible below. /h4
+ div style=background-color:green;position:absolute;width:64px;height:64px
+   div id=fixedContainer
+ img class=test src=""
+   /div
+ /div
+  div style=background-color:green;position:absolute;width:64px;height:64px;top:130px
+   div id=percentContainer
+ img class=test src=""
+   /div
+  /div
+ /div
+/body
+/html


Added: trunk/LayoutTests/fast/css/resources/red-box.png (0 => 122501)

--- trunk/LayoutTests/fast/css/resources/red-box.png	(rev 0)
+++ trunk/LayoutTests/fast/css/resources/red-box.png	2012-07-12 20:48:39 UTC (rev 122501)
@@ -0,0 +1,6 @@
+\x89PNG
+
+
+IHDR@@\xAAiq\xDEsRGB\xAE\xCE\xE9gAMA\xB1\x8F\xFCa	pHYs\xC4\xC4\x95+\x8FIDATx^\xED\xD7\xC1
+\xC00İ\xDB\xE8$\xC8

[webkit-changes] [122502] trunk

2012-07-12 Thread jchaffraix

Title: [122502] trunk








Revision 122502
Author jchaffr...@webkit.org
Date 2012-07-12 13:53:58 -0700 (Thu, 12 Jul 2012)


Log Message
ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered on flex-box content
https://bugs.webkit.org/show_bug.cgi?id=91003

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/flexbox/assert-generated-deprecated-flexbox.html
   fast/flexbox/assert-generated-new-flexbox.html

The issue was that findBeforeAfterParent didn't return the right parent for the flex-box case. This would
make us update the wrong children (and not propagate the style updates properly).

* rendering/RenderObjectChildList.cpp:
(WebCore::findBeforeAfterParent):
Added a check for flex boxes (both deprecated and new).

LayoutTests:

* fast/flexbox/assert-generated-deprecated-flexbox-expected.txt: Added.
* fast/flexbox/assert-generated-deprecated-flexbox.html: Added.
* fast/flexbox/assert-generated-new-flexbox-expected.txt: Added.
* fast/flexbox/assert-generated-new-flexbox.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp


Added Paths

trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox-expected.txt
trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html
trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox-expected.txt
trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122501 => 122502)

--- trunk/LayoutTests/ChangeLog	2012-07-12 20:48:39 UTC (rev 122501)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 20:53:58 UTC (rev 122502)
@@ -1,3 +1,15 @@
+2012-07-12  Julien Chaffraix  jchaffr...@webkit.org
+
+ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered on flex-box content
+https://bugs.webkit.org/show_bug.cgi?id=91003
+
+Reviewed by Abhishek Arya.
+
+* fast/flexbox/assert-generated-deprecated-flexbox-expected.txt: Added.
+* fast/flexbox/assert-generated-deprecated-flexbox.html: Added.
+* fast/flexbox/assert-generated-new-flexbox-expected.txt: Added.
+* fast/flexbox/assert-generated-new-flexbox.html: Added.
+
 2012-07-12  Pravin D  pravind@gmail.com
 
 Percentage width replaced element in zero percent/fixed width container block incorrectly rendered.


Added: trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox-expected.txt (0 => 122502)

--- trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox-expected.txt	2012-07-12 20:53:58 UTC (rev 122502)
@@ -0,0 +1,5 @@
+Bug 91003: ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered on flex-box content
+
+This test has passed if it doesn't crash or ASSERT.
+
+


Added: trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html (0 => 122502)

--- trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html	(rev 0)
+++ trunk/LayoutTests/fast/flexbox/assert-generated-deprecated-flexbox.html	2012-07-12 20:53:58 UTC (rev 122502)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+style
+div:after {
+content: 'Generated content wrapped in a flex-box.';
+display: -webkit-box;
+}
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+pBug a href="" ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered on flex-box content/p
+pThis test has passed if it doesn't crash or ASSERT./p
+div/div
+/html


Added: trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox-expected.txt (0 => 122502)

--- trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox-expected.txt	2012-07-12 20:53:58 UTC (rev 122502)
@@ -0,0 +1,5 @@
+Bug 91003: ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered on flex-box content
+
+This test has passed if it doesn't crash or ASSERT.
+
+


Added: trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox.html (0 => 122502)

--- trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox.html	(rev 0)
+++ trunk/LayoutTests/fast/flexbox/assert-generated-new-flexbox.html	2012-07-12 20:53:58 UTC (rev 122502)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+style
+div:after {
+content: 'Generated content wrapped in a flex-box.';
+display: -webkit-flex;
+}
+/style
+script
+if (window.testRunner)
+testRunner.dumpAsText();
+/script
+pBug a href="" ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered

[webkit-changes] [122504] trunk/LayoutTests

2012-07-12 Thread abarth

Title: [122504] trunk/LayoutTests








Revision 122504
Author aba...@webkit.org
Date 2012-07-12 14:09:59 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed.  Delete two empty directories.

* platform/google-chrome-linux32: Removed.
* platform/google-chrome-linux64: Removed.

Modified Paths

trunk/LayoutTests/ChangeLog


Removed Paths

trunk/LayoutTests/platform/google-chrome-linux32/
trunk/LayoutTests/platform/google-chrome-linux64/




Diff

Modified: trunk/LayoutTests/ChangeLog (122503 => 122504)

--- trunk/LayoutTests/ChangeLog	2012-07-12 21:06:18 UTC (rev 122503)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 21:09:59 UTC (rev 122504)
@@ -1,3 +1,10 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+Unreviewed.  Delete two empty directories.
+
+* platform/google-chrome-linux32: Removed.
+* platform/google-chrome-linux64: Removed.
+
 2012-07-12  Julien Chaffraix  jchaffr...@webkit.org
 
 ASSERT(genChild-isListMarker() || genChild-style()-styleType() == FIRST_LETTER) triggered on flex-box content






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122505] trunk

2012-07-12 Thread dpranke

Title: [122505] trunk








Revision 122505
Author dpra...@chromium.org
Date 2012-07-12 14:22:13 -0700 (Thu, 12 Jul 2012)


Log Message
nrwt crashes saving the output for a platform-specific expected test reference
https://bugs.webkit.org/show_bug.cgi?id=90872

Reviewed by Ojan Vafai.

Tools:

The expected output for a test is copied alongside the test
itself in the layout-test-results directory; in other words, for
foo/bar-expected.txt sits alongside foo/bar.html even if we're
actually using platform/mac/foo/bar-expected.txt.

Unless the test is a reftest, in which case we would copy the
output to platform/mac/foo/bar-expected.html and set a
'ref_file' parameter in results.json to indicate the path. This
can be useful in the cases where we have multiple references for
a single test or when multiple tests share the same reference.

We found a bug where we weren't creating platform/mac/foo under
the results directory, and so this wasn't actually working.
However, treating reftests differently seems like a bad thing,
so we should probably be consistent. This change puts the
-expected.html next to the test, and reworks test_result_writer
so that we create directories uniformly and consistently.

Note that we weren't catching this problem in unit tests because
the MockFileSystem creates a directory automatically if it
doesn't exist; this was done intentionally for convenience, but
is really a bug and should be fixed; see https://bugs.webkit.org/show_bug.cgi?id=91028.

I have not added additional tests here since fixing that bug
should be sufficient.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(interpret_test_failures):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ResultSummaryTest.test_interpret_test_failures):
* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):
(TestResultWriter._write_binary_file):
(TestResultWriter):
(TestResultWriter._write_text_file):
(TestResultWriter.write_output_files):
(TestResultWriter.write_stderr):
(TestResultWriter.write_crash_log):
(TestResultWriter.create_text_diff_and_write_result):
(TestResultWriter.write_image_diff_files):
(write_reftest):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Remove tests for the 'ref_file' parameter in results.json
entries.

* fast/harness/resources/results-test.js:
* fast/harness/results.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/resources/results-test.js
trunk/LayoutTests/fast/harness/results.html
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py




Diff

Modified: trunk/LayoutTests/ChangeLog (122504 => 122505)

--- trunk/LayoutTests/ChangeLog	2012-07-12 21:09:59 UTC (rev 122504)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 21:22:13 UTC (rev 122505)
@@ -1,3 +1,16 @@
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
+nrwt crashes saving the output for a platform-specific expected test reference
+https://bugs.webkit.org/show_bug.cgi?id=90872
+
+Reviewed by Ojan Vafai.
+
+Remove tests for the 'ref_file' parameter in results.json
+entries.
+
+* fast/harness/resources/results-test.js:
+* fast/harness/results.html:
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 Unreviewed.  Delete two empty directories.


Modified: trunk/LayoutTests/fast/harness/resources/results-test.js (122504 => 122505)

--- trunk/LayoutTests/fast/harness/resources/results-test.js	2012-07-12 21:09:59 UTC (rev 122504)
+++ trunk/LayoutTests/fast/harness/resources/results-test.js	2012-07-12 21:22:13 UTC (rev 122505)
@@ -8,7 +8,7 @@
 document.querySelector('head').appendChild(testStyles);
 
 var g_testIndex = 0;
-var g_log = [You should see a serios of PASS lines.];
+var g_log = [You should see a series of PASS lines.];
 
 // Make async actually be sync for the sake of simpler testing.
 function async(func, args)
@@ -274,25 +274,8 @@
 results.tests['bar-reftest-mismatch.html'].is_mismatch_reftest = true;
 runSingleRowTest(results, false, '', 'ref mismatch html actual ');
 
-results = mockResults();
-results.tests['bar-reftest.html'] = mockExpectation('PASS', 'IMAGE', 1);
-results.tests['bar-reftest.html'].is_reftest = true;
-results.tests['bar-reftest.html'].ref_file = 'common.html';
-runSingleRowTest(results, false, '', 'ref html images diff (1%) ');
-runTest(results, function() {
-assertTrue(document.getElementsByClassName('result-link')[0].getAttribute('href') == 'common.html');
-});
 
 results = mockResults();
-results.tests['bar-reftest.html'] = mockExpectation('PASS', 'IMAGE');
-

[webkit-changes] [122507] trunk/Source/WebKit/qt

2012-07-12 Thread kseo

Title: [122507] trunk/Source/WebKit/qt








Revision 122507
Author k...@webkit.org
Date 2012-07-12 14:37:30 -0700 (Thu, 12 Jul 2012)


Log Message
[Qt] Increase the drawing performance by merging dirty rects.
https://bugs.webkit.org/show_bug.cgi?id=91075

Patch by Huang Dongsung luxte...@company100.net on 2012-07-12
Reviewed by Noam Rosenthal.

QWebFramePrivate calls FrameView::paintContents as many as the number of dirty
rects, so it causes too many redundant render tree traversals.
I changed it to merge dirty rects and call FrameView::paintContents only once.
The algorithm to merge rects is copied from GTK.

When parallel image decoders are in use, each image is independently repainted
when decoding is finished. This creates a lot by repaint requests. So by merging
these repaint requests, I could improve rendering performance.

For example, I tested parallel image decoders on the locally mirrored Pinterest site.
QWebFramePrivate called FrameView::paintContents 165 times after parallel image
decoders decoded all the images. It took about 120ms on my six-core Intel Xeon machine.
This patch decreases painting time from 120ms to 30ms.

* Api/qwebframe.cpp:
(coalesceRectsIfPossible):
(QWebFramePrivate::renderRelativeCoords):

Modified Paths

trunk/Source/WebKit/qt/Api/qwebframe.cpp
trunk/Source/WebKit/qt/ChangeLog




Diff

Modified: trunk/Source/WebKit/qt/Api/qwebframe.cpp (122506 => 122507)

--- trunk/Source/WebKit/qt/Api/qwebframe.cpp	2012-07-12 21:35:34 UTC (rev 122506)
+++ trunk/Source/WebKit/qt/Api/qwebframe.cpp	2012-07-12 21:37:30 UTC (rev 122507)
@@ -356,6 +356,32 @@
 }
 #endif
 
+// This code is copied from ChromeClientGtk.cpp.
+static void coalesceRectsIfPossible(const QRect clipRect, QVectorQRect rects)
+{
+const unsigned int rectThreshold = 10;
+const float wastedSpaceThreshold = 0.75f;
+bool useUnionedRect = (rects.size() = 1) || (rects.size()  rectThreshold);
+if (!useUnionedRect) {
+// Attempt to guess whether or not we should use the unioned rect or the individual rects.
+// We do this by computing the percentage of wasted space in the union. If that wasted space
+// is too large, then we will do individual rect painting instead.
+float unionPixels = (clipRect.width() * clipRect.height());
+float singlePixels = 0;
+for (size_t i = 0; i  rects.size(); ++i)
+singlePixels += rects[i].width() * rects[i].height();
+float wastedSpace = 1 - (singlePixels / unionPixels);
+if (wastedSpace = wastedSpaceThreshold)
+useUnionedRect = true;
+}
+
+if (!useUnionedRect)
+return;
+
+rects.clear();
+rects.append(clipRect);
+}
+
 void QWebFramePrivate::renderRelativeCoords(GraphicsContext* context, QFlagsQWebFrame::RenderLayer layers, const QRegion clip)
 {
 if (!frame-view() || !frame-contentRenderer())
@@ -371,6 +397,8 @@
 view-updateLayoutAndStyleIfNeededRecursive();
 
 if (layers  QWebFrame::ContentsLayer) {
+QRect clipBoundingRect = clip.boundingRect();
+coalesceRectsIfPossible(clipBoundingRect, vector);
 for (int i = 0; i  vector.size(); ++i) {
 const QRect clipRect = vector.at(i);
 
@@ -396,7 +424,7 @@
 context-restore();
 }
 #if USE(ACCELERATED_COMPOSITING)
-renderCompositedLayers(context, IntRect(clip.boundingRect()));
+renderCompositedLayers(context, IntRect(clipBoundingRect));
 #endif
 }
 renderFrameExtras(context, layers, clip);


Modified: trunk/Source/WebKit/qt/ChangeLog (122506 => 122507)

--- trunk/Source/WebKit/qt/ChangeLog	2012-07-12 21:35:34 UTC (rev 122506)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-07-12 21:37:30 UTC (rev 122507)
@@ -1,3 +1,28 @@
+2012-07-12  Huang Dongsung  luxte...@company100.net
+
+[Qt] Increase the drawing performance by merging dirty rects.
+https://bugs.webkit.org/show_bug.cgi?id=91075
+
+Reviewed by Noam Rosenthal.
+
+QWebFramePrivate calls FrameView::paintContents as many as the number of dirty
+rects, so it causes too many redundant render tree traversals.
+I changed it to merge dirty rects and call FrameView::paintContents only once.
+The algorithm to merge rects is copied from GTK.
+
+When parallel image decoders are in use, each image is independently repainted
+when decoding is finished. This creates a lot by repaint requests. So by merging
+these repaint requests, I could improve rendering performance.
+
+For example, I tested parallel image decoders on the locally mirrored Pinterest site.
+QWebFramePrivate called FrameView::paintContents 165 times after parallel image
+decoders decoded all the images. It took about 120ms on my six-core Intel Xeon machine.
+This patch decreases painting time from 120ms to 30ms.
+
+* Api/qwebframe.cpp:
+(coalesceRectsIfPossible):
+(QWebFramePrivate::renderRelativeCoords):
+

[webkit-changes] [122508] trunk

2012-07-12 Thread ojan

Title: [122508] trunk








Revision 122508
Author o...@chromium.org
Date 2012-07-12 14:38:33 -0700 (Thu, 12 Jul 2012)


Log Message
Implied minimum size of flex items is min-content
https://bugs.webkit.org/show_bug.cgi?id=87546

Reviewed by Tony Chang.

Source/WebCore:

http://dev.w3.org/csswg/css3-flexbox/#min-size-auto
In the main axis direction, min-size of auto means min-content.

Test: css3/flexbox/flex-item-min-size.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeContentLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
It turned out that these FIXMEs are all unnecessary with the changes to RenderFlexibleBox.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

LayoutTests:

Mostly just set min-height/min-width:0 as appropriate to keep the tests testing
what the used to be testing. I made sure that each rendering was correct before
making the changes. In a couple cases, I changed expectations where I thought
the test was still testing was it was intending to test.

* css3/flexbox/child-overflow.html:
* css3/flexbox/columns-auto-size.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/flex-item-min-size-expected.txt: Added.
* css3/flexbox/flex-item-min-size.html: Added.
* css3/flexbox/flexitem.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
* css3/flexbox/repaint-rtl-column.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/flexbox/child-overflow.html
trunk/LayoutTests/css3/flexbox/columns-auto-size.html
trunk/LayoutTests/css3/flexbox/cross-axis-scrollbar.html
trunk/LayoutTests/css3/flexbox/flexitem.html
trunk/LayoutTests/css3/flexbox/line-wrapping.html
trunk/LayoutTests/css3/flexbox/perpendicular-writing-modes-inside-flex-item.html
trunk/LayoutTests/css3/flexbox/repaint-rtl-column.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp


Added Paths

trunk/LayoutTests/css3/flexbox/flex-item-min-size-expected.txt
trunk/LayoutTests/css3/flexbox/flex-item-min-size.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122507 => 122508)

--- trunk/LayoutTests/ChangeLog	2012-07-12 21:37:30 UTC (rev 122507)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 21:38:33 UTC (rev 122508)
@@ -1,3 +1,25 @@
+2012-07-12  Ojan Vafai  o...@chromium.org
+
+Implied minimum size of flex items is min-content
+https://bugs.webkit.org/show_bug.cgi?id=87546
+
+Reviewed by Tony Chang.
+
+Mostly just set min-height/min-width:0 as appropriate to keep the tests testing
+what the used to be testing. I made sure that each rendering was correct before
+making the changes. In a couple cases, I changed expectations where I thought
+the test was still testing was it was intending to test.
+
+* css3/flexbox/child-overflow.html:
+* css3/flexbox/columns-auto-size.html:
+* css3/flexbox/cross-axis-scrollbar.html:
+* css3/flexbox/flex-item-min-size-expected.txt: Added.
+* css3/flexbox/flex-item-min-size.html: Added.
+* css3/flexbox/flexitem.html:
+* css3/flexbox/line-wrapping.html:
+* css3/flexbox/perpendicular-writing-modes-inside-flex-item.html:
+* css3/flexbox/repaint-rtl-column.html:
+
 2012-07-12  Dirk Pranke  dpra...@chromium.org
 
 nrwt crashes saving the output for a platform-specific expected test reference


Modified: trunk/LayoutTests/css3/flexbox/child-overflow.html (122507 => 122508)

--- trunk/LayoutTests/css3/flexbox/child-overflow.html	2012-07-12 21:37:30 UTC (rev 122507)
+++ trunk/LayoutTests/css3/flexbox/child-overflow.html	2012-07-12 21:38:33 UTC (rev 122508)
@@ -48,6 +48,8 @@
 
 .flexbox  div {
 overflow: auto;
+min-width: 0;
+min-height: 0;
 }
 
 .flexbox  div  div {


Modified: trunk/LayoutTests/css3/flexbox/columns-auto-size.html (122507 => 122508)

--- trunk/LayoutTests/css3/flexbox/columns-auto-size.html	2012-07-12 21:37:30 UTC (rev 122507)
+++ trunk/LayoutTests/css3/flexbox/columns-auto-size.html	2012-07-12 21:38:33 UTC (rev 122508)
@@ -59,7 +59,7 @@
   div data-expected-height=0 data-offset-y=0 style=-webkit-flex: 1/div
   div data-expected-height=10 data-offset-y=0 style=height: 10px;/div
   div data-expected-height=10 data-offset-y=10 style=-webkit-flex: 1 autodiv style=height: 10px/div/div
-  div data-expected-height=0 data-offset-y=20 style=-webkit-flex: 1div data-expected-height=10 data-offset-y=20 class=child-div style=height: 10px/div/div
+  div data-expected-height=0 data-offset-y=20 style=min-height: 0; -webkit-flex: 1div

[webkit-changes] [122509] trunk

2012-07-12 Thread abarth

Title: [122509] trunk








Revision 122509
Author aba...@webkit.org
Date 2012-07-12 14:41:20 -0700 (Thu, 12 Jul 2012)


Log Message
Regression (r122359) Layout Test html5lib/runner.html is failing
https://bugs.webkit.org/show_bug.cgi?id=91047

Reviewed by Tony Chang.

Source/WebCore: 

This ASSERT is bogus because doctypes can be removed from the DOM and
then re-added.

Test: fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html

* dom/Document.cpp:
(WebCore::Document::setDocType):

LayoutTests: 

Add a test that shows what happens when a doctype gets added and
removed.

* fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt: Added.
* fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html: Added.
* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp


Added Paths

trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt
trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122508 => 122509)

--- trunk/LayoutTests/ChangeLog	2012-07-12 21:38:33 UTC (rev 122508)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 21:41:20 UTC (rev 122509)
@@ -1,3 +1,17 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+Regression (r122359) Layout Test html5lib/runner.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=91047
+
+Reviewed by Tony Chang.
+
+Add a test that shows what happens when a doctype gets added and
+removed.
+
+* fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt: Added.
+* fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html: Added.
+* platform/chromium/TestExpectations:
+
 2012-07-12  Ojan Vafai  o...@chromium.org
 
 Implied minimum size of flex items is min-content


Added: trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt (0 => 122509)

--- trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add-expected.txt	2012-07-12 21:41:20 UTC (rev 122509)
@@ -0,0 +1,4 @@
+ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true
+ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true
+ALERT: viewport size 320x480 scale 1 with limits [1, 5] and userScalable true
+


Added: trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html (0 => 122509)

--- trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html	(rev 0)
+++ trunk/LayoutTests/fast/viewport/viewport-legacy-xhtmlmp-remove-and-add.html	2012-07-12 21:41:20 UTC (rev 122509)
@@ -0,0 +1,37 @@
+?xml version=1.0 encoding=utf-8?
+!DOCTYPE html PUBLIC -//WAPFORUM//DTD XHTML Mobile 1.0//EN http://www.wapforum.org/DTD/xhtml-mobile10.dtd
+head
+!--
+Related spec: http://www.w3.org/TR/css-device-adapt/
+
+XHTML-MP is used for mobile documents which are assumed to be designed for
+handheld devices, hence using the viewport size as the initial containing
+block size, so using XHTML-MP will give the same result as a viewport
+meta tag with the following parameters:
+
+width=device-width, height=device-height, initial-scale=1
+
+--
+titleDefault viewport value changed by XHTML-MP/title
+script
+function test() {
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+if (window.internals)
+alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));
+
+var originalDoctype = document.doctype;
+document.removeChild(originalDoctype);
+
+if (window.internals)
+alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));
+
+document.insertBefore(originalDoctype, document.firstChild);
+
+if (window.internals)
+alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));
+}
+/script
+/head
+body _onload_=test(); /


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122508 => 122509)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 21:38:33 UTC (rev 122508)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 21:41:20 UTC (rev 122509)
@@ -3744,8 +3744,5 @@
 BUGWK90980 LINUX MAC DEBUG : fast/forms/textarea/textarea-state-restore.html = PASS TIMEOUT
 BUGWK90980 WIN : fast/forms/textarea/textarea-state-restore.html = PASS TIMEOUT
 
-// Started crashing after r122359
-BUGWK91047 DEBUG : html5lib/runner.html = CRASH
-
 // Started crashing after 122286
 BUGWK91133 WIN : storage/indexeddb/constants.html = PASS CRASH


Modified: trunk/Source/WebCore/ChangeLog

[webkit-changes] [122510] trunk/LayoutTests/fast/wcss/

2012-07-12 Thread abarth

Title: [122510] trunk/LayoutTests/fast/wcss/








Revision 122510
Author aba...@webkit.org
Date 2012-07-12 14:42:27 -0700 (Thu, 12 Jul 2012)


Log Message
Delete another empty directory.

Removed Paths

trunk/LayoutTests/fast/wcss/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122511] trunk/Source

2012-07-12 Thread danakj

Title: [122511] trunk/Source








Revision 122511
Author dan...@chromium.org
Date 2012-07-12 14:42:31 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] The root layer should not try create a second RenderSurface for itself
https://bugs.webkit.org/show_bug.cgi?id=91124

Reviewed by Adrienne Walker.

Source/WebCore:

Tests: CCLayerTreeHostImplTest.rootLayerDoesntCreateExtraSurface

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122510 => 122511)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 21:42:27 UTC (rev 122510)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 21:42:31 UTC (rev 122511)
@@ -1,3 +1,15 @@
+2012-07-12  Dana Jansens  dan...@chromium.org
+
+[chromium] The root layer should not try create a second RenderSurface for itself
+https://bugs.webkit.org/show_bug.cgi?id=91124
+
+Reviewed by Adrienne Walker.
+
+Tests: CCLayerTreeHostImplTest.rootLayerDoesntCreateExtraSurface
+
+* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
+(WebCore::subtreeShouldRenderToSeparateSurface):
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 Regression (r122359) Layout Test html5lib/runner.html is failing


Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp (122510 => 122511)

--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp	2012-07-12 21:42:27 UTC (rev 122510)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp	2012-07-12 21:42:31 UTC (rev 122511)
@@ -261,6 +261,11 @@
 templatetypename LayerType
 static bool subtreeShouldRenderToSeparateSurface(LayerType* layer, bool axisAlignedWithRespectToParent)
 {
+// The root layer has a special render surface that is set up externally, so
+// it shouldn't be treated as a surface in this code.
+if (!layer-parent())
+return false;
+
 // Cache this value, because otherwise it walks the entire subtree several times.
 bool descendantDrawsContent = layer-descendantDrawsContent();
 


Modified: trunk/Source/WebKit/chromium/ChangeLog (122510 => 122511)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 21:42:27 UTC (rev 122510)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 21:42:31 UTC (rev 122511)
@@ -1,3 +1,12 @@
+2012-07-12  Dana Jansens  dan...@chromium.org
+
+[chromium] The root layer should not try create a second RenderSurface for itself
+https://bugs.webkit.org/show_bug.cgi?id=91124
+
+Reviewed by Adrienne Walker.
+
+* tests/CCLayerTreeHostImplTest.cpp:
+
 2012-07-12  Eric Penner  epen...@google.com
 
 [chromium] Use CCTexture/TextureAllocator and remove TextureManager


Modified: trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (122510 => 122511)

--- trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2012-07-12 21:42:27 UTC (rev 122510)
+++ trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	2012-07-12 21:42:31 UTC (rev 122511)
@@ -1628,6 +1628,28 @@
 EXPECT_EQ(expectedSwapRect.height(), actualSwapRect.height());
 }
 
+TEST_F(CCLayerTreeHostImplTest, rootLayerDoesntCreateExtraSurface)
+{
+CCLayerImpl* root = new FakeDrawableCCLayerImpl(1);
+CCLayerImpl* child = new FakeDrawableCCLayerImpl(2);
+child-setAnchorPoint(FloatPoint(0, 0));
+child-setBounds(IntSize(10, 10));
+child-setDrawsContent(true);
+root-setAnchorPoint(FloatPoint(0, 0));
+root-setBounds(IntSize(10, 10));
+root-setDrawsContent(true);
+root-setOpacity(0.7f);
+root-addChild(adoptPtr(child));
+
+m_hostImpl-setRootLayer(adoptPtr(root));
+
+CCLayerTreeHostImpl::FrameData frame;
+
+EXPECT_TRUE(m_hostImpl-prepareToDraw(frame));
+EXPECT_EQ(1u, frame.renderSurfaceLayerList-size());
+EXPECT_EQ(1u, frame.renderPasses.size());
+}
+
 } // namespace
 
 class FakeLayerWithQuads : public CCLayerImpl {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122512] trunk/Source/WebKit2

2012-07-12 Thread commit-queue

Title: [122512] trunk/Source/WebKit2








Revision 122512
Author commit-qu...@webkit.org
Date 2012-07-12 14:46:04 -0700 (Thu, 12 Jul 2012)


Log Message
[EFL] Port the test framework to WebKit 2
https://bugs.webkit.org/show_bug.cgi?id=90606

Patch by Thiago Marcos P. Santos thiago.san...@intel.com on 2012-07-12
Reviewed by Kenneth Rohde Christiansen.

This port of EFL's WebKit 1 test framework uses a more gtest-ish
way of writing tests and it is based on a test fixture that loads a
page synchronously as convenience (if needed). This base fixture can be
easily extended by just inheriting from it.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp: Added.
(EWK2UnitTest):
(EWK2UnitTest::onLoadProgress):
(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::SetUp):
(EWK2UnitTest::EWK2UnitTestBase::TearDown):
(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h: Added.
(EWK2UnitTest):
(EWK2UnitTestBase):
(EWK2UnitTest::EWK2UnitTestBase::setLoadProgress):
(EWK2UnitTest::EWK2UnitTestBase::webView):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp: Added.
(EWK2UnitTest):
(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTestPageUrl):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h: Added.
(EWK2UnitTest):
(EWK2UnitTestEnvironment):
(EWK2UnitTest::EWK2UnitTestEnvironment::useX11Window):
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultWidth):
(EWK2UnitTest::EWK2UnitTestEnvironment::defaultHeight):
* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp: Added.
(parseArguments):
(main):
* UIProcess/API/efl/tests/resources/default_test_page.html: Added.
* UIProcess/API/efl/tests/test_ewk2_view.cpp: Added.
(TEST_F):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake


Added Paths

trunk/Source/WebKit2/UIProcess/API/efl/tests/
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h
trunk/Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/
trunk/Source/WebKit2/UIProcess/API/efl/tests/resources/default_test_page.html
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122511 => 122512)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 21:42:31 UTC (rev 122511)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 21:46:04 UTC (rev 122512)
@@ -1,3 +1,45 @@
+2012-07-12  Thiago Marcos P. Santos  thiago.san...@intel.com
+
+[EFL] Port the test framework to WebKit 2
+https://bugs.webkit.org/show_bug.cgi?id=90606
+
+Reviewed by Kenneth Rohde Christiansen.
+
+This port of EFL's WebKit 1 test framework uses a more gtest-ish
+way of writing tests and it is based on a test fixture that loads a
+page synchronously as convenience (if needed). This base fixture can be
+easily extended by just inheriting from it.
+
+* PlatformEfl.cmake:
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp: Added.
+(EWK2UnitTest):
+(EWK2UnitTest::onLoadProgress):
+(EWK2UnitTest::EWK2UnitTestBase::EWK2UnitTestBase):
+(EWK2UnitTest::EWK2UnitTestBase::SetUp):
+(EWK2UnitTest::EWK2UnitTestBase::TearDown):
+(EWK2UnitTest::EWK2UnitTestBase::loadUrlSync):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h: Added.
+(EWK2UnitTest):
+(EWK2UnitTestBase):
+(EWK2UnitTest::EWK2UnitTestBase::setLoadProgress):
+(EWK2UnitTest::EWK2UnitTestBase::webView):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp: Added.
+(EWK2UnitTest):
+(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
+(EWK2UnitTest::EWK2UnitTestEnvironment::defaultTestPageUrl):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h: Added.
+(EWK2UnitTest):
+(EWK2UnitTestEnvironment):
+(EWK2UnitTest::EWK2UnitTestEnvironment::useX11Window):
+(EWK2UnitTest::EWK2UnitTestEnvironment::defaultWidth):
+(EWK2UnitTest::EWK2UnitTestEnvironment::defaultHeight):
+* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp: Added.
+(parseArguments):
+(main):
+* UIProcess/API/efl/tests/resources/default_test_page.html: Added.
+* UIProcess/API/efl/tests/test_ewk2_view.cpp: Added.
+(TEST_F):
+
 2012-07-12  Christophe Dumez  christophe.du...@intel.com
 
 [WK2] Add

[webkit-changes] [122513] trunk/Tools

2012-07-12 Thread dpranke

Title: [122513] trunk/Tools








Revision 122513
Author dpra...@chromium.org
Date 2012-07-12 14:55:37 -0700 (Thu, 12 Jul 2012)


Log Message
webkitpy: rename manager_worker_broker to message_pool
https://bugs.webkit.org/show_bug.cgi?id=91145

Reviewed by Ojan Vafai.

Since the MessagePool interface is more generic (and simpler)
now and will be reused by test-webkitpy, I'm renaming it and
moving it to webkitpy.common.

* Scripts/webkitpy/common/message_pool.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(TestRunInterruptedException.__reduce__):
(Manager._run_tests.worker_factory):
(Manager._run_tests):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py


Added Paths

trunk/Tools/Scripts/webkitpy/common/message_pool.py


Removed Paths

trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py




Diff

Modified: trunk/Tools/ChangeLog (122512 => 122513)

--- trunk/Tools/ChangeLog	2012-07-12 21:46:04 UTC (rev 122512)
+++ trunk/Tools/ChangeLog	2012-07-12 21:55:37 UTC (rev 122513)
@@ -1,5 +1,23 @@
 2012-07-12  Dirk Pranke  dpra...@chromium.org
 
+webkitpy: rename manager_worker_broker to message_pool
+https://bugs.webkit.org/show_bug.cgi?id=91145
+
+Reviewed by Ojan Vafai.
+
+Since the MessagePool interface is more generic (and simpler)
+now and will be reused by test-webkitpy, I'm renaming it and
+moving it to webkitpy.common.
+
+* Scripts/webkitpy/common/message_pool.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py.
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(TestRunInterruptedException.__reduce__):
+(Manager._run_tests.worker_factory):
+(Manager._run_tests):
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
 nrwt crashes saving the output for a platform-specific expected test reference
 https://bugs.webkit.org/show_bug.cgi?id=90872
 


Copied: trunk/Tools/Scripts/webkitpy/common/message_pool.py (from rev 122511, trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py) (0 => 122513)

--- trunk/Tools/Scripts/webkitpy/common/message_pool.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/common/message_pool.py	2012-07-12 21:55:37 UTC (rev 122513)
@@ -0,0 +1,310 @@
+# Copyright (C) 2011 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+# * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+# * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# AS IS AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+Module for handling messages and concurrency for run-webkit-tests
+and test-webkitpy. This module follows the design for multiprocessing.Pool
+and concurrency.futures.ProcessPoolExecutor, with the following differences:
+
+* Tasks are executed in stateful subprocesses via objects that implement the
+  Worker interface - this allows the workers to share state across tasks.
+* The pool provides an asynchronous event-handling interface so the caller
+  may receive events as tasks are processed.
+
+If you don't need these features, use multiprocessing.Pool or concurrency.futures
+intead.
+
+
+
+import cPickle
+import logging
+import multiprocessing
+import Queue
+import sys
+import time
+import traceback
+
+
+from webkitpy.common.host

[webkit-changes] [122514] trunk/LayoutTests

2012-07-12 Thread dpranke

Title: [122514] trunk/LayoutTests








Revision 122514
Author dpra...@chromium.org
Date 2012-07-12 15:05:44 -0700 (Thu, 12 Jul 2012)


Log Message
rebaseline fast/harness/results.html after r122505.

Unreviewed, expectations change.

* fast/harness/results-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/results-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (122513 => 122514)

--- trunk/LayoutTests/ChangeLog	2012-07-12 21:55:37 UTC (rev 122513)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 22:05:44 UTC (rev 122514)
@@ -1,3 +1,11 @@
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
+rebaseline fast/harness/results.html after r122505.
+
+Unreviewed, expectations change.
+
+* fast/harness/results-expected.txt:
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 Regression (r122359) Layout Test html5lib/runner.html is failing


Modified: trunk/LayoutTests/fast/harness/results-expected.txt (122513 => 122514)

--- trunk/LayoutTests/fast/harness/results-expected.txt	2012-07-12 21:55:37 UTC (rev 122513)
+++ trunk/LayoutTests/fast/harness/results-expected.txt	2012-07-12 22:05:44 UTC (rev 122514)
@@ -1,4 +1,4 @@
-You should see a serios of PASS lines.
+You should see a series of PASS lines.
 TEST-1: PASS
 TEST-1: PASS
 TEST-1: PASS
@@ -96,131 +96,117 @@
 TEST-16: PASS
 TEST-16: PASS
 TEST-16: PASS
-TEST-16: PASS
-TEST-16: PASS
-TEST-16: PASS
 TEST-17: PASS
+TEST-17: PASS
+TEST-17: PASS
 TEST-18: PASS
 TEST-18: PASS
 TEST-18: PASS
 TEST-18: PASS
-TEST-18: PASS
-TEST-18: PASS
 TEST-19: PASS
+TEST-19: PASS
 TEST-20: PASS
 TEST-20: PASS
 TEST-20: PASS
+TEST-20: PASS
+TEST-20: PASS
 TEST-21: PASS
 TEST-21: PASS
-TEST-21: PASS
 TEST-22: PASS
 TEST-22: PASS
-TEST-22: PASS
-TEST-22: PASS
 TEST-23: PASS
-TEST-23: PASS
 TEST-24: PASS
 TEST-24: PASS
-TEST-24: PASS
-TEST-24: PASS
-TEST-24: PASS
 TEST-25: PASS
-TEST-25: PASS
 TEST-26: PASS
-TEST-26: PASS
 TEST-27: PASS
 TEST-28: PASS
 TEST-28: PASS
+TEST-28: PASS
 TEST-29: PASS
+TEST-29: PASS
 TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
+TEST-30: PASS
 TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
+TEST-31: PASS
 TEST-32: PASS
 TEST-32: PASS
 TEST-32: PASS
+TEST-32: PASS
 TEST-33: PASS
 TEST-33: PASS
+TEST-33: PASS
+TEST-33: PASS
+TEST-33: PASS
+TEST-33: PASS
+TEST-33: PASS
+TEST-33: PASS
 TEST-34: PASS
 TEST-34: PASS
 TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
-TEST-34: PASS
 TEST-35: PASS
 TEST-35: PASS
 TEST-35: PASS
-TEST-35: PASS
-TEST-35: PASS
-TEST-35: PASS
-TEST-35: PASS
-TEST-35: PASS
-TEST-35: PASS
-TEST-35: PASS
 TEST-36: PASS
 TEST-36: PASS
 TEST-36: PASS
 TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
+TEST-36: PASS
 TEST-37: PASS
 TEST-37: PASS
 TEST-37: PASS
 TEST-37: PASS
 TEST-37: PASS
-TEST-37: PASS
-TEST-37: PASS
-TEST-37: PASS
-TEST-38: PASS
-TEST-38: PASS
-TEST-38: PASS
-TEST-39: PASS
-TEST-39: PASS
-TEST-39: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-40: PASS
-TEST-41: PASS
-TEST-41: PASS
-TEST-41: PASS
-TEST-41: PASS
-TEST-41: PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122515] trunk

2012-07-12 Thread jsbell

Title: [122515] trunk








Revision 122515
Author jsb...@chromium.org
Date 2012-07-12 15:19:10 -0700 (Thu, 12 Jul 2012)


Log Message
IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers
https://bugs.webkit.org/show_bug.cgi?id=90310

Reviewed by Tony Chang.

Source/WebCore:

Simplify Document vs. Worker logic for IDBFactory::open() and hook up the
other two IDBFactory methods for use by workers as well.

Test: storage/indexeddb/factory-basics-workers.html

* Modules/indexeddb/IDBFactory.cpp:
(isContextValid): Helper function consolidating checks that context is usable.
(getIndexedDBDatabasePath): Helper function for accessing group settings.
(WebCore::IDBFactory::getDatabaseNames): Simplify - just pass context through to back end.
(WebCore::IDBFactory::open): Ditto.
(WebCore::IDBFactory::deleteDatabase): Ditto.
(WebCore::IDBFactory::cmp): Whitespace.
* Modules/indexeddb/IDBFactoryBackendImpl.cpp: Obsolete openFromWorker() removed.
(WebCore::IDBFactoryBackendImpl::getDatabaseNames): Signature updated.
(WebCore::IDBFactoryBackendImpl::deleteDatabase): Signature updated.
(WebCore::IDBFactoryBackendImpl::open): Signature updated.
* Modules/indexeddb/IDBFactoryBackendImpl.h:
(IDBFactoryBackendImpl):
* Modules/indexeddb/IDBFactoryBackendInterface.h: Interface methods now take both SecurityOrigin
and ScriptExecutionContext, but not Frame. In the proxy, SecurityOrigin is redundant (can be
accessed from context) but on the real back end the context is null (as Frame was previously).
(IDBFactoryBackendInterface):
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore):
(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

Source/WebKit/chromium:

* src/IDBFactoryBackendProxy.cpp:
(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Consolidates user-prompting logic.
(WebKit::getWebFrame): Helper to dig out frame from Document, or null for Worker.
(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
(WebKit):
(WebKit::IDBFactoryBackendProxy::open):
(WebKit::IDBFactoryBackendProxy::deleteDatabase):
* src/IDBFactoryBackendProxy.h: Update method signatures to match interface.
(WebCore):
(IDBFactoryBackendProxy):

LayoutTests:

* storage/indexeddb/factory-basics-workers-expected.txt: Added.
* storage/indexeddb/factory-basics-workers.html: Added.
* storage/indexeddb/resources/factory-basics.js: Allow use by Worker as well as Window.
(getDatabaseNamesSuccess1):
(openSuccess):
(getDatabaseNamesSuccess2):
(getDatabaseNamesSuccess3):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/storage/indexeddb/resources/factory-basics.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBFactory.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h
trunk/Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h
trunk/Source/WebCore/inspector/InspectorIndexedDBAgent.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp
trunk/Source/WebKit/chromium/src/IDBFactoryBackendProxy.h


Added Paths

trunk/LayoutTests/storage/indexeddb/factory-basics-workers-expected.txt
trunk/LayoutTests/storage/indexeddb/factory-basics-workers.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122514 => 122515)

--- trunk/LayoutTests/ChangeLog	2012-07-12 22:05:44 UTC (rev 122514)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 22:19:10 UTC (rev 122515)
@@ -1,3 +1,18 @@
+2012-07-12  Joshua Bell  jsb...@chromium.org
+
+IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers
+https://bugs.webkit.org/show_bug.cgi?id=90310
+
+Reviewed by Tony Chang.
+
+* storage/indexeddb/factory-basics-workers-expected.txt: Added.
+* storage/indexeddb/factory-basics-workers.html: Added.
+* storage/indexeddb/resources/factory-basics.js: Allow use by Worker as well as Window.
+(getDatabaseNamesSuccess1):
+(openSuccess):
+(getDatabaseNamesSuccess2):
+(getDatabaseNamesSuccess3):
+
 2012-07-12  Dirk Pranke  dpra...@chromium.org
 
 rebaseline fast/harness/results.html after r122505.


Added: trunk/LayoutTests/storage/indexeddb/factory-basics-workers-expected.txt (0 => 122515)

--- trunk/LayoutTests/storage/indexeddb/factory-basics-workers-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/factory-basics-workers-expected.txt	2012-07-12 22:19:10 UTC (rev 122515)
@@ -0,0 +1,33 @@
+[Worker] Test the basics of IndexedDB's IDBFactory.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+Starting worker: resources/factory-basics.js
+[Worker] indexedDB = self.indexedDB || self.webkitIndexedDB || self.mozIndexedDB || self.msIndexedDB || self.OIndexedDB;
+[Worker] 
+PASS [Worker] typeof indexedDB.open is function

[webkit-changes] [122516] trunk

2012-07-12 Thread commit-queue

Title: [122516] trunk








Revision 122516
Author commit-qu...@webkit.org
Date 2012-07-12 15:33:36 -0700 (Thu, 12 Jul 2012)


Log Message
Row size/position is wrongly calculated when table having overlapping rowspan cell and colspan cell
https://bugs.webkit.org/show_bug.cgi?id=16811

Patch by Pravin D pravind@gmail.com on 2012-07-12
Reviewed by Julien Chaffraix.

Source/WebCore:

The height of a row is calculated by taking the max height of the cells contained in it. When a row contains
a rowSpan cell and if this row is not the last row of the cell, then its height is max height of other non
rowSpan cells. If the row is the last row of the rowSpan cell, then using the contraint laid by CSS2.1 spec
For a rowSpan cell, the sum of the row heights involved must be great enough to encompass the cell spanning the rows,
the last remaining height of the rowSpan(cell height minus heights of other involved rows) is taken into consideration
while calculating the height of this row.
Currently when calculating the height of the row we are only using the height of the primary cell at position (row, col).
However when a row has colSpan cell and rowSpan, they might overlap. In such a sitution as only the primary cells height
is considered, the height of the row will be calculated worngly if the other overlapping cell has greater height.
Thus all the overlapping cell at position (row, col) must be considered while calculating the height of a row.

Test: fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
Fixed function to use all the overlapping cells at position(row, col) to calculate the height/position of rows.

LayoutTests:

* fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html: Added.
* fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableSection.cpp


Added Paths

trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html
trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122515 => 122516)

--- trunk/LayoutTests/ChangeLog	2012-07-12 22:19:10 UTC (rev 122515)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 22:33:36 UTC (rev 122516)
@@ -1,3 +1,13 @@
+2012-07-12  Pravin D  pravind@gmail.com
+
+Row size/position is wrongly calculated when table having overlapping rowspan cell and colspan cell
+https://bugs.webkit.org/show_bug.cgi?id=16811
+
+Reviewed by Julien Chaffraix.
+
+* fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html: Added.
+* fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html: Added.
+
 2012-07-12  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers


Added: trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html (0 => 122516)

--- trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell-expected.html	2012-07-12 22:33:36 UTC (rev 122516)
@@ -0,0 +1,25 @@
+!DOCTYPE html
+html
+body
+p h4Testcase for a href="" 16811/a.br
+The test case checks if the height and position of rows having overlapping rowSpan and colSpan cells gets properly calculated./h4
+If the row height/position is properly calculated then the height of the green rectangle should be same as the yellow rectangle and the green rectangle must be contained
+within the yellow rectangle.
+/p
+table style=border:1px solid yellow;
+  tr
+td
+  img width=20 height=60/
+/td
+td rowspan=2
+  img width=20 height=120 style=border:1px solid green;/
+/td
+  /tr
+  tr
+td
+  img height=20/
+/td
+  /tr
+/table
+/body
+/html


Added: trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html (0 => 122516)

--- trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html	(rev 0)
+++ trunk/LayoutTests/fast/table/last-cell-of-rowspan-overlapping-colspan-cell.html	2012-07-12 22:33:36 UTC (rev 122516)
@@ -0,0 +1,26 @@
+!DOCTYPE html
+html
+body
+p h4Testcase for a href="" 16811/a.br
+The test case checks if the height and position of rows having overlapping rowSpan and colSpan cells gets properly calculated./h4
+If the row height/position is properly calculated then the height of the green rectangle should be same as the yellow rectangle and the green rectangle must be contained
+within the yellow rectangle.
+/p
+table style=border:1px solid yellow;
+  tr
+td
+  img width=20 height=60/
+/td
+td rowspan=2
+  img width=20 height=120 style=border:1px solid green;/
+/td
+

[webkit-changes] [122517] trunk/Tools

2012-07-12 Thread dpranke

Title: [122517] trunk/Tools








Revision 122517
Author dpra...@chromium.org
Date 2012-07-12 15:35:40 -0700 (Thu, 12 Jul 2012)


Log Message
webkitpy: clean up logging handlers, lint common.message_pool
https://bugs.webkit.org/show_bug.cgi?id=91152

Reviewed by Ojan Vafai.

The unix implementation of multiprocessing clones any logging
handlers from the parent process into the child; we currently
don't want this behavior in our code, so I was hand-removing the
installed handlers in the child process I knew about. After thinking
about it further, I think it was simpler and safe enough to just
remove all handlers in the child, since the message pool
propagates any message from the child back into the parent.

We can always change this in the future if it turns out to be an issue.

I'm also fixing a couple of other lint warnings while I'm at it.

* Scripts/webkitpy/common/message_pool.py:
(_MessagePool.__exit__):
(_MessagePool._handle_worker_exception):
(_Worker._set_up_logging):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/message_pool.py




Diff

Modified: trunk/Tools/ChangeLog (122516 => 122517)

--- trunk/Tools/ChangeLog	2012-07-12 22:33:36 UTC (rev 122516)
+++ trunk/Tools/ChangeLog	2012-07-12 22:35:40 UTC (rev 122517)
@@ -1,5 +1,29 @@
 2012-07-12  Dirk Pranke  dpra...@chromium.org
 
+webkitpy: clean up logging handlers, lint common.message_pool
+https://bugs.webkit.org/show_bug.cgi?id=91152
+
+Reviewed by Ojan Vafai.
+
+The unix implementation of multiprocessing clones any logging
+handlers from the parent process into the child; we currently
+don't want this behavior in our code, so I was hand-removing the
+installed handlers in the child process I knew about. After thinking
+about it further, I think it was simpler and safe enough to just
+remove all handlers in the child, since the message pool
+propagates any message from the child back into the parent.
+
+We can always change this in the future if it turns out to be an issue.
+
+I'm also fixing a couple of other lint warnings while I'm at it.
+
+* Scripts/webkitpy/common/message_pool.py:
+(_MessagePool.__exit__):
+(_MessagePool._handle_worker_exception):
+(_Worker._set_up_logging):
+
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
 webkitpy: rename manager_worker_broker to message_pool
 https://bugs.webkit.org/show_bug.cgi?id=91145
 


Modified: trunk/Tools/Scripts/webkitpy/common/message_pool.py (122516 => 122517)

--- trunk/Tools/Scripts/webkitpy/common/message_pool.py	2012-07-12 22:33:36 UTC (rev 122516)
+++ trunk/Tools/Scripts/webkitpy/common/message_pool.py	2012-07-12 22:35:40 UTC (rev 122517)
@@ -82,7 +82,7 @@
 def __enter__(self):
 return self
 
-def __exit__(self, exc_type, exc_value, traceback):
+def __exit__(self, exc_type, exc_value, exc_traceback):
 self._close()
 return False
 
@@ -143,7 +143,7 @@
 self._workers_stopped.add(source)
 
 @staticmethod
-def _handle_worker_exception(source, exception_type, exception_value, stack):
+def _handle_worker_exception(source, exception_type, exception_value, _):
 if exception_type == KeyboardInterrupt:
 raise exception_type(exception_value)
 _log.error(%s raised %s('%s'): % (
@@ -288,14 +288,10 @@
 def _set_up_logging(self):
 self._logger = logging.getLogger()
 
-# The unix multiprocessing implementation clones the MeteredStream log handler
-# into the child process, so we need to remove it to avoid duplicate logging.
+# The unix multiprocessing implementation clones any log handlers into the child process,
+# so we remove them to avoid duplicate logging.
 for h in self._logger.handlers:
-# log handlers don't have names until python 2.7.
-# FIXME: log handler names should be passed in.
-if getattr(h, 'name', '') in ('MeteredStreamLogHandler', 'webkitpy.test.printer'):
-self._logger.removeHandler(h)
-break
+self._logger.removeHandler(h)
 
 self._log_handler = _WorkerLogHandler(self)
 self._logger.addHandler(self._log_handler)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122518] trunk/Source/WebCore

2012-07-12 Thread rniwa

Title: [122518] trunk/Source/WebCore








Revision 122518
Author rn...@webkit.org
Date 2012-07-12 15:40:26 -0700 (Thu, 12 Jul 2012)


Log Message
Merge HTMLCollectionWithArrayStorage into HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=91144

Reviewed by Anders Carlsson.

Merged HTMLCollectionWithArrayStorage::item into HTMLCollection::item and got rid of
HTMLCollectionWithArrayStorage. Also de-virtualized HTMLCollection::item and HTMLCollection::length
and merged itemInArrayAfter and itemAfter.

In addition, improved the algorithm in HTMLCollection::length to take advantage of item cache.
Instead of always computing the length from the beginning, we start the search from the cached item
so that if we're near end of the collection, we avoid significant portion of the node traversal.

Furthermore, made HTMLCollection always call setItemCache with a non-null item and HTMLCollection::item
set the length cache when it reaches the end of the collection to avoid redundant length calculations.

* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::setItemCache): Add a FIXME.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::itemAfter): Regular HTMLCollection doesn't have uses elements array so
assert that offsetInArray is always 0.
(WebCore): Removed calcLength.
(WebCore::HTMLCollection::length): Rewritten. The algorithm is as follows:
When there is no item cache, we look for the first item by calling item(0). If item(0) returns null,
then it must have set the length cache so bail out. If the previous step didn't bail out, then
the item cache is valid and not null (see above), so count the number of remaining items in collection
starting at the cached item's offset + 1.
(WebCore::HTMLCollection::item): Avoid calling setItemCache with null. When the first item is null,
set the length cache instead.
(WebCore::HTMLCollection::itemAfterCachedItem): Extracted from HTMLCollectionWithArrayStorage::item.
(WebCore::HTMLCollection::namedItem): Pass in arrayOffset to itemAfter. Note this variable is never
used since only HTMLFormCollection and HTMLPropertiesCollection use array offsets but they override
this function.
(WebCore::HTMLCollection::updateNameCache): Ditto.
* html/HTMLCollection.h:
(HTMLCollection):
(WebCore):
* html/HTMLFormCollection.cpp: Removed calcLength(). Even though this function didn't iterate over
the collection directly, HTMLFormElement::length and HTMLFieldSetElement::length did so we're not
regressing any performance here.
(WebCore::HTMLFormCollection::HTMLFormCollection):
(WebCore::HTMLFormCollection::itemAfter):
* html/HTMLFormCollection.h:
(HTMLFormCollection):
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter):
* html/HTMLNameCollection.h:
(HTMLNameCollection):
* html/HTMLPropertiesCollection.cpp: Removed calcLength().
(WebCore::HTMLPropertiesCollection::HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::itemAfter):
(WebCore):
* html/HTMLPropertiesCollection.h:
(HTMLPropertiesCollection):
* html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::itemAfter):
* html/HTMLTableRowsCollection.h:
(HTMLTableRowsCollection):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DynamicNodeList.h
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h
trunk/Source/WebCore/html/HTMLFormCollection.cpp
trunk/Source/WebCore/html/HTMLFormCollection.h
trunk/Source/WebCore/html/HTMLNameCollection.cpp
trunk/Source/WebCore/html/HTMLNameCollection.h
trunk/Source/WebCore/html/HTMLPropertiesCollection.cpp
trunk/Source/WebCore/html/HTMLPropertiesCollection.h
trunk/Source/WebCore/html/HTMLTableRowsCollection.cpp
trunk/Source/WebCore/html/HTMLTableRowsCollection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (122517 => 122518)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 22:35:40 UTC (rev 122517)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 22:40:26 UTC (rev 122518)
@@ -1,3 +1,64 @@
+2012-07-12  Ryosuke Niwa  rn...@webkit.org
+
+Merge HTMLCollectionWithArrayStorage into HTMLCollection
+https://bugs.webkit.org/show_bug.cgi?id=91144
+
+Reviewed by Anders Carlsson.
+
+Merged HTMLCollectionWithArrayStorage::item into HTMLCollection::item and got rid of
+HTMLCollectionWithArrayStorage. Also de-virtualized HTMLCollection::item and HTMLCollection::length
+and merged itemInArrayAfter and itemAfter.
+
+In addition, improved the algorithm in HTMLCollection::length to take advantage of item cache.
+Instead of always computing the length from the beginning, we start the search from the cached item
+so that if we're near end of the collection, we avoid significant portion of the node traversal.
+
+Furthermore, made HTMLCollection always call setItemCache with a non-null item and HTMLCollection::item
+set the length cache when it reaches the end of the collection to avoid redundant length calculations.
+
+*

[webkit-changes] [122520] trunk/Source/WebKit2

2012-07-12 Thread timothy

Title: [122520] trunk/Source/WebKit2








Revision 122520
Author timo...@apple.com
Date 2012-07-12 15:58:08 -0700 (Thu, 12 Jul 2012)


Log Message
Make the Inspect Element context menu item appear in nightly builds again.

https://webkit.org/b/89323

Reviewed by Anders Carlsson.

* Shared/API/c/WKContextMenuItem.cpp:
(compatibleContextMenuItemTag): Added. Checks for the specific version of Safari 6 that needs the
tag fixed up to match values it expects.
(WKContextMenuItemGetTag): On Mac platforms call compatibleContextMenuItemTag to fix up the tag
before returning it.
* Shared/API/c/WKContextMenuItemTypes.h: Fix the order of the WKContextMenuItemTag enum
to be binary compatible with older versions of WebKit2.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp
trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122519 => 122520)

--- trunk/Source/WebKit2/ChangeLog	2012-07-12 22:43:44 UTC (rev 122519)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-12 22:58:08 UTC (rev 122520)
@@ -1,3 +1,19 @@
+2012-07-12  Timothy Hatcher  timo...@apple.com
+
+Make the Inspect Element context menu item appear in nightly builds again.
+
+https://webkit.org/b/89323
+
+Reviewed by Anders Carlsson.
+
+* Shared/API/c/WKContextMenuItem.cpp:
+(compatibleContextMenuItemTag): Added. Checks for the specific version of Safari 6 that needs the
+tag fixed up to match values it expects.
+(WKContextMenuItemGetTag): On Mac platforms call compatibleContextMenuItemTag to fix up the tag
+before returning it.
+* Shared/API/c/WKContextMenuItemTypes.h: Fix the order of the WKContextMenuItemTag enum
+to be binary compatible with older versions of WebKit2.
+
 2012-07-12  Thiago Marcos P. Santos  thiago.san...@intel.com
 
 [EFL] Port the test framework to WebKit 2


Modified: trunk/Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp (122519 => 122520)

--- trunk/Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp	2012-07-12 22:43:44 UTC (rev 122519)
+++ trunk/Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp	2012-07-12 22:58:08 UTC (rev 122520)
@@ -32,6 +32,10 @@
 #include WKAPICast.h
 #include WKContextMenuItemTypes.h
 
+#if PLATFORM(MAC)
+#import mach-o/dyld.h
+#endif
+
 using namespace WebCore;
 using namespace WebKit;
 
@@ -80,10 +84,36 @@
 #endif
 }
 
+#if PLATFORM(MAC)
+static WKContextMenuItemTag compatibleContextMenuItemTag(WKContextMenuItemTag tag)
+{
+static bool needsWorkaround = ^bool {
+const int32_t safariFrameworkVersionWithIncompatibleContextMenuItemTags = 0x02181900; // 536.25.0 (Safari 6.0)
+return NSVersionOfRunTimeLibrary(Safari) == safariFrameworkVersionWithIncompatibleContextMenuItemTags;
+}();
+
+if (!needsWorkaround)
+return tag;
+
+// kWKContextMenuItemTagDictationAlternative was inserted before kWKContextMenuItemTagInspectElement.
+// DictationAlternative is now at the end like it should have been. To be compatible we need to return
+// InspectElement for DictationAlternative and shift InspectElement and after by one.
+if (tag == kWKContextMenuItemTagDictationAlternative)
+return kWKContextMenuItemTagInspectElement;
+if (tag = kWKContextMenuItemTagInspectElement  tag  kWKContextMenuItemBaseApplicationTag)
+return tag + 1;
+return tag;
+}
+#endif
+
 WKContextMenuItemTag WKContextMenuItemGetTag(WKContextMenuItemRef itemRef)
 {
 #if ENABLE(CONTEXT_MENUS)
+#if PLATFORM(MAC)
+return compatibleContextMenuItemTag(toAPI(toImpl(itemRef)-data()-action()));
+#else
 return toAPI(toImpl(itemRef)-data()-action());
+#endif
 #else
 return toAPI(ContextMenuItemTagNoAction);
 #endif


Modified: trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h (122519 => 122520)

--- trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h	2012-07-12 22:43:44 UTC (rev 122519)
+++ trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h	2012-07-12 22:58:08 UTC (rev 122520)
@@ -88,7 +88,6 @@
 kWKContextMenuItemTagRightToLeft,
 kWKContextMenuItemTagPDFSinglePageScrolling,
 kWKContextMenuItemTagPDFFacingPagesScrolling,
-kWKContextMenuItemTagDictationAlternative,
 kWKContextMenuItemTagInspectElement,
 kWKContextMenuItemTagTextDirectionMenu,
 kWKContextMenuItemTagTextDirectionDefault,
@@ -114,6 +113,7 @@
 kWKContextMenuItemTagEnterVideoFullscreen,
 kWKContextMenuItemTagMediaPlayPause,
 kWKContextMenuItemTagMediaMute,
+kWKContextMenuItemTagDictationAlternative,
 kWKContextMenuItemBaseApplicationTag = 1
 };
 typedef uint32_t WKContextMenuItemTag;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122521] trunk/LayoutTests

2012-07-12 Thread wjmaclean

Title: [122521] trunk/LayoutTests








Revision 122521
Author wjmacl...@chromium.org
Date 2012-07-12 16:02:56 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] Unreviewed gardening. SKIP inspector/elements/edit-dom-actions.html on Win Debug
https://bugs.webkit.org/show_bug.cgi?id=60109

Since we can't use SLOW and TIMEOUT together, let's skip this test until it is fixed.

* platform/chromium/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (122520 => 122521)

--- trunk/LayoutTests/ChangeLog	2012-07-12 22:58:08 UTC (rev 122520)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 23:02:56 UTC (rev 122521)
@@ -1,3 +1,12 @@
+2012-07-12  W. James MacLean  wjmacl...@chromium.org
+
+[chromium] Unreviewed gardening. SKIP inspector/elements/edit-dom-actions.html on Win Debug
+https://bugs.webkit.org/show_bug.cgi?id=60109
+
+Since we can't use SLOW and TIMEOUT together, let's skip this test until it is fixed.
+
+* platform/chromium/TestExpectations:
+
 2012-07-12  Pravin D  pravind@gmail.com
 
 Row size/position is wrongly calculated when table having overlapping rowspan cell and colspan cell


Modified: trunk/LayoutTests/platform/chromium/TestExpectations (122520 => 122521)

--- trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 22:58:08 UTC (rev 122520)
+++ trunk/LayoutTests/platform/chromium/TestExpectations	2012-07-12 23:02:56 UTC (rev 122521)
@@ -968,7 +968,7 @@
 BUGWK82894 SKIP DEBUG : inspector/profiler/heap-snapshot-inspect-dom-wrapper.html = PASS
 
 BUGWK60109 WIN RELEASE : inspector/elements/edit-dom-actions.html = PASS TEXT
-BUGWK60109 SLOW WIN DEBUG : inspector/elements/edit-dom-actions.html = PASS TEXT TIMEOUT
+BUGWK60109 SKIP WIN DEBUG : inspector/elements/edit-dom-actions.html = PASS TEXT
 
 BUGWK72434 LINUX WIN : inspector/styles/svg-style.xhtml = PASS TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122522] trunk/Tools

2012-07-12 Thread kseo

Title: [122522] trunk/Tools








Revision 122522
Author k...@webkit.org
Date 2012-07-12 16:12:54 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed. Change my irc nickname to kseo.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (122521 => 122522)

--- trunk/Tools/ChangeLog	2012-07-12 23:02:56 UTC (rev 122521)
+++ trunk/Tools/ChangeLog	2012-07-12 23:12:54 UTC (rev 122522)
@@ -1,3 +1,9 @@
+2012-07-12  Kwang Yul Seo  sk...@company100.net
+
+Unreviewed. Change my irc nickname to kseo.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2012-07-12  Dirk Pranke  dpra...@chromium.org
 
 webkitpy: clean up logging handlers, lint common.message_pool


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (122521 => 122522)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-07-12 23:02:56 UTC (rev 122521)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-07-12 23:12:54 UTC (rev 122522)
@@ -304,7 +304,7 @@
 Committer(Konrad Piascik, kpias...@rim.com, kpiascik),
 Committer(Kristof Kosztyo, kkris...@inf.u-szeged.hu, kkristof),
 Committer(Krzysztof Kowalczyk, kkowalc...@gmail.com),
-Committer(Kwang Yul Seo, [sk...@company100.net, k...@webkit.org], kwangseo),
+Committer(Kwang Yul Seo, [sk...@company100.net, k...@webkit.org], kseo),
 Committer(Leandro Gracia Gil, leandrogra...@chromium.org, leandrogracia),
 Committer(Leandro Pereira, [lean...@profusion.mobi, lean...@webkit.org], acidx),
 Committer(Leo Yang, [leo.y...@torchmobile.com.cn, leoy...@webkit.org, leoyang.web...@gmail.com, leo.yan...@gmail.com], leoyang),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122523] trunk/Source/WebKit/chromium

2012-07-12 Thread abarth

Title: [122523] trunk/Source/WebKit/chromium








Revision 122523
Author aba...@webkit.org
Date 2012-07-12 16:13:02 -0700 (Thu, 12 Jul 2012)


Log Message
[Chromium] WebSettings should be sorted
https://bugs.webkit.org/show_bug.cgi?id=91157

Reviewed by Eric Seidel.

This might be my OCD, but IMHO this file would be cleaner if we listed
the settings in alphabetic order.

* public/WebSettings.h:
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::forceSoftwareCompositing):
(WebKit::WebSettingsImpl::viewportEnabled):
(WebKit::WebSettingsImpl::maxUntiledLayerSize):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (122522 => 122523)

--- trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 23:12:54 UTC (rev 122522)
+++ trunk/Source/WebKit/chromium/ChangeLog	2012-07-12 23:13:02 UTC (rev 122523)
@@ -1,3 +1,20 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+[Chromium] WebSettings should be sorted
+https://bugs.webkit.org/show_bug.cgi?id=91157
+
+Reviewed by Eric Seidel.
+
+This might be my OCD, but IMHO this file would be cleaner if we listed
+the settings in alphabetic order.
+
+* public/WebSettings.h:
+* src/WebSettingsImpl.h:
+(WebSettingsImpl):
+(WebKit::WebSettingsImpl::forceSoftwareCompositing):
+(WebKit::WebSettingsImpl::viewportEnabled):
+(WebKit::WebSettingsImpl::maxUntiledLayerSize):
+
 2012-07-12  Joshua Bell  jsb...@chromium.org
 
 IndexedDB: Enable IDBFactory.deleteDatabase() and webkitGetDatabaseNames() in Workers


Modified: trunk/Source/WebKit/chromium/public/WebSettings.h (122522 => 122523)

--- trunk/Source/WebKit/chromium/public/WebSettings.h	2012-07-12 23:12:54 UTC (rev 122522)
+++ trunk/Source/WebKit/chromium/public/WebSettings.h	2012-07-12 23:13:02 UTC (rev 122523)
@@ -53,111 +53,110 @@
 EditingBehaviorUnix
 };
 
-virtual void setStandardFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
-virtual void setFixedFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
-virtual void setSerifFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
-virtual void setSansSerifFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
+virtual bool forceSoftwareCompositing() const = 0;
+virtual bool scrollAnimatorEnabled() const = 0;
+virtual bool viewportEnabled() const = 0;
+virtual void setAccelerated2dCanvasEnabled(bool) = 0;
+virtual void setAcceleratedCompositingEnabled(bool) = 0;
+virtual void setAcceleratedCompositingFor3DTransformsEnabled(bool) = 0;
+virtual void setAcceleratedCompositingForAnimationEnabled(bool) = 0;
+virtual void setAcceleratedCompositingForCanvasEnabled(bool) = 0;
+virtual void setAcceleratedCompositingForFixedPositionEnabled(bool)  = 0;
+virtual void setAcceleratedCompositingForPluginsEnabled(bool) = 0;
+virtual void setAcceleratedCompositingForVideoEnabled(bool) = 0;
+virtual void setAcceleratedFiltersEnabled(bool) = 0;
+virtual void setAcceleratedPaintingEnabled(bool) = 0;
+virtual void setAllowDisplayOfInsecureContent(bool) = 0;
+virtual void setAllowFileAccessFromFileURLs(bool) = 0;
+virtual void setAllowRunningOfInsecureContent(bool) = 0;
+virtual void setAllowScriptsToCloseWindows(bool) = 0;
+virtual void setAllowUniversalAccessFromFileURLs(bool) = 0;
+virtual void setApplyDefaultDeviceScaleFactorInCompositor(bool) = 0;
+virtual void setAsynchronousSpellCheckingEnabled(bool) = 0;
+virtual void setAuthorAndUserStylesEnabled(bool) = 0;
+virtual void setCaretBrowsingEnabled(bool) = 0;
+virtual void setCookieEnabled(bool) = 0;
 virtual void setCursiveFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
-virtual void setFantasyFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
-virtual void setPictographFontFamily(const WebString, UScriptCode = USCRIPT_COMMON) = 0;
-virtual void setDefaultFontSize(int) = 0;
+virtual void setDNSPrefetchingEnabled(bool) = 0;
+virtual void setDOMPasteAllowed(bool) = 0;
 virtual void setDefaultFixedFontSize(int) = 0;
-virtual void setMinimumFontSize(int) = 0;
-virtual void setMinimumLogicalFontSize(int) = 0;
-virtual void setApplyDefaultDeviceScaleFactorInCompositor(bool) = 0;
-virtual void setTextAutosizingEnabled(bool) = 0;
+virtual void setDefaultFontSize(int) = 0;
 virtual void setDefaultTextEncodingName(const WebString) = 0;
-virtual void setDeviceSupportsTouch(bool) = 0;
+virtual void setDefaultTileSize(WebSize) = 0;
+virtual void setDeferred2dCanvasEnabled(bool) = 0;
+virtual void setDeveloperExtrasEnabled(bool) = 0;
 virtual void setDeviceSupportsMouse(bool) = 0;
-virtual void setJavaScriptEnabled(bool) = 0;
-

[webkit-changes] [122524] trunk/Source/WebCore

2012-07-12 Thread commit-queue

Title: [122524] trunk/Source/WebCore








Revision 122524
Author commit-qu...@webkit.org
Date 2012-07-12 16:14:40 -0700 (Thu, 12 Jul 2012)


Log Message
Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic
https://bugs.webkit.org/show_bug.cgi?id=89900

Patch by Elliott Sprehn espr...@gmail.com on 2012-07-12
Reviewed by Eric Seidel and Abhishek Arya.

Previously we would walk the all children a renderer whenever adding
or removing a child renderer from its RenderObjectChildList to look for
RenderQuote and RenderCounter instances to update. This patch introduces
a counter in RenderView for the number of RenderQuote and RenderCounter
instances in that document so we can avoid these traversals.

No tests needed since this is just a short circuiting of logic and the existing
tests should cover it.

* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::RenderCounter): Increment instance counter.
(WebCore::RenderCounter::willBeDestroyed): Decrement instance counter.
(WebCore):
(WebCore::RenderCounter::rendererRemovedFromTree): Short circuit when counter is zero.
(WebCore::RenderCounter::rendererSubtreeAttached): Short circuit when counter is zero.
* rendering/RenderCounter.h:
(RenderCounter):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode): Short circuit calling into Counter and Quote code when the document is being destroyed.
* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):
(WebCore):
(WebCore::RenderQuote::rendererSubtreeAttached): Increment instance counter.
(WebCore::RenderQuote::rendererRemovedFromTree): Decrement instance counter.
* rendering/RenderQuote.h:
(RenderQuote):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h: Methods for managing the RenderQuote and RenderCounter counts.
(RenderView):
(WebCore::RenderView::addRenderQuote):
(WebCore::RenderView::removeRenderQuote):
(WebCore::RenderView::hasRenderQuotes):
(WebCore::RenderView::addRenderCounter):
(WebCore::RenderView::removeRenderCounter):
(WebCore::RenderView::hasRenderCounters):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderCounter.cpp
trunk/Source/WebCore/rendering/RenderCounter.h
trunk/Source/WebCore/rendering/RenderObjectChildList.cpp
trunk/Source/WebCore/rendering/RenderQuote.cpp
trunk/Source/WebCore/rendering/RenderQuote.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (122523 => 122524)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 23:13:02 UTC (rev 122523)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 23:14:40 UTC (rev 122524)
@@ -1,3 +1,48 @@
+2012-07-12  Elliott Sprehn  espr...@gmail.com
+
+Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic
+https://bugs.webkit.org/show_bug.cgi?id=89900
+
+Reviewed by Eric Seidel and Abhishek Arya.
+
+Previously we would walk the all children a renderer whenever adding
+or removing a child renderer from its RenderObjectChildList to look for 
+RenderQuote and RenderCounter instances to update. This patch introduces 
+a counter in RenderView for the number of RenderQuote and RenderCounter 
+instances in that document so we can avoid these traversals.
+
+No tests needed since this is just a short circuiting of logic and the existing
+tests should cover it.
+
+* rendering/RenderCounter.cpp:
+(WebCore::RenderCounter::RenderCounter): Increment instance counter.
+(WebCore::RenderCounter::willBeDestroyed): Decrement instance counter.
+(WebCore):
+(WebCore::RenderCounter::rendererRemovedFromTree): Short circuit when counter is zero.
+(WebCore::RenderCounter::rendererSubtreeAttached): Short circuit when counter is zero.
+* rendering/RenderCounter.h:
+(RenderCounter):
+* rendering/RenderObjectChildList.cpp:
+(WebCore::RenderObjectChildList::removeChildNode): Short circuit calling into Counter and Quote code when the document is being destroyed.
+* rendering/RenderQuote.cpp:
+(WebCore::RenderQuote::RenderQuote):
+(WebCore::RenderQuote::willBeDestroyed):
+(WebCore):
+(WebCore::RenderQuote::rendererSubtreeAttached): Increment instance counter.
+(WebCore::RenderQuote::rendererRemovedFromTree): Decrement instance counter.
+* rendering/RenderQuote.h:
+(RenderQuote):
+* rendering/RenderView.cpp:
+(WebCore::RenderView::RenderView):
+* rendering/RenderView.h: Methods for managing the RenderQuote and RenderCounter counts.
+(RenderView):
+(WebCore::RenderView::addRenderQuote):
+(WebCore::RenderView::removeRenderQuote):
+(WebCore::RenderView::hasRenderQuotes):
+

[webkit-changes] [122525] trunk/Source

2012-07-12 Thread danakj

Title: [122525] trunk/Source








Revision 122525
Author dan...@chromium.org
Date 2012-07-12 16:26:01 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] Remove the RenderPass pointer from RenderPassDrawQuad
https://bugs.webkit.org/show_bug.cgi?id=91023

Reviewed by Adrienne Walker.

Source/WebCore:

Removes the RenderPass pointer and keeps only an integer id in the
quad to refer back to the RenderPass the quad reads from.

Covered by existing tests.

* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::findRenderPassById):
(WebCore):
(WebCore::removeRenderPassesRecursive):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):
(WebCore::CCLayerTreeHostImpl::removeRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(FrameData):
(CullRenderPassesWithCachedTextures):
(CullRenderPassesWithNoQuads):
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCRenderPass.h:
(WebCore):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostImplTest.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderSurface.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122524 => 122525)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 23:14:40 UTC (rev 122524)
+++ trunk/Source/WebCore/ChangeLog	2012-07-12 23:26:01 UTC (rev 122525)
@@ -1,3 +1,43 @@
+2012-07-12  Dana Jansens  dan...@chromium.org
+
+[chromium] Remove the RenderPass pointer from RenderPassDrawQuad
+https://bugs.webkit.org/show_bug.cgi?id=91023
+
+Reviewed by Adrienne Walker.
+
+Removes the RenderPass pointer and keeps only an integer id in the
+quad to refer back to the RenderPass the quad reads from.
+
+Covered by existing tests.
+
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
+(WebCore::findRenderPassById):
+(WebCore):
+(WebCore::removeRenderPassesRecursive):
+(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithCachedTextures::shouldRemoveRenderPass):
+(WebCore::CCLayerTreeHostImpl::CullRenderPassesWithNoQuads::shouldRemoveRenderPass):
+(WebCore::CCLayerTreeHostImpl::removeRenderPasses):
+(WebCore::CCLayerTreeHostImpl::prepareToDraw):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+(FrameData):
+(CullRenderPassesWithCachedTextures):
+(CullRenderPassesWithNoQuads):
+(CCLayerTreeHostImpl):
+* platform/graphics/chromium/cc/CCRenderPass.cpp:
+(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
+* platform/graphics/chromium/cc/CCRenderPass.h:
+(WebCore):
+* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
+(WebCore::CCRenderPassDrawQuad::create):
+(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
+* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
+(CCRenderPassDrawQuad):
+* platform/graphics/chromium/cc/CCRenderSurface.cpp:
+(WebCore::CCRenderSurface::appendQuads):
+* platform/graphics/chromium/cc/CCRenderSurface.h:
+(CCRenderSurface):
+
 2012-07-12  Elliott Sprehn  espr...@gmail.com
 
 Unneeded tree walking when adding or removing children due to RenderCounter / RenderQuote logic


Modified: trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (122524 => 122525)

--- trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp	2012-07-12 23:14:40 UTC (rev 122524)
+++

[webkit-changes] [122526] trunk/Tools

2012-07-12 Thread kseo

Title: [122526] trunk/Tools








Revision 122526
Author k...@webkit.org
Date 2012-07-12 16:26:15 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed. Add Dongsung Huang to the list of contributors. He
has submitted over 30 patches on texture mapper, canvas and image decoders.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (122525 => 122526)

--- trunk/Tools/ChangeLog	2012-07-12 23:26:01 UTC (rev 122525)
+++ trunk/Tools/ChangeLog	2012-07-12 23:26:15 UTC (rev 122526)
@@ -1,5 +1,12 @@
 2012-07-12  Kwang Yul Seo  sk...@company100.net
 
+Unreviewed. Add Dongsung Huang to the list of contributors. He
+has submitted over 30 patches on texture mapper, canvas and image decoders.
+
+* Scripts/webkitpy/common/config/committers.py:
+
+2012-07-12  Kwang Yul Seo  sk...@company100.net
+
 Unreviewed. Change my irc nickname to kseo.
 
 * Scripts/webkitpy/common/config/committers.py:


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (122525 => 122526)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-07-12 23:26:01 UTC (rev 122525)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2012-07-12 23:26:15 UTC (rev 122526)
@@ -123,6 +123,7 @@
 Contributor(David Barr, davidb...@chromium.org, barrbrain),
 Contributor(David Dorwin, ddor...@chromium.org, ddorwin),
 Contributor(David Reveman, reve...@chromium.org, reveman),
+Contributor(Dongsung Huang, luxte...@company100.net, Huang),
 Contributor(Douglas Davidson, ddavi...@apple.com),
 Contributor(Edward O'Connor, eocon...@apple.com, hober),
 Contributor(Eric Penner, epen...@chromium.org, epenner),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122527] trunk/Tools

2012-07-12 Thread abarth

Title: [122527] trunk/Tools








Revision 122527
Author aba...@webkit.org
Date 2012-07-12 16:27:30 -0700 (Thu, 12 Jul 2012)


Log Message
Unreviewed.  Nit: git config files use tabs, not spaces.

* EWSTools/cold-boot.sh:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWSTools/cold-boot.sh




Diff

Modified: trunk/Tools/ChangeLog (122526 => 122527)

--- trunk/Tools/ChangeLog	2012-07-12 23:26:15 UTC (rev 122526)
+++ trunk/Tools/ChangeLog	2012-07-12 23:27:30 UTC (rev 122527)
@@ -1,3 +1,9 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+Unreviewed.  Nit: git config files use tabs, not spaces.
+
+* EWSTools/cold-boot.sh:
+
 2012-07-12  Kwang Yul Seo  sk...@company100.net
 
 Unreviewed. Add Dongsung Huang to the list of contributors. He


Modified: trunk/Tools/EWSTools/cold-boot.sh (122526 => 122527)

--- trunk/Tools/EWSTools/cold-boot.sh	2012-07-12 23:26:15 UTC (rev 122526)
+++ trunk/Tools/EWSTools/cold-boot.sh	2012-07-12 23:27:30 UTC (rev 122527)
@@ -73,13 +73,13 @@
 if [[ $1 == commit-queue ]];then
 cat  .git/config EOF
 [svn-remote svn]
-url = ""
-fetch = trunk:refs/remotes/origin/master
+	url = ""
+	fetch = trunk:refs/remotes/origin/master
 [user]
-email = commit-qu...@webkit.org
-name = Commit Queue
+	email = commit-qu...@webkit.org
+	name = Commit Queue
 [merge changelog]
-driver = perl $PWD/Tools/Scripts/resolve-ChangeLogs --merge-driver %O %B %A
+	driver = perl $PWD/Tools/Scripts/resolve-ChangeLogs --merge-driver %O %B %A
 EOF
 fi
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122529] trunk

2012-07-12 Thread enne

Title: [122529] trunk








Revision 122529
Author e...@google.com
Date 2012-07-12 16:38:44 -0700 (Thu, 12 Jul 2012)


Log Message
[chromium] Root invalidations for RTL pages need to be in the right space
https://bugs.webkit.org/show_bug.cgi?id=91155

Reviewed by Kenneth Russell.

Source/WebKit/chromium:

The root layer has a translation on it when placed in the tree, so any
invalidations on this layer likewise need to be adjusted.

This adjustment is due to the fact that compositor layers all have the
origin in the upper left corner of the layer, but this is not always
the origin for graphics layers. Rather than making compositor layers
have to deal with a potential offset, we change the transform when
inserting the layer into the tree. Invalidations need to be similarly
transformed from document space into compositor layer space.

The need for this offset is due to the definition of the initial
containing block. RTL pages (pages with dir=RTL on the body) start
scrolled all the way to the right, and the origin is in the upper left
hand corner of this initial viewport. Thus on RTL pages with
horizontal overflow, the left of the document is in negative CSS
space.

* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::invalidateRect):

LayoutTests:

Add a test that demonstrates this problem. Before the code fix, the
test shows just a red square because the invalidation for the style
change repaints the wrong rect.

* compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
* compositing/rtl/rtl-overflow-invalidation-expected.txt: Added.
* compositing/rtl/rtl-overflow-invalidation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp


Added Paths

trunk/LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.png
trunk/LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.txt
trunk/LayoutTests/compositing/rtl/rtl-overflow-invalidation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122528 => 122529)

--- trunk/LayoutTests/ChangeLog	2012-07-12 23:30:47 UTC (rev 122528)
+++ trunk/LayoutTests/ChangeLog	2012-07-12 23:38:44 UTC (rev 122529)
@@ -1,3 +1,18 @@
+2012-07-12  Adrienne Walker  e...@google.com
+
+[chromium] Root invalidations for RTL pages need to be in the right space
+https://bugs.webkit.org/show_bug.cgi?id=91155
+
+Reviewed by Kenneth Russell.
+
+Add a test that demonstrates this problem. Before the code fix, the
+test shows just a red square because the invalidation for the style
+change repaints the wrong rect.
+
+* compositing/rtl/rtl-overflow-invalidation-expected.png: Added.
+* compositing/rtl/rtl-overflow-invalidation-expected.txt: Added.
+* compositing/rtl/rtl-overflow-invalidation.html: Added.
+
 2012-07-12  James Simonsen  simon...@chromium.org
 
 [Navigation Timing] Import the W3C Navigation Timing test suite


Added: trunk/LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.png (0 => 122529)

--- trunk/LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.png	(rev 0)
+++ trunk/LayoutTests/compositing/rtl/rtl-overflow-invalidation-expected.png	2012-07-12 23:38:44 UTC (rev 122529)
@@ -0,0 +1,5 @@
+\x89PNG
+
+
+IHDR X')tEXtchecksum7c4f4ad7ad63bab2764e0d8cbcf74d31\x87\xEB
+\xE7IDATx\x9C\xED\xD8\xC1m\x84@EAc\x9173\xB2\xD9VH~\xF6xEչ\xFF\xF8\xD4ۜ\xF3\x80\xB7\xCE\xF3\xBC\xFC\xFD{;\x9EI`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@L`\xC4@l_=a;\xB7\xD5\xC6\xE6\xEA

[webkit-changes] [122530] trunk/Source/WebCore

2012-07-12 Thread shinyak

Title: [122530] trunk/Source/WebCore








Revision 122530
Author shin...@chromium.org
Date 2012-07-12 17:09:21 -0700 (Thu, 12 Jul 2012)


Log Message
Needs callback before AuthorShadowRoot is added.
https://bugs.webkit.org/show_bug.cgi?id=91167

Reviewed by Hajime Morita.

This is a preliminary patch for adding multiple Shadow DOM support for media elements and form elements.
They assume that UserAgentShadowRoot is the oldest, however currently a page author may try to add
AuthorShadowRoot before adding UserAgentShadowRoot.

This patch adds a callback before AuthorShadowRoot is being added, and allow us to add UserAgentShadowRoot
for those elements. See also Bug 77936, Bug 77937, Bug 90532.

* dom/Element.h:
(WebCore::Element::willAddAuthorShadowRoot):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot):
* dom/ElementShadow.h:
(ElementShadow):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementShadow.cpp
trunk/Source/WebCore/dom/ElementShadow.h
trunk/Source/WebCore/dom/ShadowRoot.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122529 => 122530)

--- trunk/Source/WebCore/ChangeLog	2012-07-12 23:38:44 UTC (rev 122529)
+++ trunk/Source/WebCore/ChangeLog	2012-07-13 00:09:21 UTC (rev 122530)
@@ -1,3 +1,26 @@
+2012-07-12  Shinya Kawanaka  shin...@chromium.org
+
+Needs callback before AuthorShadowRoot is added.
+https://bugs.webkit.org/show_bug.cgi?id=91167
+
+Reviewed by Hajime Morita.
+
+This is a preliminary patch for adding multiple Shadow DOM support for media elements and form elements.
+They assume that UserAgentShadowRoot is the oldest, however currently a page author may try to add
+AuthorShadowRoot before adding UserAgentShadowRoot.
+
+This patch adds a callback before AuthorShadowRoot is being added, and allow us to add UserAgentShadowRoot
+for those elements. See also Bug 77936, Bug 77937, Bug 90532.
+
+* dom/Element.h:
+(WebCore::Element::willAddAuthorShadowRoot):
+* dom/ElementShadow.cpp:
+(WebCore::ElementShadow::addShadowRoot):
+* dom/ElementShadow.h:
+(ElementShadow):
+* dom/ShadowRoot.cpp:
+(WebCore::ShadowRoot::create):
+
 2012-07-12  Dana Jansens  dan...@chromium.org
 
 [chromium] Remove the RenderPass pointer from RenderPassDrawQuad


Modified: trunk/Source/WebCore/dom/Element.h (122529 => 122530)

--- trunk/Source/WebCore/dom/Element.h	2012-07-12 23:38:44 UTC (rev 122529)
+++ trunk/Source/WebCore/dom/Element.h	2012-07-13 00:09:21 UTC (rev 122530)
@@ -269,6 +269,7 @@
 
 ElementShadow* shadow() const;
 ElementShadow* ensureShadow();
+virtual void willAddAuthorShadowRoot() { }
 
 // FIXME: Remove Element::ensureShadowRoot
 // https://bugs.webkit.org/show_bug.cgi?id=77608


Modified: trunk/Source/WebCore/dom/ElementShadow.cpp (122529 => 122530)

--- trunk/Source/WebCore/dom/ElementShadow.cpp	2012-07-12 23:38:44 UTC (rev 122529)
+++ trunk/Source/WebCore/dom/ElementShadow.cpp	2012-07-13 00:09:21 UTC (rev 122530)
@@ -65,7 +65,7 @@
 return true;
 }
 
-void ElementShadow::addShadowRoot(Element* shadowHost, PassRefPtrShadowRoot shadowRoot, ExceptionCode ec)
+void ElementShadow::addShadowRoot(Element* shadowHost, PassRefPtrShadowRoot shadowRoot, ShadowRoot::ShadowRootType type, ExceptionCode ec)
 {
 ASSERT(shadowHost);
 ASSERT(shadowRoot);
@@ -73,6 +73,9 @@
 if (!validateShadowRoot(shadowHost-document(), shadowRoot.get(), ec))
 return;
 
+if (type == ShadowRoot::AuthorShadowRoot)
+shadowHost-willAddAuthorShadowRoot();
+
 shadowRoot-setHost(shadowHost);
 shadowRoot-setParentTreeScope(shadowHost-treeScope());
 m_shadowRoots.push(shadowRoot.get());


Modified: trunk/Source/WebCore/dom/ElementShadow.h (122529 => 122530)

--- trunk/Source/WebCore/dom/ElementShadow.h	2012-07-12 23:38:44 UTC (rev 122529)
+++ trunk/Source/WebCore/dom/ElementShadow.h	2012-07-13 00:09:21 UTC (rev 122530)
@@ -53,7 +53,7 @@
 ShadowRoot* oldestShadowRoot() const;
 
 void removeAllShadowRoots();
-void addShadowRoot(Element* shadowHost, PassRefPtrShadowRoot, ExceptionCode);
+void addShadowRoot(Element* shadowHost, PassRefPtrShadowRoot, ShadowRoot::ShadowRootType, ExceptionCode);
 
 void attach();
 void detach();


Modified: trunk/Source/WebCore/dom/ShadowRoot.cpp (122529 => 122530)

--- trunk/Source/WebCore/dom/ShadowRoot.cpp	2012-07-12 23:38:44 UTC (rev 122529)
+++ trunk/Source/WebCore/dom/ShadowRoot.cpp	2012-07-13 00:09:21 UTC (rev 122530)
@@ -122,7 +122,7 @@
 #endif
 
 ec = 0;
-element-ensureShadow()-addShadowRoot(element, shadowRoot, ec);
+element-ensureShadow()-addShadowRoot(element, shadowRoot, type, ec);
 if (ec)
 return 0;
 ASSERT(element == shadowRoot-host());






___
webkit-changes

[webkit-changes] [122531] trunk/Source/WebCore

2012-07-12 Thread rniwa

Title: [122531] trunk/Source/WebCore








Revision 122531
Author rn...@webkit.org
Date 2012-07-12 17:20:46 -0700 (Thu, 12 Jul 2012)


Log Message
Move m_type and m_hasNameCache from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
https://bugs.webkit.org/show_bug.cgi?id=91164

Reviewed by Anders Carlsson.

Moved m_type and m_hasNameCache from HTMLCollection and renamed them to m_collectionType and m_isNameCacheValid.

Also renamed shouldIncludeChildren to shouldOnlyIncludeDirectChildren and negated the return value since
all HTMLCollection include children in the collection and the function was meant to tell us whether the collection
should include descendents that are not direct children of base().

In addition, renamed nextNodeOrSibling to nextNode since or sibling doesn't seem to add any semantic clarity.

* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::type):
(WebCore::DynamicNodeListCacheBase::hasNameCache):
(WebCore::DynamicNodeListCacheBase::setHasNameCache):
(WebCore::DynamicNodeListCacheBase::clearCache):
* html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::isAcceptableElement):
(WebCore::nextNode):
(WebCore::HTMLCollection::itemAfter):
* html/HTMLCollection.h:
(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
(HTMLCollectionCacheBase):
(WebCore::HTMLCollectionCacheBase::clearCache):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DynamicNodeList.h
trunk/Source/WebCore/html/CollectionType.h
trunk/Source/WebCore/html/HTMLCollection.cpp
trunk/Source/WebCore/html/HTMLCollection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (122530 => 122531)

--- trunk/Source/WebCore/ChangeLog	2012-07-13 00:09:21 UTC (rev 122530)
+++ trunk/Source/WebCore/ChangeLog	2012-07-13 00:20:46 UTC (rev 122531)
@@ -1,3 +1,36 @@
+2012-07-12  Ryosuke Niwa  rn...@webkit.org
+
+Move m_type and m_hasNameCache from HTMLCollectionCacheBase to DynamicNodeListCacheBase for better bit packing
+https://bugs.webkit.org/show_bug.cgi?id=91164
+
+Reviewed by Anders Carlsson.
+
+Moved m_type and m_hasNameCache from HTMLCollection and renamed them to m_collectionType and m_isNameCacheValid.
+
+Also renamed shouldIncludeChildren to shouldOnlyIncludeDirectChildren and negated the return value since
+all HTMLCollection include children in the collection and the function was meant to tell us whether the collection
+should include descendents that are not direct children of base().
+
+In addition, renamed nextNodeOrSibling to nextNode since or sibling doesn't seem to add any semantic clarity.
+
+* dom/DynamicNodeList.h:
+(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
+(DynamicNodeListCacheBase):
+(WebCore::DynamicNodeListCacheBase::type):
+(WebCore::DynamicNodeListCacheBase::hasNameCache):
+(WebCore::DynamicNodeListCacheBase::setHasNameCache):
+(WebCore::DynamicNodeListCacheBase::clearCache):
+* html/HTMLCollection.cpp:
+(WebCore::shouldOnlyIncludeDirectChildren):
+(WebCore::HTMLCollection::HTMLCollection):
+(WebCore::HTMLCollection::isAcceptableElement):
+(WebCore::nextNode):
+(WebCore::HTMLCollection::itemAfter):
+* html/HTMLCollection.h:
+(WebCore::HTMLCollectionCacheBase::HTMLCollectionCacheBase):
+(HTMLCollectionCacheBase):
+(WebCore::HTMLCollectionCacheBase::clearCache):
+
 2012-07-12  Shinya Kawanaka  shin...@chromium.org
 
 Needs callback before AuthorShadowRoot is added.


Modified: trunk/Source/WebCore/dom/DynamicNodeList.h (122530 => 122531)

--- trunk/Source/WebCore/dom/DynamicNodeList.h	2012-07-13 00:09:21 UTC (rev 122530)
+++ trunk/Source/WebCore/dom/DynamicNodeList.h	2012-07-13 00:20:46 UTC (rev 122531)
@@ -24,6 +24,7 @@
 #ifndef DynamicNodeList_h
 #define DynamicNodeList_h
 
+#include CollectionType.h
 #include Document.h
 #include NodeList.h
 #include wtf/Forward.h
@@ -39,16 +40,25 @@
 DynamicNodeListCacheBase(NodeListRootType rootType, NodeListInvalidationType invalidationType)
 : m_rootedAtDocument(rootType == NodeListIsRootedAtDocument)
 , m_invalidationType(invalidationType)
+, m_collectionType(InvalidCollectionType)
 {
 ASSERT(m_invalidationType == static_castunsigned(invalidationType));
 clearCache();
 }
 
+DynamicNodeListCacheBase(CollectionType collectionType)
+: m_collectionType(collectionType)
+{
+ASSERT(m_collectionType == static_castunsigned(collectionType));
+clearCache();
+}
+
 public:
 ALWAYS_INLINE bool isRootedAtDocument() const { return m_rootedAtDocument; }
 ALWAYS_INLINE bool shouldInvalidateOnAttributeChange() const { return

[webkit-changes] [122533] trunk/Source/WebCore

2012-07-12 Thread rniwa

Title: [122533] trunk/Source/WebCore








Revision 122533
Author rn...@webkit.org
Date 2012-07-12 17:34:26 -0700 (Thu, 12 Jul 2012)


Log Message
Build fix. Initialize unused const member variables to make compilers happy.

* dom/DynamicNodeList.h:
(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/DynamicNodeList.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (122532 => 122533)

--- trunk/Source/WebCore/ChangeLog	2012-07-13 00:29:03 UTC (rev 122532)
+++ trunk/Source/WebCore/ChangeLog	2012-07-13 00:34:26 UTC (rev 122533)
@@ -1,3 +1,10 @@
+2012-07-12  Ryosuke Niwa  rn...@webkit.org
+
+Build fix. Initialize unused const member variables to make compilers happy.
+
+* dom/DynamicNodeList.h:
+(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
+
 2012-07-12  Konrad Piascik  kpias...@rim.com
 
 Web Inspector: Geolocation override


Modified: trunk/Source/WebCore/dom/DynamicNodeList.h (122532 => 122533)

--- trunk/Source/WebCore/dom/DynamicNodeList.h	2012-07-13 00:29:03 UTC (rev 122532)
+++ trunk/Source/WebCore/dom/DynamicNodeList.h	2012-07-13 00:34:26 UTC (rev 122533)
@@ -47,7 +47,9 @@
 }
 
 DynamicNodeListCacheBase(CollectionType collectionType)
-: m_collectionType(collectionType)
+: m_rootedAtDocument(false) // Ignored
+, m_invalidationType(DoNotInvalidateOnAttributeChanges) // Ignored
+, m_collectionType(collectionType)
 {
 ASSERT(m_collectionType == static_castunsigned(collectionType));
 clearCache();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122534] trunk/Tools

2012-07-12 Thread abarth

Title: [122534] trunk/Tools








Revision 122534
Author aba...@webkit.org
Date 2012-07-12 18:26:53 -0700 (Thu, 12 Jul 2012)


Log Message
CommitQueue is confused about what port it is using
https://bugs.webkit.org/show_bug.cgi?id=91040

Reviewed by Dirk Pranke.

On EC2, we explicitly pass --port to the commit-queue, but that
requires editing the start-queue.sh script locally on each bot. In
moving to Google Compute Engine, we're try to avoid any local edits to
the EWSTools.

Rather than passing --port to the commit-queue, this patch teaches the
CommitQueue which port its running, which is the approach we use for
the EWS bots.

Mutating tool._deprecated_port is a bit ugly, but it's what we're doing
currently for the EWS bots.

* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):
(CommitQueue.begin_work_queue):
(CommitQueue.run_command):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(mock_run_webkit_patch):
(test_rollout):
(test_rollout_lands):
(test_manual_reject_during_processing):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/commands/queues.py
trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (122533 => 122534)

--- trunk/Tools/ChangeLog	2012-07-13 00:34:26 UTC (rev 122533)
+++ trunk/Tools/ChangeLog	2012-07-13 01:26:53 UTC (rev 122534)
@@ -1,3 +1,33 @@
+2012-07-12  Adam Barth  aba...@webkit.org
+
+CommitQueue is confused about what port it is using
+https://bugs.webkit.org/show_bug.cgi?id=91040
+
+Reviewed by Dirk Pranke.
+
+On EC2, we explicitly pass --port to the commit-queue, but that
+requires editing the start-queue.sh script locally on each bot. In
+moving to Google Compute Engine, we're try to avoid any local edits to
+the EWSTools.
+
+Rather than passing --port to the commit-queue, this patch teaches the
+CommitQueue which port its running, which is the approach we use for
+the EWS bots.
+
+Mutating tool._deprecated_port is a bit ugly, but it's what we're doing
+currently for the EWS bots.
+
+* Scripts/webkitpy/tool/commands/queues.py:
+(CommitQueue):
+(CommitQueue.begin_work_queue):
+(CommitQueue.run_command):
+* Scripts/webkitpy/tool/commands/queues_unittest.py:
+(CommitQueueTest.test_commit_queue):
+(mock_run_webkit_patch):
+(test_rollout):
+(test_rollout_lands):
+(test_manual_reject_during_processing):
+
 2012-07-12  James Simonsen  simon...@chromium.org
 
 [Navigation Timing] Import the W3C Navigation Timing test suite


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (122533 => 122534)

--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py	2012-07-13 00:34:26 UTC (rev 122533)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py	2012-07-13 01:26:53 UTC (rev 122534)
@@ -38,6 +38,7 @@
 from StringIO import StringIO
 
 from webkitpy.common.config.committervalidator import CommitterValidator
+from webkitpy.common.config.ports import DeprecatedPort
 from webkitpy.common.net.bugzilla import Attachment
 from webkitpy.common.net.statusserver import StatusServer
 from webkitpy.common.system.deprecated_logging import error, log
@@ -257,10 +258,16 @@
 
 class CommitQueue(AbstractPatchQueue, StepSequenceErrorHandler, CommitQueueTaskDelegate):
 name = commit-queue
+port_name = chromium-xvfb
 
 # AbstractPatchQueue methods
 
 def begin_work_queue(self):
+if not self._options.port:
+self.port = DeprecatedPort.port(self.port_name)
+# FIXME: This violates abstraction
+self._tool._deprecated_port = self.port
+
 AbstractPatchQueue.begin_work_queue(self)
 self.committer_validator = CommitterValidator(self._tool)
 self._expected_failures = ExpectedFailures()
@@ -305,7 +312,7 @@
 # CommitQueueTaskDelegate methods
 
 def run_command(self, command):
-self.run_webkit_patch(command)
+self.run_webkit_patch(command + [self.port.flag()])
 
 def command_passed(self, message, patch):
 self._update_status(message, patch=patch)


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py (122533 => 122534)

--- trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2012-07-13 00:34:26 UTC (rev 122533)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2012-07-13 01:26:53 UTC (rev 122534)
@@ -49,7 +49,7 @@
 CommitQueue.__init__(self)
 if tool:
 self.bind_to_tool(tool)
-self._options = MockOptions(confirm=False, parent_command=commit-queue)
+self._options = MockOptions(confirm=False, parent_command=commit-queue, port=None)
 
 def begin_work_queue(self):
 output_capture = OutputCapture()
@@ -231,8 +231,8 @@
 
 def test_commit_queue(self):
 tool = MockTool()
-

[webkit-changes] [122535] trunk/Source/WebCore

2012-07-12 Thread arv

Title: [122535] trunk/Source/WebCore








Revision 122535
Author a...@chromium.org
Date 2012-07-12 18:53:17 -0700 (Thu, 12 Jul 2012)


Log Message
[V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=91165

Reviewed by Nate Chapin.

The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.

No new tests. No change in functionality.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm




Diff

Modified: trunk/Source/WebCore/ChangeLog (122534 => 122535)

--- trunk/Source/WebCore/ChangeLog	2012-07-13 01:26:53 UTC (rev 122534)
+++ trunk/Source/WebCore/ChangeLog	2012-07-13 01:53:17 UTC (rev 122535)
@@ -1,3 +1,17 @@
+2012-07-12  Erik Arvidsson  a...@chromium.org
+
+[V8] Simplify CodeGeneratorV8 since V8OnProto is only true for DOMWindow
+https://bugs.webkit.org/show_bug.cgi?id=91165
+
+Reviewed by Nate Chapin.
+
+The old code was dead code since V8OnProto only ever gets set to 1 for DOMWindow.
+
+No new tests. No change in functionality.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateNormalAttrSetter):
+
 2012-07-12  Ryosuke Niwa  rn...@webkit.org
 
 Build fix. Initialize unused const member variables to make compilers happy.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (122534 => 122535)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-07-13 01:26:53 UTC (rev 122534)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2012-07-13 01:53:17 UTC (rev 122535)
@@ -1134,21 +1134,9 @@
 push(@implContentDecls, $svgWrappedNativeType* imp = impInstance;\n);
 }
 } elsif ($attrExt-{V8OnProto}) {
-  if ($interfaceName eq DOMWindow) {
 push(@implContentDecls, END);
-v8::Handlev8::Object holder = info.Holder();
+${implClassName}* imp = V8${implClassName}::toNative(info.Holder());
 END
-  } else {
-# perform lookup first
-push(@implContentDecls, END);
-v8::Handlev8::Object holder = V8DOMWrapper::lookupDOMWrapper(V8${interfaceName}::GetTemplate(), info.This());
-if (holder.IsEmpty())
-return;
-END
-  }
-push(@implContentDecls, END);
-${implClassName}* imp = V8${implClassName}::toNative(holder);
-END
 } else {
 my $attrType = GetTypeFromSignature($attribute-signature);
 my $reflect = $attribute-signature-extendedAttributes-{Reflect};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122536] trunk/Tools

2012-07-12 Thread dpranke

Title: [122536] trunk/Tools








Revision 122536
Author dpra...@chromium.org
Date 2012-07-12 19:01:09 -0700 (Thu, 12 Jul 2012)


Log Message
test-webkitpy: rename test_finder to finder
https://bugs.webkit.org/show_bug.cgi?id=91175

Reviewed by Adam Barth.

Rename test_finder - finder, TestFinder - Finder to remove
some of the stutter in the names.

* Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
* Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
* Scripts/webkitpy/test/main.py:
(Tester.__init__):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/test/main.py


Added Paths

trunk/Tools/Scripts/webkitpy/test/finder.py
trunk/Tools/Scripts/webkitpy/test/finder_unittest.py


Removed Paths

trunk/Tools/Scripts/webkitpy/test/test_finder.py
trunk/Tools/Scripts/webkitpy/test/test_finder_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (122535 => 122536)

--- trunk/Tools/ChangeLog	2012-07-13 01:53:17 UTC (rev 122535)
+++ trunk/Tools/ChangeLog	2012-07-13 02:01:09 UTC (rev 122536)
@@ -1,3 +1,18 @@
+2012-07-12  Dirk Pranke  dpra...@chromium.org
+
+test-webkitpy: rename test_finder to finder
+https://bugs.webkit.org/show_bug.cgi?id=91175
+
+Reviewed by Adam Barth.
+
+Rename test_finder - finder, TestFinder - Finder to remove
+some of the stutter in the names.
+
+* Scripts/webkitpy/test/finder.py: Renamed from Tools/Scripts/webkitpy/test/test_finder.py.
+* Scripts/webkitpy/test/finder_unittest.py: Renamed from Tools/Scripts/webkitpy/test/test_finder_unittest.py.
+* Scripts/webkitpy/test/main.py:
+(Tester.__init__):
+
 2012-07-12  Adam Barth  aba...@webkit.org
 
 CommitQueue is confused about what port it is using


Copied: trunk/Tools/Scripts/webkitpy/test/finder.py (from rev 122535, trunk/Tools/Scripts/webkitpy/test/test_finder.py) (0 => 122536)

--- trunk/Tools/Scripts/webkitpy/test/finder.py	(rev 0)
+++ trunk/Tools/Scripts/webkitpy/test/finder.py	2012-07-13 02:01:09 UTC (rev 122536)
@@ -0,0 +1,180 @@
+# Copyright (C) 2012 Google, Inc.
+# Copyright (C) 2010 Chris Jerdonek (cjerdo...@webkit.org)
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1.  Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2.  Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+this module is responsible for finding python tests.
+
+import logging
+import re
+import sys
+
+
+_log = logging.getLogger(__name__)
+
+
+class TestDirectoryTree(object):
+def __init__(self, filesystem, top_directory, starting_subdirectory):
+self.filesystem = filesystem
+self.top_directory = filesystem.realpath(top_directory)
+self.search_directory = self.top_directory
+self.top_package = ''
+if starting_subdirectory:
+self.top_package = starting_subdirectory.replace(filesystem.sep, '.') + '.'
+self.search_directory = filesystem.join(self.top_directory, starting_subdirectory)
+
+def find_modules(self, suffixes, sub_directory=None):
+if sub_directory:
+search_directory = self.filesystem.join(self.top_directory, sub_directory)
+else:
+search_directory = self.search_directory
+
+def file_filter(filesystem, dirname, basename):
+return any(basename.endswith(suffix) for suffix in suffixes)
+
+filenames = self.filesystem.files_under(search_directory, file_filter=file_filter)
+return [self.to_module(filename) for filename in filenames]
+
+def to_module(self, path):
+return path.replace(self.top_directory + self.filesystem.sep, '').replace(self.filesystem.sep, '.')[:-3]
+
+def subpath(self, path):
+Returns the relative path from the top of the tree to the path, or

[webkit-changes] [122537] trunk

2012-07-12 Thread eric

Title: [122537] trunk








Revision 122537
Author e...@webkit.org
Date 2012-07-12 19:12:21 -0700 (Thu, 12 Jul 2012)


Log Message
Incorrect behaviour calling Range setStart or setEnd with boundary in different document
https://bugs.webkit.org/show_bug.cgi?id=42517

Reviewed by Ojan Vafai.

Source/WebCore:

Added a new static inline checkForDifferentRootContainer to share some code
and made setStart/setEnd do the right thing in the x-document case.  I removed
the bogus checks in set*After/set*Before functions, and since they just call
through to setStart/setEnd, they also now do the right thing.

Test: fast/dom/Range/set-wrong-document-err.html

* dom/Range.cpp:
(WebCore::checkForDifferentRootContainer):
(WebCore):
(WebCore::Range::setStart):
(WebCore::Range::setEnd):
(WebCore::Range::setStartAfter):
(WebCore::Range::setEndBefore):
(WebCore::Range::setEndAfter):
(WebCore::Range::setStartBefore):

LayoutTests:

Add a new test to cover this changed behavior, and correct a FIXME in an old test
which was documenting our incorrect behavior.

* fast/dom/Range/set-wrong-document-err-expected.txt: Added.
* fast/dom/Range/set-wrong-document-err.html: Added.
* fast/dom/move-nodes-across-documents.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/dom/move-nodes-across-documents.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Range.cpp


Added Paths

trunk/LayoutTests/fast/dom/Range/set-wrong-document-err-expected.txt
trunk/LayoutTests/fast/dom/Range/set-wrong-document-err.html




Diff

Modified: trunk/LayoutTests/ChangeLog (122536 => 122537)

--- trunk/LayoutTests/ChangeLog	2012-07-13 02:01:09 UTC (rev 122536)
+++ trunk/LayoutTests/ChangeLog	2012-07-13 02:12:21 UTC (rev 122537)
@@ -1,3 +1,17 @@
+2012-07-12  Eric Seidel  e...@webkit.org
+
+Incorrect behaviour calling Range setStart or setEnd with boundary in different document
+https://bugs.webkit.org/show_bug.cgi?id=42517
+
+Reviewed by Ojan Vafai.
+
+Add a new test to cover this changed behavior, and correct a FIXME in an old test
+which was documenting our incorrect behavior.
+
+* fast/dom/Range/set-wrong-document-err-expected.txt: Added.
+* fast/dom/Range/set-wrong-document-err.html: Added.
+* fast/dom/move-nodes-across-documents.html:
+
 2012-07-12  Konrad Piascik  kpias...@rim.com
 
 Web Inspector: Geolocation override


Added: trunk/LayoutTests/fast/dom/Range/set-wrong-document-err-expected.txt (0 => 122537)

--- trunk/LayoutTests/fast/dom/Range/set-wrong-document-err-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/dom/Range/set-wrong-document-err-expected.txt	2012-07-13 02:12:21 UTC (rev 122537)
@@ -0,0 +1,27 @@
+Range set* functions should not throw WRONG_DOCUMENT_ERR.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS range.setStart(iframe.contentDocument.body, 0) did not throw exception.
+PASS range.startContainer is iframe.contentDocument.body
+PASS range.collapsed is true
+PASS range.setEnd(iframe.contentDocument.body, 0) did not throw exception.
+PASS range.startContainer is iframe.contentDocument.body
+PASS range.collapsed is true
+PASS range.setStartAfter(iframe.contentDocument.body.firstChild) did not throw exception.
+PASS range.startContainer is iframe.contentDocument.body
+PASS range.collapsed is true
+PASS range.setStartBefore(iframe.contentDocument.body.firstChild) did not throw exception.
+PASS range.startContainer is iframe.contentDocument.body
+PASS range.collapsed is true
+PASS range.setEndAfter(iframe.contentDocument.body.firstChild) did not throw exception.
+PASS range.startContainer is iframe.contentDocument.body
+PASS range.collapsed is true
+PASS range.setEndBefore(iframe.contentDocument.body.firstChild) did not throw exception.
+PASS range.startContainer is iframe.contentDocument.body
+PASS range.collapsed is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/dom/Range/set-wrong-document-err.html (0 => 122537)

--- trunk/LayoutTests/fast/dom/Range/set-wrong-document-err.html	(rev 0)
+++ trunk/LayoutTests/fast/dom/Range/set-wrong-document-err.html	2012-07-13 02:12:21 UTC (rev 122537)
@@ -0,0 +1,54 @@
+!DOCTYPE html
+body
+script src=""
+script
+
+function newRange() {
+	var range = document.createRange();
+	range.selectNodeContents(iframe);
+	return range;
+}
+
+function checkRange() {
+	shouldBe(range.startContainer, iframe.contentDocument.body);
+	shouldBeTrue(range.collapsed);
+}
+
+description(Range set* functions should not throw WRONG_DOCUMENT_ERR.);
+window.iframe = document.createElement(iframe);
+document.body.appendChild(iframe);
+iframe.contentDocument.write(htmlheadbodycontent/body/html);
+
+// Move range start to the iframe document. According to the DOM
+// Range spec, this should collapse the Range to the new boundary.
+//

[webkit-changes] [122539] trunk/Source/WebCore

2012-07-12 Thread mitz

Title: [122539] trunk/Source/WebCore








Revision 122539
Author m...@apple.com
Date 2012-07-12 21:31:56 -0700 (Thu, 12 Jul 2012)


Log Message
Pass an option flag to CFStringGetHyphenationLocationBeforeIndex() that tells it to not
terminate the search at the last word boundary before the given index.

Reviewed by Adele Peterson.

No test, because the current version of Core Foundation ignores the options parameter.

* platform/text/cf/HyphenationCF.cpp:
(WebCore::lastHyphenLocation): Changed the options parameter from 0 to 1.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (122538 => 122539)

--- trunk/Source/WebCore/ChangeLog	2012-07-13 02:29:29 UTC (rev 122538)
+++ trunk/Source/WebCore/ChangeLog	2012-07-13 04:31:56 UTC (rev 122539)
@@ -1,3 +1,15 @@
+2012-07-12  Dan Bernstein  m...@apple.com
+
+Pass an option flag to CFStringGetHyphenationLocationBeforeIndex() that tells it to not
+terminate the search at the last word boundary before the given index.
+
+Reviewed by Adele Peterson.
+
+No test, because the current version of Core Foundation ignores the options parameter.
+
+* platform/text/cf/HyphenationCF.cpp:
+(WebCore::lastHyphenLocation): Changed the options parameter from 0 to 1.
+
 2012-07-12  Eric Seidel  e...@webkit.org
 
 Incorrect behaviour calling Range setStart or setEnd with boundary in different document


Modified: trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp (122538 => 122539)

--- trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp	2012-07-13 02:29:29 UTC (rev 122538)
+++ trunk/Source/WebCore/platform/text/cf/HyphenationCF.cpp	2012-07-13 04:31:56 UTC (rev 122539)
@@ -70,7 +70,8 @@
 RetainPtrCFLocaleRef locale = cfLocaleCache().get(localeIdentifier);
 ASSERT(locale);
 
-CFIndex result = CFStringGetHyphenationLocationBeforeIndex(string.get(), beforeIndex, CFRangeMake(0, length), 0, locale.get(), 0);
+CFOptionFlags searchAcrossWordBoundaries = 1;
+CFIndex result = CFStringGetHyphenationLocationBeforeIndex(string.get(), beforeIndex, CFRangeMake(0, length), searchAcrossWordBoundaries, locale.get(), 0);
 return result == kCFNotFound ? 0 : result;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [122541] trunk

2012-07-12 Thread fpizlo

Title: [122541] trunk








Revision 122541
Author fpi...@apple.com
Date 2012-07-12 22:31:05 -0700 (Thu, 12 Jul 2012)


Log Message
DFG CFA may get overzealous in loops that have code that must exit
https://bugs.webkit.org/show_bug.cgi?id=91188

Source/_javascript_Core: 

Reviewed by Gavin Barraclough.

Ensure that if the CFA assumes that an operation must exit, then it will always exit
no matter what happens after. That's necessary to preserve soundness.

Remove a broken fixup done by the DFG simplifier, where it was trying to say that the
variable-at-head was the first access in the second block in the merge, if the first
block did not read the variable. That's totally wrong, if the first block was in fact
doing a phantom read. I removed that fixup and instead hardened the rest of the
compiler.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(BasicBlock):
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::run):
(ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):

LayoutTests: 

Reviewed by Gavin Baraclough.

* fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt: Added.
* fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.html: Added.
* fast/js/script-tests/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.js: Added.
(foo):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGAbstractState.cpp
trunk/Source/_javascript_Core/dfg/DFGBasicBlock.h
trunk/Source/_javascript_Core/dfg/DFGCFAPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGCFGSimplificationPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGConstantFoldingPhase.cpp
trunk/Source/_javascript_Core/dfg/DFGVariableEventStream.cpp


Added Paths

trunk/LayoutTests/fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt
trunk/LayoutTests/fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.html
trunk/LayoutTests/fast/js/script-tests/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.js




Diff

Modified: trunk/LayoutTests/ChangeLog (122540 => 122541)

--- trunk/LayoutTests/ChangeLog	2012-07-13 05:08:23 UTC (rev 122540)
+++ trunk/LayoutTests/ChangeLog	2012-07-13 05:31:05 UTC (rev 122541)
@@ -1,3 +1,15 @@
+2012-07-12  Filip Pizlo  fpi...@apple.com
+
+DFG CFA may get overzealous in loops that have code that must exit
+https://bugs.webkit.org/show_bug.cgi?id=91188
+
+Reviewed by Gavin Baraclough.
+
+* fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt: Added.
+* fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.html: Added.
+* fast/js/script-tests/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop.js: Added.
+(foo):
+
 2012-07-12  Eric Seidel  e...@webkit.org
 
 Incorrect behaviour calling Range setStart or setEnd with boundary in different document


Added: trunk/LayoutTests/fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt (0 => 122541)

--- trunk/LayoutTests/fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/js/dfg-force-exit-then-sparse-conditional-constant-prop-in-loop-expected.txt	2012-07-13 05:31:05 UTC (rev 122541)
@@ -0,0 +1,209 @@
+Checks that increased aggressiveness in sparse conditional constant propagation resultin from a node being proven to be force exit does not lead to a cascade of unsound decisions.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746
+PASS foo(array) is 8746

[webkit-changes] [122542] trunk

2012-07-12 Thread commit-queue

Title: [122542] trunk








Revision 122542
Author commit-qu...@webkit.org
Date 2012-07-12 22:39:31 -0700 (Thu, 12 Jul 2012)


Log Message
[WK2][EFL] Facilitate debugging of the Web Process
https://bugs.webkit.org/show_bug.cgi?id=90768

Patch by Christophe Dumez christophe.du...@intel.com on 2012-07-12
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

The EFL port now checks if the WEB_PROCESS_CMD_PREFIX
environment variable is set and uses it as prefix
when spawning the Web process if it is. This is used
for debugging purposes with prefixes such as:
xterm -title renderer -e gdb --args.

* UIProcess/Launcher/ProcessLauncher.h:
(LaunchOptions):
* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connect):

Tools:

Add a new --webprocess-cmd-prefix argument to
run-webkit-tests script for EFL port. If provided,
the prefix will be prepended to the command used
to spawn the Web process. This can be used for
debugging purposes with prefixes such as:
xterm -title renderer -e gdb --args.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.__init__):
(EflPort.setup_environ_for_server):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformRunUntil): Implement support for
m_noTimeout timeout value.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h
trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp
trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/efl.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
trunk/Tools/WebKitTestRunner/efl/TestControllerEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (122541 => 122542)

--- trunk/Source/WebKit2/ChangeLog	2012-07-13 05:31:05 UTC (rev 122541)
+++ trunk/Source/WebKit2/ChangeLog	2012-07-13 05:39:31 UTC (rev 122542)
@@ -1,3 +1,23 @@
+2012-07-12  Christophe Dumez  christophe.du...@intel.com
+
+[WK2][EFL] Facilitate debugging of the Web Process
+https://bugs.webkit.org/show_bug.cgi?id=90768
+
+Reviewed by Kenneth Rohde Christiansen.
+
+The EFL port now checks if the WEB_PROCESS_CMD_PREFIX
+environment variable is set and uses it as prefix
+when spawning the Web process if it is. This is used
+for debugging purposes with prefixes such as:
+xterm -title renderer -e gdb --args.
+
+* UIProcess/Launcher/ProcessLauncher.h:
+(LaunchOptions):
+* UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
+(WebKit::ProcessLauncher::launchProcess):
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::connect):
+
 2012-07-12  Timothy Hatcher  timo...@apple.com
 
 Make the Inspect Element context menu item appear in nightly builds again.


Modified: trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h (122541 => 122542)

--- trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h	2012-07-13 05:31:05 UTC (rev 122541)
+++ trunk/Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h	2012-07-13 05:39:31 UTC (rev 122542)
@@ -31,6 +31,10 @@
 #include wtf/RefPtr.h
 #include wtf/Threading.h
 
+#ifndef NDEBUG
+#include wtf/text/WTFString.h
+#endif
+
 namespace WebKit {
 
 class ProcessLauncher : public ThreadSafeRefCountedProcessLauncher {
@@ -54,6 +58,9 @@
 cpu_type_t architecture;
 bool executableHeap;
 #endif
+#ifndef NDEBUG
+String processCmdPrefix;
+#endif
 };
 
 static PassRefPtrProcessLauncher create(Client* client, const LaunchOptions launchOptions)


Modified: trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp (122541 => 122542)

--- trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp	2012-07-13 05:31:05 UTC (rev 122541)
+++ trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp	2012-07-13 05:39:31 UTC (rev 122542)
@@ -70,7 +70,19 @@
 executablePath = String(executablePathPtr);
 }
 String fullPath = executablePath + / + processName;
-execl(fullPath.utf8().data(), processName.utf8().data(), socket.utf8().data(), static_castchar*(0));
+#ifndef NDEBUG
+if (m_launchOptions.processCmdPrefix.isEmpty())
+#endif
+execl(fullPath.utf8().data(), processName.utf8().data(), socket.utf8().data(), static_castchar*(0));
+#ifndef NDEBUG
+else {
+String cmd = makeString(m_launchOptions.processCmdPrefix, ' ', fullPath, ' ', socket);
+if (system(cmd.utf8().data()) == -1) {
+ASSERT_NOT_REACHED();
+return;
+}
+}
+#endif
 } else if (pid  0) { // parent process;
 close(sockets[0]);
 m_processIdentifier = pid;


Modified: trunk/Source/WebKit2/UIProcess/WebProcessProxy.cpp (122541 => 122542)

---

99 matches

Mail list logo