[webkit-changes] [206252] trunk/Source/WebCore
Title: [206252] trunk/Source/WebCore Revision 206252 Author commit-qu...@webkit.org Date 2016-09-22 00:35:46 -0700 (Thu, 22 Sep 2016) Log Message Improve DeferredWrapper code https://bugs.webkit.org/show_bug.cgi?id=161787 Patch by Youenn Fablet on 2016-09-22 Reviewed by Darin Adler. No change of behavior. Renaming DeferredWrapper to DeferredPromise. Adding create method that creates the underlying JSC::JSPromiseDeferred in non-worker environments. Updated create method to take references. Introducing domWindow helper accessor into JSDOMObject to ease creation of promise in non-worker environments. Doing some minor clean up (renaming of m_wrapper to m_promiseDeferred, accessor change). * Modules/applepay/ApplePaySession.cpp: (WebCore::ApplePaySession::canMakePaymentsWithActiveCard): * Modules/applepay/ApplePaySession.h: * Modules/fetch/DOMWindowFetch.cpp: (WebCore::DOMWindowFetch::fetch): * Modules/fetch/DOMWindowFetch.h: Updated to take a DeferredPromise to make it consistent with WorkerGlobalScopeFetch. * Modules/fetch/FetchBody.cpp: (WebCore::FetchBody::arrayBuffer): (WebCore::FetchBody::blob): (WebCore::FetchBody::json): (WebCore::FetchBody::text): (WebCore::FetchBody::consume): (WebCore::FetchBody::consumeArrayBuffer): (WebCore::FetchBody::consumeArrayBufferView): (WebCore::FetchBody::consumeText): (WebCore::FetchBody::consumeBlob): * Modules/fetch/FetchBody.h: (WebCore::FetchBody::formData): * Modules/fetch/FetchBodyConsumer.cpp: (WebCore::FetchBodyConsumer::resolveWithData): (WebCore::FetchBodyConsumer::resolve): * Modules/fetch/FetchBodyConsumer.h: * Modules/fetch/FetchBodyOwner.cpp: (WebCore::FetchBodyOwner::arrayBuffer): (WebCore::FetchBodyOwner::blob): (WebCore::FetchBodyOwner::formData): (WebCore::FetchBodyOwner::json): (WebCore::FetchBodyOwner::text): * Modules/fetch/FetchBodyOwner.h: * Modules/fetch/FetchResponse.cpp: (WebCore::FetchResponse::consume): (WebCore::FetchResponse::finishConsumingStream): * Modules/fetch/FetchResponse.h: * Modules/fetch/WorkerGlobalScopeFetch.cpp: (WebCore::WorkerGlobalScopeFetch::fetch): * Modules/fetch/WorkerGlobalScopeFetch.h: * bindings/js/JSCustomElementRegistryCustom.cpp: (WebCore::whenDefinedPromise): (WebCore::JSCustomElementRegistry::whenDefined): * bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::visitChildren): * bindings/js/JSDOMGlobalObject.h: * bindings/js/JSDOMPromise.cpp: (WebCore::DOMDeferredPromise::DOMDeferredPromise): (WebCore::DOMDeferredPromise::~DOMDeferredPromise): (WebCore::DOMDeferredPromise::clear): (WebCore::DOMDeferredPromise::contextDestroyed): (WebCore::DOMDeferredPromise::promise): (WebCore::DOMDeferredPromise::callFunction): (WebCore::DOMDeferredPromise::reject): (WebCore::rejectPromiseWithExceptionIfAny): (WebCore::fulfillPromiseWithJSON): (WebCore::fulfillPromiseWithArrayBuffer): (WebCore::DeferredWrapper::DeferredWrapper): Deleted. (WebCore::DeferredWrapper::~DeferredWrapper): Deleted. (WebCore::DeferredWrapper::clear): Deleted. (WebCore::DeferredWrapper::contextDestroyed): Deleted. (WebCore::DeferredWrapper::promise): Deleted. (WebCore::DeferredWrapper::callFunction): Deleted. (WebCore::DeferredWrapper::reject): Deleted. * bindings/js/JSDOMPromise.h: (WebCore::DOMDeferredPromise::create): (WebCore::callPromiseFunction): (WebCore::DOMPromise::DOMPromise): (WebCore::DOMPromise::deferredPromise): (WebCore::DOMDeferredPromise::resolveWithValue): (WebCore::DOMDeferredPromise::resolveWithNewlyCreated): (WebCore::DOMDeferredPromise::rejectWithValue): (WebCore::DOMDeferredPromise::resolve): (WebCore::DOMDeferredPromise::reject): (WebCore::DeferredWrapper::create): Deleted. (WebCore::DOMPromise::deferredWrapper): Deleted. (WebCore::DeferredWrapper::resolveWithValue): Deleted. (WebCore::DeferredWrapper::resolveWithNewlyCreated): Deleted. (WebCore::DeferredWrapper::rejectWithValue): Deleted. (WebCore::DeferredWrapper::resolve): Deleted. (WebCore::DeferredWrapper::reject): Deleted. * bindings/js/JSDOMWrapper.cpp: Introducing domWindow() accessor. * bindings/js/JSDOMWrapper.h: * bindings/js/JSFontFaceCustom.cpp: (WebCore::JSFontFace::loaded): * bindings/js/JSFontFaceSetCustom.cpp: (WebCore::JSFontFaceSet::ready): * bindings/js/JSMediaDevicesCustom.cpp: (WebCore::JSMediaDevices::getUserMedia): * bindings/js/JSMediaStreamTrackCustom.cpp: (WebCore::JSMediaStreamTrack::applyConstraints): * bindings/js/JSReadableStreamSourceCustom.cpp: (WebCore::JSReadableStreamSource::start): * bindings/js/JSWebKitSubtleCryptoCustom.cpp: (WebCore::JSWebKitSubtleCrypto::encrypt): (WebCore::JSWebKitSubtleCrypto::decrypt): (WebCore::JSWebKitSubtleCrypto::sign): (WebCore::JSWebKitSubtleCrypto::verify): (WebCore::JSWebKitSubtleCrypto::digest): (WebCore::JSWebKitSubtleCrypto::generateKey): (WebCore::JSWebKitSubtleCrypto::importKey): (WebCore::JSWebKitSubtleCrypto::exportKey): (WebCore::JSWebKitSubtleCrypto::wrapKey): (WebCore::JSWebKitSubtleCrypto::unwrapKey): * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): (GenerateRetur
[webkit-changes] [206253] trunk
Title: [206253] trunk Revision 206253 Author svil...@igalia.com Date 2016-09-22 00:57:32 -0700 (Thu, 22 Sep 2016) Log Message [css-grid] Remove the x2 computation of row sizes with indefinite heights https://bugs.webkit.org/show_bug.cgi?id=162150 Reviewed by Darin Adler. PerformanceTests: Added a new test case which checks the layout performance of grids inside other grids, i.e, grids acting both as grid container and grid item. * Layout/nested-grid.html: Added. Source/WebCore: On r192154, among other things, we added a second pass of the track sizing algorithm for rows in order to properly compute row sizes when the height was indefinite. We did that in order to have a symmetrical implementation for columns and rows, but unfortunatelly that was not correct. Apart from issuing incorrect results in some cases it created a huge performance issue in the case of having nested grids because we were exponentially increasing the amount of executions of the track sizing algorithm. The attached performance test shows a 200% improvement with the patch (26 vs 80 runs/s). Test: fast/css-grid-layout/nested-grid.html * rendering/RenderGrid.cpp: (WebCore::RenderGrid::layoutBlock): (WebCore::RenderGrid::computeIntrinsicLogicalHeight): (WebCore::RenderGrid::layoutGridItems): LayoutTests: Added a new reftest to check the behavior of grids acting also as grid items and how the track sizing of rows depend on that. It includes tests for grids which stretch their children and grids which do not. Apart from that some expected results were updated so that they no longer fail. * fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html: Updated expectations. * fast/css-grid-layout/nested-grid-expected.html: Added. * fast/css-grid-layout/nested-grid.html: Added. * fast/css-grid-layout/percent-track-breadths-regarding-container-size.html: Removed FIXME. * fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt: Fixed 2 failing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html trunk/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt trunk/LayoutTests/fast/css-grid-layout/percent-track-breadths-regarding-container-size.html trunk/PerformanceTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderGrid.cpp Added Paths trunk/LayoutTests/fast/css-grid-layout/nested-grid-expected.html trunk/LayoutTests/fast/css-grid-layout/nested-grid.html trunk/PerformanceTests/Layout/nested-grid.html Diff Modified: trunk/LayoutTests/ChangeLog (206252 => 206253) --- trunk/LayoutTests/ChangeLog 2016-09-22 07:35:46 UTC (rev 206252) +++ trunk/LayoutTests/ChangeLog 2016-09-22 07:57:32 UTC (rev 206253) @@ -1,3 +1,23 @@ +2016-09-19 Sergio Villar Senin + +[css-grid] Remove the x2 computation of row sizes with indefinite heights +https://bugs.webkit.org/show_bug.cgi?id=162150 + +Reviewed by Darin Adler. + +Added a new reftest to check the behavior of grids acting also as grid items and how the +track sizing of rows depend on that. It includes tests for grids which stretch their +children and grids which do not. + +Apart from that some expected results were updated so that they no longer fail. + +* fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html: Updated expectations. +* fast/css-grid-layout/nested-grid-expected.html: Added. +* fast/css-grid-layout/nested-grid.html: Added. +* fast/css-grid-layout/percent-track-breadths-regarding-container-size.html: Removed FIXME. +* fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt: Fixed 2 +failing tests. + 2016-09-21 Jiewen Tan Unreviewed, update ios-simulator-wk1 test expectations Modified: trunk/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html (206252 => 206253) --- trunk/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html 2016-09-22 07:35:46 UTC (rev 206252) +++ trunk/LayoutTests/fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html 2016-09-22 07:57:32 UTC (rev 206253) @@ -54,15 +54,15 @@ -XX XXX XX XXX +XX XXX XX XXX -XX XXX X +XX XXX X -XX XXX +XX XXX @@ -132,11 +132,11 @@ -XX XX XX +XX XX XX -XX X +XX X @@ -150,11 +150,11 @@ -XX XXX +XX XXX -XX XX +XX XX @@ -162,11 +162,11 @@ - + - X X + X X @@ -209,7 +209,7 @@ X X - XX XX XX + XX XX XX X XX X @@ -230,7 +230,7 @@ X X - X XXX XX + X XXX XX XX XXX XX X @@ -239,22 +239,22 @@ - XX X + XX X - XX X + XX X
[webkit-changes] [206254] trunk/Source/WebCore
Title: [206254] trunk/Source/WebCore Revision 206254 Author commit-qu...@webkit.org Date 2016-09-22 01:28:37 -0700 (Thu, 22 Sep 2016) Log Message Refactor ContentSecurityPolicy::allow* methods https://bugs.webkit.org/show_bug.cgi?id=162335 Patch by Youenn Fablet on 2016-09-22 Reviewed by Darin Adler. No change of behavior. Removing the second parameter of ContentSecurityPolicy::allow* methods. When true, this parameter makes the methods return true. This patch updates the callers of allow* methods to check for the parameter before making the call. Made some refactoring to share more code between the various allow* methods. * Modules/fetch/FetchLoader.cpp: (WebCore::FetchLoader::start): * Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::connect): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::isSafeToLoadURL): (WebCore::HTMLMediaElement::outOfBandTrackSources): * html/HTMLPlugInImageElement.cpp: (WebCore::HTMLPlugInImageElement::allowedToLoadPluginContent): * html/HTMLTrackElement.cpp: (WebCore::HTMLTrackElement::canLoadURL): * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): (WebCore::DocumentThreadableLoader::redirectReceived): (WebCore::DocumentThreadableLoader::loadRequest): (WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy): * loader/DocumentThreadableLoader.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkIfFormActionAllowedByCSP): * loader/PolicyChecker.cpp: (WebCore::isAllowedByContentSecurityPolicy): * loader/SubframeLoader.cpp: (WebCore::SubframeLoader::createJavaAppletWidget): * loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::allowedByContentSecurityPolicy): * page/EventSource.cpp: (WebCore::EventSource::create): * page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowResourceFromSource): (WebCore::ContentSecurityPolicy::allowChildContextFromSource): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::allowConnectToSource): (WebCore::ContentSecurityPolicy::allowFormAction): * page/csp/ContentSecurityPolicy.h: * workers/AbstractWorker.cpp: (WebCore::AbstractWorker::resolveURL): * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::importScripts): * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::initSend): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/fetch/FetchLoader.cpp trunk/Source/WebCore/Modules/websockets/WebSocket.cpp trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp trunk/Source/WebCore/html/HTMLTrackElement.cpp trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp trunk/Source/WebCore/loader/DocumentThreadableLoader.h trunk/Source/WebCore/loader/FrameLoader.cpp trunk/Source/WebCore/loader/PolicyChecker.cpp trunk/Source/WebCore/loader/SubframeLoader.cpp trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp trunk/Source/WebCore/page/EventSource.cpp trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp trunk/Source/WebCore/page/csp/ContentSecurityPolicy.h trunk/Source/WebCore/workers/AbstractWorker.cpp trunk/Source/WebCore/workers/WorkerGlobalScope.cpp trunk/Source/WebCore/xml/XMLHttpRequest.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (206253 => 206254) --- trunk/Source/WebCore/ChangeLog 2016-09-22 07:57:32 UTC (rev 206253) +++ trunk/Source/WebCore/ChangeLog 2016-09-22 08:28:37 UTC (rev 206254) @@ -1,3 +1,65 @@ +2016-09-22 Youenn Fablet + +Refactor ContentSecurityPolicy::allow* methods +https://bugs.webkit.org/show_bug.cgi?id=162335 + +Reviewed by Darin Adler. + +No change of behavior. + +Removing the second parameter of ContentSecurityPolicy::allow* methods. +When true, this parameter makes the methods return true. +This patch updates the callers of allow* methods to check for the parameter before making the call. + +Made some refactoring to share more code between the various allow* methods. + +* Modules/fetch/FetchLoader.cpp: +(WebCore::FetchLoader::start): +* Modules/websockets/WebSocket.cpp: +(WebCore::WebSocket::connect): +* html/HTMLMediaElement.cpp: +(WebCore::HTMLMediaElement::isSafeToLoadURL): +(WebCore::HTMLMediaElement::outOfBandTrackSources): +* html/HTMLPlugInImageElement.cpp: +(WebCore::HTMLPlugInImageElement::allowedToLoadPluginContent): +* html/HTMLTrackElement.cpp: +(WebCore::HTMLTrackElement::canLoadURL): +* loader/DocumentThreadableLoader.cpp: +(WebCore::DocumentThreadab
[webkit-changes] [206255] trunk
Title: [206255] trunk
Revision 206255
Author commit-qu...@webkit.org
Date 2016-09-22 01:57:12 -0700 (Thu, 22 Sep 2016)
Log Message
CachedResourceRequest should store a SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=162258
Patch by Youenn Fablet on 2016-09-22
Reviewed by Sam Weinig.
Source/WebCore:
Test: http/tests/local/script-crossorigin-loads-file-scheme.html
Passing SecurityOrigin from loader clients to CachedResource through CachedResourceRequest.
This ensures that specific origin properties like universal access are well preserved.
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest): Set origin to the request.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource): Setting origin from the request.
Computing CORS state based on that origin.
(WebCore::CachedResource::load): Removing origin computation.
(WebCore::CachedResource::loadFrom): Ditto.
(WebCore::CachedResource::computeOrigin): Deleted.
* loader/cache/CachedResource.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
(WebCore::CachedResourceLoader::prepareFetch): Introduced to implement step 1 to 7 of https://fetch.spec.whatwg.org/#fetching.
(WebCore::CachedResourceLoader::requestResource):
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin): Storing origin.
* loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::setOrigin):
(WebCore::CachedResourceRequest::releaseOrigin):
(WebCore::CachedResourceRequest::origin):
LayoutTests:
Updated test to expect load even though CORS checks should fail as the document origin has universal access.
* http/tests/local/script-crossorigin-loads-fail-origin-expected.txt: Removed.
* http/tests/local/script-crossorigin-loads-file-scheme-expected.txt: Added.
* http/tests/local/script-crossorigin-loads-file-scheme.html: Renamed from LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentThreadableLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResource.cpp
trunk/Source/WebCore/loader/cache/CachedResource.h
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp
trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp
trunk/Source/WebCore/loader/cache/CachedResourceRequest.h
Added Paths
trunk/LayoutTests/http/tests/local/script-crossorigin-loads-file-scheme-expected.txt
trunk/LayoutTests/http/tests/local/script-crossorigin-loads-file-scheme.html
Removed Paths
trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin-expected.txt
trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html
Diff
Modified: trunk/LayoutTests/ChangeLog (206254 => 206255)
--- trunk/LayoutTests/ChangeLog 2016-09-22 08:28:37 UTC (rev 206254)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 08:57:12 UTC (rev 206255)
@@ -1,3 +1,16 @@
+2016-09-22 Youenn Fablet
+
+CachedResourceRequest should store a SecurityOrigin
+https://bugs.webkit.org/show_bug.cgi?id=162258
+
+Reviewed by Sam Weinig.
+
+Updated test to expect load even though CORS checks should fail as the document origin has universal access.
+
+* http/tests/local/script-crossorigin-loads-fail-origin-expected.txt: Removed.
+* http/tests/local/script-crossorigin-loads-file-scheme-expected.txt: Added.
+* http/tests/local/script-crossorigin-loads-file-scheme.html: Renamed from LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html.
+
2016-09-19 Sergio Villar Senin
[css-grid] Remove the x2 computation of row sizes with indefinite heights
Deleted: trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin-expected.txt (206254 => 206255)
--- trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin-expected.txt 2016-09-22 08:28:37 UTC (rev 206254)
+++ trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin-expected.txt 2016-09-22 08:57:12 UTC (rev 206255)
@@ -1,5 +0,0 @@
-CONSOLE MESSAGE: Origin is not allowed by Access-Control-Allow-Origin.
-CONSOLE MESSAGE: Cross-origin script load denied by Cross-Origin Resource Sharing policy.
-This test fails if the script loads correctly.
-
-PASS
Deleted: trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html (206254 => 206255)
--- trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html 2016-09-22 08:28:37 UTC (rev 206254)
+++ trunk/LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html 2016-09-22 08:57:12 UTC (rev 206255)
@@ -1,23 +0,0 @@
-
-This test fails if the script loads correctly.
-
-
-if (window.testRunner) {
-testRunner.dumpAsText();
-testRunner.waitUntilDone();
-}
-
-function done(msg) {
-document.querySelector("pre
[webkit-changes] [206257] trunk/Source/WebCore
Title: [206257] trunk/Source/WebCore
Revision 206257
Author commit-qu...@webkit.org
Date 2016-09-22 05:43:55 -0700 (Thu, 22 Sep 2016)
Log Message
[GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL
https://bugs.webkit.org/show_bug.cgi?id=159928
Patch by Olivier Blin on 2016-09-22
Reviewed by Carlos Garcia Campos.
Copy of GStreamer video frames to WebGL textures was not accelerated.
WebGLRenderingContextBase::texImage2D(HTMLVideoElement) went
through a slow software paint() wrapping the video frame into
cairo surface (ImageGStreamer), downloading it to draw to the
image cache context, copying it again in software, and uploading
it back to an OpenGL texture.
This patch implements copyVideoTextureToPlatformTexture() for
the GStreamer media player backend, to do GPU-to-GPU copy, by
extracting code from nativeImageForCurrentTime().
Doing this also fixes bug #159621: red and blue colors were
swapped in video rendered through WebGL with GSTREAMER_GL enabled.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::prepareContextForCairoPaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToCairoSurface):
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (206256 => 206257)
--- trunk/Source/WebCore/ChangeLog 2016-09-22 12:14:39 UTC (rev 206256)
+++ trunk/Source/WebCore/ChangeLog 2016-09-22 12:43:55 UTC (rev 206257)
@@ -1,3 +1,32 @@
+2016-09-22 Olivier Blin
+
+[GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL
+https://bugs.webkit.org/show_bug.cgi?id=159928
+
+Reviewed by Carlos Garcia Campos.
+
+Copy of GStreamer video frames to WebGL textures was not accelerated.
+
+WebGLRenderingContextBase::texImage2D(HTMLVideoElement) went
+through a slow software paint() wrapping the video frame into
+cairo surface (ImageGStreamer), downloading it to draw to the
+image cache context, copying it again in software, and uploading
+it back to an OpenGL texture.
+
+This patch implements copyVideoTextureToPlatformTexture() for
+the GStreamer media player backend, to do GPU-to-GPU copy, by
+extracting code from nativeImageForCurrentTime().
+
+Doing this also fixes bug #159621: red and blue colors were
+swapped in video rendered through WebGL with GSTREAMER_GL enabled.
+
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+(WebCore::MediaPlayerPrivateGStreamerBase::prepareContextForCairoPaint):
+(WebCore::MediaPlayerPrivateGStreamerBase::paintToCairoSurface):
+(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
+(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
+* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
2016-09-22 Carlos Garcia Campos
[GTK] Rename DataObjectGtk as SelectionData
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (206256 => 206257)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-09-22 12:14:39 UTC (rev 206256)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2016-09-22 12:43:55 UTC (rev 206257)
@@ -697,38 +697,36 @@
#endif
#if USE(GSTREAMER_GL)
-NativeImagePtr MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime()
+// This should be called with the sample mutex locked.
+GLContext* MediaPlayerPrivateGStreamerBase::prepareContextForCairoPaint(GstVideoInfo& videoInfo, IntSize& size, IntSize& rotatedSize)
{
-#if USE(CAIRO) && ENABLE(ACCELERATED_2D_CANVAS)
-if (m_usingFallbackVideoSink)
+if (!getSampleVideoInfo(m_sample.get(), videoInfo))
return nullptr;
-WTF::GMutexLocker lock(m_sampleMutex);
+GLContext* context = PlatformDisplay::sharedDisplayForCompositing().sharingGLContext();
+context->makeContextCurrent();
-GstVideoInfo videoInfo;
-if (!getSampleVideoInfo(m_sample.get(), videoInfo))
-return nullptr;
+// Thread-awareness is a huge performance hit on non-Intel drivers.
+cairo_gl_device_set_thread_aware(context->cairoDevice(), FALSE);
+size = IntSize(GST_VIDEO_INFO_WIDTH(&videoInfo), GST_VIDEO_INFO_HEIGHT(&videoInfo));
+rotatedSize = m_videoSourceOrientation.usesWidthAsHeight() ? size.transposedSize() : size;
+
+return context;
+}
+
+// This should be called with the sample mutex locked.
+bool MediaPlayerPrivateG
[webkit-changes] [206258] trunk/Source/WebCore
Title: [206258] trunk/Source/WebCore Revision 206258 Author ander...@apple.com Date 2016-09-22 07:15:08 -0700 (Thu, 22 Sep 2016) Log Message Attempt to fix the open source iOS build. * platform/spi/cocoa/PassKitSPI.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h Diff Modified: trunk/Source/WebCore/ChangeLog (206257 => 206258) --- trunk/Source/WebCore/ChangeLog 2016-09-22 12:43:55 UTC (rev 206257) +++ trunk/Source/WebCore/ChangeLog 2016-09-22 14:15:08 UTC (rev 206258) @@ -1,3 +1,9 @@ +2016-09-22 Anders Carlsson + +Attempt to fix the open source iOS build. + +* platform/spi/cocoa/PassKitSPI.h: + 2016-09-22 Olivier Blin [GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL Modified: trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h (206257 => 206258) --- trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h 2016-09-22 12:43:55 UTC (rev 206257) +++ trunk/Source/WebCore/platform/spi/cocoa/PassKitSPI.h 2016-09-22 14:15:08 UTC (rev 206258) @@ -187,6 +187,9 @@ - (void)paymentAuthorizationViewController:(PKPaymentAuthorizationViewController *)controller didSelectPaymentMethod:(PKPaymentMethod *)paymentMethod completion:(void (^)(NSArray *summaryItems))completion; @end +@interface PKPassLibrary : NSObject +@end + NS_ASSUME_NONNULL_END #endif @@ -211,9 +214,6 @@ - (void)paymentAuthorizationViewController:(PKPaymentAuthorizationViewController *)controller didRequestMerchantSession:(void(^)(PKPaymentMerchantSession *, NSError *))sessionBlock; @end -@interface PKPassLibrary : NSObject -@end - NS_ASSUME_NONNULL_END #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206259] trunk
Title: [206259] trunk
Revision 206259
Author n_w...@apple.com
Date 2016-09-22 08:14:27 -0700 (Thu, 22 Sep 2016)
Log Message
AX: aria-pressed state not correctly conveyed to VoiceOver iOS on unless role=button added
https://bugs.webkit.org/show_bug.cgi?id=162269
Reviewed by Chris Fleizach.
Source/WebCore:
with aria-pressed attribute has a toggle button role, however, we were looking for explicit
roles in order to convey the aria-press state. Since there's no spec requiring authors explicitly defining
default ARIA semantics in such case, I'm exposing the aria-pressed state for all valid toggle buttons.
Changes are covered in modified test.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isPressed):
LayoutTests:
Added test cases and also fixed a wrong expected output.
* accessibility/ios-simulator/aria-pressed-state-expected.txt:
* accessibility/ios-simulator/aria-pressed-state.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state.html
trunk/LayoutTests/accessibility/ios-simulator/toggle-button-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (206258 => 206259)
--- trunk/LayoutTests/ChangeLog 2016-09-22 14:15:08 UTC (rev 206258)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 15:14:27 UTC (rev 206259)
@@ -1,3 +1,15 @@
+2016-09-22 Nan Wang
+
+AX: aria-pressed state not correctly conveyed to VoiceOver iOS on unless role=button added
+https://bugs.webkit.org/show_bug.cgi?id=162269
+
+Reviewed by Chris Fleizach.
+
+Added test cases and also fixed a wrong expected output.
+
+* accessibility/ios-simulator/aria-pressed-state-expected.txt:
+* accessibility/ios-simulator/aria-pressed-state.html:
+
2016-09-22 Youenn Fablet
CachedResourceRequest should store a SecurityOrigin
Modified: trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state-expected.txt (206258 => 206259)
--- trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state-expected.txt 2016-09-22 14:15:08 UTC (rev 206258)
+++ trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state-expected.txt 2016-09-22 15:14:27 UTC (rev 206259)
@@ -1,11 +1,14 @@
button 1
button 2
+button3 button4
This test thats aria-pressed changes the traits returned by buttons
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-FAIL btn1.iphoneTraits != btn2.iphoneTraits should be true. Was false.
+PASS btn1.traits != btn2.traits is true
+PASS btn3.stringValue is 'AXValue: 1'
+PASS btn4.stringValue is 'AXValue: 1'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state.html (206258 => 206259)
--- trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state.html 2016-09-22 14:15:08 UTC (rev 206258)
+++ trunk/LayoutTests/accessibility/ios-simulator/aria-pressed-state.html 2016-09-22 15:14:27 UTC (rev 206259)
@@ -11,8 +11,10 @@
button 1
-button 2
+button 2
+button3
+button4
@@ -29,7 +31,13 @@
document.getElementById("button2").focus();
var btn2 = accessibilityController.focusedElement;
-shouldBe("btn1.iphoneTraits != btn2.iphoneTraits", "true");
+shouldBeTrue("btn1.traits != btn2.traits");
+
+// Make sure aria-press value is exposed correctly with native button tags.
+var btn3 = accessibilityController.accessibleElementById("button3");
+shouldBe("btn3.stringValue", "'AXValue: 1'");
+var btn4 = accessibilityController.accessibleElementById("button4");
+shouldBe("btn4.stringValue", "'AXValue: 1'");
}
successfullyParsed = true;
Modified: trunk/LayoutTests/accessibility/ios-simulator/toggle-button-expected.txt (206258 => 206259)
--- trunk/LayoutTests/accessibility/ios-simulator/toggle-button-expected.txt 2016-09-22 14:15:08 UTC (rev 206258)
+++ trunk/LayoutTests/accessibility/ios-simulator/toggle-button-expected.txt 2016-09-22 15:14:27 UTC (rev 206259)
@@ -7,7 +7,7 @@
Button1 : AXLabel: Bold
Button1 : AXValue:
Button2 : AXLabel: Italic
-Button2 : AXValue:
+Button2 : AXValue: 1
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/Source/WebCore/ChangeLog (206258 => 206259)
--- trunk/Source/WebCore/ChangeLog 2016-09-22 14:15:08 UTC (rev 206258)
+++ trunk/Source/WebCore/ChangeLog 2016-09-22 15:14:27 UTC (rev 206259)
@@ -1,3 +1,19 @@
+2016-09-22 Nan Wang
+
+AX: aria-pressed state not correctly conveyed to VoiceOver iOS on unless role=button added
+https://bugs.webkit.org/show_bug.cgi?id=162269
+
+Reviewed by Chris Fleizach.
+
+ with aria-pressed attribute has a toggle button role, however, we were looking for explicit
+roles in
[webkit-changes] [206261] trunk
Title: [206261] trunk Revision 206261 Author jbed...@apple.com Date 2016-09-22 10:39:51 -0700 (Thu, 22 Sep 2016) Log Message Automatic Text Replacement Testing in WebKit2 https://bugs.webkit.org/show_bug.cgi?id=161919 Reviewed by Ryosuke Niwa. Source/WebCore: Fixing existing tests: editing/inserting/smart-link-when-caret-is-moved-before-URL.html editing/inserting/typing-space-to-trigger-smart-link.html Implemented test hooks for text replacement for WebKit2. Note that spell checking has not been implemented, so most tests which use text replacement still fail. * testing/Internals.cpp: (WebCore::Internals::Internals): Reset TextChecker. (WebCore::Internals::setContinuousSpellCheckingEnabled): Converted exception to an assert. (WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Converted exception to an assert. (WebCore::Internals::setAutomaticLinkDetectionEnabled): Converted exception to an assert. (WebCore::Internals::setAutomaticDashSubstitutionEnabled): Converted exception to an assert. (WebCore::Internals::setAutomaticTextReplacementEnabled): Converted exception to an assert. (WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Converted exception to an assert. * testing/Internals.h: Removed exception argument for TextChecker setters. * testing/Internals.idl: Ditto. Source/WebKit2: Implemented test hooks for text replacement for WebKit2. Note that spell checking has not been implemented, so most tests which use text replacement still fail. * UIProcess/API/C/WKTextChecker.cpp: Added #ifdefs to include file for iOS and Mac. (WKTextCheckerSetTestingMode): Added. * UIProcess/API/C/WKTextChecker.h: Added #ifdefs to include file for iOS and Mac. * UIProcess/TextChecker.h: Added hooks to bypass writing to NSUserDefaults. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::toggleSmartInsertDelete): New message to toggle TextChecker flag. (WebKit::WebPageProxy::toggleAutomaticQuoteSubstitution): Ditto. (WebKit::WebPageProxy::toggleAutomaticLinkDetection): Ditto. (WebKit::WebPageProxy::toggleAutomaticDashSubstitution): Ditto. (WebKit::WebPageProxy::toggleAutomaticTextReplacement): Ditto. * UIProcess/WebPageProxy.h: Added messages to toggle TextChecker flags. * UIProcess/WebPageProxy.messages.in: Ditto. * UIProcess/efl/TextCheckerEfl.cpp: Implemented new TextChecker hooks for non-Cocoa platforms. * UIProcess/gtk/TextCheckerGtk.cpp: Ditto. (WebKit::TextChecker::mutableState): Ditto. * UIProcess/ios/TextCheckerIOS.mm: Implemented new TextChecker hooks. (WebKit::TextChecker::mutableState): Allow modification of text checker without writing to NSUserDefaults. (WebKit::TextChecker::state): Call mutableState. (WebKit::TextChecker::accessSmartInsertDeleteEnabled): Dummy function. * UIProcess/mac/TextCheckerMac.mm: (WebKit::refresh): Reload TextChecker configuration from NSUserDefaults. (WebKit::TextChecker::mutableState): Allow modification of text checker without writing to NSUserDefaults. (WebKit::TextChecker::state): Call mutableState(). (WebKit::TextChecker::accessSmartInsertDeleteEnabled): Allow toggling of smartInsertDeleteEnabled without writing to NSUserDefaults. (WebKit::initializeState): Deleted. * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleSetAutomaticLinkDetectionEnabled): Deleted. * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Removed WKBundleSetAutomaticLinkDetectionEnabled. * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setAutomaticLinkDetectionEnabled): Deleted. * WebKit2.xcodeproj/project.pbxproj: Added WKTextChecker to Mac and iOS. * WebProcess/InjectedBundle/InjectedBundle.h: Remove setAutomaticLinkDetectionEnabled. * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::toggleSmartInsertDelete): Send message to UI process to toggle TextChecker. (WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution): Ditto. (WebKit::WebEditorClient::toggleAutomaticLinkDetection): Ditto. (WebKit::WebEditorClient::toggleAutomaticDashSubstitution): Ditto. (WebKit::WebEditorClient::toggleAutomaticTextReplacement): Ditto. Tools: Implemented test hooks for text replacement for WebKit2. Note that spell checking has not been implemented, so most tests which use text replacement still fail. * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto. (WTR::InjectedBundle::beginTesting): Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto. * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto. * WebKitTestRunner/TestController.cpp: (WTR::TestController::runTest): Place TextChecker into testing mode. LayoutTests: Implemented test hooks for text replacement for WebKit2. Note that spell checking has not been implemented, so most tests which use text replacement still fail. * editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Use internals instead of
[webkit-changes] [206262] trunk/LayoutTests
Title: [206262] trunk/LayoutTests Revision 206262 Author commit-qu...@webkit.org Date 2016-09-22 10:59:34 -0700 (Thu, 22 Sep 2016) Log Message imported/w3c/web-platform-tests/resource-timing/idlharness.html is flaky https://bugs.webkit.org/show_bug.cgi?id=162414 Unreviewed. Patch by Youenn Fablet on 2016-09-22 * TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (206261 => 206262) --- trunk/LayoutTests/ChangeLog 2016-09-22 17:39:51 UTC (rev 206261) +++ trunk/LayoutTests/ChangeLog 2016-09-22 17:59:34 UTC (rev 206262) @@ -1,3 +1,12 @@ +2016-09-22 Youenn Fablet + +imported/w3c/web-platform-tests/resource-timing/idlharness.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=162414 + +Unreviewed. + +* TestExpectations: + 2016-09-22 Jonathan Bedard Automatic Text Replacement Testing in WebKit2 Modified: trunk/LayoutTests/TestExpectations (206261 => 206262) --- trunk/LayoutTests/TestExpectations 2016-09-22 17:39:51 UTC (rev 206261) +++ trunk/LayoutTests/TestExpectations 2016-09-22 17:59:34 UTC (rev 206262) @@ -983,3 +983,4 @@ webkit.org/b/160017 js/regress-139548.html [ Slow ] webkit.org/b/161088 imported/w3c/web-platform-tests/resource-timing/resource-timing.html [ Pass Failure ] +webkit.org/b/162414 imported/w3c/web-platform-tests/resource-timing/idlharness.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206263] trunk/LayoutTests
Title: [206263] trunk/LayoutTests
Revision 206263
Author ryanhad...@apple.com
Date 2016-09-22 11:19:49 -0700 (Thu, 22 Sep 2016)
Log Message
Unreviewed, rolling out r206112.
This change made inspector/network/xhr-json-blob-has-
content.html very flaky.
Reverted changeset:
"Web Inspector: adopt Object.awaitEvent in
LayoutTests/inspector/network"
https://bugs.webkit.org/show_bug.cgi?id=162099
http://trac.webkit.org/changeset/206112
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/network/client-blocked-load-expected.txt
trunk/LayoutTests/inspector/network/client-blocked-load.html
trunk/LayoutTests/inspector/network/xhr-json-blob-has-content.html
Diff
Modified: trunk/LayoutTests/ChangeLog (206262 => 206263)
--- trunk/LayoutTests/ChangeLog 2016-09-22 17:59:34 UTC (rev 206262)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 18:19:49 UTC (rev 206263)
@@ -1,3 +1,17 @@
+2016-09-22 Ryan Haddad
+
+Unreviewed, rolling out r206112.
+
+This change made inspector/network/xhr-json-blob-has-
+content.html very flaky.
+
+Reverted changeset:
+
+"Web Inspector: adopt Object.awaitEvent in
+LayoutTests/inspector/network"
+https://bugs.webkit.org/show_bug.cgi?id=162099
+http://trac.webkit.org/changeset/206112
+
2016-09-22 Youenn Fablet
imported/w3c/web-platform-tests/resource-timing/idlharness.html is flaky
Modified: trunk/LayoutTests/inspector/network/client-blocked-load-expected.txt (206262 => 206263)
--- trunk/LayoutTests/inspector/network/client-blocked-load-expected.txt 2016-09-22 17:59:34 UTC (rev 206262)
+++ trunk/LayoutTests/inspector/network/client-blocked-load-expected.txt 2016-09-22 18:19:49 UTC (rev 206263)
@@ -4,6 +4,6 @@
== Running test suite: ClientBlockedResourceLoad
-- Running test case: TriggerBlockedResourceLoad
PASS: Resource should be created.
-PASS: Added Resource load did fail.
PASS: Request url should be rewritten to the null string.
+PASS: Resource load should fail.
Modified: trunk/LayoutTests/inspector/network/client-blocked-load.html (206262 => 206263)
--- trunk/LayoutTests/inspector/network/client-blocked-load.html 2016-09-22 17:59:34 UTC (rev 206262)
+++ trunk/LayoutTests/inspector/network/client-blocked-load.html 2016-09-22 18:19:49 UTC (rev 206263)
@@ -18,20 +18,17 @@
suite.addTestCase({
name: "TriggerBlockedResourceLoad",
description: "Trigger a blocked resource load and ensure we get notified of the request.",
-test(resolve, reject) {
-Promise.all([
-WebInspector.Frame.awaitEvent(WebInspector.Frame.Event.ResourceWasAdded),
-WebInspector.Resource.awaitEvent(WebInspector.Resource.Event.LoadingDidFail)
-])
-.then(([resourceWasAddedEvent, loadingDidFailEvent]) => {
-let resource = resourceWasAddedEvent.data.resource;
+test: (resolve, reject) => {
+InspectorTest.evaluateInPage("createBlockedResourceLoad()");
+WebInspector.Frame.singleFireEventListener(WebInspector.Frame.Event.ResourceWasAdded, (event) => {
+let resource = event.data.resource;
InspectorTest.expectThat(resource instanceof WebInspector.Resource, "Resource should be created.");
-InspectorTest.expectThat(resource === loadingDidFailEvent.target, "Added Resource load did fail.");
InspectorTest.expectThat(resource.url ="" "", "Request url should be rewritten to the null string.");
-})
-.then(resolve, reject);
-
-InspectorTest.evaluateInPage("createBlockedResourceLoad()");
+resource.singleFireEventListener(WebInspector.Resource.Event.LoadingDidFail, (event) => {
+InspectorTest.pass("Resource load should fail.");
+resolve();
+});
+});
}
});
Modified: trunk/LayoutTests/inspector/network/xhr-json-blob-has-content.html (206262 => 206263)
--- trunk/LayoutTests/inspector/network/xhr-json-blob-has-content.html 2016-09-22 17:59:34 UTC (rev 206262)
+++ trunk/LayoutTests/inspector/network/xhr-json-blob-has-content.html 2016-09-22 18:19:49 UTC (rev 206263)
@@ -25,25 +25,18 @@
suite.addTestCase({
name: "XHR.JSONContent",
description: "Ensure an XMLHttpRequest with JSON content still gives us text.",
-test(resolve, reject) {
-let resource = null;
-
-WebInspector.Frame.awaitEvent(WebInspector.Frame.Event.ResourceWasAdded)
-.then((event) => {
-resource = event.data.resource;
+test: (resolve, reject) => {
+InspectorTest.evaluateInPage("createJSONXHR()");
+WebInspector.Frame.singleFireEventListener(WebInspector.Frame.Event.ResourceWasAdded, (event) => {
+let resource = event.data.resource;
InspectorTest.expectThat(resource instanceof WebIns
[webkit-changes] [206264] trunk/LayoutTests
Title: [206264] trunk/LayoutTests Revision 206264 Author ryanhad...@apple.com Date 2016-09-22 11:30:33 -0700 (Thu, 22 Sep 2016) Log Message Marking imported/w3c/web-platform-tests/media-source/mediasource-duration.html as flaky on mac. https://bugs.webkit.org/show_bug.cgi?id=162308 Unreviewed test gardening. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (206263 => 206264) --- trunk/LayoutTests/ChangeLog 2016-09-22 18:19:49 UTC (rev 206263) +++ trunk/LayoutTests/ChangeLog 2016-09-22 18:30:33 UTC (rev 206264) @@ -1,5 +1,14 @@ 2016-09-22 Ryan Haddad +Marking imported/w3c/web-platform-tests/media-source/mediasource-duration.html as flaky on mac. +https://bugs.webkit.org/show_bug.cgi?id=162308 + +Unreviewed test gardening. + +* platform/mac/TestExpectations: + +2016-09-22 Ryan Haddad + Unreviewed, rolling out r206112. This change made inspector/network/xhr-json-blob-has- Modified: trunk/LayoutTests/platform/mac/TestExpectations (206263 => 206264) --- trunk/LayoutTests/platform/mac/TestExpectations 2016-09-22 18:19:49 UTC (rev 206263) +++ trunk/LayoutTests/platform/mac/TestExpectations 2016-09-22 18:30:33 UTC (rev 206264) @@ -1450,3 +1450,5 @@ webkit.org/b/161156 js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html [ Pass Failure ] webkit.org/b/161883 imported/w3c/web-platform-tests/dom/nodes/ProcessingInstruction-escapes-1.xhtml [ Pass Failure ] + +webkit.org/b/162308 imported/w3c/web-platform-tests/media-source/mediasource-duration.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206265] trunk/Source/WebCore
Title: [206265] trunk/Source/WebCore Revision 206265 Author commit-qu...@webkit.org Date 2016-09-22 11:43:40 -0700 (Thu, 22 Sep 2016) Log Message [WinCairo] Fix build after r206196 Patch by Don Olmstead on 2016-09-22 Reviewed by Alex Christensen. * platform/text/win/LocaleWin.cpp: (WebCore::LocaleWin::getLocaleInfoString): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/text/win/LocaleWin.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (206264 => 206265) --- trunk/Source/WebCore/ChangeLog 2016-09-22 18:30:33 UTC (rev 206264) +++ trunk/Source/WebCore/ChangeLog 2016-09-22 18:43:40 UTC (rev 206265) @@ -1,3 +1,12 @@ +2016-09-22 Don Olmstead + +[WinCairo] Fix build after r206196 + +Reviewed by Alex Christensen. + +* platform/text/win/LocaleWin.cpp: +(WebCore::LocaleWin::getLocaleInfoString): + 2016-09-22 Jonathan Bedard Automatic Text Replacement Testing in WebKit2 Modified: trunk/Source/WebCore/platform/text/win/LocaleWin.cpp (206264 => 206265) --- trunk/Source/WebCore/platform/text/win/LocaleWin.cpp 2016-09-22 18:30:33 UTC (rev 206264) +++ trunk/Source/WebCore/platform/text/win/LocaleWin.cpp 2016-09-22 18:43:40 UTC (rev 206265) @@ -101,7 +101,7 @@ Vector buffer(bufferSizeWithNUL); ::GetLocaleInfo(m_lcid, type, buffer.data(), bufferSizeWithNUL); buffer.shrink(bufferSizeWithNUL - 1); -return String::adopt(buffer); +return String::adopt(WTFMove(buffer)); } void LocaleWin::getLocaleInfo(LCTYPE type, DWORD& result) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206266] trunk
Title: [206266] trunk Revision 206266 Author cdu...@apple.com Date 2016-09-22 11:47:34 -0700 (Thu, 22 Sep 2016) Log Message Fix serialization of HTML void elements when they have children https://bugs.webkit.org/show_bug.cgi?id=162418 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaseline W3C test now that more checks are passing. * web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt: Source/WebCore: Fix serialization of HTML void elements when they have children. Void elements (such as ) cannot have a closing tag. When encountering them, we would properly not serialize the void element's children (if it had any). However, we would incorrectly append an end tag (because the element technically has children). Relevant specification: - https://html.spec.whatwg.org/#html-fragment-serialisation-algorithm In particular, this part: "" If current node is an area, base, basefont, bgsound, br, col, embed, frame, hr, img, input, keygen, link, meta, param, source, track or wbr element, then continue on to the next child node at this point. "" Firefox matches the specification. No new tests, rebaselined existing test. * editing/MarkupAccumulator.cpp: (WebCore::MarkupAccumulator::serializeNodesWithNamespaces): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/MarkupAccumulator.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206265 => 206266) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-22 18:43:40 UTC (rev 206265) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-22 18:47:34 UTC (rev 206266) @@ -1,3 +1,14 @@ +2016-09-22 Chris Dumez + +Fix serialization of HTML void elements when they have children +https://bugs.webkit.org/show_bug.cgi?id=162418 + +Reviewed by Darin Adler. + +Rebaseline W3C test now that more checks are passing. + +* web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt: + 2016-09-22 Youenn Fablet Sync web-platform-tests up to revision 3801ab5 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt (206265 => 206266) --- trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt 2016-09-22 18:43:40 UTC (rev 206265) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt 2016-09-22 18:47:34 UTC (rev 206266) @@ -108,137 +108,137 @@ PASS innerHTML Void context node source PASS innerHTML Void context node track PASS innerHTML Void context node wbr -FAIL innerHTML void as first child with following siblings area assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings base assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings basefont assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings bgsound assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings br assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings col assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings embed assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings frame assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings hr assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings img assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings input assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings keygen assert_equals: expected "test" but got "test" -FAIL innerHTML void as first child with following siblings link assert_equals: expected "test" but got "test" +PASS innerHTML void as first child with following siblings area +PASS innerHTML void as first child with following siblings base +PASS innerHTML void as first child with following siblings basefont +PASS innerHTML void as first child with following siblings bgsound +PASS innerHTML void as first child with following siblings br +PASS innerHTML void as first child with following siblings col +PASS innerHTML void as first child with following siblings embed +PASS innerHTML void as first child with following siblings frame +PASS innerHTML void as first child with following siblings hr +PASS innerHTML void as first child with following siblings img +PASS innerHTML void as first child with follow
[webkit-changes] [206267] trunk/Source/JavaScriptCore
Title: [206267] trunk/Source/_javascript_Core Revision 206267 Author joep...@webkit.org Date 2016-09-22 11:59:47 -0700 (Thu, 22 Sep 2016) Log Message Remove a bunch of unnecessary includes https://bugs.webkit.org/show_bug.cgi?id=162376 Reviewed by Mark Lam. Modified Paths trunk/Source/_javascript_Core/API/JSObjectRef.cpp trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.cpp trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.cpp trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/CallLinkStatus.h trunk/Source/_javascript_Core/bytecode/CodeBlock.h trunk/Source/_javascript_Core/bytecode/CodeOrigin.h trunk/Source/_javascript_Core/bytecode/SpeculatedType.cpp trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h trunk/Source/_javascript_Core/bytecode/ValueProfile.h trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp trunk/Source/_javascript_Core/dfg/DFGByteCodeParser.cpp trunk/Source/_javascript_Core/dfg/DFGOperations.cpp trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp trunk/Source/_javascript_Core/ftl/FTLAbstractHeapRepository.cpp trunk/Source/_javascript_Core/heap/CodeBlockSet.cpp trunk/Source/_javascript_Core/heap/CodeBlockSet.h trunk/Source/_javascript_Core/heap/MarkedSpace.cpp trunk/Source/_javascript_Core/inspector/JSJavaScriptCallFramePrototype.cpp trunk/Source/_javascript_Core/interpreter/CallFrame.cpp trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/interpreter/Interpreter.h trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp trunk/Source/_javascript_Core/interpreter/StackVisitor.h trunk/Source/_javascript_Core/jit/JIT.cpp trunk/Source/_javascript_Core/jit/JIT.h trunk/Source/_javascript_Core/jit/JITOperations.cpp trunk/Source/_javascript_Core/jit/ThunkGenerators.h trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp trunk/Source/_javascript_Core/parser/Nodes.h trunk/Source/_javascript_Core/parser/Parser.cpp trunk/Source/_javascript_Core/parser/Parser.h trunk/Source/_javascript_Core/parser/SourceProvider.cpp trunk/Source/_javascript_Core/runtime/ArgList.h trunk/Source/_javascript_Core/runtime/ArrayBufferView.cpp trunk/Source/_javascript_Core/runtime/Executable.h trunk/Source/_javascript_Core/runtime/FunctionPrototype.cpp trunk/Source/_javascript_Core/runtime/JSEnvironmentRecord.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.h trunk/Source/_javascript_Core/runtime/JSLexicalEnvironment.h trunk/Source/_javascript_Core/runtime/JSPropertyNameEnumerator.h trunk/Source/_javascript_Core/runtime/JSSegmentedVariableObject.h trunk/Source/_javascript_Core/runtime/MapPrototype.cpp trunk/Source/_javascript_Core/runtime/RegExpCachedResult.h trunk/Source/_javascript_Core/runtime/RegExpConstructor.cpp trunk/Source/_javascript_Core/runtime/RegExpObject.cpp trunk/Source/_javascript_Core/runtime/RegExpPrototype.cpp trunk/Source/_javascript_Core/runtime/SamplingProfiler.cpp trunk/Source/_javascript_Core/runtime/SetPrototype.cpp trunk/Source/_javascript_Core/runtime/StringObject.cpp trunk/Source/_javascript_Core/runtime/StringPrototype.cpp trunk/Source/_javascript_Core/runtime/StructureIDTable.cpp trunk/Source/_javascript_Core/runtime/VM.cpp Diff Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (206266 => 206267) --- trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2016-09-22 18:47:34 UTC (rev 206266) +++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2016-09-22 18:59:47 UTC (rev 206267) @@ -30,8 +30,6 @@ #include "APICast.h" #include "APIUtils.h" -#include "ButterflyInlines.h" -#include "CodeBlock.h" #include "DateConstructor.h" #include "ErrorConstructor.h" #include "Exception.h" @@ -40,6 +38,7 @@ #include "InitializeThreading.h" #include "JSAPIWrapperObject.h" #include "JSArray.h" +#include "JSCInlines.h" #include "JSCallbackConstructor.h" #include "JSCallbackFunction.h" #include "JSCallbackObject.h" @@ -52,7 +51,6 @@ #include "JSValueRef.h" #include "ObjectConstructor.h" #include "ObjectPrototype.h" -#include "JSCInlines.h" #include "PropertyNameArray.h" #include "RegExpConstructor.h" Modified: trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.cpp (206266 => 206267) --- trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.cpp 2016-09-22 18:47:34 UTC (rev 206266) +++ trunk/Source/_javascript_Core/API/tests/FunctionOverridesTest.cpp 2016-09-22 18:59:47 UTC (rev 206267) @@ -32,7 +32,6 @@ #include "_javascript_Core.h" #include "Options.h" #include -#include using JSC::Options; Modified: trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.cpp (206266 => 206267) --- trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.cpp 2016-09-22 18:47:34 UTC (rev 206266) +++ trunk/Source/_javascript_Core/API/tests/GlobalContextWithFinalizerTest.cpp 2016-09-22 18:59:47 UTC (rev 206267) @@ -27,7 +27,6 @@ #include "GlobalContextWithFinalizerTest.h" #include "_javascript_Core.
[webkit-changes] [206268] trunk
Title: [206268] trunk
Revision 206268
Author commit-qu...@webkit.org
Date 2016-09-22 12:11:23 -0700 (Thu, 22 Sep 2016)
Log Message
test262: Function length should be number of parameters before parameters with default values
https://bugs.webkit.org/show_bug.cgi?id=162377
Patch by Joseph Pecoraro on 2016-09-22
Reviewed by Saam Barati.
JSTests:
* stress/es6-default-parameters.js:
Add our own tests for function lengths with default parameters.
* test262.yaml:
We now pass all dflt-length tests.
Source/_javascript_Core:
https://tc39.github.io/ecma262/#sec-function-definitions-static-semantics-expectedargumentcount
> NOTE: The ExpectedArgumentCount of a FormalParameterList is the number of
> FormalParameters to the left of either the rest parameter or the first
> FormalParameter with an Initializer. A FormalParameter without an
> initializer is allowed after the first parameter with an initializer
> but such parameters are considered to be optional with undefined as
> their default value.
Alongside the parameterCount value, maintain a separate count,
functionLength, which will be the count before seeing a rest parameter
or parameter with a default value. This will be the function's length.
* bytecode/UnlinkedCodeBlock.h:
* bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
* bytecode/UnlinkedFunctionExecutable.h:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionMetadata):
* parser/Nodes.cpp:
(JSC::FunctionMetadataNode::FunctionMetadataNode):
* parser/Nodes.h:
* parser/Parser.cpp:
(JSC::Parser::isArrowFunctionParameters):
(JSC::Parser::parseGeneratorFunctionSourceElements):
(JSC::Parser::parseFormalParameters):
(JSC::Parser::parseFunctionBody):
(JSC::Parser::parseFunctionParameters):
(JSC::Parser::parseFunctionInfo):
* parser/Parser.h:
* parser/ParserFunctionInfo.h:
* parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionMetadata):
* runtime/Executable.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::createBuiltinFunction):
(JSC::JSFunction::reifyLength):
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/stress/es6-default-parameters.js
trunk/JSTests/test262.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/UnlinkedCodeBlock.h
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.cpp
trunk/Source/_javascript_Core/bytecode/UnlinkedFunctionExecutable.h
trunk/Source/_javascript_Core/parser/ASTBuilder.h
trunk/Source/_javascript_Core/parser/Nodes.cpp
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/Parser.cpp
trunk/Source/_javascript_Core/parser/Parser.h
trunk/Source/_javascript_Core/parser/ParserFunctionInfo.h
trunk/Source/_javascript_Core/parser/SourceProviderCacheItem.h
trunk/Source/_javascript_Core/parser/SyntaxChecker.h
trunk/Source/_javascript_Core/runtime/Executable.h
trunk/Source/_javascript_Core/runtime/JSFunction.cpp
Diff
Modified: trunk/JSTests/ChangeLog (206267 => 206268)
--- trunk/JSTests/ChangeLog 2016-09-22 18:59:47 UTC (rev 206267)
+++ trunk/JSTests/ChangeLog 2016-09-22 19:11:23 UTC (rev 206268)
@@ -1,3 +1,16 @@
+2016-09-22 Joseph Pecoraro
+
+test262: Function length should be number of parameters before parameters with default values
+https://bugs.webkit.org/show_bug.cgi?id=162377
+
+Reviewed by Saam Barati.
+
+* stress/es6-default-parameters.js:
+Add our own tests for function lengths with default parameters.
+
+* test262.yaml:
+We now pass all dflt-length tests.
+
2016-09-20 Benjamin Poulain
[JSC] Do not use EagerRun on tests counting recompilation
Modified: trunk/JSTests/stress/es6-default-parameters.js (206267 => 206268)
--- trunk/JSTests/stress/es6-default-parameters.js 2016-09-22 18:59:47 UTC (rev 206267)
+++ trunk/JSTests/stress/es6-default-parameters.js 2016-09-22 19:11:23 UTC (rev 206268)
@@ -221,6 +221,115 @@
}
})();
+// Length
+
+function named1(a){};
+function named2(a=1){};
+function named3(a,b){};
+function named4(a,b=1){};
+function named5(a=1,b=1){};
+function named6(a,b,c){};
+function named7(a=1,b,c){};
+function named8(a,b=1,c){};
+function named9(a,b,c=1){};
+function named10(a,...b){};
+function named11(a=1,...b){};
+function named12(a=10,b,c=20,...r){};
+
+assert( named1.length === 1 );
+assert( named2.length === 0 );
+assert( named3.length === 2 );
+assert( named4.length === 1 );
+assert( named5.length === 0 );
+assert( named6.length === 3 );
+assert( named7.length === 0 );
+assert( named8.length === 1 );
+assert( named9.length === 2 );
+assert( named10.length === 1 );
+assert( named11.length === 0 );
+assert( named12.length === 0 );
+
+assert( (function(a){}).length === 1 );
+assert( (function(a=1){}).length === 0 );
+assert( (function(a,b){}).length === 2 );
+assert( (function(a,b=1){}).length === 1 );
+assert( (function(a=1,b=1){}).
[webkit-changes] [206269] branches/safari-602-branch/Source
Title: [206269] branches/safari-602-branch/Source Revision 206269 Author bshaf...@apple.com Date 2016-09-22 13:47:46 -0700 (Thu, 22 Sep 2016) Log Message Versioning. Modified Paths branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig (206268 => 206269) --- branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2016-09-22 19:11:23 UTC (rev 206268) +++ branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2016-09-22 20:47:46 UTC (rev 206269) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 11; +TINY_VERSION = 12; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig (206268 => 206269) --- branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig 2016-09-22 19:11:23 UTC (rev 206268) +++ branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig 2016-09-22 20:47:46 UTC (rev 206269) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 11; +TINY_VERSION = 12; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (206268 => 206269) --- branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-09-22 19:11:23 UTC (rev 206268) +++ branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-09-22 20:47:46 UTC (rev 206269) @@ -1,6 +1,6 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 11; +TINY_VERSION = 12; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig (206268 => 206269) --- branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2016-09-22 19:11:23 UTC (rev 206268) +++ branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2016-09-22 20:47:46 UTC (rev 206269) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 11; +TINY_VERSION = 12; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig (206268 => 206269) --- branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig 2016-09-22 19:11:23 UTC (rev 206268) +++ branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig 2016-09-22 20:47:46 UTC (rev 206269) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 11; +TINY_VERSION = 12; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206270] branches/safari-602-branch/Source/WebCore
Title: [206270] branches/safari-602-branch/Source/WebCore
Revision 206270
Author bshaf...@apple.com
Date 2016-09-22 13:48:55 -0700 (Thu, 22 Sep 2016)
Log Message
Merge r206027. rdar://problem/28366812
Modified Paths
branches/safari-602-branch/Source/WebCore/ChangeLog
branches/safari-602-branch/Source/WebCore/PlatformWin.cmake
Diff
Modified: branches/safari-602-branch/Source/WebCore/ChangeLog (206269 => 206270)
--- branches/safari-602-branch/Source/WebCore/ChangeLog 2016-09-22 20:47:46 UTC (rev 206269)
+++ branches/safari-602-branch/Source/WebCore/ChangeLog 2016-09-22 20:48:55 UTC (rev 206270)
@@ -1,3 +1,19 @@
+2016-09-22 Babak Shafiei
+
+Merge r206027. rdar://problem/28366812
+
+2016-09-16 Per Arne Vollan
+
+[Win] Compile fix.
+https://bugs.webkit.org/show_bug.cgi?id=162059
+
+Reviewed by Alex Christensen.
+
+If an include file exists in two places in the include paths, we can end up including the file twice,
+since #pragma once will not protect us against this.
+
+* PlatformWin.cmake: Put WebCore forwarding folder first in include list.
+
2016-09-16 Babak Shafiei
Merge r206006. rdar://problem/27991573
Modified: branches/safari-602-branch/Source/WebCore/PlatformWin.cmake (206269 => 206270)
--- branches/safari-602-branch/Source/WebCore/PlatformWin.cmake 2016-09-22 20:47:46 UTC (rev 206269)
+++ branches/safari-602-branch/Source/WebCore/PlatformWin.cmake 2016-09-22 20:48:55 UTC (rev 206270)
@@ -1,6 +1,7 @@
add_definitions(/bigobj)
list(APPEND WebCore_INCLUDE_DIRECTORIES
+"${WEBCORE_DIR}/ForwardingHeaders"
"${CMAKE_BINARY_DIR}/../include/private"
"${CMAKE_BINARY_DIR}/../include/private/_javascript_Core"
"${DERIVED_SOURCES_DIR}/ForwardingHeaders/ANGLE"
@@ -24,7 +25,6 @@
"${DERIVED_SOURCES_DIR}/ForwardingHeaders/_javascript_Core/runtime"
"${DERIVED_SOURCES_DIR}/ForwardingHeaders/_javascript_Core/yarr"
"${DERIVED_SOURCES_DIR}/ForwardingHeaders/WTF"
-"${WEBCORE_DIR}/ForwardingHeaders"
"${WEBCORE_DIR}/accessibility/win"
"${WEBCORE_DIR}/page/win"
"${WEBCORE_DIR}/platform/cf"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206271] tags/Safari-602.2.12/
Title: [206271] tags/Safari-602.2.12/ Revision 206271 Author bshaf...@apple.com Date 2016-09-22 13:50:21 -0700 (Thu, 22 Sep 2016) Log Message New tag. Added Paths tags/Safari-602.2.12/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206272] trunk/Source/WebCore
Title: [206272] trunk/Source/WebCore Revision 206272 Author jer.no...@apple.com Date 2016-09-22 13:54:56 -0700 (Thu, 22 Sep 2016) Log Message Fullscreen controls inoperative in WebKitLegacy web views https://bugs.webkit.org/show_bug.cgi?id=162374 Reviewed by Eric Carlson. After r205365, the WebPlaybackSessionInterfaceAVKit was now created after the WebPlaybackSessionModel which fed it data, so it no longer received the burst of data upon creation. Instead, it should have always asked the model for its cached data as soon as it was connected to set up its inital state. * platform/ios/WebPlaybackSessionInterfaceAVKit.mm: (WebCore::WebPlaybackSessionInterfaceAVKit::WebPlaybackSessionInterfaceAVKit): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm Diff Modified: trunk/Source/WebCore/ChangeLog (206271 => 206272) --- trunk/Source/WebCore/ChangeLog 2016-09-22 20:50:21 UTC (rev 206271) +++ trunk/Source/WebCore/ChangeLog 2016-09-22 20:54:56 UTC (rev 206272) @@ -1,3 +1,18 @@ +2016-09-22 Jer Noble + +Fullscreen controls inoperative in WebKitLegacy web views +https://bugs.webkit.org/show_bug.cgi?id=162374 + +Reviewed by Eric Carlson. + +After r205365, the WebPlaybackSessionInterfaceAVKit was now created after the +WebPlaybackSessionModel which fed it data, so it no longer received the burst of data upon +creation. Instead, it should have always asked the model for its cached data as soon as it +was connected to set up its inital state. + +* platform/ios/WebPlaybackSessionInterfaceAVKit.mm: +(WebCore::WebPlaybackSessionInterfaceAVKit::WebPlaybackSessionInterfaceAVKit): + 2016-09-22 Chris Dumez Fix serialization of HTML void elements when they have children Modified: trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm (206271 => 206272) --- trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm 2016-09-22 20:50:21 UTC (rev 206271) +++ trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm 2016-09-22 20:54:56 UTC (rev 206272) @@ -54,6 +54,17 @@ model.addClient(*this); [m_playerController setPlaybackSessionInterface:this]; [m_playerController setDelegate:&model]; + +durationChanged(model.duration()); +currentTimeChanged(model.currentTime(), [[NSProcessInfo processInfo] systemUptime]); +bufferedTimeChanged(model.bufferedTime()); +rateChanged(model.isPlaying(), model.playbackRate()); +seekableRangesChanged(model.seekableRanges()); +canPlayFastReverseChanged(model.canPlayFastReverse()); +audioMediaSelectionOptionsChanged(model.audioMediaSelectionOptions(), model.audioMediaSelectedIndex()); +legibleMediaSelectionOptionsChanged(model.legibleMediaSelectionOptions(), model.legibleMediaSelectedIndex()); +externalPlaybackChanged(model.externalPlaybackEnabled(), model.externalPlaybackTargetType(), model.externalPlaybackLocalizedDeviceName()); +wirelessVideoPlaybackDisabledChanged(model.wirelessVideoPlaybackDisabled()); } WebPlaybackSessionInterfaceAVKit::~WebPlaybackSessionInterfaceAVKit() ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206273] branches/safari-602-branch/Source
Title: [206273] branches/safari-602-branch/Source Revision 206273 Author bshaf...@apple.com Date 2016-09-22 14:05:46 -0700 (Thu, 22 Sep 2016) Log Message Versioning. Modified Paths branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig (206272 => 206273) --- branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2016-09-22 20:54:56 UTC (rev 206272) +++ branches/safari-602-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2016-09-22 21:05:46 UTC (rev 206273) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig (206272 => 206273) --- branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig 2016-09-22 20:54:56 UTC (rev 206272) +++ branches/safari-602-branch/Source/WebCore/Configurations/Version.xcconfig 2016-09-22 21:05:46 UTC (rev 206273) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (206272 => 206273) --- branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-09-22 20:54:56 UTC (rev 206272) +++ branches/safari-602-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-09-22 21:05:46 UTC (rev 206273) @@ -1,6 +1,6 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig (206272 => 206273) --- branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2016-09-22 20:54:56 UTC (rev 206272) +++ branches/safari-602-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2016-09-22 21:05:46 UTC (rev 206273) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig (206272 => 206273) --- branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig 2016-09-22 20:54:56 UTC (rev 206272) +++ branches/safari-602-branch/Source/WebKit2/Configurations/Version.xcconfig 2016-09-22 21:05:46 UTC (rev 206273) @@ -23,7 +23,7 @@ MAJOR_VERSION = 602; MINOR_VERSION = 2; -TINY_VERSION = 12; +TINY_VERSION = 13; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206274] trunk/Source
Title: [206274] trunk/Source
Revision 206274
Author fpi...@apple.com
Date 2016-09-22 14:11:42 -0700 (Thu, 22 Sep 2016)
Log Message
Fences on x86 should be a lot cheaper
https://bugs.webkit.org/show_bug.cgi?id=162417
Reviewed by Mark Lam and Geoffrey Garen.
Source/_javascript_Core:
It turns out that:
lock; orl $0, (%rsp)
does everything that we wanted from:
mfence
And it's a lot faster. When I tried mfence for making object visiting concurrent-GC-TSO-
friendly, it was a 9% regression on Octane/splay. But when I tried ortop, it was neutral.
So, we should use ortop from now on.
This part of the change is for the JITs. MacroAssembler::memoryFence() appears to always
mean something like an acqrel fence, so it's safe to make this use ortop. Since B3's Fence
compiles to Air MemoryFence, which is just MacroAssembler::memoryFence(), this also changes
B3 codegen.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::memoryFence):
* assembler/X86Assembler.h:
(JSC::X86Assembler::lock):
* b3/testb3.cpp:
(JSC::B3::testX86MFence):
(JSC::B3::testX86CompilerFence):
Source/WTF:
It turns out that:
lock; orl $0, (%rsp)
does everything that we wanted from:
mfence
And it's a lot faster. When I tried mfence for making object visiting concurrent-GC-TSO-
friendly, it was a 9% regression on Octane/splay. But when I tried ortop, it was neutral.
So, we should use ortop from now on.
This part of the change just affects our Atomics. I also changed this in the JITs.
* wtf/Atomics.h:
(WTF::x86_ortop):
(WTF::storeLoadFence):
(WTF::x86_mfence): Deleted.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
trunk/Source/_javascript_Core/b3/testb3.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (206273 => 206274)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-22 21:05:46 UTC (rev 206273)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-22 21:11:42 UTC (rev 206274)
@@ -1,3 +1,35 @@
+2016-09-22 Filip Pizlo
+
+Fences on x86 should be a lot cheaper
+https://bugs.webkit.org/show_bug.cgi?id=162417
+
+Reviewed by Mark Lam and Geoffrey Garen.
+
+It turns out that:
+
+lock; orl $0, (%rsp)
+
+does everything that we wanted from:
+
+mfence
+
+And it's a lot faster. When I tried mfence for making object visiting concurrent-GC-TSO-
+friendly, it was a 9% regression on Octane/splay. But when I tried ortop, it was neutral.
+So, we should use ortop from now on.
+
+This part of the change is for the JITs. MacroAssembler::memoryFence() appears to always
+mean something like an acqrel fence, so it's safe to make this use ortop. Since B3's Fence
+compiles to Air MemoryFence, which is just MacroAssembler::memoryFence(), this also changes
+B3 codegen.
+
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::memoryFence):
+* assembler/X86Assembler.h:
+(JSC::X86Assembler::lock):
+* b3/testb3.cpp:
+(JSC::B3::testX86MFence):
+(JSC::B3::testX86CompilerFence):
+
2016-09-22 Joseph Pecoraro
test262: Function length should be number of parameters before parameters with default values
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (206273 => 206274)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2016-09-22 21:05:46 UTC (rev 206273)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h 2016-09-22 21:11:42 UTC (rev 206274)
@@ -2629,9 +2629,12 @@
m_assembler.nop();
}
+// We take memoryFence to mean acqrel. This has acqrel semantics on x86.
void memoryFence()
{
-m_assembler.mfence();
+// lock; orl $0, (%rsp)
+m_assembler.lock();
+m_assembler.orl_im(0, 0, X86Registers::esp);
}
static void replaceWithJump(CodeLocationLabel instructionStart, CodeLocationLabel destination)
Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (206273 => 206274)
--- trunk/Source/_javascript_Core/assembler/X86Assembler.h 2016-09-22 21:05:46 UTC (rev 206273)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h 2016-09-22 21:11:42 UTC (rev 206274)
@@ -249,6 +249,7 @@
OP_ESCAPE_DD= 0xDD,
OP_CALL_rel32 = 0xE8,
OP_JMP_rel32= 0xE9,
+PRE_LOCK= 0xF0,
PRE_SSE_F2 = 0xF2,
PRE_SSE_F3 = 0xF3,
OP_HLT = 0xF4,
@@ -2684,6 +2685,11 @@
m_form
[webkit-changes] [206275] trunk
Title: [206275] trunk
Revision 206275
Author dba...@webkit.org
Date 2016-09-22 14:22:32 -0700 (Thu, 22 Sep 2016)
Log Message
Remove more ENABLE(TEXT_AUTOSIZING) code
https://bugs.webkit.org/show_bug.cgi?id=162456
Reviewed by Simon Fraser.
.:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/WebCore:
* page/Settings.in:
* rendering/style/StyleVisualData.h:
(WebCore::StyleVisualData::operator==):
Source/WebKit2:
* UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebCore/rendering/style/StyleVisualData.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp
trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_settings.cpp
trunk/Source/cmake/tools/vsprops/FeatureDefines.props
trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props
Diff
Modified: trunk/ChangeLog (206274 => 206275)
--- trunk/ChangeLog 2016-09-22 21:11:42 UTC (rev 206274)
+++ trunk/ChangeLog 2016-09-22 21:22:32 UTC (rev 206275)
@@ -1,3 +1,13 @@
+2016-09-22 Daniel Bates
+
+Remove more ENABLE(TEXT_AUTOSIZING) code
+https://bugs.webkit.org/show_bug.cgi?id=162456
+
+Reviewed by Simon Fraser.
+
+* Source/cmake/tools/vsprops/FeatureDefines.props:
+* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
+
2016-09-20 Don Olmstead
[WinCairo] Use find_package cairo in build
Modified: trunk/Source/WebCore/ChangeLog (206274 => 206275)
--- trunk/Source/WebCore/ChangeLog 2016-09-22 21:11:42 UTC (rev 206274)
+++ trunk/Source/WebCore/ChangeLog 2016-09-22 21:22:32 UTC (rev 206275)
@@ -1,3 +1,14 @@
+2016-09-22 Daniel Bates
+
+Remove more ENABLE(TEXT_AUTOSIZING) code
+https://bugs.webkit.org/show_bug.cgi?id=162456
+
+Reviewed by Simon Fraser.
+
+* page/Settings.in:
+* rendering/style/StyleVisualData.h:
+(WebCore::StyleVisualData::operator==):
+
2016-09-22 Jer Noble
Fullscreen controls inoperative in WebKitLegacy web views
Modified: trunk/Source/WebCore/page/Settings.in (206274 => 206275)
--- trunk/Source/WebCore/page/Settings.in 2016-09-22 21:11:42 UTC (rev 206274)
+++ trunk/Source/WebCore/page/Settings.in 2016-09-22 21:22:32 UTC (rev 206275)
@@ -199,12 +199,8 @@
useLegacyBackgroundSizeShorthandBehavior initial=false
fixedBackgroundsPaintRelativeToDocument initial=defaultFixedBackgroundsPaintRelativeToDocument
-textAutosizingEnabled initial=false, setNeedsStyleRecalcInAllFrames=1, conditional=TEXT_AUTOSIZING
textAutosizingEnabled initial=defaultTextAutosizingEnabled(), setNeedsStyleRecalcInAllFrames=1, conditional=IOS_TEXT_AUTOSIZING
-
-textAutosizingWindowSizeOverride type=IntSize, setNeedsStyleRecalcInAllFrames=1, conditional=TEXT_AUTOSIZING
textAutosizingWindowSizeOverride type=IntSize, setNeedsStyleRecalcInAllFrames=1, conditional=IOS_TEXT_AUTOSIZING
-
minimumZoomFontSize type=float, initial=defaultMinimumZoomFontSize(), conditional=IOS_TEXT_AUTOSIZING
simpleLineLayoutEnabled initial=true, setNeedsStyleRecalcInAllFrames=1
Modified: trunk/Source/WebCore/rendering/style/StyleVisualData.h (206274 => 206275)
--- trunk/Source/WebCore/rendering/style/StyleVisualData.h 2016-09-22 21:11:42 UTC (rev 206274)
+++ trunk/Source/WebCore/rendering/style/StyleVisualData.h 2016-09-22 21:22:32 UTC (rev 206275)
@@ -43,9 +43,6 @@
return clip == o.clip
&& hasClip == o.hasClip
&& textDecoration == o.textDecoration
-#if ENABLE(TEXT_AUTOSIZING)
-&& m_textAutosizingMultiplier == o.m_textAutosizingMultiplier
-#endif
&& m_zoom == o.m_zoom;
}
bool operator!=(const StyleVisualData& o) const { return !(*this == o); }
Modified: trunk/Source/WebKit2/ChangeLog (206274 => 206275)
--- trunk/Source/WebKit2/ChangeLog 2016-09-22 21:11:42 UTC (rev 206274)
+++ trunk/Source/WebKit2/ChangeLog 2016-09-22 21:22:32 UTC (rev 206275)
@@ -1,3 +1,16 @@
+2016-09-22 Daniel Bates
+
+Remove more ENABLE(TEXT_AUTOSIZING) code
+https://bugs.webkit.org/show_bug.cgi?id=162456
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/efl/ewk_settings.cpp:
+(ewk_settings_text_autosizing_enabled_set):
+(ewk_settings_text_autosizing_enabled_get):
+* UIProcess/API/efl/tests/test_ewk2_settings.cpp:
+(TEST_F):
+
2016-09-22 Jonathan Bedard
Automatic Text Replacement Testing in WebKit2
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp (206274 => 206275)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2016-09-22 21:11:42 UTC (rev 206274)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_settings.cpp 2016-09-22 21:22:32 UTC (rev 206275)
@@ -302,29 +30
[webkit-changes] [206277] trunk
Title: [206277] trunk
Revision 206277
Author dba...@webkit.org
Date 2016-09-22 14:34:12 -0700 (Thu, 22 Sep 2016)
Log Message
[XSS Auditor] HTML5 entities can bypass XSS Auditor
https://bugs.webkit.org/show_bug.cgi?id=161939
Reviewed by David Kilzer.
Source/WebCore:
Merged from Blink:
Truncate a src-like URL at the first & character as it may mark the start of an HTML entity.
We will evaluate the effectiveness of this approach and adjust it if necessary if we see an
increase in false positives.
HTML5 defines more named character references, including named character references for common
punctuation characters. Characters following some punctuation characters may come from the page
itself. We truncate src-like strings at punctuation characters to avoid considering such page
content when performing a match.
Test: http/tests/security/xssAuditor/script-tag-with-source-data-url5.html
* html/parser/XSSAuditor.cpp:
(WebCore::truncateForSrcLikeAttribute):
LayoutTests:
* http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-source-data-url5.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/XSSAuditor.cpp
Added Paths
trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt
trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5.html
Diff
Modified: trunk/LayoutTests/ChangeLog (206276 => 206277)
--- trunk/LayoutTests/ChangeLog 2016-09-22 21:33:20 UTC (rev 206276)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 21:34:12 UTC (rev 206277)
@@ -1,5 +1,16 @@
2016-09-22 Daniel Bates
+[XSS Auditor] HTML5 entities can bypass XSS Auditor
+https://bugs.webkit.org/show_bug.cgi?id=161939
+
+
+Reviewed by David Kilzer.
+
+* http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt: Added.
+* http/tests/security/xssAuditor/script-tag-with-source-data-url5.html: Added.
+
+2016-09-22 Daniel Bates
+
[XSS Auditor] Truncate data URLs at quotes
https://bugs.webkit.org/show_bug.cgi?id=161937
Added: trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt (0 => 206277)
--- trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt 2016-09-22 21:34:12 UTC (rev 206277)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: line 3: The XSS Auditor refused to execute a script in 'http://localhost:8000/security/xssAuditor/resources/echo-property.pl?q=%22%3E%3Cscript%20src%3ddata:%26comma%3balert(1)%3b%22' because its source code was found within the request. The auditor was enabled because the server did not send an 'X-XSS-Protection' header.
+
Added: trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5.html (0 => 206277)
--- trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url5.html 2016-09-22 21:34:12 UTC (rev 206277)
@@ -0,0 +1,15 @@
+
+
+
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.setXSSAuditorEnabled(true);
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (206276 => 206277)
--- trunk/Source/WebCore/ChangeLog 2016-09-22 21:33:20 UTC (rev 206276)
+++ trunk/Source/WebCore/ChangeLog 2016-09-22 21:34:12 UTC (rev 206277)
@@ -1,5 +1,30 @@
2016-09-22 Daniel Bates
+[XSS Auditor] HTML5 entities can bypass XSS Auditor
+https://bugs.webkit.org/show_bug.cgi?id=161939
+
+
+Reviewed by David Kilzer.
+
+Merged from Blink:
+
+
+Truncate a src-like URL at the first & character as it may mark the start of an HTML entity.
+We will evaluate the effectiveness of this approach and adjust it if necessary if we see an
+increase in false positives.
+
+HTML5 defines more named character references, including named character references for common
+punctuation characters. Characters following some punctuation characters may come from the page
+itself. We truncate src-like strings at punctuation characters to avoid considering such page
+content when performing a match.
+
+Test: http/tests/security/xssAuditor/script-tag-with-source-data-url5.html
+
+* html/parser/XSSAuditor.cpp:
+(WebCore::truncateForSrcLikeAttribute):
+
+2016-09-22 Daniel Bates
+
[XSS Auditor] Truncate data URLs at quotes
https://bugs.webkit.org/show_bug.cgi?id=161937
Modified: trunk/Source/WebCore/html/parser/XSSAuditor.cpp (206276 => 206277)
--- trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2016-09-22 21:33:20
[webkit-changes] [206278] trunk
Title: [206278] trunk Revision 206278 Author dba...@webkit.org Date 2016-09-22 14:39:29 -0700 (Thu, 22 Sep 2016) Log Message [CSP] Violation report may be sent to wrong domain on frame-ancestors violation https://bugs.webkit.org/show_bug.cgi?id=162079 Reviewed by Andy Estes. Source/WebCore: Fixes an issue where a CSP violation report may be sent to the wrong domain when the frame-ancestors directive is violated. In particular, when the frame-ancestors directive is violated for a page that specifies a report URI that is a relative URL then the report URI would be resolved with respect to the parent frame's document URL and hence be sent to the domain of the parent frame's document. * page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::reportViolation): Adjust the report URL with respect to the blocked URL when we do not have a script execution context. LayoutTests: Modified http/tests/security/contentSecurityPolicy/resources/save-report.php to print the HTTP Host header as a means to validate that the CSP violation report was sent to the appropriate host. Update test expectations. Note that the presence of "localhost" in the HTTP Host header in the test results for tests security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin.html and security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https.html verify that we resolve a relative URL CSP report URI with respect to the blocked URL. * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https.html: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin.html: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-https-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-https.html: * http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin.html: * http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/script-blocked-sends-multiple-reports-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-enforced-policy-and-blocked-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-enforced-policy-and-blocked-by-report-policy2-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-enforced-policy-and-allowed-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-allowed-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-enforced-policy-and-allowed-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-allowed-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt: * http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt: * http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: * http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: * http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: * http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: * http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: * http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt: * http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt: * http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled-expected.txt: * http/tests/security/contentSecurityPolicy/report-onl
[webkit-changes] [206276] trunk
Title: [206276] trunk
Revision 206276
Author dba...@webkit.org
Date 2016-09-22 14:33:20 -0700 (Thu, 22 Sep 2016)
Log Message
[XSS Auditor] Truncate data URLs at quotes
https://bugs.webkit.org/show_bug.cgi?id=161937
Reviewed by David Kilzer.
Source/WebCore:
Merged from Blink:
Truncate a data URL at the first single or double quote character to avoid considering
characters that may come from the page content following an injected data URL.
Test: http/tests/security/xssAuditor/script-tag-with-source-data-url4.html
* html/parser/XSSAuditor.cpp:
(WebCore::truncateForSrcLikeAttribute):
LayoutTests:
* http/tests/security/xssAuditor/resources/echo-property.pl:
* http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-source-data-url4.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-property.pl
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/parser/XSSAuditor.cpp
Added Paths
trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt
trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4.html
Diff
Modified: trunk/LayoutTests/ChangeLog (206275 => 206276)
--- trunk/LayoutTests/ChangeLog 2016-09-22 21:22:32 UTC (rev 206275)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 21:33:20 UTC (rev 206276)
@@ -1,3 +1,14 @@
+2016-09-22 Daniel Bates
+
+[XSS Auditor] Truncate data URLs at quotes
+https://bugs.webkit.org/show_bug.cgi?id=161937
+
+Reviewed by David Kilzer.
+
+* http/tests/security/xssAuditor/resources/echo-property.pl:
+* http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt: Added.
+* http/tests/security/xssAuditor/script-tag-with-source-data-url4.html: Added.
+
2016-09-22 Ryan Haddad
Marking imported/w3c/web-platform-tests/media-source/mediasource-duration.html as flaky on mac.
Modified: trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-property.pl (206275 => 206276)
--- trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-property.pl 2016-09-22 21:22:32 UTC (rev 206275)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-property.pl 2016-09-22 21:33:20 UTC (rev 206276)
@@ -14,5 +14,6 @@
print $cgi->param('clutter');
}
print "\">\n";
+print "var y = 123;";
print "\n";
print "\n";
Added: trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt (0 => 206276)
--- trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt 2016-09-22 21:33:20 UTC (rev 206276)
@@ -0,0 +1,2 @@
+CONSOLE MESSAGE: line 3: The XSS Auditor refused to execute a script in 'http://localhost:8000/security/xssAuditor/resources/echo-property.pl?q=%22%3E%3Cscript%20src%3ddata:,alert(1)%3bhey%%22' because its source code was found within the request. The auditor was enabled because the server did not send an 'X-XSS-Protection' header.
+
Added: trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4.html (0 => 206276)
--- trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4.html (rev 0)
+++ trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-data-url4.html 2016-09-22 21:33:20 UTC (rev 206276)
@@ -0,0 +1,15 @@
+
+
+
+
+if (window.testRunner) {
+ testRunner.dumpAsText();
+ testRunner.setXSSAuditorEnabled(true);
+}
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (206275 => 206276)
--- trunk/Source/WebCore/ChangeLog 2016-09-22 21:22:32 UTC (rev 206275)
+++ trunk/Source/WebCore/ChangeLog 2016-09-22 21:33:20 UTC (rev 206276)
@@ -1,5 +1,23 @@
2016-09-22 Daniel Bates
+[XSS Auditor] Truncate data URLs at quotes
+https://bugs.webkit.org/show_bug.cgi?id=161937
+
+Reviewed by David Kilzer.
+
+Merged from Blink:
+
+
+Truncate a data URL at the first single or double quote character to avoid considering
+characters that may come from the page content following an injected data URL.
+
+Test: http/tests/security/xssAuditor/script-tag-with-source-data-url4.html
+
+* html/parser/XSSAuditor.cpp:
+(WebCore::truncateForSrcLikeAttribute):
+
+2016-09-22 Daniel Bates
+
Remove more ENABLE(TEXT_AUTOSIZING) code
https://bugs.webkit.org/show_bug.cgi?id=162456
Modified: trunk/Source/WebCore/html/parser/XSSAuditor.cpp (206275 => 206276)
--- trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2016-09-22 21:22:32 UTC (rev 206275)
+++ trunk/Source/WebCore/html/parser/XSSAuditor.cpp 2016-09-22 21:33:20 UTC (rev 206276)
@@ -178,11 +178,14 @@
{
// In HTTP URLs, characters follow
[webkit-changes] [206279] trunk/Source/WebCore
Title: [206279] trunk/Source/WebCore
Revision 206279
Author za...@apple.com
Date 2016-09-22 14:56:02 -0700 (Thu, 22 Sep 2016)
Log Message
ShowRenderTree: Shuffle letters to have better readability.
https://bugs.webkit.org/show_bug.cgi?id=162460
Reviewed by Simon Fraser.
old: (B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle.
new: (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout.
Not testable.
* rendering/RenderObject.cpp:
(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRenderObject):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (206278 => 206279)
--- trunk/Source/WebCore/ChangeLog 2016-09-22 21:39:29 UTC (rev 206278)
+++ trunk/Source/WebCore/ChangeLog 2016-09-22 21:56:02 UTC (rev 206279)
@@ -1,3 +1,18 @@
+2016-09-22 Zalan Bujtas
+
+ShowRenderTree: Shuffle letters to have better readability.
+https://bugs.webkit.org/show_bug.cgi?id=162460
+
+Reviewed by Simon Fraser.
+old: (B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle.
+new: (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout.
+
+Not testable.
+
+* rendering/RenderObject.cpp:
+(WebCore::showRenderTreeLegend):
+(WebCore::RenderObject::showRenderObject):
+
2016-09-22 Daniel Bates
[CSP] Violation report may be sent to wrong domain on frame-ancestors violation
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (206278 => 206279)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2016-09-22 21:39:29 UTC (rev 206278)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2016-09-22 21:56:02 UTC (rev 206279)
@@ -947,7 +947,7 @@
static void showRenderTreeLegend()
{
-fprintf(stderr, "\n(B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle\n");
+fprintf(stderr, "\n(B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout\n");
}
void RenderObject::showNodeTreeForThis() const
@@ -1026,10 +1026,10 @@
if (isRelPositioned())
fputc('R', stderr);
else if (isStickyPositioned())
-fputc('Y', stderr);
+fputc('K', stderr);
else if (isOutOfFlowPositioned()) {
if (style().position() == AbsolutePosition)
-fputc('B', stderr);
+fputc('A', stderr);
else
fputc('X', stderr);
}
@@ -1036,6 +1036,11 @@
} else
fputc('-', stderr);
+if (isFloating())
+fputc('F', stderr);
+else
+fputc('-', stderr);
+
if (hasOverflowClip())
fputc('O', stderr);
else
@@ -1042,7 +1047,7 @@
fputc('-', stderr);
if (isAnonymous())
-fputc('A', stderr);
+fputc('Y', stderr);
else
fputc('-', stderr);
@@ -1051,11 +1056,6 @@
else
fputc('-', stderr);
-if (isFloating())
-fputc('F', stderr);
-else
-fputc('-', stderr);
-
if (hasLayer())
fputc('L', stderr);
else
@@ -1068,13 +1068,13 @@
fputc(' ', stderr);
-if (needsLayout())
-fputc('D', stderr);
+if (node() && node()->needsStyleRecalc())
+fputc('+', stderr);
else
fputc('-', stderr);
-if (node() && node()->needsStyleRecalc())
-fputc('S', stderr);
+if (needsLayout())
+fputc('+', stderr);
else
fputc('-', stderr);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206280] trunk
Title: [206280] trunk
Revision 206280
Author beid...@apple.com
Date 2016-09-22 15:34:02 -0700 (Thu, 22 Sep 2016)
Log Message
IDBIndex.openCursor() matches indices on multiple object stores.
and https://bugs.webkit.org/show_bug.cgi?id=158833
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html
storage/indexeddb/modern/multiple-objectstore-index-cursor-collision.html
* Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::buildIndexStatement): Need to include the object store id in the statement for
index cursors, otherwise there will be collisions amongst multiple object stores that happen to
share primary keys.
(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
LayoutTests:
* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt: Added.
* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt: Added.
* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html: Added.
* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision.html: Added.
* storage/indexeddb/modern/resources/multiple-objectstore-index-cursor-collision.js: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp
Added Paths
trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html
trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision.html
trunk/LayoutTests/storage/indexeddb/modern/resources/multiple-objectstore-index-cursor-collision.js
Diff
Modified: trunk/LayoutTests/ChangeLog (206279 => 206280)
--- trunk/LayoutTests/ChangeLog 2016-09-22 21:56:02 UTC (rev 206279)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 22:34:02 UTC (rev 206280)
@@ -1,3 +1,16 @@
+2016-09-22 Brady Eidson
+
+IDBIndex.openCursor() matches indices on multiple object stores.
+ and https://bugs.webkit.org/show_bug.cgi?id=158833
+
+Reviewed by Alex Christensen.
+
+* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt: Added.
+* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt: Added.
+* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html: Added.
+* storage/indexeddb/modern/multiple-objectstore-index-cursor-collision.html: Added.
+* storage/indexeddb/modern/resources/multiple-objectstore-index-cursor-collision.js: Added.
+
2016-09-22 Daniel Bates
[CSP] Violation report may be sent to wrong domain on frame-ancestors violation
Added: trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt (0 => 206280)
--- trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt 2016-09-22 22:34:02 UTC (rev 206280)
@@ -0,0 +1,21 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+db deleted
+Creating db
+Enumerating ObjectStore 'schools' by primary key
+key: 1, primaryKey: 1, value: {"name":"Stockholm University","city":"Stockholm","id":1}
+key: 2, primaryKey: 2, value: {"name":"Uppsala University","city":"Uppsala","id":2}
+key: 3, primaryKey: 3, value: {"name":"Chalmers","city":"Gothenburg","id":3}
+Enumerating index 'city' on 'schools'
+key: Gothenburg, primaryKey: 3, value: {"name":"Chalmers","city":"Gothenburg","id":3}
+key: Stockholm, primaryKey: 1, value: {"name":"Stockholm University","city":"Stockholm","id":1}
+key: Uppsala, primaryKey: 2, value: {"name":"Uppsala University","city":"Uppsala","id":2}
+Enumerating ObjectStore 'students' by primary key
+key: 1, primaryKey: 1, value: {"name":"Adam Anderson","id":1}
+key: 2, primaryKey: 2, value: {"name":"Bertil Bengtson","id":2}
+Enumerating index 'name' on 'students'
+key: Adam Anderson, primaryKey: 1, value: {"name":"Adam Anderson","id":1}
+key: Bertil Bengtson, primaryKey: 2, value: {"name":"Bertil Bengtson","id":2}
+Done.
+
Added: trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt (0 => 206280)
--- trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt (rev 0)
+++ trunk/LayoutTests/storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt 2016-09-22 22:34:02 UTC (rev 206280)
@@ -0,0 +1,21 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+db deleted
+Creating db
+Enumera
[webkit-changes] [206281] trunk
Title: [206281] trunk
Revision 206281
Author mark@apple.com
Date 2016-09-22 16:41:56 -0700 (Thu, 22 Sep 2016)
Log Message
Array.prototype.join should do overflow checks on string joins.
https://bugs.webkit.org/show_bug.cgi?id=162459
Reviewed by Saam Barati.
JSTests:
* stress/array-join-on-strings-need-overflow-checks.js: Added.
(assert):
(catch):
Source/_javascript_Core:
Change the 2 JSRopeString::create() functions that do joins to be private, and
force all clients of it to go through the jsString() utility functions that do
overflow checks before creating the ropes.
* dfg/DFGOperations.cpp:
* runtime/ArrayPrototype.cpp:
(JSC::slowJoin):
* runtime/JSString.h:
* runtime/Operations.h:
(JSC::jsString):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGOperations.cpp
trunk/Source/_javascript_Core/runtime/ArrayPrototype.cpp
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/Operations.h
Added Paths
trunk/JSTests/stress/array-join-on-strings-need-overflow-checks.js
Diff
Modified: trunk/JSTests/ChangeLog (206280 => 206281)
--- trunk/JSTests/ChangeLog 2016-09-22 22:34:02 UTC (rev 206280)
+++ trunk/JSTests/ChangeLog 2016-09-22 23:41:56 UTC (rev 206281)
@@ -1,3 +1,14 @@
+2016-09-22 Mark Lam
+
+Array.prototype.join should do overflow checks on string joins.
+https://bugs.webkit.org/show_bug.cgi?id=162459
+
+Reviewed by Saam Barati.
+
+* stress/array-join-on-strings-need-overflow-checks.js: Added.
+(assert):
+(catch):
+
2016-09-22 Joseph Pecoraro
test262: Function length should be number of parameters before parameters with default values
Added: trunk/JSTests/stress/array-join-on-strings-need-overflow-checks.js (0 => 206281)
--- trunk/JSTests/stress/array-join-on-strings-need-overflow-checks.js (rev 0)
+++ trunk/JSTests/stress/array-join-on-strings-need-overflow-checks.js 2016-09-22 23:41:56 UTC (rev 206281)
@@ -0,0 +1,33 @@
+function assert(x, y) {
+if (x != y)
+throw(" Expect: " + y + ", actual: " + x);
+}
+
+s1 = "";
+for (var k = 0; k < 2000; ++k)
+s1 += "z";
+var expectedLength = 2000;
+assert(s1.length, 2000);
+
+s2 = 'x';
+expectedLength = 1;
+assert(s2.length, expectedLength);
+
+for (var i = 0; i < 22; ++i) {
+expectedLength += expectedLength;
+s2 += s2;
+assert(s2.length, expectedLength);
+}
+
+var caughtException;
+try {
+expectedLength = ((s1.length - 1) * s2.length) + 1;
+result = Array.prototype.join.apply(s1, [s2]);
+assert(result.length, expectedLength);
+} catch (e) {
+caughtException = e;
+}
+
+if (!caughtException)
+throw("Array.prototype.join should have thrown an exception when string length overflows");
+assert(caughtException, "Error: Out of memory");
Modified: trunk/Source/_javascript_Core/ChangeLog (206280 => 206281)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-22 22:34:02 UTC (rev 206280)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-22 23:41:56 UTC (rev 206281)
@@ -1,3 +1,21 @@
+2016-09-22 Mark Lam
+
+Array.prototype.join should do overflow checks on string joins.
+https://bugs.webkit.org/show_bug.cgi?id=162459
+
+Reviewed by Saam Barati.
+
+Change the 2 JSRopeString::create() functions that do joins to be private, and
+force all clients of it to go through the jsString() utility functions that do
+overflow checks before creating the ropes.
+
+* dfg/DFGOperations.cpp:
+* runtime/ArrayPrototype.cpp:
+(JSC::slowJoin):
+* runtime/JSString.h:
+* runtime/Operations.h:
+(JSC::jsString):
+
2016-09-22 Filip Pizlo
Fences on x86 should be a lot cheaper
Modified: trunk/Source/_javascript_Core/dfg/DFGOperations.cpp (206280 => 206281)
--- trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2016-09-22 22:34:02 UTC (rev 206280)
+++ trunk/Source/_javascript_Core/dfg/DFGOperations.cpp 2016-09-22 23:41:56 UTC (rev 206281)
@@ -52,6 +52,7 @@
#include "JSMap.h"
#include "JSSet.h"
#include "ObjectConstructor.h"
+#include "Operations.h"
#include "RegExpObject.h"
#include "Repatch.h"
#include "ScopedArguments.h"
@@ -1500,14 +1501,8 @@
{
VM& vm = exec->vm();
NativeCallFrameTracer tracer(&vm, exec);
-auto scope = DECLARE_THROW_SCOPE(vm);
-if (sumOverflows(left->length(), right->length())) {
-throwOutOfMemoryError(exec, scope);
-return nullptr;
-}
-
-return JSRopeString::create(vm, left, right);
+return jsString(exec, left, right);
}
JSCell* JIT_OPERATION operationMakeRope3(ExecState* exec, JSString* a, JSString* b, JSString* c)
@@ -1514,14 +1509,8 @@
{
VM& vm = exec->vm();
NativeCallFrameTracer tracer(&vm, exec);
-auto scope = DECLARE_THROW_SCOPE(vm);
-if (sumOverflows(a->length(), b->length(), c->length())) {
-throwOutOfMemoryErr
[webkit-changes] [206282] trunk
Title: [206282] trunk
Revision 206282
Author commit-qu...@webkit.org
Date 2016-09-22 16:53:33 -0700 (Thu, 22 Sep 2016)
Log Message
Add long press selection test
https://bugs.webkit.org/show_bug.cgi?id=162367
Patch by Megan Gardner on 2016-09-22
Reviewed by Simon Fraser.
Tools:
Add support to UIScriptController to synthesize long press events on iOS.
This required adding long-press functionality to HIDEventGenerator.
HIDEventGenerator sends the touchDown, but must then send the touchUp with
a dispatch_after (rather than sleeping, as we do for other events) in order
for the gesture recognizers to correctly detect a long press.
Use the long press synthesis in a test that detects whether a long press
gesture triggers text selection.
Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
were nanoseconds and typedefed to long without regard to the type
differences. Redid constants to be the right value, and converted upon use.
Cleaned up unused enum types.
* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::longPressAtPoint):
(WTR::UIScriptController::forcePressAtPoint):
(WTR::UIScriptController::dragFromPointToPoint): Deleted.
* Scripts/webkitpy/common/config/contributors.json:
* TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::longPressAtPoint):
(WTR::UIScriptController::forcePressAtPoint):
(WTR::UIScriptController::dragFromPointToPoint): Deleted.
* TestRunnerShared/UIScriptContext/UIScriptController.h:
* WebKitTestRunner/ios/HIDEventGenerator.h:
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator clearTap:]):
(-[HIDEventGenerator longPressTimerCall:]):
(-[HIDEventGenerator longPressFinish:completionBlock:]):
(-[HIDEventGenerator longPress:completionBlock:]):
(-[HIDEventGenerator forcePress:completionBlock:]):
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::longPressAtPoint):
(WTR::UIScriptController::forcePressAtPoint):
(WTR::UIScriptController::dragFromPointToPoint): Deleted.
LayoutTests:
Added test for long press selection.
* fast/events/touch/ios/long-press-to-select-text-expected.txt: Added.
* fast/events/touch/ios/long-press-to-select-text.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/ios/UIScriptControllerIOS.mm
trunk/Tools/TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.cpp
trunk/Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.h
trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm
trunk/Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Added Paths
trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text-expected.txt
trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text.html
Diff
Modified: trunk/LayoutTests/ChangeLog (206281 => 206282)
--- trunk/LayoutTests/ChangeLog 2016-09-22 23:41:56 UTC (rev 206281)
+++ trunk/LayoutTests/ChangeLog 2016-09-22 23:53:33 UTC (rev 206282)
@@ -1,3 +1,15 @@
+2016-09-22 Megan Gardner
+
+Add long press selection test
+https://bugs.webkit.org/show_bug.cgi?id=162367
+
+Reviewed by Simon Fraser.
+
+Added test for long press selection.
+
+* fast/events/touch/ios/long-press-to-select-text-expected.txt: Added.
+* fast/events/touch/ios/long-press-to-select-text.html: Added.
+
2016-09-22 Brady Eidson
IDBIndex.openCursor() matches indices on multiple object stores.
Added: trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text-expected.txt (0 => 206282)
--- trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text-expected.txt 2016-09-22 23:53:33 UTC (rev 206282)
@@ -0,0 +1,2 @@
+PASS: successfully selected the word PressMe
+Done
Added: trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text.html (0 => 206282)
--- trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text.html (rev 0)
+++ trunk/LayoutTests/fast/events/touch/ios/long-press-to-select-text.html 2016-09-22 23:53:33 UTC (rev 206282)
@@ -0,0 +1,63 @@
+
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function getUIScript()
+{
+return `
+(function() {
+uiController.longPressAtPoint(30, 20, function() {
+uiController.uiScriptComplete("Done");
+});
+})();`
+}
+
+function runTest()
+{
+if (!testRunner
[webkit-changes] [206283] trunk/Tools
Title: [206283] trunk/Tools
Revision 206283
Author matthew_han...@apple.com
Date 2016-09-22 18:14:59 -0700 (Thu, 22 Sep 2016)
Log Message
Add an API for getting the branch identifier from a Git or SVN checkout.
https://bugs.webkit.org/show_bug.cgi?id=151570
rdar://problem/17959831
Reviewed by David Kilzer.
This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
the name of the tag, or the name of the branch, as appropriate. This function is necessary for
a VCSUtils client that is not checked in to the WebKit project.
This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
- pathRelativeToSVNRepositoryRootForPath
- svnInfoForPath
- svnURLForPath
- svnRepositoryRootForPath
This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
of SCM.
* Scripts/VCSUtils.pm:
(svnInfoForPath):
Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
Make code safe to use for a path, and not just for the CWD.
(svnURLForPath):
Calls svnInfoForPath and extracts the URL.
(svnRepositoryRootForPath):
Calls svnInfoForPath and extracts the Repository Root.
(svnIdentifierForPath):
Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
(pathRelativeToSVNRepositoryRootForPath):
Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
determining both values.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/VCSUtils.pm
Diff
Modified: trunk/Tools/ChangeLog (206282 => 206283)
--- trunk/Tools/ChangeLog 2016-09-22 23:53:33 UTC (rev 206282)
+++ trunk/Tools/ChangeLog 2016-09-23 01:14:59 UTC (rev 206283)
@@ -1,3 +1,43 @@
+2016-09-22 Matthew Hanson
+
+Add an API for getting the branch identifier from a Git or SVN checkout.
+https://bugs.webkit.org/show_bug.cgi?id=151570
+rdar://problem/17959831
+
+Reviewed by David Kilzer.
+
+This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
+the name of the tag, or the name of the branch, as appropriate. This function is necessary for
+a VCSUtils client that is not checked in to the WebKit project.
+
+This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
+- pathRelativeToSVNRepositoryRootForPath
+- svnInfoForPath
+- svnURLForPath
+- svnRepositoryRootForPath
+
+This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
+allows clients of VCSUtils to extract what arbitrary information from the `svn info` command regardless
+of SCM.
+
+* Scripts/VCSUtils.pm:
+(svnInfoForPath):
+Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
+Make code safe to use for a path, and not just for the CWD.
+
+(svnURLForPath):
+Calls svnInfoForPath and extracts the URL.
+
+(svnRepositoryRootForPath):
+Calls svnInfoForPath and extracts the Repository Root.
+
+(svnIdentifierForPath):
+Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
+
+(pathRelativeToSVNRepositoryRootForPath):
+Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
+determining both values.
+
2016-09-22 Megan Gardner
Add long press selection test
Modified: trunk/Tools/Scripts/VCSUtils.pm (206282 => 206283)
--- trunk/Tools/Scripts/VCSUtils.pm 2016-09-22 23:53:33 UTC (rev 206282)
+++ trunk/Tools/Scripts/VCSUtils.pm 2016-09-23 01:14:59 UTC (rev 206283)
@@ -87,8 +87,12 @@
&scmMoveOrRenameFile
&scmToggleExecutableBit
&setChangeLogDateAndReviewer
+&svnIdentifierForPath
+&svnInfoForPath
+&svnRepositoryRootForPath
&svnRevisionForDirectory
&svnStatus
+&svnURLForPath
&toWindowsLineEndings
&gitCommitForSVNRevision
&listOfChangedFilesBetweenRevisions
@@ -444,33 +448,64 @@
return $revision;
}
-sub pathRelativeToSVNRepositoryRootForPath($)
+sub svnInfoForPath($)
{
my ($file) = @_;
my $relativePath = File::Spec->abs2rel($file);
my $svnInfo;
-if (isSVN()) {
+if (isSVNDirectory($file)) {
my $escapedRelativePath = escapeSubversionPath($relativePath);
my $command = "svn info $escapedRelativePath";
$command = "LC_ALL=C $command" if !isWindows();
$svnInfo = `$command`;
-} elsif (isGit()) {
-my $command = "git svn info $relativePath";
+} elsif (isGitDirectory($file)) {
+my $command = "git svn info";
$command = "LC_ALL=C $command" if !isWindows();
-$svnInfo = `$command`;
+$svnInfo = `cd $relativePat
[webkit-changes] [206284] trunk/Source/JavaScriptCore
Title: [206284] trunk/Source/_javascript_Core
Revision 206284
Author mark@apple.com
Date 2016-09-22 18:15:53 -0700 (Thu, 22 Sep 2016)
Log Message
Removed unused hasErrorInfo().
https://bugs.webkit.org/show_bug.cgi?id=162473
Reviewed by Saam Barati.
* _javascript_Core.order:
* runtime/Error.cpp:
(JSC::hasErrorInfo): Deleted.
* runtime/Error.h:
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.order
trunk/Source/_javascript_Core/runtime/Error.cpp
trunk/Source/_javascript_Core/runtime/Error.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (206283 => 206284)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-23 01:15:53 UTC (rev 206284)
@@ -1,5 +1,17 @@
2016-09-22 Mark Lam
+Removed unused hasErrorInfo().
+https://bugs.webkit.org/show_bug.cgi?id=162473
+
+Reviewed by Saam Barati.
+
+* _javascript_Core.order:
+* runtime/Error.cpp:
+(JSC::hasErrorInfo): Deleted.
+* runtime/Error.h:
+
+2016-09-22 Mark Lam
+
Array.prototype.join should do overflow checks on string joins.
https://bugs.webkit.org/show_bug.cgi?id=162459
Modified: trunk/Source/_javascript_Core/_javascript_Core.order (206283 => 206284)
--- trunk/Source/_javascript_Core/_javascript_Core.order 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/_javascript_Core/_javascript_Core.order 2016-09-23 01:15:53 UTC (rev 206284)
@@ -1761,7 +1761,6 @@
_cti_vm_throw
__ZN3JSC8jitThrowEPNS_2VMEPNS_9ExecStateENS_7JSValueENS_16ReturnAddressPtrE
__ZN3JSC11Interpreter14throwExceptionERPNS_9ExecStateERNS_7JSValueEj
-__ZN3JSC12hasErrorInfoEPNS_9ExecStateEPNS_8JSObjectE
__ZN3JSC9CodeBlock27lineNumberForBytecodeOffsetEj
__ZN3JSC17UnlinkedCodeBlock27lineNumberForBytecodeOffsetEj
__ZN3JSC12addErrorInfoEPNS_9ExecStateEPNS_8JSObjectEiRKNS_10SourceCodeE
Modified: trunk/Source/_javascript_Core/runtime/Error.cpp (206283 => 206284)
--- trunk/Source/_javascript_Core/runtime/Error.cpp 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/_javascript_Core/runtime/Error.cpp 2016-09-23 01:15:53 UTC (rev 206284)
@@ -193,13 +193,6 @@
return error;
}
-
-bool hasErrorInfo(ExecState* exec, JSObject* error)
-{
-return error->hasProperty(exec, Identifier::fromString(exec, linePropertyName))
-|| error->hasProperty(exec, Identifier::fromString(exec, sourceURLPropertyName));
-}
-
JSObject* throwConstructorCannotBeCalledAsFunctionTypeError(ExecState* exec, ThrowScope& scope, const char* constructorName)
{
return throwTypeError(exec, scope, makeString("calling ", constructorName, " constructor without new is invalid"));
Modified: trunk/Source/_javascript_Core/runtime/Error.h (206283 => 206284)
--- trunk/Source/_javascript_Core/runtime/Error.h 2016-09-23 01:14:59 UTC (rev 206283)
+++ trunk/Source/_javascript_Core/runtime/Error.h 2016-09-23 01:15:53 UTC (rev 206284)
@@ -64,7 +64,6 @@
bool addErrorInfoAndGetBytecodeOffset(ExecState*, VM&, JSObject*, bool, CallFrame*&, unsigned* = nullptr);
-bool hasErrorInfo(ExecState*, JSObject* error);
JS_EXPORT_PRIVATE void addErrorInfo(ExecState*, JSObject*, bool);
JSObject* addErrorInfo(ExecState*, JSObject* error, int line, const SourceCode&);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206285] trunk
Title: [206285] trunk Revision 206285 Author cdu...@apple.com Date 2016-09-22 18:54:05 -0700 (Thu, 22 Sep 2016) Log Message [ShadowDOM] Add support for Node.getRootNode(options) https://bugs.webkit.org/show_bug.cgi?id=162457 Reviewed by Ryosuke Niwa. LayoutTests/imported/w3c: Rebaseline existing W3C DOM tests now that more checks are passing. * web-platform-tests/dom/interfaces-expected.txt: * web-platform-tests/dom/nodes/rootNode-expected.txt: Source/WebCore: Add support for Node.getRootNode(options): - https://dom.spec.whatwg.org/#dom-node-getrootnode No new tests, rebaselined existing tests. * dom/EventPath.cpp: (WebCore::RelatedNodeRetargeter::RelatedNodeRetargeter): (WebCore::RelatedNodeRetargeter::checkConsistency): * dom/Node.cpp: (WebCore::Node::rootNode): (WebCore::Node::shadowIncludingRoot): (WebCore::Node::getRootNode): * dom/Node.h: * dom/Node.idl: * editing/Editor.cpp: (WebCore::correctSpellcheckingPreservingTextCheckingParagraph): * xml/XPathPath.cpp: (WebCore::XPath::LocationPath::evaluate): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/rootNode-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/EventPath.cpp trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/dom/Node.idl trunk/Source/WebCore/editing/Editor.cpp trunk/Source/WebCore/xml/XPathPath.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206284 => 206285) --- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-23 01:15:53 UTC (rev 206284) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-23 01:54:05 UTC (rev 206285) @@ -1,5 +1,17 @@ 2016-09-22 Chris Dumez +[ShadowDOM] Add support for Node.getRootNode(options) +https://bugs.webkit.org/show_bug.cgi?id=162457 + +Reviewed by Ryosuke Niwa. + +Rebaseline existing W3C DOM tests now that more checks are passing. + +* web-platform-tests/dom/interfaces-expected.txt: +* web-platform-tests/dom/nodes/rootNode-expected.txt: + +2016-09-22 Chris Dumez + Fix serialization of HTML void elements when they have children https://bugs.webkit.org/show_bug.cgi?id=162418 Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt (206284 => 206285) --- trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-09-23 01:15:53 UTC (rev 206284) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt 2016-09-23 01:54:05 UTC (rev 206285) @@ -192,7 +192,7 @@ PASS Node interface: attribute baseURI PASS Node interface: attribute isConnected PASS Node interface: attribute ownerDocument -FAIL Node interface: operation getRootNode(GetRootNodeOptions) assert_own_property: interface prototype object missing non-static operation expected property "getRootNode" missing +PASS Node interface: operation getRootNode(GetRootNodeOptions) PASS Node interface: attribute parentNode PASS Node interface: attribute parentElement PASS Node interface: operation hasChildNodes() @@ -349,8 +349,8 @@ PASS Node interface: new Document() must inherit property "baseURI" with the proper type (14) PASS Node interface: new Document() must inherit property "isConnected" with the proper type (15) PASS Node interface: new Document() must inherit property "ownerDocument" with the proper type (16) -FAIL Node interface: new Document() must inherit property "getRootNode" with the proper type (17) assert_inherits: property "getRootNode" not found in prototype chain -FAIL Node interface: calling getRootNode(GetRootNodeOptions) on new Document() with too few arguments must throw TypeError assert_inherits: property "getRootNode" not found in prototype chain +PASS Node interface: new Document() must inherit property "getRootNode" with the proper type (17) +PASS Node interface: calling getRootNode(GetRootNodeOptions) on new Document() with too few arguments must throw TypeError PASS Node interface: new Document() must inherit property "parentNode" with the proper type (18) PASS Node interface: new Document() must inherit property "parentElement" with the proper type (19) PASS Node interface: new Document() must inherit property "hasChildNodes" with the proper type (20) @@ -481,8 +481,8 @@ PASS Node interface: xmlDoc must inherit property "baseURI" with the proper type (14) PASS Node interface: xmlDoc must inherit property "isConnected" with the proper type (15) PASS Node interface: xmlDoc must inherit property "ownerDocument" with the proper type (16) -FAIL Node interface: xmlDoc must inherit property "getRootNode" with the proper type (17) assert_inherits: property "getRootNode" not found in prototype chain -FAIL Node interface: calling getRootNode(GetRootNodeOptions) on xmlDoc with too few arguments must throw TypeError assert_inherits:
[webkit-changes] [206286] branches/safari-602-branch
Title: [206286] branches/safari-602-branch Revision 206286 Author bshaf...@apple.com Date 2016-09-22 19:10:48 -0700 (Thu, 22 Sep 2016) Log Message Merge r206033. rdar://problem/28086237 Modified Paths branches/safari-602-branch/Source/WebKit2/ChangeLog branches/safari-602-branch/Source/WebKit2/Shared/NativeWebKeyboardEvent.h branches/safari-602-branch/Source/WebKit2/Shared/mac/NativeWebKeyboardEventMac.mm branches/safari-602-branch/Source/WebKit2/Shared/mac/WebEventFactory.h branches/safari-602-branch/Source/WebKit2/Shared/mac/WebEventFactory.mm branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm branches/safari-602-branch/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h branches/safari-602-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm branches/safari-602-branch/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h branches/safari-602-branch/Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm branches/safari-602-branch/Source/WebKit2/UIProcess/WebPageProxy.cpp branches/safari-602-branch/Source/WebKit2/UIProcess/WebPageProxy.h branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.cpp branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.h branches/safari-602-branch/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in branches/safari-602-branch/Tools/ChangeLog branches/safari-602-branch/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit/ios/audio-only.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-click.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/change-video-source-on-end.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-mutes-onplaying.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-offscreen.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/wide-autoplaying-video-with-audio.html Added Paths branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/input-field-in-scrollable-document.html branches/safari-602-branch/Tools/TestWebKitAPI/mac/TestWKWebViewMac.h branches/safari-602-branch/Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm Diff Modified: branches/safari-602-branch/Source/WebKit2/ChangeLog (206285 => 206286) --- branches/safari-602-branch/Source/WebKit2/ChangeLog 2016-09-23 01:54:05 UTC (rev 206285) +++ branches/safari-602-branch/Source/WebKit2/ChangeLog 2016-09-23 02:10:48 UTC (rev 206286) @@ -1,3 +1,72 @@ +2016-09-22 Babak Shafiei + +Merge r206033. rdar://problem/28086237 + +2016-09-16 Wenson Hsieh + +Inserting a space after inserting an accepted candidate scrolls the document and causes a flicker +https://bugs.webkit.org/show_bug.cgi?id=162009 + + +Reviewed by Tim Horton. + +After inserting a text candidate, if the candidate ended with a soft space, the next space we insert should
[webkit-changes] [206288] branches/safari-602-branch/Source/WebCore
Title: [206288] branches/safari-602-branch/Source/WebCore
Revision 206288
Author bshaf...@apple.com
Date 2016-09-22 19:10:59 -0700 (Thu, 22 Sep 2016)
Log Message
Merge r206193. rdar://problem/28376161
Modified Paths
branches/safari-602-branch/Source/WebCore/ChangeLog
branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp
branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.h
branches/safari-602-branch/Source/WebCore/html/HTMLMediaElement.cpp
branches/safari-602-branch/Source/WebCore/html/HTMLMediaElement.h
branches/safari-602-branch/Source/WebCore/platform/audio/PlatformMediaSession.cpp
branches/safari-602-branch/Source/WebCore/platform/audio/PlatformMediaSession.h
branches/safari-602-branch/Source/WebCore/platform/audio/mac/MediaSessionManagerMac.mm
branches/safari-602-branch/Source/WebCore/platform/mac/MediaRemoteSoftLink.cpp
branches/safari-602-branch/Source/WebCore/platform/mac/MediaRemoteSoftLink.h
Diff
Modified: branches/safari-602-branch/Source/WebCore/ChangeLog (206287 => 206288)
--- branches/safari-602-branch/Source/WebCore/ChangeLog 2016-09-23 02:10:53 UTC (rev 206287)
+++ branches/safari-602-branch/Source/WebCore/ChangeLog 2016-09-23 02:10:59 UTC (rev 206288)
@@ -1,5 +1,34 @@
2016-09-22 Babak Shafiei
+Merge r206193. rdar://problem/28376161
+
+2016-09-20 Jer Noble
+
+Adopt MRMediaRemoteSetParentApplication.
+https://bugs.webkit.org/show_bug.cgi?id=162259
+
+
+Reviewed by Anders Carlsson.
+
+Allow MediaSessionManagerMac to retrieve the correct parent application identifier
+from a PlatformMediaSession so that it can pass that identifier through to MediaRemote
+via MRMediaRemoteSetParentApplication.
+
+* Modules/webaudio/AudioContext.cpp:
+(WebCore::AudioContext::sourceApplicationIdentifier):
+* Modules/webaudio/AudioContext.h:
+* platform/audio/PlatformMediaSession.cpp:
+(WebCore::PlatformMediaSession::sourceApplicationIdentifier):
+* platform/audio/PlatformMediaSession.h:
+(WebCore::PlatformMediaSession::resetPlaybackSessionState): Deleted.
+* platform/audio/mac/MediaSessionManagerMac.mm:
+(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
+* platform/mac/MediaRemoteSoftLink.cpp:
+* platform/mac/MediaRemoteSoftLink.h:
+
+
+2016-09-22 Babak Shafiei
+
Merge r206027. rdar://problem/28366812
2016-09-16 Per Arne Vollan
Modified: branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp (206287 => 206288)
--- branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp 2016-09-23 02:10:53 UTC (rev 206287)
+++ branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.cpp 2016-09-23 02:10:59 UTC (rev 206288)
@@ -48,11 +48,13 @@
#include "EventNames.h"
#include "ExceptionCode.h"
#include "FFTFrame.h"
+#include "Frame.h"
#include "GainNode.h"
#include "GenericEventQueue.h"
#include "HRTFDatabaseLoader.h"
#include "HRTFPanner.h"
#include "JSDOMPromise.h"
+#include "NetworkingContext.h"
#include "OfflineAudioCompletionEvent.h"
#include "OfflineAudioDestinationNode.h"
#include "OscillatorNode.h"
@@ -356,6 +358,16 @@
return downcast(m_scriptExecutionContext);
}
+String AudioContext::sourceApplicationIdentifier() const
+{
+Document* document = this->document();
+if (Frame* frame = document ? document->frame() : nullptr) {
+if (NetworkingContext* networkingContext = frame->loader().networkingContext())
+return networkingContext->sourceApplicationIdentifier();
+}
+return emptyString();
+}
+
RefPtr AudioContext::createBuffer(unsigned numberOfChannels, size_t numberOfFrames, float sampleRate, ExceptionCode& ec)
{
RefPtr audioBuffer = AudioBuffer::create(numberOfChannels, numberOfFrames, sampleRate);
Modified: branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.h (206287 => 206288)
--- branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.h 2016-09-23 02:10:53 UTC (rev 206287)
+++ branches/safari-602-branch/Source/WebCore/Modules/webaudio/AudioContext.h 2016-09-23 02:10:59 UTC (rev 206288)
@@ -316,6 +316,7 @@
bool canReceiveRemoteControlCommands() const override { return false; }
void didReceiveRemoteControlCommand(PlatformMediaSession::RemoteControlCommandType) override { }
bool shouldOverrideBackgroundPlaybackRestriction(PlatformMediaSession::InterruptionType) const override { return false; }
+String sourceApplicationIdentifier() const override;
// EventTarget
void refEventTarget() override { ref(); }
Modified: branches/safari-602-branch/Source/WebCore/html/HTMLMediaElement.cpp (206287 => 206288)
--- branches/safari-602-branch/Source/WebCore/html/HTMLMediaElement.cpp 2016-09-23 02:10:53 UTC (rev 206287)
+++ branch
[webkit-changes] [206287] branches/safari-602-branch/Tools
Title: [206287] branches/safari-602-branch/Tools
Revision 206287
Author bshaf...@apple.com
Date 2016-09-22 19:10:53 -0700 (Thu, 22 Sep 2016)
Log Message
Merge r206038. rdar://problem/28086237
Modified Paths
branches/safari-602-branch/Tools/ChangeLog
branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm
Diff
Modified: branches/safari-602-branch/Tools/ChangeLog (206286 => 206287)
--- branches/safari-602-branch/Tools/ChangeLog 2016-09-23 02:10:48 UTC (rev 206286)
+++ branches/safari-602-branch/Tools/ChangeLog 2016-09-23 02:10:53 UTC (rev 206287)
@@ -1,5 +1,22 @@
2016-09-22 Babak Shafiei
+Merge r206038. rdar://problem/28086237
+
+2016-09-16 Wenson Hsieh
+
+RequiresUserActionForPlayback TestWebKitAPI tests are broken after r206033.
+https://bugs.webkit.org/show_bug.cgi?id=162080
+
+Reviewed by Jer Noble.
+
+I renamed "playingHandler" to the more generalized "testHandler", but did not realize that the
+RequiresUserActionForPlayback tests also used "playingHandler". Renames the handler to account for this change.
+
+* TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
+(RequiresUserActionForPlaybackTest::SetUp):
+
+2016-09-22 Babak Shafiei
+
Merge r206033. rdar://problem/28086237
2016-09-16 Wenson Hsieh
Modified: branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm (206286 => 206287)
--- branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-09-23 02:10:48 UTC (rev 206286)
+++ branches/safari-602-branch/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm 2016-09-23 02:10:53 UTC (rev 206287)
@@ -72,7 +72,7 @@
{
handler = adoptNS([[RequiresUserActionForPlaybackMessageHandler alloc] init]);
configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
-[[configuration userContentController] addScriptMessageHandler:handler.get() name:@"playingHandler"];
+[[configuration userContentController] addScriptMessageHandler:handler.get() name:@"testHandler"];
configuration.get()._mediaDataLoadsAutomatically = YES;
#if TARGET_OS_IPHONE
configuration.get().allowsInlineMediaPlayback = YES;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206289] trunk
Title: [206289] trunk
Revision 206289
Author commit-qu...@webkit.org
Date 2016-09-22 20:50:22 -0700 (Thu, 22 Sep 2016)
Log Message
[JSC] Use an inline cache to generate op_negate
https://bugs.webkit.org/show_bug.cgi?id=162371
Patch by Benjamin Poulain on 2016-09-22
Reviewed by Saam Barati.
JSTests:
* stress/op-negate-inline-cache.js: Added.
Source/_javascript_Core:
Use an inline cache to reduce the amount of code
required to implement op_negate.
For pure integer negate, the generated asm shrinks
from 147 bytes to 125 bytes (14%).
For double negate, the generated asm shrinks
to 130 bytes (11%).
The average size on Sunspider is 100bytes, this is due
to the op_negates that are never executed and do not
generate much.
* bytecode/ArithProfile.h:
(JSC::ArithProfile::ArithProfile):
(JSC::ArithProfile::observeLHS):
(JSC::ArithProfile::observeLHSAndRHS):
* bytecode/BytecodeList.json:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::addJITNegIC):
* bytecode/CodeBlock.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitUnaryOp):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::UnaryOpNode::emitBytecode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMathIC):
* dfg/DFGSpeculativeJIT.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMathIC):
* jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
* jit/JITInlines.h:
(JSC::JIT::callOperation):
* jit/JITMathIC.h:
(JSC::JITMathIC::generateInline):
(JSC::canGenerateWithBinaryProfile):
(JSC::canGenerateWithUnaryProfile):
* jit/JITMathICForwards.h:
* jit/JITNegGenerator.cpp:
(JSC::JITNegGenerator::generateInline):
(JSC::JITNegGenerator::generateFastPath):
* jit/JITNegGenerator.h:
(JSC::JITNegGenerator::JITNegGenerator):
(JSC::JITNegGenerator::arithProfile):
(JSC::JITNegGenerator::didEmitFastPath): Deleted.
(JSC::JITNegGenerator::endJumpList): Deleted.
(JSC::JITNegGenerator::slowPathJumpList): Deleted.
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/CommonSlowPaths.cpp:
(JSC::updateArithProfileForUnaryArithOp):
(JSC::SLOW_PATH_DECL):
Modified Paths
trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/ArithProfile.h
trunk/Source/_javascript_Core/bytecode/BytecodeList.json
trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp
trunk/Source/_javascript_Core/bytecode/CodeBlock.h
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp
trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/CCallHelpers.h
trunk/Source/_javascript_Core/jit/JIT.h
trunk/Source/_javascript_Core/jit/JITArithmetic.cpp
trunk/Source/_javascript_Core/jit/JITInlines.h
trunk/Source/_javascript_Core/jit/JITMathIC.h
trunk/Source/_javascript_Core/jit/JITMathICForwards.h
trunk/Source/_javascript_Core/jit/JITNegGenerator.cpp
trunk/Source/_javascript_Core/jit/JITNegGenerator.h
trunk/Source/_javascript_Core/jit/JITOperations.cpp
trunk/Source/_javascript_Core/jit/JITOperations.h
trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm
trunk/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp
Added Paths
trunk/JSTests/stress/op-negate-inline-cache.js
Diff
Modified: trunk/JSTests/ChangeLog (206288 => 206289)
--- trunk/JSTests/ChangeLog 2016-09-23 02:10:59 UTC (rev 206288)
+++ trunk/JSTests/ChangeLog 2016-09-23 03:50:22 UTC (rev 206289)
@@ -1,3 +1,12 @@
+2016-09-22 Benjamin Poulain
+
+[JSC] Use an inline cache to generate op_negate
+https://bugs.webkit.org/show_bug.cgi?id=162371
+
+Reviewed by Saam Barati.
+
+* stress/op-negate-inline-cache.js: Added.
+
2016-09-22 Mark Lam
Array.prototype.join should do overflow checks on string joins.
Added: trunk/JSTests/stress/op-negate-inline-cache.js (0 => 206289)
--- trunk/JSTests/stress/op-negate-inline-cache.js (rev 0)
+++ trunk/JSTests/stress/op-negate-inline-cache.js 2016-09-23 03:50:22 UTC (rev 206289)
@@ -0,0 +1,300 @@
+"use strict"
+
+
+function opaqueIdentity(arg) {
+return arg;
+}
+noInline(opaqueIdentity)
+function negateWithDoubleSub(arg) {
+// Implement integer negate as a double sub operation.
+return opaqueIdentity(6.4 - arg) - 6.4;
+}
+noInline(negateWithDoubleSub)
+
+function opaqueNonZeroIntegerNegate(arg)
+{
+return -arg;
+}
+noInline(opaqueNonZeroI
[webkit-changes] [206291] tags/Safari-603.1.6.0.2/
Title: [206291] tags/Safari-603.1.6.0.2/ Revision 206291 Author bshaf...@apple.com Date 2016-09-22 22:25:25 -0700 (Thu, 22 Sep 2016) Log Message New tag. Added Paths tags/Safari-603.1.6.0.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206292] tags/Safari-603.1.6.0.2/Source
Title: [206292] tags/Safari-603.1.6.0.2/Source Revision 206292 Author bshaf...@apple.com Date 2016-09-22 22:29:03 -0700 (Thu, 22 Sep 2016) Log Message Versioning. Modified Paths tags/Safari-603.1.6.0.2/Source/_javascript_Core/Configurations/Version.xcconfig tags/Safari-603.1.6.0.2/Source/WebCore/Configurations/Version.xcconfig tags/Safari-603.1.6.0.2/Source/WebInspectorUI/Configurations/Version.xcconfig tags/Safari-603.1.6.0.2/Source/WebKit/mac/Configurations/Version.xcconfig tags/Safari-603.1.6.0.2/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: tags/Safari-603.1.6.0.2/Source/_javascript_Core/Configurations/Version.xcconfig (206291 => 206292) --- tags/Safari-603.1.6.0.2/Source/_javascript_Core/Configurations/Version.xcconfig 2016-09-23 05:25:25 UTC (rev 206291) +++ tags/Safari-603.1.6.0.2/Source/_javascript_Core/Configurations/Version.xcconfig 2016-09-23 05:29:03 UTC (rev 206292) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-603.1.6.0.2/Source/WebCore/Configurations/Version.xcconfig (206291 => 206292) --- tags/Safari-603.1.6.0.2/Source/WebCore/Configurations/Version.xcconfig 2016-09-23 05:25:25 UTC (rev 206291) +++ tags/Safari-603.1.6.0.2/Source/WebCore/Configurations/Version.xcconfig 2016-09-23 05:29:03 UTC (rev 206292) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-603.1.6.0.2/Source/WebInspectorUI/Configurations/Version.xcconfig (206291 => 206292) --- tags/Safari-603.1.6.0.2/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-09-23 05:25:25 UTC (rev 206291) +++ tags/Safari-603.1.6.0.2/Source/WebInspectorUI/Configurations/Version.xcconfig 2016-09-23 05:29:03 UTC (rev 206292) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The system version prefix is based on the current system version. Modified: tags/Safari-603.1.6.0.2/Source/WebKit/mac/Configurations/Version.xcconfig (206291 => 206292) --- tags/Safari-603.1.6.0.2/Source/WebKit/mac/Configurations/Version.xcconfig 2016-09-23 05:25:25 UTC (rev 206291) +++ tags/Safari-603.1.6.0.2/Source/WebKit/mac/Configurations/Version.xcconfig 2016-09-23 05:29:03 UTC (rev 206292) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: tags/Safari-603.1.6.0.2/Source/WebKit2/Configurations/Version.xcconfig (206291 => 206292) --- tags/Safari-603.1.6.0.2/Source/WebKit2/Configurations/Version.xcconfig 2016-09-23 05:25:25 UTC (rev 206291) +++ tags/Safari-603.1.6.0.2/Source/WebKit2/Configurations/Version.xcconfig 2016-09-23 05:29:03 UTC (rev 206292) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 6; MICRO_VERSION = 0; -NANO_VERSION = 1; +NANO_VERSION = 2; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [206293] tags/Safari-603.1.6.0.2
Title: [206293] tags/Safari-603.1.6.0.2
Revision 206293
Author bshaf...@apple.com
Date 2016-09-22 22:31:15 -0700 (Thu, 22 Sep 2016)
Log Message
Roll out r206165. rdar://problem/28435943
Modified Paths
tags/Safari-603.1.6.0.2/LayoutTests/ChangeLog
tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt
tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html
tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/ChangeLog
tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt
tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/web-platform-tests/url/a-element-xhtml-expected.txt
tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/web-platform-tests/url/url-constructor-expected.txt
tags/Safari-603.1.6.0.2/Source/WebCore/ChangeLog
tags/Safari-603.1.6.0.2/Source/WebCore/page/SecurityOrigin.cpp
Diff
Modified: tags/Safari-603.1.6.0.2/LayoutTests/ChangeLog (206292 => 206293)
--- tags/Safari-603.1.6.0.2/LayoutTests/ChangeLog 2016-09-23 05:29:03 UTC (rev 206292)
+++ tags/Safari-603.1.6.0.2/LayoutTests/ChangeLog 2016-09-23 05:31:15 UTC (rev 206293)
@@ -1,3 +1,7 @@
+2016-09-22 Babak Shafiei
+
+Roll out r206165.
+
2016-09-20 Nan Wang
AX: AppleVisUser: VO can't navigate web dialogs iOS10
Modified: tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt (206292 => 206293)
--- tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt 2016-09-23 05:29:03 UTC (rev 206292)
+++ tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt 2016-09-23 05:31:15 UTC (rev 206293)
@@ -1,3 +1,5 @@
+CONSOLE MESSAGE: Unable to post message to asdf://. Recipient has origin http://localhost:8000.
+
window.location.href = ""
waiting...
Encountered exception SyntaxError (DOM Exception 12): The string did not match the expected pattern. while posting message to ''.
@@ -4,7 +6,7 @@
Encountered exception SyntaxError (DOM Exception 12): The string did not match the expected pattern. while posting message to 'asdf'.
Encountered exception SyntaxError (DOM Exception 12): The string did not match the expected pattern. while posting message to '/tmp/foo'.
Encountered exception SyntaxError (DOM Exception 12): The string did not match the expected pattern. while posting message to '//localhost'.
-Encountered exception SyntaxError (DOM Exception 12): The string did not match the expected pattern. while posting message to 'asdf:'.
+Posted message to 'asdf:' without any exceptions.
Encountered exception SyntaxError (DOM Exception 12): The string did not match the expected pattern. while posting message to 'http:'.
Received message: data="" message: data="" origin="http://127.0.0.1:8000"" origin="http://localhost:8000"
Modified: tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html (206292 => 206293)
--- tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html 2016-09-23 05:29:03 UTC (rev 206292)
+++ tags/Safari-603.1.6.0.2/LayoutTests/http/tests/security/postMessage/invalid-origin-throws-exception.html 2016-09-23 05:31:15 UTC (rev 206293)
@@ -29,7 +29,7 @@
tryPostMessage("/tmp/foo");
tryPostMessage("//localhost");
-// URLs without an origin should fail with a syntax error.
+// URLs without an origin should fail without generating any errors.
tryPostMessage("asdf:");
tryPostMessage("http:");
Modified: tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/ChangeLog (206292 => 206293)
--- tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/ChangeLog 2016-09-23 05:29:03 UTC (rev 206292)
+++ tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/ChangeLog 2016-09-23 05:31:15 UTC (rev 206293)
@@ -1,3 +1,7 @@
+2016-09-22 Babak Shafiei
+
+Roll out r206165.
+
2016-09-20 Alex Christensen
Make URLSearchParams spec-compliant
Modified: tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt (206292 => 206293)
--- tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt 2016-09-23 05:29:03 UTC (rev 206292)
+++ tags/Safari-603.1.6.0.2/LayoutTests/imported/w3c/web-platform-tests/url/a-element-expected.txt 2016-09-23 05:31:15 UTC (rev 206293)
@@ -7,7 +7,7 @@
PASS Parsing: < :foo.com
> against
PASS Parsing: < foo.com > against
-PASS Parsing: against
+FAIL Parsing: against assert_equals: origin expected "null" but got "a://"
PASS Parsing: against
PASS Parsing: against
FAIL Parsing: against assert_equals: origin expected "http://f:0" but got "http://f"
@@ -48,12 +48,12 @@
PASS Parsing: against
PASS Parsing: against
PASS Parsing: against
-PASS Parsing: ag
