date:20180416

[webkit-changes] [230700] trunk/Tools

2018-04-16 Thread zalan

Title: [230700] trunk/Tools








Revision 230700
Author za...@apple.com
Date 2018-04-16 22:17:26 -0700 (Mon, 16 Apr 2018)


Log Message
[LayoutReloaded] Add support for replaced box.
https://bugs.webkit.org/show_bug.cgi?id=184680

Reviewed by Antti Koivisto.

Basic support for inline replaced.

* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
(InlineFormattingContext.prototype._handleInlineBox):
(InlineFormattingContext.prototype._handleInlineBlock):
(InlineFormattingContext.prototype._handleReplaced):
* LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
(Line.prototype.lastLineBox):
(Line.prototype.addInlineBox):
(Line.prototype.addInlineContainerBox): Deleted.
* LayoutReloaded/TreeBuilder.js:
(TreeBuilder.prototype._createAndAttachBox):
* LayoutReloaded/Utils.js:
(Utils._dumpBox):
* LayoutReloaded/test/index.html:
* LayoutReloaded/test/inline-simple-replaced.html: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/Line.js
trunk/Tools/LayoutReloaded/TreeBuilder.js
trunk/Tools/LayoutReloaded/Utils.js
trunk/Tools/LayoutReloaded/test/index.html


Added Paths

trunk/Tools/LayoutReloaded/test/inline-simple-replaced.html




Diff

Modified: trunk/Tools/ChangeLog (230699 => 230700)

--- trunk/Tools/ChangeLog	2018-04-17 03:15:16 UTC (rev 230699)
+++ trunk/Tools/ChangeLog	2018-04-17 05:17:26 UTC (rev 230700)
@@ -1,5 +1,29 @@
 2018-04-16  Zalan Bujtas  
 
+[LayoutReloaded] Add support for replaced box.
+https://bugs.webkit.org/show_bug.cgi?id=184680
+
+Reviewed by Antti Koivisto.
+
+Basic support for inline replaced.
+
+* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
+(InlineFormattingContext.prototype._handleInlineBox):
+(InlineFormattingContext.prototype._handleInlineBlock):
+(InlineFormattingContext.prototype._handleReplaced):
+* LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
+(Line.prototype.lastLineBox):
+(Line.prototype.addInlineBox):
+(Line.prototype.addInlineContainerBox): Deleted.
+* LayoutReloaded/TreeBuilder.js:
+(TreeBuilder.prototype._createAndAttachBox):
+* LayoutReloaded/Utils.js:
+(Utils._dumpBox):
+* LayoutReloaded/test/index.html:
+* LayoutReloaded/test/inline-simple-replaced.html: Added.
+
+2018-04-16  Zalan Bujtas  
+
 [LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
 https://bugs.webkit.org/show_bug.cgi?id=184679
 


Modified: trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js (230699 => 230700)

--- trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js	2018-04-17 03:15:16 UTC (rev 230699)
+++ trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js	2018-04-17 05:17:26 UTC (rev 230700)
@@ -104,6 +104,8 @@
 _handleInlineBox(inlineBox) {
 if (inlineBox.text())
 return this._handleText(inlineBox);
+else
+return this._handleReplaced(inlineBox);
 }
 
 _handleInlineBlock(inlineBlockBox) {
@@ -110,13 +112,13 @@
 ASSERT(inlineBlockBox.establishesFormattingContext());
 let displayBox = this.displayBox(inlineBlockBox);
 
-// TODO: auto width/height
+// TODO: auto width/height and check if content actually at all.
 this._adjustLineForInlineContainerStart(inlineBlockBox);
 displayBox.setWidth(Utils.width(inlineBlockBox) + Utils.computedHorizontalBorderAndPadding(inlineBlockBox.node()));
 this.layoutState().formattingContext(inlineBlockBox).layout();
 displayBox.setHeight(Utils.height(inlineBlockBox) + Utils.computedVerticalBorderAndPadding(inlineBlockBox.node()));
+this._line().addInlineBox(displayBox.size());
 this._adjustLineForInlineContainerEnd(inlineBlockBox);
-this._line().addInlineContainerBox(displayBox.size());
 }
 
 _handleText(inlineBox) {
@@ -156,6 +158,18 @@
 this._line().moveContentHorizontally(floatWidth);
 }
 
+_handleReplaced(replacedBox) {
+// TODO: intrinsic size and check if content actually at all.
+let displayBox = this.displayBox(replacedBox);
+this._adjustLineForInlineContainerStart(replacedBox);
+displayBox.setWidth(Utils.width(replacedBox) + Utils.computedHorizontalBorderAndPadding(replacedBox.node()));
+
+displayBox.setHeight(Utils.height(replacedBox) + Utils.computedVerticalBorderAndPadding(replacedBox.node()));
+this._line().addInlineBox(displayBox.size());
+displayBox.setTopLeft(this._line().lastLineBox().lineBoxRect.topLeft());
+this._adjustLineForInlineContainerEnd(replacedBox);
+   }
+

[webkit-changes] [230701] trunk/Source/WebInspectorUI

2018-04-16 Thread nvasilyev

Title: [230701] trunk/Source/WebInspectorUI








Revision 230701
Author nvasil...@apple.com
Date 2018-04-16 22:48:41 -0700 (Mon, 16 Apr 2018)


Log Message
Web Inspector: Can't select and copy text from Network tab popover
https://bugs.webkit.org/show_bug.cgi?id=184606

Reviewed by Matt Baker.

* UserInterface/Views/ResourceTimingBreakdownView.css:
(.waterfall-popover .resource-timing-breakdown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (230700 => 230701)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-04-17 05:17:26 UTC (rev 230700)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-04-17 05:48:41 UTC (rev 230701)
@@ -1,3 +1,13 @@
+2018-04-16  Nikita Vasilyev  
+
+Web Inspector: Can't select and copy text from Network tab popover
+https://bugs.webkit.org/show_bug.cgi?id=184606
+
+Reviewed by Matt Baker.
+
+* UserInterface/Views/ResourceTimingBreakdownView.css:
+(.waterfall-popover .resource-timing-breakdown):
+
 2018-04-12  Nikita Vasilyev  
 
 Web Inspector: Refactoring: move popover styles from JS to CSS


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css (230700 => 230701)

--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css	2018-04-17 05:17:26 UTC (rev 230700)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css	2018-04-17 05:48:41 UTC (rev 230701)
@@ -29,6 +29,7 @@
 
 .waterfall-popover-content .resource-timing-breakdown {
 margin: 5px;
+-webkit-user-select: text;
 }
 
 .resource-timing-breakdown > table > tr > td.label {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230673] trunk/Source/WebKit

2018-04-16 Thread timothy

Title: [230673] trunk/Source/WebKit








Revision 230673
Author timo...@apple.com
Date 2018-04-16 11:29:19 -0700 (Mon, 16 Apr 2018)


Log Message
Clean up OTHER_LDFLAGS for WebKit processes
https://bugs.webkit.org/show_bug.cgi?id=184657

Reviewed by Jer Noble.

* Configurations/PluginProcessShim.xcconfig:
* Configurations/PluginService.32.xcconfig:
* Configurations/PluginService.64.xcconfig:
* Configurations/WebContentService.xcconfig:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig
trunk/Source/WebKit/Configurations/PluginService.32.xcconfig
trunk/Source/WebKit/Configurations/PluginService.64.xcconfig
trunk/Source/WebKit/Configurations/WebContentService.xcconfig




Diff

Modified: trunk/Source/WebKit/ChangeLog (230672 => 230673)

--- trunk/Source/WebKit/ChangeLog	2018-04-16 18:05:42 UTC (rev 230672)
+++ trunk/Source/WebKit/ChangeLog	2018-04-16 18:29:19 UTC (rev 230673)
@@ -1,3 +1,15 @@
+2018-04-16  Timothy Hatcher  
+
+Clean up OTHER_LDFLAGS for WebKit processes
+https://bugs.webkit.org/show_bug.cgi?id=184657
+
+Reviewed by Jer Noble.
+
+* Configurations/PluginProcessShim.xcconfig:
+* Configurations/PluginService.32.xcconfig:
+* Configurations/PluginService.64.xcconfig:
+* Configurations/WebContentService.xcconfig:
+
 2018-04-15  Michael Catanzaro  
 
 [WPE] Install files needed for WebKitWebExtensions


Modified: trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig (230672 => 230673)

--- trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
+++ trunk/Source/WebKit/Configurations/PluginProcessShim.xcconfig	2018-04-16 18:29:19 UTC (rev 230673)
@@ -25,5 +25,13 @@
 
 #include "Shim.xcconfig"
 
-OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM);
-OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = -framework AppKit -framework Carbon -framework QuartzCore;
+WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
+
+WK_CARBON_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_CARBON_LDFLAGS_macosx = -framework Carbon;
+
+WK_QUARTZCORE_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_QUARTZCORE_LDFLAGS_macosx = -framework QuartzCore;
+
+OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS) $(WK_APPKIT_LDFLAGS) $(WK_CARBON_LDFLAGS) $(WK_QUARTZCORE_LDFLAGS);


Modified: trunk/Source/WebKit/Configurations/PluginService.32.xcconfig (230672 => 230673)

--- trunk/Source/WebKit/Configurations/PluginService.32.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
+++ trunk/Source/WebKit/Configurations/PluginService.32.xcconfig	2018-04-16 18:29:19 UTC (rev 230673)
@@ -32,9 +32,12 @@
 PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist;
 
-OTHER_LDFLAGS = $(OTHER_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
-OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = -framework AppKit $(BUILT_PRODUCTS_DIR)/PluginProcessShim.dylib;
+WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
 
+OTHER_LDFLAGS = $(inherited) $(WK_APPKIT_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
+OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(BUILT_PRODUCTS_DIR)/PluginProcessShim.dylib;
+
 CODE_SIGN_ENTITLEMENTS = Configurations/PluginService.entitlements;
 
 SKIP_INSTALL = $(WK_BUILDING_ONLY_X86_64);


Modified: trunk/Source/WebKit/Configurations/PluginService.64.xcconfig (230672 => 230673)

--- trunk/Source/WebKit/Configurations/PluginService.64.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
+++ trunk/Source/WebKit/Configurations/PluginService.64.xcconfig	2018-04-16 18:29:19 UTC (rev 230673)
@@ -29,9 +29,12 @@
 PRODUCT_BUNDLE_IDENTIFIER = $(PRODUCT_NAME);
 INFOPLIST_FILE = PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist;
 
-OTHER_LDFLAGS = $(OTHER_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
-OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = -framework AppKit $(BUILT_PRODUCTS_DIR)/PluginProcessShim.dylib;
+WK_APPKIT_LDFLAGS = $(WK_APPKIT_LDFLAGS_$(WK_PLATFORM_NAME));
+WK_APPKIT_LDFLAGS_macosx = -framework AppKit;
 
+OTHER_LDFLAGS = $(inherited) $(WK_APPKIT_LDFLAGS) $(OTHER_LDFLAGS_PLATFORM) $(OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH) $(WK_RELOCATABLE_FRAMEWORKS_LDFLAGS);
+OTHER_LDFLAGS_PLATFORM[sdk=macosx*] = $(BUILT_PRODUCTS_DIR)/PluginProcessShim.dylib;
+
 CODE_SIGN_ENTITLEMENTS = Configurations/PluginService.entitlements;
 
 SKIP_INSTALL[sdk=iphone*] = YES;


Modified: trunk/Source/WebKit/Configurations/WebContentService.xcconfig (230672 => 230673)

--- trunk/Source/WebKit/Configurations/WebContentService.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
+++

[webkit-changes] [230672] tags/Safari-606.1.13.1/Source

2018-04-16 Thread kocsen_chung

Title: [230672] tags/Safari-606.1.13.1/Source








Revision 230672
Author kocsen_ch...@apple.com
Date 2018-04-16 11:05:42 -0700 (Mon, 16 Apr 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.13.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.13.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.13.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.13.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.13.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.13.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.13.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.13.1/Source/_javascript_Core/Configurations/Version.xcconfig (230671 => 230672)

--- tags/Safari-606.1.13.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
+++ tags/Safari-606.1.13.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.13.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (230671 => 230672)

--- tags/Safari-606.1.13.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
+++ tags/Safari-606.1.13.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.13.1/Source/WebCore/Configurations/Version.xcconfig (230671 => 230672)

--- tags/Safari-606.1.13.1/Source/WebCore/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
+++ tags/Safari-606.1.13.1/Source/WebCore/Configurations/Version.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.13.1/Source/WebCore/PAL/Configurations/Version.xcconfig (230671 => 230672)

--- tags/Safari-606.1.13.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
+++ tags/Safari-606.1.13.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.13.1/Source/WebInspectorUI/Configurations/Version.xcconfig (230671 => 230672)

--- tags/Safari-606.1.13.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
+++ tags/Safari-606.1.13.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-606.1.13.1/Source/WebKit/Configurations/Version.xcconfig (230671 => 230672)

--- tags/Safari-606.1.13.1/Source/WebKit/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
+++ tags/Safari-606.1.13.1/Source/WebKit/Configurations/Version.xcconfig	2018-04-16 18:05:42 UTC (rev 230672)
@@

[webkit-changes] [230670] tags/Safari-606.1.13.1/

2018-04-16 Thread kocsen_chung

Title: [230670] tags/Safari-606.1.13.1/








Revision 230670
Author kocsen_ch...@apple.com
Date 2018-04-16 10:48:29 -0700 (Mon, 16 Apr 2018)


Log Message
New tag.

Added Paths

tags/Safari-606.1.13.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230671] trunk/Source

2018-04-16 Thread bshafiei

Title: [230671] trunk/Source








Revision 230671
Author bshaf...@apple.com
Date 2018-04-16 10:55:49 -0700 (Mon, 16 Apr 2018)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/Configurations/Version.xcconfig
trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/WebKit/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/WebKit/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (230670 => 230671)

--- trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-04-16 17:48:29 UTC (rev 230670)
+++ trunk/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-04-16 17:55:49 UTC (rev 230671)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
-TINY_VERSION = 13;
+TINY_VERSION = 14;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230669] trunk/Source/WebCore

2018-04-16 Thread commit-queue

Title: [230669] trunk/Source/WebCore








Revision 230669
Author commit-qu...@webkit.org
Date 2018-04-16 09:01:56 -0700 (Mon, 16 Apr 2018)


Log Message
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible
https://bugs.webkit.org/show_bug.cgi?id=184651

Patch by Thibault Saunier  on 2018-04-16
Reviewed by Philippe Normand.

We can't notify the client if none is connected, but still we need to fill our metadatas from
the provided GstTagList, especially in the case of playbin3 where the client is not set yet
at construct time but the metadata might already be preset (and won't be updated later on).

No new tests are added as we already have a few ones that are currently disabled in
the mediastream testsuite. This patch is part of the work to enable them.

* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230668 => 230669)

--- trunk/Source/WebCore/ChangeLog	2018-04-16 14:36:58 UTC (rev 230668)
+++ trunk/Source/WebCore/ChangeLog	2018-04-16 16:01:56 UTC (rev 230669)
@@ -1,3 +1,20 @@
+2018-04-16  Thibault Saunier  
+
+[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible
+https://bugs.webkit.org/show_bug.cgi?id=184651
+
+Reviewed by Philippe Normand.
+
+We can't notify the client if none is connected, but still we need to fill our metadatas from
+the provided GstTagList, especially in the case of playbin3 where the client is not set yet
+at construct time but the metadata might already be preset (and won't be updated later on).
+
+No new tests are added as we already have a few ones that are currently disabled in
+the mediastream testsuite. This patch is part of the work to enable them.
+
+* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
+(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):
+
 2018-04-16  Antoine Quint  
 
 [Web Animations] Ensure we never return -0 through the API


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp (230668 => 230669)

--- trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp	2018-04-16 14:36:58 UTC (rev 230668)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp	2018-04-16 16:01:56 UTC (rev 230669)
@@ -172,8 +172,6 @@
 void TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged()
 {
 TrackPrivateBaseClient* client = m_owner->client();
-if (!client)
-return;
 
 GRefPtr tags;
 {
@@ -180,10 +178,11 @@
 LockHolder lock(m_tagMutex);
 tags.swap(m_tags);
 }
+
 if (!tags)
 return;
 
-if (getTag(tags.get(), GST_TAG_TITLE, m_label))
+if (getTag(tags.get(), GST_TAG_TITLE, m_label) && client)
 client->labelChanged(m_label);
 
 AtomicString language;
@@ -194,7 +193,8 @@
 return;
 
 m_language = language;
-client->languageChanged(m_language);
+if (client)
+client->languageChanged(m_language);
 }
 
 } // namespace WebCore






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230668] trunk/LayoutTests

2018-04-16 Thread pvollan

Title: [230668] trunk/LayoutTests








Revision 230668
Author pvol...@apple.com
Date 2018-04-16 07:36:58 -0700 (Mon, 16 Apr 2018)


Log Message
Mark css3/filters/blur-various-radii.html as a crash on Windows.
https://bugs.webkit.org/show_bug.cgi?id=184649

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230667 => 230668)

--- trunk/LayoutTests/ChangeLog	2018-04-16 08:47:17 UTC (rev 230667)
+++ trunk/LayoutTests/ChangeLog	2018-04-16 14:36:58 UTC (rev 230668)
@@ -1,3 +1,12 @@
+2018-04-16  Per Arne Vollan  
+
+Mark css3/filters/blur-various-radii.html as a crash on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=184649
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-04-13  Carlos Ramalho  
 
 [GTK][Wayland] Unflag test-case fast/canvas/canvas-createPattern-video-modify.html


Modified: trunk/LayoutTests/platform/win/TestExpectations (230667 => 230668)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-04-16 08:47:17 UTC (rev 230667)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-04-16 14:36:58 UTC (rev 230668)
@@ -4053,3 +4053,5 @@
 webkit.org/b/184589 fast/css-generated-content/pseudo-transition.html [ Skip ]
 webkit.org/b/184589 animations/animation-direction-alternate-reverse.html [ Skip ]
 webkit.org/b/184589 fast/css-generated-content/pseudo-animation.html [ Skip ]
+
+webkit.org/b/184649 css3/filters/blur-various-radii.html [ Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230674] trunk/Source/WebCore

2018-04-16 Thread commit-queue

Title: [230674] trunk/Source/WebCore








Revision 230674
Author commit-qu...@webkit.org
Date 2018-04-16 11:33:13 -0700 (Mon, 16 Apr 2018)


Log Message
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
https://bugs.webkit.org/show_bug.cgi?id=184652

Patch by Thibault Saunier  on 2018-04-16
Reviewed by Philippe Normand.

In the constructor we should mark selected streams based on the default values from GstStream,
if the user changes them, they will be updated as required later on.

No new tests are added as we already have a few ones that are currently disabled in
the mediastream testsuite. This patch is part of the work to enable them.

* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230673 => 230674)

--- trunk/Source/WebCore/ChangeLog	2018-04-16 18:29:19 UTC (rev 230673)
+++ trunk/Source/WebCore/ChangeLog	2018-04-16 18:33:13 UTC (rev 230674)
@@ -1,5 +1,23 @@
 2018-04-16  Thibault Saunier  
 
+[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
+https://bugs.webkit.org/show_bug.cgi?id=184652
+
+Reviewed by Philippe Normand.
+
+In the constructor we should mark selected streams based on the default values from GstStream,
+if the user changes them, they will be updated as required later on.
+
+No new tests are added as we already have a few ones that are currently disabled in
+the mediastream testsuite. This patch is part of the work to enable them.
+
+* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:
+(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):
+* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:
+(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
+
+2018-04-16  Thibault Saunier  
+
 [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible
 https://bugs.webkit.org/show_bug.cgi?id=184651
 


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp (230673 => 230674)

--- trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp	2018-04-16 18:29:19 UTC (rev 230673)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp	2018-04-16 18:33:13 UTC (rev 230674)
@@ -49,6 +49,7 @@
 , m_player(player)
 {
 m_id = gst_stream_get_stream_id(stream.get());
+setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
 notifyTrackOfActiveChanged();
 }
 #endif


Modified: trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp (230673 => 230674)

--- trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp	2018-04-16 18:29:19 UTC (rev 230673)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp	2018-04-16 18:33:13 UTC (rev 230674)
@@ -49,6 +49,7 @@
 , m_player(player)
 {
 m_id = gst_stream_get_stream_id(stream.get());
+setActive(gst_stream_get_stream_flags(stream.get()) & GST_STREAM_FLAG_SELECT);
 notifyTrackOfActiveChanged();
 }
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230675] trunk/Source/WebKit

2018-04-16 Thread bburg

Title: [230675] trunk/Source/WebKit








Revision 230675
Author bb...@apple.com
Date 2018-04-16 11:53:50 -0700 (Mon, 16 Apr 2018)


Log Message
[Cocoa] Web Automation: add SPI to terminate automation session and disconnect the remote end
https://bugs.webkit.org/show_bug.cgi?id=184523


Reviewed by Simon Fraser.

When a user breaks the automation glass pane and chooses "Stop Session", there is no way
for Safari to actually disconnect the remote connection using automation-related ObjC SPI.
This can lead to sessions getting stuck and safaridriver is unable to request a new session.

Expose the -terminate method as SPI. This disconnects the remote connection and then notifies
the session delegate that the remote disconnected. At that point, Safari can uninstall
the session from the process pool and tear down other session state.

* UIProcess/API/Cocoa/_WKAutomationSession.h:
* UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession terminate]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h
trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (230674 => 230675)

--- trunk/Source/WebKit/ChangeLog	2018-04-16 18:33:13 UTC (rev 230674)
+++ trunk/Source/WebKit/ChangeLog	2018-04-16 18:53:50 UTC (rev 230675)
@@ -1,3 +1,23 @@
+2018-04-16  Brian Burg  
+
+[Cocoa] Web Automation: add SPI to terminate automation session and disconnect the remote end
+https://bugs.webkit.org/show_bug.cgi?id=184523
+
+
+Reviewed by Simon Fraser.
+
+When a user breaks the automation glass pane and chooses "Stop Session", there is no way
+for Safari to actually disconnect the remote connection using automation-related ObjC SPI.
+This can lead to sessions getting stuck and safaridriver is unable to request a new session.
+
+Expose the -terminate method as SPI. This disconnects the remote connection and then notifies
+the session delegate that the remote disconnected. At that point, Safari can uninstall
+the session from the process pool and tear down other session state.
+
+* UIProcess/API/Cocoa/_WKAutomationSession.h:
+* UIProcess/API/Cocoa/_WKAutomationSession.mm:
+(-[_WKAutomationSession terminate]):
+
 2018-04-16  Timothy Hatcher  
 
 Clean up OTHER_LDFLAGS for WebKit processes


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h (230674 => 230675)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h	2018-04-16 18:33:13 UTC (rev 230674)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.h	2018-04-16 18:53:50 UTC (rev 230675)
@@ -47,6 +47,8 @@
 
 - (instancetype)initWithConfiguration:(_WKAutomationSessionConfiguration *)configuration NS_DESIGNATED_INITIALIZER;
 
+- (void)terminate WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
+
 #if !TARGET_OS_IPHONE
 - (BOOL)wasEventSynthesizedForAutomation:(NSEvent *)event;
 - (void)markEventAsSynthesizedForAutomation:(NSEvent *)event;


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.mm (230674 => 230675)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.mm	2018-04-16 18:33:13 UTC (rev 230674)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/_WKAutomationSession.mm	2018-04-16 18:53:50 UTC (rev 230675)
@@ -102,6 +102,11 @@
 return _session->isSimulatingUserInteraction();
 }
 
+- (void)terminate
+{
+_session->terminate();
+}
+
 #if PLATFORM(MAC)
 - (BOOL)wasEventSynthesizedForAutomation:(NSEvent *)event
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230679] trunk/Source/WebCore

2018-04-16 Thread commit-queue

Title: [230679] trunk/Source/WebCore








Revision 230679
Author commit-qu...@webkit.org
Date 2018-04-16 12:45:27 -0700 (Mon, 16 Apr 2018)


Log Message
[WinCairo] Media elements should be enabled by default
https://bugs.webkit.org/show_bug.cgi?id=184597

Patch by Christopher Reid  on 2018-04-16
Reviewed by Per Arne Vollan.

Enabling media elements by default with media foundation.

* page/SettingsDefaultValues.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SettingsDefaultValues.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (230678 => 230679)

--- trunk/Source/WebCore/ChangeLog	2018-04-16 19:22:17 UTC (rev 230678)
+++ trunk/Source/WebCore/ChangeLog	2018-04-16 19:45:27 UTC (rev 230679)
@@ -1,5 +1,16 @@
 2018-04-16  Christopher Reid  
 
+[WinCairo] Media elements should be enabled by default
+https://bugs.webkit.org/show_bug.cgi?id=184597
+
+Reviewed by Per Arne Vollan.
+
+Enabling media elements by default with media foundation.
+
+* page/SettingsDefaultValues.h:
+
+2018-04-16  Christopher Reid  
+
 [Curl] Add the Accept-Language field to curl request headers
 https://bugs.webkit.org/show_bug.cgi?id=184605
 


Modified: trunk/Source/WebCore/page/SettingsDefaultValues.h (230678 => 230679)

--- trunk/Source/WebCore/page/SettingsDefaultValues.h	2018-04-16 19:22:17 UTC (rev 230678)
+++ trunk/Source/WebCore/page/SettingsDefaultValues.h	2018-04-16 19:45:27 UTC (rev 230679)
@@ -98,7 +98,7 @@
 static const bool defaultSmartInsertDeleteEnabled = true;
 static const bool defaultSelectTrailingWhitespaceEnabled = false;
 
-#if ENABLE(VIDEO) && (USE(AVFOUNDATION) || USE(GSTREAMER))
+#if ENABLE(VIDEO) && (USE(AVFOUNDATION) || USE(GSTREAMER) || USE(MEDIA_FOUNDATION))
 static const bool defaultMediaEnabled = true;
 #else
 static const bool defaultMediaEnabled = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230678] trunk/Source/WebCore

2018-04-16 Thread commit-queue

Title: [230678] trunk/Source/WebCore








Revision 230678
Author commit-qu...@webkit.org
Date 2018-04-16 12:22:17 -0700 (Mon, 16 Apr 2018)


Log Message
[Curl] Add the Accept-Language field to curl request headers
https://bugs.webkit.org/show_bug.cgi?id=184605

Patch by Christopher Reid  on 2018-04-16
Reviewed by Alex Christensen.

Add Accept-Language field to curl request headers

* platform/network/curl/CurlRequest.cpp:
* platform/network/curl/CurlRequest.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp
trunk/Source/WebCore/platform/network/curl/CurlRequest.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (230677 => 230678)

--- trunk/Source/WebCore/ChangeLog	2018-04-16 19:20:17 UTC (rev 230677)
+++ trunk/Source/WebCore/ChangeLog	2018-04-16 19:22:17 UTC (rev 230678)
@@ -1,3 +1,15 @@
+2018-04-16  Christopher Reid  
+
+[Curl] Add the Accept-Language field to curl request headers
+https://bugs.webkit.org/show_bug.cgi?id=184605
+
+Reviewed by Alex Christensen.
+
+Add Accept-Language field to curl request headers
+
+* platform/network/curl/CurlRequest.cpp:
+* platform/network/curl/CurlRequest.h:
+
 2018-04-16  Chris Dumez  
 
 Move more WindowProxy-related logic from ScriptController to WindowProxyController


Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp (230677 => 230678)

--- trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp	2018-04-16 19:20:17 UTC (rev 230677)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.cpp	2018-04-16 19:22:17 UTC (rev 230678)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2017 Sony Interactive Entertainment Inc.
+ * Copyright (C) 2018 Sony Interactive Entertainment Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -33,6 +33,7 @@
 #include "MIMETypeRegistry.h"
 #include "ResourceError.h"
 #include "SharedBuffer.h"
+#include 
 #include 
 
 namespace WebCore {
@@ -163,11 +164,14 @@
 {
 auto& sslHandle = CurlContext::singleton().sslHandle();
 
+auto httpHeaderFields = m_request.httpHeaderFields();
+appendAcceptLanguageHeader(httpHeaderFields);
+
 m_curlHandle = std::make_unique();
 
 m_curlHandle->initialize();
 m_curlHandle->setUrl(m_request.url());
-m_curlHandle->appendRequestHeaders(m_request.httpHeaderFields());
+m_curlHandle->appendRequestHeaders(httpHeaderFields);
 
 const auto& method = m_request.httpMethod();
 if (method == "GET")
@@ -453,6 +457,12 @@
 m_curlHandle = nullptr;
 }
 
+void CurlRequest::appendAcceptLanguageHeader(HTTPHeaderMap& header)
+{
+for (const auto& language : userPreferredLanguages())
+header.add(HTTPHeaderName::AcceptLanguage, language);
+}
+
 void CurlRequest::setupPUT(ResourceRequest& request)
 {
 m_curlHandle->enableHttpPutRequest();


Modified: trunk/Source/WebCore/platform/network/curl/CurlRequest.h (230677 => 230678)

--- trunk/Source/WebCore/platform/network/curl/CurlRequest.h	2018-04-16 19:20:17 UTC (rev 230677)
+++ trunk/Source/WebCore/platform/network/curl/CurlRequest.h	2018-04-16 19:22:17 UTC (rev 230678)
@@ -118,7 +118,8 @@
 void didCancelTransfer() override;
 void finalizeTransfer();
 
-// For POST and PUT method 
+// For setup 
+void appendAcceptLanguageHeader(HTTPHeaderMap&);
 void setupPOST(ResourceRequest&);
 void setupPUT(ResourceRequest&);
 void setupSendData(bool forPutMethod);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230676] trunk/Source/WebCore

2018-04-16 Thread cdumez

Title: [230676] trunk/Source/WebCore








Revision 230676
Author cdu...@apple.com
Date 2018-04-16 12:02:40 -0700 (Mon, 16 Apr 2018)


Log Message
Move more WindowProxy-related logic from ScriptController to WindowProxyController
https://bugs.webkit.org/show_bug.cgi?id=184640

Reviewed by Ryosuke Niwa.

Move more WindowProxy-related logic from ScriptController to WindowProxyController,
for clarity.

* bindings/js/JSDOMWindowProxy.cpp:
(WebCore::JSDOMWindowProxy::attachDebugger):
* bindings/js/JSDOMWindowProxy.h:
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::initScriptForWindowProxy):
* bindings/js/ScriptController.h:
(WebCore::ScriptController::existingCacheableBindingRootObject const):
* bindings/js/WindowProxyController.cpp:
(WebCore::collectGarbageAfterWindowProxyDestruction):
(WebCore::WindowProxyController::~WindowProxyController):
(WebCore::WindowProxyController::clearWindowProxiesNotMatchingDOMWindow):
(WebCore::WindowProxyController::setDOMWindowForWindowProxy):
(WebCore::WindowProxyController::attachDebugger):
* bindings/js/WindowProxyController.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
* page/Page.cpp:
(WebCore::Page::setDebugger):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.h
trunk/Source/WebCore/bindings/js/ScriptCachedFrameData.cpp
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/bindings/js/ScriptController.h
trunk/Source/WebCore/bindings/js/WindowProxyController.cpp
trunk/Source/WebCore/bindings/js/WindowProxyController.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/page/Page.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230675 => 230676)

--- trunk/Source/WebCore/ChangeLog	2018-04-16 18:53:50 UTC (rev 230675)
+++ trunk/Source/WebCore/ChangeLog	2018-04-16 19:02:40 UTC (rev 230676)
@@ -1,3 +1,36 @@
+2018-04-16  Chris Dumez  
+
+Move more WindowProxy-related logic from ScriptController to WindowProxyController
+https://bugs.webkit.org/show_bug.cgi?id=184640
+
+Reviewed by Ryosuke Niwa.
+
+Move more WindowProxy-related logic from ScriptController to WindowProxyController,
+for clarity.
+
+* bindings/js/JSDOMWindowProxy.cpp:
+(WebCore::JSDOMWindowProxy::attachDebugger):
+* bindings/js/JSDOMWindowProxy.h:
+* bindings/js/ScriptCachedFrameData.cpp:
+(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
+(WebCore::ScriptCachedFrameData::restore):
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::~ScriptController):
+(WebCore::ScriptController::initScriptForWindowProxy):
+* bindings/js/ScriptController.h:
+(WebCore::ScriptController::existingCacheableBindingRootObject const):
+* bindings/js/WindowProxyController.cpp:
+(WebCore::collectGarbageAfterWindowProxyDestruction):
+(WebCore::WindowProxyController::~WindowProxyController):
+(WebCore::WindowProxyController::clearWindowProxiesNotMatchingDOMWindow):
+(WebCore::WindowProxyController::setDOMWindowForWindowProxy):
+(WebCore::WindowProxyController::attachDebugger):
+* bindings/js/WindowProxyController.h:
+* loader/FrameLoader.cpp:
+(WebCore::FrameLoader::clear):
+* page/Page.cpp:
+(WebCore::Page::setDebugger):
+
 2018-04-16  Thibault Saunier  
 
 [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.cpp (230675 => 230676)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.cpp	2018-04-16 18:53:50 UTC (rev 230675)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.cpp	2018-04-16 19:02:40 UTC (rev 230676)
@@ -105,6 +105,17 @@
 ASSERT(prototype->globalObject() == );
 }
 
+void JSDOMWindowProxy::attachDebugger(JSC::Debugger* debugger)
+{
+auto* globalObject = window();
+JSLockHolder lock(globalObject->vm());
+
+if (debugger)
+debugger->attach(globalObject);
+else if (auto* currentDebugger = globalObject->debugger())
+currentDebugger->detach(globalObject, JSC::Debugger::TerminatingDebuggingSession);
+}
+
 DOMWindow& JSDOMWindowProxy::wrapped() const
 {
 return window()->wrapped();


Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.h (230675 => 230676)

--- trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.h	2018-04-16 18:53:50 UTC (rev 230675)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.h	2018-04-16 19:02:40 UTC (rev 230676)
@@ -31,6 +31,10 @@
 #include "JSDOMWindow.h"
 #include <_javascript_Core/JSProxy.h>
 
+namespace JSC {

[webkit-changes] [230677] trunk/Source/WTF

2018-04-16 Thread pvollan

Title: [230677] trunk/Source/WTF








Revision 230677
Author pvol...@apple.com
Date 2018-04-16 12:20:17 -0700 (Mon, 16 Apr 2018)


Log Message
Deactivate the WindowServer connection for the WebContent process.
https://bugs.webkit.org/show_bug.cgi?id=184451


Reviewed by Brent Fulgham.

Defining ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING as 1 will deactivate the WindowServer connection
for the WebContent process by enabling the call to 'CGSSetDenyWindowServerConnections(true)' on
process startup. After calling this function, every attempt to establish a connection to the
WindowServer from the WebContent process will fail, except for CA render server connections.

* wtf/FeatureDefines.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h




Diff

Modified: trunk/Source/WTF/ChangeLog (230676 => 230677)

--- trunk/Source/WTF/ChangeLog	2018-04-16 19:02:40 UTC (rev 230676)
+++ trunk/Source/WTF/ChangeLog	2018-04-16 19:20:17 UTC (rev 230677)
@@ -1,3 +1,18 @@
+2018-04-16  Per Arne Vollan  
+
+Deactivate the WindowServer connection for the WebContent process.
+https://bugs.webkit.org/show_bug.cgi?id=184451
+
+
+Reviewed by Brent Fulgham.
+
+Defining ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING as 1 will deactivate the WindowServer connection
+for the WebContent process by enabling the call to 'CGSSetDenyWindowServerConnections(true)' on
+process startup. After calling this function, every attempt to establish a connection to the
+WindowServer from the WebContent process will fail, except for CA render server connections.
+
+* wtf/FeatureDefines.h:
+
 2018-04-14  Commit Queue  
 
 Unreviewed, rolling out r230659.


Modified: trunk/Source/WTF/wtf/FeatureDefines.h (230676 => 230677)

--- trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-16 19:02:40 UTC (rev 230676)
+++ trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-16 19:20:17 UTC (rev 230677)
@@ -238,7 +238,7 @@
 #endif
 
 #if !defined(ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING)
-#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0
+#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
 #endif
 
 #endif /* PLATFORM(MAC) */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230683] tags/Safari-606.1.13.1

2018-04-16 Thread kocsen_chung

Title: [230683] tags/Safari-606.1.13.1








Revision 230683
Author kocsen_ch...@apple.com
Date 2018-04-16 14:52:30 -0700 (Mon, 16 Apr 2018)


Log Message
Cherry-pick r230665. rdar://problem/39397649

[Web Animations] Animations do not naturally get a finish event
https://bugs.webkit.org/show_bug.cgi?id=184639


Reviewed by Jon Lee.

LayoutTests/imported/w3c:

Record two progressions in the Web Animations WPT tests.

* web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:

Source/WebCore:

We must call updateFinishedState() when an animation gets sampled as it means its timeline's time has progressed
and it may have crossed to a finished state. Calling updateFinishedState() when sampling means that we'll correctly
set the animation's hold time to its end value, which means that currentTime() will now always be clamped to return
the end time once its has reached it, so we must not schedule animations to resolve immediately anymore since otherwise
they will keep being scheduled in a loop.

* animation/WebAnimation.cpp:
(WebCore::WebAnimation::timeToNextRequiredTick const):
(WebCore::WebAnimation::resolve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog
tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt
tags/Safari-606.1.13.1/Source/WebCore/ChangeLog
tags/Safari-606.1.13.1/Source/WebCore/animation/WebAnimation.cpp




Diff

Modified: tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog (230682 => 230683)

--- tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog	2018-04-16 21:52:24 UTC (rev 230682)
+++ tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog	2018-04-16 21:52:30 UTC (rev 230683)
@@ -1,3 +1,45 @@
+2018-04-16  Kocsen Chung  
+
+Cherry-pick r230665. rdar://problem/39397649
+
+[Web Animations] Animations do not naturally get a finish event
+https://bugs.webkit.org/show_bug.cgi?id=184639
+
+
+Reviewed by Jon Lee.
+
+LayoutTests/imported/w3c:
+
+Record two progressions in the Web Animations WPT tests.
+
+* web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
+
+Source/WebCore:
+
+We must call updateFinishedState() when an animation gets sampled as it means its timeline's time has progressed
+and it may have crossed to a finished state. Calling updateFinishedState() when sampling means that we'll correctly
+set the animation's hold time to its end value, which means that currentTime() will now always be clamped to return
+the end time once its has reached it, so we must not schedule animations to resolve immediately anymore since otherwise
+they will keep being scheduled in a loop.
+
+* animation/WebAnimation.cpp:
+(WebCore::WebAnimation::timeToNextRequiredTick const):
+(WebCore::WebAnimation::resolve):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-04-15  Antoine Quint  
+
+[Web Animations] Animations do not naturally get a finish event
+https://bugs.webkit.org/show_bug.cgi?id=184639
+
+
+Reviewed by Jon Lee.
+
+Record two progressions in the Web Animations WPT tests.
+
+* web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:
+
 2018-04-09  Brendan McLoughlin  
 
 sync remaining web-platform-tests to 94b33b573a069ae5170104ca581a354a35762536


Modified: tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt (230682 => 230683)

--- tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt	2018-04-16 21:52:24 UTC (rev 230682)
+++ tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt	2018-04-16 21:52:30 UTC (rev 230683)
@@ -1,8 +1,8 @@
 
-FAIL Updating the finished state when playing past end assert_equals: Hold time is set to target end clamping current time expected 10 but got 100029
+PASS Updating the finished state when playing past end 
 PASS Updating the finished state when seeking past end 
 PASS Updating the finished state when seeking exactly to end 
-FAIL Updating the finished state when playing in reverse past zero assert_equals: Hold time is set to zero clamping current time expected 0 but got -15
+PASS Updating the finished state when playing in reverse past zero

[webkit-changes] [230682] tags/Safari-606.1.13.1/Source

2018-04-16 Thread kocsen_chung

Title: [230682] tags/Safari-606.1.13.1/Source








Revision 230682
Author kocsen_ch...@apple.com
Date 2018-04-16 14:52:24 -0700 (Mon, 16 Apr 2018)


Log Message
Cherry-pick r230521. rdar://problem/39344671

[Web Animations] Turn Web Animations on by default
https://bugs.webkit.org/show_bug.cgi?id=184491

Patch by Antoine Quint  on 2018-04-11
Reviewed by Simon Fraser.

Source/WebCore:

* page/RuntimeEnabledFeatures.h:

Source/WebKit:

* Shared/WebPreferences.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

tags/Safari-606.1.13.1/Source/WebCore/ChangeLog
tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h
tags/Safari-606.1.13.1/Source/WebKit/ChangeLog
tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml




Diff

Modified: tags/Safari-606.1.13.1/Source/WebCore/ChangeLog (230681 => 230682)

--- tags/Safari-606.1.13.1/Source/WebCore/ChangeLog	2018-04-16 21:50:26 UTC (rev 230681)
+++ tags/Safari-606.1.13.1/Source/WebCore/ChangeLog	2018-04-16 21:52:24 UTC (rev 230682)
@@ -1,3 +1,32 @@
+2018-04-16  Kocsen Chung  
+
+Cherry-pick r230521. rdar://problem/39344671
+
+[Web Animations] Turn Web Animations on by default
+https://bugs.webkit.org/show_bug.cgi?id=184491
+
+Patch by Antoine Quint  on 2018-04-11
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+* page/RuntimeEnabledFeatures.h:
+
+Source/WebKit:
+
+* Shared/WebPreferences.yaml:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-04-11  Antoine Quint  
+
+[Web Animations] Turn Web Animations on by default
+https://bugs.webkit.org/show_bug.cgi?id=184491
+
+Reviewed by Simon Fraser.
+
+* page/RuntimeEnabledFeatures.h:
+
 2018-04-12  Kocsen Chung  
 
 Revert r230521. rdar://problem/39399564


Modified: tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h (230681 => 230682)

--- tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-04-16 21:50:26 UTC (rev 230681)
+++ tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-04-16 21:52:24 UTC (rev 230682)
@@ -336,7 +336,7 @@
 bool m_isWritableStreamAPIEnabled { false };
 #endif
 
-bool m_areWebAnimationsEnabled { false };
+bool m_areWebAnimationsEnabled { true };
 bool m_areCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled { false };
 
 #if ENABLE(WEBGL2)


Modified: tags/Safari-606.1.13.1/Source/WebKit/ChangeLog (230681 => 230682)

--- tags/Safari-606.1.13.1/Source/WebKit/ChangeLog	2018-04-16 21:50:26 UTC (rev 230681)
+++ tags/Safari-606.1.13.1/Source/WebKit/ChangeLog	2018-04-16 21:52:24 UTC (rev 230682)
@@ -1,3 +1,32 @@
+2018-04-16  Kocsen Chung  
+
+Cherry-pick r230521. rdar://problem/39344671
+
+[Web Animations] Turn Web Animations on by default
+https://bugs.webkit.org/show_bug.cgi?id=184491
+
+Patch by Antoine Quint  on 2018-04-11
+Reviewed by Simon Fraser.
+
+Source/WebCore:
+
+* page/RuntimeEnabledFeatures.h:
+
+Source/WebKit:
+
+* Shared/WebPreferences.yaml:
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-04-11  Antoine Quint  
+
+[Web Animations] Turn Web Animations on by default
+https://bugs.webkit.org/show_bug.cgi?id=184491
+
+Reviewed by Simon Fraser.
+
+* Shared/WebPreferences.yaml:
+
 2018-04-12  Kocsen Chung  
 
 Revert r230521. rdar://problem/39399564


Modified: tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml (230681 => 230682)

--- tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml	2018-04-16 21:50:26 UTC (rev 230681)
+++ tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml	2018-04-16 21:52:24 UTC (rev 230682)
@@ -1173,7 +1173,7 @@
 
 WebAnimationsEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "Web Animations"
   humanReadableDescription: "Web Animations prototype"
   category: experimental






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230681] trunk

2018-04-16 Thread youenn

Title: [230681] trunk








Revision 230681
Author you...@apple.com
Date 2018-04-16 14:50:26 -0700 (Mon, 16 Apr 2018)


Log Message
Use NetworkLoadChecker to handle synchronous HTTP loads
https://bugs.webkit.org/show_bug.cgi?id=184240

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/cors/request-headers-expected.txt:
* web-platform-tests/XMLHttpRequest/access-control-and-redirects-expected.txt:
* web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt:
* web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt:

Source/WebCore:

Update LoaderStrategy::loadResourceSynchronously to pass FetchOptions directly.
Update various call sites accordingly. This allows NetworkProcess to do all necessary checks.
Add an option to disable security checks if NetworkProcess does it for WebProcess.
This option will be also used for regular asynchronous loads in future patches.

Update DocumentThreadableLoader to bypass preflighting and response validation checks in case they are done in NetworkProcess.

Covered by existing and rebased tests.

* loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::doPreflight):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::loadRequest):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/FrameLoader.h:
* loader/LoaderStrategy.h:
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::docLoaderFunc):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::openFunc):

Source/WebKit:

For every NetworkResourceLoader synchronous load, we create a NetworkLoadChecker.
NetworkLoadChecker handles all security checks in that case.
This allows supporting cross-origin loads for synchronous XHR.

Updated NetworkCORSPreflightChecker to return the result as a ResourceError.
This is used to convey any error message from NetworkProcess to the JS console.
Ensure NetworkCORSPreflightChecker computes correctly Access-Control-Request-Headers value
by providing the headers set by the application plus Referrer/Origin.

* NetworkProcess/NetworkCORSPreflightChecker.cpp:
(WebKit::NetworkCORSPreflightChecker::~NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):
* NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::validateCacheEntry):
* NetworkProcess/NetworkResourceLoader.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::loadResourceSynchronously):
* WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

* http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt:
* http/wpt/beacon/cors/cors-preflight-blob-failure.html: Fix buggy assertion.
Test should check for actual request header and not header name in Access-Control-Request-Headers.
* http/wpt/beacon/cors/cors-preflight-blob-success.html: Ditto.
* platform/mac-wk1/http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
* platform/mac-wk1/http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt: Added.
* platform/mac-wk1/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
* platform/mac-wk1/imported/w3c/web-platform-tests/XMLHttpRequest/access-control-and-redirects-expected.txt: Added.
* platform/win/http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
* platform/win/http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt: Added.
* platform/win/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
* platform/mac-highsierra-wk2/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt.
* platform/mac-highsierra-wk2/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt: Copied from

[webkit-changes] [230687] trunk/Source/ThirdParty/libwebrtc

2018-04-16 Thread youenn

Title: [230687] trunk/Source/ThirdParty/libwebrtc








Revision 230687
Author you...@apple.com
Date 2018-04-16 15:59:04 -0700 (Mon, 16 Apr 2018)


Log Message
Set H264 VT encoder usage to 1
https://bugs.webkit.org/show_bug.cgi?id=184668

Reviewed by Eric Carlson.

* Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 configureCompressionSession]):

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (230686 => 230687)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-04-16 22:46:47 UTC (rev 230686)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2018-04-16 22:59:04 UTC (rev 230687)
@@ -1,3 +1,13 @@
+2018-04-16  Youenn Fablet  
+
+Set H264 VT encoder usage to 1
+https://bugs.webkit.org/show_bug.cgi?id=184668
+
+Reviewed by Eric Carlson.
+
+* Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:
+(-[RTCVideoEncoderH264 configureCompressionSession]):
+
 2018-04-10  Youenn Fablet  
 
 webrtc/datachannel/basic-tcp.html will crash with an invalid crash


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm (230686 => 230687)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm	2018-04-16 22:46:47 UTC (rev 230686)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm	2018-04-16 22:59:04 UTC (rev 230687)
@@ -38,7 +38,6 @@
 #include "sdk/WebKit/EncoderUtilities.h"
 #include "sdk/WebKit/WebKitUtilities.h"
 
-#if !ENABLE_VCP_ENCODER && !defined(WEBRTC_IOS)
 #import 
 #import 
 
@@ -45,6 +44,7 @@
 SOFT_LINK_FRAMEWORK_OPTIONAL(VideoToolBox)
 SOFT_LINK_POINTER_OPTIONAL(VideoToolBox, kVTVideoEncoderSpecification_Usage, NSString *)
 
+#if !ENABLE_VCP_ENCODER && !defined(WEBRTC_IOS)
 static inline bool isStandardFrameSize(int32_t width, int32_t height)
 {
 // FIXME: Envision relaxing this rule, something like width and height dividable by 4 or 8 should be good enough.
@@ -733,6 +733,9 @@
   SetVTSessionProperty(_compressionSession, kVTCompressionPropertyKey_RealTime, true);
   SetVTSessionProperty(_compressionSession, kVTCompressionPropertyKey_ProfileLevel, _profile);
   SetVTSessionProperty(_compressionSession, kVTCompressionPropertyKey_AllowFrameReordering, false);
+#if ENABLE_VCP_ENCODER
+  SetVTSessionProperty(_compressionSession, (__bridge CFStringRef)getkVTVideoEncoderSpecification_Usage(), 1);
+#endif
   [self setEncoderBitrateBps:_targetBitrateBps];
   // TODO(tkchin): Look at entropy mode and colorspace matrices.
   // TODO(tkchin): Investigate to see if there's any way to make this work.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230685] tags/Safari-606.1.13.1

2018-04-16 Thread kocsen_chung

Title: [230685] tags/Safari-606.1.13.1








Revision 230685
Author kocsen_ch...@apple.com
Date 2018-04-16 15:29:59 -0700 (Mon, 16 Apr 2018)


Log Message
Revert r230683. rdar://problem/39397649

Modified Paths

tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog
tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt
tags/Safari-606.1.13.1/Source/WebCore/ChangeLog
tags/Safari-606.1.13.1/Source/WebCore/animation/WebAnimation.cpp




Diff

Modified: tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog (230684 => 230685)

--- tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog	2018-04-16 22:29:55 UTC (rev 230684)
+++ tags/Safari-606.1.13.1/LayoutTests/imported/w3c/ChangeLog	2018-04-16 22:29:59 UTC (rev 230685)
@@ -1,5 +1,9 @@
 2018-04-16  Kocsen Chung  
 
+Revert r230683. rdar://problem/39397649
+
+2018-04-16  Kocsen Chung  
+
 Cherry-pick r230665. rdar://problem/39397649
 
 [Web Animations] Animations do not naturally get a finish event


Modified: tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt (230684 => 230685)

--- tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt	2018-04-16 22:29:55 UTC (rev 230684)
+++ tags/Safari-606.1.13.1/LayoutTests/imported/w3c/web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt	2018-04-16 22:29:59 UTC (rev 230685)
@@ -1,8 +1,8 @@
 
-PASS Updating the finished state when playing past end 
+FAIL Updating the finished state when playing past end assert_equals: Hold time is set to target end clamping current time expected 10 but got 100029
 PASS Updating the finished state when seeking past end 
 PASS Updating the finished state when seeking exactly to end 
-PASS Updating the finished state when playing in reverse past zero 
+FAIL Updating the finished state when playing in reverse past zero assert_equals: Hold time is set to zero clamping current time expected 0 but got -15
 PASS Updating the finished state when seeking a reversed animation past zero 
 FAIL Updating the finished state when seeking a reversed animation exactly to zero assert_equals: Hold time is set so current time should NOT change expected 0 but got -0
 PASS Updating the finished state when playing before end 


Modified: tags/Safari-606.1.13.1/Source/WebCore/ChangeLog (230684 => 230685)

--- tags/Safari-606.1.13.1/Source/WebCore/ChangeLog	2018-04-16 22:29:55 UTC (rev 230684)
+++ tags/Safari-606.1.13.1/Source/WebCore/ChangeLog	2018-04-16 22:29:59 UTC (rev 230685)
@@ -1,5 +1,9 @@
 2018-04-16  Kocsen Chung  
 
+Revert r230683. rdar://problem/39397649
+
+2018-04-16  Kocsen Chung  
+
 Revert r230682. rdar://problem/39344671
 
 2018-04-16  Kocsen Chung  


Modified: tags/Safari-606.1.13.1/Source/WebCore/animation/WebAnimation.cpp (230684 => 230685)

--- tags/Safari-606.1.13.1/Source/WebCore/animation/WebAnimation.cpp	2018-04-16 22:29:55 UTC (rev 230684)
+++ tags/Safari-606.1.13.1/Source/WebCore/animation/WebAnimation.cpp	2018-04-16 22:29:59 UTC (rev 230685)
@@ -992,6 +992,11 @@
 if (localTime < 0_s)
 return -localTime;
 
+// If our current time is just at the acthive duration threshold we want to invalidate as
+// soon as possible to restore a non-animated value.
+if (std::abs(localTime.microseconds() - m_effect->timing()->activeDuration().microseconds()) < timeEpsilon.microseconds())
+return 0_s;
+
 // In any other case, we're idle or already outside our active duration and have no need
 // to schedule an invalidation.
 return Seconds::infinity();
@@ -1001,8 +1006,6 @@
 {
 if (m_effect)
 m_effect->apply(targetStyle);
-
-updateFinishedState(DidSeek::No, SynchronouslyNotify::Yes);
 }
 
 void WebAnimation::acceleratedRunningStateDidChange()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230684] tags/Safari-606.1.13.1/Source

2018-04-16 Thread kocsen_chung

Title: [230684] tags/Safari-606.1.13.1/Source








Revision 230684
Author kocsen_ch...@apple.com
Date 2018-04-16 15:29:55 -0700 (Mon, 16 Apr 2018)


Log Message
Revert r230682. rdar://problem/39344671

Modified Paths

tags/Safari-606.1.13.1/Source/WebCore/ChangeLog
tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h
tags/Safari-606.1.13.1/Source/WebKit/ChangeLog
tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml




Diff

Modified: tags/Safari-606.1.13.1/Source/WebCore/ChangeLog (230683 => 230684)

--- tags/Safari-606.1.13.1/Source/WebCore/ChangeLog	2018-04-16 21:52:30 UTC (rev 230683)
+++ tags/Safari-606.1.13.1/Source/WebCore/ChangeLog	2018-04-16 22:29:55 UTC (rev 230684)
@@ -1,5 +1,9 @@
 2018-04-16  Kocsen Chung  
 
+Revert r230682. rdar://problem/39344671
+
+2018-04-16  Kocsen Chung  
+
 Cherry-pick r230665. rdar://problem/39397649
 
 [Web Animations] Animations do not naturally get a finish event


Modified: tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h (230683 => 230684)

--- tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-04-16 21:52:30 UTC (rev 230683)
+++ tags/Safari-606.1.13.1/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-04-16 22:29:55 UTC (rev 230684)
@@ -336,7 +336,7 @@
 bool m_isWritableStreamAPIEnabled { false };
 #endif
 
-bool m_areWebAnimationsEnabled { true };
+bool m_areWebAnimationsEnabled { false };
 bool m_areCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled { false };
 
 #if ENABLE(WEBGL2)


Modified: tags/Safari-606.1.13.1/Source/WebKit/ChangeLog (230683 => 230684)

--- tags/Safari-606.1.13.1/Source/WebKit/ChangeLog	2018-04-16 21:52:30 UTC (rev 230683)
+++ tags/Safari-606.1.13.1/Source/WebKit/ChangeLog	2018-04-16 22:29:55 UTC (rev 230684)
@@ -1,5 +1,9 @@
 2018-04-16  Kocsen Chung  
 
+Revert r230682. rdar://problem/39344671
+
+2018-04-16  Kocsen Chung  
+
 Cherry-pick r230521. rdar://problem/39344671
 
 [Web Animations] Turn Web Animations on by default


Modified: tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml (230683 => 230684)

--- tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml	2018-04-16 21:52:30 UTC (rev 230683)
+++ tags/Safari-606.1.13.1/Source/WebKit/Shared/WebPreferences.yaml	2018-04-16 22:29:55 UTC (rev 230684)
@@ -1173,7 +1173,7 @@
 
 WebAnimationsEnabled:
   type: bool
-  defaultValue: true
+  defaultValue: false
   humanReadableName: "Web Animations"
   humanReadableDescription: "Web Animations prototype"
   category: experimental






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230686] trunk

2018-04-16 Thread megan_gardner

Title: [230686] trunk








Revision 230686
Author megan_gard...@apple.com
Date 2018-04-16 15:46:47 -0700 (Mon, 16 Apr 2018)


Log Message
Switch to UIWKTextInteractionAssistant for non-editable text
https://bugs.webkit.org/show_bug.cgi?id=182834

Reviewed by Beth Dakin.

Source/WebKit:

Switch to only using one assistant for text selection.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView useSelectionAssistantWithGranularity:]):

LayoutTests:

Marking tests as flaky and to be fixed later.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (230685 => 230686)

--- trunk/LayoutTests/ChangeLog	2018-04-16 22:29:59 UTC (rev 230685)
+++ trunk/LayoutTests/ChangeLog	2018-04-16 22:46:47 UTC (rev 230686)
@@ -1,3 +1,14 @@
+2018-04-16  Megan Gardner  
+
+Switch to UIWKTextInteractionAssistant for non-editable text
+https://bugs.webkit.org/show_bug.cgi?id=182834
+
+Reviewed by Beth Dakin.
+
+Marking tests as flaky and to be fixed later.
+
+* platform/ios-wk2/TestExpectations:
+
 2018-04-16  Youenn Fablet  
 
 Use NetworkLoadChecker to handle synchronous HTTP loads


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (230685 => 230686)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-04-16 22:29:59 UTC (rev 230685)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-04-16 22:46:47 UTC (rev 230686)
@@ -1347,3 +1347,9 @@
 webkit.org/b/183860 [ Release ] http/wpt/service-workers/third-party-registration.html [ Skip ]
 
 webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
+
+#FIXME: Tests that fail when run after fast/events/ios/double-tap-zoom.html with UIWKTextInteractionAssistant turned on
+fast/flexbox/flexbox-fail-to-select-same-line.html [ ImageOnlyFailure Pass ]
+fast/text/international/hebrew-selection.html [ ImageOnlyFailure Pass ]
+imported/blink/editing/style/justify-left-crash.html [ ImageOnlyFailure Pass ]
+imported/blink/fast/css/user-select-none.html [ ImageOnlyFailure Pass ]


Modified: trunk/Source/WebKit/ChangeLog (230685 => 230686)

--- trunk/Source/WebKit/ChangeLog	2018-04-16 22:29:59 UTC (rev 230685)
+++ trunk/Source/WebKit/ChangeLog	2018-04-16 22:46:47 UTC (rev 230686)
@@ -1,3 +1,15 @@
+2018-04-16  Megan Gardner  
+
+Switch to UIWKTextInteractionAssistant for non-editable text
+https://bugs.webkit.org/show_bug.cgi?id=182834
+
+Reviewed by Beth Dakin.
+
+Switch to only using one assistant for text selection.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView useSelectionAssistantWithGranularity:]):
+
 2018-04-16  Youenn Fablet  
 
 Use NetworkLoadChecker to handle synchronous HTTP loads


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (230685 => 230686)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-04-16 22:29:59 UTC (rev 230685)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-04-16 22:46:47 UTC (rev 230686)
@@ -1902,30 +1902,17 @@
 
 - (void)useSelectionAssistantWithGranularity:(WKSelectionGranularity)selectionGranularity
 {
-#if ENABLE(UNIFIED_TEXT_SELECTION)
-selectionGranularity = WKSelectionGranularityCharacter;
-#endif
-if (selectionGranularity == WKSelectionGranularityDynamic) {
-if (_textSelectionAssistant) {
-[_textSelectionAssistant deactivateSelection];
-_textSelectionAssistant = nil;
-}
-if (!_webSelectionAssistant)
-_webSelectionAssistant = adoptNS([[UIWKSelectionAssistant alloc] initWithView:self]);
-} else if (selectionGranularity == WKSelectionGranularityCharacter) {
-if (_webSelectionAssistant)
-_webSelectionAssistant = nil;
+_webSelectionAssistant = nil;
 
-if (!_textSelectionAssistant)
-_textSelectionAssistant = adoptNS([[UIWKTextInteractionAssistant alloc] initWithView:self]);
-else {
-// Reset the gesture recognizers in case editibility has changed.
-[_textSelectionAssistant setGestureRecognizers];
-}
+if (!_textSelectionAssistant)
+_textSelectionAssistant = adoptNS([[UIWKTextInteractionAssistant alloc] initWithView:self]);
+else {
+// Reset the gesture recognizers in case editibility has changed.
+[_textSelectionAssistant setGestureRecognizers];
+}
 
-if (self.isFirstResponder && !self.suppressAssistantSelectionView)
-[_textSelectionAssistant activateSelection];
-}
+if (self.isFirstResponder && !self.suppressAssistantSelectionView)
+

[webkit-changes] [230666] trunk/Websites/perf.webkit.org

2018-04-16 Thread rniwa

Title: [230666] trunk/Websites/perf.webkit.org








Revision 230666
Author rn...@webkit.org
Date 2018-04-15 23:58:36 -0700 (Sun, 15 Apr 2018)


Log Message
Make it possible to hide some repository groups
https://bugs.webkit.org/show_bug.cgi?id=184632

Reviewed by Saam Barati.

Added the ability to hide repository groups in the custom analysis task configurator from the admin page.
Hidden repositroy groups will continue to function for existing test groups. This is purely an UI change.

* init-database.sql: Added repositorygroup_hidden as a new column to triggerable_repository_groups.
* public/admin/triggerables.php: Added a form field to hide a repository group.
* public/include/manifest-generator.php: Include hidden state in the manifest file.
* public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Filter out hidden repository groups.
* public/v3/models/triggerable.js:
(prototype.isHidden): Added.
* server-tests/api-manifest-tests.js: Updated an existing test case to test a hidden repository group.

Modified Paths

trunk/Websites/perf.webkit.org/ChangeLog
trunk/Websites/perf.webkit.org/init-database.sql
trunk/Websites/perf.webkit.org/public/admin/triggerables.php
trunk/Websites/perf.webkit.org/public/include/manifest-generator.php
trunk/Websites/perf.webkit.org/public/v3/components/custom-analysis-task-configurator.js
trunk/Websites/perf.webkit.org/public/v3/models/triggerable.js
trunk/Websites/perf.webkit.org/server-tests/api-manifest-tests.js




Diff

Modified: trunk/Websites/perf.webkit.org/ChangeLog (230665 => 230666)

--- trunk/Websites/perf.webkit.org/ChangeLog	2018-04-16 05:38:01 UTC (rev 230665)
+++ trunk/Websites/perf.webkit.org/ChangeLog	2018-04-16 06:58:36 UTC (rev 230666)
@@ -1,3 +1,22 @@
+2018-04-15  Ryosuke Niwa  
+
+Make it possible to hide some repository groups
+https://bugs.webkit.org/show_bug.cgi?id=184632
+
+Reviewed by Saam Barati.
+
+Added the ability to hide repository groups in the custom analysis task configurator from the admin page.
+Hidden repositroy groups will continue to function for existing test groups. This is purely an UI change.
+
+* init-database.sql: Added repositorygroup_hidden as a new column to triggerable_repository_groups.
+* public/admin/triggerables.php: Added a form field to hide a repository group.
+* public/include/manifest-generator.php: Include hidden state in the manifest file.
+* public/v3/components/custom-analysis-task-configurator.js:
+(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Filter out hidden repository groups.
+* public/v3/models/triggerable.js:
+(prototype.isHidden): Added.
+* server-tests/api-manifest-tests.js: Updated an existing test case to test a hidden repository group.
+
 2018-04-06  Dewei Zhu  
 
 Added 'CommitSet.diff' which will be shared between multiple independent incoming changes.


Modified: trunk/Websites/perf.webkit.org/init-database.sql (230665 => 230666)

--- trunk/Websites/perf.webkit.org/init-database.sql	2018-04-16 05:38:01 UTC (rev 230665)
+++ trunk/Websites/perf.webkit.org/init-database.sql	2018-04-16 06:58:36 UTC (rev 230666)
@@ -244,6 +244,7 @@
 repositorygroup_name varchar(256) NOT NULL,
 repositorygroup_description varchar(256),
 repositorygroup_accepts_roots boolean NOT NULL DEFAULT FALSE,
+repositorygroup_hidden boolean NOT NULL DEFAULT FALSE,
 CONSTRAINT repository_group_name_must_be_unique_for_triggerable UNIQUE(repositorygroup_triggerable, repositorygroup_name));
 
 CREATE TABLE triggerable_repositories (


Modified: trunk/Websites/perf.webkit.org/public/admin/triggerables.php (230665 => 230666)

--- trunk/Websites/perf.webkit.org/public/admin/triggerables.php	2018-04-16 05:38:01 UTC (rev 230665)
+++ trunk/Websites/perf.webkit.org/public/admin/triggerables.php	2018-04-16 06:58:36 UTC (rev 230666)
@@ -23,6 +23,9 @@
 } else if ($action == 'update-group-description') {
 if (update_field('triggerable_repository_groups', 'repositorygroup', 'description'))
 regenerate_manifest();
+} else if ($action == 'update-group-hidden') {
+if (update_field('triggerable_repository_groups', 'repositorygroup', 'hidden'))
+regenerate_manifest();
 } else if ($action == 'update-group-accept-roots') {
 if (update_field('triggerable_repository_groups', 'repositorygroup', 'accepts_roots',
 Database::to_database_boolean(array_get($_POST, 'accepts'
@@ -39,7 +42,7 @@
 regenerate_manifest();
 } else
 $db->rollback_transaction();
-}  else if ($action == 'update-accept-patch') {
+} else if ($action == 'update-accept-patch') {
 $group_id = intval($_POST['group']);
 $repositories_that_accepts_patch = array_get($_POST, 'repositories', array());
 
@@

[webkit-changes] [230693] tags/Safari-606.1.13.2/Source

2018-04-16 Thread kocsen_chung

Title: [230693] tags/Safari-606.1.13.2/Source








Revision 230693
Author kocsen_ch...@apple.com
Date 2018-04-16 17:19:33 -0700 (Mon, 16 Apr 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.13.2/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.13.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.13.2/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.13.2/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.13.2/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.13.2/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.13.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.13.2/Source/_javascript_Core/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.13.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.13.2/Source/WebCore/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/WebCore/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/WebCore/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.13.2/Source/WebCore/PAL/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.13.2/Source/WebInspectorUI/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.13.2/Source/WebKit/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/WebKit/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/WebKit/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: tags/Safari-606.1.13.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (230692 => 230693)

--- tags/Safari-606.1.13.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-04-17 00:17:42 UTC (rev 230692)
+++ tags/Safari-606.1.13.2/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-04-17 00:19:33 UTC (rev 230693)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 13;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230694] trunk

2018-04-16 Thread aestes

Title: [230694] trunk








Revision 230694
Author aes...@apple.com
Date 2018-04-16 18:20:43 -0700 (Mon, 16 Apr 2018)


Log Message
[iOS] Enable WKPDFView by default
https://bugs.webkit.org/show_bug.cgi?id=184675


Reviewed by Darin Adler.

Source/WebKit:

* UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry init]):

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (230693 => 230694)

--- trunk/Source/WTF/ChangeLog	2018-04-17 00:19:33 UTC (rev 230693)
+++ trunk/Source/WTF/ChangeLog	2018-04-17 01:20:43 UTC (rev 230694)
@@ -1,3 +1,13 @@
+2018-04-16  Andy Estes  
+
+[iOS] Enable WKPDFView by default
+https://bugs.webkit.org/show_bug.cgi?id=184675
+
+
+Reviewed by Darin Adler.
+
+* wtf/FeatureDefines.h:
+
 2018-04-16  Per Arne Vollan  
 
 Deactivate the WindowServer connection for the WebContent process.


Modified: trunk/Source/WTF/wtf/FeatureDefines.h (230693 => 230694)

--- trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-17 00:19:33 UTC (rev 230693)
+++ trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-17 01:20:43 UTC (rev 230694)
@@ -167,7 +167,7 @@
 #endif
 
 #if !defined(ENABLE_WKLEGACYPDFVIEW)
-#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !ENABLE(MINIMAL_SIMULATOR)
+#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !ENABLE(MINIMAL_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 12
 #define ENABLE_WKLEGACYPDFVIEW 1
 #endif
 #endif


Modified: trunk/Source/WebKit/ChangeLog (230693 => 230694)

--- trunk/Source/WebKit/ChangeLog	2018-04-17 00:19:33 UTC (rev 230693)
+++ trunk/Source/WebKit/ChangeLog	2018-04-17 01:20:43 UTC (rev 230694)
@@ -1,3 +1,14 @@
+2018-04-16  Andy Estes  
+
+[iOS] Enable WKPDFView by default
+https://bugs.webkit.org/show_bug.cgi?id=184675
+
+
+Reviewed by Darin Adler.
+
+* UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
+(-[WKWebViewContentProviderRegistry init]):
+
 2018-04-16  Brent Fulgham  
 
 [macOS] Don't establish unneeded Dock connections


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm (230693 => 230694)

--- trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm	2018-04-17 00:19:33 UTC (rev 230693)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm	2018-04-17 01:20:43 UTC (rev 230694)
@@ -31,6 +31,7 @@
 #if PLATFORM(IOS)
 
 #import "WKLegacyPDFView.h"
+#import "WKPDFView.h"
 #import "WKSystemPreviewView.h"
 #import "WKWebViewInternal.h"
 #import "WebPageProxy.h"
@@ -56,8 +57,11 @@
 if (!(self = [super init]))
 return nil;
 
-#if ENABLE(WKLEGACYPDFVIEW)
+#if ENABLE(WKPDFVIEW)
 for (auto& mimeType : WebCore::MIMETypeRegistry::getPDFMIMETypes())
+[self registerProvider:[WKPDFView class] forMIMEType:mimeType];
+#elif ENABLE(WKLEGACYPDFVIEW)
+for (auto& mimeType : WebCore::MIMETypeRegistry::getPDFMIMETypes())
 [self registerProvider:[WKLegacyPDFView class] forMIMEType:mimeType];
 #endif
 


Modified: trunk/Tools/ChangeLog (230693 => 230694)

--- trunk/Tools/ChangeLog	2018-04-17 00:19:33 UTC (rev 230693)
+++ trunk/Tools/ChangeLog	2018-04-17 01:20:43 UTC (rev 230694)
@@ -1,3 +1,13 @@
+2018-04-16  Andy Estes  
+
+[iOS] Enable WKPDFView by default
+https://bugs.webkit.org/show_bug.cgi?id=184675
+
+
+Reviewed by Darin Adler.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
+
 2018-04-16  Leo Balter  
 
 Perl-based Test262 runner


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm (230693 => 230694)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm	2018-04-17 00:19:33 UTC (rev 230693)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm	2018-04-17 01:20:43 UTC (rev 230694)
@@ -26,7 +26,8 @@
 #import "config.h"
 #import 
 
-#if WK_API_ENABLED && TARGET_OS_IPHONE
+// FIXME: Enable these tests on iOS 12 once rdar://problem/39475542 is resolved.
+#if WK_API_ENABLED && TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED < 12
 
 #import "PlatformUtilities.h"
 #import "TestNavigationDelegate.h"






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230689] trunk/Source

2018-04-16 Thread bfulgham

Title: [230689] trunk/Source








Revision 230689
Author bfulg...@apple.com
Date 2018-04-16 16:43:05 -0700 (Mon, 16 Apr 2018)


Log Message
[macOS] Don't establish unneeded Dock connections
https://bugs.webkit.org/show_bug.cgi?id=184664


Reviewed by Simon Fraser.

There is no reason for the WebContent or Plugin processes to interact with
the Dock. We should tell AppKit that we don't want this connection, and to
avoid creating such connections.

Source/WebCore/PAL:

* pal/spi/mac/NSApplicationSPI.h: Add Dock connection declaration.

Source/WebKit:

* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializeProcess): Tell NSApplication to
not create a Dock connection.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Ditto.

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (230688 => 230689)

--- trunk/Source/WebCore/PAL/ChangeLog	2018-04-16 23:18:45 UTC (rev 230688)
+++ trunk/Source/WebCore/PAL/ChangeLog	2018-04-16 23:43:05 UTC (rev 230689)
@@ -1,3 +1,17 @@
+2018-04-16  Brent Fulgham  
+
+[macOS] Don't establish unneeded Dock connections
+https://bugs.webkit.org/show_bug.cgi?id=184664
+
+
+Reviewed by Simon Fraser.
+
+There is no reason for the WebContent or Plugin processes to interact with
+the Dock. We should tell AppKit that we don't want this connection, and to
+avoid creating such connections.
+
+* pal/spi/mac/NSApplicationSPI.h: Add Dock connection declaration.
+
 2018-04-09  John Wilander  
 
 Refactor Ignore HSTS code


Modified: trunk/Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h (230688 => 230689)

--- trunk/Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h	2018-04-16 23:18:45 UTC (rev 230688)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/NSApplicationSPI.h	2018-04-16 23:43:05 UTC (rev 230689)
@@ -32,6 +32,7 @@
 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
 + (void)_accessibilityInitialize;
++ (void)_preventDockConnections;
 #endif
 
 @end


Modified: trunk/Source/WebKit/ChangeLog (230688 => 230689)

--- trunk/Source/WebKit/ChangeLog	2018-04-16 23:18:45 UTC (rev 230688)
+++ trunk/Source/WebKit/ChangeLog	2018-04-16 23:43:05 UTC (rev 230689)
@@ -1,3 +1,21 @@
+2018-04-16  Brent Fulgham  
+
+[macOS] Don't establish unneeded Dock connections
+https://bugs.webkit.org/show_bug.cgi?id=184664
+
+
+Reviewed by Simon Fraser.
+
+There is no reason for the WebContent or Plugin processes to interact with
+the Dock. We should tell AppKit that we don't want this connection, and to
+avoid creating such connections.
+
+* PluginProcess/mac/PluginProcessMac.mm:
+(WebKit::PluginProcess::platformInitializeProcess): Tell NSApplication to
+not create a Dock connection.
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::platformInitializeWebProcess): Ditto.
+
 2018-04-16  Megan Gardner  
 
 Switch to UIWKTextInteractionAssistant for non-editable text


Modified: trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm (230688 => 230689)

--- trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm	2018-04-16 23:18:45 UTC (rev 230688)
+++ trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm	2018-04-16 23:43:05 UTC (rev 230689)
@@ -48,6 +48,7 @@
 #import 
 #import 
 #import 
+#import 
 #import 
 #import 
 #import 
@@ -524,6 +525,12 @@
 {
 initializeShim();
 
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+// We don't need to talk to the dock.
+if ([NSApplication respondsToSelector:@selector(_preventDockConnections)])
+[NSApplication _preventDockConnections];
+#endif
+
 initializeCocoaOverrides();
 
 // FIXME: It would be better to proxy SetCursor calls over to the UI process instead of


Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (230688 => 230689)

--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2018-04-16 23:18:45 UTC (rev 230688)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2018-04-16 23:43:05 UTC (rev 230689)
@@ -170,6 +170,10 @@
 #endif
 
 #if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+// We don't need to talk to the dock.
+if ([NSApplication respondsToSelector:@selector(_preventDockConnections)])
+[NSApplication _preventDockConnections];
+
 // Need to initialize accessibility for VoiceOver to work when the WebContent process is using NSRunLoop.
 // Currently, it is also needed to allocate and initialize an NSApplication object.
 // FIXME: Remove the following line when rdar://problem/36323569 is

[webkit-changes] [230690] branches/safari-605-branch/Source

2018-04-16 Thread kocsen_chung

Title: [230690] branches/safari-605-branch/Source








Revision 230690
Author kocsen_ch...@apple.com
Date 2018-04-16 16:46:54 -0700 (Mon, 16 Apr 2018)


Log Message
Versioning.

Modified Paths

branches/safari-605-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-605-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-605-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-605-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-605-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-605-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-605-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-605-branch/Source/_javascript_Core/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-605-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-605-branch/Source/WebCore/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/WebCore/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/WebCore/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-605-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-605-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-605-branch/Source/WebKit/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/WebKit/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/WebKit/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-605-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig (230689 => 230690)

--- branches/safari-605-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-04-16 23:43:05 UTC (rev 230689)
+++ branches/safari-605-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig	2018-04-16 23:46:54 UTC (rev 230690)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 605;
 MINOR_VERSION = 2;
-TINY_VERSION = 4;
+TINY_VERSION = 5;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230691] trunk/LayoutTests

2018-04-16 Thread krollin

Title: [230691] trunk/LayoutTests








Revision 230691
Author krol...@apple.com
Date 2018-04-16 16:57:08 -0700 (Mon, 16 Apr 2018)


Log Message
REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=184673


Unreviewed test gardening. The test was flaky because the HTTP parser
would try to preload the _javascript_ resource. Sometimes this operation
would complete in time to print its own console message, duplicating a
subsequent one when the non-preloading resource-load occurs. Updated
the test to load the _javascript_ in such a way that it skips the reload
step.

* TestExpectations:
* http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230690 => 230691)

--- trunk/LayoutTests/ChangeLog	2018-04-16 23:46:54 UTC (rev 230690)
+++ trunk/LayoutTests/ChangeLog	2018-04-16 23:57:08 UTC (rev 230691)
@@ -1,3 +1,20 @@
+2018-04-16  Keith Rollin  
+
+REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=184673
+
+
+Unreviewed test gardening. The test was flaky because the HTTP parser
+would try to preload the _javascript_ resource. Sometimes this operation
+would complete in time to print its own console message, duplicating a
+subsequent one when the non-preloading resource-load occurs. Updated
+the test to load the _javascript_ in such a way that it skips the reload
+step.
+
+* TestExpectations:
+* http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt:
+* http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html:
+
 2018-04-16  Ross Kirsling  
 
 Unreviewed. Update WinCairo TestExpectations in preparation for LayoutTests automation.


Modified: trunk/LayoutTests/TestExpectations (230690 => 230691)

--- trunk/LayoutTests/TestExpectations	2018-04-16 23:46:54 UTC (rev 230690)
+++ trunk/LayoutTests/TestExpectations	2018-04-16 23:57:08 UTC (rev 230691)
@@ -1196,7 +1196,6 @@
 webkit.org/b/154203 http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html
 webkit.org/b/154522 http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-base-uri-deny.html
 webkit.org/b/155132 http/tests/security/contentSecurityPolicy/video-with-https-url-allowed-by-csp-media-src-star.html [ Failure ]
-http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html [ Pass Failure ]
 webkit.org/b/158480 http/tests/websocket/tests/hybi/upgrade-simple-ws.html [ Skip ]
 
 # These state object tests purposefully stress a resource limit, and take multiple seconds to run.


Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt (230690 => 230691)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt	2018-04-16 23:46:54 UTC (rev 230690)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt	2018-04-16 23:57:08 UTC (rev 230691)
@@ -1,5 +1,4 @@
-CONSOLE MESSAGE: Refused to load the script 'http://localhost:8000/security/contentSecurityPolicy/resources/script-set-value.js' because it violates the following Content Security Policy directive: "script-src 'self' 'unsafe-inline'".
+CONSOLE MESSAGE: Refused to load http://localhost:8000/security/contentSecurityPolicy/resources/script-set-value.js because it does not appear in the script-src directive of the Content Security Policy.
 
-
 PASS Script element has error on bad script-src 
 


Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html (230690 => 230691)

--- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html	2018-04-16 23:46:54 UTC (rev 230690)
+++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html	2018-04-16 23:57:08 UTC (rev 230691)
@@ -18,6 +18,12 @@
 
 
 
-+