[webkit-changes] [230797] trunk

[rego]

Title: [230797] trunk








Revision 230797
Author r...@igalia.com
Date 2018-04-19 00:10:48 -0700 (Thu, 19 Apr 2018)


Log Message
Caret rendered at incorrect location inside empty table cell
https://bugs.webkit.org/show_bug.cgi?id=85385

Reviewed by Zalan Bujtas.

Source/WebCore:

This is based on a previous patch by Shezan Baig .

This fixes the position of the caret in empty cells,
that was painted lower than expected
(and then modified when you start to edit the cell).

Ensures that editable table cells have at least one line when
they are laid out. This ensures that the cell's intrinsic before/after
padding is calculated correctly, which results in the caret location
being calculated correctly.

Test: editing/caret/caret-in-empty-cell.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::hasLineIfEmpty): Override method to consider
that it has an an empty line if the table cell is editable.
* rendering/RenderTableCell.h:

LayoutTests:

* editing/caret/caret-in-empty-cell-expected.html: Added.
* editing/caret/caret-in-empty-cell.html: Added.
* editing/deleting/5206311-2-expected.txt:
* editing/deleting/5433862-1-expected.txt:
* platform/gtk/editing/deleting/5126166-expected.png:
* platform/gtk/editing/deleting/5126166-expected.txt:
* platform/gtk/editing/deleting/5206311-1-expected.png:
* platform/gtk/editing/deleting/5206311-1-expected.txt:
* platform/gtk/editing/deleting/5433862-2-expected.png:
* platform/gtk/editing/deleting/5433862-2-expected.txt:
* platform/gtk/editing/deleting/5483370-expected.png:
* platform/gtk/editing/deleting/5483370-expected.txt:
* platform/gtk/editing/selection/move-by-line-001-expected.png:
* platform/gtk/editing/selection/move-by-line-001-expected.txt:
* platform/gtk/editing/selection/select-all-004-expected.txt:
* platform/ios-simulator/editing/deleting/5126166-expected.txt:
* platform/ios-simulator/editing/deleting/5206311-1-expected.txt:
* platform/ios-simulator/editing/deleting/5433862-2-expected.txt:
* platform/ios-simulator/editing/deleting/5483370-expected.txt:
* platform/mac/editing/deleting/5126166-expected.png:
* platform/mac/editing/deleting/5126166-expected.txt:
* platform/mac/editing/deleting/5206311-1-expected.png:
* platform/mac/editing/deleting/5206311-1-expected.txt:
* platform/mac/editing/deleting/5433862-2-expected.png:
* platform/mac/editing/deleting/5433862-2-expected.txt:
* platform/mac/editing/deleting/5483370-expected.png:
* platform/mac/editing/deleting/5483370-expected.txt:
* platform/mac/editing/selection/move-by-line-001-expected.txt:
* platform/mac/editing/selection/select-all-004-expected.txt:
* platform/win/editing/deleting/5126166-expected.png: Added.
* platform/win/editing/deleting/5126166-expected.txt:
* platform/win/editing/deleting/5206311-1-expected.png: Added.
* platform/win/editing/deleting/5206311-1-expected.txt:
* platform/win/editing/deleting/5433862-2-expected.png: Added.
* platform/win/editing/deleting/5433862-2-expected.txt:
* platform/win/editing/deleting/5483370-expected.png: Added.
* platform/win/editing/deleting/5483370-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/5206311-2-expected.txt
trunk/LayoutTests/editing/deleting/5433862-1-expected.txt
trunk/LayoutTests/editing/selection/select-all-004-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/5126166-expected.png
trunk/LayoutTests/platform/gtk/editing/deleting/5126166-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/5206311-1-expected.png
trunk/LayoutTests/platform/gtk/editing/deleting/5206311-1-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/5433862-2-expected.png
trunk/LayoutTests/platform/gtk/editing/deleting/5433862-2-expected.txt
trunk/LayoutTests/platform/gtk/editing/deleting/5483370-expected.png
trunk/LayoutTests/platform/gtk/editing/deleting/5483370-expected.txt
trunk/LayoutTests/platform/gtk/editing/selection/move-by-line-001-expected.png
trunk/LayoutTests/platform/gtk/editing/selection/move-by-line-001-expected.txt
trunk/LayoutTests/platform/ios/editing/deleting/5126166-expected.txt
trunk/LayoutTests/platform/ios/editing/deleting/5206311-1-expected.txt
trunk/LayoutTests/platform/ios/editing/deleting/5433862-2-expected.txt
trunk/LayoutTests/platform/ios/editing/deleting/5483370-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/5126166-expected.png
trunk/LayoutTests/platform/mac/editing/deleting/5126166-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/5206311-1-expected.png
trunk/LayoutTests/platform/mac/editing/deleting/5206311-1-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/5433862-2-expected.png
trunk/LayoutTests/platform/mac/editing/deleting/5433862-2-expected.txt
trunk/LayoutTests/platform/mac/editing/deleting/5483370-expected.png
trunk/LayoutTests/platform/mac/editing/deleting/5483370-expected.txt
trunk/LayoutTests/platform/mac/editing/selection/move-by-line-001-expected.txt

[webkit-changes] [230798] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [230798] trunk/Source/_javascript_Core








Revision 230798
Author utatane@gmail.com
Date 2018-04-19 05:35:40 -0700 (Thu, 19 Apr 2018)


Log Message
Unreviewed, Fix jsc shell
https://bugs.webkit.org/show_bug.cgi?id=184600

WebAssembly module loading does not finish with drainMicrotasks().
So JSNativeStdFunction's capturing variables become invalid.
This patch fixes this issue.

* jsc.cpp:
(functionDollarAgentStart):
(runWithOptions):
(runJSC):
(jscmain):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/jsc.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230797 => 230798)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-19 07:10:48 UTC (rev 230797)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-19 12:35:40 UTC (rev 230798)
@@ -1,3 +1,18 @@
+2018-04-19  Yusuke Suzuki  
+
+Unreviewed, Fix jsc shell
+https://bugs.webkit.org/show_bug.cgi?id=184600
+
+WebAssembly module loading does not finish with drainMicrotasks().
+So JSNativeStdFunction's capturing variables become invalid.
+This patch fixes this issue.
+
+* jsc.cpp:
+(functionDollarAgentStart):
+(runWithOptions):
+(runJSC):
+(jscmain):
+
 2018-04-18  Ross Kirsling  
 
 REGRESSION(r230748) [WinCairo] 'JSC::JIT::appendCallWithSlowPathReturnType': function does not take 1 arguments


Modified: trunk/Source/_javascript_Core/jsc.cpp (230797 => 230798)

--- trunk/Source/_javascript_Core/jsc.cpp	2018-04-19 07:10:48 UTC (rev 230797)
+++ trunk/Source/_javascript_Core/jsc.cpp	2018-04-19 12:35:40 UTC (rev 230798)
@@ -1620,7 +1620,7 @@
 commandLine.m_interactive = false;
 runJSC(
 commandLine, true,
-[&] (VM&, GlobalObject* globalObject) {
+[&] (VM&, GlobalObject* globalObject, bool& success) {
 // Notify the thread that started us that we have registered a worker.
 {
 auto locker = holdLock(didStartLock);
@@ -1629,7 +1629,6 @@
 }
 
 NakedPtr evaluationException;
-bool success = true;
 JSValue result;
 result = evaluate(globalObject->globalExec(), makeSource(sourceCode, SourceOrigin(ASCIILiteral("worker"))), JSValue(), evaluationException);
 if (evaluationException)
@@ -1637,7 +1636,6 @@
 checkException(globalObject->globalExec(), globalObject, true, evaluationException, result, commandLine, success);
 if (!success)
 exit(1);
-return success;
 });
 })->detach();
 
@@ -2295,7 +2293,7 @@
 success = success && checkUncaughtException(vm, globalObject, (hasException) ? value : JSValue(), options);
 }
 
-static bool runWithOptions(GlobalObject* globalObject, CommandLine& options)
+static void runWithOptions(GlobalObject* globalObject, CommandLine& options, bool& success)
 {
 

[webkit-changes] [230834] trunk

[beidson]

Title: [230834] trunk








Revision 230834
Author beid...@apple.com
Date 2018-04-19 21:55:32 -0700 (Thu, 19 Apr 2018)


Log Message
Make back forward cache work with process swapping.
 and https://bugs.webkit.org/show_bug.cgi?id=184793

Reviewed by Chris Dumez.

Source/WebCore:

Covered by API tests.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::loadDifferentDocumentItem):
* loader/FrameLoader.h:

Source/WebKit:

We previously saved old processes in "SuspendedPageProxy" objects.
Now we reuse them when going back or forward.

* Platform/Logging.h:

* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::setSuspendedPage):
(WebKit::WebBackForwardListItem::loggingString):
* Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::suspendedPage const):

Teach Navigation objects their source WebBackForwardListItems:
* UIProcess/API/APINavigation.cpp:
(API::Navigation::Navigation):
(API::Navigation::loggingString const):
* UIProcess/API/APINavigation.h:
(API::Navigation::create):
(API::Navigation::targetItem const):
(API::Navigation::fromItem const):
(API::Navigation::backForwardListItem): Deleted.

* UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

* UIProcess/SuspendedPageProxy.cpp:
(WebKit::messageNamesToIgnoreWhileSuspended):
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
(WebKit::SuspendedPageProxy::~SuspendedPageProxy):
(WebKit::SuspendedPageProxy::webProcessDidClose):
(WebKit::SuspendedPageProxy::didReceiveMessage):
(WebKit::SuspendedPageProxy::loggingString const):
* UIProcess/SuspendedPageProxy.h:
(WebKit::SuspendedPageProxy::origin const):

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::WebBackForwardList):
(WebKit::WebBackForwardList::~WebBackForwardList):
(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::goToItem):
(WebKit::WebBackForwardList::removeAllItems):
(WebKit::WebBackForwardList::clear):
(WebKit::WebBackForwardList::restoreFromState):
(WebKit::WebBackForwardList::filteredItemStates const):
(WebKit::WebBackForwardList::itemStates const):
(WebKit::WebBackForwardList::loggingString):
* UIProcess/WebBackForwardList.h:

* UIProcess/WebNavigationState.cpp:
(WebKit::WebNavigationState::createLoadRequestNavigation):
(WebKit::WebNavigationState::createBackForwardNavigation):
* UIProcess/WebNavigationState.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::maybeCreateSuspendedPage):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::didCreateMainFrame):
(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::connectionWillOpen):
(WebKit::WebPageProxy::attachToProcessForNavigation): Deleted.
* UIProcess/WebPageProxy.h:

* UIProcess/WebProcessLifetimeTracker.cpp:
(WebKit::WebProcessLifetimeTracker::webPageEnteringWebProcess):
(WebKit::WebProcessLifetimeTracker::connectionWillOpen): Deleted.
* UIProcess/WebProcessLifetimeTracker.h:

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::registerSuspendedPageProxy):
(WebKit::WebProcessPool::unregisterSuspendedPageProxy):
* UIProcess/WebProcessPool.h:

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::suspendWebPageProxy):
(WebKit::WebProcessProxy::updateBackForwardItem):
(WebKit::WebProcessProxy::frameCreated):
* UIProcess/WebProcessProxy.h:

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::attachDrawingArea):

* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WebBackForwardListProxy::addItem):
* WebProcess/WebPage/WebBackForwardListProxy.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::m_credentialsMessenger):
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::goToBackForwardItem):
(WebKit::WebPage::restoreSessionInternal):
(WebKit::WebPage::restoreSession):
(WebKit::WebPage::updateBackForwardListForReattach):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):

[webkit-changes] [230833] tags/Safari-606.1.14.1/Source

[kocsen_chung]

Title: [230833] tags/Safari-606.1.14.1/Source








Revision 230833
Author kocsen_ch...@apple.com
Date 2018-04-19 20:16:34 -0700 (Thu, 19 Apr 2018)


Log Message
Versioning.

Modified Paths

tags/Safari-606.1.14.1/Source/_javascript_Core/Configurations/Version.xcconfig
tags/Safari-606.1.14.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
tags/Safari-606.1.14.1/Source/WebCore/Configurations/Version.xcconfig
tags/Safari-606.1.14.1/Source/WebCore/PAL/Configurations/Version.xcconfig
tags/Safari-606.1.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig
tags/Safari-606.1.14.1/Source/WebKit/Configurations/Version.xcconfig
tags/Safari-606.1.14.1/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: tags/Safari-606.1.14.1/Source/_javascript_Core/Configurations/Version.xcconfig (230832 => 230833)

--- tags/Safari-606.1.14.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-20 03:10:09 UTC (rev 230832)
+++ tags/Safari-606.1.14.1/Source/_javascript_Core/Configurations/Version.xcconfig	2018-04-20 03:16:34 UTC (rev 230833)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.14.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (230832 => 230833)

--- tags/Safari-606.1.14.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-20 03:10:09 UTC (rev 230832)
+++ tags/Safari-606.1.14.1/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2018-04-20 03:16:34 UTC (rev 230833)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.14.1/Source/WebCore/Configurations/Version.xcconfig (230832 => 230833)

--- tags/Safari-606.1.14.1/Source/WebCore/Configurations/Version.xcconfig	2018-04-20 03:10:09 UTC (rev 230832)
+++ tags/Safari-606.1.14.1/Source/WebCore/Configurations/Version.xcconfig	2018-04-20 03:16:34 UTC (rev 230833)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.14.1/Source/WebCore/PAL/Configurations/Version.xcconfig (230832 => 230833)

--- tags/Safari-606.1.14.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-20 03:10:09 UTC (rev 230832)
+++ tags/Safari-606.1.14.1/Source/WebCore/PAL/Configurations/Version.xcconfig	2018-04-20 03:16:34 UTC (rev 230833)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: tags/Safari-606.1.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig (230832 => 230833)

--- tags/Safari-606.1.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-20 03:10:09 UTC (rev 230832)
+++ tags/Safari-606.1.14.1/Source/WebInspectorUI/Configurations/Version.xcconfig	2018-04-20 03:16:34 UTC (rev 230833)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 606;
 MINOR_VERSION = 1;
 TINY_VERSION = 14;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: tags/Safari-606.1.14.1/Source/WebKit/Configurations/Version.xcconfig (230832 => 230833)

--- tags/Safari-606.1.14.1/Source/WebKit/Configurations/Version.xcconfig	2018-04-20 03:10:09 UTC (rev 230832)
+++ tags/Safari-606.1.14.1/Source/WebKit/Configurations/Version.xcconfig	2018-04-20 03:16:34 UTC (rev 230833)
@@ 

[webkit-changes] [230831] trunk/Source

[cdumez]

Title: [230831] trunk/Source








Revision 230831
Author cdu...@apple.com
Date 2018-04-19 19:15:39 -0700 (Thu, 19 Apr 2018)


Log Message
Rename JSDOMWindowProxy to JSWindowProxy
https://bugs.webkit.org/show_bug.cgi?id=184797

Reviewed by Sam Weinig.

Rename JSDOMWindowProxy to JSWindowProxy for consistency with WindowProxy.

Source/WebCore:

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/IDLTypes.h:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMConvertWindowProxy.h:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::proxy const):
(WebCore::toJSDOMWindow):
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::toWrapped):
* bindings/js/JSEventTargetCustom.cpp:
(WebCore::JSEventTarget::toWrapped):
* bindings/js/JSRemoteDOMWindowBase.cpp:
(WebCore::JSRemoteDOMWindowBase::JSRemoteDOMWindowBase):
(WebCore::toJSRemoteDOMWindow):
* bindings/js/JSRemoteDOMWindowBase.h:
* bindings/js/JSWindowProxy.cpp: Renamed from Source/WebCore/bindings/js/JSDOMWindowProxy.cpp.
(WebCore::JSWindowProxy::JSWindowProxy):
(WebCore::JSWindowProxy::finishCreation):
(WebCore::JSWindowProxy::create):
(WebCore::JSWindowProxy::destroy):
(WebCore::JSWindowProxy::setWindow):
(WebCore::JSWindowProxy::attachDebugger):
(WebCore::JSWindowProxy::wrapped const):
(WebCore::JSWindowProxy::toWrapped):
(WebCore::toJS):
(WebCore::toJSWindowProxy):
* bindings/js/JSWindowProxy.h: Renamed from Source/WebCore/bindings/js/JSDOMWindowProxy.h.
(WebCore::toJS):
(WebCore::toJSWindowProxy):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::initScriptForWindowProxy):
* bindings/js/ScriptController.h:
* bindings/js/WindowProxy.cpp:
(WebCore::WindowProxy::createJSWindowProxy):
(WebCore::WindowProxy::jsWindowProxiesAsVector const):
(WebCore::WindowProxy::createJSWindowProxyWithInitializedScript):
* bindings/js/WindowProxy.h:
(WebCore::WindowProxy::jsWindowProxy):
(WebCore::WindowProxy::existingJSWindowProxy const):
* bindings/scripts/CodeGeneratorJS.pm:
(AddToIncludesForIDLType):
(GenerateHeader):
(GenerateOverloadDispatcher):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodOverloadDispatcher):
* page/Frame.cpp:
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didCreateWindowProxy const):
* page/csp/ContentSecurityPolicy.h:

Source/WebInspectorUI:

* UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
(HeapSnapshot.prototype._isNodeGlobalObject):

Source/WebKitLegacy/mac:

* DOM/DOMUtility.mm:
(createDOMWrapper):
* WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):

Source/WebKitLegacy/win:

* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/IDLTypes.h
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSDOMConvertWindowProxy.h
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.h
trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
trunk/Source/WebCore/bindings/js/JSEventTargetCustom.cpp
trunk/Source/WebCore/bindings/js/JSRemoteDOMWindowBase.cpp
trunk/Source/WebCore/bindings/js/JSRemoteDOMWindowBase.h
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/bindings/js/ScriptController.h
trunk/Source/WebCore/bindings/js/WindowProxy.cpp
trunk/Source/WebCore/bindings/js/WindowProxy.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializationInherit.h
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestSerializationInheritFinal.h
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.cpp
trunk/Source/WebCore/page/csp/ContentSecurityPolicy.h
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/HeapSnapshot.js
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/DOM/DOMUtility.mm
trunk/Source/WebKitLegacy/mac/WebView/WebFrame.mm
trunk/Source/WebKitLegacy/win/ChangeLog
trunk/Source/WebKitLegacy/win/WebFrame.cpp


Added Paths

trunk/Source/WebCore/bindings/js/JSWindowProxy.cpp
trunk/Source/WebCore/bindings/js/JSWindowProxy.h

[webkit-changes] [230832] tags/Safari-606.1.14.1/

[kocsen_chung]

Title: [230832] tags/Safari-606.1.14.1/








Revision 230832
Author kocsen_ch...@apple.com
Date 2018-04-19 20:10:09 -0700 (Thu, 19 Apr 2018)


Log Message
New tag.

Added Paths

tags/Safari-606.1.14.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230805] trunk/Source/WebCore

[commit-queue]

Title: [230805] trunk/Source/WebCore








Revision 230805
Author commit-qu...@webkit.org
Date 2018-04-19 09:01:09 -0700 (Thu, 19 Apr 2018)


Log Message
Change MediaSource WebCore to return NewObject for SourceBuffers
https://bugs.webkit.org/show_bug.cgi?id=184642

Patch by Eric Stobbart  on 2018-04-19
Reviewed by Chris Dumez.

Minor change inline with IDL documentation

* Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::addSourceBuffer):
(): Deleted.
* Modules/mediasource/MediaSource.h:
* Modules/mediasource/MediaSource.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp
trunk/Source/WebCore/Modules/mediasource/MediaSource.h
trunk/Source/WebCore/Modules/mediasource/MediaSource.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (230804 => 230805)

--- trunk/Source/WebCore/ChangeLog	2018-04-19 15:58:30 UTC (rev 230804)
+++ trunk/Source/WebCore/ChangeLog	2018-04-19 16:01:09 UTC (rev 230805)
@@ -1,3 +1,18 @@
+2018-04-19  Eric Stobbart  
+
+Change MediaSource WebCore to return NewObject for SourceBuffers
+https://bugs.webkit.org/show_bug.cgi?id=184642
+
+Reviewed by Chris Dumez.
+
+Minor change inline with IDL documentation
+
+* Modules/mediasource/MediaSource.cpp:
+(WebCore::MediaSource::addSourceBuffer):
+(): Deleted.
+* Modules/mediasource/MediaSource.h:
+* Modules/mediasource/MediaSource.idl:
+
 2018-04-19  Yusuke Suzuki  
 
 Unreviewed, build fix for Ubuntu LTS GCC


Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp (230804 => 230805)

--- trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2018-04-19 15:58:30 UTC (rev 230804)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp	2018-04-19 16:01:09 UTC (rev 230805)
@@ -623,7 +623,7 @@
 }
 }
 
-ExceptionOr MediaSource::addSourceBuffer(const String& type)
+ExceptionOr MediaSource::addSourceBuffer(const String& type)
 {
 LOG(MediaSource, "MediaSource::addSourceBuffer(%s) %p", type.ascii().data(), this);
 
@@ -669,14 +669,12 @@
 // ↳ Set the mode attribute on the new object to "segments".
 buffer->setMode(shouldGenerateTimestamps ? SourceBuffer::AppendMode::Sequence : SourceBuffer::AppendMode::Segments);
 
-auto& result = buffer.get();
-
 // 8. Add the new object to sourceBuffers and fire a addsourcebuffer on that object.
-m_sourceBuffers->add(WTFMove(buffer));
+m_sourceBuffers->add(buffer.copyRef());
 regenerateActiveSourceBuffers();
 
 // 9. Return the new object to the caller.
-return result;
+return WTFMove(buffer);
 }
 
 ExceptionOr MediaSource::removeSourceBuffer(SourceBuffer& buffer)


Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.h (230804 => 230805)

--- trunk/Source/WebCore/Modules/mediasource/MediaSource.h	2018-04-19 15:58:30 UTC (rev 230804)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.h	2018-04-19 16:01:09 UTC (rev 230805)
@@ -91,7 +91,7 @@
 
 SourceBufferList* sourceBuffers() { return m_sourceBuffers.get(); }
 SourceBufferList* activeSourceBuffers() { return m_activeSourceBuffers.get(); }
-ExceptionOr addSourceBuffer(const String& type);
+ExceptionOr addSourceBuffer(const String& type);
 ExceptionOr removeSourceBuffer(SourceBuffer&);
 static bool isTypeSupported(const String& type);
 


Modified: trunk/Source/WebCore/Modules/mediasource/MediaSource.idl (230804 => 230805)

--- trunk/Source/WebCore/Modules/mediasource/MediaSource.idl	2018-04-19 15:58:30 UTC (rev 230804)
+++ trunk/Source/WebCore/Modules/mediasource/MediaSource.idl	2018-04-19 16:01:09 UTC (rev 230805)
@@ -54,7 +54,7 @@
 
 attribute unrestricted double duration;
 
-[MayThrowException] SourceBuffer addSourceBuffer(DOMString type);
+[NewObject, MayThrowException] SourceBuffer addSourceBuffer(DOMString type);
 [MayThrowException] void removeSourceBuffer(SourceBuffer buffer);
 
 readonly attribute ReadyState readyState;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230802] trunk/LayoutTests

[ryanhaddad]

Title: [230802] trunk/LayoutTests








Revision 230802
Author ryanhad...@apple.com
Date 2018-04-19 08:58:24 -0700 (Thu, 19 Apr 2018)


Log Message
Mark imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=182833

Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230801 => 230802)

--- trunk/LayoutTests/ChangeLog	2018-04-19 15:58:21 UTC (rev 230801)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 15:58:24 UTC (rev 230802)
@@ -1,5 +1,14 @@
 2018-04-18  Ryan Haddad  
 
+Mark imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=182833
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
+2018-04-18  Ryan Haddad  
+
 Mark media/video-aspect-ratio.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=184457
 


Modified: trunk/LayoutTests/TestExpectations (230801 => 230802)

--- trunk/LayoutTests/TestExpectations	2018-04-19 15:58:21 UTC (rev 230801)
+++ trunk/LayoutTests/TestExpectations	2018-04-19 15:58:24 UTC (rev 230802)
@@ -1829,6 +1829,7 @@
 webkit.org/b/182833 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html [ Skip ]
 webkit.org/b/182833 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args.html [ Pass Failure ]
 webkit.org/b/182833 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-origin.sub.html [ Pass Failure ]
+webkit.org/b/182833 imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html [ Pass Failure ]
 
 webkit.org/b/184198 imported/w3c/web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230804] trunk/LayoutTests

[ryanhaddad]

Title: [230804] trunk/LayoutTests








Revision 230804
Author ryanhad...@apple.com
Date 2018-04-19 08:58:30 -0700 (Thu, 19 Apr 2018)


Log Message
Unreviewed, rebaseline tests for iOS simulator.

* platform/ios/TestExpectations:
* platform/ios/editing/deleting/delete-emoji-9-expected.txt:
* platform/ios/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
* platform/ios/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Added.
* platform/ios/quicklook/excel-expected.txt:
* platform/ios/quicklook/excel-legacy-expected.txt:
* platform/ios/quicklook/excel-macro-enabled-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios/editing/deleting/delete-emoji-9-expected.txt
trunk/LayoutTests/platform/ios/quicklook/excel-expected.txt
trunk/LayoutTests/platform/ios/quicklook/excel-legacy-expected.txt
trunk/LayoutTests/platform/ios/quicklook/excel-macro-enabled-expected.txt


Added Paths

trunk/LayoutTests/platform/ios/http/tests/blink/
trunk/LayoutTests/platform/ios/http/tests/blink/sendbeacon/
trunk/LayoutTests/platform/ios/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/beacon/
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/beacon/headers/
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (230803 => 230804)

--- trunk/LayoutTests/ChangeLog	2018-04-19 15:58:26 UTC (rev 230803)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 15:58:30 UTC (rev 230804)
@@ -1,3 +1,15 @@
+2018-04-19  Ryan Haddad  
+
+Unreviewed, rebaseline tests for iOS simulator.
+
+* platform/ios/TestExpectations:
+* platform/ios/editing/deleting/delete-emoji-9-expected.txt:
+* platform/ios/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
+* platform/ios/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Added.
+* platform/ios/quicklook/excel-expected.txt:
+* platform/ios/quicklook/excel-legacy-expected.txt:
+* platform/ios/quicklook/excel-macro-enabled-expected.txt:
+
 2018-04-18  Ryan Haddad  
 
 Skip legacy-animation-engine/media/track/opera directory on iOS.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (230803 => 230804)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-04-19 15:58:26 UTC (rev 230803)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-04-19 15:58:30 UTC (rev 230804)
@@ -3290,3 +3290,5 @@
 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/interfaces.any.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/hr-time/idlharness.html [ Slow ]
+
+webkit.org/b/184783 compositing/ios/overflow-scroll-touch-tiles.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/ios/editing/deleting/delete-emoji-9-expected.txt (230803 => 230804)

--- trunk/LayoutTests/platform/ios/editing/deleting/delete-emoji-9-expected.txt	2018-04-19 15:58:26 UTC (rev 230803)
+++ trunk/LayoutTests/platform/ios/editing/deleting/delete-emoji-9-expected.txt	2018-04-19 15:58:30 UTC (rev 230804)
@@ -7,127 +7,55 @@
 
 Dump of markup 2:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsctgbwls<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsct<#selection-caret>"
 
 Dump of markup 3:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsctgbwl<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbeng<#selection-caret>"
 
 Dump of markup 4:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsctgbw<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍<#selection-caret>"
 
 Dump of markup 5:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsctgb<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍<#selection-caret>"
 
 Dump of markup 6:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsctg<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍<#selection-caret>"
 
 Dump of markup 7:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsct<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍<#selection-caret>"
 
 Dump of markup 8:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsct<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍<#selection-caret>"
 
 Dump of markup 9:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsct<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕️‍<#selection-caret>"
 
 Dump of markup 10:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbsc<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕‍⚕<#selection-caret>"
 
 Dump of markup 11:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggbs<#selection-caret>"
+酪‍⚕️‍⚕️‍⚕<#selection-caret>"
 
 Dump of markup 12:
 | "
-酪‍⚕️‍⚕️‍⚕‍⚕️‍️‍️‍gbenggb<#selection-caret>"
+酪‍⚕️‍⚕️<#selection-caret>"
 
 Dump of markup 13:
 | "

[webkit-changes] [230803] trunk/LayoutTests

[ryanhaddad]

Title: [230803] trunk/LayoutTests








Revision 230803
Author ryanhad...@apple.com
Date 2018-04-19 08:58:26 -0700 (Thu, 19 Apr 2018)


Log Message
Skip legacy-animation-engine/media/track/opera directory on iOS.
https://bugs.webkit.org/show_bug.cgi?id=184420

Unreviewed test gardening.

The media/track/opera directory is already skipped on iOS, so skip this duplicated directory.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230802 => 230803)

--- trunk/LayoutTests/ChangeLog	2018-04-19 15:58:24 UTC (rev 230802)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 15:58:26 UTC (rev 230803)
@@ -1,5 +1,16 @@
 2018-04-18  Ryan Haddad  
 
+Skip legacy-animation-engine/media/track/opera directory on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=184420
+
+Unreviewed test gardening.
+
+The media/track/opera directory is already skipped on iOS, so skip this duplicated directory.
+
+* platform/ios/TestExpectations:
+
+2018-04-18  Ryan Haddad  
+
 Mark imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=182833
 


Modified: trunk/LayoutTests/platform/ios/TestExpectations (230802 => 230803)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-04-19 15:58:24 UTC (rev 230802)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-04-19 15:58:26 UTC (rev 230803)
@@ -2716,6 +2716,7 @@
 media/video-webkit-playsinline.html
 media/volume-bar-empty-when-muted.html
 
+webkit.org/b/103926 legacy-animation-engine/media/track/opera
 webkit.org/b/103926 media/track/opera
 
 webkit.org/b/35297 media/video-display-aspect-ratio.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230801] trunk/LayoutTests

[ryanhaddad]

Title: [230801] trunk/LayoutTests








Revision 230801
Author ryanhad...@apple.com
Date 2018-04-19 08:58:21 -0700 (Thu, 19 Apr 2018)


Log Message
Mark media/video-aspect-ratio.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184457

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230800 => 230801)

--- trunk/LayoutTests/ChangeLog	2018-04-19 15:00:41 UTC (rev 230800)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 15:58:21 UTC (rev 230801)
@@ -1,3 +1,12 @@
+2018-04-18  Ryan Haddad  
+
+Mark media/video-aspect-ratio.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=184457
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2018-04-19  Miguel Gomez  
 
 Unreviewed GTK+ gardening after r230796.


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (230800 => 230801)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-04-19 15:00:41 UTC (rev 230800)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-04-19 15:58:21 UTC (rev 230801)
@@ -536,3 +536,5 @@
 webkit.org/b/184456 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback.html [ Pass Failure ]
 
 webkit.org/b/184569 [ Debug ] animations/missing-from-to.html [ Skip ]
+
+webkit.org/b/184457 media/video-aspect-ratio.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230799] trunk/Source/WebCore

[utatane . tea]

Title: [230799] trunk/Source/WebCore








Revision 230799
Author utatane@gmail.com
Date 2018-04-19 05:47:33 -0700 (Thu, 19 Apr 2018)


Log Message
Unreviewed, build fix for Ubuntu LTS GCC
https://bugs.webkit.org/show_bug.cgi?id=184756

The variable name "windowProxy" (with auto&) conflicts with the function name "windowProxy".

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::collectIsolatedContexts):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230798 => 230799)

--- trunk/Source/WebCore/ChangeLog	2018-04-19 12:35:40 UTC (rev 230798)
+++ trunk/Source/WebCore/ChangeLog	2018-04-19 12:47:33 UTC (rev 230799)
@@ -1,3 +1,14 @@
+2018-04-19  Yusuke Suzuki  
+
+Unreviewed, build fix for Ubuntu LTS GCC
+https://bugs.webkit.org/show_bug.cgi?id=184756
+
+The variable name "windowProxy" (with auto&) conflicts with the function name "windowProxy".
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::updateDocument):
+(WebCore::ScriptController::collectIsolatedContexts):
+
 2018-04-19  Manuel Rego Casasnovas  
 
 Caret rendered at incorrect location inside empty table cell


Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (230798 => 230799)

--- trunk/Source/WebCore/bindings/js/ScriptController.cpp	2018-04-19 12:35:40 UTC (rev 230798)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp	2018-04-19 12:47:33 UTC (rev 230799)
@@ -383,9 +383,9 @@
 
 void ScriptController::updateDocument()
 {
-for (auto& windowProxy : windowProxy().jsWindowProxiesAsVector()) {
-JSLockHolder lock(windowProxy->world().vm());
-jsCast(windowProxy->window())->updateDocument();
+for (auto& jsWindowProxy : windowProxy().jsWindowProxiesAsVector()) {
+JSLockHolder lock(jsWindowProxy->world().vm());
+jsCast(jsWindowProxy->window())->updateDocument();
 }
 }
 
@@ -427,9 +427,9 @@
 
 void ScriptController::collectIsolatedContexts(Vector>& result)
 {
-for (auto& windowProxy : windowProxy().jsWindowProxiesAsVector()) {
-auto* exec = windowProxy->window()->globalExec();
-auto* origin = (windowProxy->wrapped()).document()->securityOrigin();
+for (auto& jsWindowProxy : windowProxy().jsWindowProxiesAsVector()) {
+auto* exec = jsWindowProxy->window()->globalExec();
+auto* origin = (jsWindowProxy->wrapped()).document()->securityOrigin();
 result.append(std::make_pair(exec, origin));
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230810] trunk

[youenn]

Title: [230810] trunk








Revision 230810
Author you...@apple.com
Date 2018-04-19 10:54:35 -0700 (Thu, 19 Apr 2018)


Log Message
NetworkProcess should use CSP/content blockers for sync XHR
https://bugs.webkit.org/show_bug.cgi?id=184760

Reviewed by Chris Dumez.

Source/WebKit:

Setting CSP/ContentBlockers parameters for sync XHR loads.
* NetworkProcess/NetworkResourceLoader.cpp:

LayoutTests:

* http/tests/contentextensions/sync-xhr-redirection-blocked-expected.txt: Added.
* http/tests/contentextensions/sync-xhr-redirection-blocked.html: Added.
* http/tests/contentextensions/sync-xhr-redirection-blocked.html.json: Added.
* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-sync-xhr-in-main-frame-window.html: Added.
* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-sync-xhr-in-main-frame-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-sync-xhr-in-main-frame.html: Added.
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp


Added Paths

trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked-expected.txt
trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked.html
trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked.html.json
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-sync-xhr-in-main-frame-window.html
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-sync-xhr-in-main-frame-expected.txt
trunk/LayoutTests/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-sync-xhr-in-main-frame.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230809 => 230810)

--- trunk/LayoutTests/ChangeLog	2018-04-19 17:49:21 UTC (rev 230809)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 17:54:35 UTC (rev 230810)
@@ -1,3 +1,19 @@
+2018-04-19  Youenn Fablet  
+
+NetworkProcess should use CSP/content blockers for sync XHR
+https://bugs.webkit.org/show_bug.cgi?id=184760
+
+Reviewed by Chris Dumez.
+
+* http/tests/contentextensions/sync-xhr-redirection-blocked-expected.txt: Added.
+* http/tests/contentextensions/sync-xhr-redirection-blocked.html: Added.
+* http/tests/contentextensions/sync-xhr-redirection-blocked.html.json: Added.
+* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-sync-xhr-in-main-frame-window.html: Added.
+* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-sync-xhr-in-main-frame-expected.txt: Added.
+* http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-sync-xhr-in-main-frame.html: Added.
+* platform/mac-wk1/TestExpectations:
+* platform/win/TestExpectations:
+
 2018-04-19  Ryan Haddad  
 
 Unreviewed test gardening for iOS simulator.


Added: trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked-expected.txt (0 => 230810)

--- trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked-expected.txt	2018-04-19 17:54:35 UTC (rev 230810)
@@ -0,0 +1,6 @@
+CONSOLE MESSAGE: line 22: Content blocker prevented frame displaying http://127.0.0.1:8000/contentextensions/sync-xhr-redirection-blocked.html from loading a resource from http://127.0.0.1:8000/resources/redirect.php?url=""
+CONSOLE MESSAGE: line 22: XMLHttpRequest cannot load http://127.0.0.1:8000/resources/redirect.php?url="" 
+Synchronous status: 0, readyState:1, responseText: 
+Synchronous status: 0, readyState:4, responseText: 
+Synchronous error: NetworkError: A network error occurred.
+


Added: trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked.html (0 => 230810)

--- trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked.html	(rev 0)
+++ trunk/LayoutTests/http/tests/contentextensions/sync-xhr-redirection-blocked.html	2018-04-19 17:54:35 UTC (rev 230810)
@@ -0,0 +1,33 @@
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function log(text) {
+document.body.appendChild(document.createTextNode(text));
+document.body.appendChild(document.createElement("br"));
+}
+
+function runTest() {
+var xhr = new XMLHttpRequest();
+xhr._onreadystatechange_ = function() {
+log("Synchronous status: " + xhr.status + ", readyState:" + xhr.readyState + ", 

[webkit-changes] [230809] trunk/LayoutTests

[ryanhaddad]

Title: [230809] trunk/LayoutTests








Revision 230809
Author ryanhad...@apple.com
Date 2018-04-19 10:49:21 -0700 (Thu, 19 Apr 2018)


Log Message
Unreviewed test gardening for iOS simulator.

* platform/ios-wk2/TestExpectations:
* platform/ios-wk2/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Removed.
* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations


Removed Paths

trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/beacon/




Diff

Modified: trunk/LayoutTests/ChangeLog (230808 => 230809)

--- trunk/LayoutTests/ChangeLog	2018-04-19 17:36:40 UTC (rev 230808)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 17:49:21 UTC (rev 230809)
@@ -1,3 +1,11 @@
+2018-04-19  Ryan Haddad  
+
+Unreviewed test gardening for iOS simulator.
+
+* platform/ios-wk2/TestExpectations:
+* platform/ios-wk2/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Removed.
+* platform/ios/TestExpectations:
+
 2018-04-19  Nan Wang  
 
 AX: AOM: respect the accessibility setting for dispatching the accessible events


Modified: trunk/LayoutTests/platform/ios/TestExpectations (230808 => 230809)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-04-19 17:36:40 UTC (rev 230808)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-04-19 17:49:21 UTC (rev 230809)
@@ -3177,7 +3177,7 @@
 webkit.org/b/142087 fast/css3-text/css3-text-decoration/no-gap-between-two-rounded-textboxes.html [ ImageOnlyFailure ]
 webkit.org/b/142087 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-inherit.html [ ImageOnlyFailure ]
 
-webkit.org/b/177322 [ Debug ] imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html [ Pass Failure ]
+webkit.org/b/177322 imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html [ Pass Failure ]
 
 webkit.org/b/178029 http/tests/preload/viewport/meta-viewport-link-headers.php [ Pass Failure ]
 
@@ -3291,4 +3291,6 @@
 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/interfaces.any.worker.html [ Slow ]
 [ Debug ] imported/w3c/web-platform-tests/hr-time/idlharness.html [ Slow ]
 
-webkit.org/b/184783 compositing/ios/overflow-scroll-touch-tiles.html [ Pass Failure ]
+webkit.org/b/183388 fast/scrolling/scroll-to-focused-element-asynchronously.html [ Pass Failure ]
+
+webkit.org/b/184787 http/wpt/cache-storage/cache-quota.any.html [ Pass Failure ]


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (230808 => 230809)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-04-19 17:36:40 UTC (rev 230808)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-04-19 17:49:21 UTC (rev 230809)
@@ -1354,3 +1354,5 @@
 fast/text/international/hebrew-selection.html [ ImageOnlyFailure Pass ]
 imported/blink/editing/style/justify-left-crash.html [ ImageOnlyFailure Pass ]
 imported/blink/fast/css/user-select-none.html [ ImageOnlyFailure Pass ]
+
+webkit.org/b/184783 compositing/ios/overflow-scroll-touch-tiles.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230811] trunk/Source/WTF

[pvollan]

Title: [230811] trunk/Source/WTF








Revision 230811
Author pvol...@apple.com
Date 2018-04-19 11:25:36 -0700 (Thu, 19 Apr 2018)


Log Message
Unreviewed, rolling out r230677.

Introduced Netflix problems.

Reverted changeset:

"Deactivate the WindowServer connection for the WebContent process."
https://bugs.webkit.org/show_bug.cgi?id=184451
https://trac.webkit.org/changeset/230677

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h




Diff

Modified: trunk/Source/WTF/ChangeLog (230810 => 230811)

--- trunk/Source/WTF/ChangeLog	2018-04-19 17:54:35 UTC (rev 230810)
+++ trunk/Source/WTF/ChangeLog	2018-04-19 18:25:36 UTC (rev 230811)
@@ -1,3 +1,15 @@
+2018-04-19  Per Arne Vollan  
+
+Unreviewed, rolling out r230677.
+
+Introduced Netflix problems.
+
+Reverted changeset:
+
+"Deactivate the WindowServer connection for the WebContent process."
+https://bugs.webkit.org/show_bug.cgi?id=184451
+https://trac.webkit.org/changeset/230677
+
 2018-04-19  Nan Wang  
 
 AX: AOM: respect the accessibility setting for dispatching the accessible events


Modified: trunk/Source/WTF/wtf/FeatureDefines.h (230810 => 230811)

--- trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-19 17:54:35 UTC (rev 230810)
+++ trunk/Source/WTF/wtf/FeatureDefines.h	2018-04-19 18:25:36 UTC (rev 230811)
@@ -238,7 +238,7 @@
 #endif
 
 #if !defined(ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING)
-#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+#define ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING 0
 #endif
 
 #endif /* PLATFORM(MAC) */






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230812] trunk/Source

[beidson]

Title: [230812] trunk/Source








Revision 230812
Author beid...@apple.com
Date 2018-04-19 11:45:40 -0700 (Thu, 19 Apr 2018)


Log Message
Add globally-unique HistoryItem identifiers (and have WebKit2 adopt them).
 and https://bugs.webkit.org/show_bug.cgi?id=184750

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests (Refactor, no behavior change).

In WebCore, we:
- Add a process-unique "BackForwardItemIdentifier"
- Make all HistoryItems have such an identifier as a member

* WebCore.xcodeproj/project.pbxproj:

* history/BackForwardItemIdentifier.h: Added.
(WebCore::BackForwardItemIdentifier::logString const):
(WebCore::operator==):
(WebCore::BackForwardItemIdentifier::encode const):
(WebCore::BackForwardItemIdentifier::decode):
(WebCore::BackForwardItemIdentifier::hash const):
(WTF::BackForwardItemIdentifierHash::hash):
(WTF::BackForwardItemIdentifierHash::equal):
(WTF::HashTraits::emptyValue):
(WTF::HashTraits::constructDeletedValue):
(WTF::HashTraits::isDeletedValue):

* history/HistoryItem.cpp:
(WebCore::HistoryItem::generateSequenceNumber):
(WebCore::HistoryItem::HistoryItem):
(WebCore::generateSequenceNumber): Deleted.

* history/HistoryItem.h:
(WebCore::HistoryItem::create):
(WebCore::HistoryItem::identifier const):

Source/WebKit:

With process swapping, the assumption that "back/forward items belong to a process" is invalid.

All HistoryItem/WebBackForwardListItems now need to be uniquely identified across all processes,
no matter which process they originated from, so there will never be a collision in the UIProcess.

This allows us to:
- Have the UIProcess to keep a single process-wide map of all WebBackForwardListItems
- Get rid of the per-WebProcess WebBackForwardListItem map
- Simplify a lot of WebBackForwardList(Proxy) code that no longer needs to keep that per-process
  map in sync
- Get rid of a lot of other ancillary code

* Shared/SessionState.cpp:
(WebKit::BackForwardListItemState::decode):
* Shared/SessionState.h:

* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::~WebBackForwardListItem):
(WebKit::WebBackForwardListItem::itemForID):
(WebKit::WebBackForwardListItem::highestUsedItemID): Deleted.
* Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::itemID const):

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:

* UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::itemForID):
(WebKit::WebBackForwardList::pageClosed):
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::restoreFromState):
(WebKit::generateWebBackForwardItemID): Deleted.
* UIProcess/WebBackForwardList.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::maybeCreateSuspendedPage):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::backForwardAddItem):
(WebKit::WebPageProxy::backForwardGoToItem):
(WebKit::WebPageProxy::backForwardItemAtIndex):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::backForwardRemovedItem):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:

* UIProcess/WebProcessPool.cpp: Explicitly set the UIProcess Process::Identifier so it starts
  at "1" and then the first child process starts at "2", etc etc.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::checkURLReceivedFromWebProcess):
(WebKit::WebProcessProxy::updateBackForwardItem):
(WebKit::WebProcessProxy::webBackForwardItem const): Deleted.
(WebKit::WebProcessProxy::registerNewWebBackForwardListItem): Deleted.
(WebKit::WebProcessProxy::removeBackForwardItem): Deleted.
(WebKit::WebProcessProxy::addOrUpdateBackForwardItem): Deleted.
* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.messages.in:

* WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toBackForwardListItemState):
(WebKit::applyFrameState):
(WebKit::toHistoryItem):
(WebKit::toPageState): Deleted.
* WebProcess/WebCoreSupport/SessionStateConversion.h:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem const):

* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WK2NotifyHistoryItemChanged):
(WebKit::WebBackForwardListProxy::itemForID):
(WebKit::WebBackForwardListProxy::removeItem):
(WebKit::WebBackForwardListProxy::addItem): Previously this was a two-step process of adding an item
  to the process and then associating it with the page. Now it's just directly adding it to the page,
  so we don't need to call updateBackForwardItem first.
(WebKit::WebBackForwardListProxy::goToItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::close):
(WebKit::historyItemToIDMap): 

[webkit-changes] [230808] trunk

[n_wang]

Title: [230808] trunk








Revision 230808
Author n_w...@apple.com
Date 2018-04-19 10:36:40 -0700 (Thu, 19 Apr 2018)


Log Message
AX: AOM: respect the accessibility setting for dispatching the accessible events
https://bugs.webkit.org/show_bug.cgi?id=184619

Reviewed by Ryosuke Niwa.

Source/WebCore:

Added accessibilityEventsEnabled as a setting on the page.

Test: accessibility/ios-simulator/accessibility-events-setting.html

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::shouldDispatchAccessibilityEvent const):
* page/Settings.yaml:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setAccessibilityEventsEnabled):
* testing/InternalSettings.h:
* testing/InternalSettings.idl:

Source/WebKit:

Linked libAccessibility on iOS and macOS to use the platform accessibility settings
for allowing dispatching the accessibility events.

* Configurations/WebKit.xcconfig:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(accessibilityEventsEnabledChangedCallback):
(-[WKWebView _updateAccessibilityEventsEnabled]):
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateAccessibilityEventsEnabled):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateAccessibilityEventsEnabled):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Source/WTF:

* wtf/Platform.h:

LayoutTests:

* accessibility/ios-simulator/accessibility-events-setting-expected.txt: Added.
* accessibility/ios-simulator/accessibility-events-setting.html: Added.
* platform/ios-wk1/TestExpectations:
* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk1/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/page/Settings.yaml
trunk/Source/WebCore/testing/InternalSettings.cpp
trunk/Source/WebCore/testing/InternalSettings.h
trunk/Source/WebCore/testing/InternalSettings.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in


Added Paths

trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html




Diff

Modified: trunk/LayoutTests/ChangeLog (230807 => 230808)

--- trunk/LayoutTests/ChangeLog	2018-04-19 17:14:19 UTC (rev 230807)
+++ trunk/LayoutTests/ChangeLog	2018-04-19 17:36:40 UTC (rev 230808)
@@ -1,3 +1,15 @@
+2018-04-19  Nan Wang  
+
+AX: AOM: respect the accessibility setting for dispatching the accessible events
+https://bugs.webkit.org/show_bug.cgi?id=184619
+
+Reviewed by Ryosuke Niwa.
+
+* accessibility/ios-simulator/accessibility-events-setting-expected.txt: Added.
+* accessibility/ios-simulator/accessibility-events-setting.html: Added.
+* platform/ios-wk1/TestExpectations:
+* platform/ios-wk2/TestExpectations:
+
 2018-04-19  Tadeu Zagallo  
 
 Fix flakiness in worker-to-worker test


Added: trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt (0 => 230808)

--- trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting-expected.txt	2018-04-19 17:36:40 UTC (rev 230808)
@@ -0,0 +1,13 @@
+Click
+This tests that dispatching accessibility events is controled by iOS settings.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS receivedAXEvent is true
+PASS receivedAXEvent is false
+PASS receivedAXEvent is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html (0 => 230808)

--- trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/accessibility-events-setting.html	2018-04-19 17:36:40 UTC (rev 230808)
@@ -0,0 +1,52 @@
+
+
+
+
+
+
+Click
+
+

+

+
+