[webkit-changes] [258975] trunk/Source/WebCore
Title: [258975] trunk/Source/WebCore
Revision 258975
Author ctur...@igalia.com
Date 2020-03-25 03:19:09 -0700 (Wed, 25 Mar 2020)
Log Message
[GStreamer] Remove noisy warning about broken LC support
https://bugs.webkit.org/show_bug.cgi?id=209472
Reviewed by Philippe Normand.
* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::initializeGStreamer): There's no seemingly nice way of
ensuring this message is issued once in WebKit the
lifetime. Issuing multiple times is upsetting users. We can't rely
on Gst logging at this point, and there's no established story of
using the LOG_CHANNEL stuff on WPE/GTK ports for suppressible
WebKit message AFAICT.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (258974 => 258975)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 06:00:23 UTC (rev 258974)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 10:19:09 UTC (rev 258975)
@@ -1,3 +1,18 @@
+2020-03-25 Charlie Turner
+
+[GStreamer] Remove noisy warning about broken LC support
+https://bugs.webkit.org/show_bug.cgi?id=209472
+
+Reviewed by Philippe Normand.
+
+* platform/graphics/gstreamer/GStreamerCommon.cpp:
+(WebCore::initializeGStreamer): There's no seemingly nice way of
+ensuring this message is issued once in WebKit the
+lifetime. Issuing multiple times is upsetting users. We can't rely
+on Gst logging at this point, and there's no established story of
+using the LOG_CHANNEL stuff on WPE/GTK ports for suppressible
+WebKit message AFAICT.
+
2020-03-24 Andres Gonzalez
Avoid multiple unnecessary updates of the IsolatedTree.
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp (258974 => 258975)
--- trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2020-03-25 06:00:23 UTC (rev 258974)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp 2020-03-25 10:19:09 UTC (rev 258975)
@@ -268,8 +268,7 @@
if (avAACDecoderFactory)
gst_plugin_feature_set_rank(GST_PLUGIN_FEATURE_CAST(avAACDecoderFactory.get()), GST_RANK_MARGINAL);
}
-} else
-WTFLogAlways("WARNING: You might have broken LC support in your AAC decoders, consider installing fdkaacdec");
+}
#endif
});
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258976] trunk
Title: [258976] trunk
Revision 258976
Author shvaikal...@gmail.com
Date 2020-03-25 04:11:47 -0700 (Wed, 25 Mar 2020)
Log Message
\b escapes inside character classes should be valid in Unicode patterns
https://bugs.webkit.org/show_bug.cgi?id=209528
Reviewed by Darin Adler.
JSTests:
* test262/expectations.yaml: Mark 2 test cases as passing.
Source/_javascript_Core:
This change removes isIdentityEscapeAnError('b') check, allowing \b escapes
inside character classes in Unicode patterns match U+0008 (BACKSPACE) characters,
aligning JSC with V8 and SpiderMonkey.
Grammar: https://tc39.es/ecma262/#prod-ClassEscape
('b' comes before CharacterEscape :: IdentityEscape)
* yarr/YarrParser.h:
(JSC::Yarr::Parser::parseEscape):
LayoutTests:
* js/regexp-unicode-expected.txt:
* js/script-tests/regexp-unicode.js:
Modified Paths
trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/regexp-unicode-expected.txt
trunk/LayoutTests/js/script-tests/regexp-unicode.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrParser.h
Diff
Modified: trunk/JSTests/ChangeLog (258975 => 258976)
--- trunk/JSTests/ChangeLog 2020-03-25 10:19:09 UTC (rev 258975)
+++ trunk/JSTests/ChangeLog 2020-03-25 11:11:47 UTC (rev 258976)
@@ -1,3 +1,12 @@
+2020-03-25 Alexey Shvayka
+
+\b escapes inside character classes should be valid in Unicode patterns
+https://bugs.webkit.org/show_bug.cgi?id=209528
+
+Reviewed by Darin Adler.
+
+* test262/expectations.yaml: Mark 2 test cases as passing.
+
2020-03-24 Tadeu Zagallo
LLIntGenerator must link switch jumps to otherwise redundant labels
Modified: trunk/JSTests/test262/expectations.yaml (258975 => 258976)
--- trunk/JSTests/test262/expectations.yaml 2020-03-25 10:19:09 UTC (rev 258975)
+++ trunk/JSTests/test262/expectations.yaml 2020-03-25 11:11:47 UTC (rev 258976)
@@ -1711,9 +1711,6 @@
test/built-ins/RegExp/quantifier-integer-limit.js:
default: 'SyntaxError: Invalid regular _expression_: number too large in {} quantifier'
strict mode: 'SyntaxError: Invalid regular _expression_: number too large in {} quantifier'
-test/built-ins/RegExp/unicode_character_class_backspace_escape.js:
- default: 'SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern'
- strict mode: 'SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern'
test/built-ins/RegExp/unicode_restricted_identity_escape_alpha.js:
default: "Test262Error: IdentityEscape in AtomEscape: 'k' Expected a SyntaxError to be thrown but no exception was thrown at all"
strict mode: "Test262Error: IdentityEscape in AtomEscape: 'k' Expected a SyntaxError to be thrown but no exception was thrown at all"
Modified: trunk/LayoutTests/ChangeLog (258975 => 258976)
--- trunk/LayoutTests/ChangeLog 2020-03-25 10:19:09 UTC (rev 258975)
+++ trunk/LayoutTests/ChangeLog 2020-03-25 11:11:47 UTC (rev 258976)
@@ -1,3 +1,13 @@
+2020-03-25 Alexey Shvayka
+
+\b escapes inside character classes should be valid in Unicode patterns
+https://bugs.webkit.org/show_bug.cgi?id=209528
+
+Reviewed by Darin Adler.
+
+* js/regexp-unicode-expected.txt:
+* js/script-tests/regexp-unicode.js:
+
2020-03-24 Zalan Bujtas
[MultiColumn] Infinite recursion in RenderBlockFlow::relayoutToAvoidWidows
Modified: trunk/LayoutTests/js/regexp-unicode-expected.txt (258975 => 258976)
--- trunk/LayoutTests/js/regexp-unicode-expected.txt 2020-03-25 10:19:09 UTC (rev 258975)
+++ trunk/LayoutTests/js/regexp-unicode-expected.txt 2020-03-25 11:11:47 UTC (rev 258976)
@@ -187,7 +187,6 @@
PASS r = new RegExp("\\-", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
PASS r = new RegExp("\\a", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
PASS r = new RegExp("[\\a]", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
-PASS r = new RegExp("[\\b]", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
PASS r = new RegExp("[\\B]", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
PASS r = new RegExp("\\x", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
PASS r = new RegExp("[\\x]", "u") threw exception SyntaxError: Invalid regular _expression_: invalid escaped character for Unicode pattern.
Modified: trunk/LayoutTests/js/script-tests/regexp-unicode.js (258975 => 258976)
--- trunk/LayoutTests/js/script-tests/regexp-unicode.js 2020-03-25 10:19:09 UTC (rev 258975)
+++ trunk/LayoutTests/js/script-tests/regexp-unicode.js 2020-03-25 11:11:47 UTC (rev 258976)
@@ -247,7 +
[webkit-changes] [258977] trunk/Source/WebCore
Title: [258977] trunk/Source/WebCore Revision 258977 Author you...@apple.com Date 2020-03-25 06:44:17 -0700 (Wed, 25 Mar 2020) Log Message Audio fails to capture stream in WebRTC if AudioSession gets interrupted https://bugs.webkit.org/show_bug.cgi?id=208516 Reviewed by Eric Carlson. In case of page going to hidden, continue calling each capture factory to mute the corresponding sources if needed. In case of page being visible again, reset all tracks according page muted state. This allows restarting tracks that have been muted while page was hidden (video tracks or suspended audio tracks). Since tracks can go to muted when visibility changes, we no longer return early when setting the muted state of a page to the same value. Instead we apply it which ensures we comply with what UIProcess wants. We start removing the concept of a RealtimeMediaSource be interrupted. Instead we use muting of sources. This allows UIProcess or the page to override any muted state, for instance if page goes in foreground again. We update the AudioSharedUnit to allow restarting capture even if suspended. This ensures that we are able to restart capturing even if we do not receive the audio session end of interruption. Also, this notification sometimes takes a long time to happen and we do not want to wait for it when user is interacting with the page. A future refactoring will further remove RealtimeMediaSource interrupted-related code. Manually tested. * dom/Document.cpp: (WebCore::Document::visibilityStateChanged): * page/Page.cpp: (WebCore::Page::setMuted): * platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::isInterrupted const): * platform/mediastream/RealtimeMediaSource.cpp: (WebCore::RealtimeMediaSource::setInterrupted): (WebCore::RealtimeMediaSource::setMuted): * platform/mediastream/mac/BaseAudioSharedUnit.cpp: (WebCore::BaseAudioSharedUnit::startProducingData): (WebCore::BaseAudioSharedUnit::resume): (WebCore::BaseAudioSharedUnit::suspend): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/page/Page.cpp trunk/Source/WebCore/platform/audio/PlatformMediaSessionManager.h trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp trunk/Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (258976 => 258977) --- trunk/Source/WebCore/ChangeLog 2020-03-25 11:11:47 UTC (rev 258976) +++ trunk/Source/WebCore/ChangeLog 2020-03-25 13:44:17 UTC (rev 258977) @@ -1,3 +1,42 @@ +2020-03-25 Youenn Fablet + +Audio fails to capture stream in WebRTC if AudioSession gets interrupted +https://bugs.webkit.org/show_bug.cgi?id=208516 + + +Reviewed by Eric Carlson. + +In case of page going to hidden, continue calling each capture factory to mute the corresponding sources if needed. +In case of page being visible again, reset all tracks according page muted state. This allows restarting tracks that have been +muted while page was hidden (video tracks or suspended audio tracks). + +Since tracks can go to muted when visibility changes, we no longer return early when setting the muted state of a page to the same value. +Instead we apply it which ensures we comply with what UIProcess wants. + +We start removing the concept of a RealtimeMediaSource be interrupted. Instead we use muting of sources. +This allows UIProcess or the page to override any muted state, for instance if page goes in foreground again. + +We update the AudioSharedUnit to allow restarting capture even if suspended. +This ensures that we are able to restart capturing even if we do not receive the audio session end of interruption. +Also, this notification sometimes takes a long time to happen and we do not want to wait for it when user is interacting with the page. +A future refactoring will further remove RealtimeMediaSource interrupted-related code. + +Manually tested. + +* dom/Document.cpp: +(WebCore::Document::visibilityStateChanged): +* page/Page.cpp: +(WebCore::Page::setMuted): +* platform/audio/PlatformMediaSessionManager.h: +(WebCore::PlatformMediaSessionManager::isInterrupted const): +* platform/mediastream/RealtimeMediaSource.cpp: +(WebCore::RealtimeMediaSource::setInterrupted): +(WebCore::RealtimeMediaSource::setMuted): +* platform/mediastream/mac/BaseAudioSharedUnit.cpp: +(WebCore::BaseAudioSharedUnit::startProducingData): +(WebCore::BaseAudioSharedUnit::resume): +(WebCore::BaseAudioSharedUnit::suspend): + 2020-03-25 Charlie Turner [GStreamer] Remove noisy warni
[webkit-changes] [258978] trunk
Title: [258978] trunk
Revision 258978
Author commit-qu...@webkit.org
Date 2020-03-25 06:54:14 -0700 (Wed, 25 Mar 2020)
Log Message
[GTK] Add user agent quirk for auth.mayohr.com
https://bugs.webkit.org/show_bug.cgi?id=209378
Patch by Ting-Wei Lan on 2020-03-25
Reviewed by Michael Catanzaro.
Source/WebCore:
This site blocks the login page completely and asks the user to download
Google Chrome when using our standard user agent. It only blocks the
login page. After logging in, it works fine without user agent quirks.
Note that it is required to hide Version/X from the user agent string
for the site to recognize it as a valid Chrome user agent. Since Chrome
itself does not use Version/X, it should be safe to modify the existing
quirk instead of adding a new one to handle it.
* platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresNoSafariVersion):
(WebCore::UserAgentQuirks::quirksForURL):
(WebCore::UserAgentQuirks::stringForQuirk):
* platform/UserAgentQuirks.h:
* platform/glib/UserAgentGLib.cpp:
(WebCore::buildUserAgentString):
Tools:
* TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
(TestWebKitAPI::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/UserAgentQuirks.cpp
trunk/Source/WebCore/platform/glib/UserAgentGLib.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (258977 => 258978)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 13:44:17 UTC (rev 258977)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 13:54:14 UTC (rev 258978)
@@ -1,3 +1,28 @@
+2020-03-25 Ting-Wei Lan
+
+[GTK] Add user agent quirk for auth.mayohr.com
+https://bugs.webkit.org/show_bug.cgi?id=209378
+
+Reviewed by Michael Catanzaro.
+
+This site blocks the login page completely and asks the user to download
+Google Chrome when using our standard user agent. It only blocks the
+login page. After logging in, it works fine without user agent quirks.
+
+Note that it is required to hide Version/X from the user agent string
+for the site to recognize it as a valid Chrome user agent. Since Chrome
+itself does not use Version/X, it should be safe to modify the existing
+quirk instead of adding a new one to handle it.
+
+* platform/UserAgentQuirks.cpp:
+(WebCore::urlRequiresChromeBrowser):
+(WebCore::urlRequiresNoSafariVersion):
+(WebCore::UserAgentQuirks::quirksForURL):
+(WebCore::UserAgentQuirks::stringForQuirk):
+* platform/UserAgentQuirks.h:
+* platform/glib/UserAgentGLib.cpp:
+(WebCore::buildUserAgentString):
+
2020-03-25 Youenn Fablet
Audio fails to capture stream in WebRTC if AudioSession gets interrupted
Modified: trunk/Source/WebCore/platform/UserAgentQuirks.cpp (258977 => 258978)
--- trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2020-03-25 13:44:17 UTC (rev 258977)
+++ trunk/Source/WebCore/platform/UserAgentQuirks.cpp 2020-03-25 13:54:14 UTC (rev 258978)
@@ -62,7 +62,8 @@
// that works in Chrome that WebKit cannot handle. Prefer other quirks instead.
static bool urlRequiresChromeBrowser(const URL& url)
{
-String baseDomain = topPrivatelyControlledDomain(url.host().toString());
+String domain = url.host().toString();
+String baseDomain = topPrivatelyControlledDomain(domain);
// Needed for fonts on many sites to work with WebKit.
// https://bugs.webkit.org/show_bug.cgi?id=147296
@@ -69,6 +70,11 @@
if (baseDomain == "typekit.net" || baseDomain == "typekit.com")
return true;
+// This site completely blocks the login page with WebKitGTK's standard user
+// agent and ask users to use Google Chrome or Microsoft Internet Explorer.
+if (domain == "auth.mayohr.com")
+return true;
+
return false;
}
Modified: trunk/Source/WebCore/platform/glib/UserAgentGLib.cpp (258977 => 258978)
--- trunk/Source/WebCore/platform/glib/UserAgentGLib.cpp 2020-03-25 13:44:17 UTC (rev 258977)
+++ trunk/Source/WebCore/platform/glib/UserAgentGLib.cpp 2020-03-25 13:54:14 UTC (rev 258978)
@@ -104,15 +104,16 @@
uaString.append(versionForUAString());
uaString.appendLiteral(" (KHTML, like Gecko) ");
-// Note that Chrome UAs advertise *both* Chrome and Safari.
+// Note that Chrome UAs advertise *both* Chrome/X and Safari/X, but it does
+// not advertise Version/X.
if (quirks.contains(UserAgentQuirks::NeedsChromeBrowser)) {
uaString.append(UserAgentQuirks::stringForQuirk(UserAgentQuirks::NeedsChromeBrowser));
uaString.appendLiteral(" ");
-}
-
// Version/X is mandatory *before* Safari/X to be a valid Safari UA. See
// https://bugs.webkit.org/show_bug.cgi?id=133403 for details.
-uaString.appendLiteral("Version/13.0 Safari/");
+} else
+uaStr
[webkit-changes] [258979] trunk/LayoutTests
Title: [258979] trunk/LayoutTests Revision 258979 Author dp...@igalia.com Date 2020-03-25 07:05:23 -0700 (Wed, 25 Mar 2020) Log Message [GTK] Gardening, update TestExpectations https://bugs.webkit.org/show_bug.cgi?id=209534 Unreviewed gardening. Gardening of flaky tests and of tests that are failing in the EWS bot but not in the test bot. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (258978 => 258979) --- trunk/LayoutTests/ChangeLog 2020-03-25 13:54:14 UTC (rev 258978) +++ trunk/LayoutTests/ChangeLog 2020-03-25 14:05:23 UTC (rev 258979) @@ -1,3 +1,15 @@ +2020-03-25 Diego Pino Garcia + +[GTK] Gardening, update TestExpectations +https://bugs.webkit.org/show_bug.cgi?id=209534 + +Unreviewed gardening. + +Gardening of flaky tests and of tests that are failing in the EWS bot +but not in the test bot. + +* platform/gtk/TestExpectations: + 2020-03-25 Alexey Shvayka \b escapes inside character classes should be valid in Unicode patterns Modified: trunk/LayoutTests/platform/gtk/TestExpectations (258978 => 258979) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-03-25 13:54:14 UTC (rev 258978) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-03-25 14:05:23 UTC (rev 258979) @@ -1484,6 +1484,11 @@ webkit.org/b/207737 imported/w3c/web-platform-tests/media-source/mediasource-h264-play-starved.html [ Pass Crash ] +# Tests crashing in EWS but not in test bot. +webkit.org/b/209533 http/tests/contentextensions/video-element-resource-type.html [ Crash Pass ] +webkit.org/b/209533 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadstart_noautoplay.html [ Crash Pass ] +webkit.org/b/209533 media/track/track-automatic-subtitles.html [ Crash Pass ] + # # End of Crashing tests # @@ -2703,7 +2708,12 @@ webkit.org/b/208301 editing/pasteboard/4922709.html [ Failure Pass ] webkit.org/b/208301 editing/pasteboard/5028447.html [ Failure Pass ] +webkit.org/b/208301 editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html [ Failure Pass ] webkit.org/b/208301 editing/pasteboard/paste-before-tab-span.html [ Failure Pass ] +webkit.org/b/208301 editing/pasteboard/paste-line-endings-003.html [ Failure Pass ] +webkit.org/b/208301 editing/pasteboard/paste-line-endings-007.html [ Failure Pass ] +webkit.org/b/208301 editing/pasteboard/paste-text-005.html [ Failure Pass ] +webkit.org/b/208301 editing/pasteboard/pasting-into-p-should-not-nest-p.html [ Failure Pass ] webkit.org/b/208304 http/tests/cache/disk-cache/speculative-validation/validation-request.html [ Failure Pass ] @@ -2771,6 +2781,10 @@ webkit.org/b/209102 accessibility/accessibility-node-memory-management.html [ Failure Pass ] +webkit.org/b/209474 media/media-can-play-ogg.html [ Failure Pass ] + +webkit.org/b/209475 fast/hidpi/hidpi-long-page-with-inset-element.html [ ImageOnlyFailure Pass ] + # # End of Flaky tests # @@ -3168,6 +3182,13 @@ webkit.org/b/208000 [ Debug ] inspector/unit-tests/throttler.html [ Failure Timeout ] webkit.org/b/208000 [ Debug ] inspector/unit-tests/url-utilities.html [ Timeout ] +# Tests timing out in EWS but not test-bot. +webkit.org/b/209533 fast/frames/exponential-frames.html [ Timeout Pass ] +webkit.org/b/209533 http/tests/appcache/top-frame-2.html [ Timeout Pass ] +webkit.org/b/209533 http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html [ Timeout Pass ] +webkit.org/b/209533 http/tests/workers/service/Client-properties.html [ Timeout Pass ] +webkit.org/b/209533 media/video-isplayingtoautomotiveheadunit.html [ Timeout Pass ] + # These entries are commented to avoid a lint error of duplicated bug entry. # webkit.org/b/208630 fast/scrolling/arrow-key-scroll-in-rtl-document.html [ Timeout ] # webkit.org/b/208630 fast/scrolling/overflow-scroll-past-max.html [ Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258980] trunk/Source
Title: [258980] trunk/Source Revision 258980 Author wenson_hs...@apple.com Date 2020-03-25 08:05:52 -0700 (Wed, 25 Mar 2020) Log Message Avoid querying pasteboard strings while dragging content over a potential drop target https://bugs.webkit.org/show_bug.cgi?id=209531 Reviewed by Tim Horton and Ryosuke Niwa. Source/WebCore: A couple of places in WebCore currently use PasteboardStrategy::stringForType() to query for pasteboard URL strings. These call sites attempt to read URL strings (using both readString and stringForType) for the purposes of checking whether or not we should avoid exposing the URL string to web content (note that in the case of containsPlainText, we actually check whether or not the string is empty, which depends on whether or not the string is safe to expose to the web -- e.g., not a file URL). This is incompatible with some changes in the near future which will prevent the web content process from reading any data from the pasteboard, if a paste or drop action has not yet been performed. To address this issue, we introduce an alternate PasteboardStrategy method, containsStringSafeForDOMToReadForType, which returns (for a given platform pasteboard type) whether or not a string that can be safely exposed to bindings exists. Rather than allow the web process to read the entire string, limit it to just this true/false answer. * platform/PasteboardStrategy.h: * platform/PlatformPasteboard.h: * platform/cocoa/DragDataCocoa.mm: (WebCore::DragData::containsPlainText const): Use containsStringSafeForDOMToReadForType instead of stringForType. * platform/cocoa/PasteboardCocoa.mm: (WebCore::Pasteboard::fileContentState): Use containsStringSafeForDOMToReadForType instead of readString. * platform/cocoa/PlatformPasteboardCocoa.mm: (WebCore::PlatformPasteboard::containsStringSafeForDOMToReadForType const): Source/WebKit: Add PasteboardStrategy and WebPasteboardProxy (IPC) plumbing; see WebCore for more details. * UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::containsStringSafeForDOMToReadForType): * UIProcess/WebPasteboardProxy.cpp: (WebKit::WebPasteboardProxy::containsStringSafeForDOMToReadForType): * UIProcess/WebPasteboardProxy.h: * UIProcess/WebPasteboardProxy.messages.in: * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::containsStringSafeForDOMToReadForType): * WebProcess/WebCoreSupport/WebPlatformStrategies.h: Source/WebKitLegacy/mac: Add PasteboardStrategy plumbing; see WebCore for more details. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::containsStringSafeForDOMToReadForType): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/PasteboardStrategy.h trunk/Source/WebCore/platform/PlatformPasteboard.h trunk/Source/WebCore/platform/cocoa/DragDataCocoa.mm trunk/Source/WebCore/platform/cocoa/PasteboardCocoa.mm trunk/Source/WebCore/platform/cocoa/PlatformPasteboardCocoa.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm trunk/Source/WebKit/UIProcess/WebPasteboardProxy.cpp trunk/Source/WebKit/UIProcess/WebPasteboardProxy.h trunk/Source/WebKit/UIProcess/WebPasteboardProxy.messages.in trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.h trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm Diff Modified: trunk/Source/WebCore/ChangeLog (258979 => 258980) --- trunk/Source/WebCore/ChangeLog 2020-03-25 14:05:23 UTC (rev 258979) +++ trunk/Source/WebCore/ChangeLog 2020-03-25 15:05:52 UTC (rev 258980) @@ -1,3 +1,38 @@ +2020-03-25 Wenson Hsieh + +Avoid querying pasteboard strings while dragging content over a potential drop target +https://bugs.webkit.org/show_bug.cgi?id=209531 + +Reviewed by Tim Horton and Ryosuke Niwa. + +A couple of places in WebCore currently use PasteboardStrategy::stringForType() to query for pasteboard URL +strings. These call sites attempt to read URL strings (using both readString and stringForType) for the purposes +of checking whether or not we should avoid exposing the URL string to web content (note that in the case of +containsPlainText, we actually check whether or not the string is empty, which depends on whether or not the +string is safe to expose to the web -- e.g., not a file URL). + +This is incompatible with some changes in the near future which will prevent the web content process from +reading any data from the pasteboard, if a paste or drop action has not yet been performed. To address this +issue, we introduce an alternate PasteboardStrategy method, containsStringSafeForDOMToReadForType, which returns +(for a given platform pastebo
[webkit-changes] [258981] trunk/LayoutTests
Title: [258981] trunk/LayoutTests Revision 258981 Author tsav...@apple.com Date 2020-03-25 08:20:05 -0700 (Wed, 25 Mar 2020) Log Message [ios] svg/custom/object-sizing-explicit-width.xhtml is flaky failure https://bugs.webkit.org/show_bug.cgi?id=209544 Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (258980 => 258981) --- trunk/LayoutTests/ChangeLog 2020-03-25 15:05:52 UTC (rev 258980) +++ trunk/LayoutTests/ChangeLog 2020-03-25 15:20:05 UTC (rev 258981) @@ -1,3 +1,12 @@ +2020-03-25 Truitt Savell + +[ios] svg/custom/object-sizing-explicit-width.xhtml is flaky failure +https://bugs.webkit.org/show_bug.cgi?id=209544 + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-03-25 Diego Pino Garcia [GTK] Gardening, update TestExpectations Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (258980 => 258981) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-25 15:05:52 UTC (rev 258980) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-25 15:20:05 UTC (rev 258981) @@ -1649,4 +1649,6 @@ webkit.org/b/209512 http/tests/cache/disk-cache/disk-cache-vary-cookie-private.html [ Pass Timeout ] -webkit.org/b/209520 http/wpt/fetch/dnt-header-after-redirection.html [ Pass Timeout ] \ No newline at end of file +webkit.org/b/209520 http/wpt/fetch/dnt-header-after-redirection.html [ Pass Timeout ] + +webkit.org/b/209544 svg/custom/object-sizing-explicit-width.xhtml [ Pass Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258982] trunk/Source/ThirdParty/libwebrtc
Title: [258982] trunk/Source/ThirdParty/libwebrtc
Revision 258982
Author you...@apple.com
Date 2020-03-25 08:53:05 -0700 (Wed, 25 Mar 2020)
Log Message
Bump rnnoise to M82
https://bugs.webkit.org/show_bug.cgi?id=209541
Reviewed by Eric Carlson.
* CMakeLists.txt:
* Source/third_party/rnnoise: Updated.
* libwebrtc.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/BUILD.gn
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/OWNERS
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/README.chromium
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Removed Paths
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/DEPS
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/src/kiss_fft.cc
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/src/kiss_fft.h
trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/src/kiss_fft_unittest.cc
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2020-03-25 15:53:05 UTC (rev 258982)
@@ -334,7 +334,6 @@
Source/third_party/libyuv/source/scale_neon64.cc
Source/third_party/libyuv/source/video_common.cc
Source/third_party/pffft/src/pffft.c
-Source/third_party/rnnoise/src/kiss_fft.cc
Source/third_party/rnnoise/src/rnn_vad_weights.cc
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c
Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_auth.c
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2020-03-25 15:53:05 UTC (rev 258982)
@@ -1,3 +1,14 @@
+2020-03-25 youenn fablet
+
+Bump rnnoise to M82
+https://bugs.webkit.org/show_bug.cgi?id=209541
+
+Reviewed by Eric Carlson.
+
+* CMakeLists.txt:
+* Source/third_party/rnnoise: Updated.
+* libwebrtc.xcodeproj/project.pbxproj:
+
2020-03-19 Alex Christensen
Cherry pick usrsctp commit 790a7a2555aefb392a5a69923f1e9d17b4968467
Modified: trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/BUILD.gn (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/BUILD.gn 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/BUILD.gn 2020-03-25 15:53:05 UTC (rev 258982)
@@ -5,19 +5,9 @@
import("//testing/test.gni")
group("rnnoise") {
- deps = [
-":kiss_fft",
-":rnn_vad",
- ]
+ deps = [ ":rnn_vad" ]
}
-source_set("kiss_fft") {
- sources = [
-"src/kiss_fft.cc",
-"src/kiss_fft.h",
- ]
-}
-
source_set("rnn_vad") {
sources = [
"src/rnn_activations.h",
@@ -25,14 +15,3 @@
"src/rnn_vad_weights.h",
]
}
-
-test("kiss_fft_unittest") {
- sources = [
-"src/kiss_fft_unittest.cc",
- ]
- deps = [
-":kiss_fft",
-"//testing/gtest",
-"//testing/gtest:gtest_main",
- ]
-}
Deleted: trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/DEPS (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/DEPS 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/DEPS 2020-03-25 15:53:05 UTC (rev 258982)
@@ -1,3 +0,0 @@
-include_rules = [
- "+testing/gtest/include/gtest",
-]
Modified: trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/OWNERS (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/OWNERS 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/OWNERS 2020-03-25 15:53:05 UTC (rev 258982)
@@ -1,2 +1,3 @@
aless...@chromium.org
ale...@chromium.org
+# COMPONENT: Tools
Modified: trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/README.chromium (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/README.chromium 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/README.chromium 2020-03-25 15:53:05 UTC (rev 258982)
@@ -25,4 +25,5 @@
* rnn_vad_weights.h: output layer sizes + weights scaling factor
* removing unwanted extern from constants in rnn_vad_weights.h and using
constants to declare array sizes
-* Add braces around arrays in unit test.
\ No newline at end of file
+* Add braces around arrays in unit test.
+* KissFFT removed
Deleted: trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/src/kiss_fft.cc (258981 => 258982)
--- trunk/Source/ThirdParty/libwebrtc/Source/third_party/rnnoise/src/kiss_fft.cc 2020-03-25 15:20:05 UTC (rev 258981)
+++ trunk/Source/ThirdPa
[webkit-changes] [258985] trunk
Title: [258985] trunk
Revision 258985
Author simon.fra...@apple.com
Date 2020-03-25 09:19:00 -0700 (Wed, 25 Mar 2020)
Log Message
REGRESSION (r251385): box-shadow interferes with backdrop-filter
https://bugs.webkit.org/show_bug.cgi?id=208070
Reviewed by Dean Jackson.
Source/WebCore:
updateClippingStrategy() compares the rounded rect passed in with the geometry
of the first layer argument, so the rect needs to have a zero origin. We do
the same computation in GraphicsLayerCA::updateContentsRects().
Test: compositing/filters/backdrop-filter-rect.html
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateBackdropFiltersRect):
LayoutTests:
* compositing/filters/backdrop-filter-rect-expected.html: Added.
* compositing/filters/backdrop-filter-rect.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
Added Paths
trunk/LayoutTests/compositing/filters/backdrop-filter-rect-expected.html
trunk/LayoutTests/compositing/filters/backdrop-filter-rect.html
Diff
Modified: trunk/LayoutTests/ChangeLog (258984 => 258985)
--- trunk/LayoutTests/ChangeLog 2020-03-25 15:59:15 UTC (rev 258984)
+++ trunk/LayoutTests/ChangeLog 2020-03-25 16:19:00 UTC (rev 258985)
@@ -1,3 +1,14 @@
+2020-03-25 Simon Fraser
+
+REGRESSION (r251385): box-shadow interferes with backdrop-filter
+https://bugs.webkit.org/show_bug.cgi?id=208070
+
+
+Reviewed by Dean Jackson.
+
+* compositing/filters/backdrop-filter-rect-expected.html: Added.
+* compositing/filters/backdrop-filter-rect.html: Added.
+
2020-03-25 Truitt Savell
[ios] svg/custom/object-sizing-explicit-width.xhtml is flaky failure
Added: trunk/LayoutTests/compositing/filters/backdrop-filter-rect-expected.html (0 => 258985)
--- trunk/LayoutTests/compositing/filters/backdrop-filter-rect-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/filters/backdrop-filter-rect-expected.html 2020-03-25 16:19:00 UTC (rev 258985)
@@ -0,0 +1,37 @@
+
+
+
+
+img {
+background-color: green;
+height: 500px;
+width: 500px;
+}
+
+.backdrop {
+position: absolute;
+height: 200px;
+width: 200px;
+left: 140px;
+top: 140px;
+background-color: rgba(0, 0, 0, 0.2);
+-webkit-backdrop-filter: saturate(0);
+}
+
+.extender {
+position: absolute;
+height: 20px;
+width: 20px;
+top: 40px;
+left: 40px;
+background-color: blue;
+}
+}
+
+
+
+
+
+
+
+
Added: trunk/LayoutTests/compositing/filters/backdrop-filter-rect.html (0 => 258985)
--- trunk/LayoutTests/compositing/filters/backdrop-filter-rect.html (rev 0)
+++ trunk/LayoutTests/compositing/filters/backdrop-filter-rect.html 2020-03-25 16:19:00 UTC (rev 258985)
@@ -0,0 +1,38 @@
+
+
+
+
+img {
+background-color: green;
+height: 500px;
+width: 500px;
+}
+
+.backdrop {
+position: absolute;
+height: 200px;
+width: 200px;
+left: 140px;
+top: 140px;
+background-color: rgba(0, 0, 0, 0.2);
+-webkit-backdrop-filter: saturate(0);
+}
+
+.extender {
+position: absolute;
+height: 20px;
+width: 20px;
+top: -100px;
+left: -100px;
+background-color: blue;
+}
+}
+
+
+
+
+
+
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (258984 => 258985)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 15:59:15 UTC (rev 258984)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 16:19:00 UTC (rev 258985)
@@ -1,3 +1,20 @@
+2020-03-25 Simon Fraser
+
+REGRESSION (r251385): box-shadow interferes with backdrop-filter
+https://bugs.webkit.org/show_bug.cgi?id=208070
+
+
+Reviewed by Dean Jackson.
+
+updateClippingStrategy() compares the rounded rect passed in with the geometry
+of the first layer argument, so the rect needs to have a zero origin. We do
+the same computation in GraphicsLayerCA::updateContentsRects().
+
+Test: compositing/filters/backdrop-filter-rect.html
+
+* platform/graphics/ca/GraphicsLayerCA.cpp:
+(WebCore::GraphicsLayerCA::updateBackdropFiltersRect):
+
2020-03-25 Wenson Hsieh
Avoid querying pasteboard strings while dragging content over a potential drop target
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (258984 => 258985)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2020-03-25 15:59:15 UTC (rev 258984)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2020-03-25 16:19:00 UTC (rev 258985)
@@ -2276,7 +2276,9 @@
m_backdropLayer->setBounds(contentBounds);
m_backdropLayer->setPosition(m_backdropFiltersRect.rect().location());
-updateClippingStrategy(*m_b
[webkit-changes] [258986] trunk/Source
Title: [258986] trunk/Source
Revision 258986
Author katherine_che...@apple.com
Date 2020-03-25 09:29:54 -0700 (Wed, 25 Mar 2020)
Log Message
App-bound domain checks should provide more debugging details at script evaluation sites
https://bugs.webkit.org/show_bug.cgi?id=209521
Reviewed by Chris Dumez.
Source/WebCore:
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
Return makeUnexpected object with an error message instead of null to
provide more details as to why the executeScriptInWorld()
call was not completed. Also add console logging and release logging.
* page/Frame.cpp:
(WebCore::Frame::injectUserScriptImmediately):
There is no option to return an exception here, so this patch adds
console logging and release logging.
Source/WebKit:
Return an exception because that option is available here, and also add
console and release logging for consistency across app-bound domain checks.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScript):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (258985 => 258986)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 16:19:00 UTC (rev 258985)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 16:29:54 UTC (rev 258986)
@@ -1,3 +1,22 @@
+2020-03-25 Kate Cheney
+
+App-bound domain checks should provide more debugging details at script evaluation sites
+https://bugs.webkit.org/show_bug.cgi?id=209521
+
+
+Reviewed by Chris Dumez.
+
+* bindings/js/ScriptController.cpp:
+(WebCore::ScriptController::executeScriptInWorld):
+Return makeUnexpected object with an error message instead of null to
+provide more details as to why the executeScriptInWorld()
+call was not completed. Also add console logging and release logging.
+
+* page/Frame.cpp:
+(WebCore::Frame::injectUserScriptImmediately):
+There is no option to return an exception here, so this patch adds
+console logging and release logging.
+
2020-03-25 Simon Fraser
REGRESSION (r251385): box-shadow interferes with backdrop-filter
Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (258985 => 258986)
--- trunk/Source/WebCore/bindings/js/ScriptController.cpp 2020-03-25 16:19:00 UTC (rev 258985)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp 2020-03-25 16:29:54 UTC (rev 258986)
@@ -40,6 +40,7 @@
#include "JSDocument.h"
#include "JSExecState.h"
#include "LoadableModuleScript.h"
+#include "Logging.h"
#include "ModuleFetchFailureKind.h"
#include "ModuleFetchParameters.h"
#include "NP_jsobject.h"
@@ -77,6 +78,8 @@
#include
#include
+#define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(m_frame.isAlwaysOnLoggingAllowed(), channel, "%p - ScriptController::" fmt, this, ##__VA_ARGS__)
+
namespace WebCore {
using namespace JSC;
@@ -576,8 +579,12 @@
ValueOrException ScriptController::executeScriptInWorld(DOMWrapperWorld& world, RunJavaScriptParameters&& parameters)
{
-if (m_frame.loader().client().hasNavigatedAwayFromAppBoundDomain() && !m_frame.loader().client().needsInAppBrowserPrivacyQuirks())
-return jsNull();
+if (m_frame.loader().client().hasNavigatedAwayFromAppBoundDomain() && !m_frame.loader().client().needsInAppBrowserPrivacyQuirks()) {
+if (auto* document = m_frame.document())
+document->addConsoleMessage(MessageSource::Security, MessageLevel::Warning, "Ignoring user script injection for non-app bound domain.");
+RELEASE_LOG_ERROR_IF_ALLOWED(Loading, "executeScriptInWorld: Ignoring user script injection for non app-bound domain");
+return makeUnexpected(ExceptionDetails { "Ignoring user script injection for non-app bound domain"_s });
+}
UserGestureIndicator gestureIndicator(parameters.forceUserGesture == ForceUserGesture::Yes ? Optional(ProcessingUserGesture) : WTF::nullopt);
@@ -860,3 +867,5 @@
}
} // namespace WebCore
+
+#undef RELEASE_LOG_ERROR_IF_ALLOWED
Modified: trunk/Source/WebCore/page/Frame.cpp (258985 => 258986)
--- trunk/Source/WebCore/page/Frame.cpp 2020-03-25 16:19:00 UTC (rev 258985)
+++ trunk/Source/WebCore/page/Frame.cpp 2020-03-25 16:29:54 UTC (rev 258986)
@@ -107,6 +107,8 @@
#include
#include
+#define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), channel, "%p - Frame::" fmt, this, ##__VA_ARGS__)
+
namespace WebCore {
using namespace HTMLNames;
@@ -624,8 +626,12 @@
void Frame::injectUserScriptImmediately(DOMWrapperWorld& world, const UserScript& script)
{
-if (loader().client().hasNavigatedAwayFromAppBoundDomain() && !loader().client().needsInAppBrowserPrivacyQuirks())
+if (loader().client().hasNavigatedAw
[webkit-changes] [258987] trunk/Source/WebCore
Title: [258987] trunk/Source/WebCore Revision 258987 Author svil...@igalia.com Date 2020-03-25 09:32:00 -0700 (Wed, 25 Mar 2020) Log Message Use ENABLE_WEBXR to guard WebXR IDL files in CMakeLists.txt https://bugs.webkit.org/show_bug.cgi?id=209536 Reviewed by Darin Adler. * CMakeLists.txt: replaced ENABLE_WEBGL by ENABLE_WEBXR. Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog Diff Modified: trunk/Source/WebCore/CMakeLists.txt (258986 => 258987) --- trunk/Source/WebCore/CMakeLists.txt 2020-03-25 16:29:54 UTC (rev 258986) +++ trunk/Source/WebCore/CMakeLists.txt 2020-03-25 16:32:00 UTC (rev 258987) @@ -1180,7 +1180,7 @@ ) endif () -if (ENABLE_WEBGL) +if (ENABLE_WEBXR) list(APPEND WebCore_NON_SVG_IDL_FILES Modules/webxr/NavigatorWebXR.idl Modules/webxr/WebXRBoundedReferenceSpace.idl Modified: trunk/Source/WebCore/ChangeLog (258986 => 258987) --- trunk/Source/WebCore/ChangeLog 2020-03-25 16:29:54 UTC (rev 258986) +++ trunk/Source/WebCore/ChangeLog 2020-03-25 16:32:00 UTC (rev 258987) @@ -1,3 +1,12 @@ +2020-03-25 Sergio Villar Senin + +Use ENABLE_WEBXR to guard WebXR IDL files in CMakeLists.txt +https://bugs.webkit.org/show_bug.cgi?id=209536 + +Reviewed by Darin Adler. + +* CMakeLists.txt: replaced ENABLE_WEBGL by ENABLE_WEBXR. + 2020-03-25 Kate Cheney App-bound domain checks should provide more debugging details at script evaluation sites ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258988] branches/safari-609-branch/Source/WebCore/platform/mediastream/ mac
Title: [258988] branches/safari-609-branch/Source/WebCore/platform/mediastream/mac
Revision 258988
Author repst...@apple.com
Date 2020-03-25 09:49:28 -0700 (Wed, 25 Mar 2020)
Log Message
Apply patch. rdar://problem/60827023
Modified Paths
branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp
branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h
Diff
Modified: branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp (258987 => 258988)
--- branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp 2020-03-25 16:32:00 UTC (rev 258987)
+++ branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp 2020-03-25 16:49:28 UTC (rev 258988)
@@ -61,6 +61,9 @@
if (m_dataSource)
m_dataSource->setPaused(true);
+m_isAudioUnitStarted = false;
+m_isPlaying = false;
+
if (m_remoteIOUnit) {
AudioOutputUnitStop(m_remoteIOUnit);
AudioComponentInstanceDispose(m_remoteIOUnit);
@@ -84,6 +87,11 @@
if (m_dataSource)
m_dataSource->setPaused(false);
+
+if (m_isCleared) {
+streamTrack().source().addObserver(*this);
+m_isCleared = false;
+}
}
void AudioTrackPrivateMediaStreamCocoa::play()
@@ -98,6 +106,8 @@
if (!m_isPlaying)
return;
+clear();
+
m_isPlaying = false;
m_autoPlay = false;
@@ -256,6 +266,19 @@
pause();
}
+void AudioTrackPrivateMediaStreamCocoa::sourceMutedChanged()
+{
+if (streamTrack().muted())
+return;
+
+if (!m_isPlaying)
+return;
+
+// If we we want to play and were muted, we restart from scratch by doing a pause/start.
+pause();
+play();
+}
+
OSStatus AudioTrackPrivateMediaStreamCocoa::render(UInt32 sampleCount, AudioBufferList& ioData, UInt32 /*inBusNumber*/, const AudioTimeStamp& timeStamp, AudioUnitRenderActionFlags& actionFlags)
{
// This function is called on a high-priority background thread. The following protectedThis object ensures the object is not
Modified: branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h (258987 => 258988)
--- branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h 2020-03-25 16:32:00 UTC (rev 258987)
+++ branches/safari-609-branch/Source/WebCore/platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h 2020-03-25 16:49:28 UTC (rev 258988)
@@ -63,6 +63,7 @@
// RealtimeMediaSource::Observer
void sourceStopped() final;
+void sourceMutedChanged() final;
void audioSamplesAvailable(const MediaTime&, const PlatformAudioData&, const AudioStreamDescription&, size_t) final;
static OSStatus inputProc(void*, AudioUnitRenderActionFlags*, const AudioTimeStamp*, UInt32 inBusNumber, UInt32 numberOfFrames, AudioBufferList*);
@@ -72,6 +73,7 @@
void cleanup();
void zeroBufferList(AudioBufferList&, size_t);
void playInternal();
+void stop();
#if !RELEASE_LOG_DISABLED
const char* logClassName() const final { return "AudioTrackPrivateMediaStreamCocoa"; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258989] trunk
Title: [258989] trunk Revision 258989 Author dba...@webkit.org Date 2020-03-25 09:50:27 -0700 (Wed, 25 Mar 2020) Log Message [iOS] ASSERTION FAILURE: !isMissingPostLayoutData in WebKit::EditorState::postLayoutData() https://bugs.webkit.org/show_bug.cgi?id=199960 Reviewed by Simon Fraser. Source/WebKit: Refactor the computation of editor state so that we can request that a layout be performed each time we compute the editor state as part of asking the UI process to interpret a key event. The full (read: after layout) editor state is needed for UIKit to perform a deletion because UIKit wants to know how many characters are before the selection. Otherwise, we hit an assert due to the fact the last editor state sent (when the Web process asked the UI process to interpret the key) is missing layout data. The refactoring also moves the Cocoa-common code out of the platform-independent WebPage.cpp file into WebPageCocoa.mm. One side effect of the refactoring is that we no longer allow the platformEditorState() function to override the isMissingPostLayoutData bit. Currently it can even though the calling code, the platform independent code (PIE) in WebPage, may have attached layout data. Now the PIE code sets this bit if it attached layout data and the platformEditorState() function only attaches more layout data if that bit is set. platformEditorState() never unsets that bit (i.e. sets isMissingPostLayoutData to true). The patch also removes m_isEditorStateMissingPostLayoutData in WebPage.h. This instance variable has been unused since . Also we haven't been using IncludePostLayoutDataHint::No since the last reference to it was removed in . I also renamed platformEditorState() to getPlatformEditorState() since it has an out argument. Test: editing/deleting/ios/backspace-last-character.html * Shared/EditorState.h: * UIProcess/API/glib/WebKitEditorState.cpp: (webkitEditorStateCreate): Initialize _WebKitEditorStatePrivate::typingAttributes to WEBKIT_EDITOR_TYPING_ATTRIBUTE_NONE. * WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::getPlatformEditorStateCommon const): Added. Moved Cocoa-common code from WebPage.cpp to here. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState const): Move Cocoa-common code to WebPageCocoa.mm. Change enum to track whether a layout should be performed. Keep the current behavior of only including post layout data if the frame view does not need a layout. This behavior is encoded in the enumerator ShouldPerformLayout::Default. which is the default argument value for the argument shouldPerformLayout. * WebProcess/WebPage/WebPage.h: (WebKit::WebPage::platformNeedsLayoutForEditorState const): Added. Non-Cocoa port implementation that returns false. * WebProcess/WebPage/glib/WebPageGLib.cpp: (WebKit::WebPage::getPlatformEditorState const): Early return if isMissingPostLayoutData is true. (WebKit::WebPage::platformEditorState const): Deleted. * WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformNeedsLayoutForEditorState const): Added. Keep the current behavior of performing a layout if we have a composition or a hardware keyboard is attached. (WebKit::WebPage::getPlatformEditorState const): Call platformEditorStateCommon(). Bail out early if isMissingPostLayoutData is true. (WebKit::WebPage::handleEditingKeyboardEvent): The important part of this patch. Request a layout when computing the editor state that we will send to the UI process. (WebKit::WebPage::platformEditorState const): Deleted. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getPlatformEditorState const): Call platformEditorStateCommon(). Bail out early if isMissingPostLayoutData is true. (WebKit::WebPage::platformEditorState const): Deleted. * WebProcess/WebPage/playstation/WebPagePlayStation.cpp: (WebKit::WebPage::getPlatformEditorState const): Update as needed. (WebKit::WebPage::platformEditorState const): Deleted. * WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::getPlatformEditorState const): Update as needed. (WebKit::WebPage::platformEditorState const): Deleted. LayoutTests: Add a test to ensure we do not assert when using the software keyboard to type a character into a and then delete it. * TestExpectations: Skip tests in editing/deleting/ios on all platforms. * editing/deleting/ios/backspace-last-character-expected.txt: Added. * editing/deleting/ios/backspace-last-character.html: Added. * platform/ios/TestExpectations: Unskip tests in editing/deleting/ios on iOS. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios/TestExpectations trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/Shared/EditorState.h trunk/Source/WebKit/UIProcess/API/glib/WebKitEditorState.cpp trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/glib/WebPageGLib.cpp trunk/Sou
[webkit-changes] [258991] trunk/Source/WebCore
Title: [258991] trunk/Source/WebCore
Revision 258991
Author you...@apple.com
Date 2020-03-25 10:05:23 -0700 (Wed, 25 Mar 2020)
Log Message
Fix build after https://trac.webkit.org/changeset/258977/webkit
https://bugs.webkit.org/show_bug.cgi?id=209545
Unreviewed.
* dom/Document.cpp:
(WebCore::Document::visibilityStateChanged):
Add ENABLE(MEDIA_STREAM) compilation flag.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (258990 => 258991)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 17:03:50 UTC (rev 258990)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 17:05:23 UTC (rev 258991)
@@ -1,3 +1,14 @@
+2020-03-25 youenn fablet
+
+Fix build after https://trac.webkit.org/changeset/258977/webkit
+https://bugs.webkit.org/show_bug.cgi?id=209545
+
+Unreviewed.
+
+* dom/Document.cpp:
+(WebCore::Document::visibilityStateChanged):
+Add ENABLE(MEDIA_STREAM) compilation flag.
+
2020-03-25 Frank Yang
WebKit uses Alphabetic Baseline when "-webkit-text-orientation" is "mixed" in Vertical Writing Mode
Modified: trunk/Source/WebCore/dom/Document.cpp (258990 => 258991)
--- trunk/Source/WebCore/dom/Document.cpp 2020-03-25 17:03:50 UTC (rev 258990)
+++ trunk/Source/WebCore/dom/Document.cpp 2020-03-25 17:05:23 UTC (rev 258991)
@@ -1744,14 +1744,16 @@
for (auto* client : m_visibilityStateCallbackClients)
client->visibilityStateChanged();
-#if PLATFORM(IOS_FAMILY)
+#if ENABLE(MEDIA_STREAM)
if (hidden()) {
RealtimeMediaSourceCenter::singleton().setCapturePageState(hidden(), page()->isMediaCaptureMuted());
return;
}
+#if PLATFORM(IOS_FAMILY)
if (!PlatformMediaSessionManager::sharedManager().isInterrupted())
MediaStreamTrack::updateCaptureAccordingToMutedState(*this);
#endif
+#endif
}
VisibilityState Document::visibilityState() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258992] tags/Safari-610.1.7.3.2/
Title: [258992] tags/Safari-610.1.7.3.2/ Revision 258992 Author alanc...@apple.com Date 2020-03-25 10:07:35 -0700 (Wed, 25 Mar 2020) Log Message Tag Safari-610.1.7.3.2. Added Paths tags/Safari-610.1.7.3.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258993] trunk/LayoutTests
Title: [258993] trunk/LayoutTests Revision 258993 Author s...@apple.com Date 2020-03-25 10:15:12 -0700 (Wed, 25 Mar 2020) Log Message Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky https://bugs.webkit.org/show_bug.cgi?id=202328 Unreviewed test gardening. Remove flaky expectation for this test since it has been passing on all Mac and iOS platforms. Make the iOS expected result the same for the device and for the simulator. * platform/ios-simulator/fast/images: Removed. * platform/ios/TestExpectations: * platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt: Added. * platform/mac-wk1/TestExpectations: * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations Added Paths trunk/LayoutTests/platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt Removed Paths trunk/LayoutTests/platform/ios-simulator/fast/images/ Diff Modified: trunk/LayoutTests/ChangeLog (258992 => 258993) --- trunk/LayoutTests/ChangeLog 2020-03-25 17:07:35 UTC (rev 258992) +++ trunk/LayoutTests/ChangeLog 2020-03-25 17:15:12 UTC (rev 258993) @@ -1,3 +1,21 @@ +2020-03-25 Said Abou-Hallawa + +Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=202328 + + +Unreviewed test gardening. + +Remove flaky expectation for this test since it has been passing on all +Mac and iOS platforms. Make the iOS expected result the same for the +device and for the simulator. + +* platform/ios-simulator/fast/images: Removed. +* platform/ios/TestExpectations: +* platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt: Added. +* platform/mac-wk1/TestExpectations: +* platform/mac/TestExpectations: + 2020-03-25 Frank Yang WebKit uses Alphabetic Baseline when "-webkit-text-orientation" is "mixed" in Vertical Writing Mode Modified: trunk/LayoutTests/platform/ios/TestExpectations (258992 => 258993) --- trunk/LayoutTests/platform/ios/TestExpectations 2020-03-25 17:07:35 UTC (rev 258992) +++ trunk/LayoutTests/platform/ios/TestExpectations 2020-03-25 17:15:12 UTC (rev 258993) @@ -3301,8 +3301,6 @@ # fast/scrolling/ios/body-overflow-hidden.html is an Image failure fast/scrolling/ios/body-overflow-hidden.html [ Pass ImageOnlyFailure ] -webkit.org/b/202328 fast/images/async-image-multiple-clients-repaint.html [ Pass Failure ] - # drawFocusRing without keyboard enabled does nothing imported/w3c/web-platform-tests/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_001.html [ Skip ] imported/w3c/web-platform-tests/2dcontext/drawing-paths-to-the-canvas/drawFocusIfNeeded_002.html [ Skip ] Added: trunk/LayoutTests/platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt (0 => 258993) --- trunk/LayoutTests/platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt (rev 0) +++ trunk/LayoutTests/platform/ios/fast/images/async-image-multiple-clients-repaint-expected.txt 2020-03-25 17:15:12 UTC (rev 258993) @@ -0,0 +1,10 @@ + + +(repaint rects + (rect 8 348 200 100) + (rect 8 348 200 100) + (rect 8 348 200 100) + (rect 8 348 200 100) + (rect 8 348 200 100) +) + Modified: trunk/LayoutTests/platform/mac/TestExpectations (258992 => 258993) --- trunk/LayoutTests/platform/mac/TestExpectations 2020-03-25 17:07:35 UTC (rev 258992) +++ trunk/LayoutTests/platform/mac/TestExpectations 2020-03-25 17:15:12 UTC (rev 258993) @@ -1833,9 +1833,6 @@ # The test runner is failing in an unrelated, unexplained, invisible to the human eye, 2 pixels difference. webkit.org/b/201401 imported/w3c/web-platform-tests/media-source/mediasource-video-is-visible.html [ Skip ] -# rdar://55484256 (REGRESSION: (Catalina) fast/images/async-image-multiple-clients-repaint.html is a flakey failure) -[ Catalina+ ] fast/images/async-image-multiple-clients-repaint.html [ Pass Failure ] - # Two canvas tests fail with small antialiasing diffs imported/w3c/web-platform-tests/2dcontext/building-paths/canvas_complexshapes_arcto_001.htm [ ImageOnlyFailure ] imported/w3c/web-platform-tests/2dcontext/building-paths/canvas_complexshapes_beziercurveto_001.htm [ ImageOnlyFailure ] Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (258992 => 258993) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-25 17:07:35 UTC (rev 258992) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-25 17:15:12 UTC (rev 258993) @@ -733,7 +733,6 @@ [ Mojave+ ] fast/images/animated-gif-paint-after-animation.html [ Skip ] [ Mojave+ ] fast/images/async-image-background-image-repeated.html [ Skip ] [ Mojave+ ] fast/images/async-image-background-image.html [ Skip ] -[ Mojave+ ] fast/ima
[webkit-changes] [258994] trunk/Source/WebKit
Title: [258994] trunk/Source/WebKit
Revision 258994
Author bfulg...@apple.com
Date 2020-03-25 10:27:01 -0700 (Wed, 25 Mar 2020)
Log Message
Avoid logging sensitive information for all network sessions
https://bugs.webkit.org/show_bug.cgi?id=209522
Reviewed by Alex Christensen.
We avoid logging sensitive information (such as visited URLs) on production builds and for ephemeral sessions.
We should also avoid such logging for engineering and prerelease builds to reduce the possibility of any
personally identifiable information being retained in logs.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID): Deny senstive logging for all sessions.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (258993 => 258994)
--- trunk/Source/WebKit/ChangeLog 2020-03-25 17:15:12 UTC (rev 258993)
+++ trunk/Source/WebKit/ChangeLog 2020-03-25 17:27:01 UTC (rev 258994)
@@ -1,3 +1,19 @@
+2020-03-25 Brent Fulgham
+
+Avoid logging sensitive information for all network sessions
+https://bugs.webkit.org/show_bug.cgi?id=209522
+
+
+Reviewed by Alex Christensen.
+
+We avoid logging sensitive information (such as visited URLs) on production builds and for ephemeral sessions.
+
+We should also avoid such logging for engineering and prerelease builds to reduce the possibility of any
+personally identifiable information being retained in logs.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::configurationForSessionID): Deny senstive logging for all sessions.
+
2020-03-24 Daniel Bates
[iOS] ASSERTION FAILURE: !isMissingPostLayoutData in WebKit::EditorState::postLayoutData()
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (258993 => 258994)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-03-25 17:15:12 UTC (rev 258993)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2020-03-25 17:27:01 UTC (rev 258994)
@@ -994,15 +994,17 @@
static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session)
{
+NSURLSessionConfiguration *configuration;
if (session.isEphemeral()) {
-NSURLSessionConfiguration *configuration = [NSURLSessionConfiguration ephemeralSessionConfiguration];
+configuration = [NSURLSessionConfiguration ephemeralSessionConfiguration];
configuration._shouldSkipPreferredClientCertificateLookup = YES;
+} else
+configuration = [NSURLSessionConfiguration defaultSessionConfiguration];
+
#if HAVE(ALLOWS_SENSITIVE_LOGGING)
-configuration._allowsSensitiveLogging = NO;
+configuration._allowsSensitiveLogging = NO;
#endif
-return configuration;
-}
-return [NSURLSessionConfiguration defaultSessionConfiguration];
+return configuration;
}
const String& NetworkSessionCocoa::boundInterfaceIdentifier() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258995] trunk/Source/WebKit
Title: [258995] trunk/Source/WebKit
Revision 258995
Author dba...@webkit.org
Date 2020-03-25 10:32:07 -0700 (Wed, 25 Mar 2020)
Log Message
Remove newline that I accidentally added in r258989.
* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (258994 => 258995)
--- trunk/Source/WebKit/ChangeLog 2020-03-25 17:27:01 UTC (rev 258994)
+++ trunk/Source/WebKit/ChangeLog 2020-03-25 17:32:07 UTC (rev 258995)
@@ -1,3 +1,9 @@
+2020-03-25 Daniel Bates
+
+Remove newline that I accidentally added in r258989.
+
+* WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
+
2020-03-25 Brent Fulgham
Avoid logging sensitive information for all network sessions
Modified: trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm (258994 => 258995)
--- trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm 2020-03-25 17:27:01 UTC (rev 258994)
+++ trunk/Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm 2020-03-25 17:32:07 UTC (rev 258995)
@@ -314,7 +314,6 @@
return data;
}
-
void WebPage::getProcessDisplayName(CompletionHandler&& completionHandler)
{
#if PLATFORM(MAC)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258996] trunk/LayoutTests
Title: [258996] trunk/LayoutTests Revision 258996 Author jacob_uph...@apple.com Date 2020-03-25 10:37:04 -0700 (Wed, 25 Mar 2020) Log Message [ iOS ] http/tests/cache-storage/page-cache-domcache-pending-promise.html is flaky timing out https://bugs.webkit.org/show_bug.cgi?id=209514 Fixing expectations. Unreviewed test gardening. * platform/ios-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/ios-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (258995 => 258996) --- trunk/LayoutTests/ChangeLog 2020-03-25 17:32:07 UTC (rev 258995) +++ trunk/LayoutTests/ChangeLog 2020-03-25 17:37:04 UTC (rev 258996) @@ -1,3 +1,14 @@ +2020-03-25 Jacob Uphoff + +[ iOS ] http/tests/cache-storage/page-cache-domcache-pending-promise.html is flaky timing out +https://bugs.webkit.org/show_bug.cgi?id=209514 + +Fixing expectations. + +Unreviewed test gardening. + +* platform/ios-wk2/TestExpectations: + 2020-03-25 Said Abou-Hallawa Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (258995 => 258996) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-25 17:32:07 UTC (rev 258995) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2020-03-25 17:37:04 UTC (rev 258996) @@ -1360,7 +1360,7 @@ webkit.org/b/207665 http/tests/cache-storage/cache-representation.https.html [ Slow ] -webkit.org/b/209514 http/tests/cache-storage/page-cache-domcache-pending-promise.html [ Pass Timeout ] +webkit.org/b/209514 http/tests/cache-storage/page-cache-domcache-pending-promise.html [ Pass Timeout DumpJSConsoleLogInStdErr ] webkit.org/b/196300 fast/visual-viewport/ios/min-scale-greater-than-one.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258997] trunk/Tools
Title: [258997] trunk/Tools
Revision 258997
Author aakash_j...@apple.com
Date 2020-03-25 11:08:01 -0700 (Wed, 25 Mar 2020)
Log Message
[ews] status-bubble should link to buildbot queue while waiting in queue
https://bugs.webkit.org/show_bug.cgi?id=209543
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py
trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py (258996 => 258997)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py 2020-03-25 17:37:04 UTC (rev 258996)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/common/buildbot.py 2020-03-25 18:08:01 UTC (rev 258997)
@@ -39,6 +39,7 @@
ALL_RESULTS = lrange(7)
SUCCESS, WARNINGS, FAILURE, SKIPPED, EXCEPTION, RETRY, CANCELLED = ALL_RESULTS
icons_for_queues_mapping = {}
+queue_name_by_shortname_mapping = {}
builder_name_to_id_mapping = {}
@classmethod
@@ -96,9 +97,12 @@
@classmethod
def update_icons_for_queues_mapping(cls):
config = cls.fetch_config()
+if not config:
+_log.warn('Unable to fetch buildbot config.json')
for builder in config.get('builders', []):
shortname = builder.get('shortname')
Buildbot.icons_for_queues_mapping[shortname] = builder.get('icon')
+Buildbot.queue_name_by_shortname_mapping[shortname] = builder.get('name')
@classmethod
def update_builder_name_to_id_mapping(cls):
Modified: trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py (258996 => 258997)
--- trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2020-03-25 17:37:04 UTC (rev 258996)
+++ trunk/Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py 2020-03-25 18:08:01 UTC (rev 258997)
@@ -96,6 +96,11 @@
bubble['queue_position'] = queue_position
if not queue_position:
return None
+if self._get_parent_queue(queue):
+queue = self._get_parent_queue(queue)
+queue_full_name = Buildbot.queue_name_by_shortname_mapping.get(queue)
+if queue_full_name:
+bubble['url'] = 'https://{}/#/builders/{}'.format(config.BUILDBOT_SERVER_HOST, queue_full_name)
bubble['details_message'] = 'Waiting in queue, processing has not started yet.\n\nPosition in queue: {}'.format(queue_position)
return bubble
Modified: trunk/Tools/ChangeLog (258996 => 258997)
--- trunk/Tools/ChangeLog 2020-03-25 17:37:04 UTC (rev 258996)
+++ trunk/Tools/ChangeLog 2020-03-25 18:08:01 UTC (rev 258997)
@@ -1,3 +1,15 @@
+2020-03-25 Aakash Jain
+
+[ews] status-bubble should link to buildbot queue while waiting in queue
+https://bugs.webkit.org/show_bug.cgi?id=209543
+
+Reviewed by Jonathan Bedard.
+
+* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+(StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
+* BuildSlaveSupport/ews-app/ews/common/buildbot.py:
+(Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
+
2020-03-25 Ting-Wei Lan
[GTK] Add user agent quirk for auth.mayohr.com
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258998] trunk/Source/WebCore
Title: [258998] trunk/Source/WebCore Revision 258998 Author svil...@igalia.com Date 2020-03-25 11:11:47 -0700 (Wed, 25 Mar 2020) Log Message Unreviewed build fix for GTK. In wkb.ug/209536 we replaced ENABLE_WEBGL by ENABLE_WEBXR for cmake builds. We just forgot to do it the same for derived sources. * Sources.txt: replaced ENABLE_WEBGL by ENABLE_WEBXR. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Sources.txt Diff Modified: trunk/Source/WebCore/ChangeLog (258997 => 258998) --- trunk/Source/WebCore/ChangeLog 2020-03-25 18:08:01 UTC (rev 258997) +++ trunk/Source/WebCore/ChangeLog 2020-03-25 18:11:47 UTC (rev 258998) @@ -1,3 +1,12 @@ +2020-03-25 Sergio Villar Senin + +Unreviewed build fix for GTK. + +In wkb.ug/209536 we replaced ENABLE_WEBGL by ENABLE_WEBXR for cmake +builds. We just forgot to do it the same for derived sources. + +* Sources.txt: replaced ENABLE_WEBGL by ENABLE_WEBXR. + 2020-03-25 youenn fablet Fix build after https://trac.webkit.org/changeset/258977/webkit Modified: trunk/Source/WebCore/Sources.txt (258997 => 258998) --- trunk/Source/WebCore/Sources.txt 2020-03-25 18:08:01 UTC (rev 258997) +++ trunk/Source/WebCore/Sources.txt 2020-03-25 18:11:47 UTC (rev 258998) @@ -3552,7 +3552,7 @@ JSXPathResult.cpp JSXSLTProcessor.cpp -#if ENABLE_WEBGL +#if ENABLE_WEBXR JSWebXRBoundedReferenceSpace.cpp JSXREnvironmentBlendMode.cpp ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [258999] trunk/Tools
Title: [258999] trunk/Tools
Revision 258999
Author aakash_j...@apple.com
Date 2020-03-25 11:24:31 -0700 (Wed, 25 Mar 2020)
Log Message
[ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=209550
Reviewed by Jonathan Bedard.
* BuildSlaveSupport/ews-build/steps.py:
(FindModifiedChangeLogs): Set haltOnFailure to false.
(FindModifiedChangeLogs.getResultSummary):
(FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
* BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (258998 => 258999)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-25 18:11:47 UTC (rev 258998)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-03-25 18:24:31 UTC (rev 258999)
@@ -2464,7 +2464,7 @@
name = 'find-modified-changelogs'
descriptionDone = ['Found modified ChangeLogs']
command = ['git', 'diff', '-r', '--name-status', '--no-renames', '--no-ext-diff', '--full-index']
-haltOnFailure = True
+haltOnFailure = False
def __init__(self, **kwargs):
shell.ShellCommand.__init__(self, timeout=3 * 60, logEnviron=False, **kwargs)
@@ -2476,7 +2476,8 @@
def getResultSummary(self):
if self.results != SUCCESS:
-return {u'step': u'Failed to find list of modified ChangeLogs'}
+patch_id = self.getProperty('patch_id', '')
+return {u'step': u'Failed to find any modified ChangeLog in Patch {}'.format(patch_id)}
return shell.ShellCommand.getResultSummary(self)
def evaluateCommand(self, cmd):
@@ -2484,6 +2485,15 @@
log_text = self.log_observer.getStdout() + self.log_observer.getStderr()
modified_changelogs = self.extract_changelogs(log_text, self._status_regexp('MA'))
self.setProperty('modified_changelogs', modified_changelogs)
+if rc == FAILURE or not modified_changelogs:
+patch_id = self.getProperty('patch_id', '')
+message = 'Unable to find any modified ChangeLog in Patch {}'.format(patch_id)
+if self.getProperty('buildername', '').lower() == 'commit-queue':
+self.setProperty('bugzilla_comment_text', message.replace('Patch', 'Attachment'))
+self.setProperty('build_finish_summary', message)
+self.build.addStepsAfterCurrentStep([CommentOnBug(), SetCommitQueueMinusFlagOnPatch()])
+else:
+self.build.buildFinished([message], FAILURE)
return rc
def is_path_to_changelog(self, path):
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (258998 => 258999)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-03-25 18:11:47 UTC (rev 258998)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-03-25 18:24:31 UTC (rev 258999)
@@ -3148,6 +3148,8 @@
def test_modified_changelogs(self):
self.setupStep(FindModifiedChangeLogs())
+self.assertEqual(FindModifiedChangeLogs.haltOnFailure, False)
+self.setProperty('buildername', 'Commit-Queue')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
timeout=180,
@@ -3163,6 +3165,8 @@
self.expectOutcome(result=SUCCESS, state_string='Found modified ChangeLogs')
rc = self.runStep()
self.assertEqual(self.getProperty('modified_changelogs'), ['Source/WebCore/ChangeLog', 'Tools/ChangeLog'])
+self.assertEqual(self.getProperty('bugzilla_comment_text'), None)
+self.assertEqual(self.getProperty('build_finish_summary'), None)
return rc
def test_success_added_changelog(self):
@@ -3179,10 +3183,14 @@
self.expectOutcome(result=SUCCESS, state_string='Found modified ChangeLogs')
rc = self.runStep()
self.assertEqual(self.getProperty('modified_changelogs'), ['Tools/Scripts/ChangeLog'])
+self.assertEqual(self.getProperty('bugzilla_comment_text'), None)
+self.assertEqual(self.getProperty('build_finish_summary'), None)
return rc
def test_failure(self):
self.setupStep(FindModifiedChangeLogs())
+self.setProperty('patch_id', '1234')
+self.setProperty('buildername', 'Commit-Queue')
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
timeout=180,
@@ -3191,8 +3199,11 @@
ExpectShell.log('stdio', stdout='Unexpected failure') +
2,
)
-self.expectOutcome(result=FAILURE, state_string='Failed to find list of modified ChangeLogs')
-return self.runStep()
+self.expectOutcome(result=FAILURE, state_string='Failed to find any modified ChangeLog in Patc
[webkit-changes] [259000] trunk/Source/WebCore
Title: [259000] trunk/Source/WebCore
Revision 259000
Author simon.fra...@apple.com
Date 2020-03-25 11:34:21 -0700 (Wed, 25 Mar 2020)
Log Message
Remove CompositingChangeRepaint which was always CompositingChangeRepaintNow
https://bugs.webkit.org/show_bug.cgi?id=209551
Reviewed by Zalan Bujtas.
All callers to updateBacking() passed CompositingChangeRepaintNow, so remove this argument
and the enum.
No behavior change.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::layerStyleChanged):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::updateLayerCompositingState):
* rendering/RenderLayerCompositor.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (258999 => 259000)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 18:24:31 UTC (rev 258999)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 18:34:21 UTC (rev 259000)
@@ -1,3 +1,22 @@
+2020-03-25 Simon Fraser
+
+Remove CompositingChangeRepaint which was always CompositingChangeRepaintNow
+https://bugs.webkit.org/show_bug.cgi?id=209551
+
+Reviewed by Zalan Bujtas.
+
+All callers to updateBacking() passed CompositingChangeRepaintNow, so remove this argument
+and the enum.
+
+No behavior change.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::computeCompositingRequirements):
+(WebCore::RenderLayerCompositor::layerStyleChanged):
+(WebCore::RenderLayerCompositor::updateBacking):
+(WebCore::RenderLayerCompositor::updateLayerCompositingState):
+* rendering/RenderLayerCompositor.h:
+
2020-03-25 Sergio Villar Senin
Unreviewed build fix for GTK.
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (258999 => 259000)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2020-03-25 18:24:31 UTC (rev 258999)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2020-03-25 18:34:21 UTC (rev 259000)
@@ -1049,7 +1049,7 @@
// Create or destroy backing here. However, we can't update geometry because layers above us may become composited
// during post-order traversal (e.g. for clipping).
-if (updateBacking(layer, queryData, CompositingChangeRepaintNow, willBeComposited ? BackingRequired::Yes : BackingRequired::No)) {
+if (updateBacking(layer, queryData, willBeComposited ? BackingRequired::Yes : BackingRequired::No)) {
layer.setNeedsCompositingLayerConnection();
// Child layers need to get a geometry update to recompute their position.
layer.setChildrenNeedCompositingGeometryUpdate();
@@ -1058,7 +1058,7 @@
}
// Update layer state bits.
-if (layer.reflectionLayer() && updateLayerCompositingState(*layer.reflectionLayer(), &layer, queryData, CompositingChangeRepaintNow))
+if (layer.reflectionLayer() && updateLayerCompositingState(*layer.reflectionLayer(), &layer, queryData))
layer.setNeedsCompositingLayerConnection();
// FIXME: clarify needsCompositingPaintOrderChildrenUpdate. If a composited layer gets a new ancestor, it needs geometry computations.
@@ -1467,7 +1467,7 @@
RequiresCompositingData queryData;
queryData.layoutUpToDate = LayoutUpToDate::No;
-bool layerChanged = updateBacking(layer, queryData, CompositingChangeRepaintNow);
+bool layerChanged = updateBacking(layer, queryData);
if (layerChanged) {
layer.setChildrenNeedCompositingGeometryUpdate();
layer.setNeedsCompositingLayerConnection();
@@ -1589,7 +1589,7 @@
m_rootContentsLayer->setMasksToBounds(!m_renderView.settings().backgroundShouldExtendBeyondPage());
}
-bool RenderLayerCompositor::updateBacking(RenderLayer& layer, RequiresCompositingData& queryData, CompositingChangeRepaint shouldRepaint, BackingRequired backingRequired)
+bool RenderLayerCompositor::updateBacking(RenderLayer& layer, RequiresCompositingData& queryData, BackingRequired backingRequired)
{
bool layerChanged = false;
if (backingRequired == BackingRequired::Unknown)
@@ -1606,8 +1606,7 @@
if (!layer.backing()) {
// If we need to repaint, do so before making backing
-if (shouldRepaint == CompositingChangeRepaintNow)
-repaintOnCompositingChange(layer); // wrong backing
+repaintOnCompositingChange(layer);
layer.ensureBacking();
@@ -1657,8 +1656,7 @@
layer.computeRepaintRectsIncludingDescendants();
// If we need to repaint, do so now that we've removed the backing
-if (shouldRepaint == CompositingChangeRepaintNow)
-repaintOnCompositingChange(layer);
+repaintOnCompositingChange(layer);
}
[webkit-changes] [259002] branches/safari-609-branch
Title: [259002] branches/safari-609-branch
Revision 259002
Author repst...@apple.com
Date 2020-03-25 12:16:09 -0700 (Wed, 25 Mar 2020)
Log Message
Apply patch. rdar://problem/60756680
Modified Paths
branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj
branches/safari-609-branch/Source/WTF/wtf/PlatformMac.cmake
branches/safari-609-branch/Source/WebCore/loader/DocumentThreadableLoader.cpp
branches/safari-609-branch/Source/WebCore/platform/RuntimeApplicationChecks.h
branches/safari-609-branch/Source/WebCore/platform/Timer.cpp
branches/safari-609-branch/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
branches/safari-609-branch/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme
Added Paths
branches/safari-609-branch/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp
branches/safari-609-branch/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
Diff
Modified: branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj (259001 => 259002)
--- branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-03-25 19:16:03 UTC (rev 259001)
+++ branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-03-25 19:16:09 UTC (rev 259002)
@@ -61,6 +61,7 @@
1C181C931D307AB800F5FA16 /* UTextProviderUTF16.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C181C8D1D307AB800F5FA16 /* UTextProviderUTF16.cpp */; };
1C181C961D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C181C951D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp */; };
1C503BE623AAE0AE0072E66B /* LanguageCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1C503BE523AAE0AE0072E66B /* LanguageCocoa.mm */; };
+ 1C9E1C8A242AA9BC00DEB5B2 /* RuntimeApplicationChecksCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C9E1C88242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.cpp */; };
1FA47C8A152502DA00568D1B /* WebCoreThread.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1FA47C88152502DA00568D1B /* WebCoreThread.cpp */; };
2CCD892A15C0390200285083 /* GregorianDateTime.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2CCD892915C0390200285083 /* GregorianDateTime.cpp */; };
2CDED0EF18115C38004DBA70 /* RunLoopCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2CDED0EE18115C38004DBA70 /* RunLoopCF.cpp */; };
@@ -342,6 +343,8 @@
1C181C951D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextBreakIteratorInternalICUCocoa.cpp; sourceTree = ""; };
1C503BE423AADEEA0072E66B /* NSLocaleSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NSLocaleSPI.h; sourceTree = ""; };
1C503BE523AAE0AE0072E66B /* LanguageCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = LanguageCocoa.mm; sourceTree = ""; };
+ 1C9E1C88242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RuntimeApplicationChecksCocoa.cpp; sourceTree = ""; };
+ 1C9E1C89242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RuntimeApplicationChecksCocoa.h; sourceTree = ""; };
1CCDB1491E566626006C73C0 /* TextBreakIteratorCF.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextBreakIteratorCF.h; sourceTree = ""; };
1CCDB14D1E566898006C73C0 /* TextBreakIteratorICU.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextBreakIteratorICU.h; sourceTree = ""; };
1CCDB1511E566BC5006C73C0 /* CFStringSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFStringSPI.h; sourceTree = ""; };
@@ -1470,6 +1473,8 @@
E4A0AD3B1A96251900536DF6 /* cocoa */ = {
isa = PBXGroup;
children = (
+1C9E1C88242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.cpp */,
+1C9E1C89242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.h */,
1469419B16EAB10A0024E146 /* AutodrainedPool.cpp */,
E38C41241EB4E04C0042957D /* CPUTimeCocoa.cpp */,
CEA072A9236FFBF70018839C /* CrashReporter.cpp */,
@@ -1593,6 +1598,7 @@
517F82D71FD22F3000DA3DEA /* CrossThreadTaskHandler.cpp in Sources */,
A8A4739A151A825B004123FF /* CryptographicallyRandomNumber.cpp in Sources */,
E15556F518A0CC18006F48FB /* CryptographicUtilities.cpp in Sources */,
+1C9E1C8A242AA9BC00DEB5B2 /* RuntimeApplicationChecksCocoa.cpp in Sources */,
A8A47439151A825B004123FF /* CString.cpp in Sources */,
A8A4739C151A825B004123FF /* CurrentTime.cpp in Sources */,
A8A4739E1
[webkit-changes] [259001] branches/safari-609-branch
Title: [259001] branches/safari-609-branch
Revision 259001
Author repst...@apple.com
Date 2020-03-25 12:16:03 -0700 (Wed, 25 Mar 2020)
Log Message
Revert "Apply patch. rdar://problem/60756680"
This reverts commit r258972.
Modified Paths
branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj
branches/safari-609-branch/Source/WTF/wtf/PlatformMac.cmake
branches/safari-609-branch/Source/WebCore/platform/RuntimeApplicationChecks.h
branches/safari-609-branch/Source/WebCore/platform/Timer.cpp
branches/safari-609-branch/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
branches/safari-609-branch/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm
branches/safari-609-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm
branches/safari-609-branch/WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme
Removed Paths
branches/safari-609-branch/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp
branches/safari-609-branch/Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
Diff
Modified: branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj (259000 => 259001)
--- branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-03-25 18:34:21 UTC (rev 259000)
+++ branches/safari-609-branch/Source/WTF/WTF.xcodeproj/project.pbxproj 2020-03-25 19:16:03 UTC (rev 259001)
@@ -61,7 +61,6 @@
1C181C931D307AB800F5FA16 /* UTextProviderUTF16.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C181C8D1D307AB800F5FA16 /* UTextProviderUTF16.cpp */; };
1C181C961D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C181C951D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp */; };
1C503BE623AAE0AE0072E66B /* LanguageCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1C503BE523AAE0AE0072E66B /* LanguageCocoa.mm */; };
- 1C9E1C8A242AA9BC00DEB5B2 /* RuntimeApplicationChecksCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1C9E1C88242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.cpp */; };
1FA47C8A152502DA00568D1B /* WebCoreThread.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1FA47C88152502DA00568D1B /* WebCoreThread.cpp */; };
2CCD892A15C0390200285083 /* GregorianDateTime.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2CCD892915C0390200285083 /* GregorianDateTime.cpp */; };
2CDED0EF18115C38004DBA70 /* RunLoopCF.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2CDED0EE18115C38004DBA70 /* RunLoopCF.cpp */; };
@@ -343,8 +342,6 @@
1C181C951D30800A00F5FA16 /* TextBreakIteratorInternalICUCocoa.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = TextBreakIteratorInternalICUCocoa.cpp; sourceTree = ""; };
1C503BE423AADEEA0072E66B /* NSLocaleSPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NSLocaleSPI.h; sourceTree = ""; };
1C503BE523AAE0AE0072E66B /* LanguageCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = LanguageCocoa.mm; sourceTree = ""; };
- 1C9E1C88242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RuntimeApplicationChecksCocoa.cpp; sourceTree = ""; };
- 1C9E1C89242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RuntimeApplicationChecksCocoa.h; sourceTree = ""; };
1CCDB1491E566626006C73C0 /* TextBreakIteratorCF.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextBreakIteratorCF.h; sourceTree = ""; };
1CCDB14D1E566898006C73C0 /* TextBreakIteratorICU.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextBreakIteratorICU.h; sourceTree = ""; };
1CCDB1511E566BC5006C73C0 /* CFStringSPI.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CFStringSPI.h; sourceTree = ""; };
@@ -1473,8 +1470,6 @@
E4A0AD3B1A96251900536DF6 /* cocoa */ = {
isa = PBXGroup;
children = (
-1C9E1C88242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.cpp */,
-1C9E1C89242AA9A800DEB5B2 /* RuntimeApplicationChecksCocoa.h */,
1469419B16EAB10A0024E146 /* AutodrainedPool.cpp */,
E38C41241EB4E04C0042957D /* CPUTimeCocoa.cpp */,
CEA072A9236FFBF70018839C /* CrashReporter.cpp */,
@@ -1598,7 +1593,6 @@
517F82D71FD22F3000DA3DEA /* CrossThreadTaskHandler.cpp in Sources */,
A8A4739A151A825B004123FF /* CryptographicallyRandomNumber.cpp in Sources */,
E15556F518A0CC18006F48FB /* CryptographicUtilities.cpp in Sources */,
-1C9E1C8A242AA9BC00DEB5B2 /* RuntimeApplicationChecksCocoa.cpp in Sources */,
A8A47439151A825B004123FF /* CString.cpp in Sources */,
A8A4739C151A825B004123FF /* CurrentTime.cpp in Sources */,
A8A4739E151A825B004123FF /* DataLog.cpp in Sources */,
Modified: branches/safari-609-branch/Source/WTF/wtf/PlatformMac.cmake
[webkit-changes] [259003] trunk/LayoutTests
Title: [259003] trunk/LayoutTests Revision 259003 Author s...@apple.com Date 2020-03-25 12:29:30 -0700 (Wed, 25 Mar 2020) Log Message Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky https://bugs.webkit.org/show_bug.cgi?id=202328 Unreviewed test gardening. Put the skip statement for this test back in mac-wk1/TestExpectations since has not been fixed yet. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259002 => 259003) --- trunk/LayoutTests/ChangeLog 2020-03-25 19:16:09 UTC (rev 259002) +++ trunk/LayoutTests/ChangeLog 2020-03-25 19:29:30 UTC (rev 259003) @@ -1,3 +1,16 @@ +2020-03-25 Said Abou-Hallawa + +Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=202328 + + +Unreviewed test gardening. + +Put the skip statement for this test back in mac-wk1/TestExpectations +since has not been fixed yet. + +* platform/mac-wk1/TestExpectations: + 2020-03-25 Jacob Uphoff [ iOS ] http/tests/cache-storage/page-cache-domcache-pending-promise.html is flaky timing out Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259002 => 259003) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-25 19:16:09 UTC (rev 259002) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-25 19:29:30 UTC (rev 259003) @@ -733,6 +733,7 @@ [ Mojave+ ] fast/images/animated-gif-paint-after-animation.html [ Skip ] [ Mojave+ ] fast/images/async-image-background-image-repeated.html [ Skip ] [ Mojave+ ] fast/images/async-image-background-image.html [ Skip ] +[ Mojave+ ] fast/images/async-image-multiple-clients-repaint.html [ Skip ] [ Mojave+ ] fast/images/composited-animated-gif-outside-viewport.html [ Skip ] [ Mojave+ ] fast/images/decode-render-animated-image.html [ Skip ] [ Mojave+ ] fast/images/decode-render-static-image.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259004] trunk/LayoutTests
Title: [259004] trunk/LayoutTests
Revision 259004
Author nmouchta...@apple.com
Date 2020-03-25 12:49:39 -0700 (Wed, 25 Mar 2020)
Log Message
Add ref test for apple pay button corner radius change
https://bugs.webkit.org/show_bug.cgi?id=208959
Reviewed by Andy Estes.
Add ref test to check that providing a border-radius does not result in rendering
a default apple pay button.
* http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html: Added.
* http/tests/ssl/applepay/ApplePayButtonCornerRadius.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html
trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259003 => 259004)
--- trunk/LayoutTests/ChangeLog 2020-03-25 19:29:30 UTC (rev 259003)
+++ trunk/LayoutTests/ChangeLog 2020-03-25 19:49:39 UTC (rev 259004)
@@ -1,3 +1,16 @@
+2020-03-25 Nikos Mouchtaris
+
+Add ref test for apple pay button corner radius change
+https://bugs.webkit.org/show_bug.cgi?id=208959
+
+Reviewed by Andy Estes.
+
+Add ref test to check that providing a border-radius does not result in rendering
+a default apple pay button.
+
+* http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html: Added.
+* http/tests/ssl/applepay/ApplePayButtonCornerRadius.html: Added.
+
2020-03-25 Said Abou-Hallawa
Layout Test fast/images/async-image-multiple-clients-repaint.html is flaky
Added: trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html (0 => 259004)
--- trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html (rev 0)
+++ trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius-expected-mismatch.html 2020-03-25 19:49:39 UTC (rev 259004)
@@ -0,0 +1,48 @@
+
+
+
+
+Test rendering Apple Pay buttons
+
+.apple-pay-button {
+-webkit-appearance: -apple-pay-button;
+display: block;
+}
+
+.white {
+-apple-pay-button-style: white;
+}
+
+.white-outline {
+-apple-pay-button-style: white-outline;
+}
+
+.black {
+-apple-pay-button-style: black;
+}
+
+.check-out {
+-apple-pay-button-type: check-out;
+}
+
+.book {
+-apple-pay-button-type: book;
+}
+
+.subscribe {
+-apple-pay-button-type: subscribe;
+}
+
+
+
+
+for (let style of ["white", "white-outline", "black"]) {
+for (let type of ["check-out", "book", "subscribe"]) {
+var buttonNoRadius = document.createElement("button");
+buttonNoRadius.classList.add("apple-pay-button", style, type);
+document.body.appendChild(buttonNoRadius);
+}
+}
+
+
+
Added: trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius.html (0 => 259004)
--- trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius.html (rev 0)
+++ trunk/LayoutTests/http/tests/ssl/applepay/ApplePayButtonCornerRadius.html 2020-03-25 19:49:39 UTC (rev 259004)
@@ -0,0 +1,54 @@
+
+
+
+
+Test rendering Apple Pay buttons
+
+.apple-pay-button {
+-webkit-appearance: -apple-pay-button;
+display: block;
+}
+
+.white {
+-apple-pay-button-style: white;
+}
+
+.white-outline {
+-apple-pay-button-style: white-outline;
+}
+
+.black {
+-apple-pay-button-style: black;
+}
+
+.check-out {
+-apple-pay-button-type: check-out;
+}
+
+.book {
+-apple-pay-button-type: book;
+}
+
+.subscribe {
+-apple-pay-button-type: subscribe;
+}
+.borderRadiusLarge {
+border-top-left-radius: 20px/21px;
+border-top-right-radius: 25px;
+border-bottom-left-radius: 10px/1px;
+border-bottom-right-radius: 5px;
+}
+
+
+
+
+for (let style of ["white", "white-outline", "black"]) {
+for (let type of ["check-out", "book", "subscribe"]) {
+var button = document.createElement("button");
+button.classList.add("apple-pay-button", style, type, "borderRadiusLarge");
+document.body.appendChild(button);
+}
+}
+
+
+
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259005] trunk/Source/WebKit
Title: [259005] trunk/Source/WebKit
Revision 259005
Author beid...@apple.com
Date 2020-03-25 13:02:59 -0700 (Wed, 25 Mar 2020)
Log Message
Some WKWebView.h header doc cleanup.
https://bugs.webkit.org/show_bug.cgi?id=209549
Reviewed by Simon Fraser.
* UIProcess/API/Cocoa/WKWebView.h:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259004 => 259005)
--- trunk/Source/WebKit/ChangeLog 2020-03-25 19:49:39 UTC (rev 259004)
+++ trunk/Source/WebKit/ChangeLog 2020-03-25 20:02:59 UTC (rev 259005)
@@ -1,3 +1,12 @@
+2020-03-25 Brady Eidson
+
+Some WKWebView.h header doc cleanup.
+https://bugs.webkit.org/show_bug.cgi?id=209549
+
+Reviewed by Simon Fraser.
+
+* UIProcess/API/Cocoa/WKWebView.h:
+
2020-03-25 Daniel Bates
Remove newline that I accidentally added in r258989.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h (259004 => 259005)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2020-03-25 19:49:39 UTC (rev 259004)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.h 2020-03-25 20:02:59 UTC (rev 259005)
@@ -233,7 +233,7 @@
Evaluating your _javascript_ string can leave behind other changes to global state visibile to _javascript_. (e.g. `window.myVariable = 1;`)
Those changes will only be visibile to scripts executed in the same WKContentWorld.
evaluateJavaScript: is a great way to set up global state for future _javascript_ execution in a given world. (e.g. Importing libraries/utilities that future _javascript_ execution will rely on)
- Once your global state is set up, consider using callAsyncJavaScriptFunction: for more flexible interaction with the _javascript_ programming model.
+ Once your global state is set up, consider using callAsyncJavaScript: for more flexible interaction with the _javascript_ programming model.
*/
- (void)evaluateJavaScript:(NSString *)_javascript_String inContentWorld:(WKContentWorld *)contentWorld completionHandler:(void (^ _Nullable)(_Nullable id, NSError * _Nullable error))completionHandler NS_REFINED_FOR_SWIFT WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
@@ -243,18 +243,29 @@
@param contentWorld The WKContentWorld in which to call the _javascript_ function.
@param completionHandler A block to invoke with the return value of the function call, or with the asynchronous resolution of the function's return value.
@discussion The functionBody string is treated as an anonymous _javascript_ function body that can be called with named arguments.
- Do not format your string as one of the variants of function call available in _javascript_.
- Instead pass in a _javascript_ string representing the function body, formatted for evaluation.
+ Do not format your functionBody string as a function-like callable object as you would in pure _javascript_.
+ Your functionBody string should contain only the function body you want executed.
+
For example do not pass in the string:
- function(x, y, z) { return x ? y : z; }
+ @textblock
+ function(x, y, z)
+ {
+ return x ? y : z;
+ }
+ @/textblock
+
Instead pass in the string:
+ @textblock
return x ? y : z;
+ @/textblock
The arguments dictionary supplies the values for those arguments which are serialized into _javascript_ equivalents.
For example:
+ @textblock
@{ @"x" : @YES, @"y" : @1, @"z" : @"hello world" };
+ @/textblock
- Combining the above arguments dictionary with the above functionBody string, a function with the arguments named "x", "y", and "z" is called with values YES, 1, and "hello world" respectively.
+ Combining the above arguments dictionary with the above functionBody string, a function with the arguments named "x", "y", and "z" is called with values true, 1, and "hello world" respectively.
Allowed argument types are:
NSNumber, NSString, NSDate, NSArray, NSDictionary, and NSNull.
@@ -279,11 +290,13 @@
Since the function is a _javascript_ "async" function you can use _javascript_ "await" on thenable objects inside your function body.
For example:
+ @textblock
var p = new Promise(function (f) {
window.setTimeout("f(42)", 1000);
});
await p;
return p;
+ @/textblock
The above function text will create a promise that will fulfull with the value 42 after a one second delay, wait for it to resolve, then return the fulfillment value of 42.
*/
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259006] trunk
Title: [259006] trunk Revision 259006 Author commit-qu...@webkit.org Date 2020-03-25 13:12:54 -0700 (Wed, 25 Mar 2020) Log Message Unprefix -webkit-text-orientation https://bugs.webkit.org/show_bug.cgi?id=196139 Source/WebCore: Patch by Frank Yang on 2020-03-25 Reviewed by Myles C. Maxfield In order to unprefix -webkit-text-orientation to be text-orientation, a new property, "text-orientation" is added to CSSProperties.json. I didn't use alias because the prefixed version still supports non-standard values, and we want the unprefixed version to strictly follow the specs. However only adding a new property is not enough because -webkit-text-orientation is a high-priority property, and without extra logic, the CSS property "last-one-wins" ordering rule cannot be enforced because high-priority properties are applied to elements in the order they appear in the generated CSSPropertyNames.cpp file. Therefore a codegen flag, "related-property" is added to both -webkit-text-orientation and text-orientation to point to each other, so that when applying high priorities, the algorithm will know that the two properties are modifying the same style of the element (in our case, text orientation) and thus the CSS property "last-one-wins" ordering rule will take effect. This code change also helps future developments when we want to unprefix other high-priority properties. Tests: fast/text/orientation-inheritance.html fast/text/orientation-mixed-unprefix.html fast/text/orientation-sideways-prefix-unprefix.html fast/text/orientation-sideways-unprefix.html fast/text/orientation-upright-unprefix.html fast/text/test-orientation-parsing-001.html fast/text/text-orientation-parse-competition.html fast/text/text-orientation-parse.html imported/w3c/web-platform-tests/css/css-writing-modes/text-orientation-parsing-001.html * css/CSSComputedStyleDeclaration.cpp: - added support for parsing "text-orientation" (WebCore::ComputedStyleExtractor::valueForPropertyInStyle): - added a new RenderStyle, CSSPropertyTextOrientation * css/CSSProperties.json: - added a new codegen property, "related-property" * css/makeprop.pl: - added new rules for generating code to parse related properties (addProperty): - inserts new rule in the generated code to parse related properties * css/parser/CSSParserFastPaths.cpp: - Specified the CSS property values that the unprefixed "text-orientation" can take (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): - Only supports the standard values for text-orientation (WebCore::CSSParserFastPaths::isKeywordPropertyID): - Added switch case value CSSPropertyTextOrientation * css/parser/CSSParserImpl.cpp: - Added rules to treat related properties differently (WebCore::filterProperties): - For related rules that are also high priority, if we saw one in the property list, we will mark all the related property as seen, in order to enforce the "last-one-wins" ordering rule * style/StyleBuilderCustom.h: (WebCore::Style::BuilderCustom::applyValueTextOrientation): - added functionality to parse the newly added "text-orientation" property Tools: Patch by Frank Yang on 2020-03-25 Reviewed by Myles C. Maxfield. This change is made to add the extra flag "related-property" in CSSProperty.json in the jsonchecker so that the jsonchecker would not complain about unrecognized key * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property (JSONCSSPropertiesChecker.check_codegen_properties): LayoutTests: Added test cases to check that Webkit can now parse text-orientation correctly, as well as that the precedence rule for CSS property still applies when both -webkit-text-orientation and text-orientation property are present, the second one takes precedence. Patch by Frank Yang on 2020-03-25 Reviewed by Myles C. Maxfield * fast/text/orientation-inheritance-expected.html: Added. * fast/text/orientation-inheritance.html: Added. * fast/text/orientation-mixed-unprefix-expected.html: Added. * fast/text/orientation-mixed-unprefix.html: Added. * fast/text/orientation-sideways-prefix-unprefix-expected.html: Added. * fast/text/orientation-sideways-prefix-unprefix.html: Added. * fast/text/orientation-sideways-unprefix-expected.html: Added. * fast/text/orientation-sideways-unprefix.html: Added. * fast/text/orientation-upright-unprefix-expected.html: Added. * fast/text/orientation-upright-unprefix.html: Added. * fast/text/test-orientation-parsing-001-expected.txt: Added. * fast/text/test-orientation-parsing-001.html: Added. * fast/text/text-orientation-parse-competition-expected.txt: Added. * fast/text/text-orientation-parse-competition.html: Added. * fast/text/text-orientation-parse-expected.txt: Added. * fast/text/text-orientation-parse.html: Added. * fast/text/text-orientation-parse-stylesheet-expected.txt: Added. * fast/text/text-orientation-parse-stylesheet.html: Added.
[webkit-changes] [259007] trunk/LayoutTests
Title: [259007] trunk/LayoutTests Revision 259007 Author lawrenc...@apple.com Date 2020-03-25 13:48:55 -0700 (Wed, 25 Mar 2020) Log Message [ Mac wk1] ASSERTION FAILED: m_wrapper under WebCore::XMLHttpRequestUpload::dispatchProgressEvent https://bugs.webkit.org/show_bug.cgi?id=209560 Unreviewed test gardening. * platform/mac-wk1/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk1/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259006 => 259007) --- trunk/LayoutTests/ChangeLog 2020-03-25 20:12:54 UTC (rev 259006) +++ trunk/LayoutTests/ChangeLog 2020-03-25 20:48:55 UTC (rev 259007) @@ -1,3 +1,12 @@ +2020-03-25 Jason Lawrence + +[ Mac wk1] ASSERTION FAILED: m_wrapper under WebCore::XMLHttpRequestUpload::dispatchProgressEvent +https://bugs.webkit.org/show_bug.cgi?id=209560 + +Unreviewed test gardening. + +* platform/mac-wk1/TestExpectations: + 2020-03-25 Frank Yang Unprefix -webkit-text-orientation Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259006 => 259007) --- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-25 20:12:54 UTC (rev 259006) +++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-25 20:48:55 UTC (rev 259007) @@ -964,4 +964,6 @@ webkit.org/b/209499 [ Catalina ] storage/indexeddb/modern/abort-requests-cancelled.html [ Pass Timeout Crash ] -webkit.org/b/209499 [ Catalina ] storage/indexeddb/modern/abort-requests-cancelled-private.html [ Pass Timeout Crash ] \ No newline at end of file +webkit.org/b/209499 [ Catalina ] storage/indexeddb/modern/abort-requests-cancelled-private.html [ Pass Timeout Crash ] + +webkit.org/b/209560 imported/w3c/web-platform-tests/xhr/send-response-upload-event-progress.htm [ Pass Crash Failure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259008] trunk/Source
Title: [259008] trunk/Source
Revision 259008
Author wenson_hs...@apple.com
Date 2020-03-25 14:13:55 -0700 (Wed, 25 Mar 2020)
Log Message
Rename "data interaction pasteboard" to "drag and drop pasteboard"
https://bugs.webkit.org/show_bug.cgi?id=209556
Reviewed by Tim Horton.
Source/WebCore:
"Data interaction" is an obsolete term for drag and drop on iOS, and was meant only to be used early on in
development. Replace this with the more descriptive name "drag and drop pasteboard", and additionally hide the
name behind a Cocoa-only Pasteboard helper method so that each call site won't need to repeat the string.
* platform/Pasteboard.h:
* platform/cocoa/DragDataCocoa.mm:
(WebCore::DragData::DragData):
* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::nameOfDragPasteboard):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::respectsUTIFidelities const):
* platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::PlatformPasteboard):
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::nameOfDragPasteboard):
Source/WebKit:
Adopt Pasteboard::nameOfDragPasteboard instead of the literal string "data interaction pasteboard".
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidEnter:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:sessionDidExit:]):
(-[WKContentView dropInteraction:performDrop:]):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/cocoa/DragDataCocoa.mm
trunk/Source/WebCore/platform/ios/PasteboardIOS.mm
trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm
trunk/Source/WebCore/platform/mac/PasteboardMac.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (259007 => 259008)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 20:48:55 UTC (rev 259007)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 21:13:55 UTC (rev 259008)
@@ -1,3 +1,26 @@
+2020-03-25 Wenson Hsieh
+
+Rename "data interaction pasteboard" to "drag and drop pasteboard"
+https://bugs.webkit.org/show_bug.cgi?id=209556
+
+Reviewed by Tim Horton.
+
+"Data interaction" is an obsolete term for drag and drop on iOS, and was meant only to be used early on in
+development. Replace this with the more descriptive name "drag and drop pasteboard", and additionally hide the
+name behind a Cocoa-only Pasteboard helper method so that each call site won't need to repeat the string.
+
+* platform/Pasteboard.h:
+* platform/cocoa/DragDataCocoa.mm:
+(WebCore::DragData::DragData):
+* platform/ios/PasteboardIOS.mm:
+(WebCore::Pasteboard::nameOfDragPasteboard):
+(WebCore::Pasteboard::createForDragAndDrop):
+(WebCore::Pasteboard::respectsUTIFidelities const):
+* platform/ios/PlatformPasteboardIOS.mm:
+(WebCore::PlatformPasteboard::PlatformPasteboard):
+* platform/mac/PasteboardMac.mm:
+(WebCore::Pasteboard::nameOfDragPasteboard):
+
2020-03-25 Frank Yang
Unprefix -webkit-text-orientation
Modified: trunk/Source/WebCore/platform/Pasteboard.h (259007 => 259008)
--- trunk/Source/WebCore/platform/Pasteboard.h 2020-03-25 20:48:55 UTC (rev 259007)
+++ trunk/Source/WebCore/platform/Pasteboard.h 2020-03-25 21:13:55 UTC (rev 259008)
@@ -250,6 +250,9 @@
#endif
#if PLATFORM(COCOA)
+#if ENABLE(DRAG_SUPPORT)
+WEBCORE_EXPORT static String nameOfDragPasteboard();
+#endif
static bool shouldTreatCocoaTypeAsFile(const String&);
WEBCORE_EXPORT static NSArray *supportedFileUploadPasteboardTypes();
int64_t changeCount() const;
Modified: trunk/Source/WebCore/platform/cocoa/DragDataCocoa.mm (259007 => 259008)
--- trunk/Source/WebCore/platform/cocoa/DragDataCocoa.mm 2020-03-25 20:48:55 UTC (rev 259007)
+++ trunk/Source/WebCore/platform/cocoa/DragDataCocoa.mm 2020-03-25 21:13:55 UTC (rev 259008)
@@ -126,7 +126,7 @@
#if PLATFORM(MAC)
, m_pasteboardName([[m_platformDragData draggingPasteboard] name])
#else
-, m_pasteboardName("data interaction pasteboard")
+, m_pasteboardName(Pasteboard::nameOfDragPasteboard())
#endif
{
}
Modified: trunk/Source/WebCore/platform/ios/PasteboardIOS.mm (259007 => 259008)
--- trunk/Source/WebCore/platform/ios/PasteboardIOS.mm 2020-03-25 20:48:55 UTC (rev 259007)
+++ trunk/Source/WebCore/platform/ios/PasteboardIOS.mm 2020-03-25 21:13:55 UTC (rev 259008)
@@ -64,9 +64,14 @@
notImplemented();
}
+String Pasteboard::nameOfDragPasteboard()
+{
+return "drag and drop pasteboard";
+}
+
std::unique_ptr Pasteboard::createForDragAndDrop()
{
-return makeUnique("data interaction pasteboard");
+return makeUnique(Pasteboard::nameOfDragPasteboard());
}
std::unique_ptr Pasteboard::createForDragAndDrop(const DragData& dragData)
@@ -348,7 +353,7 @@
// For now, data in
[webkit-changes] [259009] trunk
Title: [259009] trunk
Revision 259009
Author cdu...@apple.com
Date 2020-03-25 14:16:13 -0700 (Wed, 25 Mar 2020)
Log Message
Event listeners registered with 'once' option may get garbage collected too soon
https://bugs.webkit.org/show_bug.cgi?id=209504
Reviewed by Yusuke Suzuki.
Source/_javascript_Core:
Add EnsureStillAliveScope RAII object for ensureStillAliveHere().
* runtime/JSCJSValue.h:
(JSC::EnsureStillAliveScope::EnsureStillAliveScope):
(JSC::EnsureStillAliveScope::~EnsureStillAliveScope):
Source/WebCore:
In EventTarget::innerInvokeEventListeners, if the listener we're about to call is a one-time
listener (has 'once' flag set), we would first unregister the event listener and then call
it, as per the DOM specification. However, once unregistered, the event listener is no longer
visited for GC purposes and its internal JS Function may get garbage collected before we get
a chance to call it.
To address the issue, we now make sure the JS Function (and its wrapper) stay alive for the
duration of the scope using ensureStillAliveHere().
Test: http/tests/inspector/network/har/har-page-aggressive-gc.html
* bindings/js/JSEventListener.h:
* dom/EventListener.h:
(WebCore::EventListener::jsFunction const):
(WebCore::EventListener::wrapper const):
* dom/EventTarget.cpp:
(WebCore::EventTarget::innerInvokeEventListeners):
LayoutTests:
Add layout test coverage.
* http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt: Added.
* http/tests/inspector/network/har/har-page-aggressive-gc.html: Added.
* platform/gtk/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSCJSValue.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSErrorHandler.cpp
trunk/Source/WebCore/bindings/js/JSEventListener.cpp
trunk/Source/WebCore/bindings/js/JSEventListener.h
trunk/Source/WebCore/dom/EventListener.h
trunk/Source/WebCore/dom/EventTarget.cpp
trunk/Source/WebCore/inspector/CommandLineAPIHost.cpp
trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
Added Paths
trunk/LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt
trunk/LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259008 => 259009)
--- trunk/LayoutTests/ChangeLog 2020-03-25 21:13:55 UTC (rev 259008)
+++ trunk/LayoutTests/ChangeLog 2020-03-25 21:16:13 UTC (rev 259009)
@@ -1,3 +1,20 @@
+2020-03-25 Chris Dumez
+
+Event listeners registered with 'once' option may get garbage collected too soon
+https://bugs.webkit.org/show_bug.cgi?id=209504
+
+
+Reviewed by Yusuke Suzuki.
+
+Add layout test coverage.
+
+* http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt: Added.
+* http/tests/inspector/network/har/har-page-aggressive-gc.html: Added.
+* platform/gtk/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/win/TestExpectations:
+
2020-03-25 Jason Lawrence
[ Mac wk1] ASSERTION FAILED: m_wrapper under WebCore::XMLHttpRequestUpload::dispatchProgressEvent
Added: trunk/LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt (0 => 259009)
--- trunk/LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/inspector/network/har/har-page-aggressive-gc-expected.txt 2020-03-25 21:16:13 UTC (rev 259009)
@@ -0,0 +1,769 @@
+HAR Page Test.
+
+
+== Running test suite: HAR.Page
+-- Running test case: HAR.Basic.Page
+{
+ "log": {
+"version": "1.2",
+"creator": {
+ "name": "WebKit Web Inspector",
+ "version": ""
+},
+"pages": [
+ {
+"startedDateTime": "",
+"id": "page_0",
+"title": "http://127.0.0.1:8000/inspector/network/har/har-page.html",
+"pageTimings": {
+ "onContentLoad": "",
+ "onLoad": ""
+}
+ }
+],
+"entries": [
+ {
+"pageref": "page_0",
+"startedDateTime": "",
+"time": "",
+"request": {
+ "method": "GET",
+ "url": "http://127.0.0.1:8000/inspector/network/har/har-page.html",
+ "httpVersion": "",
+ "cookies": [],
+ "headers": "",
+ "queryString": [],
+ "headersSize": "",
+ "bodySize": ""
+},
+"response": {
+ "status": 200,
+ "statusText": "OK",
+ "httpVersion": "",
+ "cookies": [],
+ "headers":
[webkit-changes] [259010] trunk/LayoutTests
Title: [259010] trunk/LayoutTests Revision 259010 Author lawrenc...@apple.com Date 2020-03-25 14:27:07 -0700 (Wed, 25 Mar 2020) Log Message [ Mac wk2 ] svg/as-image/svg-image-with-data-uri-background.html is flaky failing. https://bugs.webkit.org/show_bug.cgi?id=209564 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259009 => 259010) --- trunk/LayoutTests/ChangeLog 2020-03-25 21:16:13 UTC (rev 259009) +++ trunk/LayoutTests/ChangeLog 2020-03-25 21:27:07 UTC (rev 259010) @@ -1,3 +1,12 @@ +2020-03-25 Jason Lawrence + +[ Mac wk2 ] svg/as-image/svg-image-with-data-uri-background.html is flaky failing. +https://bugs.webkit.org/show_bug.cgi?id=209564 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2020-03-25 Chris Dumez Event listeners registered with 'once' option may get garbage collected too soon Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (259009 => 259010) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-03-25 21:16:13 UTC (rev 259009) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2020-03-25 21:27:07 UTC (rev 259010) @@ -1070,3 +1070,5 @@ webkit.org/b/209490 http/tests/media/track-in-band-hls-metadata.html [ Pass Crash Timeout ] webkit.org/b/209503 [ Debug ] http/tests/referrer-policy-anchor/origin/cross-origin-http.https.html [ Pass Crash ] + +webkit.org/b/209564 svg/as-image/svg-image-with-data-uri-background.html [ Pass ImageOnlyFailure ] \ No newline at end of file ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259011] branches/safari-610.1.7-branch/Source
Title: [259011] branches/safari-610.1.7-branch/Source Revision 259011 Author alanc...@apple.com Date 2020-03-25 14:30:43 -0700 (Wed, 25 Mar 2020) Log Message Cherry-pick r258795. rdar://problem/60886075 Ensure media cache directory is created before passing to AVURLAsset. https://bugs.webkit.org/show_bug.cgi?id=209341 Reviewed by Eric Carlson. Source/WebCore: Sandbox changes require the media cache directory to be created before passing to AVFoundation, to ensure that a sandbox extension is allowed to be created for that directory. When the mediaCacheDirectory is empty or null, no longer specify a temporary directory. This allows clients to disable caching by specifying an empty string for the cache directory. Since now assetCacheForPath() can return nil, update all the call sites to handle that possibility. Add a new method, ensureAssetCacheExistsAtPath() which tries to create a directory at the specified path, and returns nil if that is not possible. This ensures the cache path exists before adding the AVAssetCache to the AVURLAsset options dictionary. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::assetCacheForPath): (WebCore::ensureAssetCacheExistsForPath): (WebCore::MediaPlayerPrivateAVFoundationObjC::originsInMediaCache): (WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache): (WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Source/WebKitLegacy/mac: MediaPlayerPrivateAVFoundaionObjC will no longer create an asset cache in a temporary directory by default; ensure that it's media cache directory is set during initialization. * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258795 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-610.1.7-branch/Source/WebCore/ChangeLog branches/safari-610.1.7-branch/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm branches/safari-610.1.7-branch/Source/WebKitLegacy/mac/ChangeLog branches/safari-610.1.7-branch/Source/WebKitLegacy/mac/WebView/WebView.mm Diff Modified: branches/safari-610.1.7-branch/Source/WebCore/ChangeLog (259010 => 259011) --- branches/safari-610.1.7-branch/Source/WebCore/ChangeLog 2020-03-25 21:27:07 UTC (rev 259010) +++ branches/safari-610.1.7-branch/Source/WebCore/ChangeLog 2020-03-25 21:30:43 UTC (rev 259011) @@ -1,79 +1,5 @@ -b"2020-03-24 Alan Coon \n\nCherry-pick r258476. rdar://problem/60839077\n\nAdd missing checks needed for AppBound Quirk\nhttps://bugs.webkit.org/show_bug.cgi?id=209117\n\n\nReviewed by John Wilander.\n\nThe checks for the 'NeedsInAppBrowserPrivacyQuirks' flag added in r258101 was incomplete.\nSource/WebCore:\n\nTwo additional call sites need to check the state of the flag.\n\n* bindings/js/ScriptController.cpp:\n(WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.\n* loader/FrameLoaderClient.h: Add new API for the 'NeedsInAppBrowserPrivacyQuirks'\ndebug flag.\n* page/Frame.cpp:\n(WebCore::Frame::injectUserScriptImmediately): Ditto.\n\nSource/WebKit:\n\nThese changes let the WebFrameLoaderClient report the quirk state to WebCore code.\n\n* WebProcess/WebCoreSupport/WebFrameLoaderC lient.cpp:\n(WebKit::WebFrameLoaderClient::needsInAppBrowserPrivacyQuirks): Added.\n* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:\n* WebProcess/WebPage/WebPage.h:\n(WebKit::WebPage::needsInAppBrowserPrivacyQuirks const): Added.\n\n\ngit-svn-id: https://svn.webkit.org/repository/webkit/trunk@258476 268f45cc-cd09-0410-ab3c-d52691b4dbfc\n\n2020-03-14 Brent Fulgham \n\nAdd missing checks needed for AppBound Quirk\nhttps://bugs.webkit.org/show_bug.cgi?id=209117\n\n\nReviewed by John Wilander.\n\nThe checks for the 'NeedsInAppBrowserPrivacyQuirks' flag added in r258101 was incomplete.\nTwo additional call sites need to check the state of the flag.\n\n* bindings/js/ScriptController.cpp:\n(WebCore::ScriptController::executeScriptInWorld): Add missing check for the quirk.\n* loader/FrameLoa derClient.h: Add new API for the 'NeedsInAppBrowserPrivacyQuirks'\ndebug flag.\n* page/Frame.cpp:\n(WebCore::Frame::injectUserScriptImmediately): Ditto.\n\n"2020-03-17 Alan Coon +b'2020-03-25 Alan Coon \n\nCherry-pick r258795. rdar://problem/60886075\n\nEnsure media cache directory is created before passing to AVURLAsset.\nhttps://bugs.webkit.org/show_bug.cgi?id=209341\n\nReviewed by Eric Carlson.\n\nSource/Web
[webkit-changes] [259012] trunk/Tools
Title: [259012] trunk/Tools
Revision 259012
Author do...@apple.com
Date 2020-03-25 14:36:05 -0700 (Wed, 25 Mar 2020)
Log Message
Unreviewed, add new committer to contributors.json
* Scripts/webkitpy/common/config/contributors.json:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Diff
Modified: trunk/Tools/ChangeLog (259011 => 259012)
--- trunk/Tools/ChangeLog 2020-03-25 21:30:43 UTC (rev 259011)
+++ trunk/Tools/ChangeLog 2020-03-25 21:36:05 UTC (rev 259012)
@@ -1,3 +1,9 @@
+2020-03-25 Doug Kelly
+
+Unreviewed, add new committer to contributors.json
+
+* Scripts/webkitpy/common/config/contributors.json:
+
2020-03-25 Frank Yang
Unprefix -webkit-text-orientation
Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (259011 => 259012)
--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2020-03-25 21:30:43 UTC (rev 259011)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json 2020-03-25 21:36:05 UTC (rev 259012)
@@ -1821,6 +1821,15 @@
"dwim"
]
},
+ "Doug Kelly" : {
+ "emails" : [
+ "do...@apple.com"
+ ],
+ "nicks" : [
+ "dougk"
+ ],
+ "status" : "committer"
+ },
"Doug Russell" : {
"emails" : [
"d_russ...@apple.com"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259013] trunk
Title: [259013] trunk
Revision 259013
Author dba...@webkit.org
Date 2020-03-25 14:56:03 -0700 (Wed, 25 Mar 2020)
Log Message
Element context character rects may be in wrong coordinate system
https://bugs.webkit.org/show_bug.cgi?id=209493
Reviewed by Wenson Hsieh.
Source/WebKit:
Convert the character rects from content view coordinates to root view coordinates
as that is the coordinate system callers of -requestDocumentContext expect.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::requestDocumentEditingContext):
Tools:
Add some tests.
* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (259012 => 259013)
--- trunk/Source/WebKit/ChangeLog 2020-03-25 21:36:05 UTC (rev 259012)
+++ trunk/Source/WebKit/ChangeLog 2020-03-25 21:56:03 UTC (rev 259013)
@@ -1,3 +1,17 @@
+2020-03-25 Daniel Bates
+
+Element context character rects may be in wrong coordinate system
+https://bugs.webkit.org/show_bug.cgi?id=209493
+
+
+Reviewed by Wenson Hsieh.
+
+Convert the character rects from content view coordinates to root view coordinates
+as that is the coordinate system callers of -requestDocumentContext expect.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::requestDocumentEditingContext):
+
2020-03-25 Wenson Hsieh
Rename "data interaction pasteboard" to "drag and drop pasteboard"
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (259012 => 259013)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-03-25 21:36:05 UTC (rev 259012)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2020-03-25 21:56:03 UTC (rev 259013)
@@ -4252,8 +4252,11 @@
unsigned offsetSoFar = startOffset;
const int stride = 1;
while (!iterator.atEnd()) {
-if (!iterator.text().isEmpty())
-rects.append({ createLiveRange(iterator.range())->absoluteBoundingBox(Range::BoundingRectBehavior::IgnoreEmptyTextSelections), { offsetSoFar++, stride } });
+if (!iterator.text().isEmpty()) {
+auto currentRange = createLiveRange(iterator.range());
+auto absoluteBoundingBox = currentRange->absoluteBoundingBox(Range::BoundingRectBehavior::IgnoreEmptyTextSelections);
+rects.append({ currentRange->ownerDocument().view()->contentsToRootView(absoluteBoundingBox), { offsetSoFar++, stride } });
+}
iterator.advance(stride);
}
return rects;
Modified: trunk/Tools/ChangeLog (259012 => 259013)
--- trunk/Tools/ChangeLog 2020-03-25 21:36:05 UTC (rev 259012)
+++ trunk/Tools/ChangeLog 2020-03-25 21:56:03 UTC (rev 259013)
@@ -1,3 +1,16 @@
+2020-03-25 Daniel Bates
+
+Element context character rects may be in wrong coordinate system
+https://bugs.webkit.org/show_bug.cgi?id=209493
+
+
+Reviewed by Wenson Hsieh.
+
+Add some tests.
+
+* TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
+(TEST):
+
2020-03-25 Doug Kelly
Unreviewed, add new committer to contributors.json
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm (259012 => 259013)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm 2020-03-25 21:36:05 UTC (rev 259012)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm 2020-03-25 21:56:03 UTC (rev 259013)
@@ -513,6 +513,64 @@
}
}
+TEST(DocumentEditingContext, RequestRectsInTextAreaInsideIFrame)
+{
+auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
+// Use "padding: 0" for the as the default user-agent stylesheet can effect text wrapping.
+[webView synchronouslyLoadHTMLString:applyAhemStyle([NSString stringWithFormat:@"", applyAhemStyle(@"The quick brown fox jumps over the lazy dog.let textarea = document.getElementById('test'); textarea.focus(); textarea.setSelectionRange(0, 0); /* Place caret at the beginning of the field. */")])];
+
+auto *context = [webView synchronouslyRequestDocumentContext:makeRequest(UIWKDocumentRequestText | UIWKDocumentRequestRects, UITextGranularityWord, 1)];
+EXPECT_NOT_NULL(context);
+EXPECT_NULL(context.contextBefore);
+EXPECT_NSSTRING_EQ("The", context.contextAfter);
+auto *textRects = [context textRects];
+EXPECT_EQ(3U, textRects.count);
+
+#if PLATFORM(MACCATALYST)
+const size_t yPos = 27;
+const size_t height = 26;
+#else
+const size_t yPos = 28;
+const size_t height = 25;
+#endif
+
+if (textRects.count >= 3) {
+CGFloat x = 28;
+EXPECT_EQ(CGRectMake(x + 0 * glyphWidth, yPos, 25, height), textRects[0].C
[webkit-changes] [259014] branches/safari-609-branch/Source/WebKit
Title: [259014] branches/safari-609-branch/Source/WebKit
Revision 259014
Author repst...@apple.com
Date 2020-03-25 14:57:10 -0700 (Wed, 25 Mar 2020)
Log Message
Unreviewed build fixes, rdar://problem/60756680&60827009
Modified Paths
branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h
Diff
Modified: branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (259013 => 259014)
--- branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-03-25 21:56:03 UTC (rev 259013)
+++ branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-03-25 21:57:10 UTC (rev 259014)
@@ -32,7 +32,7 @@
#endif
#if PLATFORM(IOS_FAMILY)
-#include
+#include
#include "VersionChecks.h"
#endif
Modified: branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h (259013 => 259014)
--- branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h 2020-03-25 21:56:03 UTC (rev 259013)
+++ branches/safari-609-branch/Source/WebKit/UIProcess/WebProcessProxy.h 2020-03-25 21:57:10 UTC (rev 259014)
@@ -498,6 +498,10 @@
ForegroundWebProcessToken m_foregroundToken;
BackgroundWebProcessToken m_backgroundToken;
+#if PLATFORM(IOS_FAMILY)
+bool m_hasSentMessageToUnblockAccessibilityServer { false };
+#endif
+
HashMap m_pageURLRetainCountMap;
Optional m_registrableDomain;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259015] trunk
Title: [259015] trunk
Revision 259015
Author simon.fra...@apple.com
Date 2020-03-25 15:28:41 -0700 (Wed, 25 Mar 2020)
Log Message
Flashing and partly visible elements
https://bugs.webkit.org/show_bug.cgi?id=204605
Reviewed by Zalan Bujtas.
Source/WebCore:
If, during a compositing update, a layer becomes non-composited, then we repaint its
location in its new target compositing layer. However, that layer might be in the list
of BackingSharingState's layers that may paint into backing provided by some ancestor,
so they'd be in a limbo state where their repaint target was unknown. We'd erroneously
repaint in some ancestor, resulting in missing content.
Fix by having BackingSharingState track a set of layers that can't be repainted currently
because their ancestor chain contains a maybe-sharing layer, and repaint them when
the backing sharing state is resolved.
This is only an issue during RenderLayerCompositor::computeCompositingRequirements()
when the backing sharing state is being computed, so most repaints are not affected.
Test: compositing/shared-backing/repaint-into-shared-backing.html
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::BackingSharingState::isPotentialBackingSharingLayer const):
(WebCore::RenderLayerCompositor::BackingSharingState::addLayerNeedingRepaint):
(WebCore::RenderLayerCompositor::BackingSharingState::endBackingSharingSequence):
(WebCore::RenderLayerCompositor::BackingSharingState::issuePendingRepaints):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::updateLayerCompositingState):
(WebCore::RenderLayerCompositor::layerRepaintTargetsBackingSharingLayer const):
* rendering/RenderLayerCompositor.h:
LayoutTests:
* compositing/shared-backing/repaint-into-shared-backing-expected.html: Added.
* compositing/shared-backing/repaint-into-shared-backing.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp
trunk/Source/WebCore/rendering/RenderLayerCompositor.h
Added Paths
trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing-expected.html
trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259014 => 259015)
--- trunk/LayoutTests/ChangeLog 2020-03-25 21:57:10 UTC (rev 259014)
+++ trunk/LayoutTests/ChangeLog 2020-03-25 22:28:41 UTC (rev 259015)
@@ -1,3 +1,13 @@
+2020-03-25 Simon Fraser
+
+Flashing and partly visible elements
+https://bugs.webkit.org/show_bug.cgi?id=204605
+
+Reviewed by Zalan Bujtas.
+
+* compositing/shared-backing/repaint-into-shared-backing-expected.html: Added.
+* compositing/shared-backing/repaint-into-shared-backing.html: Added.
+
2020-03-25 Jason Lawrence
[ Mac wk2 ] svg/as-image/svg-image-with-data-uri-background.html is flaky failing.
Added: trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing-expected.html (0 => 259015)
--- trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing-expected.html (rev 0)
+++ trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing-expected.html 2020-03-25 22:28:41 UTC (rev 259015)
@@ -0,0 +1,53 @@
+
+
+
+
+.container {
+padding: 10px;
+margin: 10px;
+border: 2px solid black;
+height: 400px;
+width: 500px;
+overflow-y: hidden;
+}
+
+.wrapper {
+position: relative;
+width: 2000px;
+z-index: 1;
+}
+
+.positioned {
+position: absolute;
+left: 0;
+top: 0;
+background-color: silver;
+z-index: 2;
+padding: 20px;
+width: 100%;
+height: 250px;
+overflow: hidden;
+}
+
+ .inner {
+position: relative;
+width: 300px;
+height: 200px;
+background-color: green;
+transform: translate(0px, 0px);
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
\ No newline at end of file
Added: trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing.html (0 => 259015)
--- trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing.html (rev 0)
+++ trunk/LayoutTests/compositing/shared-backing/repaint-into-shared-backing.html 2020-03-25 22:28:41 UTC (rev 259015)
@@ -0,0 +1,71 @@
+
+
+
+
+.container {
+padding: 10px;
+margin: 10px;
+border: 2px solid black;
+height: 400px;
+width: 500px;
+overflow-y: hidden;
+}
+
+.wrapper {
+position: relative;
+
[webkit-changes] [259016] trunk/Source/WTF
Title: [259016] trunk/Source/WTF
Revision 259016
Author sihui_...@apple.com
Date 2020-03-25 15:53:10 -0700 (Wed, 25 Mar 2020)
Log Message
Remove unused suspend functions in CrossThreadTaskHandler
https://bugs.webkit.org/show_bug.cgi?id=209553
Reviewed by Geoffrey Garen.
* wtf/CrossThreadTaskHandler.cpp:
(WTF::CrossThreadTaskHandler::taskRunLoop):
(WTF::CrossThreadTaskHandler::suspendAndWait): Deleted.
(WTF::CrossThreadTaskHandler::resume): Deleted.
* wtf/CrossThreadTaskHandler.h:
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp
trunk/Source/WTF/wtf/CrossThreadTaskHandler.h
Diff
Modified: trunk/Source/WTF/ChangeLog (259015 => 259016)
--- trunk/Source/WTF/ChangeLog 2020-03-25 22:28:41 UTC (rev 259015)
+++ trunk/Source/WTF/ChangeLog 2020-03-25 22:53:10 UTC (rev 259016)
@@ -1,3 +1,16 @@
+2020-03-25 Sihui Liu
+
+Remove unused suspend functions in CrossThreadTaskHandler
+https://bugs.webkit.org/show_bug.cgi?id=209553
+
+Reviewed by Geoffrey Garen.
+
+* wtf/CrossThreadTaskHandler.cpp:
+(WTF::CrossThreadTaskHandler::taskRunLoop):
+(WTF::CrossThreadTaskHandler::suspendAndWait): Deleted.
+(WTF::CrossThreadTaskHandler::resume): Deleted.
+* wtf/CrossThreadTaskHandler.h:
+
2020-03-24 Per Arne Vollan
[Cocoa] Fix launch time regression with CF prefs direct mode enabled
Modified: trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp (259015 => 259016)
--- trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp 2020-03-25 22:28:41 UTC (rev 259015)
+++ trunk/Source/WTF/wtf/CrossThreadTaskHandler.cpp 2020-03-25 22:53:10 UTC (rev 259016)
@@ -72,22 +72,9 @@
}
while (!m_taskQueue.isKilled()) {
-{
-std::unique_ptr autodrainedPool = (m_useAutodrainedPool == AutodrainedPoolForRunLoop::Use) ? makeUnique() : nullptr;
+std::unique_ptr autodrainedPool = (m_useAutodrainedPool == AutodrainedPoolForRunLoop::Use) ? makeUnique() : nullptr;
-m_taskQueue.waitForMessage().performTask();
-}
-
-Locker shouldSuspendLocker(m_shouldSuspendLock);
-while (m_shouldSuspend) {
-m_suspendedLock.lock();
-if (!m_suspended) {
-m_suspended = true;
-m_suspendedCondition.notifyOne();
-}
-m_suspendedLock.unlock();
-m_shouldSuspendCondition.wait(m_shouldSuspendLock);
-}
+m_taskQueue.waitForMessage().performTask();
}
}
@@ -102,34 +89,4 @@
task->performTask();
}
-void CrossThreadTaskHandler::suspendAndWait()
-{
-ASSERT(isMainThread());
-{
-Locker locker(m_shouldSuspendLock);
-m_shouldSuspend = true;
-}
-
-// Post an empty task to ensure database thread knows m_shouldSuspend and sets m_suspended.
-postTask(CrossThreadTask([]() { }));
-
-Locker locker(m_suspendedLock);
-while (!m_suspended)
-m_suspendedCondition.wait(m_suspendedLock);
-}
-
-void CrossThreadTaskHandler::resume()
-{
-ASSERT(isMainThread());
-Locker locker(m_shouldSuspendLock);
-if (m_shouldSuspend) {
-m_suspendedLock.lock();
-if (m_suspended)
-m_suspended = false;
-m_suspendedLock.unlock();
-m_shouldSuspend = false;
-m_shouldSuspendCondition.notifyOne();
-}
-}
-
} // namespace WTF
Modified: trunk/Source/WTF/wtf/CrossThreadTaskHandler.h (259015 => 259016)
--- trunk/Source/WTF/wtf/CrossThreadTaskHandler.h 2020-03-25 22:28:41 UTC (rev 259015)
+++ trunk/Source/WTF/wtf/CrossThreadTaskHandler.h 2020-03-25 22:53:10 UTC (rev 259016)
@@ -45,8 +45,6 @@
WTF_EXPORT_PRIVATE void postTask(CrossThreadTask&&);
WTF_EXPORT_PRIVATE void postTaskReply(CrossThreadTask&&);
-WTF_EXPORT_PRIVATE void suspendAndWait();
-WTF_EXPORT_PRIVATE void resume();
private:
void handleTaskRepliesOnMainThread();
@@ -58,14 +56,6 @@
Lock m_mainThreadReplyLock;
bool m_mainThreadReplyScheduled { false };
-bool m_shouldSuspend { false };
-Condition m_shouldSuspendCondition;
-Lock m_shouldSuspendLock;
-
-bool m_suspended { false };
-Condition m_suspendedCondition;
-Lock m_suspendedLock;
-
CrossThreadQueue m_taskQueue;
CrossThreadQueue m_taskReplyQueue;
};
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259017] trunk/Tools
Title: [259017] trunk/Tools
Revision 259017
Author zhifei_f...@apple.com
Date 2020-03-25 16:05:41 -0700 (Wed, 25 Mar 2020)
Log Message
[Timeline] Fix the out of bound dot index
https://bugs.webkit.org/show_bug.cgi?id=209492
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
(Timeline.CanvasSeriesComponent):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (259016 => 259017)
--- trunk/Tools/ChangeLog 2020-03-25 22:53:10 UTC (rev 259016)
+++ trunk/Tools/ChangeLog 2020-03-25 23:05:41 UTC (rev 259017)
@@ -1,3 +1,13 @@
+2020-03-25 Zhifei Fang
+
+[Timeline] Fix the out of bound dot index
+https://bugs.webkit.org/show_bug.cgi?id=209492
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+(Timeline.CanvasSeriesComponent):
+
2020-03-25 Daniel Bates
Element context character rects may be in wrong coordinate system
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (259016 => 259017)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 22:53:10 UTC (rev 259016)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:05:41 UTC (rev 259017)
@@ -385,10 +385,8 @@
let endScalesIndex = startScalesIndex + Math.ceil((renderWidth) / dotWidth);
if (endScalesIndex >= scales.length)
endScalesIndex = scales.length - 1;
-let currentDotIndex = startScalesIndex - (scales.length - dots.length);
-if (currentDotIndex < 0)
-currentDotIndex = 0;
-for (let i = currentDotIndex; i <= startScalesIndex; i++) {
+let currentDotIndex = 0;
+for (let i = currentDotIndex; i <= startScalesIndex && currentDotIndex < dots.length; i++) {
const compResult = comp(scales[startScalesIndex], getScale(dots[currentDotIndex]));
if (!reversed) {
if (compResult > 0)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259018] trunk/Source/WTF
Title: [259018] trunk/Source/WTF Revision 259018 Author chris.r...@sony.com Date 2020-03-25 16:19:01 -0700 (Wed, 25 Mar 2020) Log Message [PlayStation] Specify a 16 KB minimum page size https://bugs.webkit.org/show_bug.cgi?id=209566 Reviewed by Ross Kirsling. * wtf/PageBlock.h: Modified Paths trunk/Source/WTF/ChangeLog trunk/Source/WTF/wtf/PageBlock.h Diff Modified: trunk/Source/WTF/ChangeLog (259017 => 259018) --- trunk/Source/WTF/ChangeLog 2020-03-25 23:05:41 UTC (rev 259017) +++ trunk/Source/WTF/ChangeLog 2020-03-25 23:19:01 UTC (rev 259018) @@ -1,3 +1,12 @@ +2020-03-25 Christopher Reid + +[PlayStation] Specify a 16 KB minimum page size +https://bugs.webkit.org/show_bug.cgi?id=209566 + +Reviewed by Ross Kirsling. + +* wtf/PageBlock.h: + 2020-03-25 Sihui Liu Remove unused suspend functions in CrossThreadTaskHandler Modified: trunk/Source/WTF/wtf/PageBlock.h (259017 => 259018) --- trunk/Source/WTF/wtf/PageBlock.h 2020-03-25 23:05:41 UTC (rev 259017) +++ trunk/Source/WTF/wtf/PageBlock.h 2020-03-25 23:19:01 UTC (rev 259018) @@ -47,7 +47,7 @@ // 64 KiB. (Apple uses 16 KiB.) // // Use 64 KiB for any unknown CPUs to be conservative. -#if OS(DARWIN) +#if OS(DARWIN) || PLATFORM(PLAYSTATION) constexpr size_t CeilingOnPageSize = 16 * KB; #elif OS(WINDOWS) || CPU(MIPS) || CPU(X86) || CPU(X86_64) || CPU(ARM) constexpr size_t CeilingOnPageSize = 4 * KB; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259019] trunk/Tools
Title: [259019] trunk/Tools
Revision 259019
Author zhifei_f...@apple.com
Date 2020-03-25 16:19:32 -0700 (Wed, 25 Mar 2020)
Log Message
[Timeline] A better default get label function, which fit the assumpation the label is always a string
https://bugs.webkit.org/show_bug.cgi?id=209567
Reviewed by Jonathan Bedard.
* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js
Diff
Modified: trunk/Tools/ChangeLog (259018 => 259019)
--- trunk/Tools/ChangeLog 2020-03-25 23:19:01 UTC (rev 259018)
+++ trunk/Tools/ChangeLog 2020-03-25 23:19:32 UTC (rev 259019)
@@ -1,5 +1,14 @@
2020-03-25 Zhifei Fang
+[Timeline] A better default get label function, which fit the assumpation the label is always a string
+https://bugs.webkit.org/show_bug.cgi?id=209567
+
+Reviewed by Jonathan Bedard.
+
+* resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+
+2020-03-25 Zhifei Fang
+
[Timeline] Fix the out of bound dot index
https://bugs.webkit.org/show_bug.cgi?id=209492
Modified: trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (259018 => 259019)
--- trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:19:01 UTC (rev 259018)
+++ trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js 2020-03-25 23:19:32 UTC (rev 259019)
@@ -609,7 +609,7 @@
const _onScaleEnter_ = typeof option._onScaleEnter_ === "function" ? option.onScaleEnter : null;
const _onScaleLeave_ = typeof option._onScaleLeave_ === "function" ? option.onScaleLeave : null;
const sortData = option.sortData === true ? option.sortData : false;
-const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => a;
+const getLabel = typeof option.getLabelFunc === "function" ? option.getLabelFunc : (a) => `${a}`;
const isTop = typeof option.isTop === "boolean" ? option.isTop : false;
// Get the css value, this component assume to use with webkit.css
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259020] trunk/Source/WebCore
Title: [259020] trunk/Source/WebCore
Revision 259020
Author wenson_hs...@apple.com
Date 2020-03-25 16:26:37 -0700 (Wed, 25 Mar 2020)
Log Message
Unreviewed, fix the watchOS build after r259008
Put a call to Pasteboard::nameOfDragPasteboard behind ENABLE(DRAG_SUPPORT); additionally, update an out-of-date
comment to reflect the fact that arbitrary UIPasteboards can be converted to a list of NSItemProviders, whose
data can be traversed in fidelity order.
* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::respectsUTIFidelities const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/PasteboardIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (259019 => 259020)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 23:19:32 UTC (rev 259019)
+++ trunk/Source/WebCore/ChangeLog 2020-03-25 23:26:37 UTC (rev 259020)
@@ -1,3 +1,14 @@
+2020-03-25 Wenson Hsieh
+
+Unreviewed, fix the watchOS build after r259008
+
+Put a call to Pasteboard::nameOfDragPasteboard behind ENABLE(DRAG_SUPPORT); additionally, update an out-of-date
+comment to reflect the fact that arbitrary UIPasteboards can be converted to a list of NSItemProviders, whose
+data can be traversed in fidelity order.
+
+* platform/ios/PasteboardIOS.mm:
+(WebCore::Pasteboard::respectsUTIFidelities const):
+
2020-03-25 Simon Fraser
Flashing and partly visible elements
Modified: trunk/Source/WebCore/platform/ios/PasteboardIOS.mm (259019 => 259020)
--- trunk/Source/WebCore/platform/ios/PasteboardIOS.mm 2020-03-25 23:19:32 UTC (rev 259019)
+++ trunk/Source/WebCore/platform/ios/PasteboardIOS.mm 2020-03-25 23:26:37 UTC (rev 259020)
@@ -350,10 +350,12 @@
bool Pasteboard::respectsUTIFidelities() const
{
-// For now, data interaction is the only feature that uses item-provider-based pasteboard representations.
-// In the future, we may need to consult the client layer to determine whether or not the pasteboard supports
-// item types ranked by fidelity.
+#if ENABLE(DRAG_SUPPORT)
+// FIXME: We should respect UTI fidelity for normal UIPasteboard-backed pasteboards as well.
return m_pasteboardName == Pasteboard::nameOfDragPasteboard();
+#else
+return false;
+#endif
}
void Pasteboard::readRespectingUTIFidelities(PasteboardWebContentReader& reader, WebContentReadingPolicy policy, Optional itemIndex)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259022] branches/safari-609-branch/Source/WebKit/Shared/ WebPreferencesDefaultValues.cpp
Title: [259022] branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
Revision 259022
Author repst...@apple.com
Date 2020-03-25 16:47:30 -0700 (Wed, 25 Mar 2020)
Log Message
Unreviewed build fix, rdar://problem/60756680
Modified Paths
branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
Diff
Modified: branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (259021 => 259022)
--- branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-03-25 23:41:50 UTC (rev 259021)
+++ branches/safari-609-branch/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2020-03-25 23:47:30 UTC (rev 259022)
@@ -50,7 +50,7 @@
bool defaultCSSOMViewScrollingAPIEnabled()
{
#if PLATFORM(IOS_FAMILY)
-if (WebCore::IOSApplication::isIMDb() && WebCore::applicationSDKVersion() < DYLD_IOS_VERSION_13_0)
+if (WebCore::IOSApplication::isIMDb() && applicationSDKVersion() < DYLD_IOS_VERSION_13_0)
return false;
#endif
return true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259023] trunk/Source/WebKit
Title: [259023] trunk/Source/WebKit Revision 259023 Author pvol...@apple.com Date 2020-03-25 16:52:24 -0700 (Wed, 25 Mar 2020) Log Message [macOS] Fix sandbox violations related to media playback https://bugs.webkit.org/show_bug.cgi?id=209568 Reviewed by Brent Fulgham. Fix observed sandbox violations during media playback. * UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::mediaRelatedMachServices): Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm Diff Modified: trunk/Source/WebKit/ChangeLog (259022 => 259023) --- trunk/Source/WebKit/ChangeLog 2020-03-25 23:47:30 UTC (rev 259022) +++ trunk/Source/WebKit/ChangeLog 2020-03-25 23:52:24 UTC (rev 259023) @@ -1,3 +1,16 @@ +2020-03-25 Per Arne Vollan + +[macOS] Fix sandbox violations related to media playback +https://bugs.webkit.org/show_bug.cgi?id=209568 + + +Reviewed by Brent Fulgham. + +Fix observed sandbox violations during media playback. + +* UIProcess/Cocoa/WebProcessPoolCocoa.mm: +(WebKit::mediaRelatedMachServices): + 2020-03-25 Daniel Bates Element context character rects may be in wrong coordinate system Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (259022 => 259023) --- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-25 23:47:30 UTC (rev 259022) +++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2020-03-25 23:52:24 UTC (rev 259023) @@ -253,7 +253,7 @@ "com.apple.coremedia.visualcontext.xpc", "com.apple.airplay.apsynccontroller.xpc", "com.apple.audio.AURemoteIOServer" #endif -#if PLATFORM(MAC) +#if PLATFORM(MAC) || PLATFORM(MACCATALYST) "com.apple.coremedia.endpointstream.xpc", "com.apple.coremedia.endpointplaybacksession.xpc", "com.apple.coremedia.endpointremotecontrolsession.xpc", "com.apple.coremedia.videodecoder", "com.apple.coremedia.videoencoder" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259024] trunk
Title: [259024] trunk
Revision 259024
Author commit-qu...@webkit.org
Date 2020-03-25 17:28:36 -0700 (Wed, 25 Mar 2020)
Log Message
CanvasRenderingContext2D.putImageData() should not process neutered ImageData
https://bugs.webkit.org/show_bug.cgi?id=208303
Patch by Pinki Gyanchandani on 2020-03-25
Reviewed by Said Abou-Hallawa.
Source/WebCore:
Test: fast/canvas/canvas-putImageData-neutered-ImageData.html
The crash happens when putImageData is called on a neutered ImageData object.
Added a check to exit from CanvasRenderingContext2D.putImageData() function when ImageData object is neutered.
* html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::putImageData):
LayoutTests:
Added slightly modified version of testcase from bugzilla.
This testcase checks that a neutered ImageData object is not considered to be put onto the canvas.
* fast/canvas/canvas-putImageData-neutered-ImageData-expected.txt: Added.
* fast/canvas/canvas-putImageData-neutered-ImageData.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
Added Paths
trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData-expected.txt
trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259023 => 259024)
--- trunk/LayoutTests/ChangeLog 2020-03-25 23:52:24 UTC (rev 259023)
+++ trunk/LayoutTests/ChangeLog 2020-03-26 00:28:36 UTC (rev 259024)
@@ -1,3 +1,16 @@
+2020-03-25 Pinki Gyanchandani
+
+CanvasRenderingContext2D.putImageData() should not process neutered ImageData
+https://bugs.webkit.org/show_bug.cgi?id=208303
+
+Reviewed by Said Abou-Hallawa.
+
+Added slightly modified version of testcase from bugzilla.
+This testcase checks that a neutered ImageData object is not considered to be put onto the canvas.
+
+* fast/canvas/canvas-putImageData-neutered-ImageData-expected.txt: Added.
+* fast/canvas/canvas-putImageData-neutered-ImageData.html: Added.
+
2020-03-25 Simon Fraser
Flashing and partly visible elements
Added: trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData-expected.txt (0 => 259024)
--- trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData-expected.txt 2020-03-26 00:28:36 UTC (rev 259024)
@@ -0,0 +1,2 @@
+Test passes if it does not crash.
+
Added: trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html (0 => 259024)
--- trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/canvas-putImageData-neutered-ImageData.html 2020-03-26 00:28:36 UTC (rev 259024)
@@ -0,0 +1,23 @@
+
+
+
+
+function canvasTest() {
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var worker = new Worker('non-existent-file');
+var imageWidth = 1;
+var imageHeight = 1;
+var image = new ImageData( imageWidth, imageHeight);
+var context = document.getElementById("canvas").getContext("2d");
+worker.postMessage({data: image.data.buffer}, [image.data.buffer]);
+context.putImageData(image, 0, 0);
+}
+
+
+
+Test passes if it does not crash.
+
+
+
Modified: trunk/Source/WebCore/ChangeLog (259023 => 259024)
--- trunk/Source/WebCore/ChangeLog 2020-03-25 23:52:24 UTC (rev 259023)
+++ trunk/Source/WebCore/ChangeLog 2020-03-26 00:28:36 UTC (rev 259024)
@@ -1,3 +1,18 @@
+2020-03-25 Pinki Gyanchandani
+
+CanvasRenderingContext2D.putImageData() should not process neutered ImageData
+https://bugs.webkit.org/show_bug.cgi?id=208303
+
+Reviewed by Said Abou-Hallawa.
+
+Test: fast/canvas/canvas-putImageData-neutered-ImageData.html
+
+The crash happens when putImageData is called on a neutered ImageData object.
+Added a check to exit from CanvasRenderingContext2D.putImageData() function when ImageData object is neutered.
+
+* html/canvas/CanvasRenderingContext2DBase.cpp:
+(WebCore::CanvasRenderingContext2DBase::putImageData):
+
2020-03-25 Chris Dumez
Use JSC::EnsureStillAliveScope RAII object in the generated bindings code
Modified: trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp (259023 => 259024)
--- trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp 2020-03-25 23:52:24 UTC (rev 259023)
+++ trunk/Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp 2020-03-26 00:28:36 UTC (rev 259024)
@@ -2159,7 +2159,7 @@
if (!buffer)
return;
-if (!data.data())
+if (!data.data() || data.data()->isNeutered())
return;
if (dirtyWidth < 0) {
___
webkit-changes mailing list
webkit-changes@lists.webkit
[webkit-changes] [259025] trunk/Source/WebKit
Title: [259025] trunk/Source/WebKit
Revision 259025
Author timothy_hor...@apple.com
Date 2020-03-25 17:32:00 -0700 (Wed, 25 Mar 2020)
Log Message
Unable to build WebKit with iOS 13.4 SDK
https://bugs.webkit.org/show_bug.cgi?id=209317
Reviewed by Megan Gardner.
* Platform/spi/ios/UIKitSPI.h:
Stop defining some UIKit SPI that is now API (hurray!).
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259024 => 259025)
--- trunk/Source/WebKit/ChangeLog 2020-03-26 00:28:36 UTC (rev 259024)
+++ trunk/Source/WebKit/ChangeLog 2020-03-26 00:32:00 UTC (rev 259025)
@@ -1,3 +1,13 @@
+2020-03-25 Tim Horton
+
+Unable to build WebKit with iOS 13.4 SDK
+https://bugs.webkit.org/show_bug.cgi?id=209317
+
+Reviewed by Megan Gardner.
+
+* Platform/spi/ios/UIKitSPI.h:
+Stop defining some UIKit SPI that is now API (hurray!).
+
2020-03-25 Per Arne Vollan
[macOS] Fix sandbox violations related to media playback
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (259024 => 259025)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-03-26 00:28:36 UTC (rev 259024)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-03-26 00:32:00 UTC (rev 259025)
@@ -230,10 +230,12 @@
kUIKeyboardInputPreProcessed = 1 << 7,
} UIKeyboardInputFlags;
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 130400
typedef NS_OPTIONS(NSInteger, UIEventButtonMask) {
UIEventButtonMaskPrimary = 1 << 0,
UIEventButtonMaskSecondary = 1 << 1,
};
+#endif
@interface UIEvent ()
- (void *)_hidEvent;
@@ -379,6 +381,7 @@
UIScrollViewIndicatorInsetAdjustmentNever
};
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 130400
typedef enum {
UIAxisNeither = 0,
UIAxisHorizontal = 1 << 0,
@@ -385,6 +388,7 @@
UIAxisVertical = 1 << 1,
UIAxisBoth = (UIAxisHorizontal | UIAxisVertical),
} UIAxis;
+#endif
@interface UIScrollView ()
- (void)_stopScrollingAndZoomingAnimations;
@@ -411,7 +415,9 @@
@end
@interface UIGestureRecognizer ()
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 130400
@property (nonatomic, readonly, getter=_modifierFlags) UIKeyModifierFlags modifierFlags;
+#endif
- (void)_hoverEntered:(NSSet *)touches withEvent:(UIEvent *)event;
- (void)_hoverMoved:(NSSet *)touches withEvent:(UIEvent *)event;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259026] trunk
Title: [259026] trunk Revision 259026 Author shvaikal...@gmail.com Date 2020-03-25 18:24:05 -0700 (Wed, 25 Mar 2020) Log Message Invalid numeric and named references should be early syntax errors https://bugs.webkit.org/show_bug.cgi?id=178175 Reviewed by Ross Kirsling. JSTests: * test262/expectations.yaml: Mark 44 test cases as passing. Source/_javascript_Core: This patch: 1. Fixes named reference parsing in parseEscape(), making /\k/u throw SyntaxError per spec [1]. 2. Reworks containsIllegalNamedForwardReferences(), making dangling (e.g. /\k(?.)/) and incomplete (e.g. /\k<(?.)/) named references throw SyntaxError if the non-Unicode pattern contains a named group [2]. 3. Moves reparsing logic from YarrPattern to YarrParser, ensuring syntax errors due to illegal references (named & numeric) are thrown at parse time; drops isValidNamedForwardReference() from Delegate, refactors saveUnmatchedNamedForwardReferences(), and overall improves cohesion of illegal references logic. [1]: https://tc39.es/ecma262/#prod-IdentityEscape [2]: https://tc39.es/ecma262/#sec-regexpinitialize (step 7.b) * yarr/YarrErrorCode.cpp: (JSC::Yarr::errorMessage): (JSC::Yarr::errorToThrow): * yarr/YarrErrorCode.h: * yarr/YarrParser.h: (JSC::Yarr::Parser::CharacterClassParserDelegate::atomNamedBackReference): (JSC::Yarr::Parser::Parser): (JSC::Yarr::Parser::parseEscape): (JSC::Yarr::Parser::parseParenthesesBegin): (JSC::Yarr::Parser::parse): (JSC::Yarr::Parser::handleIllegalReferences): (JSC::Yarr::Parser::containsIllegalNamedForwardReference): (JSC::Yarr::Parser::resetForReparsing): (JSC::Yarr::parse): (JSC::Yarr::Parser::CharacterClassParserDelegate::isValidNamedForwardReference): Deleted. * yarr/YarrPattern.cpp: (JSC::Yarr::YarrPatternConstructor::atomBackReference): (JSC::Yarr::YarrPatternConstructor::atomNamedForwardReference): (JSC::Yarr::YarrPattern::compile): (JSC::Yarr::YarrPatternConstructor::saveUnmatchedNamedForwardReferences): Deleted. (JSC::Yarr::YarrPatternConstructor::isValidNamedForwardReference): Deleted. * yarr/YarrPattern.h: (JSC::Yarr::YarrPattern::resetForReparsing): (JSC::Yarr::YarrPattern::containsIllegalBackReference): Deleted. (JSC::Yarr::YarrPattern::containsIllegalNamedForwardReferences): Deleted. * yarr/YarrSyntaxChecker.cpp: (JSC::Yarr::SyntaxChecker::atomNamedBackReference): (JSC::Yarr::SyntaxChecker::resetForReparsing): (JSC::Yarr::SyntaxChecker::isValidNamedForwardReference): Deleted. Source/WebCore: Accounts for changes of YarrParser's Delegate interface, no behavioral changes. resetForReparsing() is never called because we disable numeric backrefences and named forward references (see arguments of Yarr::parse() call). Test: TestWebKitAPI.ContentExtensionTest.ParsingFailures * contentextensions/URLFilterParser.cpp: (WebCore::ContentExtensions::PatternParser::resetForReparsing): (WebCore::ContentExtensions::URLFilterParser::addPattern): (WebCore::ContentExtensions::PatternParser::isValidNamedForwardReference): Deleted. Tools: Removes FIXME as YarrParser is correct not to throw errors as it is parsing in non-Unicode mode. Also adds a few named groups tests. * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: LayoutTests: * js/regexp-named-capture-groups-expected.txt: * js/script-tests/regexp-named-capture-groups.js: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/expectations.yaml trunk/LayoutTests/ChangeLog trunk/LayoutTests/js/regexp-named-capture-groups-expected.txt trunk/LayoutTests/js/script-tests/regexp-named-capture-groups.js trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/yarr/YarrErrorCode.cpp trunk/Source/_javascript_Core/yarr/YarrErrorCode.h trunk/Source/_javascript_Core/yarr/YarrParser.h trunk/Source/_javascript_Core/yarr/YarrPattern.cpp trunk/Source/_javascript_Core/yarr/YarrPattern.h trunk/Source/_javascript_Core/yarr/YarrSyntaxChecker.cpp trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/contentextensions/URLFilterParser.cpp trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp Diff Modified: trunk/JSTests/ChangeLog (259025 => 259026) --- trunk/JSTests/ChangeLog 2020-03-26 00:32:00 UTC (rev 259025) +++ trunk/JSTests/ChangeLog 2020-03-26 01:24:05 UTC (rev 259026) @@ -1,5 +1,14 @@ 2020-03-25 Alexey Shvayka +Invalid numeric and named references should be early syntax errors +https://bugs.webkit.org/show_bug.cgi?id=178175 + +Reviewed by Ross Kirsling. + +* test262/expectations.yaml: Mark 44 test cases as passing. + +2020-03-25 Alexey Shvayka + \b escapes inside character classes should be valid in Unicode patterns https://bugs.webkit.org/show_bug.cgi?id=209528 Modified: trunk/JSTests/test262/expectations.yaml (259025 => 259026) --- trunk/JSTests/test262/expectations.yaml 2020-03-26 00:32:00 UTC (rev 259025) +++ trunk/JSTests/test262/expectations.yaml 2020-03-26 01:24:05 UTC (rev 259026) @@ -1711,9 +1711,6 @@ test
[webkit-changes] [259027] trunk
Title: [259027] trunk
Revision 259027
Author shihchieh_...@apple.com
Date 2020-03-25 18:51:14 -0700 (Wed, 25 Mar 2020)
Log Message
Nullptr crash in WebCore::Node::isDescendantOf when inserting list
https://bugs.webkit.org/show_bug.cgi?id=209529
Reviewed by Darin Adler.
Source/WebCore:
The visible positions may be null if the DOM tree is altered before an edit command is applied.
Add null check for visible positions at the beginning of InsertListCommand::doApply.
Test: editing/inserting/insert-list-during-node-removal-crash.html
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
LayoutTests:
Added a regression test for the crash.
* editing/inserting/insert-list-during-node-removal-crash-expected.txt: Added.
* editing/inserting/insert-list-during-node-removal-crash.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/InsertListCommand.cpp
Added Paths
trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash-expected.txt
trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash.html
Diff
Modified: trunk/LayoutTests/ChangeLog (259026 => 259027)
--- trunk/LayoutTests/ChangeLog 2020-03-26 01:24:05 UTC (rev 259026)
+++ trunk/LayoutTests/ChangeLog 2020-03-26 01:51:14 UTC (rev 259027)
@@ -1,3 +1,16 @@
+2020-03-25 Jack Lee
+
+Nullptr crash in WebCore::Node::isDescendantOf when inserting list
+https://bugs.webkit.org/show_bug.cgi?id=209529
+
+
+Reviewed by Darin Adler.
+
+Added a regression test for the crash.
+
+* editing/inserting/insert-list-during-node-removal-crash-expected.txt: Added.
+* editing/inserting/insert-list-during-node-removal-crash.html: Added.
+
2020-03-25 Alexey Shvayka
Invalid numeric and named references should be early syntax errors
Added: trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash-expected.txt (0 => 259027)
--- trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash-expected.txt 2020-03-26 01:51:14 UTC (rev 259027)
@@ -0,0 +1 @@
+Tests inserting list during node removal. The test passes if WebKit doesn't crash or hit an assertion.
Added: trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash.html (0 => 259027)
--- trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash.html (rev 0)
+++ trunk/LayoutTests/editing/inserting/insert-list-during-node-removal-crash.html 2020-03-26 01:51:14 UTC (rev 259027)
@@ -0,0 +1,23 @@
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function DomNodeEventHandler() {
+document.execCommand("insertOrderedList", false);
+requestAnimationFrame(function () {
+document.body.innerHTML = " Tests inserting list during node removal. The test passes if WebKit doesn't crash or hit an assertion.
";
+if (window.testRunner) {
+testRunner.notifyDone();
+}
+});
+}
+
+window._onload_ = () => {
+TD.addEventListener("DOMNodeRemovedFromDocument", DomNodeEventHandler);
+document.execCommand("selectAll", false);
+window.getSelection().deleteFromDocument();
+}
+
+a
Modified: trunk/Source/WebCore/ChangeLog (259026 => 259027)
--- trunk/Source/WebCore/ChangeLog 2020-03-26 01:24:05 UTC (rev 259026)
+++ trunk/Source/WebCore/ChangeLog 2020-03-26 01:51:14 UTC (rev 259027)
@@ -1,3 +1,19 @@
+2020-03-25 Jack Lee
+
+Nullptr crash in WebCore::Node::isDescendantOf when inserting list
+https://bugs.webkit.org/show_bug.cgi?id=209529
+
+
+Reviewed by Darin Adler.
+
+The visible positions may be null if the DOM tree is altered before an edit command is applied.
+Add null check for visible positions at the beginning of InsertListCommand::doApply.
+
+Test: editing/inserting/insert-list-during-node-removal-crash.html
+
+* editing/InsertListCommand.cpp:
+(WebCore::InsertListCommand::doApply):
+
2020-03-25 Alexey Shvayka
Invalid numeric and named references should be early syntax errors
Modified: trunk/Source/WebCore/editing/InsertListCommand.cpp (259026 => 259027)
--- trunk/Source/WebCore/editing/InsertListCommand.cpp 2020-03-26 01:24:05 UTC (rev 259026)
+++ trunk/Source/WebCore/editing/InsertListCommand.cpp 2020-03-26 01:51:14 UTC (rev 259027)
@@ -112,12 +112,13 @@
void InsertListCommand::doApply()
{
-if (endingSelection().isNoneOrOrphaned() || !endingSelection().isContentRichlyEditable())
+VisiblePosition visibleEnd = endingSelection().visibleEnd();
+VisiblePosition visibleStart = endingSelection().visibleStart();
+
+if (visibleEnd.isNull() || visibleStart.isN
[webkit-changes] [259028] trunk/Source/WebKit
Title: [259028] trunk/Source/WebKit
Revision 259028
Author rn...@webkit.org
Date 2020-03-25 19:10:38 -0700 (Wed, 25 Mar 2020)
Log Message
Mini browser immediately hit an assertion in debug build
https://bugs.webkit.org/show_bug.cgi?id=209575
Reviewed by Simon Fraser.
Use 1 instead of 0 as the desination ID to avoid hitting assertions.
* WebProcess/GPU/media/RemoteAudioSession.cpp:
(WebKit::RemoteAudioSession::RemoteAudioSession):
(WebKit::RemoteAudioSession::~RemoteAudioSession):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (259027 => 259028)
--- trunk/Source/WebKit/ChangeLog 2020-03-26 01:51:14 UTC (rev 259027)
+++ trunk/Source/WebKit/ChangeLog 2020-03-26 02:10:38 UTC (rev 259028)
@@ -1,3 +1,16 @@
+2020-03-25 Ryosuke Niwa
+
+Mini browser immediately hit an assertion in debug build
+https://bugs.webkit.org/show_bug.cgi?id=209575
+
+Reviewed by Simon Fraser.
+
+Use 1 instead of 0 as the desination ID to avoid hitting assertions.
+
+* WebProcess/GPU/media/RemoteAudioSession.cpp:
+(WebKit::RemoteAudioSession::RemoteAudioSession):
+(WebKit::RemoteAudioSession::~RemoteAudioSession):
+
2020-03-25 Tim Horton
Unable to build WebKit with iOS 13.4 SDK
Modified: trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp (259027 => 259028)
--- trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp 2020-03-26 01:51:14 UTC (rev 259027)
+++ trunk/Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp 2020-03-26 02:10:38 UTC (rev 259028)
@@ -49,13 +49,13 @@
: m_process(process)
, m_configuration(WTFMove(configuration))
{
-m_process.ensureGPUProcessConnection().messageReceiverMap().addMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 0, *this);
+m_process.ensureGPUProcessConnection().messageReceiverMap().addMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 1, *this);
}
RemoteAudioSession::~RemoteAudioSession()
{
if (auto* connection = m_process.existingGPUProcessConnection())
-connection->messageReceiverMap().removeMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 0);
+connection->messageReceiverMap().removeMessageReceiver(Messages::RemoteAudioSession::messageReceiverName(), 1);
}
IPC::Connection& RemoteAudioSession::connection()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259029] trunk
Title: [259029] trunk Revision 259029 Author shvaikal...@gmail.com Date 2020-03-25 19:24:29 -0700 (Wed, 25 Mar 2020) Log Message RegExp.prototype[@@replace] relies on globals and doesn't perform ToLength https://bugs.webkit.org/show_bug.cgi?id=173867 Reviewed by Ross Kirsling. JSTests: * test262/expectations.yaml: Mark 4 test cases as passing. Source/_javascript_Core: This change: a) Adds "lastIndex" ToLength coercion [1], which is observable, unlike ToLength coercion of RegExpExec result [2] that we omit, just like the one in @@split [3]. b) Removes `lastPosition` checks/updates, as there are none in the spec, and it was equivalent to checking `nextSourcePosition`. c) Removes reliance of @@replace on globals and also replaces @stringSubstrInternal built-in with @stringSubstringInternal, as the former is Annex B and accepts size as 2nd paramter, which is not very handy because ECMA-262 usually says "substring of S consisting of the code units at indices X (inclusive) through Y (exclusive)". [1]: https://tc39.es/ecma262/#sec-regexp.prototype-@@replace (step 11.c.iii.2.a) [2]: https://tc39.es/ecma262/#sec-regexp.prototype-@@replace (step 14.a) [3]: https://tc39.es/ecma262/#sec-regexp.prototype-@@split (step 19.d.iv.6) * builtins/BuiltinNames.h: * builtins/RegExpPrototype.js: (getSubstitution): (Symbol.replace): (Symbol.split): * builtins/StringPrototype.js: (globalPrivate.repeatCharactersSlowPath): * bytecode/LinkTimeConstant.h: * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): * runtime/StringPrototype.cpp: (JSC::stringIndexOfImpl): (JSC::stringProtoFuncIndexOf): (JSC::builtinStringIndexOfInternal): (JSC::stringProtoFuncSubstr): (JSC::stringSubstringImpl): (JSC::stringProtoFuncSubstring): (JSC::builtinStringSubstringInternal): (JSC::stringProtoFuncSubstrImpl): Deleted. (JSC::builtinStringSubstrInternal): Deleted. * runtime/StringPrototype.h: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/expectations.yaml trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/builtins/BuiltinNames.h trunk/Source/_javascript_Core/builtins/RegExpPrototype.js trunk/Source/_javascript_Core/builtins/StringPrototype.js trunk/Source/_javascript_Core/bytecode/LinkTimeConstant.h trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp trunk/Source/_javascript_Core/runtime/StringPrototype.cpp trunk/Source/_javascript_Core/runtime/StringPrototype.h Diff Modified: trunk/JSTests/ChangeLog (259028 => 259029) --- trunk/JSTests/ChangeLog 2020-03-26 02:10:38 UTC (rev 259028) +++ trunk/JSTests/ChangeLog 2020-03-26 02:24:29 UTC (rev 259029) @@ -1,5 +1,14 @@ 2020-03-25 Alexey Shvayka +RegExp.prototype[@@replace] relies on globals and doesn't perform ToLength +https://bugs.webkit.org/show_bug.cgi?id=173867 + +Reviewed by Ross Kirsling. + +* test262/expectations.yaml: Mark 4 test cases as passing. + +2020-03-25 Alexey Shvayka + Invalid numeric and named references should be early syntax errors https://bugs.webkit.org/show_bug.cgi?id=178175 Modified: trunk/JSTests/test262/expectations.yaml (259028 => 259029) --- trunk/JSTests/test262/expectations.yaml 2020-03-26 02:10:38 UTC (rev 259028) +++ trunk/JSTests/test262/expectations.yaml 2020-03-26 02:24:29 UTC (rev 259029) @@ -1654,12 +1654,6 @@ test/built-ins/RegExp/prototype/Symbol.match/builtin-infer-unicode.js: default: 'Test262Error: Expected SameValue(«�», «null») to be true' strict mode: 'Test262Error: Expected SameValue(«�», «null») to be true' -test/built-ins/RegExp/prototype/Symbol.replace/coerce-lastindex.js: - default: 'Test262Error: Expected SameValue(«18014398509481984», «9007199254740992») to be true' - strict mode: 'Test262Error: Expected SameValue(«18014398509481984», «9007199254740992») to be true' -test/built-ins/RegExp/prototype/Symbol.replace/poisoned-stdlib.js: - default: 'TypeError: undefined is not a function' - strict mode: 'TypeError: undefined is not a function' test/built-ins/RegExp/prototype/Symbol.search/set-lastindex-init-samevalue.js: default: 'Test262Error: Expected SameValue(«0», «0») to be true' strict mode: 'Test262Error: Expected SameValue(«0», «0») to be true' Modified: trunk/Source/_javascript_Core/ChangeLog (259028 => 259029) --- trunk/Source/_javascript_Core/ChangeLog 2020-03-26 02:10:38 UTC (rev 259028) +++ trunk/Source/_javascript_Core/ChangeLog 2020-03-26 02:24:29 UTC (rev 259029) @@ -1,5 +1,51 @@ 2020-03-25 Alexey Shvayka +RegExp.prototype[@@replace] relies on globals and doesn't perform ToLength +https://bugs.webkit.org/show_bug.cgi?id=173867 + +Reviewed by Ross Kirsling. + +This change: + +a) Adds "lastIndex" ToLength coercion [1], which is observable, unlike ToLength coercion + of RegExpExec result [2] that we omit, just like the one in @@split [3]. + +b) Removes `lastPosition` checks/updates, as there are none in the spec, and i
[webkit-changes] [259030] trunk/Source/WebKit
Title: [259030] trunk/Source/WebKit
Revision 259030
Author timothy_hor...@apple.com
Date 2020-03-25 20:26:41 -0700 (Wed, 25 Mar 2020)
Log Message
Unable to build WebKit with iOS 13.4 SDK
https://bugs.webkit.org/show_bug.cgi?id=209317
* Platform/spi/ios/UIKitSPI.h:
Address post-landing review comment; use SDK conditionals, not deployment
target conditionals, since SPI headers are mimicing SDK content.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h
Diff
Modified: trunk/Source/WebKit/ChangeLog (259029 => 259030)
--- trunk/Source/WebKit/ChangeLog 2020-03-26 02:24:29 UTC (rev 259029)
+++ trunk/Source/WebKit/ChangeLog 2020-03-26 03:26:41 UTC (rev 259030)
@@ -1,3 +1,12 @@
+2020-03-25 Timothy Horton
+
+Unable to build WebKit with iOS 13.4 SDK
+https://bugs.webkit.org/show_bug.cgi?id=209317
+
+* Platform/spi/ios/UIKitSPI.h:
+Address post-landing review comment; use SDK conditionals, not deployment
+target conditionals, since SPI headers are mimicing SDK content.
+
2020-03-25 Ryosuke Niwa
Mini browser immediately hit an assertion in debug build
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (259029 => 259030)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-03-26 02:24:29 UTC (rev 259029)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2020-03-26 03:26:41 UTC (rev 259030)
@@ -230,7 +230,7 @@
kUIKeyboardInputPreProcessed = 1 << 7,
} UIKeyboardInputFlags;
-#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 130400
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 130400
typedef NS_OPTIONS(NSInteger, UIEventButtonMask) {
UIEventButtonMaskPrimary = 1 << 0,
UIEventButtonMaskSecondary = 1 << 1,
@@ -381,7 +381,7 @@
UIScrollViewIndicatorInsetAdjustmentNever
};
-#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 130400
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 130400
typedef enum {
UIAxisNeither = 0,
UIAxisHorizontal = 1 << 0,
@@ -415,7 +415,7 @@
@end
@interface UIGestureRecognizer ()
-#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 130400
+#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 130400
@property (nonatomic, readonly, getter=_modifierFlags) UIKeyModifierFlags modifierFlags;
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259032] trunk/JSTests
Title: [259032] trunk/JSTests Revision 259032 Author ross.kirsl...@sony.com Date 2020-03-25 21:29:26 -0700 (Wed, 25 Mar 2020) Log Message Unreviewed, reimport test262 once more to make bot green. * test262/expectations.yaml: * test262/harness/assert.js: * test262/harness/propertyHelper.js: * test262/latest-changes-summary.txt: * test262/test/built-ins/JSON/stringify/replacer-function-stack-overflow.js: Removed. * test262/test/built-ins/JSON/stringify/value-tojson-stack-overflow.js: Removed. * test262/test/built-ins/NativeErrors/AggregateError/newtarget-is-undefined.js: Added. * test262/test/built-ins/RegExp/prototype/Symbol.replace/poisoned-stdlib.js: * test262/test/harness/assert-samevalue-zeros.js: * test262/test/language/expressions/class/elements/private-field-after-optional-chain.js: Added. * test262/test/language/statements/class/elements/private-field-after-optional-chain.js: Added. * test262/test262-Revision.txt: Modified Paths trunk/JSTests/ChangeLog trunk/JSTests/test262/expectations.yaml trunk/JSTests/test262/harness/assert.js trunk/JSTests/test262/harness/propertyHelper.js trunk/JSTests/test262/latest-changes-summary.txt trunk/JSTests/test262/test/built-ins/RegExp/prototype/Symbol.replace/poisoned-stdlib.js trunk/JSTests/test262/test/harness/assert-samevalue-zeros.js trunk/JSTests/test262/test262-Revision.txt Added Paths trunk/JSTests/test262/test/built-ins/NativeErrors/AggregateError/newtarget-is-undefined.js trunk/JSTests/test262/test/language/expressions/class/elements/private-field-after-optional-chain.js trunk/JSTests/test262/test/language/statements/class/elements/private-field-after-optional-chain.js Removed Paths trunk/JSTests/test262/test/built-ins/JSON/stringify/replacer-function-stack-overflow.js trunk/JSTests/test262/test/built-ins/JSON/stringify/value-tojson-stack-overflow.js Diff Modified: trunk/JSTests/ChangeLog (259031 => 259032) --- trunk/JSTests/ChangeLog 2020-03-26 04:28:40 UTC (rev 259031) +++ trunk/JSTests/ChangeLog 2020-03-26 04:29:26 UTC (rev 259032) @@ -1,3 +1,20 @@ +2020-03-25 Ross Kirsling + +Unreviewed, reimport test262 once more to make bot green. + +* test262/expectations.yaml: +* test262/harness/assert.js: +* test262/harness/propertyHelper.js: +* test262/latest-changes-summary.txt: +* test262/test/built-ins/JSON/stringify/replacer-function-stack-overflow.js: Removed. +* test262/test/built-ins/JSON/stringify/value-tojson-stack-overflow.js: Removed. +* test262/test/built-ins/NativeErrors/AggregateError/newtarget-is-undefined.js: Added. +* test262/test/built-ins/RegExp/prototype/Symbol.replace/poisoned-stdlib.js: +* test262/test/harness/assert-samevalue-zeros.js: +* test262/test/language/expressions/class/elements/private-field-after-optional-chain.js: Added. +* test262/test/language/statements/class/elements/private-field-after-optional-chain.js: Added. +* test262/test262-Revision.txt: + 2020-03-25 Alexey Shvayka RegExp.prototype[@@replace] relies on globals and doesn't perform ToLength Modified: trunk/JSTests/test262/expectations.yaml (259031 => 259032) --- trunk/JSTests/test262/expectations.yaml 2020-03-26 04:28:40 UTC (rev 259031) +++ trunk/JSTests/test262/expectations.yaml 2020-03-26 04:29:26 UTC (rev 259032) @@ -1086,12 +1086,6 @@ test/built-ins/JSON/parse/reviver-object-non-configurable-prop-create.js: default: 'Test262Error: Expected SameValue(«22», «2») to be true' strict mode: 'Test262Error: Expected SameValue(«22», «2») to be true' -test/built-ins/JSON/stringify/replacer-function-stack-overflow.js: - default: 'Exception: _javascript_ execution terminated.' - strict mode: 'Exception: _javascript_ execution terminated.' -test/built-ins/JSON/stringify/value-tojson-stack-overflow.js: - default: 'Exception: _javascript_ execution terminated.' - strict mode: 'Exception: _javascript_ execution terminated.' test/built-ins/Map/proto-from-ctor-realm.js: default: 'Test262Error: Expected SameValue(«[object Map]», «[object Map]») to be true' strict mode: 'Test262Error: Expected SameValue(«[object Map]», «[object Map]») to be true' @@ -1655,11 +1649,11 @@ default: 'Test262Error: Expected SameValue(«�», «null») to be true' strict mode: 'Test262Error: Expected SameValue(«�», «null») to be true' test/built-ins/RegExp/prototype/Symbol.search/set-lastindex-init-samevalue.js: - default: 'Test262Error: Expected SameValue(«0», «0») to be true' - strict mode: 'Test262Error: Expected SameValue(«0», «0») to be true' + default: 'Test262Error: Expected SameValue(«-0», «0») to be true' + strict mode: 'Test262Error: Expected SameValue(«-0», «0») to be true' test/built-ins/RegExp/prototype/Symbol.search/set-lastindex-restore-samevalue.js: - default: 'Test262Error: Expected SameValue(«0», «0») to be true' - strict mode: 'Test262Error: Expected SameValue(«0», «0») to be true' + default: 'Test262Error: Expecte
[webkit-changes] [259031] trunk
Title: [259031] trunk
Revision 259031
Author commit-qu...@webkit.org
Date 2020-03-25 21:28:40 -0700 (Wed, 25 Mar 2020)
Log Message
[ macOS ] svg/custom/textPath-change-id-pattern.svg is flakey failing
https://bugs.webkit.org/show_bug.cgi?id=208532
Patch by Said Abou-Hallawa on 2020-03-25
Reviewed by Darin Adler.
Source/WebCore:
In this layout test, the id of a element changes. This is
referenced by a element which is a child of a element.
The element is used to fill a element.
This patch ensures all clients () of the resource ancestor ()
of any sub-resource () is marked for repaint when the id of a
sub-sub-resource () changes.
* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForRepaint):
* rendering/svg/RenderSVGResourceContainer.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
(WebCore::SVGElement::invalidateInstances):
Unrelated change. This is a leftover from r179807 which was converting a
"do { } while();" statement to "while() { }" statement.
LayoutTests:
* platform/mac-wk1/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.h
trunk/Source/WebCore/svg/SVGElement.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (259030 => 259031)
--- trunk/LayoutTests/ChangeLog 2020-03-26 03:26:41 UTC (rev 259030)
+++ trunk/LayoutTests/ChangeLog 2020-03-26 04:28:40 UTC (rev 259031)
@@ -1,3 +1,12 @@
+2020-03-25 Said Abou-Hallawa
+
+[ macOS ] svg/custom/textPath-change-id-pattern.svg is flakey failing
+https://bugs.webkit.org/show_bug.cgi?id=208532
+
+Reviewed by Darin Adler.
+
+* platform/mac-wk1/TestExpectations:
+
2020-03-25 Jack Lee
Nullptr crash in WebCore::Node::isDescendantOf when inserting list
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (259030 => 259031)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-26 03:26:41 UTC (rev 259030)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2020-03-26 04:28:40 UTC (rev 259031)
@@ -943,8 +943,6 @@
webkit.org/b/209480 [ Debug ] webgl/2.0.0/conformance/attribs/gl-vertexattribpointer.html [ Pass Timeout ]
-webkit.org/b/208532 svg/custom/textPath-change-id-pattern.svg [ Pass Failure ]
-
webkit.org/b/208825 [ Debug ] inspector/script-profiler/event-type-Microtask.html [ Pass Failure ]
webkit.org/b/208890 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore_openKeyCursor.htm [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (259030 => 259031)
--- trunk/Source/WebCore/ChangeLog 2020-03-26 03:26:41 UTC (rev 259030)
+++ trunk/Source/WebCore/ChangeLog 2020-03-26 04:28:40 UTC (rev 259031)
@@ -1,3 +1,27 @@
+2020-03-25 Said Abou-Hallawa
+
+[ macOS ] svg/custom/textPath-change-id-pattern.svg is flakey failing
+https://bugs.webkit.org/show_bug.cgi?id=208532
+
+Reviewed by Darin Adler.
+
+In this layout test, the id of a element changes. This is
+referenced by a element which is a child of a element.
+The element is used to fill a element.
+
+This patch ensures all clients () of the resource ancestor ()
+of any sub-resource () is marked for repaint when the id of a
+sub-sub-resource () changes.
+
+* rendering/svg/RenderSVGResourceContainer.cpp:
+(WebCore::RenderSVGResourceContainer::markAllClientsForRepaint):
+* rendering/svg/RenderSVGResourceContainer.h:
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::buildPendingResourcesIfNeeded):
+(WebCore::SVGElement::invalidateInstances):
+Unrelated change. This is a leftover from r179807 which was converting a
+"do { } while();" statement to "while() { }" statement.
+
2020-03-25 Jack Lee
Nullptr crash in WebCore::Node::isDescendantOf when inserting list
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp (259030 => 259031)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2020-03-26 03:26:41 UTC (rev 259030)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp 2020-03-26 04:28:40 UTC (rev 259031)
@@ -90,6 +90,11 @@
registerResource();
}
+void RenderSVGResourceContainer::markAllClientsForRepaint()
+{
+markAllClientsForInvalidation(RepaintInvalidation);
+}
+
void RenderSVGResourceContainer::markAllClientsForInvalidation(InvalidationMode mode)
{
// FIXME: Style invalidation should either be a pre-layout task or this function
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.h (259030 => 259031)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceContainer.h 2020-03-26 03:26:41 UTC (rev 259030)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourc
[webkit-changes] [259033] trunk/LayoutTests
Title: [259033] trunk/LayoutTests Revision 259033 Author ryanhad...@apple.com Date 2020-03-25 21:44:08 -0700 (Wed, 25 Mar 2020) Log Message Unreviewed test gardening for Win10. * platform/win/TestExpectations: Skip two webanimations tests that are consistently timing out. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (259032 => 259033) --- trunk/LayoutTests/ChangeLog 2020-03-26 04:29:26 UTC (rev 259032) +++ trunk/LayoutTests/ChangeLog 2020-03-26 04:44:08 UTC (rev 259033) @@ -1,3 +1,9 @@ +2020-03-25 Ryan Haddad + +Unreviewed test gardening for Win10. + +* platform/win/TestExpectations: Skip two webanimations tests that are consistently timing out. + 2020-03-25 Said Abou-Hallawa [ macOS ] svg/custom/textPath-change-id-pattern.svg is flakey failing Modified: trunk/LayoutTests/platform/win/TestExpectations (259032 => 259033) --- trunk/LayoutTests/platform/win/TestExpectations 2020-03-26 04:29:26 UTC (rev 259032) +++ trunk/LayoutTests/platform/win/TestExpectations 2020-03-26 04:44:08 UTC (rev 259033) @@ -4478,6 +4478,10 @@ webkit.org/b/209455 http/tests/misc/last-modified-parsing.html [ Failure ] +webkit.org/b/209583 webanimations/no-scheduling-while-filling-accelerated.html [ Skip ] + +webkit.org/b/209582 webanimations/css-transition-in-flight-reversal-accelerated.html [ Skip ] + # IntersectionObserver is off by default http/tests/lazyload [ Skip ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [259034] trunk/Source/WebCore
Title: [259034] trunk/Source/WebCore
Revision 259034
Author sihui_...@apple.com
Date 2020-03-25 23:26:51 -0700 (Wed, 25 Mar 2020)
Log Message
IndexedDB: destroy UniqueIDBDatabase when it's not used
https://bugs.webkit.org/show_bug.cgi?id=209532
Reviewed by Geoffrey Garen.
Reviewed by Geoffrey Garen.
When all connections of a UniqueIDBDatabase object are closed and there are no pending reuqests, the
object may not be used any more. We should delete it for better memory use.
* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::removeUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::closeAndTakeUniqueIDBDatabase): Deleted.
* Modules/indexeddb/server/IDBServer.h:
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::handleDelete):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::tryCloseAndRemoveFromServer):
* Modules/indexeddb/server/UniqueIDBDatabase.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (259033 => 259034)
--- trunk/Source/WebCore/ChangeLog 2020-03-26 04:44:08 UTC (rev 259033)
+++ trunk/Source/WebCore/ChangeLog 2020-03-26 06:26:51 UTC (rev 259034)
@@ -1,3 +1,25 @@
+2020-03-25 Sihui Liu
+
+IndexedDB: destroy UniqueIDBDatabase when it's not used
+https://bugs.webkit.org/show_bug.cgi?id=209532
+
+Reviewed by Geoffrey Garen.
+
+Reviewed by Geoffrey Garen.
+
+When all connections of a UniqueIDBDatabase object are closed and there are no pending reuqests, the
+object may not be used any more. We should delete it for better memory use.
+
+* Modules/indexeddb/server/IDBServer.cpp:
+(WebCore::IDBServer::IDBServer::removeUniqueIDBDatabase):
+(WebCore::IDBServer::IDBServer::closeAndTakeUniqueIDBDatabase): Deleted.
+* Modules/indexeddb/server/IDBServer.h:
+* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+(WebCore::IDBServer::UniqueIDBDatabase::handleDelete):
+(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
+(WebCore::IDBServer::UniqueIDBDatabase::tryCloseAndRemoveFromServer):
+* Modules/indexeddb/server/UniqueIDBDatabase.h:
+
2020-03-25 Said Abou-Hallawa
[ macOS ] svg/custom/textPath-change-id-pattern.svg is flakey failing
Modified: trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp (259033 => 259034)
--- trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp 2020-03-26 04:44:08 UTC (rev 259033)
+++ trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp 2020-03-26 06:26:51 UTC (rev 259034)
@@ -171,15 +171,13 @@
database->handleDelete(*connection, requestData);
}
-std::unique_ptr IDBServer::closeAndTakeUniqueIDBDatabase(UniqueIDBDatabase& database)
+void IDBServer::removeUniqueIDBDatabase(const IDBDatabaseIdentifier& identifier)
{
-LOG(IndexedDB, "IDBServer::closeUniqueIDBDatabase");
-ASSERT(isMainThread());
+LOG(IndexedDB, "IDBServer::removeUniqueIDBDatabase");
+ASSERT(!isMainThread());
-auto uniquePointer = m_uniqueIDBDatabaseMap.take(database.identifier());
-ASSERT(uniquePointer);
-
-return uniquePointer;
+auto removed = m_uniqueIDBDatabaseMap.remove(identifier);
+ASSERT_UNUSED(removed, removed);
}
void IDBServer::abortTransaction(const IDBResourceIdentifier& transactionIdentifier)
Modified: trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h (259033 => 259034)
--- trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h 2020-03-26 04:44:08 UTC (rev 259033)
+++ trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.h 2020-03-26 06:26:51 UTC (rev 259034)
@@ -96,7 +96,7 @@
void registerTransaction(UniqueIDBDatabaseTransaction&);
void unregisterTransaction(UniqueIDBDatabaseTransaction&);
-std::unique_ptr closeAndTakeUniqueIDBDatabase(UniqueIDBDatabase&);
+void removeUniqueIDBDatabase(const IDBDatabaseIdentifier&);
std::unique_ptr createBackingStore(const IDBDatabaseIdentifier&);
Modified: trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp (259033 => 259034)
--- trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2020-03-26 04:44:08 UTC (rev 259033)
+++ trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp 2020-03-26 06:26:51 UTC (rev 259034)
@@ -379,6 +379,8 @@
m_pendingOpenDBRequests.add(ServerOpenDBRequest::create(connection, requestData));
handleDatabaseOperations();
+
+tryCloseAndRemoveFromServer();
}
void UniqueIDBDatabase::startVersionChangeTransaction()
@@ -946,6 +948,7 @@
handleDatabaseOperations();
handleTr
[webkit-changes] [259035] trunk
Title: [259035] trunk
Revision 259035
Author hironori.fu...@sony.com
Date 2020-03-25 23:43:11 -0700 (Wed, 25 Mar 2020)
Log Message
[Win] lld-link: error: /manifestdependency: is not allowed in .drectve
https://bugs.webkit.org/show_bug.cgi?id=204831
Reviewed by Ross Kirsling.
.:
clang-cl doesn't support #pragma comment(linker, "/manifestdependency ..").
Use an linker option instead.
* Source/cmake/WebKitMacros.cmake (WEBKIT_EXECUTABLE): Added -manifestdependency linkder option if WIN32.
Source/_javascript_Core:
* shell/DLLLauncherMain.cpp: Removed /manifestdependency for Microsoft.VC80.CRT which seems leftover of Bug 116562 (r178530).
Tools:
* TestWebKitAPI/win/main.cpp:
* win/DLLLauncher/DLLLauncherMain.cpp:
Modified Paths
trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp
trunk/Source/cmake/WebKitMacros.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/win/main.cpp
trunk/Tools/win/DLLLauncher/DLLLauncherMain.cpp
Diff
Modified: trunk/ChangeLog (259034 => 259035)
--- trunk/ChangeLog 2020-03-26 06:26:51 UTC (rev 259034)
+++ trunk/ChangeLog 2020-03-26 06:43:11 UTC (rev 259035)
@@ -1,3 +1,15 @@
+2020-03-25 Fujii Hironori
+
+[Win] lld-link: error: /manifestdependency: is not allowed in .drectve
+https://bugs.webkit.org/show_bug.cgi?id=204831
+
+Reviewed by Ross Kirsling.
+
+clang-cl doesn't support #pragma comment(linker, "/manifestdependency ..").
+Use an linker option instead.
+
+* Source/cmake/WebKitMacros.cmake (WEBKIT_EXECUTABLE): Added -manifestdependency linkder option if WIN32.
+
2020-03-23 Michael Catanzaro
[GTK] Allow distributors to brand user agent
Modified: trunk/Source/_javascript_Core/ChangeLog (259034 => 259035)
--- trunk/Source/_javascript_Core/ChangeLog 2020-03-26 06:26:51 UTC (rev 259034)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-03-26 06:43:11 UTC (rev 259035)
@@ -1,3 +1,12 @@
+2020-03-25 Fujii Hironori
+
+[Win] lld-link: error: /manifestdependency: is not allowed in .drectve
+https://bugs.webkit.org/show_bug.cgi?id=204831
+
+Reviewed by Ross Kirsling.
+
+* shell/DLLLauncherMain.cpp: Removed /manifestdependency for Microsoft.VC80.CRT which seems leftover of Bug 116562 (r178530).
+
2020-03-25 Alexey Shvayka
RegExp.prototype[@@replace] relies on globals and doesn't perform ToLength
Modified: trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp (259034 => 259035)
--- trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp 2020-03-26 06:26:51 UTC (rev 259034)
+++ trunk/Source/_javascript_Core/shell/DLLLauncherMain.cpp 2020-03-26 06:43:11 UTC (rev 259035)
@@ -35,21 +35,6 @@
#include
#include
-#if defined _M_IX86
-#define PROCESSORARCHITECTURE "x86"
-#elif defined _M_IA64
-#define PROCESSORARCHITECTURE "ia64"
-#elif defined _M_X64
-#define PROCESSORARCHITECTURE "amd64"
-#else
-#define PROCESSORARCHITECTURE "*"
-#endif
-
-#pragma comment(linker, "/manifestdependency:\"type='win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorArchitecture='" PROCESSORARCHITECTURE "' publicKeyToken='6595b64144ccf1df' language='*'\"")
-#if defined(_MSC_VER) && (_MSC_VER >= 1600) && !defined(WIN_CAIRO)
-#pragma comment(linker, "/manifestdependency:\"type='win32' name='Microsoft.VC80.CRT' version='8.0.50727.6195' processorArchitecture='" PROCESSORARCHITECTURE "' publicKeyToken='1fc8b3b9a1e18e3b' language='*'\"")
-#endif
-
static void enableTerminationOnHeapCorruption()
{
HEAP_INFORMATION_CLASS heapEnableTerminationOnCorruption = static_cast(1);
Modified: trunk/Source/cmake/WebKitMacros.cmake (259034 => 259035)
--- trunk/Source/cmake/WebKitMacros.cmake 2020-03-26 06:26:51 UTC (rev 259034)
+++ trunk/Source/cmake/WebKitMacros.cmake 2020-03-26 06:43:11 UTC (rev 259035)
@@ -217,6 +217,16 @@
if (${_target}_OUTPUT_NAME)
set_target_properties(${_target} PROPERTIES OUTPUT_NAME ${${_target}_OUTPUT_NAME})
endif ()
+if (WIN32)
+if (WTF_CPU_X86)
+set(_processor_architecture "x86")
+elseif (WTF_CPU_X86_64)
+set(_processor_architecture "amd64")
+else ()
+set(_processor_architecture "*")
+endif ()
+target_link_options(${_target} PRIVATE "-manifestdependency:type='win32' name='Microsoft.Windows.Common-Controls' version='6.0.0.0' processorArchitecture='${_processor_architecture}'")
+endif ()
endmacro()
macro(WEBKIT_WRAP_EXECUTABLE _target)
Modified: trunk/Tools/ChangeLog (259034 => 259035)
--- trunk/Tools/ChangeLog 2020-03-26 06:26:51 UTC (rev 259034)
+++ trunk/Tools/ChangeLog 2020-03-26 06:43:11 UTC (rev 259035)
@@ -1,3 +1,13 @@
+2020-03-25 Fujii Hironori
+
+[Win] lld-link: error: /manifestdependency: is not allowed in .drectve
+https://bugs.webkit.org/show_bug.cgi?id=204831
+
+Reviewed by Ross Kirsling.
+
+* TestWebKitAPI/win/main.cpp:
