[webkit-changes] [WebKit/WebKit] 02b37e: [GStreamer][WebRTC] Debug asserts in incoming vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 02b37efd8fec0fe9b6751493a4b9c5b5f0697308 https://github.com/WebKit/WebKit/commit/02b37efd8fec0fe9b6751493a4b9c5b5f0697308 Author: Philippe Normand Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Debug asserts in incoming video source https://bugs.webkit.org/show_bug.cgi?id=261145 Reviewed by Xabier Rodriguez-Calvar. dispatchSample might trigger RealtimeMediaSource::notifySettingsDidChangeObservers() which expects to run in the main thread. * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp: (WebCore::RealtimeIncomingAudioSourceGStreamer::dispatchSample): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp: (WebCore::RealtimeIncomingSourceGStreamer::registerClient): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp: (WebCore::RealtimeIncomingVideoSourceGStreamer::dispatchSample): Canonical link: https://commits.webkit.org/267665@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9c3e31: [GStreamer] Missing check on mapped video frame va...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9c3e31205a2df36f0fcf4fc8bf40b90da15cd00f https://github.com/WebKit/WebKit/commit/9c3e31205a2df36f0fcf4fc8bf40b90da15cd00f Author: Philippe Normand Date: 2023-09-06 (Wed, 06 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer] Missing check on mapped video frame validity before pushing to compositor https://bugs.webkit.org/show_bug.cgi?id=261144 Reviewed by Xabier Rodriguez-Calvar. Exit early from the pushDMABufToCompositor() method if we failed to map the video frame. No need for a dedicated warning, there is one already in gst_video_frame_map(). * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): Canonical link: https://commits.webkit.org/267663@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0580cc: [GStreamer][WebRTC] Some tests hitting hashtable a...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0580cc9765f27145c9b0155a4724160dd692a4b8 https://github.com/WebKit/WebKit/commit/0580cc9765f27145c9b0155a4724160dd692a4b8 Author: Philippe Normand Date: 2023-09-07 (Thu, 07 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Some tests hitting hashtable asserts https://bugs.webkit.org/show_bug.cgi?id=261148 Reviewed by Xabier Rodriguez-Calvar. Bail out from meta copy function if the transform type is not supported. The same check is done in other implementations such as GstVideoMeta. * Source/WebCore/platform/graphics/gstreamer/VideoFrameMetadataGStreamer.cpp: (videoFrameMetadataGetInfo): Canonical link: https://commits.webkit.org/267721@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c76046: [GStreamer] registerAppsinkWithWorkaroundsIfNeeded...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c760465095dda52270369a1f4f620a253bc320d8 https://github.com/WebKit/WebKit/commit/c760465095dda52270369a1f4f620a253bc320d8 Author: Philippe Normand Date: 2023-09-01 (Fri, 01 Sep 2023) Changed paths: M Source/WebCore/platform/AudioDecoder.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp Log Message: --- [GStreamer] registerAppsinkWithWorkaroundsIfNeededCallOnce() should be callable from non-main threads https://bugs.webkit.org/show_bug.cgi?id=260711 Reviewed by Alicia Boya Garcia. Remove un-needed ASSERT, nothing should prevent to call gst_element_register() from a non-main thread. * Source/WebCore/platform/AudioDecoder.cpp: (WebCore::AudioDecoder::isCodecSupported): * Source/WebCore/platform/graphics/gstreamer/GStreamerSinksWorkarounds.cpp: (WebCore::registerAppsinkWithWorkaroundsIfNeededCallOnce): Canonical link: https://commits.webkit.org/267550@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6c4458: [GStreamer] WebCodecs gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6c4458b35259a70d20146a0c511d72a538e5f670 https://github.com/WebKit/WebKit/commit/6c4458b35259a70d20146a0c511d72a538e5f670 Author: Philippe Normand Date: 2023-09-13 (Wed, 13 Sep 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt Log Message: --- [GStreamer] WebCodecs gardening https://bugs.webkit.org/show_bug.cgi?id=261499 Unreviewed, WebCodecs rebaseline and expectations updates. * LayoutTests/platform/glib/TestExpectations: reconfiguring-encoder* tests passing after 267865@main * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt: Rebaseline after 267403@main * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt: Ditto Canonical link: https://commits.webkit.org/267939@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 08a37f: WebCodecs AudioEncoder implementation
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 08a37f0893cdc5a25ccc5eadb855f7751949635a https://github.com/WebKit/WebKit/commit/08a37f0893cdc5a25ccc5eadb855f7751949635a Author: Philippe Normand Date: 2023-09-13 (Wed, 13 Sep 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-codec-specific.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder-config.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.worker-expected.txt M LayoutTests/platform/glib/TestExpectations M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources.make A Source/WebCore/Modules/webcodecs/AacEncoderConfig.h A Source/WebCore/Modules/webcodecs/AacEncoderConfig.idl A Source/WebCore/Modules/webcodecs/FlacEncoderConfig.h A Source/WebCore/Modules/webcodecs/FlacEncoderConfig.idl A Source/WebCore/Modules/webcodecs/OpusEncoderConfig.h A Source/WebCore/Modules/webcodecs/OpusEncoderConfig.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.cpp A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoder.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderConfig.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderSupport.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioEncoderSupport.idl A Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkMetadata.h A Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkMetadata.idl A Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkOutputCallback.h A Source/WebCore/Modules/webcodecs/WebCodecsEncodedAudioChunkOutputCallback.idl M Source/WebCore/Sources.txt M Source/WebCore/WebCore.xcodeproj/project.pbxproj M Source/WebCore/bindings/js/WebCoreBuiltinNames.h M Source/WebCore/dom/EventTargetFactory.in A Source/WebCore/platform/AudioEncoder.cpp A Source/WebCore/platform/AudioEncoder.h A Source/WebCore/platform/AudioEncoderActiveConfiguration.h M Source/WebCore/platform/PlatformScreen.cpp M Source/WebCore/platform/SourcesGStreamer.txt M Source/WebCore/platform/audio/PlatformRawAudioData.h A Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp A Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.h M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.h M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp Log Message: --- WebCodecs AudioEncoder implementation https://bugs.webkit.org/show_bug.cgi?id=261107 Reviewed by Youenn Fablet. This patch exposes AudioEncoder and its implementation for ports enabling the WebCodecsAudioEnabled setting. Canonical link: https://commits.webkit.org/267963@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 48c2a6: [GLib] Remote playback tests gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 48c2a63b170c321152e94e1560c8efba320a9123 https://github.com/WebKit/WebKit/commit/48c2a63b170c321152e94e1560c8efba320a9123 Author: Philippe Normand Date: 2023-09-07 (Thu, 07 Sep 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GLib] Remote playback tests gardening https://bugs.webkit.org/show_bug.cgi?id=261275 Unreviewed, skip WPT remote-playback tests, WIRELESS_PLAYBACK_TARGET is disabled in GLib ports. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/267738@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1fb4cd: [WebCodecs] AudioDecoder follow-up after 267403@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1fb4cdd856dd56a4c6b7973ed2a798f8d2e3a793 https://github.com/WebKit/WebKit/commit/1fb4cdd856dd56a4c6b7973ed2a798f8d2e3a793 Author: Philippe Normand Date: 2023-09-07 (Thu, 07 Sep 2023) Changed paths: M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.h M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.idl M Source/WebCore/platform/AudioDecoder.cpp Log Message: --- [WebCodecs] AudioDecoder follow-up after 267403@main https://bugs.webkit.org/show_bug.cgi?id=260958 Reviewed by Youenn Fablet. The AudioDecoder config validation now follows the spec more closely. Some tests still fail, not catching the exception raised when configuring the decoder with an invalid config, but the same failures happen in the VideoDecoder, so both should be addressed in a separate patch. * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt: * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::isValidDecoderConfig): (WebCore::createAudioDecoderConfig): (WebCore::WebCodecsAudioDecoder::configure): (WebCore::WebCodecsAudioDecoder::isConfigSupported): * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.h: * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.idl: * Source/WebCore/platform/AudioDecoder.cpp: (WebCore::AudioDecoder::isCodecSupported): Canonical link: https://commits.webkit.org/267743@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cfd564: [WPE] Bump internal Cog commit
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cfd564becff8fafc7101926efcb65c35b9360762 https://github.com/WebKit/WebKit/commit/cfd564becff8fafc7101926efcb65c35b9360762 Author: Philippe Normand Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M Tools/PlatformWPE.cmake Log Message: --- [WPE] Bump internal Cog commit https://bugs.webkit.org/show_bug.cgi?id=260849 Reviewed by Michael Catanzaro. The list of changes since the previous version is: 9e2dc0a launcher: Add command-line option for controlling autoplay behavior 7a33249 drm: Fix logic error in indexing when using find_crtc_for_encoder 95d0aaf Update platform/drm/cog-platform-drm.c 689e7a6 Update platform/drm/cog-platform-drm.c 47dee03 drm: Fix crash on imx6 when no current encoder+crtc is bound 51e0951 gtk4: Prefix a scheme if none provided 7489ca5 Meson: check file sys/mman.h in order to define HAVE_MEMFD_CREATE 705e46d Fix maybe-uninitialized warning 5976f59 launcher: Handle GApplication::activate da64b4a Add support for weston 13 protocols 7a60bda launcher: Add CLI flag to disable built-in key bindings 48fdd6e Fix compilation warning in i386 7b7c10b core: Move key binding handling into CogView 0606be4 launcher: Remove handling of plain WPE backends 7eb8ffb core: Add a fallback CogPlatform implementation 9001a8d core: Introduce a new CogView class 023fbb0 wl: fix blurry rendering in some compositors f8ae0e6 core: Add missing underscore to environment variable names 0a9405c core: Move platform selection logic into the library 8e1acd3 webkit-utils: Check if the media engine will show the resource c51d94e headless: Move frame tick source to platform object a6d2321 launcher: Simplify by using global CogPlatform 9df4a77 drm: ignore key event if no xkb context is available af5789c docs: Fix gi-docgen wrong type for GKeyFile warning * Tools/PlatformWPE.cmake: Canonical link: https://commits.webkit.org/267414@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0717ba: [GStreamer][WebCodecs] Build video encoder active ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0717ba7dec18b44a84043c0b7a83db6f7ae97a62 https://github.com/WebKit/WebKit/commit/0717ba7dec18b44a84043c0b7a83db6f7ae97a62 Author: Philippe Normand Date: 2023-09-04 (Mon, 04 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h Log Message: --- [GStreamer][WebCodecs] Build video encoder active configuration from source pad caps https://bugs.webkit.org/show_bug.cgi?id=261084 Reviewed by Xabier Rodriguez-Calvar. The active configuration should now have a valid header buffer and colorspace, filled from the caps of the underlying GStreamer encoder source pad. Some encoders store the header in `streamheaders` (vp8, vp9) and some use a `codec_data` field (x264), so both cases need to be handled. Drive-by: Weaken the link between the GStreamerInternalVideoEncoder and its GStreamerElementHarness in order to avoid memory leaks. * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: (WebCore::GStreamerInternalVideoEncoder::create): (WebCore::GStreamerVideoEncoder::create): (WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder): (WebCore::GStreamerInternalVideoEncoder::GStreamerInternalVideoEncoder): (WebCore::GStreamerInternalVideoEncoder::encode): * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h: Canonical link: https://commits.webkit.org/267606@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 62c5bb: Cherry-pick 267399@main (3e47e6d0c366). https://bu...
/WebProcess/WebPage/DrawingArea.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_appHighlightsVisible):
(WebKit::WebPage::reinitializeWebPage):
* Source/WebKit/WebProcess/WebPage/wc/DrawingAreaWC.h:
Canonical link: https://commits.webkit.org/267733@main
Commit: 56f0f3882de8cede7ae22385938c1f0c7edebf3f
https://github.com/WebKit/WebKit/commit/56f0f3882de8cede7ae22385938c1f0c7edebf3f
Author: Philippe Normand
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp
Log Message:
---
Cherry-pick 267132@main (dfa421425d51).
https://bugs.webkit.org/show_bug.cgi?id=260423
[GStreamer][WebCodecs] Circular references in video decoder leading to
memory leaks
https://bugs.webkit.org/show_bug.cgi?id=260423
Reviewed by Xabier Rodriguez-Calvar.
Circular references between the GStreamerInternalVideoDecoder and its
harness through captured
references in lambdas was preventing proper cleanup of the harness when
closing the decoder. Using
WeakPtrs instead of strong Refs in captured variables fixes the issue.
Also, driving-by, fixing the ImageGStreamer API to fit with our style
guidelines and making sure the
sample is cleared *after* the associated video frame is un-mapped.
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::createImage):
* Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(WebCore::ImageGStreamer::~ImageGStreamer):
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp:
(WebCore::GStreamerInternalVideoDecoder::harnessedElement const):
(WebCore::GStreamerVideoDecoder::create):
(WebCore::GStreamerVideoDecoder::~GStreamerVideoDecoder):
(WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder):
(WebCore::GStreamerInternalVideoDecoder::decode):
Canonical link: https://commits.webkit.org/267132@main
Commit: 02d362b73707c6caa4fb92cceb883d198b4f7304
https://github.com/WebKit/WebKit/commit/02d362b73707c6caa4fb92cceb883d198b4f7304
Author: Enrique Ocaña González
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
M
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp
Log Message:
---
Cherry-pick 267276@main (5023d703877c).
https://bugs.webkit.org/show_bug.cgi?id=260067
[MSE][GStreamer] Deadlock while flushing on paused when there's a non
in-place transform element
https://bugs.webkit.org/show_bug.cgi?id=260067
Reviewed by Alicia Boya Garcia.
There is a deadlock possible inside WebKit media src (MSE) between
streaming thread handling
CAPS event and pipeline flush in the main thread. This happens in case
where there is a
transform element in the pipeline that does transition NOT in place.
Basetransform elem
expects that it will allocate buffers so on CAPS change it triggers
allocation negotiations
(ALLOCATION query). In such case CAPS event becomes fully synchronous as
basetransform does
ALLOCATION query that is synchronous (serialized with data) and may block
the streaming
thread. If the pipeline is paused and the sink thread doesn't accept any
data, this will
block CAPS event until pipeline is unpaused or flushed. But flush requires
a lock that
streaming thread is holding (DataMutexLocker streamingMembers {
stream->streamingMembersDataMutex };)
See: https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/1135
A way to fix this is to make webKitMediaSrcLoop() release the lock before
pushing the caps
event (which may take a long time to get processed) to let the main thread
start the flush.
Such a flush would cause the sink element to release the streaming thread
and the caps event
processing to finish. After the caps event has been pushed, the lock would
be retaken. But
streamingMembers might have changed under our feet (and it certainly will,
because of the
flush). We should reevaluate if the flush condition is present, and in that
case abort the
execution of webKitMediaSrcLoop() after having paused the streaming task of
the
corresponding pad.
*
Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcLoop): Run the caps pushing code with the lock released and
reevaluate the flush condition after the lock is reacquired.
Canonical link: https://commits.webkit.org/267276@main
Commit: 8f58a5833296d21aff427088a0789aaafc36bcb0
https://github.com/WebKit/WebKit/commit/8f58a5833296d21aff427088a0789aaafc36bcb0
Author: Philippe Normand
Date: 2023-09-08 (Fri, 08 Sep 2023)
Changed paths:
A LayoutTests/http/wpt/mediarecorder/MediaRecorder-start-s
[webkit-changes] [WebKit/WebKit] e8891e: [GStreamer] WebCodecs rebaseline after 267403@main
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e8891e7f3da958f3f23ea6aaef728c42ae69060c https://github.com/WebKit/WebKit/commit/e8891e7f3da958f3f23ea6aaef728c42ae69060c Author: Philippe Normand Date: 2023-09-08 (Fri, 08 Sep 2023) Changed paths: M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt Log Message: --- [GStreamer] WebCodecs rebaseline after 267403@main https://bugs.webkit.org/show_bug.cgi?id=261324 Unreviewed, update GLib baselines. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt: Canonical link: https://commits.webkit.org/267778@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8a21dc: [GStreamer] http/wpt/webcodecs/hevc-encoder-config...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8a21dcdda524903b19b086f9a136b360480547e0 https://github.com/WebKit/WebKit/commit/8a21dcdda524903b19b086f9a136b360480547e0 Author: Philippe Normand Date: 2023-09-08 (Fri, 08 Sep 2023) Changed paths: M LayoutTests/http/wpt/webcodecs/hevc-encoder-config.https.any.js M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/glib/media/media-can-play-h265-video-expected.txt M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h Log Message: --- [GStreamer] http/wpt/webcodecs/hevc-encoder-config.https.any.html fails https://bugs.webkit.org/show_bug.cgi?id=261267 Reviewed by Youenn Fablet and Xabier Rodriguez-Calvar. The GStreamer registry scanner now checks the validity of HEVC codec strings before looking-up an encoder or decoder for it. The test was also flaky, calling flush after the asynchronous configuration can lead to flakyness where the exception caught during flush would be the one raised during configuration. So remove the flush part. * LayoutTests/http/wpt/webcodecs/hevc-encoder-config.https.any.js: * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::isCapsSupported const): (WebCore::GStreamerRegistryScanner::isHEVCCodecSupported const): (WebCore::GStreamerRegistryScanner::isCodecSupported const): (WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const): * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h: Canonical link: https://commits.webkit.org/267781@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 53a28d: [GStreamer] mediastream and webrtc gardenings
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 53a28d96db4275f0eda4da75d03dc1e3557d2040 https://github.com/WebKit/WebKit/commit/53a28d96db4275f0eda4da75d03dc1e3557d2040 Author: Philippe Normand Date: 2023-09-08 (Fri, 08 Sep 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt M LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt M LayoutTests/platform/wpe/TestExpectations Log Message: --- [GStreamer] mediastream and webrtc gardenings https://bugs.webkit.org/show_bug.cgi?id=261327 Unreviewed, update mediastream and webrtc baselines and expectations. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt: * LayoutTests/platform/glib/fast/mediastream/RTCPeerConnection-inspect-offer-expected.txt: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/267785@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e0ed8: [WebCodecs] Realign audio decoder configuration
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e0ed8ccee82b57c0266cd6d88b24f021106d85e https://github.com/WebKit/WebKit/commit/1e0ed8ccee82b57c0266cd6d88b24f021106d85e Author: Philippe Normand Date: 2023-09-08 (Fri, 08 Sep 2023) Changed paths: M Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp Log Message: --- [WebCodecs] Realign audio decoder configuration https://bugs.webkit.org/show_bug.cgi?id=261325 Reviewed by Youenn Fablet. The decoder is now closed earlier on, in case the codec is not supported. The video decoder does this as well. * Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp: (WebCore::WebCodecsAudioDecoder::configure): Canonical link: https://commits.webkit.org/267788@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 72bca1: REGRESSION(269353@main): Introduced new crashes in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 72bca1fdbc7a82299fdab684d0660f3228ecba41 https://github.com/WebKit/WebKit/commit/72bca1fdbc7a82299fdab684d0660f3228ecba41 Author: Philippe Normand Date: 2023-10-17 (Tue, 17 Oct 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp Log Message: --- REGRESSION(269353@main): Introduced new crashes in the GStreamer WebRTC backend https://bugs.webkit.org/show_bug.cgi?id=263191 Reviewed by Xabier Rodriguez-Calvar. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp: (WebCore::fillRTCTransportStats): Fill the dtlsState field, which is required, per-spec. Canonical link: https://commits.webkit.org/269404@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 008f55: [GTK] Build broken due to a missing include in WTF
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 008f55c66fd7d78e244d5ff1ae2e50b83372af4d https://github.com/WebKit/WebKit/commit/008f55c66fd7d78e244d5ff1ae2e50b83372af4d Author: Philippe Normand Date: 2023-11-02 (Thu, 02 Nov 2023) Changed paths: M Source/WTF/wtf/text/IntegerToStringConversion.h Log Message: --- [GTK] Build broken due to a missing include in WTF https://bugs.webkit.org/show_bug.cgi?id=264085 Unreviewed. * Source/WTF/wtf/text/IntegerToStringConversion.h: Include cstdint, required for uint8_t. Canonical link: https://commits.webkit.org/270106@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d62977: [GStreamer][WebRTC] Support for remote outbound RT...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d62977ac31c639b2b32b05a0d1e434cca31683c8 https://github.com/WebKit/WebKit/commit/d62977ac31c639b2b32b05a0d1e434cca31683c8 Author: Philippe Normand Date: 2023-11-03 (Fri, 03 Nov 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp Log Message: --- [GStreamer][WebRTC] Support for remote outbound RTP statistics https://bugs.webkit.org/show_bug.cgi?id=264086 Reviewed by Xabier Rodriguez-Calvar. The remote-outbound-rtp-stream statistics are now relayed from GstWebRTC to WebKit. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp: (WebCore::fillSentRTPStreamStats): (WebCore::fillRemoteOutboundRTPStreamStats): (WebCore::fillOutboundRTPStreamStats): (WebCore::fillReportCallback): Canonical link: https://commits.webkit.org/270164@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d8cf4d: [GTK4] MiniBrowser build fails with clang-16
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d8cf4d012a1ab04ee774880962f667d491f46a14 https://github.com/WebKit/WebKit/commit/d8cf4d012a1ab04ee774880962f667d491f46a14 Author: Philippe Normand Date: 2023-11-05 (Sun, 05 Nov 2023) Changed paths: M Tools/MiniBrowser/gtk/BrowserWindow.c Log Message: --- [GTK4] MiniBrowser build fails with clang-16 https://bugs.webkit.org/show_bug.cgi?id=264223 Reviewed by Michael Catanzaro. * Tools/MiniBrowser/gtk/BrowserWindow.c: (faviconChanged): Fix unused result warning. Canonical link: https://commits.webkit.org/270247@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 264d86: REGRESSION(269844@main): [GStreamer] WebCodecs enc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 264d86dee5244d378f73d881bce792ddb51b75e2 https://github.com/WebKit/WebKit/commit/264d86dee5244d378f73d881bce792ddb51b75e2 Author: Philippe Normand Date: 2023-10-29 (Sun, 29 Oct 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt M Source/WebCore/platform/VideoDecoder.cpp M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp Log Message: --- REGRESSION(269844@main): [GStreamer] WebCodecs encoders now closing from non-main thread https://bugs.webkit.org/show_bug.cgi?id=263846 Reviewed by Youenn Fablet. Schedule the close/reset of encoders and decoders in the script execution context. Otherwise the resetEncoder() might attempt to trigger rejection of pending flush promises from a non main thread, leading to ASSERTs hit in Debug builds. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/video-encoder-config.https.any.worker-expected.txt: * Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp: (WebCore::GStreamerAudioEncoder::create): * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: (WebCore::GStreamerVideoEncoder::create): Canonical link: https://commits.webkit.org/269913@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22965f: [GStreamer][WebCodecs] Propagate audio decoder cre...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22965f369e432bd5d1b3653caa5d7ae2d4158c1e https://github.com/WebKit/WebKit/commit/22965f369e432bd5d1b3653caa5d7ae2d4158c1e Author: Philippe Normand Date: 2023-10-31 (Tue, 31 Oct 2023) Changed paths: M Source/WebCore/platform/AudioDecoder.cpp M Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.h Log Message: --- [GStreamer][WebCodecs] Propagate audio decoder create/configure errors to the script execution context https://bugs.webkit.org/show_bug.cgi?id=263851 Reviewed by Xabier Rodriguez-Calvar. Without this patch the pending flush promises rejections might trigger ASSERTs in Debug builds because they would be called from a non-main thread. * Source/WebCore/platform/AudioDecoder.cpp: (WebCore::AudioDecoder::create): * Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.cpp: (WebCore::GStreamerAudioDecoder::create): * Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.h: Canonical link: https://commits.webkit.org/270005@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1677ba: [GStreamer][WebRTC] stats gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1677ba06cb943dbf03ea6b49836a4d489c2c13e7 https://github.com/WebKit/WebKit/commit/1677ba06cb943dbf03ea6b49836a4d489c2c13e7 Author: Philippe Normand Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer][WebRTC] stats gardening https://bugs.webkit.org/show_bug.cgi?id=263638 Unreviewed, unflag crashes fixed by 269404@main. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/269759@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 788e18: [GStreamer][WebCodecs] Dispatch video encoder call...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 788e1881d666bf53a0dcff285dac1c1ba790337d https://github.com/WebKit/WebKit/commit/788e1881d666bf53a0dcff285dac1c1ba790337d Author: Philippe Normand Date: 2023-09-18 (Mon, 18 Sep 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp Log Message: --- [GStreamer][WebCodecs] Dispatch video encoder callback out of the internal work queue https://bugs.webkit.org/show_bug.cgi?id=261502 Reviewed by Xabier Rodriguez-Calvar. This should be posted as a task on the encoder's script execution context in order to reduce pressure on the GStreamer encoder WorkQueue. * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: (WebCore::GStreamerVideoEncoder::encode): Canonical link: https://commits.webkit.org/268075@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fe502b: [GStreamer][WebAudio] Misc cleanups
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fe502bf25fceede418bdfb4ed2f614e45eaf0e16 https://github.com/WebKit/WebKit/commit/fe502bf25fceede418bdfb4ed2f614e45eaf0e16 Author: Philippe Normand Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp Log Message: --- [GStreamer][WebAudio] Misc cleanups https://bugs.webkit.org/show_bug.cgi?id=262183 Reviewed by Xabier Rodriguez-Calvar. The source pad caps don't change, so we can build and store the GstAudioInfo once instead of for every push iteration. webKitWebAudioSrcAllocateBuffers was also renamed to webKitWebAudioSrcAllocateBuffer for consistency. * Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: (webKitWebAudioSrcConstructed): (webKitWebAudioSrcAllocateBuffer): (webKitWebAudioSrcRenderIteration): (webKitWebAudioSrcAllocateBuffers): Deleted. Canonical link: https://commits.webkit.org/268584@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 992ab4: [BuildStream SDK] Add libbacktrace
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 992ab41027e86e4545a4a5d8f2c6d65e5ddb96ae https://github.com/WebKit/WebKit/commit/992ab41027e86e4545a4a5d8f2c6d65e5ddb96ae Author: Philippe Normand Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M Tools/buildstream/elements/sdk-platform.bst A Tools/buildstream/elements/sdk/libbacktrace.bst Log Message: --- [BuildStream SDK] Add libbacktrace https://bugs.webkit.org/show_bug.cgi?id=262295 Reviewed by Michael Catanzaro. * Tools/buildstream/elements/sdk-platform.bst: * Tools/buildstream/elements/sdk/libbacktrace.bst: Added. Canonical link: https://commits.webkit.org/268587@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f025f7: [GStreamer][WebCodecs] Harness dumping for easier ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f025f714c6f0ab1693aa85530c5e0e01ae695e7a https://github.com/WebKit/WebKit/commit/f025f714c6f0ab1693aa85530c5e0e01ae695e7a Author: Philippe Normand Date: 2023-09-28 (Thu, 28 Sep 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp Log Message: --- [GStreamer][WebCodecs] Harness dumping for easier debugging https://bugs.webkit.org/show_bug.cgi?id=262177 Reviewed by Xabier Rodriguez-Calvar. Dump the harness graph to disk when the first encoded or decoded payload has been notified. This can be useful for debugging purposes. Also driving-by in the Harness, add space characters at link boundaries to prevent ambiguous links, especially for pads or element names starting with 'o'. * Source/WebCore/platform/audio/gstreamer/AudioDecoderGStreamer.cpp: (WebCore::GStreamerInternalAudioDecoder::GStreamerInternalAudioDecoder): * Source/WebCore/platform/audio/gstreamer/AudioEncoderGStreamer.cpp: (WebCore::GStreamerInternalAudioEncoder::GStreamerInternalAudioEncoder): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: (WebCore::GStreamerInternalVideoEncoder::GStreamerInternalVideoEncoder): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: (WebCore::MermaidBuilder::process): (WebCore::MermaidBuilder::dumpElement): Canonical link: https://commits.webkit.org/268583@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3b993a: [Buildstream SDK] Bump to GStreamer 1.22.6
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3b993aeaa79ef7c515d518bac3318ea1f61a92d5 https://github.com/WebKit/WebKit/commit/3b993aeaa79ef7c515d518bac3318ea1f61a92d5 Author: Philippe Normand Date: 2023-10-04 (Wed, 04 Oct 2023) Changed paths: M Tools/buildstream/Pipfile M Tools/buildstream/Pipfile.lock M Tools/buildstream/elements/freedesktop-sdk.bst R Tools/buildstream/patches/fdo-0001-gst-plugins-base-Vendor-patch-scheduled-for-1.22.6.patch R Tools/buildstream/patches/fdo-0001-gst-plugins-base-Vendor-patches-scheduled-for-1.22.6.patch R Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.5.patch A Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.6.patch A Tools/buildstream/patches/fdo-0010-gstreamer-Vendor-inter-patches-scheduled-for-1.22.7.patch Log Message: --- [Buildstream SDK] Bump to GStreamer 1.22.6 https://bugs.webkit.org/show_bug.cgi?id=262439 Reviewed by Carlos Alberto Lopez Perez. Update the SDK to GStreamer 1.22.6 and vendor patches needed for bug 261504. The pipenv used for building the SDK was also updated in order to run on Python 3.12 hosts. * Tools/buildstream/Pipfile: * Tools/buildstream/Pipfile.lock: * Tools/buildstream/elements/freedesktop-sdk.bst: * Tools/buildstream/patches/fdo-0001-gst-plugins-base-Vendor-patch-scheduled-for-1.22.6.patch: Removed. * Tools/buildstream/patches/fdo-0001-gst-plugins-base-Vendor-patches-scheduled-for-1.22.6.patch: Removed. * Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.6.patch: Renamed from Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.5.patch. * Tools/buildstream/patches/fdo-0010-gstreamer-Vendor-inter-patches-scheduled-for-1.22.7.patch: Added. Canonical link: https://commits.webkit.org/268852@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 42fe82: [GStreamer] Caps negotiation failure between webau...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 42fe82e162800ff6901b20e3065d591d455159db https://github.com/WebKit/WebKit/commit/42fe82e162800ff6901b20e3065d591d455159db Author: Philippe Normand Date: 2023-10-03 (Tue, 03 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp Log Message: --- [GStreamer] Caps negotiation failure between webaudio source and audio mixer https://bugs.webkit.org/show_bug.cgi?id=261504 Reviewed by Xabier Rodriguez-Calvar. Add an audioconvert downstream of each audio source, because the audio sink might not support the original format of the buffers emitted by interaudiosrc. * Source/WebCore/platform/graphics/gstreamer/GStreamerAudioMixer.cpp: (WebCore::GStreamerAudioMixer::registerProducer): Canonical link: https://commits.webkit.org/268767@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 343ea7: [GTK][WPE] Enable libbacktrace support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 343ea784deb27356e5acac7d150b53353e9e4288 https://github.com/WebKit/WebKit/commit/343ea784deb27356e5acac7d150b53353e9e4288 Author: Philippe Normand Date: 2023-10-07 (Sat, 07 Oct 2023) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [GTK][WPE] Enable libbacktrace support https://bugs.webkit.org/show_bug.cgi?id=262837 Reviewed by Michael Catanzaro. * Source/cmake/OptionsGTK.cmake: Enable libbacktrace and make indentation consistent (4 spaces). * Source/cmake/OptionsWPE.cmake: Ditto. Canonical link: https://commits.webkit.org/269037@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 87ade1: Cherry-pick 269068@main (d14f07282a9d). https://bu...
Branch: refs/heads/webkitglib/2.42 Home: https://github.com/WebKit/WebKit Commit: 87ade166f1568ff994c34dee7e2c993d63b6fac9 https://github.com/WebKit/WebKit/commit/87ade166f1568ff994c34dee7e2c993d63b6fac9 Author: Philippe Normand Date: 2023-10-19 (Thu, 19 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- Cherry-pick 269068@main (d14f07282a9d). https://bugs.webkit.org/show_bug.cgi?id=261892 [GStreamer][MSE] video playback uses GstVA, except on YouTube https://bugs.webkit.org/show_bug.cgi?id=261892 Reviewed by Xabier Rodriguez-Calvar. Streams parsing is not needed for MediaStream cases because we do it upfront for incoming WebRTC MediaStreams. It is however needed for MSE, otherwise decodebin3 might not auto-plug hardware decoders. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): Canonical link: https://commits.webkit.org/269068@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d14f07: [GStreamer][MSE] video playback uses GstVA, except...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d14f07282a9de962f9e0f3354bdc560227fdc12e https://github.com/WebKit/WebKit/commit/d14f07282a9de962f9e0f3354bdc560227fdc12e Author: Philippe Normand Date: 2023-10-09 (Mon, 09 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer][MSE] video playback uses GstVA, except on YouTube https://bugs.webkit.org/show_bug.cgi?id=261892 Reviewed by Xabier Rodriguez-Calvar. Streams parsing is not needed for MediaStream cases because we do it upfront for incoming WebRTC MediaStreams. It is however needed for MSE, otherwise decodebin3 might not auto-plug hardware decoders. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureElement): Canonical link: https://commits.webkit.org/269068@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] bcbbe4: [GStreamer][DMABuf] DRM modifiers handling
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: bcbbe4ae86b2361d75d48b80fc0959ba8180bcb9 https://github.com/WebKit/WebKit/commit/bcbbe4ae86b2361d75d48b80fc0959ba8180bcb9 Author: Philippe Normand Date: 2023-10-09 (Mon, 09 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer][DMABuf] DRM modifiers handling https://bugs.webkit.org/show_bug.cgi?id=262838 Reviewed by Xabier Rodriguez-Calvar. In the upcoming GStreamer 1.24 release the video decoders can expose DRM modifiers during caps negotiation. So in this build configuration (new API required) we can passthrough those modifiers to the TextureMapper. * Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: (webKitDMABufVideoSinkConstructed): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::pushDMABufToCompositor): Canonical link: https://commits.webkit.org/269067@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fcf3a6: [GStreamer][DMABuf] Allow negotiation with decoder...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fcf3a66b27a8ee289b8366b7fa13689d2acf6394 https://github.com/WebKit/WebKit/commit/fcf3a66b27a8ee289b8366b7fa13689d2acf6394 Author: Philippe Normand Date: 2023-10-16 (Mon, 16 Oct 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp Log Message: --- [GStreamer][DMABuf] Allow negotiation with decoders without drm-format https://bugs.webkit.org/show_bug.cgi?id=263079 Reviewed by Xabier Rodriguez-Calvar. The TextureMapper is capable to generating DMABufs and guess related format fourcc when the decoder hasn't explicitely supplied those infos in the caps, so there is no reason for our sink to restrict its caps to a specific set of DRM formats. This should allow decoders not yet ported to the new DRM caps format to still be used in combination with our DMABuf sink. * Source/WebCore/platform/graphics/gstreamer/DMABufVideoSinkGStreamer.cpp: (webKitDMABufVideoSinkConstructed): Canonical link: https://commits.webkit.org/269356@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9f6c6e: [GStreamer][Debug] Build fails with clang-16
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9f6c6e9c265dea020201b1b46395efe846b4d8dd https://github.com/WebKit/WebKit/commit/9f6c6e9c265dea020201b1b46395efe846b4d8dd Author: Philippe Normand Date: 2023-10-14 (Sat, 14 Oct 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp Log Message: --- [GStreamer][Debug] Build fails with clang-16 https://bugs.webkit.org/show_bug.cgi?id=263159 Unreviewed, remove useless ASSERT. * Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: (webKitWebAudioSrcAllocateBuffer): Canonical link: https://commits.webkit.org/269341@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2cf981: [GStreamer] Harness: Basic segment handling
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2cf98196e729c6217a83c7ded6be8801eddf517a https://github.com/WebKit/WebKit/commit/2cf98196e729c6217a83c7ded6be8801eddf517a Author: Philippe Normand Date: 2023-08-21 (Mon, 21 Aug 2023) Changed paths: M Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp M Source/WebCore/platform/gstreamer/GStreamerElementHarness.h Log Message: --- [GStreamer] Harness: Basic segment handling https://bugs.webkit.org/show_bug.cgi?id=260424 Reviewed by Xabier Rodriguez-Calvar. The pushSample API is now able to use the segment information from the sample, if it's available. The corresponding sticky segment event is then coherent. Flush handling also needed a change, after flush-stop we should re-push a segment event, but we were not doing it, leading to runtime GStreamer warnings. * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: (WebCore::GStreamerElementHarness::start): (WebCore::GStreamerElementHarness::pushStickyEvents): (WebCore::GStreamerElementHarness::pushSegmentEvent): (WebCore::GStreamerElementHarness::pushSample): (WebCore::GStreamerElementHarness::pushBuffer): (WebCore::GStreamerElementHarness::flush): (WebCore::GStreamerElementHarness::flushBuffers): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.h: (WebCore::GStreamerElementHarness::start): (WebCore::GStreamerElementHarness::pushStickyEvents): (WebCore::GStreamerElementHarness::pushSegmentEvent): Canonical link: https://commits.webkit.org/267083@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2f1549: [GStreamer] Make additional use of wrapSpanData in...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2f1549d11968bcbcfeabf70cb4ff84c711f9eeda https://github.com/WebKit/WebKit/commit/2f1549d11968bcbcfeabf70cb4ff84c711f9eeda Author: Philippe Normand Date: 2023-08-16 (Wed, 16 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp Log Message: --- [GStreamer] Make additional use of wrapSpanData in VideoDecoder https://bugs.webkit.org/show_bug.cgi?id=260200 Reviewed by Xabier Rodriguez-Calvar. Refactor the decode method to use wrapSpanData. * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::decode): Canonical link: https://commits.webkit.org/266940@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 164aa4: [GStreamer][WebCodecs] Refactor to push samples on...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 164aa4e39b317d71cbd408dcaa124282838b4d2f https://github.com/WebKit/WebKit/commit/164aa4e39b317d71cbd408dcaa124282838b4d2f Author: Philippe Normand Date: 2023-08-16 (Wed, 16 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp Log Message: --- [GStreamer][WebCodecs] Refactor to push samples on the harness https://bugs.webkit.org/show_bug.cgi?id=260037 Reviewed by Xabier Rodriguez-Calvar. This delays the element harness startup until the first decode task is fired. It's also in line with the upcoming audio decoder workflow and potentially more future-proof, specially if we plan to support reverse decoding later on. * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::isConfigured const): (WebCore::GStreamerVideoDecoder::create): (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): (WebCore::GStreamerInternalVideoDecoder::decode): (WebCore::GStreamerInternalVideoDecoder::isStarted const): Deleted. Canonical link: https://commits.webkit.org/266943@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8d3c77: [CMake] Store the custom compile_commands.json fil...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8d3c77d0963679f435fb7f45f9406b51dfb51134 https://github.com/WebKit/WebKit/commit/8d3c77d0963679f435fb7f45f9406b51dfb51134 Author: Philippe Normand Date: 2023-08-26 (Sat, 26 Aug 2023) Changed paths: M Source/cmake/WebKitCommon.cmake M Tools/Scripts/rewrite-compile-commands Log Message: --- [CMake] Store the custom compile_commands.json file in a sub-directory https://bugs.webkit.org/show_bug.cgi?id=260769 Reviewed by Michael Catanzaro. clangd and similar tools should be configured to look for the compile_commands.json file in the DeveloperTools directory, so for GTK for instance, WebKitBuild/GTK/Release/DeveloperTools/. * Source/cmake/WebKitCommon.cmake: * Tools/Scripts/rewrite-compile-commands: Canonical link: https://commits.webkit.org/267324@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] efe1e1: [Linux] ASan build fails
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: efe1e12e2fa7ff0010fc32e060283ad192ee7de6 https://github.com/WebKit/WebKit/commit/efe1e12e2fa7ff0010fc32e060283ad192ee7de6 Author: Philippe Normand Date: 2023-08-26 (Sat, 26 Aug 2023) Changed paths: M Source/WTF/wtf/Vector.h Log Message: --- [Linux] ASan build fails https://bugs.webkit.org/show_bug.cgi?id=260770 Reviewed by Michael Catanzaro. * Source/WTF/wtf/Vector.h: Include asan header, required for __sanitizer_annotate_contiguous_container(). Canonical link: https://commits.webkit.org/267325@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 37bc74: [GStreamer] Prevent a crash when fetching data on ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 37bc7427407685a224044ddc3df4b81c41d6fd38 https://github.com/WebKit/WebKit/commit/37bc7427407685a224044ddc3df4b81c41d6fd38 Author: Philippe Normand Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: A LayoutTests/http/wpt/mediarecorder/MediaRecorder-start-stop-crash.html M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.cpp M Source/WebCore/platform/mediarecorder/MediaRecorderPrivateGStreamer.h Log Message: --- [GStreamer] Prevent a crash when fetching data on stopped MediaRecorder https://bugs.webkit.org/show_bug.cgi?id=260649 rdar://problem/114370120 Reviewed by Xabier Rodriguez-Calvar. The backend (GStreamer transcoder) is now clearly separated from the MediaRecorderPrivate, so that fetchData() can create a weak pointer to be used from the main thread. If the backend was destroyed in-flight no unsafe memory access is performed. Test: http/wpt/mediarecorder/MediaRecorder-start-stop-crash.html Canonical link: https://commits.webkit.org/267345@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 18c753: [GStreamer][WebCodecs] codec string validation sup...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 18c7539a953d965b154f08076a4e51751e77169a https://github.com/WebKit/WebKit/commit/18c7539a953d965b154f08076a4e51751e77169a Author: Philippe Normand Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp Log Message: --- [GStreamer][WebCodecs] codec string validation support for VideoDecoder https://bugs.webkit.org/show_bug.cgi?id=260712 Reviewed by Xabier Rodriguez-Calvar. The GStreamer VideoDecoder now performs some validation operations on the supplied codec string, similarily to what was done for Apple ports in 267272@main. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::~GStreamerInternalVideoDecoder): (WebCore::validateCodecString): (WebCore::GStreamerVideoDecoder::create): (WebCore::GStreamerVideoDecoder::~GStreamerVideoDecoder): * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp: (WebCore::GStreamerCodecUtilities::parseHEVCProfile): Canonical link: https://commits.webkit.org/267342@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5ee3f9: [GStreamer] Two new failures media/media-can-play-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5ee3f9a7c6a95baa6bfe91534059fd92e6002218 https://github.com/WebKit/WebKit/commit/5ee3f9a7c6a95baa6bfe91534059fd92e6002218 Author: Philippe Normand Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp Log Message: --- [GStreamer] Two new failures media/media-can-play-case-sensitive-flac.html, media/media-can-play-type-case-sensitive.html https://bugs.webkit.org/show_bug.cgi?id=260625 Reviewed by Xabier Rodriguez-Calvar. Codec string matching is now case-sensitive in the registry scanner. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::initializeDecoders): (WebCore::GStreamerRegistryScanner::isContentTypeSupported const): Canonical link: https://commits.webkit.org/267343@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0b71df: [GStreamer] VideoFrame metadata not explicitely up...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0b71df88d47241c1024084a8f4edb0410d847520 https://github.com/WebKit/WebKit/commit/0b71df88d47241c1024084a8f4edb0410d847520 Author: Philippe Normand Date: 2023-08-28 (Mon, 28 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp Log Message: --- [GStreamer] VideoFrame metadata not explicitely updated in underlying sample https://bugs.webkit.org/show_bug.cgi?id=260713 Reviewed by Xabier Rodriguez-Calvar. Update the sample in case its buffer received additional metadata. * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::VideoFrameGStreamer::VideoFrameGStreamer): Canonical link: https://commits.webkit.org/267347@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 184286: [WebCodecs] AudioDecoder and AudioData support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1842861b125b97a693e2f4aa6bcd70e02b0b5bce https://github.com/WebKit/WebKit/commit/1842861b125b97a693e2f4aa6bcd70e02b0b5bce Author: Philippe Normand Date: 2023-08-25 (Fri, 25 Aug 2023) Changed paths: M LayoutTests/TestExpectations M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data-serialization.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-data.crossOriginIsolated.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.crossOriginIsolated.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.crossOriginIsolated.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-decoder.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audio-encoder.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_adts_aac-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_mp3-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_mp4_aac-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_opus-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_alaw-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any.worker_pcm_mulaw-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_adts_aac-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_mp3-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_mp4_aac-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_opus-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_alaw-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/audioDecoder-codec-specific.https.any_pcm_mulaw-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/chunk-serialization.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/encoded-audio-chunk.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/encoded-audio-chunk.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/encoded-audio-chunk.crossOriginIsolated.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/encoded-audio-chunk.crossOriginIsolated.https.any.worker-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any-expected.txt M LayoutTests/imported/w3c/web-platform-tests/webcodecs/idlharness.https.any.worker-expected.txt M LayoutTests/platform/glib/TestExpectations A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/audio-data.any-expected.txt A LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/audio-data.any.worker-expected.txt M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/CMakeLists.txt M Source/WebCore/DerivedSources.make M Source/WebCore/Headers.cmake A Source/WebCore/Modules/webcodecs/AudioSampleFormat.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioData.cpp A Source/WebCore/Modules/webcodecs/WebCodecsAudioData.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioData.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioDataAlgorithms.cpp A Source/WebCore/Modules/webcodecs/WebCodecsAudioDataAlgorithms.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioDataOutputCallback.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioDataOutputCallback.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.cpp A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoder.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderConfig.idl A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderSupport.h A Source/WebCore/Modules/webcodecs/WebCodecsAudioDecoderSupport.idl A Source/WebCore/Modules/webcodecs
[webkit-changes] [WebKit/WebKit] 904e4f: [GStreamer][WebCodecs] HEVC encoding and decoding ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 904e4fcfa2e26ad5bfc0d4f9f7e7dfc4dde943cc https://github.com/WebKit/WebKit/commit/904e4fcfa2e26ad5bfc0d4f9f7e7dfc4dde943cc Author: Philippe Normand Date: 2023-08-15 (Tue, 15 Aug 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp M Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.h M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp M Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp Log Message: --- [GStreamer][WebCodecs] HEVC encoding and decoding support https://bugs.webkit.org/show_bug.cgi?id=260124 Reviewed by Xabier Rodriguez-Calvar. The corresponding layout tests are now passing, excepted the h265_annexb variants, that would require further investigation. Support for H265 codec string to GStreamer H265 profile was also added, with unit-tests. * LayoutTests/platform/glib/TestExpectations: * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::configureVideoDecoderForHarnessing): (WebCore::wrapSpanData): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::initializeEncoders): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: (WebCore::GStreamerInternalVideoEncoder::initialize): * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp: (WebCore::GStreamerCodecUtilities::parseHEVCProfile): * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.h: * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: (webkit_video_encoder_class_init): * Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/266904@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 233933: [GStreamer][WebRTC] Ensure audio outgoing source i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 23393311b1ed08a3a0d265cb5bfec76b64217b9e https://github.com/WebKit/WebKit/commit/23393311b1ed08a3a0d265cb5bfec76b64217b9e Author: Philippe Normand Date: 2023-08-15 (Tue, 15 Aug 2023) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.h Log Message: --- [GStreamer][WebRTC] Ensure audio outgoing source is stereo when negotiated through SDP https://bugs.webkit.org/show_bug.cgi?id=259974 Reviewed by Xabier Rodriguez-Calvar. The audio source might not be stereo in all cases, for instance the fallback source is mono by default. So we need to make sure the audio stream is converted to stereo when needed. * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp: (WebCore::RealtimeOutgoingAudioSourceGStreamer::RealtimeOutgoingAudioSourceGStreamer): (WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.h: Canonical link: https://commits.webkit.org/266901@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 07db15: [GStreamer][WebCodecs] Reduce AudioConverter alloc...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 07db15006984734250aa29f30c49170d3ec25a25 https://github.com/WebKit/WebKit/commit/07db15006984734250aa29f30c49170d3ec25a25 Author: Philippe Normand Date: 2023-08-29 (Tue, 29 Aug 2023) Changed paths: M Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp Log Message: --- [GStreamer][WebCodecs] Reduce AudioConverter allocations https://bugs.webkit.org/show_bug.cgi?id=260800 Reviewed by Xabier Rodriguez-Calvar. It's not un-common to convert a stream of AudioData to another format, for instance when the destination involves WebAudio, so allocate only one converter per source-destination format combination. * Source/WebCore/platform/audio/gstreamer/PlatformRawAudioDataGStreamer.cpp: (WebCore::getAudioConvertedForFormat): (WebCore::PlatformRawAudioData::copyTo): Canonical link: https://commits.webkit.org/267396@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] dfa421: [GStreamer][WebCodecs] Circular references in vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dfa421425d517ac2b7822c9b758cacb9d52743b2 https://github.com/WebKit/WebKit/commit/dfa421425d517ac2b7822c9b758cacb9d52743b2 Author: Philippe Normand Date: 2023-08-22 (Tue, 22 Aug 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h M Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp M Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp Log Message: --- [GStreamer][WebCodecs] Circular references in video decoder leading to memory leaks https://bugs.webkit.org/show_bug.cgi?id=260423 Reviewed by Xabier Rodriguez-Calvar. Circular references between the GStreamerInternalVideoDecoder and its harness through captured references in lambdas was preventing proper cleanup of the harness when closing the decoder. Using WeakPtrs instead of strong Refs in captured variables fixes the issue. Also, driving-by, fixing the ImageGStreamer API to fit with our style guidelines and making sure the sample is cleared *after* the associated video frame is un-mapped. * Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h: (WebCore::ImageGStreamer::createImage): * Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp: (WebCore::ImageGStreamer::~ImageGStreamer): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: (WebCore::GStreamerInternalVideoDecoder::harnessedElement const): (WebCore::GStreamerVideoDecoder::create): (WebCore::GStreamerVideoDecoder::~GStreamerVideoDecoder): (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): (WebCore::GStreamerInternalVideoDecoder::decode): Canonical link: https://commits.webkit.org/267132@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 60f194: [Buildstream SDK] Update to FDO 23.08 release
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 60f1940c69fed978c05c98fd4a2b522bd8c59f3a https://github.com/WebKit/WebKit/commit/60f1940c69fed978c05c98fd4a2b522bd8c59f3a Author: Philippe Normand Date: 2023-11-09 (Thu, 09 Nov 2023) Changed paths: M .gitignore M Tools/Scripts/bst-wrapper M Tools/Scripts/webkit-flatpak-sdk M Tools/buildstream/Makefile R Tools/buildstream/Pipfile R Tools/buildstream/Pipfile.lock M Tools/buildstream/README.md M Tools/buildstream/elements/flatpak-platform-extensions-extra.bst M Tools/buildstream/elements/flatpak-platform-extensions.bst M Tools/buildstream/elements/flatpak-runtimes.bst M Tools/buildstream/elements/flatpak/platform-image.bst M Tools/buildstream/elements/flatpak/platform.bst M Tools/buildstream/elements/flatpak/sdk.bst M Tools/buildstream/elements/freedesktop-sdk.bst A Tools/buildstream/elements/plugins/bst-plugins-experimental.bst A Tools/buildstream/elements/plugins/buildstream-plugins.bst M Tools/buildstream/elements/qt5/qtbase.bst M Tools/buildstream/elements/qt5/qtdeclarative.bst M Tools/buildstream/elements/qt5/qtquickcontrols.bst M Tools/buildstream/elements/qt5/qtquickcontrols2.bst M Tools/buildstream/elements/qt5/qtwayland.bst M Tools/buildstream/elements/qt5/qtx11extras.bst R Tools/buildstream/elements/sdk-build-depends/rapidjson.bst M Tools/buildstream/elements/sdk-build-depends/scons.bst M Tools/buildstream/elements/sdk-platform.bst M Tools/buildstream/elements/sdk.bst M Tools/buildstream/elements/sdk/adwaita-icon-theme.bst M Tools/buildstream/elements/sdk/apitrace.bst M Tools/buildstream/elements/sdk/breakpad.bst M Tools/buildstream/elements/sdk/capnp.bst M Tools/buildstream/elements/sdk/cargo-c.bst R Tools/buildstream/elements/sdk/ccls.bst M Tools/buildstream/elements/sdk/clangd.bst M Tools/buildstream/elements/sdk/eigen.bst M Tools/buildstream/elements/sdk/flite.bst M Tools/buildstream/elements/sdk/gi-docgen.bst M Tools/buildstream/elements/sdk/gst-plugin-closedcaption.bst M Tools/buildstream/elements/sdk/gst-plugin-dav1d.bst M Tools/buildstream/elements/sdk/gst-plugin-rtp.bst M Tools/buildstream/elements/sdk/gtk+-3.bst M Tools/buildstream/elements/sdk/gtk.bst M Tools/buildstream/elements/sdk/hwloc.bst M Tools/buildstream/elements/sdk/icecc.bst M Tools/buildstream/elements/sdk/libavif.bst M Tools/buildstream/elements/sdk/libbacktrace.bst M Tools/buildstream/elements/sdk/libevent.bst M Tools/buildstream/elements/sdk/libjxl.bst M Tools/buildstream/elements/sdk/libmanette.bst M Tools/buildstream/elements/sdk/libusrsctp.bst M Tools/buildstream/elements/sdk/libwpe.bst M Tools/buildstream/elements/sdk/mold.bst M Tools/buildstream/elements/sdk/monado.bst M Tools/buildstream/elements/sdk/openxr.bst M Tools/buildstream/elements/sdk/patchelf.bst M Tools/buildstream/elements/sdk/psmisc.bst M Tools/buildstream/elements/sdk/python3-smartypants.bst M Tools/buildstream/elements/sdk/rr.bst M Tools/buildstream/elements/sdk/sccache.bst M Tools/buildstream/elements/sdk/sparkle-cdm.bst M Tools/buildstream/elements/sdk/svt-av1.bst M Tools/buildstream/elements/sdk/tbb.bst M Tools/buildstream/elements/sdk/wpebackend-fdo.bst M Tools/buildstream/elements/sdk/xdg-dbus-proxy.bst M Tools/buildstream/elements/sdk/xorg-server.bst M Tools/buildstream/elements/test-infra.bst M Tools/buildstream/elements/test-infra/apr.bst M Tools/buildstream/elements/test-infra/httpd.bst A Tools/buildstream/elements/test-infra/perl-digest-crc-pm.bst M Tools/buildstream/elements/test-infra/webkitgtk-test-dicts.bst R Tools/buildstream/patches/fdo-0001-gst-plugins-bad-Add-support-Kate.patch R Tools/buildstream/patches/fdo-0001-mesa-Bump-to-23.1.5.patch R Tools/buildstream/patches/fdo-0001-pipewire-base-Disable-AEC-module.patch M Tools/buildstream/patches/fdo-0002-ffmpeg-Support-more-codecs.patch R Tools/buildstream/patches/fdo-0003-gst-plugins-bad-Support-for-updated-webrtc-audio-pro.patch M Tools/buildstream/patches/fdo-0004-gst-plugins-ugly-Enable-x264-encoder.patch M Tools/buildstream/patches/fdo-0005-GStreamer-Bump-to-1.22.6.patch M Tools/buildstream/patches/fdo-0006-gst-plugins-bad-Enable-soundtouch.patch R Tools/buildstream/patches/fdo-0007-components-Bump-GLib-to-version-2.76.patch R Tools/buildstream/patches/fdo-0008-components-Bump-g-i-to-version-1.76.patch M Tools/buildstream/patches/fdo-0009-gst-plugins-bad-Enable-x265-encoder.patch A Tools/buildstream/patches/flite-fix-voice-list-build.patch R Tools/buildstream/patches/rapidjson-0001-Fix-build-warnings-emitted-by-GCC-10-on-Aarch64.patch R Tools/buildstream/patches/tbb-Retry-if-pthread_create-fails-with-EAGAIN.patch M Tools/buildstream/project.conf Log
[webkit-changes] [WebKit/WebKit] 90eec0: [GStreamer] Critical warnings in appsink workaroun...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 90eec06ee98c8d32c1213aa640f5194dcb064542 https://github.com/WebKit/WebKit/commit/90eec06ee98c8d32c1213aa640f5194dcb064542 Author: Philippe Normand Date: 2022-10-17 (Mon, 17 Oct 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/AppSinkWorkaround.cpp Log Message: --- [GStreamer] Critical warnings in appsink workaround thing https://bugs.webkit.org/show_bug.cgi?id=246630 Reviewed by Xabier Rodriguez-Calvar. * Source/WebCore/platform/graphics/gstreamer/AppSinkWorkaround.cpp: (WebCore::registerAppsinkWorkaroundIfNeeded): Register debug category before logging anything from checkNeedsAppsinkWorkaround(). Canonical link: https://commits.webkit.org/255632@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e6b401: [GStreamer][WebRTC] Events forwarding between end-...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e6b4012424bfe6b5d91858df2959e7535285b452 https://github.com/WebKit/WebKit/commit/e6b4012424bfe6b5d91858df2959e7535285b452 Author: Philippe Normand Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M Source/WebCore/platform/mediastream/RealtimeMediaSource.h M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.h Log Message: --- [GStreamer][WebRTC] Events forwarding between end-point and its consumers https://bugs.webkit.org/show_bug.cgi?id=247126 Reviewed by Xabier Rodriguez-Calvar. We need to relay upstream events coming from depayloaders to webrtcbin and we also need to relay downstream events from webrtcbin to the incoming media sources. This should help improving RTP retransmission, for instance. RealtimeIncomingSourceGStreamer now directly inherits from RealtimeMediaSource in order to avoid duplication of the downstream event handling in each sub-class. * Source/WebCore/platform/mediastream/RealtimeMediaSource.h: * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp: (WebCore::RealtimeIncomingAudioSourceGStreamer::RealtimeIncomingAudioSourceGStreamer): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.h: * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp: (WebCore::RealtimeIncomingSourceGStreamer::RealtimeIncomingSourceGStreamer): (WebCore::RealtimeIncomingSourceGStreamer::registerClient): (WebCore::RealtimeIncomingSourceGStreamer::handleUpstreamEvent): (WebCore::RealtimeIncomingSourceGStreamer::handleDownstreamEvent): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.h: Canonical link: https://commits.webkit.org/256149@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a27e73: [OpenSSL] Simplify OpenSSLCryptoUniquePtr
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a27e73ffa27ddbf4e61d34eb3a532259c0381bed https://github.com/WebKit/WebKit/commit/a27e73ffa27ddbf4e61d34eb3a532259c0381bed Author: Philippe Normand Date: 2022-09-17 (Sat, 17 Sep 2022) Changed paths: M Source/WebCore/crypto/openssl/OpenSSLCryptoUniquePtr.h Log Message: --- [OpenSSL] Simplify OpenSSLCryptoUniquePtr https://bugs.webkit.org/show_bug.cgi?id=245027 Reviewed by Michael Catanzaro. Use a macro to generate unique_ptr deleters and aliases. Also this patch adds smart pointers for OpenSSL 3 `OSSL_PARAM_BLD` and `OSSL_PARAM` types, those will be used later on by the GstWebRTC backend. The OpenSSL WebCrypto port to OpenSSL 3 shall be handled in https://bugs.webkit.org/show_bug.cgi?id=245146. * Source/WebCore/crypto/openssl/OpenSSLCryptoUniquePtr.h: (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. (WebCore::OpenSSLCryptoPtrDeleter::operator() const): Deleted. Canonical link: https://commits.webkit.org/254587@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aa47ef: [GTK] ASSERTS in FontCache
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aa47ef76a7eb20fd20993871370d04fd9ef3ff8d https://github.com/WebKit/WebKit/commit/aa47ef76a7eb20fd20993871370d04fd9ef3ff8d Author: Philippe Normand Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK] ASSERTS in FontCache https://bugs.webkit.org/show_bug.cgi?id=245334 Unreviewed, gardening. Flag OffscreenCanvas text tests as crashing in debug builds. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/254606@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 961b5f: [Linux] Gardening, skip ios/watchos "fast" tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 961b5feec72b72cb2a054bbcf23f2e0e3794fc18 https://github.com/WebKit/WebKit/commit/961b5feec72b72cb2a054bbcf23f2e0e3794fc18 Author: Philippe Normand Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/wpe/TestExpectations Log Message: --- [Linux] Gardening, skip ios/watchos "fast" tests https://bugs.webkit.org/show_bug.cgi?id=245339 Unreviewed. Skip iOS and watchOS tests. Too many of those crashing, specially on WPE Debug bot, leading to early bailout from the tests and filling the disks with crash dumps. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/wpe/TestExpectations: Canonical link: https://commits.webkit.org/254614@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] fb11aa: [ATSPI] gardening for bug 245214
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: fb11aa7460999a198b8858af98498668a00cc36f https://github.com/WebKit/WebKit/commit/fb11aa7460999a198b8858af98498668a00cc36f Author: Philippe Normand Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations Log Message: --- [ATSPI] gardening for bug 245214 https://bugs.webkit.org/show_bug.cgi?id=245338 Unreviewed, ATSPI gardening. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/254613@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 54b769: [GTK] ASSERTS in FontCache
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 54b769e4acf3d54ea9fcd35e2521b92652937520 https://github.com/WebKit/WebKit/commit/54b769e4acf3d54ea9fcd35e2521b92652937520 Author: Philippe Normand Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GTK] ASSERTS in FontCache https://bugs.webkit.org/show_bug.cgi?id=245334 Unreviewed gardening * LayoutTests/platform/glib/TestExpectations: imported/w3c/web-platform-tests/html/canvas/offscreen/text/ is actually flaky crash/pass in Debug builds. Canonical link: https://commits.webkit.org/254612@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] b8caa5: REGRESSION(254574@main): Triggers ASSERTS when run...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b8caa5b21cd31bbc7cb929c59e387f9d3fb59219 https://github.com/WebKit/WebKit/commit/b8caa5b21cd31bbc7cb929c59e387f9d3fb59219 Author: Philippe Normand Date: 2022-09-18 (Sun, 18 Sep 2022) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp Log Message: --- REGRESSION(254574@main): Triggers ASSERTS when running wpt tests https://bugs.webkit.org/show_bug.cgi?id=245333 Reviewed by Michael Catanzaro. Since 254574@main the WebPageProxy TextIndicator methods are actually called on all ports, including the ones not supporting this feature. Using ASSERT_NOT_REACHED() for unimplemented features is un-common as well, usually notImplemented() is used instead, so do so for these code paths. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setTextIndicator): (WebKit::WebPageProxy::clearTextIndicator): (WebKit::WebPageProxy::setTextIndicatorAnimationProgress): Canonical link: https://commits.webkit.org/254610@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 0154fe: [GStreamer] Gardening.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 0154fee644aebfbe7aee782cd1681567d2d27014 https://github.com/WebKit/WebKit/commit/0154fee644aebfbe7aee782cd1681567d2d27014 Author: Philippe Normand Date: 2022-09-25 (Sun, 25 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/gtk/TestExpectations Log Message: --- [GStreamer] Gardening. https://bugs.webkit.org/show_bug.cgi?id=245638 Unreviewed. Move some GStreamer-specific expectations to the glib TestExpectations so that WPE bots are aware too. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/254839@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 245482: [GStreamer] Gardening.
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 245482b4590f33fa5d2a8198ddd5b40f305e1cc6 https://github.com/WebKit/WebKit/commit/245482b4590f33fa5d2a8198ddd5b40f305e1cc6 Author: Philippe Normand Date: 2022-09-25 (Sun, 25 Sep 2022) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer] Gardening. https://bugs.webkit.org/show_bug.cgi?id=245642 Unreviewed. - media/video-seek-to-current-time.html is passing. We do support H.264 in the test harness. - media/media-hevc-video-as-img.html runs (we do support H.265 in the test harness) but fails, flagged as such. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/254841@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4e2d40: [WPE][GTK] Enable MEDIA_STREAM and MEDIA_RECORDER
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4e2d40a6bf7aad63f9273c67465f70d317b6d3ad https://github.com/WebKit/WebKit/commit/4e2d40a6bf7aad63f9273c67465f70d317b6d3ad Author: Philippe Normand Date: 2022-09-25 (Sun, 25 Sep 2022) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [WPE][GTK] Enable MEDIA_STREAM and MEDIA_RECORDER https://bugs.webkit.org/show_bug.cgi?id=245636 Reviewed by Michael Catanzaro. MediaStream support is good nowadays in GLib ports, allowing capture devices access and rendering in media elements. The recorder backend is also in good shape, we would still have time to mature it further during the 2.40 cycle. WebRTC remains flagged as experimental feature for now. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/254838@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] d628ab: [GStreamer][MSE] Build warning in AppendPipeline
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d628ab1f73d4115209cf29cf0f41b524e31b01ba https://github.com/WebKit/WebKit/commit/d628ab1f73d4115209cf29cf0f41b524e31b01ba Author: Philippe Normand Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h Log Message: --- [GStreamer][MSE] Build warning in AppendPipeline https://bugs.webkit.org/show_bug.cgi?id=245637 Reviewed by Xabier Rodriguez-Calvar. Follow-up after 254788@main fixing build warnings. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::recycleTrackForPad): (WebCore::AppendPipeline::Track::emplaceOptionalParserForFormat): (WebCore::AppendPipeline::Track::initializeElements): * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h: Canonical link: https://commits.webkit.org/254855@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 792d63: [GLib] Modernize Tools/glib/apply-build-revision-t...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 792d6325aedb3d164f2f4a2d139523b0f7ffab02 https://github.com/WebKit/WebKit/commit/792d6325aedb3d164f2f4a2d139523b0f7ffab02 Author: Philippe Normand Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Tools/glib/apply-build-revision-to-files.py Log Message: --- [GLib] Modernize Tools/glib/apply-build-revision-to-files.py https://bugs.webkit.org/show_bug.cgi?id=242191 Reviewed by Michael Catanzaro. Switch back to git log parsing, as before 252012@main. Using webkitpy was not a great idea for two reasons: - autoinstall kicking off during offline builds and failing - SSL issues in buildroot setups. * Tools/glib/apply-build-revision-to-files.py: (get_revision_from_most_recent_git_commit): (get_build_revision): (main): Canonical link: https://commits.webkit.org/254851@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 156274: Merge 254848@main - Hulu.com content is stretched ...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 15627421d9c2dbde893679099050316fa4603796 https://github.com/WebKit/WebKit/commit/15627421d9c2dbde893679099050316fa4603796 Author: Jer Noble Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/page/Quirks.cpp M Source/WebCore/page/Quirks.h Log Message: --- Merge 254848@main - Hulu.com content is stretched when moving to next episode https://bugs.webkit.org/show_bug.cgi?id=245641 Reviewed by Eric Carlson. As a prelude: at some point, WebKit fixed a bug where the `object-fit` CSS property was not honored if set before media began loading in a HTMLVideoElement. Hulu.com sets it's video element's `object-fit:` style to `fill`. When Hulu.com navigates to the next episode in a playlist, it resets the 's `width:` and `height:` style to 100%, causing the video to stretch visibly. Previous to the mentioned fix, this bug would "hide" this behavior, by causing the renderer to ignore `fill` and default to `contain`. Add a quirk for Hulu.com that reverts to the previous (broken) behavior. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::updateMediaPlayer): * Source/WebCore/page/Quirks.cpp: (WebCore::Quirks::needsVideoShouldMaintainAspectRatioQuirk const): * Source/WebCore/page/Quirks.h: Canonical link: https://commits.webkit.org/254848@main (cherry picked from commit 249fdd9c0f8bf064190f69a2791917b762922bee) Commit: e362e6b6f47fb0f8682e81bf696c11c6a04406bf https://github.com/WebKit/WebKit/commit/e362e6b6f47fb0f8682e81bf696c11c6a04406bf Author: Philippe Normand Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Tools/glib/apply-build-revision-to-files.py Log Message: --- Merge 254851@main - [GLib] Modernize Tools/glib/apply-build-revision-to-files.py https://bugs.webkit.org/show_bug.cgi?id=242191 Reviewed by Michael Catanzaro. Switch back to git log parsing, as before 252012@main. Using webkitpy was not a great idea for two reasons: - autoinstall kicking off during offline builds and failing - SSL issues in buildroot setups. * Tools/glib/apply-build-revision-to-files.py: (get_revision_from_most_recent_git_commit): (get_build_revision): (main): Canonical link: https://commits.webkit.org/254851@main (cherry picked from commit 792d6325aedb3d164f2f4a2d139523b0f7ffab02) Compare: https://github.com/WebKit/WebKit/compare/9980be90d8de...e362e6b6f47f ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6016db: Merge 254855@main - [GStreamer][MSE] Build warning...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 6016db27f0c76f0fec5156cb0b4e5211a120aa0d https://github.com/WebKit/WebKit/commit/6016db27f0c76f0fec5156cb0b4e5211a120aa0d Author: Philippe Normand Date: 2022-09-26 (Mon, 26 Sep 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h Log Message: --- Merge 254855@main - [GStreamer][MSE] Build warning in AppendPipeline https://bugs.webkit.org/show_bug.cgi?id=245637 Reviewed by Xabier Rodriguez-Calvar. Follow-up after 254788@main fixing build warnings. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::recycleTrackForPad): (WebCore::AppendPipeline::Track::emplaceOptionalParserForFormat): (WebCore::AppendPipeline::Track::initializeElements): * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.h: Canonical link: https://commits.webkit.org/254855@main (cherry picked from commit d628ab1f73d4115209cf29cf0f41b524e31b01ba) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 55ef87: Merge 254830@main - [CMake] Various dependencies o...
Branch: refs/heads/webkitglib/2.38 Home: https://github.com/WebKit/WebKit Commit: 55ef877738d0a402f6223b50e9c8049d6046a36a https://github.com/WebKit/WebKit/commit/55ef877738d0a402f6223b50e9c8049d6046a36a Author: Philippe Normand Date: 2022-09-25 (Sun, 25 Sep 2022) Changed paths: M Source/WebCore/CMakeLists.txt Log Message: --- Merge 254830@main - [CMake] Various dependencies on derived sources are incorrect https://bugs.webkit.org/show_bug.cgi?id=245624 Reviewed by Michael Catanzaro. * Source/WebCore/CMakeLists.txt: CSSParser.cpp was moved to parser/, StyleResolver.cpp was moved to /style/, UserAgentStyle.cpp includes UserAgentStyleSheets.h, so should have dependency on it, PlugInsResources.h is included only from Document.cpp, so reflect this as dependency too. Finally also fix the dependency on MathMLNames in moved HTMLTreeBuilder.cpp. Canonical link: https://commits.webkit.org/254830@main (cherry picked from commit e02c5994bc762f8006e37ee0e38035e4407db2cd) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e02c59: [CMake] Various dependencies on derived sources ar...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e02c5994bc762f8006e37ee0e38035e4407db2cd https://github.com/WebKit/WebKit/commit/e02c5994bc762f8006e37ee0e38035e4407db2cd Author: Philippe Normand Date: 2022-09-24 (Sat, 24 Sep 2022) Changed paths: M Source/WebCore/CMakeLists.txt Log Message: --- [CMake] Various dependencies on derived sources are incorrect https://bugs.webkit.org/show_bug.cgi?id=245624 Reviewed by Michael Catanzaro. * Source/WebCore/CMakeLists.txt: CSSParser.cpp was moved to parser/, StyleResolver.cpp was moved to /style/, UserAgentStyle.cpp includes UserAgentStyleSheets.h, so should have dependency on it, PlugInsResources.h is included only from Document.cpp, so reflect this as dependency too. Finally also fix the dependency on MathMLNames in moved HTMLTreeBuilder.cpp. Canonical link: https://commits.webkit.org/254830@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 9ae5d2: [Flatpak SDK] Remove webkitpy auto-installed deps ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9ae5d27b14fd397d2520bf4a0fb679f8ee188d5c https://github.com/WebKit/WebKit/commit/9ae5d27b14fd397d2520bf4a0fb679f8ee188d5c Author: Philippe Normand Date: 2022-09-23 (Fri, 23 Sep 2022) Changed paths: M Tools/flatpak/flatpakutils.py Log Message: --- [Flatpak SDK] Remove webkitpy auto-installed deps when upgrading to new SDK https://bugs.webkit.org/show_bug.cgi?id=245342 Reviewed by Adrian Perez de Castro. For instance the upgrade from 21.08 to 22.08 without re-installing those dependencies triggers an ImportError when loading cffi. * Tools/flatpak/flatpakutils.py: (WebkitFlatpak.main): Canonical link: https://commits.webkit.org/254789@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 529710: [GStreamer][WebRTC] Set MTU to 1200 on RTP payloaders
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5297100c5cb8bf57b174f32728d0916470339ce9 https://github.com/WebKit/WebKit/commit/5297100c5cb8bf57b174f32728d0916470339ce9 Author: Philippe Normand Date: 2022-10-06 (Thu, 06 Oct 2022) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Set MTU to 1200 on RTP payloaders https://bugs.webkit.org/show_bug.cgi?id=246012 Reviewed by Xabier Rodriguez-Calvar. Align RTP MTU with libwebrtc implementation, also helping to reduce packet fragmentation. * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp: (WebCore::RealtimeOutgoingAudioSourceGStreamer::setPayloadType): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType): Canonical link: https://commits.webkit.org/255211@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c736ca: [WTF] Unsafe String concatenation in optimized cla...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c736ca45a340bc8340871e961dce909ddbb8ecf7 https://github.com/WebKit/WebKit/commit/c736ca45a340bc8340871e961dce909ddbb8ecf7 Author: Philippe Normand Date: 2022-10-09 (Sun, 09 Oct 2022) Changed paths: M Source/WTF/wtf/text/StringView.h Log Message: --- [WTF] Unsafe String concatenation in optimized clang builds https://bugs.webkit.org/show_bug.cgi?id=245640 Reviewed by Darin Adler. Ensure that StringImpl::copyCharacters() is not called with a null string source pointer. The check done in StringView::getCharactersWithUpconvert() is on allocated memory, so should not have any negative impact on performance. * Source/WTF/wtf/text/StringView.h: (WTF::StringView::getCharactersWithUpconvert const): Canonical link: https://commits.webkit.org/255330@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 6a9a57: [Flatpak SDK] Update and additional component
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 6a9a5757f1400ec595e6f28559742883c44fd0c0 https://github.com/WebKit/WebKit/commit/6a9a5757f1400ec595e6f28559742883c44fd0c0 Author: Philippe Normand Date: 2022-10-10 (Mon, 10 Oct 2022) Changed paths: M Tools/buildstream/elements/freedesktop-sdk.bst M Tools/buildstream/elements/sdk-platform.bst M Tools/buildstream/elements/sdk/rr.bst Log Message: --- [Flatpak SDK] Update and additional component https://bugs.webkit.org/show_bug.cgi?id=246270 Reviewed by Adrian Perez de Castro. * Tools/buildstream/elements/freedesktop-sdk.bst: Update junction to latest release. * Tools/buildstream/elements/sdk-platform.bst: Add python3-tomli, required for gst-plugins-rs build. * Tools/buildstream/elements/sdk/rr.bst: Bump to latest development version. Canonical link: https://commits.webkit.org/255336@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 488127: [Flatpak SDK] Runtime is missing Rust support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 488127417fd30f62b13ef32ab4b14849172d66bc https://github.com/WebKit/WebKit/commit/488127417fd30f62b13ef32ab4b14849172d66bc Author: Philippe Normand Date: 2022-10-10 (Mon, 10 Oct 2022) Changed paths: M Tools/flatpak/flatpakutils.py Log Message: --- [Flatpak SDK] Runtime is missing Rust support https://bugs.webkit.org/show_bug.cgi?id=246269 Reviewed by Adrian Perez de Castro. Rust support is no longer shipped in the FDO platform runtime, but separately with a SDK extension. Adapt our tooling accordingly. * Tools/flatpak/flatpakutils.py: (WebkitFlatpak.run_in_sandbox): (WebkitFlatpak._get_dependency_packages): Canonical link: https://commits.webkit.org/255335@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 5adbc7: [GStreamer][WebRTC] Media rendering improvements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5adbc713768c2e828b5995ef72fef9d21b10f6fb https://github.com/WebKit/WebKit/commit/5adbc713768c2e828b5995ef72fef9d21b10f6fb Author: Philippe Normand Date: 2022-11-02 (Wed, 02 Nov 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Media rendering improvements https://bugs.webkit.org/show_bug.cgi?id=247319 Reviewed by Xabier Rodriguez-Calvar. The main one is that clock synchronization no longer happens on incoming sources, this is not needed because the renderer pipeline is separate and they can't synchronize on the system clock either. So before this patch the clock sync on the first pipeline was artificially limiting the playback on the renderer pipeline. Additionally the player no longer configures the pipeline for buffering or doing useless duration queries when playing mediastreams. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate): (WebCore::MediaPlayerPrivateGStreamer::setPreload): (WebCore::MediaPlayerPrivateGStreamer::maxMediaTimeSeekable const): (WebCore::MediaPlayerPrivateGStreamer::totalBytes const): (WebCore::MediaPlayerPrivateGStreamer::platformDuration const): (WebCore::MediaPlayerPrivateGStreamer::isMediaStreamPlayer const): (WebCore::MediaPlayerPrivateGStreamer::configureElement): (WebCore::setPlaybackFlags): (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): (WebCore::MediaPlayerPrivateGStreamer::configureDepayloader): (WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingAudioSourceGStreamer.cpp: (WebCore::RealtimeIncomingAudioSourceGStreamer::dispatchSample): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingSourceGStreamer.cpp: (WebCore::RealtimeIncomingSourceGStreamer::registerClient): * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp: (WebCore::RealtimeIncomingVideoSourceGStreamer::dispatchSample): Canonical link: https://commits.webkit.org/256225@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f28f93: [GStreamer] ImageDecoder fixes
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f28f93033a2c0fd176cd5a5ba6929fd5631760e7 https://github.com/WebKit/WebKit/commit/f28f93033a2c0fd176cd5a5ba6929fd5631760e7 Author: Philippe Normand Date: 2022-12-23 (Fri, 23 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h Log Message: --- [GStreamer] ImageDecoder fixes https://bugs.webkit.org/show_bug.cgi?id=249775 Reviewed by Xabier Rodriguez-Calvar. Before tearing down the decoder pipeline it is good practice to disconnect all message bus handlers and also the decodebin pad-added signal handler. * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp: (WebCore::ImageDecoderGStreamer::InnerDecoder::~InnerDecoder): * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h: Canonical link: https://commits.webkit.org/258293@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 22c2ed: [GStreamer] Fix handling of I422 pixel format
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 22c2edbaea095adcb218f94ad718a1886696ee73 https://github.com/WebKit/WebKit/commit/22c2edbaea095adcb218f94ad718a1886696ee73 Author: Philippe Normand Date: 2022-12-20 (Tue, 20 Dec 2022) Changed paths: M Source/WebCore/platform/VideoPixelFormat.cpp Log Message: --- [GStreamer] Fix handling of I422 pixel format https://bugs.webkit.org/show_bug.cgi?id=249468 Reviewed by Xabier Rodriguez-Calvar. The GStreamer I422_ formats are for packed layouts, not planar as mandated by VideoPixelFormat::I422. The right GStreamer planar format for 4:2:2 YUV is Y42B. * Source/WebCore/platform/VideoPixelFormat.cpp: (WebCore::convertVideoFramePixelFormat): Canonical link: https://commits.webkit.org/258131@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 7914a0: [GStreamer] Gardening for a few media/track tests
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 7914a0bfc48a99b0733267b0e9de94684756e87a https://github.com/WebKit/WebKit/commit/7914a0bfc48a99b0733267b0e9de94684756e87a Author: Philippe Normand Date: 2023-01-05 (Thu, 05 Jan 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer] Gardening for a few media/track tests https://bugs.webkit.org/show_bug.cgi?id=250132 Unreviewed, update expectations for some media/track tests expected to start passing whenever we enable playbin3 by default. * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/258498@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e2afda: [Gstreamer][HLS] Unable to play TED videos
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e2afda4dd0ab875371bd993ec2a1a8495a142026 https://github.com/WebKit/WebKit/commit/e2afda4dd0ab875371bd993ec2a1a8495a142026 Author: Philippe Normand Date: 2023-01-10 (Tue, 10 Jan 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp Log Message: --- [Gstreamer][HLS] Unable to play TED videos https://bugs.webkit.org/show_bug.cgi?id=174458 Reviewed by Xabier Rodriguez-Calvar. Disable HLS support by default in GStreamer ports. The underlying GStreamer hlsdemux element is not receiving much maintenance and its replacement, hlsdemux2, cannot be used by WebKit due to sandboxing requirements. Most websites should now fallback to MSE if HLS is not supported by the User-Agent. This was checked on TED and Apple developer websites. HLS support can be re-enabled at runtime by setting the `WEBKIT_GST_ENABLE_HLS_SUPPORT=1` environment variable. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::initializeDecoders): Canonical link: https://commits.webkit.org/258717@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c8a10c: [GLib] Allow GStreamer tracer usage in test harness
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c8a10ceb17997c4cd9cb310fcea2bdedb405c625 https://github.com/WebKit/WebKit/commit/c8a10ceb17997c4cd9cb310fcea2bdedb405c625 Author: Philippe Normand Date: 2023-01-04 (Wed, 04 Jan 2023) Changed paths: M Tools/Scripts/webkitpy/port/glib.py Log Message: --- [GLib] Allow GStreamer tracer usage in test harness https://bugs.webkit.org/show_bug.cgi?id=250075 Reviewed by Žan Doberšek. The `GST_TRACERS` environment variable is useful when debugging media tests. * Tools/Scripts/webkitpy/port/glib.py: (GLibPort.setup_environ_for_server): Canonical link: https://commits.webkit.org/258429@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 12eeaf: REGRESSION(258448@main): [GStreamer] Broke importe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 12eeaf78a6d495d36bae29a8b9c1b8a36953e9ed https://github.com/WebKit/WebKit/commit/12eeaf78a6d495d36bae29a8b9c1b8a36953e9ed Author: Philippe Normand Date: 2023-01-12 (Thu, 12 Jan 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations M LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc-expected.txt M LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc-expected.txt M Source/WebCore/page/Page.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp Log Message: --- REGRESSION(258448@main): [GStreamer] Broke imported/w3c/web-platform-tests/media-capabilities webrtc tests https://bugs.webkit.org/show_bug.cgi?id=250315 Reviewed by Žan Doberšek and Xabier Rodriguez-Calvar. Fix WebRTC settings notifications on Page for ports not enabling LibWebRTC. Also rebaseline media-capabilities tests on GLib ports after recent changes in the GStreamer registry scanner. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-capabilities/decodingInfo.webrtc-expected.txt: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/media-capabilities/encodingInfo.webrtc-expected.txt: * Source/WebCore/page/Page.cpp: (WebCore::Page::settingsDidChange): * Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp: (WebCore::GStreamerWebRTCProvider::initializeVideoEncodingCapabilities): (WebCore::GStreamerWebRTCProvider::initializeVideoDecodingCapabilities): Canonical link: https://commits.webkit.org/258826@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 634131: [GStreamer] Support for bitrate-mode and latency-m...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 634131b13519fc84dee0e194bf1824d7d6ef6034 https://github.com/WebKit/WebKit/commit/634131b13519fc84dee0e194bf1824d7d6ef6034 Author: Philippe Normand Date: 2023-01-12 (Thu, 12 Jan 2023) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp Log Message: --- [GStreamer] Support for bitrate-mode and latency-mode configuration in the video encoder https://bugs.webkit.org/show_bug.cgi?id=250385 Reviewed by Xabier Rodriguez-Calvar. The video encoder can now be configured to encode at constant (default) or variable bitrate. The default latency mode is set to realtime, for WebRTC use-cases, but can be set to "quality", if mandated by WebCodecs video encoder configuration. * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp: (webrtcVideoEncoderBitrateModeGetType): (webrtcVideoEncoderLatencyModeGetType): (Encoders::registerEncoder): (webrtcVideoEncoderGetProperty): (webrtcVideoEncoderSetProperty): (webkit_webrtc_video_encoder_class_init): Canonical link: https://commits.webkit.org/258825@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 819661: [Flatpak SDK] Update to llvm 15
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8196614cb0623111b43d1041469eb3247e5623bb https://github.com/WebKit/WebKit/commit/8196614cb0623111b43d1041469eb3247e5623bb Author: Philippe Normand Date: 2023-01-12 (Thu, 12 Jan 2023) Changed paths: M Tools/flatpak/flatpakutils.py Log Message: --- [Flatpak SDK] Update to llvm 15 https://bugs.webkit.org/show_bug.cgi?id=250507 Reviewed by Adrian Perez de Castro. Switch the SDK runtime from llvm14 to llvm15. clangd is already on version 15, so no BuildStream change required. * Tools/flatpak/flatpakutils.py: (WebkitFlatpak._get_dependency_packages): Canonical link: https://commits.webkit.org/258827@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c38eb: REGRESSION(258663@main) [GStreamer] MIME API test ...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c38ebd63c971d13906e3dbf83e5ddc4e21378b7 https://github.com/WebKit/WebKit/commit/8c38ebd63c971d13906e3dbf83e5ddc4e21378b7 Author: Philippe Normand Date: 2023-01-12 (Thu, 12 Jan 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h M Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- REGRESSION(258663@main) [GStreamer] MIME API test crashes due to GStreamer being initialized in UIProcess https://bugs.webkit.org/show_bug.cgi?id=250480 Reviewed by Xabier Rodriguez-Calvar. The registry no longer directly registers GStreamer elements. Instead it is done from call-sites, such as the WebRTC provider, when needed. Also the scanner is now able to refresh its internal state, this is needed in situations where the singleton might have been created before the registration of additional elements. * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::registerVideoEncoder): (WebCore::registerWebKitGStreamerElements): (WebCore::registerWebKitGStreamerVideoEncoder): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.h: * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::singletonNeedsInitialization): (WebCore::GStreamerRegistryScanner::singleton): (WebCore::GStreamerRegistryScanner::GStreamerRegistryScanner): (WebCore::GStreamerRegistryScanner::refresh): (WebCore::GStreamerRegistryScanner::initializeDecoders): (WebCore::GStreamerRegistryScanner::initializeEncoders): * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h: * Source/WebCore/platform/mediastream/gstreamer/GStreamerWebRTCProvider.cpp: (WebCore::GStreamerWebRTCProvider::initializeVideoEncodingCapabilities): * Tools/TestWebKitAPI/glib/TestExpectations.json: Canonical link: https://commits.webkit.org/258848@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8ffb0f: [GStreamer][WebRTC] Minor end-point improvements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8ffb0f29be5a7b558936675186a86e0463ae5606 https://github.com/WebKit/WebKit/commit/8ffb0f29be5a7b558936675186a86e0463ae5606 Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp Log Message: --- [GStreamer][WebRTC] Minor end-point improvements https://bugs.webkit.org/show_bug.cgi?id=249937 Reviewed by Xabier Rodriguez-Calvar. Avoid some duplicate error reporting and improved instrumentation for pipeline dumping. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::initializePipeline): (WebCore::GStreamerMediaEndpoint::requestAuxiliarySender): Canonical link: https://commits.webkit.org/258656@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 8c81bb: [GStreamer][MediaStream] Minor logging and include...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 8c81bbe3f8e2b05b2da1d69d014609f54bd0cb6d https://github.com/WebKit/WebKit/commit/8c81bbe3f8e2b05b2da1d69d014609f54bd0cb6d Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterGStreamer.cpp Log Message: --- [GStreamer][MediaStream] Minor logging and include fixes https://bugs.webkit.org/show_bug.cgi?id=249939 Reviewed by Xabier Rodriguez-Calvar. * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: The audio sample handling and logging is now more coherent with the video frames handling code path. * Source/WebCore/platform/mediastream/gstreamer/RealtimeMediaSourceCenterGStreamer.cpp: Remove un-needed includes. Canonical link: https://commits.webkit.org/258660@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 2295af: [GStreamer][WebRTC] Video encoder capabilities pro...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 2295aff2e623a55981e391a4e411073a855e9e56 https://github.com/WebKit/WebKit/commit/2295aff2e623a55981e391a4e411073a855e9e56 Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.h Log Message: --- [GStreamer][WebRTC] Video encoder capabilities probing support https://bugs.webkit.org/show_bug.cgi?id=249936 Reviewed by Xabier Rodriguez-Calvar. The registry scanner is now able to check the H.264 encoding capabilies of the host. Also, when more than one platform encoder is capable of encoding to the target format, only the one with the highest rank is selected. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities): * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp: (webrtcVideoEncoderFindForFormat): (webrtcVideoEncoderSupportsFormat): (webrtcVideoEncoderSetFormat): * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.h: Canonical link: https://commits.webkit.org/258663@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 776ff1: [GStreamer] Misc fixes in video encoder/decoder pr...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 776ff1f8adf9ca581583d87985417cf231a3450c https://github.com/WebKit/WebKit/commit/776ff1f8adf9ca581583d87985417cf231a3450c Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp Log Message: --- [GStreamer] Misc fixes in video encoder/decoder probing support https://bugs.webkit.org/show_bug.cgi?id=249995 Reviewed by Xabier Rodriguez-Calvar. When multiple elements were able to support the given format only the first matching element factory was stored in the lookup result. We also now ignore the vpxalphadecodebin wrapper elements when probing vpx decoding capabilities. Those elements are meant to be used by decodebin and won't negotiate input non-alpha caps. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::ElementFactories::hasElementForMediaType const): (WebCore::GStreamerRegistryScanner::initializeDecoders): Canonical link: https://commits.webkit.org/258657@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] f48dd8: [GStreamer] gardening
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: f48dd867a1bb3871dc196682cfdd100cf80c3a24 https://github.com/WebKit/WebKit/commit/f48dd867a1bb3871dc196682cfdd100cf80c3a24 Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M LayoutTests/platform/glib/TestExpectations Log Message: --- [GStreamer] gardening https://bugs.webkit.org/show_bug.cgi?id=250316 Unreviewed, flag two media-capabilities tests as failing * LayoutTests/platform/glib/TestExpectations: Canonical link: https://commits.webkit.org/258661@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4c9aa3: [GStreamer][WebRTC] Improved msid support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4c9aa3f06f5ddf1715f2ef1cc623ecf7cf0e43f7 https://github.com/WebKit/WebKit/commit/4c9aa3f06f5ddf1715f2ef1cc623ecf7cf0e43f7 Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h Log Message: --- [GStreamer][WebRTC] Improved msid support https://bugs.webkit.org/show_bug.cgi?id=250007 Reviewed by Xabier Rodriguez-Calvar. GstWebRTCBin can now store the MediaStream ID as a pad property. Fallback to previously used CNAME otherwise. See also https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3106. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp: (WebCore::GStreamerMediaEndpoint::configureAndLinkSource): (WebCore::GStreamerMediaEndpoint::requestPad): (WebCore::GStreamerMediaEndpoint::addRemoteStream): * Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h: * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.h: (WebCore::RealtimeOutgoingMediaSourceGStreamer::mediaStreamID const): Canonical link: https://commits.webkit.org/258658@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ecd45a: [GStreamer][WebRTC] Improved statistics support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ecd45a098ed578b77bf264bbd1954feef6030edb https://github.com/WebKit/WebKit/commit/ecd45a098ed578b77bf264bbd1954feef6030edb Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h M Source/WebCore/platform/mediastream/RealtimeMediaSource.h M Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Improved statistics support https://bugs.webkit.org/show_bug.cgi?id=249940 Reviewed by Xabier Rodriguez-Calvar. Fill the `kind` attribute in RtpStreamStats and also a few more video frame related attributes for inbound rtp stats. In order to support extended stats gathering, the queryDecodedVideoFramesCount() virtual method in VideoFrameObserver was replaced by a more generic queryAdditionalStats method. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp: (WebCore::fillRTCRTPStreamStats): (WebCore::fillInboundRTPStreamStats): (WebCore::fillRTCTransportStats): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::configureVideoDecoder): (WebCore::MediaPlayerPrivateGStreamer::updateVideoSinkStatistics): (WebCore::MediaPlayerPrivateGStreamer::videoPlaybackQualityMetrics): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/mediastream/RealtimeMediaSource.h: * Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: * Source/WebCore/platform/mediastream/gstreamer/RealtimeIncomingVideoSourceGStreamer.cpp: (WebCore::RealtimeIncomingVideoSourceGStreamer::stats): Canonical link: https://commits.webkit.org/258659@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 4f70db: [GStreamer][MediaStream] Misc media capture improv...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 4f70db078a9a41587d03e48b9c8b52b60e5d13d8 https://github.com/WebKit/WebKit/commit/4f70db078a9a41587d03e48b9c8b52b60e5d13d8 Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.h M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][MediaStream] Misc media capture improvements https://bugs.webkit.org/show_bug.cgi?id=249938 Reviewed by Xabier Rodriguez-Calvar. Video frame metadata was attached only for mock sources. There's no need for a tee in the capturer pipeline because there's never more than one client. Multiple observers watch for samples received by the sink. And a few other drive-by and coding style cleanups. * Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp: (WebCore::GStreamerAudioCaptureSource::newSampleCallback): * Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp: (WebCore::initializeDebugCategory): (WebCore::GStreamerAudioCapturer::GStreamerAudioCapturer): (WebCore::GStreamerAudioCapturer::createConverter): (WebCore::GStreamerAudioCapturer::setSampleRate): * Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp: (WebCore::GStreamerCapturer::createSource): (WebCore::GStreamerCapturer::setupPipeline): (WebCore::GStreamerCapturer::makeElement): (WebCore::GStreamerCapturer::addSink): Deleted. * Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.h: * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceGStreamer.cpp: * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: Canonical link: https://commits.webkit.org/258662@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 209971: [GTK] Remove WebKitInstallMissingMediaPluginsPermi...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 209971efaec52e671a78a608074d0224c9ef1b1a https://github.com/WebKit/WebKit/commit/209971efaec52e671a78a608074d0224c9ef1b1a Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/html/HTMLMediaElement.cpp M Source/WebCore/html/HTMLMediaElement.h M Source/WebCore/page/ChromeClient.h M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/graphics/MediaPlayer.h M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h R Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h M Source/WebKit/SourcesGTK.txt M Source/WebKit/SourcesWPE.txt M Source/WebKit/UIProcess/API/glib/WebKitAutocleanups.h.in M Source/WebKit/UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.cpp M Source/WebKit/UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.h.in R Source/WebKit/UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequestPrivate.h M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp M Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h M Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp M Source/WebKit/UIProcess/API/gtk/PageClientImpl.h M Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp M Source/WebKit/UIProcess/API/wpe/PageClientImpl.h M Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp M Source/WebKit/UIProcess/PageClient.h M Source/WebKit/UIProcess/WebPageProxy.messages.in R Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp R Source/WebKit/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h R Source/WebKit/UIProcess/gstreamer/WebPageProxyGStreamer.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h M Source/WebKit/WebProcess/WebPage/WebPage.cpp M Source/WebKit/WebProcess/WebPage/WebPage.h M Source/WebKit/WebProcess/WebPage/WebPage.messages.in R Source/WebKit/WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp M Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp M Tools/TestWebKitAPI/glib/TestExpectations.json Log Message: --- [GTK] Remove WebKitInstallMissingMediaPluginsPermissionRequest https://bugs.webkit.org/show_bug.cgi?id=239132 Reviewed by Michael Catanzaro. This API wasn't triggered anymore since the WebCore GStreamer platform layer only advertises support for codecs that are guaranteed to work. * Source/WebCore/html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::requestInstallMissingPlugins): Deleted. * Source/WebCore/html/HTMLMediaElement.h: * Source/WebCore/page/ChromeClient.h: (WebCore::ChromeClient::requestInstallMissingMediaPlugins): Deleted. * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::requestInstallMissingPlugins): Deleted. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): (WebCore::MediaPlayerPrivateGStreamer::handleMessage): * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: * Source/WebCore/platform/graphics/gstreamer/MediaPlayerRequestInstallMissingPluginsCallback.h: Removed. * Source/WebKit/SourcesGTK.txt: * Source/WebKit/SourcesWPE.txt: * Source/WebKit/UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: (webkitInstallMissingMediaPluginsPermissionRequestAllow): (webkitInstallMissingMediaPluginsPermissionRequestDeny): (webkit_install_missing_media_plugins_permission_request_get_description): (createGstInstallPluginsContext): Deleted. (webkitInstallMissingMediaPluginsPermissionRequestCreate): Deleted. * Source/WebKit/UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequest.h.in: * Source/WebKit/UIProcess/API/glib/WebKitInstallMissingMediaPluginsPermissionRequestPrivate.h: Removed. * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp: (webkitWebViewRequestInstallMissingMediaPlugins): Deleted. * Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h: * Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::decidePolicyForInstallMissingMediaPluginsPermissionRequest): Deleted. * Source/WebKit/UIProcess/API/gtk/PageClientImpl.h: * Source/WebKit/UIProcess/API/wpe/PageClientImpl.cpp: (WebKit::PageClientImpl::decidePolicyForInstallMissingMediaPluginsPermissionRequest): Deleted. * Source/WebKit/UIProcess/API/wpe/PageClientImpl.h: * Source/WebKit/UIProcess/Launcher/glib/XDGDBusProxy.cpp: (WebKit::XDGDBusProxy::dbusSessionProxy): * Source/WebKit/UIProcess/PageClient.h: * Source
[webkit-changes] [WebKit/WebKit] 9e4ed3: [GStreamer][WebRTC] VAAPI encoders support
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 9e4ed340f4374475d4e0a97df381235bcd972444 https://github.com/WebKit/WebKit/commit/9e4ed340f4374475d4e0a97df381235bcd972444 Author: Philippe Normand Date: 2023-01-09 (Mon, 09 Jan 2023) Changed paths: M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] VAAPI encoders support https://bugs.webkit.org/show_bug.cgi?id=249941 Reviewed by Xabier Rodriguez-Calvar. Basic support for H.264 and H.265 VAAPI encoders. The H.265 probing is very minimal at the moment. Support for VP8/VP9/AV1 will be added later on (I don't have GPUs supporting those codecs). Implicitely depends on https://github.com/WebKit/WebKit/pull/8094 and https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3616. The videorate element in the encoder bin was triggering issues and flakyness in some tests. I think it's not really required actually, but a videoscale is good to have though. * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::fillVideoRtpCapabilities): * Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp: (webrtcVideoEncoderSetEncoder): (webkit_webrtc_video_encoder_class_init): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::setPayloadType): Canonical link: https://commits.webkit.org/258666@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] aef3b9: [WPE][GTK] Enable MEDIA_SESSION by default
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: aef3b94e6d79c9e235bc3650d972c356620df82f https://github.com/WebKit/WebKit/commit/aef3b94e6d79c9e235bc3650d972c356620df82f Author: Philippe Normand Date: 2023-01-11 (Wed, 11 Jan 2023) Changed paths: M Source/cmake/OptionsGTK.cmake M Source/cmake/OptionsWPE.cmake Log Message: --- [WPE][GTK] Enable MEDIA_SESSION by default https://bugs.webkit.org/show_bug.cgi?id=239931 Unreviewed, manual revert of 250153@main. * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: Canonical link: https://commits.webkit.org/258779@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 3a57c6: [GStreamer][MSE] Misc capabilities and EOS handlin...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 3a57c6e319c3912d4e69457cc27011a38ac329f0 https://github.com/WebKit/WebKit/commit/3a57c6e319c3912d4e69457cc27011a38ac329f0 Author: Philippe Normand Date: 2022-12-06 (Tue, 06 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h Log Message: --- [GStreamer][MSE] Misc capabilities and EOS handling improvements https://bugs.webkit.org/show_bug.cgi?id=248741 Reviewed by Alicia Boya Garcia. When the MediaSource is marked as ended, set the player network state to `loaded`, aligning with the spec and AVF backend. The `addSourceBuffer` method now returns `NotSupported` in case the AppendPipeline is not able to handle the given contentType. * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::setNetworkState): * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h: * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::addSourceBuffer): (WebCore::MediaSourcePrivateGStreamer::markEndOfStream): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::isContentTypeSupported): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h: Canonical link: https://commits.webkit.org/257408@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] e4eb5a: [GStreamer] Don't perform position queries on vide...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e4eb5ae5478a5bf650fae501a2adaf148b5cdc6e https://github.com/WebKit/WebKit/commit/e4eb5ae5478a5bf650fae501a2adaf148b5cdc6e Author: Philippe Normand Date: 2022-12-08 (Thu, 08 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp Log Message: --- [GStreamer] Don't perform position queries on video sink when the player is for audio only https://bugs.webkit.org/show_bug.cgi?id=248739 Reviewed by Xabier Rodriguez-Calvar. When the player is for an `` element the underlying video sink is a fake sink, so position queries on that one will be useless. * Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::gstreamerPositionFromSinks const): Canonical link: https://commits.webkit.org/257555@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] cf92dc: [GStreamer] Minimal codec parsing module
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: cf92dc1de95a7620e873987eed9cd096d1a65851 https://github.com/WebKit/WebKit/commit/cf92dc1de95a7620e873987eed9cd096d1a65851 Author: Philippe Normand Date: 2022-12-09 (Fri, 09 Dec 2022) Changed paths: M Source/WebCore/platform/GStreamer.cmake M Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp A Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp A Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.h Log Message: --- [GStreamer] Minimal codec parsing module https://bugs.webkit.org/show_bug.cgi?id=248948 Reviewed by Xabier Rodriguez-Calvar. This patch exposes API for parsing H.264 profile and level from a codec string, this code existed in the registry scanner before but can now be reused for eg. the upcoming WebCodecs backend. A minimal VP9 profile parsing utility is also part of this patch. The new file is stored in platform/gstreamer, we should gradually add new GStreamer modules there when appropriate. Some of the platform/graphics/gstreamer files could also move there at some point. * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::isAVC1CodecSupported const): * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.cpp: Added. (WebCore::ensureDebugCategoryInitialized): (WebCore::GStreamerCodecUtilities::parseVP9Profile): * Source/WebCore/platform/gstreamer/GStreamerCodecUtilities.h: Added. Canonical link: https://commits.webkit.org/257615@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] a4ddc3: [GStreamer][WebRTC] Report video encoder bitrate i...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a4ddc34d0b3f62cb6a02a1d7e4b81bdaa8b79035 https://github.com/WebKit/WebKit/commit/a4ddc34d0b3f62cb6a02a1d7e4b81bdaa8b79035 Author: Philippe Normand Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: --- [GStreamer][WebRTC] Report video encoder bitrate in outgoing RTP stats https://bugs.webkit.org/show_bug.cgi?id=249093 Reviewed by Xabier Rodriguez-Calvar. The bitrate in kbps is queried on the encoder and passed to the stats as a bps value. * Source/WebCore/Modules/mediastream/gstreamer/GStreamerStatsCollector.cpp: (WebCore::fillOutboundRTPStreamStats): * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::updateStats): Canonical link: https://commits.webkit.org/257719@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] ab0bcd: REGRESSION(257606@main): WebProcess::didClose over...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ab0bcd358b5081f5b138e51b620a46d06b0169d1 https://github.com/WebKit/WebKit/commit/ab0bcd358b5081f5b138e51b620a46d06b0169d1 Author: Philippe Normand Date: 2022-12-12 (Mon, 12 Dec 2022) Changed paths: M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/WebProcess/WebProcess.cpp Log Message: --- REGRESSION(257606@main): WebProcess::didClose override broke GLib ports https://bugs.webkit.org/show_bug.cgi?id=249101 Reviewed by Carlos Garcia Campos. Chain WebProcess::didClose() to parent class in order to let the AuxiliaryProcess clean-up properly. * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::didClose): Canonical link: https://commits.webkit.org/257721@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 1e5066: [GStreamer][MSE] Logging improvements
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 1e5066813c753343545f6148144885cd576b6499 https://github.com/WebKit/WebKit/commit/1e5066813c753343545f6148144885cd576b6499 Author: Philippe Normand Date: 2022-12-06 (Tue, 06 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp M Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h M Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp Log Message: --- [GStreamer][MSE] Logging improvements https://bugs.webkit.org/show_bug.cgi?id=248740 Reviewed by Alicia Boya Garcia. Use _OBJECT gst logging macros more often, helping with debugging on pages where there are multiple media elements. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::assertedElementSetState): (WebCore::AppendPipeline::AppendPipeline): (WebCore::AppendPipeline::~AppendPipeline): (WebCore::AppendPipeline::handleErrorSyncMessage): (WebCore::AppendPipeline::appsrcEndOfAppendCheckerProbe): (WebCore::AppendPipeline::appsinkCapsChanged): (WebCore::AppendPipeline::handleEndOfAppend): (WebCore::AppendPipeline::appsinkNewSample): (WebCore::AppendPipeline::didReceiveInitializationSegment): (WebCore::AppendPipeline::consumeAppsinksAvailableSamples): (WebCore::AppendPipeline::resetParserState): (WebCore::AppendPipeline::stopParser): (WebCore::AppendPipeline::pushNewBuffer): (WebCore::AppendPipeline::handleAppsinkNewSampleFromStreamingThread): (WebCore::createOptionalParserForFormat): (WebCore::AppendPipeline::Track::emplaceOptionalParserForFormat): (WebCore::appendPipelinePadProbeDebugInformation): (WebCore::appendPipelineAppsinkPadEventProbe): (WebCore::appendPipelineDemuxerBlackHolePadProbe): * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp: (WebCore::MediaPlayerPrivateGStreamerMSE::updateStates): * Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h: * Source/WebCore/platform/graphics/gstreamer/mse/MediaSourcePrivateGStreamer.cpp: (WebCore::MediaSourcePrivateGStreamer::durationChanged): (WebCore::MediaSourcePrivateGStreamer::markEndOfStream): (WebCore::MediaSourcePrivateGStreamer::unmarkEndOfStream): (WebCore::MediaSourcePrivateGStreamer::startPlaybackIfHasAllTracks): * Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp: (WebCore::SourceBufferPrivateGStreamer::append): (WebCore::SourceBufferPrivateGStreamer::abort): (WebCore::SourceBufferPrivateGStreamer::resetParserState): (WebCore::SourceBufferPrivateGStreamer::flush): (WebCore::SourceBufferPrivateGStreamer::enqueueSample): (WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples): (WebCore::SourceBufferPrivateGStreamer::allSamplesInTrackEnqueued): Canonical link: https://commits.webkit.org/257422@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] c75026: [GStreamer][MSE] Refactor demuxer handling in Appe...
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c75026b5ef156d070d279c9dc209d1bcb0f3c0c5 https://github.com/WebKit/WebKit/commit/c75026b5ef156d070d279c9dc209d1bcb0f3c0c5 Author: Philippe Normand Date: 2022-12-17 (Sat, 17 Dec 2022) Changed paths: M Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp Log Message: --- [GStreamer][MSE] Refactor demuxer handling in AppendPipeline https://bugs.webkit.org/show_bug.cgi?id=248742 Reviewed by Alicia Boya Garcia. Instead of a boolean `hasDemuxer` we can check the element metadata for the `Demuxer` classifier. * Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp: (WebCore::AppendPipeline::AppendPipeline): Canonical link: https://commits.webkit.org/258044@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [WebKit/WebKit] 57191c: [GStreamer] Handle latency messages
Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 57191c0bb3eefcf88bbc54b10e4903420c862cbb https://github.com/WebKit/WebKit/commit/57191c0bb3eefcf88bbc54b10e4903420c862cbb Author: Philippe Normand Date: 2022-12-13 (Tue, 13 Dec 2022) Changed paths: M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp M Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp M Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.h Log Message: --- [GStreamer] Handle latency messages https://bugs.webkit.org/show_bug.cgi?id=248813 Reviewed by Xabier Rodriguez-Calvar. When a latency message is received on the bus the application should recalculate and distribute a new latency. Also included in this patch is a drive-by improvement in state-change message handling in the audio file reader, where we process only the notification from the top-level pipeline. * Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp: (WebCore::AudioDestinationGStreamer::handleMessage): * Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: (WebCore::AudioFileReader::handleMessage): * Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp: (WebCore::AudioSourceProviderGStreamer::AudioSourceProviderGStreamer): * Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: (WebCore::connectSimpleBusMessageCallback): * Source/WebCore/platform/graphics/gstreamer/ImageDecoderGStreamer.cpp: (WebCore::ImageDecoderGStreamer::InnerDecoder::handleMessage): Canonical link: https://commits.webkit.org/257788@main ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
