Re: [webkit-dev] Huge Memory Leak: How to restrict?
Thanks Zecke/David,
I have logged a bug and submitted a patch for the same at:
https://bugs.webkit.org/show_bug.cgi?id=22959
Please review it and land.
Regards,
Dhananjoy
On Fri, Dec 19, 2008 at 10:21 PM, David Kilzer ddkil...@webkit.org wrote:
Please file a bug on https://bugs.webkit.org/ following these
instructions, and attach your patch for review (setting the review? flag):
http://webkit.org/coding/contributing.html
Be sure to include a ChangeLog entry with your patch.
Thanks!
Dave
--
*From:* Dhananjoy Chutia dha...@gmail.com
*To:* Holger Freyther ze...@selfish.org
*Cc:* webkit-dev@lists.webkit.org
*Sent:* Friday, December 19, 2008 8:15:43 AM
*Subject:* Re: [webkit-dev] Huge Memory Leak: How to restrict?
Hi,
The statement *d-m_msg = NULL* is removed as
I observed that *m_msg* is g_object_unref ed at
ResourceHandleInternal::~ResourceHandleInternal()
{
if (m_msg) {
g_object_unref(m_msg);
m_msg = 0;
}
}
but never executed. So, as per my understanding, the statement* d-m_msg =
NULL* is removed. Will it create any new problem? I am new in this area. I
expect your valuable suggestion.
Regards
Dhananjoy
On Fri, Dec 19, 2008 at 8:59 PM, Dhananjoy Chutia dha...@gmail.comwrote:
Hi,
Thank you for your information. I had done the following modification
in WebKit-r39293 observed the VmSize of GtkLauncher for more than 40
minutes found no increase. Please let me know whether my modification is
correct or not. It is to be noted that WebKit is configured with
*--with-target=x11
--with-http-backend=soup*.
diff -pu a/WebCore/platform/network/soup/ResourceHandleSoup.cpp
b/WebCore/platform/network/soup/ResourceHandleSoup.cpp
--- a/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2008-12-19
20:22:23.0 +0530
+++ b/WebCore/platform/network/soup/ResourceHandleSoup.cpp 2008-12-19
20:24:53.0 +0530
@@ -164,7 +164,6 @@ static void finishedCallback(SoupSession
ResourceHandleInternal* d = handle-getInternal();
// The message has been handled.
-d-m_msg = NULL;
ResourceHandleClient* client = handle-client();
if (!client)
Snap shot of current observation:
Fri Dec 19 19:56:33 IST 2008
webkit: VmSize:57368 kB
Fri Dec 19 19:57:33 IST 2008
webkit: VmSize:57368 kB
Fri Dec 19 19:58:33 IST 2008
webkit: VmSize:57368 kB
Fri Dec 19 19:59:33 IST 2008
webkit: VmSize:57368 kB
Regards
Dhananjoy
On Thu, Dec 18, 2008 at 4:35 PM, Holger Freyther ze...@selfish.orgwrote:
On Thursday 18 December 2008 07:02:35 Dhananjoy Chutia wrote:
Hi,
I had carried out one experiment with GtkLauncher, by loading and
unloading a page at interval of 2 seconds. I observed VmSize of
GtkLauncher
at interval of one minute. Memory is increased gradually. Here is my
observation result.
Your test is flawed. And i have explained this several times on mails and
irc.
So here is the deal. I give you information and you contribute back. So
no
information until I'm certain that you are willing to get results of your
findings upstream.
z.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
--
Dhananjoy
--
Dhananjoy
--
Dhananjoy
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKitGtk network backend
On Sun, 2008-12-21 at 21:29 +0100, Christian Dywan wrote: So, I'd like to suggest to make libSoup the only backend. We would then require a recent (unstable) libSoup, similar to how Gtk+ depends on the latest (unstable) Glib. Xan Lopez has agreed already on IRC. As someone who has been building/testing/developing/using WebKit/GTK+ with libsoup from the start, I agree. Of course, we actually have a use case, that is we agreed to introduce libSoup specific API: https://bugs.webkit.org/show_bug.cgi?id=22624 I also agree with this API adition, as discussed in the Soup Cookies patch IRC meeting some time ago. See you, -- Gustavo Noronha Silva g...@gnome.org GNOME contributor: http://www.gnome.org/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Webkit Building error on XP
Hi, On Sun, Dec 21, 2008 at 5:45 PM, John Doe uniquepiec...@gmail.com wrote: a) http://webkit.org/building/tools.html b) http://webkit.org/building/build.html Any help would be greatly appreciated. Thank you. I suspect something is failing earlier in the build process, and you are seeing a symptom in your later error message. Here are the typical problems people encounter: 1. Forgetting to set the WEBKITOUTPUTDIR environment variable. This causes various shell expansions in the driver scripts to fail, as things that should point to real directories end up resolving to partial path names. 2. Using an existing installation of Cygwin. If you are missing the tools that ship in the WebKitvariation from the website, things will not build properly. I tried this initially, and failed because I was missing 'gperf', but I found it easier to just ditch the existing Cygwin install and use the WebKit download. 3. Using TortoiseSVN or another Windows client that mangles line endings. The scripts that run under Cygwin often expect UNIX line endings. If your SVN client adds '\r' to the files, you will get all sorts of problems. It's hard to say what's really wrong without the correct build log. I would look at what WTF and JavaScriptCoreGenerated show to see what might be going wrong. But I suspect one of the three items above is your problem. Good luck! -Brent Here is a buildlog describing the problem that i'm facing :- JSWorkerLocation.cpp JSWorkerContext.cpp JSWorker.cpp JSWebKitTransitionEvent.cpp JSWebKitCSSKeyframesRule.cpp JSWebKitCSSKeyframeRule.cpp JSWebKitAnimationEvent.cpp JSSVGElementWrapperFactory.cpp HTMLNames.cpp Compiling... CSSGrammar.cpp XPathGrammar.cpp Compiling... 1 c1xx : fatal error C1083: Cannot open source file: '1': No such file or directory SVGParserUtilities.cpp TextCodecICU.cpp FontWin.cpp Font.cpp XPathGrammar.cpp is actually generated in WebKitBuild\obj\WebCore\ DerivedSources. Earlier in my build process, i'm getting the same error but for different file called SVGParserUtilities.cpp. Then i remove WebkitBuild and do a rebuild. Thank you. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKitGtk network backend
Hi, On Mon, Dec 22, 2008 at 2:29 AM, Gustavo Noronha Silva g...@gnome.org wrote: On Sun, 2008-12-21 at 21:29 +0100, Christian Dywan wrote: So, I'd like to suggest to make libSoup the only backend. We would then require a recent (unstable) libSoup, similar to how Gtk+ depends on the latest (unstable) Glib. Xan Lopez has agreed already on IRC. The Redistributable WebKit on Windows currently uses the cURL backend. I am fully in favor of switching to libSoup for this platform as well, if it is known to work properly on Windows. I am a bit concerned that it seems to be heavily tied to the Gnome platform. Will I end up having to pull in glib and other Gnome dependencies if I wish to use it? Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKitGtk network backend
Am Mon, 22 Dec 2008 14:03:36 -0800 schrieb Brent Fulgham bfulg...@gmail.com: Hi, On Mon, Dec 22, 2008 at 2:29 AM, Gustavo Noronha Silva g...@gnome.org wrote: On Sun, 2008-12-21 at 21:29 +0100, Christian Dywan wrote: So, I'd like to suggest to make libSoup the only backend. We would then require a recent (unstable) libSoup, similar to how Gtk+ depends on the latest (unstable) Glib. Xan Lopez has agreed already on IRC. The Redistributable WebKit on Windows currently uses the cURL backend. I am fully in favor of switching to libSoup for this platform as well, if it is known to work properly on Windows. I am a bit concerned that it seems to be heavily tied to the Gnome platform. Will I end up having to pull in glib and other Gnome dependencies if I wish to use it? Hey Brent, in fact Glib is a requirement, libSoup relies essentially on features of the GObject system. But that is already it. There are no Gnomish requirements on top of that, the libsoup-gnome library is optional and not needed for normal functionality. So it comes down to whether or not Glib is feasible for your port. ciao, Christian ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
