Re: [webkit-dev] How to write a "hello world" example in Webkit Gtk?

2009-07-06 Thread Hieu Le Trung
Hi,

 

There is no WebKit in GTK, you must compile the WebKit and use the GtkLauncher 
in order to test the webkit.

You can try some GTK sample to see if GTK works well or not.

 

Regards,

-Hieu

 

From: webkit-dev-boun...@lists.webkit.org 
[mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of deuxliquid
Sent: Tuesday, July 07, 2009 8:37 AM
To: webkit-dev@lists.webkit.org
Subject: [webkit-dev] How to write a "hello world" example in Webkit Gtk?

 

Hi all,
I have just installed Gtk-2.16.0 on my computer. Next, I must install webkit 
that base Gtk but I am not able. It seems Webkit is too big(?) so that it has 
number of errors.
I wonder if there is a Gtk that has already integrated webkit? Because I know 
Qt has also itegerated Webkit in it. 
Can anybody help me to write a small example like "hello world" in Gtk Webkit?
Thank you in advance!
Hai

 



Lướt web nhanh hơn 

 
Internet Explorer 8 tối ưu hóa cho Yahoo!, tự động khởi động 2 trang bạn thích 
mỗi lần mở trình duyệt. Tải IE8 tại đây! (Miễn phí) 

 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Oliver Hunt


On Jul 6, 2009, at 6:58 PM, Maciej Stachowiak wrote:



On Jul 6, 2009, at 6:44 PM, Oliver Hunt wrote:



On Jul 6, 2009, at 5:37 PM, Eric Seidel wrote:

Currently WebKit avoids this need for Safari directly, by having  
separate Obj-C and JS bindings around DOM objects.  Properties/ 
getters/setters added through JS do not affect the Obj-C  
bindings.  Other embedders which call directly through the JS  
bindings could currently have implementation problems w/o Isolated  
World functionality.


I'm unsure what you mean by this?  V8 could just as easily have COM  
or C bindings.  The specific issue that "Isolated Worlds" is a  
feature designed specifically to deal with potential  
vulnerabilities in JavaScript so bindings for other languages  
aren't really relevant.


My understanding of "Isolated Worlds" is that it's meant to let  
privileged JavaScript code access the DOM of a Web page without the  
risk of undesired side effects from pages that are deliberately  
trying to hack the privileged JavaScript code. This is to some  
extent the same position the Web Inspector finds itself in, for  
example. Even with the new proxying code to enable out-of-process  
Web Inspector, the Web Inspector may want any code it runs in the  
context of the Web page to use Isolated World style bindings. On the  
other hand, it needs to be able to break through to the underlying  
DOM object as well.


I was meaning JavaScript in the context of the DOM (my bad) -- native  
code is implicitly trusted so we don't have the same xss, etc concerns.


--Oliver



 - Maciej



--Oliver



-eric

On Wed, Jul 1, 2009 at 11:07 PM, Oliver Hunt   
wrote:


On Jul 1, 2009, at 10:59 PM, Adam Barth wrote:

On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak  
wrote:
We generally wouldn't accept WebKit features that only work with  
V8, even if

other ports may not immediately plan to use them.

I support this principle.

I haven't thought through whether this particular feature
should be an exception.

The main arguments are as follows:

1) Isolated worlds is not a web platform feature.  Adding the  
feature

to V8 and not to JSC does not create an incompatibility between the
two engines.  The observable behavior from web content is the same.

WebKit is not just a web platform API -- it is used in a wide  
variety different applications -- that said, if this feature  
wasn't relevant to WebKit it wouldn't need to be in WebKit




2) The purpose of implementing isolated worlds is so the app can
implement an app-specific feature (extensions).  Implementing
extensions in another app requires a lot more than just isolated
worlds.

However if isolated worlds is necessary to provide effective  
security controls in any application that wished to be extensible  
in the face of arbitrary untrusted content, and it needs to be in  
webcore (if it doesn't my prior comment applies, this doesn't need  
to be in the webkit tree) then any application that wishes to use  
webkit will need webkit to provide this unless every application  
shipped its own copy of webkit with its own implementation of  
isolated worlds.




3) I don't foresee the implementation touching any source files
outside of WebCore/bindings/v8.  Other ports do not need to bear any
costs because of isolated worlds.

As i've said if isolated worlds has a real usecase then there is  
no reason to not actually provide it




In general, I think using regression tests for features that are not
directly exposed to Web content, but implemented in WebCore/ 
WebKit, is
reasonable. For example we have tests that check that WebKit's  
delegate
methods relating to load progress are dispatched in the correct  
order.


Perhaps I've been indoctrinated into the cult, but I wouldn't want  
to

work on something without writing tests.

Agreed, and what JS engine is being used should not effect the  
results of those tests.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Maciej Stachowiak


On Jul 6, 2009, at 6:44 PM, Oliver Hunt wrote:



On Jul 6, 2009, at 5:37 PM, Eric Seidel wrote:

Currently WebKit avoids this need for Safari directly, by having  
separate Obj-C and JS bindings around DOM objects.  Properties/ 
getters/setters added through JS do not affect the Obj-C bindings.   
Other embedders which call directly through the JS bindings could  
currently have implementation problems w/o Isolated World  
functionality.


I'm unsure what you mean by this?  V8 could just as easily have COM  
or C bindings.  The specific issue that "Isolated Worlds" is a  
feature designed specifically to deal with potential vulnerabilities  
in JavaScript so bindings for other languages aren't really relevant.


My understanding of "Isolated Worlds" is that it's meant to let  
privileged JavaScript code access the DOM of a Web page without the  
risk of undesired side effects from pages that are deliberately trying  
to hack the privileged JavaScript code. This is to some extent the  
same position the Web Inspector finds itself in, for example. Even  
with the new proxying code to enable out-of-process Web Inspector, the  
Web Inspector may want any code it runs in the context of the Web page  
to use Isolated World style bindings. On the other hand, it needs to  
be able to break through to the underlying DOM object as well.


 - Maciej



--Oliver



-eric

On Wed, Jul 1, 2009 at 11:07 PM, Oliver Hunt   
wrote:


On Jul 1, 2009, at 10:59 PM, Adam Barth wrote:

On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak  
wrote:
We generally wouldn't accept WebKit features that only work with  
V8, even if

other ports may not immediately plan to use them.

I support this principle.

I haven't thought through whether this particular feature
should be an exception.

The main arguments are as follows:

1) Isolated worlds is not a web platform feature.  Adding the feature
to V8 and not to JSC does not create an incompatibility between the
two engines.  The observable behavior from web content is the same.

WebKit is not just a web platform API -- it is used in a wide  
variety different applications -- that said, if this feature wasn't  
relevant to WebKit it wouldn't need to be in WebKit




2) The purpose of implementing isolated worlds is so the app can
implement an app-specific feature (extensions).  Implementing
extensions in another app requires a lot more than just isolated
worlds.

However if isolated worlds is necessary to provide effective  
security controls in any application that wished to be extensible  
in the face of arbitrary untrusted content, and it needs to be in  
webcore (if it doesn't my prior comment applies, this doesn't need  
to be in the webkit tree) then any application that wishes to use  
webkit will need webkit to provide this unless every application  
shipped its own copy of webkit with its own implementation of  
isolated worlds.




3) I don't foresee the implementation touching any source files
outside of WebCore/bindings/v8.  Other ports do not need to bear any
costs because of isolated worlds.

As i've said if isolated worlds has a real usecase then there is no  
reason to not actually provide it




In general, I think using regression tests for features that are not
directly exposed to Web content, but implemented in WebCore/WebKit,  
is
reasonable. For example we have tests that check that WebKit's  
delegate
methods relating to load progress are dispatched in the correct  
order.


Perhaps I've been indoctrinated into the cult, but I wouldn't want to
work on something without writing tests.

Agreed, and what JS engine is being used should not effect the  
results of those tests.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Oliver Hunt


On Jul 6, 2009, at 5:37 PM, Eric Seidel wrote:

Currently WebKit avoids this need for Safari directly, by having  
separate Obj-C and JS bindings around DOM objects.  Properties/ 
getters/setters added through JS do not affect the Obj-C bindings.   
Other embedders which call directly through the JS bindings could  
currently have implementation problems w/o Isolated World  
functionality.


I'm unsure what you mean by this?  V8 could just as easily have COM or  
C bindings.  The specific issue that "Isolated Worlds" is a feature  
designed specifically to deal with potential vulnerabilities in  
JavaScript so bindings for other languages aren't really relevant.


--Oliver



-eric

On Wed, Jul 1, 2009 at 11:07 PM, Oliver Hunt  wrote:

On Jul 1, 2009, at 10:59 PM, Adam Barth wrote:

On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak  
wrote:
We generally wouldn't accept WebKit features that only work with V8,  
even if

other ports may not immediately plan to use them.

I support this principle.

I haven't thought through whether this particular feature
should be an exception.

The main arguments are as follows:

1) Isolated worlds is not a web platform feature.  Adding the feature
to V8 and not to JSC does not create an incompatibility between the
two engines.  The observable behavior from web content is the same.

WebKit is not just a web platform API -- it is used in a wide  
variety different applications -- that said, if this feature wasn't  
relevant to WebKit it wouldn't need to be in WebKit




2) The purpose of implementing isolated worlds is so the app can
implement an app-specific feature (extensions).  Implementing
extensions in another app requires a lot more than just isolated
worlds.

However if isolated worlds is necessary to provide effective  
security controls in any application that wished to be extensible in  
the face of arbitrary untrusted content, and it needs to be in  
webcore (if it doesn't my prior comment applies, this doesn't need  
to be in the webkit tree) then any application that wishes to use  
webkit will need webkit to provide this unless every application  
shipped its own copy of webkit with its own implementation of  
isolated worlds.




3) I don't foresee the implementation touching any source files
outside of WebCore/bindings/v8.  Other ports do not need to bear any
costs because of isolated worlds.

As i've said if isolated worlds has a real usecase then there is no  
reason to not actually provide it




In general, I think using regression tests for features that are not
directly exposed to Web content, but implemented in WebCore/WebKit, is
reasonable. For example we have tests that check that WebKit's  
delegate

methods relating to load progress are dispatched in the correct order.

Perhaps I've been indoctrinated into the cult, but I wouldn't want to
work on something without writing tests.

Agreed, and what JS engine is being used should not effect the  
results of those tests.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to write a "hello world" example in Webkit Gtk?

2009-07-06 Thread Jeremy Orlow
Please use webkit-h...@lists.webkit.org

On Mon, Jul 6, 2009 at 6:36 PM, deuxliquid  wrote:

> Hi all,
> I have just installed Gtk-2.16.0 on my computer. Next, I must install
> webkit that base Gtk but I am not able. It seems Webkit is too big(?) so
> that it has number of errors.
> I wonder if there is a Gtk that has already integrated webkit? Because I
> know Qt has also itegerated Webkit in it.
> Can anybody help me to write a small example like "hello world" in Gtk
> Webkit?
> Thank you in advance!
> Hai
>
> --
>  Lướt web nhanh hơn
> 
> Internet Explorer 8 tối ưu hóa cho Yahoo!, tự động khởi động 2 trang bạn
> thích mỗi lần mở trình duyệt. Tải IE8 tại đây! (Miễn 
> phí)
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] How to write a "hello world" example in Webkit Gtk?

2009-07-06 Thread deuxliquid
Hi all,
I have just installed Gtk-2.16.0 on my computer. Next, I must install webkit 
that base Gtk but I am not able. It seems Webkit is too big(?) so that it has 
number of errors.
I wonder if there is a Gtk that has already integrated webkit? Because I know 
Qt has also itegerated Webkit in it. 
Can anybody help me to write a small example like "hello world" in Gtk Webkit?
Thank you in advance!
Hai



  "Yahoo! Mail nay nhanh và nhiều không gian thoáng hơn. Hãy trải 
nghiệm ngay hôm nay! 
http://vn.mail.yahoo.com";___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] [Feature request] Bugzilla: default unassignee emails to per component.

2009-07-06 Thread tonikitoo (Antonio Gomes)
Hi Willian and Darin,

I am pretty familiarized to bugzilla ecosystem and use and I also agree w/
both of you that my proposal would not be an ideal solution... I am really
want to fire a discussion about improvements on it.

"Is getting emails the most practical way here for such ? If so, how do we
easily do this ?"

br


On Mon, Jul 6, 2009 at 2:05 PM, William Siegrist wrote:

> On Jul 6, 2009, at 12:59 PM, tonikitoo (Antonio Gomes) wrote:
>
>  Guys, I would like your opinion about the following  "feature request" add
>> in WebKit's bugzilla.
>>
>> Now, for every bug filed there is a default assignee (
>> webkit-unassig...@lists.webkit.org). In order to make possible for
>> developers to follow bug activities of a specific component. My proposal is
>> the existence of default assignees per component.
>>
>> e .g.:
>> * qtwebkit-unassig...@lists.webkit.org
>> * tests_tootls-unassig...@lists.webkit.org
>> * (,,,) and so for other components.
>>
>> That way, people could use the "user watching" feature to track specific
>> component activities via email (see bugzilla home page -> preferences ->
>> email preferences -> "user watching" option at the bottom) .
>>
>> Thoughts ?
>>
>>
>
> You could also perform an advanced search with whatever component criteria
> you wanted, then use the RSS feed from the results to watch for changes.
>
> -Bill




-- 
--Antonio Gomes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Maciej Stachowiak


That sounds like a reasonable direction. I do think future JSC-port- 
based products such as Safari may want Isolated World behavior. I  
could even imagine it being useful for WebKit's own Web Inspector in  
the same-process case. I was going to reply to Adam's last comment,  
and point out that (a) his reasons for implementing for V8 only sound  
reasonable, but (b) I think JSC-based ports may want the functionality  
in the near if not immediate future, and would that change his mind on  
the right way to do the work?


However, doing it for both JS engines removes any doubt about this  
work, in my opinion.


Also, to clarify: I think the tests for this functionality should be  
part of the WebKit regression test suite. I think I was pretty clear  
on this before. I think this would be true even for a V8-only feature  
that was implemented in the engine, and even if that feature was not  
part of the Web platform. The WebKit API on Mac has many capabilities  
that are only relevant to an embedder, not to Web content as such, but  
nontheless we consider it important to keep them under test as much as  
we can.


REgards,
Maciej

On Jul 6, 2009, at 5:39 PM, Eric Seidel wrote:


Re-sent from the proper email address.

On Mon, Jul 6, 2009 at 5:37 PM, Eric Seidel  wrote:
Adam and I talked about this feature more in person last night.

I agree with Oliver.  Like any feature added to WebCore, it should  
work with the default compiled JS engine JavaScriptCore.



From taking to Adam, it seems this could be useful for WebKit  
embedders like Safari (any context in which you want to make a  
"pristine view" of the DOM where nothing could have overridden  
properties or getters/setters unexpectedly).


Currently WebKit avoids this need for Safari directly, by having  
separate Obj-C and JS bindings around DOM objects.  Properties/ 
getters/setters added through JS do not affect the Obj-C bindings.   
Other embedders which call directly through the JS bindings could  
currently have implementation problems w/o Isolated World  
functionality.


-eric

On Wed, Jul 1, 2009 at 11:07 PM, Oliver Hunt  wrote:

On Jul 1, 2009, at 10:59 PM, Adam Barth wrote:

On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak  
wrote:
We generally wouldn't accept WebKit features that only work with V8,  
even if

other ports may not immediately plan to use them.

I support this principle.

I haven't thought through whether this particular feature
should be an exception.

The main arguments are as follows:

1) Isolated worlds is not a web platform feature.  Adding the feature
to V8 and not to JSC does not create an incompatibility between the
two engines.  The observable behavior from web content is the same.

WebKit is not just a web platform API -- it is used in a wide  
variety different applications -- that said, if this feature wasn't  
relevant to WebKit it wouldn't need to be in WebKit




2) The purpose of implementing isolated worlds is so the app can
implement an app-specific feature (extensions).  Implementing
extensions in another app requires a lot more than just isolated
worlds.

However if isolated worlds is necessary to provide effective  
security controls in any application that wished to be extensible in  
the face of arbitrary untrusted content, and it needs to be in  
webcore (if it doesn't my prior comment applies, this doesn't need  
to be in the webkit tree) then any application that wishes to use  
webkit will need webkit to provide this unless every application  
shipped its own copy of webkit with its own implementation of  
isolated worlds.




3) I don't foresee the implementation touching any source files
outside of WebCore/bindings/v8.  Other ports do not need to bear any
costs because of isolated worlds.

As i've said if isolated worlds has a real usecase then there is no  
reason to not actually provide it




In general, I think using regression tests for features that are not
directly exposed to Web content, but implemented in WebCore/WebKit, is
reasonable. For example we have tests that check that WebKit's  
delegate

methods relating to load progress are dispatched in the correct order.

Perhaps I've been indoctrinated into the cult, but I wouldn't want to
work on something without writing tests.

Agreed, and what JS engine is being used should not effect the  
results of those tests.



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Oliver Hunt

I have realised that the point i really wanted to make is that
 * Isolated worlds would be a webkit feature
 * WebKit features should be tested in the webkit test suite
 * All tests in webkit should pass in JavaScriptCore as that is  
webkit's javascript engine.


--Oliver

On Jul 1, 2009, at 10:59 PM, Adam Barth wrote:

On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak  
wrote:
We generally wouldn't accept WebKit features that only work with  
V8, even if

other ports may not immediately plan to use them.


I support this principle.


I haven't thought through whether this particular feature
should be an exception.


The main arguments are as follows:

1) Isolated worlds is not a web platform feature.  Adding the feature
to V8 and not to JSC does not create an incompatibility between the
two engines.  The observable behavior from web content is the same.

2) The purpose of implementing isolated worlds is so the app can
implement an app-specific feature (extensions).  Implementing
extensions in another app requires a lot more than just isolated
worlds.

3) I don't foresee the implementation touching any source files
outside of WebCore/bindings/v8.  Other ports do not need to bear any
costs because of isolated worlds.


In general, I think using regression tests for features that are not
directly exposed to Web content, but implemented in WebCore/WebKit,  
is
reasonable. For example we have tests that check that WebKit's  
delegate
methods relating to load progress are dispatched in the correct  
order.


Perhaps I've been indoctrinated into the cult, but I wouldn't want to
work on something without writing tests.

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Isolated world tests

2009-07-06 Thread Eric Seidel
Re-sent from the proper email address.

On Mon, Jul 6, 2009 at 5:37 PM, Eric Seidel  wrote:

> Adam and I talked about this feature more in person last night.
> I agree with Oliver.  Like any feature added to WebCore, it should work
> with the default compiled JS engine JavaScriptCore.
>
>
> From taking to Adam, it seems this could be useful for WebKit embedders
> like Safari (any context in which you want to make a "pristine view" of the
> DOM where nothing could have overridden properties or getters/setters
> unexpectedly).
>
> Currently WebKit avoids this need for Safari directly, by having separate
> Obj-C and JS bindings around DOM objects.  Properties/getters/setters added
> through JS do not affect the Obj-C bindings.  Other embedders which call
> directly through the JS bindings could currently have implementation
> problems w/o Isolated World functionality.
>
> -eric
>
> On Wed, Jul 1, 2009 at 11:07 PM, Oliver Hunt  wrote:
>
>>
>> On Jul 1, 2009, at 10:59 PM, Adam Barth wrote:
>>
>>  On Wed, Jul 1, 2009 at 7:50 PM, Maciej Stachowiak wrote:
>>>
 We generally wouldn't accept WebKit features that only work with V8,
 even if
 other ports may not immediately plan to use them.

>>>
>>> I support this principle.
>>>
>>>  I haven't thought through whether this particular feature
 should be an exception.

>>>
>>> The main arguments are as follows:
>>>
>>> 1) Isolated worlds is not a web platform feature.  Adding the feature
>>> to V8 and not to JSC does not create an incompatibility between the
>>> two engines.  The observable behavior from web content is the same.
>>>
>>
>> WebKit is not just a web platform API -- it is used in a wide variety
>> different applications -- that said, if this feature wasn't relevant to
>> WebKit it wouldn't need to be in WebKit
>>
>>
>>> 2) The purpose of implementing isolated worlds is so the app can
>>> implement an app-specific feature (extensions).  Implementing
>>> extensions in another app requires a lot more than just isolated
>>> worlds.
>>>
>>
>> However if isolated worlds is necessary to provide effective security
>> controls in any application that wished to be extensible in the face of
>> arbitrary untrusted content, and it needs to be in webcore (if it doesn't my
>> prior comment applies, this doesn't need to be in the webkit tree) then any
>> application that wishes to use webkit will need webkit to provide this
>> unless every application shipped its own copy of webkit with its own
>> implementation of isolated worlds.
>>
>>
>>> 3) I don't foresee the implementation touching any source files
>>> outside of WebCore/bindings/v8.  Other ports do not need to bear any
>>> costs because of isolated worlds.
>>>
>>
>> As i've said if isolated worlds has a real usecase then there is no reason
>> to not actually provide it
>>
>>
>>>  In general, I think using regression tests for features that are not
 directly exposed to Web content, but implemented in WebCore/WebKit, is
 reasonable. For example we have tests that check that WebKit's delegate
 methods relating to load progress are dispatched in the correct order.

>>>
>>> Perhaps I've been indoctrinated into the cult, but I wouldn't want to
>>> work on something without writing tests.
>>>
>>
>> Agreed, and what JS engine is being used should not effect the results of
>> those tests.
>>
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Inheritance in IDL files/JS bindings

2009-07-06 Thread Drew Wilson
OK - I've uploaded a patch here if anyone has a chance to look at it - it's
only about 11 changed lines, so it's pretty small.
https://bugs.webkit.org/show_bug.cgi?id=27010

-atw

On Mon, Jul 6, 2009 at 3:00 PM, Darin Adler  wrote:

> On Jul 6, 2009, at 2:52 PM, Drew Wilson wrote:
>
>  BTW, I noticed that the CustomToJS IDL attribute in HTMLCollection.idl is
>> not implemented - instead, there's just a big hard-coded list of classes in
>> CodeGeneratorJS.pm::UsesManualToJSImplementation() that corresponds to that
>> functionality.
>>
>> Any reason not to get rid of UsesManualToJSImplementation() in favor of an
>> explicit CustomToJS attribute? I'm happy to put together a patch for this.
>>
>
> No reason I can think of. That would be fine to do.
>
>-- Darin
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] content policies

2009-07-06 Thread Brady Eidson

The WebKit API already leaves policy decisions up to it's client.

Check out WebPolicyDelegate which allows the client to make decisions  
for individual resource requests based on the contents of the request,  
and WebResourceLoadDelegates for the client to make decisions based on  
the MIME type and other contents of the response.


I wonder if these are good enough for you to implement your feature in  
your browser?


~Brady

On Jul 3, 2009, at 3:58 PM, Roger Pack wrote:


Sorry to just join and post in...just wondering if any consideration
had been given to something akin to Gecko's "content policies" for
filtering content.  This would allow things like adblock plus to work
more easily with webkit based browsers [1].

Or is this something like "create a patch and send it in if you want  
it."?


Thanks much.
=r
[1] http://adblockplus.org/en/faq_internal
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Inheritance in IDL files/JS bindings

2009-07-06 Thread Darin Adler

On Jul 6, 2009, at 2:52 PM, Drew Wilson wrote:

BTW, I noticed that the CustomToJS IDL attribute in  
HTMLCollection.idl is not implemented - instead, there's just a big  
hard-coded list of classes in  
CodeGeneratorJS.pm::UsesManualToJSImplementation() that corresponds  
to that functionality.


Any reason not to get rid of UsesManualToJSImplementation() in favor  
of an explicit CustomToJS attribute? I'm happy to put together a  
patch for this.


No reason I can think of. That would be fine to do.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] [Feature request] Bugzilla: default unassignee emails to per component.

2009-07-06 Thread William Siegrist

On Jul 6, 2009, at 12:59 PM, tonikitoo (Antonio Gomes) wrote:

Guys, I would like your opinion about the following  "feature  
request" add in WebKit's bugzilla.


Now, for every bug filed there is a default assignee (webkit-unassig...@lists.webkit.org 
). In order to make possible for developers to follow bug activities  
of a specific component. My proposal is the existence of default  
assignees per component.


e .g.:
* qtwebkit-unassig...@lists.webkit.org
* tests_tootls-unassig...@lists.webkit.org
* (,,,) and so for other components.

That way, people could use the "user watching" feature to track  
specific component activities via email (see bugzilla home page ->  
preferences -> email preferences -> "user watching" option at the  
bottom) .


Thoughts ?




You could also perform an advanced search with whatever component  
criteria you wanted, then use the RSS feed from the results to watch  
for changes.


-Bill

smime.p7s
Description: S/MIME cryptographic signature
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Inheritance in IDL files/JS bindings

2009-07-06 Thread Drew Wilson
BTW, I noticed that the CustomToJS IDL attribute in HTMLCollection.idl is
not implemented - instead, there's just a big hard-coded list of classes in
CodeGeneratorJS.pm::UsesManualToJSImplementation() that corresponds to that
functionality.
Any reason not to
get rid of UsesManualToJSImplementation() in favor of an explicit
CustomToJS attribute? I'm happy to put together a patach for this.

-atw



On Sat, Jul 4, 2009 at 3:02 PM, Maciej Stachowiak  wrote:

>
> On Jul 4, 2009, at 11:52 AM, Drew Wilson wrote:
>
>
> 1) I don't ever actually want a raw JSAbstractWorker to be created - is
> there a way to disable the toJS() generation? It looks like maybe CustomToJS
> might've let me do this, but it still defines toJS() in the AbstractWorker.h
> file. I'd rather have this generate a compile error than have incorrect
> behavior at runtime.
>
>
> I think the right way to handle this is to make a custom toJS function that
> does a runtime check of the actual type, and makes the right kind of wrapper
> object. That's because any time you deal with an AbstractWorker pointer, you
> want toJS on it to return the canonical wrapper of the right concrete class.
> The toJS function for Node is a fairly elaborate example of this.
>
>
> 2) What does GenerateNativeConverter do? I note that both Node and
> Element.idl define GenerateToJS, but none of their derived classes
> (HTMLElement.idl, HTMLOptionElement.idl) define GenerateToJS, which makes me
> think that just defining GenerateToJS on derived classes is not the correct
> fix.
>
>
> Correct - see above. toJS needs to do a dynamic check based on the runtime
> type, not a static check based on the declared type. We don't ever want to
> vend an "Element" wrapper for something that actually should be an
> "HTMLDivElement", even if it got returned from a context that deals with
> generic elements.
>
>
>
> I don't know how useful the diff would be, but I uploaded one here - it's
> not ready for review yet as it has lots of odd debugging flotsam in it:
> https://bugs.webkit.org/attachment.cgi?id=32257&action=review
>
>
>
> It sounds like you're on the right track to figuring this out. I believe 
> writing a custom toJS for AbstractWorker which checks what kind of object it 
> actually has will fix your problem.
>
> Regards,
> Maciej
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] [Feature request] Bugzilla: default unassignee emails to per component.

2009-07-06 Thread Darin Adler

On Jul 6, 2009, at 12:59 PM, tonikitoo (Antonio Gomes) wrote:

Now, for every bug filed there is a default assignee (webkit-unassig...@lists.webkit.org 
). In order to make possible for developers to follow bug activities  
of a specific component. My proposal is the existence of default  
assignees per component.


I think it’s fine to have more than one assignee, and some components  
are obvious candidates for this, but I think 35 separate ones for  
every single component doesn’t seem good, and it would be awkward to  
have to manage mailing lists any time we wanted to change components  
around.


To follow bug activities on a particular component, we should probably  
add a Bugzilla watch feature that lets you follow bug activities on a  
component.


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] [Feature request] Bugzilla: default unassignee emails to per component.

2009-07-06 Thread tonikitoo (Antonio Gomes)
Guys, I would like your opinion about the following  "feature request" add
in WebKit's bugzilla.

Now, for every bug filed there is a default assignee (
webkit-unassig...@lists.webkit.org). In order to make possible for
developers to follow bug activities of a specific component. My proposal is
the existence of default assignees per component.

e .g.:
* qtwebkit-unassig...@lists.webkit.org
* tests_tootls-unassig...@lists.webkit.org
* (,,,) and so for other components.

That way, people could use the "user watching" feature to track specific
component activities via email (see bugzilla home page -> preferences ->
email preferences -> "user watching" option at the bottom) .

Thoughts ?

-- 
--Antonio Gomes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Max http connection per host ?

2009-07-06 Thread David Kilzer
Hi Jérôme,

The method to change the connection count is not public API, and it's not 
supported on all platforms (hence the reason it always returns 4).

Dave





From: Jérôme Lebel 
To: webkit-dev@lists.webkit.org
Sent: Monday, July 6, 2009 11:42:25 AM
Subject: [webkit-dev] Max http connection per host ?

Hi,

I'm trying to change the max http connection count per host in WebKit on OS X. 
I'm not sure if this mechanism by WebCore or by CFNetwork. I found 
wkInitializeMaximumHTTPConnectionCountPerHost(), but I'm not sure how it worked 
(since first parameter is 6 and it returns 4). I tried to change the parameter 
and the returned value, but nothing changed in WebKit.

I was not able to find any information in the CFNetwork documentation.

Thanks for the help

Jérôme,___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] EXPORT_JS changeset

2009-07-06 Thread Maciej Stachowiak


I see Darin already answered. But for future reference, questions like  
this that are requests for help, rather than about the development of  
WebKit itself, should be posted on webkit-help rather than webkit-div.


On Jul 1, 2009, at 6:23 AM, Jack Wootton wrote:


Hello,

I'm interested in using the JavaScriptCore, however I'm working with
an old revision of WebKit - I'm unsure of exactly what version it is,
but the most recent entry in the changelog file in the JavaScriptCore
was on the 2007-10-03.

Looking at the JavaScriptcore API files, such as JSObjectRef.h,
functions are not prefixed with IMPORT / EXPORT - as I would expect
them to be, since they make up an API exported from a DLL.  Browsing a
more recent version of the source online here:

http://trac.webkit.org/browser/trunk/JavaScriptCore/API/JSObjectRef.h

functions are exported using JS_EXPORT.  However this change seems to
have been introduced with the following changeset dated 27/11/2007.

http://trac.webkit.org/changeset/28097

Can any provide any information on:

1. How the JavaScriptCore API can be used if there is no IMPORT /
EXPORT next to function definitions.  How was it used before the
changeset introducing JS_EXPORT?
2. What happened in terms of the changes to how JSCore functions were
exported and when these changes were introduced?

--
Regards
Jack
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Iterating SunSpider

2009-07-06 Thread Maciej Stachowiak


On Jul 6, 2009, at 10:11 AM, Geoffrey Garen wrote:

So, what you end up with is after a couple of years, the slowest  
test in the suite is the most significant part of the score.   
Further, I'll predict that the slowest test will most likely be the  
least relevant test, because the truly important parts of JS  
engines were already optimized.  This has happened with Sunspider  
0.9 - the regex portions of the test became the dominant factor,  
even though they were not nearly as prominent in the real world as  
they were in the benchmark.  This leads to implementors optimizing  
for the benchmark - and that is not what we want to encourage.


How did you determine that regex performance is "not nearly as  
prominent in the real world?"



For reference: in current JavaScriptCore, the one regexp-centric test  
is about 4.6% of the score by time. 3 of the string tests also spend  
their time in regexps, however, I think those are among the tests that  
most closely resemble what Web sites do. I believe the situation is  
roughly similar in other competitive JavaScript engines. This is  
probably not exactly proportionate but it doesn't dominate the test. I  
don't think any of this is a problem, unless one thinks the regexp  
improvements in Nitro, V8 and TraceMonkey were a waste of resources.


What I have seen happen is that numeric processing and especially  
integer math became a smaller and smaller proportion of the test,  
looking at the best publicly available engines over time. I think that  
turned out to be the case because math had much more room for  
optimization in naive implementations than, say, string processing.


Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Max http connection per host ?

2009-07-06 Thread Jérôme Lebel

Hi,

I'm trying to change the max http connection count per host in WebKit  
on OS X. I'm not sure if this mechanism by WebCore or by CFNetwork. I  
found wkInitializeMaximumHTTPConnectionCountPerHost(), but I'm not  
sure how it worked (since first parameter is 6 and it returns 4). I  
tried to change the parameter and the returned value, but nothing  
changed in WebKit.


I was not able to find any information in the CFNetwork documentation.

Thanks for the help

Jérôme,
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Git Familiarity (was ChangeLog)

2009-07-06 Thread Roger Pack
> For what it's worth, I support switching to git.  It certainly will be
> painful for some, but I think it'll be a win before long.  That said, I also
> think Maciej is right and that there are some bigger fish to fry at the
> moment.

+1

git [and/or github] make branching your friend, no longer your enemy.

=r
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Logo usage

2009-07-06 Thread Darin Adler

On Jul 1, 2009, at 4:04 AM, Gustavo Noronha wrote:

I would like to know what are the usage terms for the WebKit logo -  
the one with compass in the box.


Because this logo includes a copy of the Safari logo in it, it’s  
really not OK to use it outside webkit.org. Even in webkit.org itself  
it would be nice to have a WebKit logo that was not built out of the  
Safari logo, but I don’t think it’s a simple matter of having someone  
draw a new picture.


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] EXPORT_JS changeset

2009-07-06 Thread Darin Adler

On Jul 1, 2009, at 6:23 AM, Jack Wootton wrote:

I'm interested in using the JavaScriptCore, however I'm working with  
an old revision of WebKit - I'm unsure of exactly what version it  
is, but the most recent entry in the changelog file in the  
JavaScriptCore was on the 2007-10-03.


As a group, the WebKit developers don’t really support mixing and  
matching various old versions of components.


1. How the JavaScriptCore API can be used if there is no IMPORT /  
EXPORT next to function definitions.  How was it used before the  
changeset introducing JS_EXPORT?


I assume you’re asking about Windows. We used .def files to list  
exported symbols.


2. What happened in terms of the changes to how JSCore functions  
were exported and when these changes were introduced?


Different platforms use different build systems, so the techniques  
required to get the public symbols exported are different. For  
example, on Mac OS X a .exp file is used to determine which symbols  
are exported from the JavaScriptCore framework.


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] cursor position in textbox

2009-07-06 Thread Simon Fraser

On Jul 6, 2009, at 1:45 AM, Nilesh Patil wrote:


Hi

Just a clarification...

By cursor i meant blinking cursor ( i.e. 'I' ) that appears next to
any character when u type anything in text box


Technically, that's the caret, which is also the term used in the  
source.


Simon

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Iterating SunSpider

2009-07-06 Thread Geoffrey Garen
So, what you end up with is after a couple of years, the slowest  
test in the suite is the most significant part of the score.   
Further, I'll predict that the slowest test will most likely be the  
least relevant test, because the truly important parts of JS engines  
were already optimized.  This has happened with Sunspider 0.9 - the  
regex portions of the test became the dominant factor, even though  
they were not nearly as prominent in the real world as they were in  
the benchmark.  This leads to implementors optimizing for the  
benchmark - and that is not what we want to encourage.


How did you determine that regex performance is "not nearly as  
prominent in the real world?"


Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Text control rules in themeWin.css

2009-07-06 Thread David Hyatt

Monospace textareas are gross. :)

dave

On Jul 6, 2009, at 11:47 AM, Dan Bernstein wrote:


Hi folks,

I was looking at themeWin.css and noticed a few rules relating to  
text controls. Can anyone shed a light on their purpose and why they  
are in themeWin.css rather than in html4.css or in a port-specific  
theme?


Specifically, these rules:

input:not([type]),
input[type="text"],
input[type="password"] {
padding:1px 0;
}

textarea:disabled,
input:not([type]):disabled,
input[type="text"]:disabled,
input[type="password"]:disabled,
input[type="search"]:disabled {
background-color: #EBEBE4;
}

input[type="search"]::-webkit-search-cancel-button {
   margin-right: 3px;
}

input[type="search"]::-webkit-search-results-decoration {
margin: 0 3px 0 2px;
}

input[type="search"]::-webkit-search-results-button {
margin: 0 3px 0 2px;
}

textarea {
  font-family: monospace;
}

This comment at the top of the file is most telling:

/* These styles override the default styling for HTML elements as  
defined in

   WebCore/css/html.css. So far we have used this file exclusively for
   making our form elements match Firefox's. */

Have we decided that we want WebKit to match Firefox on Windows?

Thanks,
—Dan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] cursor position in textbox

2009-07-06 Thread Adele Peterson

Yes, in WebKit, that's just another kind of selection.

On Jul 6, 2009, at 1:45 AM, Nilesh Patil wrote:


Hi

Just a clarification...

By cursor i meant blinking cursor ( i.e. 'I' ) that appears next to
any character when u type anything in text box

Thanks & Regards
Niilesh

On Mon, Jul 6, 2009 at 2:11 PM, Nilesh Patil wrote:

Hi

Thanks Adele 

Thanks & Regards
Niilesh


On Mon, Jul 6, 2009 at 12:15 PM, Adele Peterson  
wrote:

Hi Nilesh,

Try setting a breakpoint at  
WebCore::SelectionController::setSelection and

looking at the backtrace from there.

- Adele

On Jul 5, 2009, at 11:13 PM, Nilesh Patil wrote:


Hi

Any one knows how does cursor position is updated in side textbox
whenever alphabet is entered ?

Thanks in advance ...
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev






___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Text control rules in themeWin.css

2009-07-06 Thread Dan Bernstein

Hi folks,

I was looking at themeWin.css and noticed a few rules relating to text  
controls. Can anyone shed a light on their purpose and why they are in  
themeWin.css rather than in html4.css or in a port-specific theme?


Specifically, these rules:

input:not([type]),
input[type="text"],
input[type="password"] {
padding:1px 0;
}

textarea:disabled,
input:not([type]):disabled,
input[type="text"]:disabled,
input[type="password"]:disabled,
input[type="search"]:disabled {
background-color: #EBEBE4;
}

input[type="search"]::-webkit-search-cancel-button {
   margin-right: 3px;
}

input[type="search"]::-webkit-search-results-decoration {
margin: 0 3px 0 2px;
}

input[type="search"]::-webkit-search-results-button {
margin: 0 3px 0 2px;
}

textarea {
  font-family: monospace;
}

This comment at the top of the file is most telling:

/* These styles override the default styling for HTML elements as  
defined in

   WebCore/css/html.css. So far we have used this file exclusively for
   making our form elements match Firefox's. */

Have we decided that we want WebKit to match Firefox on Windows?

Thanks,
—Dan___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] how to extend the javascript native object?

2009-07-06 Thread Jack Wootton
On Mon, Jul 6, 2009 at 3:43 PM, 胡 波 wrote:
> Thank you for your answer!
>
> I think that our idea may be different.I want to extend subobject "widget"
> to "window"object in webkit .because I want to add some application to
> widget object,and make it inherited from the window object.
>
> can you help me ?   thank you!!


Sorry, I wasn't aware WebKit had a widget property of the window object.

If you are asking how do you extend the widget object that already
belongs to the window object then you need to:

1. Retrieve a reference to the window object, I think you may need to
use KJS::Window::retrieveWindow
2. Convert the object retrieved in step 1 (KJS::Window object) to a
JSObjectRef using JSObjectRef winRef = toRef(window);
3. Use the JavaScriptCore function JSObjectGetProperty on the window
object to retrieve the widget JSObjectRef object.
4. Once you have the widget JSObjectRef, then I assume you can add new
methods or properties to it.

Maybe someone else who knows more about this, or understands your
request better, may be able to help you.

> --- 09年7月6日,周一, Jack Wootton  写道:
>
> 发件人: Jack Wootton 
> 主题: Re: [webkit-dev] how to extend the javascript native object?
> 收件人: "胡 波" 
> 抄送: webkit-dev@lists.webkit.org
> 日期: 2009年7月6日,周一,下午5:22
>
> On Sat, Jul 4, 2009 at 4:52 PM, 胡 波 wrote:
>> Thank you very much!
>>
>> I understand your steps,But I do not understand the implement process! In
>> the samples you provide with me , I do not find the .cpp file. I want to
>> get
>> a sample for windows.Can you help me?
>>
>> my aim:"widget" object is the same the "history" object,for
>> example,to:"widget" object: window.widget.(property/method),:to :"history"
>> object,window.history.back();
>>
>> thank you!
>>
>
> In the JSPong example I linked, the first thing to look at should
> probably be PongAI.js.  Since this gives you an idea of what is being
> achieved. Then read the ReadMe.txt to get an overview of the different
> classes involved. You could then have a look at JSShape.m is where the
> "ball" class is constructed and it's properties are associated with
> Objective C implementation (by adding static values to the class
> definition).
>
> There is one oddity though, I do not understand why NSObject is
> inherited from, since I thought use of the JavaScriptCore API meant
> that developers didn't have to inherit from classes in this
> manner...that the API did this for them.  Maybe someone on this
> mailing list can help clarify this?
>
>
>
>
>> --- 09年7月4日,周六, Jack Wootton  写道:
>>
>> 发件人: Jack Wootton jackwoot...@gmail.com
>> 主题: Re: [webkit-dev] how to extend the javascript native object?
>> 收件人: "胡 波" 
>> 抄送: webkit-dev@lists.webkit.org
>> 日期: 2009年7月4日,周六,上午12:26
>>
>> To add, it maybe useful to look at the following files in the
>> JavaScriptCore (Although, personally I didn't find them particularly
>> easy to understand.)
>>
>> JavaScriptCore\API\testapi.c
>> testapi.js
>>
>>
>> There are also some example programs that do what you want to do, only
>> with different objects.
>>
>> JSPong: http://developer.apple.com/SampleCode/JSPong/index.html
>>
>> JSInterpreter:
>> http://developer.apple.com/samplecode/JSInterpreter/index.html
>>
>> More programs can be found here:
>>
>> http://developer.apple.com/SampleCode/Cocoa/idxInternetWeb-date.html
>>
>>
>>
>> 2009/7/3 Jack Wootton :
>>> Are you saying you wan to add a 'widget' property to the Window
>>> object?  If so, then the JavaScriptCore API has methods that will
>>> help you:
>>>
>>> Here is the API:
>>>
>>>
>>>
>>> http://gemma.apple.com/documentation/Carbon/Reference/WebKit_JavaScriptCore_Ref/index.html#//apple_ref/doc/framework/javascriptcore_fw
>>>
>>> If this is what you wish to do, then the following is a rough guide of
>>> what you need to do:
>>>
>>> 1. Create an empty class definition, you can create an empty class
>>> definition using kJSClassDefinitionEmpty.
>>> 2. Use the class definition with the JSCoreAPI method "JSClassCreate"
>>> to create your class.
>>> 3. Use your new class with JSObjectMake to create your new JSObject
>>> (this will be your widget object).
>>> 4  Use JSObjectSetProperty to add your new JSObject as a property of
>>> the Window object.
>>>
>>>
>>> On Fri, Jul 3, 2009 at 4:51 PM, 胡 波 wrote:
 I want to extend the javascript native object,such as widget
 object,and
 make it inherit window object. That is to say,when the widget object is
 extended, and we can use it by the window.widget.(method/property) in
 the
 html document?
 
 好玩贺卡等你发,邮箱贺卡全新上线!
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


>>>
>>>
>>>
>>> --
>>> Regards
>>> Jack
>>>
>>
>>
>>
>> --
>> Regards
>> Jack
>>
>> 
>> 好玩贺卡等你发,邮箱贺卡全新上线!
>
>
>
> --
> Regards
> Jack
>
> 
> 好玩贺卡等你发,邮箱贺卡全新上线!



Re: [webkit-dev] Some new mailing lists

2009-07-06 Thread Adam Roben

On Jul 6, 2009, at 10:31 AM, Adam Roben wrote:



On Jul 6, 2009, at 2:08 AM, Patrick Mueller wrote:


Maciej Stachowiak wrote:
Based on popular demand, we have created two new mailing lists to  
handle some content that's off-topic for webkit-dev. The new lists  
are:
webkit-help -- requests for help with building webkit, using  
WebKit's APIs, embedding WebKit, porting WebKit, and so forth
I suggest that anyone who would like to help others with WebKit  
topics that aren't about the development of WebKit itself, or  
people interested in asking such questions, should subscribe. We  
will gradually migrate this kind of material off of webkit-dev.

webkit-jobs -- post about WebKit-related jobs.
I suggest that anyone who would like to post or hear about WebKit- 
related employment opportunities should subscribe.


Excellent.  Can we get these added to gmane as well?'


Yes, I will add these new lists to Gmane along with the others (once  
I hear back from the Gmane folks about importing our list archives,  
etc.). Thanks for the reminder!


I went ahead and submitted subscription requests to Gmane for webkit- 
help, webkit-jobs, and webkit-gtk, since these lists don't have any  
history to import. The other lists will hopefully get added soon.


-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Help for Folder support for bookmark

2009-07-06 Thread Darin Adler
This is not a question about WebKit development, and is not on topic  
for this mailing list.


This is not a general programming help list nor a general browser- 
development help list.


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Some new mailing lists

2009-07-06 Thread Adam Roben


On Jul 6, 2009, at 2:08 AM, Patrick Mueller wrote:


Maciej Stachowiak wrote:
Based on popular demand, we have created two new mailing lists to  
handle some content that's off-topic for webkit-dev. The new lists  
are:
webkit-help -- requests for help with building webkit, using  
WebKit's APIs, embedding WebKit, porting WebKit, and so forth
 I suggest that anyone who would like to help others with WebKit  
topics that aren't about the development of WebKit itself, or  
people interested in asking such questions, should subscribe. We  
will gradually migrate this kind of material off of webkit-dev.

webkit-jobs -- post about WebKit-related jobs.
 I suggest that anyone who would like to post or hear about WebKit- 
related employment opportunities should subscribe.


Excellent.  Can we get these added to gmane as well?'


Yes, I will add these new lists to Gmane along with the others (once I  
hear back from the Gmane folks about importing our list archives,  
etc.). Thanks for the reminder!


-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] how to extend the javascript native object?

2009-07-06 Thread Darren VanBuren
Netscape, and all decendants use "ns" to prefix as opposed to "NS" for  
NeXTSTEP. A bit confusing for some.


Darren VanBuren
-
Sent from my iPod

Try Fedora 10 today. Fire it up. http://fedoraproject.org/

On Jul 6, 2009, at 2:37, Jack Wootton  wrote:


For completion, I can answer my own question.  NSObject stands for
NeXTStep Object.  Which is related to Objective C and not webkit.  I
assumed it was something like "NetScape Object".  My mistake.  If like
me you're more familiar with C++ than Objective C - this seems like a
reasonable guide:

http://www.otierney.net/objective-c.html

2009/7/6 Jack Wootton :

On Sat, Jul 4, 2009 at 4:52 PM, 胡 波 wrote:

Thank you very much!

I understand your steps,But I do not understand the implement  
process! In
the samples you provide with me , I do not find the .cpp file. I  
want to get

a sample for windows.Can you help me?

my aim:"widget" object is the same the "history" object,for
example,to:"widget" object: window.widget.(property/ 
method),:to :"history"

object,window.history.back();

thank you!



In the JSPong example I linked, the first thing to look at should
probably be PongAI.js.  Since this gives you an idea of what is being
achieved. Then read the ReadMe.txt to get an overview of the  
different
classes involved. You could then have a look at JSShape.m is where  
the

"ball" class is constructed and it's properties are associated with
Objective C implementation (by adding static values to the class
definition).

There is one oddity though, I do not understand why NSObject is
inherited from, since I thought use of the JavaScriptCore API meant
that developers didn't have to inherit from classes in this
manner...that the API did this for them.  Maybe someone on this
mailing list can help clarify this?




--- 09年7月4日,周六, Jack Wootton  
 写道:


发件人: Jack Wootton jackwoot...@gmail.com
主题: Re: [webkit-dev] how to extend the javascript native object?
收件人: "胡 波" 
抄送: webkit-dev@lists.webkit.org
日期: 2009年7月4日,周六,上午12:26

To add, it maybe useful to look at the following files in the
JavaScriptCore (Although, personally I didn't find them particularly
easy to understand.)

JavaScriptCore\API\testapi.c
testapi.js


There are also some example programs that do what you want to do,  
only

with different objects.

JSPong: http://developer.apple.com/SampleCode/JSPong/index.html

JSInterpreter:
http://developer.apple.com/samplecode/JSInterpreter/index.html

More programs can be found here:

http://developer.apple.com/SampleCode/Cocoa/idxInternetWeb-date.html



2009/7/3 Jack Wootton :

Are you saying you wan to add a 'widget' property to the Window
object?  If so, then the JavaScriptCore API has methods that will
help you:

Here is the API:


http://gemma.apple.com/documentation/Carbon/Reference/WebKit_JavaScriptCore_Ref/index.html#//apple_ref/doc/framework/javascriptcore_fw

If this is what you wish to do, then the following is a rough  
guide of

what you need to do:

1. Create an empty class definition, you can create an empty class
definition using kJSClassDefinitionEmpty.
2. Use the class definition with the JSCoreAPI method  
"JSClassCreate"

to create your class.
3. Use your new class with JSObjectMake to create your new JSObject
(this will be your widget object).
4  Use JSObjectSetProperty to add your new JSObject as a property  
of

the Window object.


On Fri, Jul 3, 2009 at 4:51 PM, 胡 波 w 
rote:

   I want to extend the javascript native object,such as widget
object,and
make it inherit window object. That is to say,when the widget  
object is
extended, and we can use it by the window.widget.(method/ 
property) in the

html document?

好玩贺卡等你发,邮箱贺卡全新上线!
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev






--
Regards
Jack





--
Regards
Jack


好玩贺卡等你发,邮箱贺卡全新上线!




--
Regards
Jack





--
Regards
Jack
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Help for Folder support for bookmark

2009-07-06 Thread Arsh Kapoor
Hi All,

I am implementing bookmarks in folder.So,along with the bookmarks
list,bookmarks will also be stored in folders.
For that I have used a structure Folder_Record which contains two
members.foldername and parentfoldername.Now,when a bookmark is added it is
stored in the current folder.

Also UserInterface has an option something as  ADDFolder wherein you can add
new folder.Now if the current added folder has no parent,parentfoldername
becomes ROOT.But,if it has a parent than that foldername is stored as
parentfoldername.
I am using SQlite database where in the add query I am inserting values of
the folderrecord structure taken from the User Interface.


Can someone help me in implementing the check condition for
parentfoldername?As in if the present folder has no parent ,then ROOT should
be stored in database.But if there is a parent folder than that foldername
should be stored as parentfoldername in database.

Thanks,
Arsh
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] how to extend the javascript native object?

2009-07-06 Thread Jack Wootton
For completion, I can answer my own question.  NSObject stands for
NeXTStep Object.  Which is related to Objective C and not webkit.  I
assumed it was something like "NetScape Object".  My mistake.  If like
me you're more familiar with C++ than Objective C - this seems like a
reasonable guide:

http://www.otierney.net/objective-c.html

2009/7/6 Jack Wootton :
> On Sat, Jul 4, 2009 at 4:52 PM, 胡 波 wrote:
>> Thank you very much!
>>
>> I understand your steps,But I do not understand the implement process! In
>> the samples you provide with me , I do not find the .cpp file. I want to get
>> a sample for windows.Can you help me?
>>
>> my aim:"widget" object is the same the "history" object,for
>> example,to:"widget" object: window.widget.(property/method),:to :"history"
>> object,window.history.back();
>>
>> thank you!
>>
>
> In the JSPong example I linked, the first thing to look at should
> probably be PongAI.js.  Since this gives you an idea of what is being
> achieved. Then read the ReadMe.txt to get an overview of the different
> classes involved. You could then have a look at JSShape.m is where the
> "ball" class is constructed and it's properties are associated with
> Objective C implementation (by adding static values to the class
> definition).
>
> There is one oddity though, I do not understand why NSObject is
> inherited from, since I thought use of the JavaScriptCore API meant
> that developers didn't have to inherit from classes in this
> manner...that the API did this for them.  Maybe someone on this
> mailing list can help clarify this?
>
>
>
>
>> --- 09年7月4日,周六, Jack Wootton  写道:
>>
>> 发件人: Jack Wootton jackwoot...@gmail.com
>> 主题: Re: [webkit-dev] how to extend the javascript native object?
>> 收件人: "胡 波" 
>> 抄送: webkit-dev@lists.webkit.org
>> 日期: 2009年7月4日,周六,上午12:26
>>
>> To add, it maybe useful to look at the following files in the
>> JavaScriptCore (Although, personally I didn't find them particularly
>> easy to understand.)
>>
>> JavaScriptCore\API\testapi.c
>> testapi.js
>>
>>
>> There are also some example programs that do what you want to do, only
>> with different objects.
>>
>> JSPong: http://developer.apple.com/SampleCode/JSPong/index.html
>>
>> JSInterpreter:
>> http://developer.apple.com/samplecode/JSInterpreter/index.html
>>
>> More programs can be found here:
>>
>> http://developer.apple.com/SampleCode/Cocoa/idxInternetWeb-date.html
>>
>>
>>
>> 2009/7/3 Jack Wootton :
>>> Are you saying you wan to add a 'widget' property to the Window
>>> object?  If so, then the JavaScriptCore API has methods that will
>>> help you:
>>>
>>> Here is the API:
>>>
>>>
>>> http://gemma.apple.com/documentation/Carbon/Reference/WebKit_JavaScriptCore_Ref/index.html#//apple_ref/doc/framework/javascriptcore_fw
>>>
>>> If this is what you wish to do, then the following is a rough guide of
>>> what you need to do:
>>>
>>> 1. Create an empty class definition, you can create an empty class
>>> definition using kJSClassDefinitionEmpty.
>>> 2. Use the class definition with the JSCoreAPI method "JSClassCreate"
>>> to create your class.
>>> 3. Use your new class with JSObjectMake to create your new JSObject
>>> (this will be your widget object).
>>> 4  Use JSObjectSetProperty to add your new JSObject as a property of
>>> the Window object.
>>>
>>>
>>> On Fri, Jul 3, 2009 at 4:51 PM, 胡 波 wrote:
 I want to extend the javascript native object,such as widget
 object,and
 make it inherit window object. That is to say,when the widget object is
 extended, and we can use it by the window.widget.(method/property) in the
 html document?
 
 好玩贺卡等你发,邮箱贺卡全新上线!
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


>>>
>>>
>>>
>>> --
>>> Regards
>>> Jack
>>>
>>
>>
>>
>> --
>> Regards
>> Jack
>>
>> 
>> 好玩贺卡等你发,邮箱贺卡全新上线!
>
>
>
> --
> Regards
> Jack
>



-- 
Regards
Jack
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] how to extend the javascript native object?

2009-07-06 Thread Jack Wootton
On Sat, Jul 4, 2009 at 4:52 PM, 胡 波 wrote:
> Thank you very much!
>
> I understand your steps,But I do not understand the implement process! In
> the samples you provide with me , I do not find the .cpp file. I want to get
> a sample for windows.Can you help me?
>
> my aim:"widget" object is the same the "history" object,for
> example,to:"widget" object: window.widget.(property/method),:to :"history"
> object,window.history.back();
>
> thank you!
>

In the JSPong example I linked, the first thing to look at should
probably be PongAI.js.  Since this gives you an idea of what is being
achieved. Then read the ReadMe.txt to get an overview of the different
classes involved. You could then have a look at JSShape.m is where the
"ball" class is constructed and it's properties are associated with
Objective C implementation (by adding static values to the class
definition).

There is one oddity though, I do not understand why NSObject is
inherited from, since I thought use of the JavaScriptCore API meant
that developers didn't have to inherit from classes in this
manner...that the API did this for them.  Maybe someone on this
mailing list can help clarify this?




> --- 09年7月4日,周六, Jack Wootton  写道:
>
> 发件人: Jack Wootton jackwoot...@gmail.com
> 主题: Re: [webkit-dev] how to extend the javascript native object?
> 收件人: "胡 波" 
> 抄送: webkit-dev@lists.webkit.org
> 日期: 2009年7月4日,周六,上午12:26
>
> To add, it maybe useful to look at the following files in the
> JavaScriptCore (Although, personally I didn't find them particularly
> easy to understand.)
>
> JavaScriptCore\API\testapi.c
> testapi.js
>
>
> There are also some example programs that do what you want to do, only
> with different objects.
>
> JSPong: http://developer.apple.com/SampleCode/JSPong/index.html
>
> JSInterpreter:
> http://developer.apple.com/samplecode/JSInterpreter/index.html
>
> More programs can be found here:
>
> http://developer.apple.com/SampleCode/Cocoa/idxInternetWeb-date.html
>
>
>
> 2009/7/3 Jack Wootton :
>> Are you saying you wan to add a 'widget' property to the Window
>> object?  If so, then the JavaScriptCore API has methods that will
>> help you:
>>
>> Here is the API:
>>
>>
>> http://gemma.apple.com/documentation/Carbon/Reference/WebKit_JavaScriptCore_Ref/index.html#//apple_ref/doc/framework/javascriptcore_fw
>>
>> If this is what you wish to do, then the following is a rough guide of
>> what you need to do:
>>
>> 1. Create an empty class definition, you can create an empty class
>> definition using kJSClassDefinitionEmpty.
>> 2. Use the class definition with the JSCoreAPI method "JSClassCreate"
>> to create your class.
>> 3. Use your new class with JSObjectMake to create your new JSObject
>> (this will be your widget object).
>> 4  Use JSObjectSetProperty to add your new JSObject as a property of
>> the Window object.
>>
>>
>> On Fri, Jul 3, 2009 at 4:51 PM, 胡 波 wrote:
>>> I want to extend the javascript native object,such as widget
>>> object,and
>>> make it inherit window object. That is to say,when the widget object is
>>> extended, and we can use it by the window.widget.(method/property) in the
>>> html document?
>>> 
>>> 好玩贺卡等你发,邮箱贺卡全新上线!
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>>>
>>
>>
>>
>> --
>> Regards
>> Jack
>>
>
>
>
> --
> Regards
> Jack
>
> 
> 好玩贺卡等你发,邮箱贺卡全新上线!



-- 
Regards
Jack
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Git Familiarity (was ChangeLog)

2009-07-06 Thread Jeremy Orlow
On Sun, Jul 5, 2009 at 10:22 PM, Justin Haygood wrote:

>
> - Original Message - From: "Benjamin Meyer" 
> To: "WebKit Development" 
> Sent: Sunday, July 05, 2009 11:25 PM
> Subject: Re: [webkit-dev] Git Familiarity (was ChangeLog)
>
>
>> At least on Windows I use mysygit myself (
>> http://code.google.com/p/msysgit/ )  From the project description:
>> "Historically, Git on Windows was  only officially supported using Cygwin.
>> To help make a native Windows  version, this project was started, based on
>> the fork."
>>
>>
> Still has the following problems:
> 1. No Windows integrated UI. Windows is very UI driven, and all of the
> development tools are UI based. Why should I open up a command line to do
> VCS stuff? I don't have to open up a command line now.
>
> 2. No Visual Studio integration. Subversion not only has TortoiseSVN, but
> there's AnkhSVN that lets you manage it entirely inside Visual Studio.


The official instructions for getting and building WebKit involve things run
from the command prompt.  I agree that there are plenty of Windows based
developers who would not be comfortable using a command line, but I find it
hard to believe that there are many hacking on WebKit.  And, if they are,
they're probably savvy enough to write MSVC++ macros.

For what it's worth, I support switching to git.  It certainly will be
painful for some, but I think it'll be a win before long.  That said, I also
think Maciej is right and that there are some bigger fish to fry at the
moment.

J
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] cursor position in textbox

2009-07-06 Thread Nilesh Patil
Hi

Just a clarification...

By cursor i meant blinking cursor ( i.e. 'I' ) that appears next to
any character when u type anything in text box

Thanks & Regards
Niilesh

On Mon, Jul 6, 2009 at 2:11 PM, Nilesh Patil wrote:
> Hi
>
> Thanks Adele 
>
> Thanks & Regards
> Niilesh
>
>
> On Mon, Jul 6, 2009 at 12:15 PM, Adele Peterson wrote:
>> Hi Nilesh,
>>
>> Try setting a breakpoint at WebCore::SelectionController::setSelection and
>> looking at the backtrace from there.
>>
>> - Adele
>>
>> On Jul 5, 2009, at 11:13 PM, Nilesh Patil wrote:
>>
>>> Hi
>>>
>>> Any one knows how does cursor position is updated in side textbox
>>> whenever alphabet is entered ?
>>>
>>> Thanks in advance ...
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] cursor position in textbox

2009-07-06 Thread Nilesh Patil
Hi

Thanks Adele 

Thanks & Regards
Niilesh


On Mon, Jul 6, 2009 at 12:15 PM, Adele Peterson wrote:
> Hi Nilesh,
>
> Try setting a breakpoint at WebCore::SelectionController::setSelection and
> looking at the backtrace from there.
>
> - Adele
>
> On Jul 5, 2009, at 11:13 PM, Nilesh Patil wrote:
>
>> Hi
>>
>> Any one knows how does cursor position is updated in side textbox
>> whenever alphabet is entered ?
>>
>> Thanks in advance ...
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Bug 22759 - dropdown menu disappears on mouse-over

2009-07-06 Thread David Hyatt
Can't you just post this in the bug?  I fail to see why this should be  
a topic for discussion on webkit-dev.


dave
(hy...@apple.com)

On Jul 5, 2009, at 1:18 PM, Vamsi Kalyan wrote:


Hi, this post is related to issue
https://bugs.webkit.org/show_bug.cgi?id=22759.


corresponding chrome issue is

http://code.google.com/p/chromium/issues/detail?id=2019
This post discusses the issue using the reduction HTML file  
available on the issue.

Following calculations calculate the expected results for the
reduction HTML file attached to the issue.
Root ListItem vertical size, "RLITotal" = 0.6em top padding + text
line height + 0.7em bottom padding, where
Text line height = 16px * 70/100 * 1.5 = 16.8
So "RLITotal" = 0.6 * 16 * 70 / 100 + 16.8 + 0.7 * 16 * 70 / 100
= 6.72 + 16.8 + 7.84
= 31.36
The absolute positioned popup list's vertical position = 2.8em
   = 2.8 * 16 *  
70 /100

   = 31.36
Though there is no gap between root element and popup, in Chrome we
see some gap.
What happens inside code during parsing the HTML file is that floating
pointing number gets converted to integer without rounding off. So
6.72 becomes 6, 7.84 becomes 7 and 16.8 becomes 16 resulting in total
for "RLITotal" as 29.
And absolute vertical location for popup, 31.36 becomes 31.
Clearly two pixel gap results because of this rounding off behaviour.
Inside following function,
int computedLineHeight() const
{
Length lh = lineHeight();
// Negative value means the line height is not set.  Use the
font's built-in spacing.
if (lh.isNegative())
return font().lineSpacing();
if (lh.isPercent())
return lh.calcMinValue(fontSize(), true);
return lh.value();
}

The line, "return lh.calcMinValue(fontSize(), true);" was changed by
adding true as second parameter, which lets the calcMinValue to round
off the result to nearest integer. So in above example 16.82 becomes
17.
But that will not be sufficient because we'll still have 1 pixel gap.
So adding 0.5 to result before casting it to integer in the following
function fixes the issue. This function is a generic function used
during HTML/CSS file parsing.
int CSSPrimitiveValue::computeLengthIntForLength(RenderStyle* style,
double multiplier)
{
double result = computeLengthDouble(style, multiplier);
// This conversion is imprecise, often resulting in values of,
e.g., 44.8.  We
// need to go ahead and round if we're really close to the next
integer value.
result += result < 0 ? -0.01 : +0.01;
if (result > intMaxForLength || result < intMinForLength)
return 0;
return static_cast(result);
}

I am not sure how critical the comment is in above function. Code
rounds off only if it is too close to integer. Could anyone tell more
about it, as in why 0.01 why not 0.5?
Thanks.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev