Re: [webkit-dev] [webkit-changes] [47592] trunk/JavaScriptCore
I remember it happens to VC6. Seems VS2005 doesn't have this problem. -Yong - Original Message - From: Darin Adler da...@apple.com To: Yong Li yong...@torchmobile.com Cc: WebKit Development webkit-dev@lists.webkit.org Sent: Thursday, August 20, 2009 6:12 PM Subject: Re: [webkit-changes] [47592] trunk/JavaScriptCore On Aug 20, 2009, at 2:04 PM, Yong Li wrote: If derefIfNotNull() is not inline, it should be static. Otherwise, you can potentially get a build error like multiple bodies of derefIfNotNullfoo are found. If this is not a problem to winscw compiler, ignore this mail. I believe that is true for functions, but not function templates. Have you seen an actual problem? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] [webkit-changes] [47610] trunk/WebCore
On Aug 20, 2009, at 8:07 PM, bweinst...@apple.com wrote:
+static inline int adjustedScrollDelta(int beginningDelta) {
+// This implemention matches Firefox's.
+// http://mxr.mozilla.org/firefox/source/toolkit/content/widgets/browser.xml#856
.
Firefox's implementation is in JavaScript, which means that the
numbers are all doubles. Your implementation uses ints. Does the
difference matter?
-Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bugzilla Data Loss
On Fri, Aug 21, 2009 at 1:54 AM, Peter Kastingpkast...@google.com wrote: but patches that were merely attached to bugs have vanished. Hopefully you still have local copies and can re-attach them! This sort of thing tends to put a kibosh on some people's workflow of using bugzilla as a source control tool (as recently read in #webkit.) Well at least abarth does this. Crap happens. -- Regards, Ryan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bugzilla Data Loss
On Friday, August 21, 2009 at 7:59:11 AM, Ryan Leavengood wrote: On Fri, Aug 21, 2009 at 1:54 AM, Peter Kastingwrote: but patches that were merely attached to bugs have vanished. Hopefully you still have local copies and can re-attach them! This sort of thing tends to put a kibosh on some people's workflow of using bugzilla as a source control tool (as recently read in #webkit.) Well at least abarth does this. This is one place were local branches in a git repository work well. Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Building release on Windows Vista
Dear WebKit gurus, is it possible to build WebKit on Windows Vista in Release configuration? Both build from Cygwin and VS dies with: c:\WebKit\WebKit\WebKitBuild\lib\WebCore.lib : fatal error LNK1106: invalid file or disk full: cannot seek to 0x44DA4146 Clean build (wiping off WebKitBuild) has been tried. I git clone'ed rather recent version of WebKit (something two or three hours long from the time this message has been sent). Debug could be built fine from cygwin. Any hints are most appreciated. tia and yours, anton. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Bugzilla Data Loss
On Fri, Aug 21, 2009 at 7:59 AM, Ryan Leavengoodleaveng...@gmail.com wrote: This sort of thing tends to put a kibosh on some people's workflow of using bugzilla as a source control tool (as recently read in #webkit.) Well at least abarth does this. Fortunately, the stuff I was working on yesterday was sufficiently complicated that I kept it in local git branches. Hopefully no one lost work. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Building release on Windows Vista
I guess you've enabled link time optimization. The lib file is too big. The solution suggested by MS is to split the project. - Original Message - From: Anton Muhin ant...@chromium.org To: webkit-dev Development webkit-dev@lists.webkit.org Sent: Friday, August 21, 2009 12:03 PM Subject: [webkit-dev] Building release on Windows Vista Dear WebKit gurus, is it possible to build WebKit on Windows Vista in Release configuration? Both build from Cygwin and VS dies with: c:\WebKit\WebKit\WebKitBuild\lib\WebCore.lib : fatal error LNK1106: invalid file or disk full: cannot seek to 0x44DA4146 Clean build (wiping off WebKitBuild) has been tried. I git clone'ed rather recent version of WebKit (something two or three hours long from the time this message has been sent). Debug could be built fine from cygwin. Any hints are most appreciated. tia and yours, anton. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] r45939 broke my workflow
Hi. r45939 broke my workflow. Here's the related bugzilla bug: https://bugs.webkit.org/show_bug.cgi?id=26999 . Old Roll out a patch workflow: cd JavaScriptCore svn-create-patch patch.txt svn-unapply patch.txt Old Roll in a patch workflow: cd JavaScriptCore svn-apply patch.txt These old ways of doing things no longer work because svn-apply and svn-unapply don't match svn-create-patch's new behavior of changing to the WebKit root directory if you're currently working in a WebKit subdirectory. Here's an example command-line interaction: ~/webkit/WebKitTools/Scripts$ svn-create-patch ro.txt ~/webkit/WebKitTools/Scripts$ svn-unapply !$ svn-unapply ro.txt can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |Index: WebKitTools/Scripts/webkitdirs.pm |=== |--- WebKitTools/Scripts/webkitdirs.pm (revision 47638) |+++ WebKitTools/Scripts/webkitdirs.pm (working copy) -- File to patch: ^C'WebKitTools/Scripts' is not a directory at ./svn- unapply line 315, line 9. I tried to ignore this for a while, but it's really causing problems for me and at least one other WebKit developer. Should we revert r45939? Is there an easy fix to svn-apply and svn-unapply that you can make? Thanks, Geoff ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] r45939 broke my workflow
Is there an easy fix to svn-apply and svn-unapply that you can make? I believe there is an easy fix for this particular workflow, which is to make svn-apply and svn-unapply behave the same way as svn-create-patch. https://bugs.webkit.org/show_bug.cgi?id=28623 Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] svn-* scripts
I’m a little irritated that we’re changing our Subversion scripts, svn- create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced Subversion in a non-project-specific way. I used the WebKit version on many projects other than the WebKit project. I think the names should change if we’re changing them to do WebKit- specific things. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] svn-* scripts
On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced Subversion in a non-project- specific way. I used the WebKit version on many projects other than the WebKit project. I think the names should change if we’re changing them to do WebKit- specific things. I don't think the change I did before was WebKit specific. And the changes (not committed) to svn-[un]apply only reflect the changes to svn-create-patch, but are again not WebKit specific. These changes ensure that patches are created and applied from the root of any SVN Repository (which in fact is what git does by default and makes the most sense by removing any possible ambiguity or forcing someone to know which directory they should apply a patch). There has been some loss of functionality [1], but that can be fixed. [1] Create a patch without svn-create-patch which contains paths not from the repository's root and then attempting to use svn-apply or svn- unapply to deal with the patch. These are the only changes I know of. If there are any others its possible they may be WebKit specific. - Joseph Pecoraro ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] svn-* scripts
On Fri, Aug 21, 2009 at 5:57 PM, Joseph Pecoraro joepec...@gmail.comwrote: On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced Subversion in a non-project-specific way. I used the WebKit version on many projects other than the WebKit project. I think the names should change if we’re changing them to do WebKit-specific things. I don't think the change I did before was WebKit specific. And the changes (not committed) to svn-[un]apply only reflect the changes to svn-create-patch, but are again not WebKit specific. These changes ensure that patches are created and applied from the root of any SVN Repository (which in fact is what git does by default and makes the most sense by removing any possible ambiguity or forcing someone to know which directory they should apply a patch). There has been some loss of functionality [1], but that can be fixed. [1] Create a patch without svn-create-patch which contains paths not from the repository's root and then attempting to use svn-apply or svn-unapply to deal with the patch. These are the only changes I know of. If there are any others its possible they may be WebKit specific. Even if they were WebKit specific, I guess i don't see what the problem would be. After all, the tools are checked into WebKitTools in the webkit repository. Making them more useful for WebKit development at the expense of other development seems like an OK trade-off to me. Note that you could always grab a version of the files from back when they behaved the way you wanted and stick them in ~/bin (or some other dir on your path). ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] svn-* scripts
On Aug 21, 2009, at 6:15 PM, Jeremy Orlow wrote: On Fri, Aug 21, 2009 at 5:57 PM, Joseph Pecoraro joepec...@gmail.com wrote: On Aug 21, 2009, at 8: 32PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced Subversion in a non-project- specific way. I used the WebKit version on many projects other than the WebKit project. I think the names should change if we’re changing them to do WebKit- specific things. I don't think the change I did before was WebKit specific. And the changes (not committed) to svn-[un]apply only reflect the changes to svn-create-patch, but are again not WebKit specific. These changes ensure that patches are created and applied from the root of any SVN Repository (which in fact is what git does by default and makes the most sense by removing any possible ambiguity or forcing someone to know which directory they should apply a patch). There has been some loss of functionality [1], but that can be fixed. [1] Create a patch without svn-create-patch which contains paths not from the repository's root and then attempting to use svn-apply or svn-unapply to deal with the patch. These are the only changes I know of. If there are any others its possible they may be WebKit specific. Even if they were WebKit specific, I guess i don't see what the problem would be. After all, the tools are checked into WebKitTools in the webkit repository. Making them more useful for WebKit development at the expense of other development seems like an OK trade-off to me. Note that you could always grab a version of the files from back when they behaved the way you wanted and stick them in ~/bin (or some other dir on your path). FWIW Darin wrote the original CVS-based versions of these tools. That's not to say he owns their descendants forever, but telling him he should go to extraordinary lengths to make use of them for other purposes seems a little presumptuous. (No opinion on the factual question of whether the changes are WebKit specific or whether they are improvements for WebKit development; I'm not totally clear on the changes or their motivation.) Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] svn-* scripts
On Friday, August 21, 2009 at 5:32:14 PM, Darin Adler wrote: I’m a little irritated that we’re changing our Subversion scripts, svn-create-patch, svn-apply, and svn-unapply into WebKit-specific scripts. Previously, they were scripts that were independent of the particular project that enhanced Subversion in a non-project-specific way. I used the WebKit version on many projects other than the WebKit project. The only dependency these scripts have is VSCUtils.pm, which contains common routines used by (almost) all the scripts. If these scripts are used elsewhere, VCSUtils.pm is the only additional file that needs to be copied with them. (VCSUtils.pm itself doesn't depend on anything else in WebKit as of r46669.) The only non-svn functionality they have now is that svn-apply is able to apply patches to either an svn or a git repository. (The other two scripts are still svn-only.) I'm not sure how this makes them WebKit-specific? Dave ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
