Re: [webkit-dev] Calling JavaScript function from within DumpRenderTree

2010-01-02 Thread Maciej Stachowiak


On Jan 1, 2010, at 9:25 PM, Sam Weinig wrote:



That said, a more javascripty way to do this would be to pass the  
function object to liveRegion.addNotificationListener itself.  That  
way, in the test file, you would have,


liveRegion.addNotificationListener(function(notification) {
   // do stuff with notification
});

In the implementation of addNotificationListener, you would save the  
function object off instead of saving off the string, and then call  
it in _accessibilityNotificationCallback.


I would recommend doing it this second way. Note that with this  
approach you can still declare the function up front, and just pass  
the name, but you wouldn't pass it with a string.


 - Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Calling JavaScript function from within DumpRenderTree

2010-01-02 Thread Chris Fleizach

On Jan 2, 2010, at 1:34 AM, Maciej Stachowiak wrote:

 
 On Jan 1, 2010, at 9:25 PM, Sam Weinig wrote:
 
 
 That said, a more javascripty way to do this would be to pass the function 
 object to liveRegion.addNotificationListener itself.  That way, in the test 
 file, you would have,
 
 liveRegion.addNotificationListener(function(notification) {
   // do stuff with notification
 });
 
 In the implementation of addNotificationListener, you would save the 
 function object off instead of saving off the string, and then call it in 
 _accessibilityNotificationCallback.
 
 I would recommend doing it this second way. Note that with this approach you 
 can still declare the function up front, and just pass the name, but you 
 wouldn't pass it with a string.
 

I agree. I have it working with this method now. 

Thx
 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev