Re: [webkit-dev] Tests in fast/workers/storage/ seem to be leaking NSStrings
Thanks for the information, Simon. - Ryosuke On Sun, Oct 17, 2010 at 9:54 PM, Simon Fraser simon.fra...@apple.comwrote: This is https://bugs.webkit.org/show_bug.cgi?id=40654 which should get fixed by https://bugs.webkit.org/show_bug.cgi?id=40655. Simon On Oct 17, 2010, at 9:47 PM, Ryosuke Niwa wrote: A lot of tests in fast/workers/storage/ seem to have the following error message: 2010-10-17 21:17:04.268 DumpRenderTree[42509:bd9b] *** _NSAutoreleaseNoPool(): Object 0x218a8890 of class NSCFString autoreleased with no pool in place - just leaking Stack: (0x955d2f4f 0x954df432 0x252508d 0x5c4d18 0x1c50230 0x1c4d649 0x263ea0d 0x22edba0 0x1e3f3bc3 0x355eeb) See http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r69939%20(22816)/results.html for example. According to Catfish_Man: It means something is using Cocoa strings without proper setup, essentially. in a normal Cocoa app, NSApplication would set up a root autorelease pool that those would fall into. In something like DRT it would need to do so itself before using them. Is this a known problem? If not, can someone work on this issue? Best, Ryosuke Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Focus Crash Relating to MathML
On Sat, Oct 16, 2010 at 3:38 PM, Alex Milowski a...@milowski.org wrote: If anyone has any ideas of this bug: https://bugs.webkit.org/show_bug.cgi?id=47745 Even more curious is that I just noticed the crash only happens with a debug build. -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Focus Crash Relating to MathML
18.10.2010, в 12:33, Alex Milowski написал(а): https://bugs.webkit.org/show_bug.cgi?id=47745 Even more curious is that I just noticed the crash only happens with a debug build. The crash is an assertion failure, so it's not surprising that it only occurs in debug builds. Assertions aren't compiled into release builds. Sometimes, looking at svn blame to see when the assertion was added help one figure out what it is about. In general, asking a renderer-related question like isFocusable() needs finished layout indeed - e.g. display:none makes a node unfocusable, but before layout (recalcStyle?), the renderer doesn't know that. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Focus Crash Relating to MathML
On Mon, Oct 18, 2010 at 12:48 PM, Alexey Proskuryakov a...@webkit.org wrote: 18.10.2010, в 12:33, Alex Milowski написал(а): https://bugs.webkit.org/show_bug.cgi?id=47745 Even more curious is that I just noticed the crash only happens with a debug build. The crash is an assertion failure, so it's not surprising that it only occurs in debug builds. Assertions aren't compiled into release builds. OK. Less curious now! :) Sometimes, looking at svn blame to see when the assertion was added help one figure out what it is about. In general, asking a renderer-related question like isFocusable() needs finished layout indeed - e.g. display:none makes a node unfocusable, but before layout (recalcStyle?), the renderer doesn't know that. Yes, that makes sense. This has something to do with the inline flow. The whole problem goes away if you change the display property of the anchor to block. All the children are marked as not needing layout but the parent (the anchor) has m_normalChildNeedsLayout set to true. If you remove the MathML math element, everything works as expected. -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Adding Blob support to event.dataTransfer
I'm planning on adding experimental blob support to DataTransfer. I emailed WHATWG awhile back, and no one replied, so I picked what looked like the most appropriate option and I've implemented it. Does anyone have objections or comments on landing https://bugs.webkit.org/show_bug.cgi?id=47482 (once I fix the Windows build problem) Daniel ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Adding Blob support to event.dataTransfer
On Mon, 18 Oct 2010, Daniel Cheng wrote: I'm planning on adding experimental blob support to DataTransfer. I emailed WHATWG awhile back, and no one replied, so I picked what looked like the most appropriate option and I've implemented it. Does anyone have objections or comments on landing https://bugs.webkit.org/show_bug.cgi?id=47482 (once I fix the Windows build problem) Make sure that you vendor-prefix anything that isn't in the spec, so it won't conflict with the spec when it's added there. As it happens, I'm working on drag and drop hopefully this week. I'll probably be adding the new way to expose the types that was discussed a few months ago. :-) -- Ian Hickson U+1047E)\._.,--,'``.fL http://ln.hixie.ch/ U+263A/, _.. \ _\ ;`._ ,. Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.' ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Regarding cache memory leaks
I don't know if this is the use case but it should be noted that the CachedResourceLoader (the old DocLoader) never drops the CachedResource handles it has. This prevents resource deletion while the CachedResourceLoader is alive and kicking. This means that modifying the source of an img element from JS does not cause the old image to be released even though it is removed from the cache eventually. Andrei. On Mon, Oct 18, 2010 at 10:18 PM, Holger Freyther ze...@selfish.org wrote: On 10/18/2010 02:55 PM, sumanrap...@aim.com wrote: Hi Holger, Hi, (please keep the mailinglist in the loop) We have applied the patch(https://bug-44806-attachments.webkit.org/attachment.cgi?id=68154) to remove the deadResources, which is working fine. Because of this patch the duration to consume the entire available RAM has increased. But still the liveResources are not freeing, due to which its again consuming the entire available RAM. my time is limited right now so I can not help you in my spare time. But if the encoded data of the current page is more than fits into your RAM there is not much you can do, you can either wait to get killed by the kernel, or you can stop loading the page. Just imagine you would throw away images you have already downloaded, you would need to download them again.. in most cases where you have limited RAM you also have limited bandwidth... The two things that I can propose are: a) verify thay you are not leaking memory. Create a simple page, reload it in a loop, repaint it and see what happens to your memory... b) ask the Linux VM to overcommit memory and see how far you can push things. I just can't commit more of my spare time to look into memory usage of WebCore, I wish I could spend more time on WebKit... ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Focus Crash Relating to MathML
Most of the MathML rendering objects have a display style property value of inline-block. Whenever these rendering objects are used, somehow the parent container gets marked as having children in need of layout. The MathML math rendering object completes its layout and marks itself as not needing layout. In the end, the container (e.g. the anchor element) render object has itself in a state where m_normalChildNeedsLayout is true but no child is marked as needing layout. I've gone through the MathML rendering objects and remove all uses of markContaingBlocksForLayout() and setNeedsLayoutPrefWidthsRecalc() which generally cause the container to be marked with a child needing layout. These calls were unnecessary and the resulting code should be more efficient. In situations where the MathML does not contain a rendering object that is an inline-block, everything works fine. For example: a href='#' math xmlns='http://www.w3.org/1998/Math/MathML'mix/mi/math /a Keep in mind, in the above, the 'mi' element just uses RenderInline as it has no special semantics as of yet. In cases where specialized render objects (typically with display inline-block) are used (e.g. an operator), the assert fires: a href='#' math xmlns='http://www.w3.org/1998/Math/MathML'mox/mo/math /a At this point, I don't think my code is directly causing the anchor to get marked with a child needing layout. I do rely on RenderBlock::layout() within most of the rendering objects to handle the actual layout after adjustments. I've tried making sure that the parent or container schedule a re-layout but that hasn't really helped. You can see all these adjustments and optimizations in the patch for: https://bugs.webkit.org/show_bug.cgi?id=43462 Any ideas of what to look at next would be appreciated. -- --Alex Milowski The excellence of grammar as a guide is proportional to the paucity of the inflexions, i.e. to the degree of analysis effected by the language considered. Bertrand Russell in a footnote of Principles of Mathematics ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] disable selection of text and images
Hi I am totally new to this group. I want to disable selection of Text and graphics in my QWebView, it seems that there is no way via Qt i can do this , so only option I am left with is to modify webkit code. I am new to webkit code too, but I am willing to put my time and effort to do this, Can any one please suggest what file/function should I be modifying in webkit?? Or does any one has any other solution other than modifying webkit? I will highly appreciate any input on this. BR -- Efan Harris ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Regarding cache memory leaks
On Wed, Oct 13, 2010 at 9:00 PM, sumanrap...@aim.com wrote: Hi Holger, When we use the default cache model i.e 8MB cache size in this case it is storing the images beyond the 8MB that is untill complete RAM memory. How much memory do you have on your system. AFAICT, webkit would need ~80M to work with most of the large web pages. So we disabled the cache by using WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER even though the images and JS are storing in the Cache. We observed this by printing dumpStats output. Everything loaded in the current page gets to the cache first. The cache limit applies to pages other than the current page. Try loading a large page followed by a blank page and see if the cache limit is exceeded. Can you please suggest us how to disable the cache properly ? you can disable it (Cache.cpp - m_disabled = true), but it will not solve the above problem. If you have a limited RAM, you could devise other techniques like disabling bigger image loads and other page content (flash), handling near OOM/estimating memory usage of a page and stopping loads. check how other mobile browsers (opera mini, n95) behave with limited RAM for large pages. BTW are you using a mobile user agent? that would solve some of the problems with large pages, though not all. we are using webkit-1.2.3 and cross compiled for MIPS platform with gtk-directfb backend. Thanks In Advance. Thanks, Suman -Original Message- From: webkit-dev-request webkit-dev-requ...@lists.webkit.org To: webkit-dev webkit-dev@lists.webkit.org Sent: Mon, 11 Oct 2010 7:30 pm Subject: webkit-dev Digest, Vol 65, Issue 12 Send webkit-dev mailing list submissions to webkit-dev@lists.webkit.org To subscribe or unsubscribe via the World Wide Web, visit http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev or, via email, send a message with subject or body 'help' to webkit-dev-requ...@lists.webkit.org You can reach the person managing the list at webkit-dev-ow...@lists.webkit.org When replying, please edit your Subject line so it is more specific than Re: Contents of webkit-dev digest... Today's Topics: 1. Regarding cache memory leaks (sumanrap...@aim.com) 2. Re: Regarding cache memory leaks (Holger Freyther) 3. Tiger? (Adam Barth) -- Message: 1 Date: Sun, 10 Oct 2010 12:37:46 -0400 (EDT) From: sumanrap...@aim.com To: webkit-dev@lists.webkit.org Subject: [webkit-dev] Regarding cache memory leaks Message-ID: 8cd36b09a73f4e9-1380-26...@webmail-d112.sysops.aol.com Content-Type: text/plain; charset=us-ascii Dear All, We are working on webkitGtk ( with gtk-directfb backend ) and ported for MIPS platform. We observed there are memory leaks with PNG/JPG image rendering. I am using webkit-1.2.3 version and I set cache model to WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER. When I am printing the dumpStats I could able to see the Image count and live decoded image sizes. Even I disabled the cache it is storing on to cache. could you please suggest me is there any patch to avoid image related memory leaks with webkitGtk. Please help me on this. Thanks In Advance. -- next part -- An HTML attachment was scrubbed... URL: http://lists.webkit.org/pipermail/webkit-dev/attachments/20101010/f451c9f4/attachment-0001.html -- Message: 2 Date: Sun, 10 Oct 2010 19:07:25 +0200 From: Holger Freyther ze...@selfish.org To: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Regarding cache memory leaks Message-ID: 4cb1f2cd.4050...@selfish.org Content-Type: text/plain; charset=ISO-8859-1 On 10/10/2010 06:37 PM, sumanrap...@aim.com wrote: Dear All, When I am printing the dumpStats I could able to see the Image count and live decoded image sizes. Even I disabled the cache it is storing on to cache. could you please suggest me is there any patch to avoid image related memory leaks with webkitGtk. Please help me on this. How do you know it is leaked? If you are currently viewing these images you will most likely have the encoded and decoded version around. Do you have a test case to show the memory leak? -- Message: 3 Date: Mon, 11 Oct 2010 01:26:34 -0700 From: Adam Barth aba...@webkit.org To: webkit-dev@lists.webkit.org Subject: [webkit-dev] Tiger? Message-ID: aanlkti=_ttwa60s5oamotjuu8qd3m4njq00ej2krk...@mail.gmail.com Content-Type: text/plain; charset=ISO-8859-1 I don't see a Tiger buildbot anymore. Does that mean I'm allowed to break the Tiger build? If so, can we rip out all the Tiger-specific code? Adam -- ___ webkit-dev mailing list webkit-dev@lists.webkit.org
