[webkit-dev] GTK+ 64 bits release bot maintenance
Hey, The GTK+ 64bit release bot is being moved to a faster machine, so it will be down for a few hours. It is currently not a core builder (though these days it is stable enough to go back to being one =D), so this should not cause any issues with the commit queue. The other 3 bots should be able to help with identifying test failures and build breakages while this one is down. I'll let you know when the bot is back, sorry for the short notice! Thanks! -- Gustavo Noronha Silva g...@gnome.org GNOME Project ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Tiger?
Ping? On Mon, Oct 11, 2010 at 9:26 AM, Adam Barth aba...@webkit.org wrote: I don't see a Tiger buildbot anymore. Does that mean I'm allowed to break the Tiger build? If so, can we rip out all the Tiger-specific code? Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Closing the loop on flaky tests (was Re: Flaky test hit list)
Thank you Adam. We should look into more options here, including some of the ones Maciej proposed. Alternatively, we could have just skipped the tests which are flaking so much. Alexey seemed to get CC'd on nearly every flake because they seemed to mostly be tests he wrote. :( -eric On Wed, Oct 20, 2010 at 6:01 PM, Adam Barth aba...@webkit.org wrote: I'll take care of it tonight. Adam On Wed, Oct 20, 2010 at 5:09 PM, Alexey Proskuryakov a...@webkit.org wrote: I'm still getting CC'ed by commit queue. Any objections to removing Bugzilla editbugs privilege from commit-queue until this is resolved? --- Comment #10 from WebKit Commit Bot commit-qu...@webkit.org 2010-10-20 17:01:11 PST --- The commit-queue encountered the following flaky tests while processing attachment 71284: transitions/transition-end-event-transform.html http/tests/appcache/fail-on-update-2.html Please file bugs against the tests. The author(s) of the test(s) have been CCed on this bug. The commit-queue is continuing to process your patch. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Tiger?
I discussed this with various folks in IRC and was told that answering this question is difficult w.r.t. Apple's need for confidentiality around some topics. Apparently, when folks are able to say something, they'll let us know. Adam On Thu, Oct 21, 2010 at 8:04 AM, Jeremy Orlow jor...@chromium.org wrote: Ping? On Mon, Oct 11, 2010 at 9:26 AM, Adam Barth aba...@webkit.org wrote: I don't see a Tiger buildbot anymore. Does that mean I'm allowed to break the Tiger build? If so, can we rip out all the Tiger-specific code? Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] OSX build break after system update
Quick PSA: if you install the Java for Mac OS X 10.6 Update 3 system update you may start getting build errors like: error: JavaVM/jni.h: No such file or directory The solution is to install Java for Mac OS X 10.6 Update 3 Developer Package from http://connect.apple.com Downloads Java [1]. Thanks andersca for the solution! -Tony [1] This link might work: http://connect.apple.com/cgi-bin/WebObjects/MemberSite.woa/wo/5.1.17.2.1.3.3.1.0.1.1.0.3.8.3.3.1 ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Add SelectionChange event for content editable regions
A patch has been submitted to https://bugs.webkit.org/show_bug.cgi?id=45712. - Ryosuke On Mon, Oct 11, 2010 at 6:21 PM, Ryosuke Niwa rn...@webkit.org wrote: On Mon, Oct 11, 2010 at 11:34 AM, Darin Adler da...@apple.com wrote: It seems that if our aim is to be compatible with the IE event, we should make our implementation as close to the IE one as possible. I’m not sure that firing the same event, but with a different target, will be good for compatibility. Is there some chance this could lead to a webpage that works in IE but fails in our engine, that would have worked fine if we used a different event name? The goal is to provide developers a way to detect selection change. The idea was that if we had multiple editable regions, developers often want to know which of those editable regions have the selection. Of course, they could walk the DOM upwards from the current selection to find the editable root but I can't think of cases where developers want to receive the document node as the target (maybe useful if we had multiple iframes with design mode on?) because they almost always have the access to the document node. I think that firing the same select event for editable areas in the document as for input and textarea elements might be a mistake, because the functions for querying and working with the selection are not uniform for those elements. Inside the engine we treat these much the same, but in the DOM API they are quite different. Agreed. Alex pointed out that it might be better to have an extra event property (e.g. webkitEditableRoot) that points to the editable root or other element and make target always point to the document node for compatibility. Do you like this design better? - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] webkit-patch --suggest-reviewers
Eric and I are working on a new feature of webkit-patch to make it easier for you to find reviewers for your code. When you upload a patch with webkit-patch, you can try passing the --suggest-reviewers option. webkit-patch will look at your patch and try to guess who might be good reviewers (and offer to CC them). This feature is very experimental, but I'd like to encourage you to give it a try and let us know what you think. At some point, we'd like to use this same idea in reverse and have a way to ask http://webkit.org/pending-review for patches that you might be the right person to review. Enjoy! Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] when is expose_event fired
Hi All, I am working on the Gtk port of webkit and using GtkLauncher for some experimentation and using a fairly recent WebKit version. I am trying to add some code in webkit_web_view_expose_event (in WebKit/gtk/webkit/webkitwebview.cpp) which basically finds all elements of a particular tag name, say h1, using getElementsByTagName(), change their style, paints them to a cairo image surface, and then changes them back to the original style - the additional code has been added after the existing code in the function which paints the changes to the gtk window. However, I wanted to know where and how is the webkit_web_view_expose_event function triggered internally - as I understand it could either be triggered from the windowing system if there is some movement /scrolling dragging of window or internally if something has changed and the page needs to be repainted - this second invocation path I am unable to find. Could someone point me to the right direction here ? Thanks for all your help.. Regards, Aneesh ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] when is expose_event fired
2010/10/22 Aneesh Bhasin contact.ane...@gmail.com: However, I wanted to know where and how is the webkit_web_view_expose_event function triggered internally - as I understand it could either be triggered from the windowing system if there is some movement /scrolling dragging of window or internally if something has changed and the page needs to be repainted - this second invocation path I am unable to find. Could someone point me to the right direction here ? You can invalidate an area of the widget with http://library.gnome.org/devel/gtk/stable/GtkWidget.html#gtk-widget-queue-draw-area or invalidate the whole widget with gtk_widget_queue_draw(). This will (eventually, not immediately) result in the widget receiving an expose event for the invalid area. -- Kalle Vahlman, z...@iki.fi Powered by http://movial.com Interesting stuff at http://sandbox.movial.com See also http://syslog.movial.fi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] when is expose_event fired
On Fri, Oct 22, 2010 at 2:10 PM, Aneesh Bhasin contact.ane...@gmail.com wrote: However, I wanted to know where and how is the webkit_web_view_expose_event function triggered internally - as I understand it could either be triggered from the windowing system if there is some movement /scrolling dragging of window or internally if something has changed and the page needs to be repainted - this second invocation path I am unable to find. Could someone point me to the right direction here ? The internal invalidation happens in WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp, in the various 'invalidate' methods. Those in turn are called from all over WebCore in various situations. Xan Thanks for all your help.. Regards, Aneesh ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
