[webkit-dev] Every build is crashing

2011-02-15 Thread Adam Barth
/me is sad

Since: 02/14/2011 13:13:56 (11 hours ago)

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r78502%20(25324)/http/tests/xmlhttprequest/cache-override-crash-log.txt

Thread 0 Crashed:  Dispatch queue: com.apple.main-thread
0   libSystem.B.dylib   0x7fe00951 __memcpy + 433
1   com.apple.WebCore   0x000101397315
WebCore::TextCodecUTF8::decode(char const*, unsigned long, bool, bool,
bool) + 773 (TextCodecUTF8.cpp:245)
2   com.apple.WebCore   0x000101301f44
WebCore::TextResourceDecoder::flush() + 100 (Vector.h:574)
3   com.apple.WebCore   0x000101374f7a
WebCore::XMLHttpRequest::didFinishLoading(unsigned long) + 90
(XMLHttpRequest.cpp:999)
4   com.apple.WebCore   0x0001008c645f
WebCore::DocumentThreadableLoader::loadRequest(WebCore::ResourceRequest
const, WebCore::SecurityCheckPolicy) + 623 (RetainPtr.h:69)
5   com.apple.WebCore   0x0001008c8260
WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document*,
WebCore::ThreadableLoaderClient*,
WebCore::DocumentThreadableLoader::BlockingBehavior,
WebCore::ResourceRequest const, WebCore::ThreadableLoaderOptions
const) + 496 (DocumentThreadableLoader.cpp:101)
6   com.apple.WebCore   0x0001008c89ab
WebCore::DocumentThreadableLoader::loadResourceSynchronously(WebCore::Document*,
WebCore::ResourceRequest const, WebCore::ThreadableLoaderClient,
WebCore::ThreadableLoaderOptions const) + 75 (PassRefPtr.h:58)
7   com.apple.WebCore   0x00010137344e
WebCore::XMLHttpRequest::createRequest(int) + 1646
(XMLHttpRequest.cpp:673)
8   com.apple.WebCore   0x000101374565
WebCore::XMLHttpRequest::send(WTF::String const, int) + 69
(XMLHttpRequest.cpp:544)
9   com.apple.WebCore   0x000101374a30
WebCore::XMLHttpRequest::send(int) + 32 (RefPtr.h:58)
10  com.apple.WebCore   0x000100fa2eed
WebCore::JSXMLHttpRequest::send(JSC::ExecState*) + 365 (RefPtr.h:42)
11  com.apple.WebCore   0x000100f9f177
WebCore::jsXMLHttpRequestPrototypeFunctionSend(JSC::ExecState*) + 119
(JSXMLHttpRequest.cpp:487)
12  ??? 0x25e36ca001b8 0 + 41658710229432
13  com.apple.JavaScriptCore0x00010016edca
JSC::Interpreter::execute(JSC::ProgramExecutable*, JSC::ExecState*,
JSC::ScopeChainNode*, JSC::JSObject*) + 538 (WriteBarrier.h:68)
14  ??? 0x000109c59700 0 + 4458911488
15  ??? 0x0001134afd70 0 + 4618648944
16  com.apple.JavaScriptCore0x0001001d2c40
JSC::JSFunction::~JSFunction() + 0 (JSFunction.cpp:105)
17  ??? 0x00841f0f 0 + 8658703
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] how to make the webkit open web faster?

2011-02-15 Thread fkwcowboy
nbsp;i want to konw which file is the ponit.
thanks ^ ^___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Every build is crashing

2011-02-15 Thread Alexey Proskuryakov

15.02.2011, в 00:04, Adam Barth написал(а):

 /me is sad
 
 Since: 02/14/2011 13:13:56 (11 hours ago)
 
 http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r78502%20(25324)/http/tests/xmlhttprequest/cache-override-crash-log.txt

This has been discussed on IRC when it started - everyone present seemed to be 
OK with that, and didn't want to revert. Please feel free to revert, of course.

This is tracked by https://bugs.webkit.org/show_bug.cgi?id=54418.

- WBR, Alexey Proskuryakov

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] what's the difference between Cache and PageCache in WebCore?

2011-02-15 Thread Aneesh Bhasin
Hi,

My answers inline...
PS : am keeping webkit-dev in the loop - this information may be
useful for others as well - or if I am wrong somewhere, others may
correct me..

2011/2/15 付文彬 fuwenbin2...@126.com

 Thanks for your help!

  I know the capacity of Resource Cache can be set according to method: 
 Cache::setCapacities, but Page Cache can only  be set the number of pages in 
 cache.
 Can you give me some suggestions for limit the total memory used by Page 
 Cache ?

Yes, the page cache can only be set in terms of the number of pages-
due to the nature of data it stores, it will be difficult and
impractical to have a memory-size limit on it. Depending on the
content of page being stored in PAge Cache, the actual memory used
will vary.

 And you said  low memory will come at an impact to the page-loading time. 
 What does page-loading time  mean?

Imagine having the Page cache switched off - that means every time you
press the 'back' button, the HTML will be parsed,  DOM tree will again
have to be constructed followed by the usual process of attachement
etc. This will increase the time it takes to display the page onscreen
- this is the 'page loading time' penalty I was referring to in my
earlier mail. Similar argument will also apply to Resource Cache as
well.

Hope that helps..

Regards,
Aneesh


 At 2011-02-15 14:13:10,Aneesh Bhasin contact.ane...@gmail.com wrote:

 Hi,

 Here's my understanding on this : There are two types of caches in WebKit : 
 Page Cache and Resource Cache.

 Resource Cache as the name suggests is to hold raw (e.g. CSS, JS etc.) as 
 well as decoded (e.g images) resources so that sites which share these 
 resources do not need to go to the network or even the network cache for 
 these resources. Of course, it also saves time spent in decoding of images. 
 You can limit the capacity (of complete cache as well as live and dead 
 resources) or turn it off completely.

 The other is the Page Cache which holds all the data structres used for 
 rendering the tree (DOM tree, render tree etc.) - used mainly to quickly 
 display the page during forward/backward navigation. Again, you can limit the 
 total memory used by this cache...

 Depending on your use-case, you can fiddle with the setting of these caches - 
 of course, low memory will come at an impact to the page-loading time.

 Hope that helps..

 Regards,
 Aneesh



 2011/2/15 付文彬 fuwenbin2...@126.com

 I want to reduce memory use of webkit,what can I do?


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] code review tool changes

2011-02-15 Thread Antonio Gomes
It absolutely does! Thanks Ojan ... this is a great tool.

On Tue, Feb 15, 2011 at 12:47 AM, Ojan Vafai o...@chromium.org wrote:

 shift+click can now be used to extend the context for a comment.
 http://trac.webkit.org/changeset/78530


 On Mon, Feb 14, 2011 at 4:27 PM, Ojan Vafai o...@chromium.org wrote:

 This behavior did change. But ctrl was never involved. If you ever clicked
 on a line next to an existing review comment line, it would expand to
 include it. The problem is that it's then difficult to leave comments on
 adjacent lines.

 You can still click and drag to expand the context though as long as you
 start inside the existing context. Alternately, adding ctrl (shift is
 probably better) to expand the context wouldn't be a difficult addition.

 Ojan


 On Mon, Feb 14, 2011 at 4:01 PM, Antonio Gomes toniki...@gmail.comwrote:

 Previously, I was able to increase the context of my inline review
 comments by clicking on consecutive line numbers while pressing CONTROL. It
 seems regressed. Am I the only one noticing that?


 --
  --Antonio Gomes






-- 
--Antonio Gomes
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Web Inspector blog post draft

2011-02-15 Thread Alexander Pavlov
A few edits have been applied to the text (thanks to everyone who
contributed!)

What is the official approval process for the Webkit blog posts? Should I
mark it as Pending Review?

On Wed, Feb 9, 2011 at 3:32 PM, Alexander Pavlov apav...@chromium.orgwrote:

 Hello everyone,

 I have put together a Web Inspector blog post draft (
 http://webkit.org/blog/?p=1463) concerning the latest style editing
 improvements. Please speak up if you think something should be changed,
 added, or removed.

 --
 Thanks,
 -alexander




-- 
-alexander
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Implementing the device element

2011-02-15 Thread Leandro Graciá Gil
Hi,

El 10 de febrero de 2011 15:15, Adam Bergkvist
adam.bergkv...@ericsson.comescribió:

 Hi,

 On 2011-02-09 22:10, Leandro Graciá Gil wrote:
  So, does that mean that a WebCore platform-independent code is going
  to determine if a new device handler should be created? I think that
  some UAs may like to, for example, keep a track of trusted pages for
  specific types of devices to determine if such a handler should be
  created. And that is not likely to be implemented in the same way by
  all the different platforms even if they intend to perform a set of
  basic common security steps. I completely agree with you that the
  behaviour should be consistent across platforms, especially the
  security and privacy aspects, but I don't think that forcing the
  common code to use available device lists is the way to do it. If we
  want a consistent behaviour we should ask for it in the specification
  and leave the implementation specific details open, not the other way
 around.
 

 Yes, the platform independent code in the device element will determine
 if a selection has been made, or altered, in the list of available devices
 Provided by the platform. Before passing it to the device element, the
 list can be filtered by the platform to exclude some entries for whatever
 reason. Selections can also be automatically applied without showing the
 Device selector based on, e.g., stored preferences. The device element
 will examine the list for selection changes to determine if a new device
 handler should be created (and a change event dispatched).

 Consider the following example:
 1. The user clicks the device element button and a list of devices is
   presented.
 2. The user selects a webcam in the list and clicks OK.
 *A new Stream is created*
 3. The user once again clicks the device element button and the list
   is presented with the webcam selected from before.
 4. The user clicks OK.
 *No new Stream is created*
 5. The user once again clicks the device element button and the list
   is presented with the webcam selected from before.
 6. The user selects a microphone in the list and clicks OK.
 *A new Stream is created*

 This is the behavior that should be consistent between ports.


I agree that this behavior should be consisted between ports. However, we
seem to be missing a case here: what happens if the user wants to revoke
access to a device in the middle of a streaming session? We need to be able
to allow this case for obvious privacy reasons.

We need a way to let the UA maintain the lifetime of Stream objects. These
can be killed by the UA at any point (perhaps due to user action or hardware
failure), so we need to specify what happens to these objects in such a
case. We also need to design our implementation in a way that can handle
this situation.

As far as I know, and please correct me if I'm wrong, your proposed design
doesn't provide the user a clear way to invalidate a stream if he wants to.
The Stream's lifetime is something completely handled by the
platform-specific client and with no presence at all in the common WebCore
code. We think this should also be an essential part of the common behaviour
across platforms.

Because of this reason we would like to raise this discussion to the
specification level in the whatwg list. We think that the expected behaviour
for the device element is something that still needs to be discussed before
facing any implementation-specific details.



  One important point that a selection-based design misses is that
  potentially many devices, if not all, will require exclusive access to
  them. Let me give a example. We have two different pages with device
  elements. First, a user selects some device (e.g. a microphone) in the
  first page, but the page makes no use of it for the moment and hence
  the real connection is not performed. Minutes later and without
  closing the first page, the same user selects the same device from
  before on the second device element (if you have only one microphone
  and an average user this could be very easy to happen) but this page
  also makes no use for it at that moment. What happens if for example
  the first page starts making use of the device and causes the
  connections on the second page to fail? This is almost for sure not
  the behaviour that the user is expecting or wanting.
 

 It will be up to the device handler API (e.g. Stream) and its potential
 consumers to handle any errors that may occur. Exclusiveness for certain
 types of devices being one type of error. Another error occurs when a
 peripheral device is disconnected while in use. Even if you have
 established a connection to the device via the device element,
 handling such an error in the device handler API is still required since
 it is not possible to revoke a device handler instance.


I think this impossibility to revoke a device handler instance is currently
the essence of our main divergence point, and something that should be
discussed 

Re: [webkit-dev] Web Inspector blog post draft

2011-02-15 Thread Darin Adler
On Feb 15, 2011, at 8:05 AM, Alexander Pavlov wrote:

 A few edits have been applied to the text (thanks to everyone who 
 contributed!)
 
 What is the official approval process for the Webkit blog posts? Should I 
 mark it as Pending Review?

I don’t think we have any approval process. You could double check that with 
Maciej.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Line box tree converting from int - float

2011-02-15 Thread David Hyatt
https://bugs.webkit.org/show_bug.cgi?id=54244

A patch is on its way that is going to be converting the line box tree from 
being int-based to being float-based.  All of the rounding hacks for word 
rounding and run rounding when measuring and drawing text will be eliminated.

The unfortunate side effect of such a patch, however, is that many many layout 
test results are changing on Mac (and I will be updating those test results).  
The effects on ports that use integer advances for glyphs should be minimal.  
If your platform has been returning non-integral values for advances, however, 
then expect many test results on your platform to change because of the 
improved precision.

dave
(hy...@apple.com)

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Every build is crashing

2011-02-15 Thread Adam Barth
On Tue, Feb 15, 2011 at 1:11 AM, Alexey Proskuryakov a...@webkit.org wrote:
 15.02.2011, в 00:04, Adam Barth написал(а):
 /me is sad

 Since: 02/14/2011 13:13:56 (11 hours ago)

 http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r78502%20(25324)/http/tests/xmlhttprequest/cache-override-crash-log.txt

 This has been discussed on IRC when it started - everyone present seemed to 
 be OK with that, and didn't want to revert. Please feel free to revert, of 
 course.

 This is tracked by https://bugs.webkit.org/show_bug.cgi?id=54418.

I must have missed that discussion.  Maybe we should note these things
in the #webkit channel topic?  In any case, it looks to have been
cleared up.

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Every build is crashing

2011-02-15 Thread Peter Kasting
On Tue, Feb 15, 2011 at 11:23 AM, Adam Barth aba...@webkit.org wrote:

  This has been discussed on IRC when it started - everyone present seemed
 to be OK with that, and didn't want to revert. Please feel free to revert,
 of course.

 I must have missed that discussion.  Maybe we should note these things
 in the #webkit channel topic?


FWIW, there wasn't really much chatter -- I noted that I'd found a crash in
a Chromium build, Alexey told me to feel free to revert if needed, and I
said that I already had a crash suppression in for Chromium and a bug on
file, so I wasn't too worried.

I didn't know other builds were crashing, and I don't think many other
people were around at the time, so it's possible other folks would have
wanted to revert then.  Sorry!

In any case, it looks to have been
 cleared up.


Yep, thanks to Antti, Andreas and anyone else involved for the quick fix.

PK
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Web Inspector blog post draft

2011-02-15 Thread Maciej Stachowiak

We don't have any approval process.

 - Maciej

On Feb 15, 2011, at 10:16 AM, Darin Adler wrote:

 On Feb 15, 2011, at 8:05 AM, Alexander Pavlov wrote:
 
 A few edits have been applied to the text (thanks to everyone who 
 contributed!)
 
 What is the official approval process for the Webkit blog posts? Should I 
 mark it as Pending Review?
 
 I don’t think we have any approval process. You could double check that with 
 Maciej.
 
-- Darin
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev