Re: [webkit-dev] NEW XML Parser
I am using webkitgtk port On Mon, Sep 5, 2011 at 9:58 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Mon, Sep 5, 2011 at 3:08 AM, Sireesha Janakiraman sireesha.j...@gmail.com wrote: Hello all, I am newbie to webkit. I am trying to use new xml parser for one of use case. I see ENABLE(NEW_XML) check to get the new functionality , but it is not defined in configure script. Is there a way I can use new_xml parser in webkit. What port of webkit are you using? regards, Lucas De Marchi ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Hyphenation in webkit
Hello, I tried hyphenation test files in webkit. a)'http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphens.html' b) http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphenate-character.html via GtkLauncher in webkitgtk1.5.2 I don't see hyphenation results. I tried setting locale to english and verified my system locale is same as set in -webkit-locale. Is hyphenation working in latest build? ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Hyphenation in webkit
Hello, I tried hyphenation test files in webkit. a)'http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphens.html' b) http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphenate-character.html via GtkLauncher in webkitgtk1.5.2 I don't see hyphenation results. I tried setting locale to english and verified my system locale is same as set in -webkit-locale. Is hyphenation working in latest build? Regards, Siri ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] unsigned versus size_t in WTFString.h
Hi Adam, Yes, I believe our current thinking is that the external interface to String lengths / indices should all be in size_t (though unless we believe we need to support strings 4GB we should keep the length stored as a 32 bit value internally). There are a couple of bugzilla bugs relevant, though I don't think either currently capture exactly this. https://bugs.webkit.org/show_bug.cgi?id=49637 https://bugs.webkit.org/show_bug.cgi?id=60279 cheers, G. On Sep 6, 2011, at 9:12 PM, Adam Barth wrote: I wanted to confirm my understanding before going too far off into the woods: Most of the uses of unsigned in WTFString.h should really be size_t, right? http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/text/WTFString.h For example, unsigned length() const should be size_t length() const and size_t find(UChar c, unsigned start = 0) const should be size_t find(UChar c, size_t start = 0) const (Obviously some, like static String number(unsigned), should stay as unsigned.) Thanks, Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] unsigned versus size_t in WTFString.h
Thanks Gavin. This guidance is very helpful. Adam On Wed, Sep 7, 2011 at 2:38 AM, Gavin Barraclough barraclo...@apple.com wrote: Hi Adam, Yes, I believe our current thinking is that the external interface to String lengths / indices should all be in size_t (though unless we believe we need to support strings 4GB we should keep the length stored as a 32 bit value internally). There are a couple of bugzilla bugs relevant, though I don't think either currently capture exactly this. https://bugs.webkit.org/show_bug.cgi?id=49637 https://bugs.webkit.org/show_bug.cgi?id=60279 cheers, G. On Sep 6, 2011, at 9:12 PM, Adam Barth wrote: I wanted to confirm my understanding before going too far off into the woods: Most of the uses of unsigned in WTFString.h should really be size_t, right? http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/text/WTFString.h For example, unsigned length() const should be size_t length() const and size_t find(UChar c, unsigned start = 0) const should be size_t find(UChar c, size_t start = 0) const (Obviously some, like static String number(unsigned), should stay as unsigned.) Thanks, Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] RefPtr/PassRefPtr Question
On Sep 6, 2011, at 6:24 PM, Maciej Stachowiak wrote: On Aug 31, 2011, at 3:31 PM, David Levin wrote: Ignore me. I'm missing the . I suppose if you want a RefPtr, then the style checker is wrong and the parameter should be allowed to be a RefPtr. Feel free to file a bug and I'll get to it (-- it may take me a week or two at the moment). It should definitely be allowed - it's a good way to represent I need a T and I won't take ownership, but I want to guarantee that my caller is holding on to this. Yes. Also a good way to represent a RefPtr out parameter for a function with more than one return value. Also occasionally useful to make a function that conditionally takes ownership of something passed in. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Hyphenation in webkit
On Sep 7, 2011, at 2:28 AM, Sireesha Janakiraman wrote: Hello, I tried hyphenation test files in webkit. a)'http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphens.html' b) http://trac.webkit.org/browser/trunk/LayoutTests/fast/text/hyphenate-character.html via GtkLauncher in webkitgtk1.5.2 I don't see hyphenation results. I tried setting locale to english and verified my system locale is same as set in -webkit-locale. Is hyphenation working in latest build? The implementation of canHyphenate() in Hyphenation.cpp returns false. A port needs to provide alternate implementations of canHyphenate() and lastHyphenLocation() for hyphenation to work. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] WebKit datacenter move/upgrade notice! (offline 9/13)
Hello WebKit Developers, On Tuesday, September 13th, the WebKit datacenter will be offline for a short period of time. We expect it to be back up and running Wednesday, September 14th. During this time, all build/archive and test bots will be unavailable. The source repository will still be online and accessible during our upgrade. Thanks, Lucas ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit datacenter move/upgrade notice! (offline 9/13)
To be more precise, the APPLE build and test slaves will be offline. The Buildbot master will continue to run, and any non-Apple buildbot slaves will be just fine. Lucas On Sep 7, 2011, at 1:24 PM, Lucas Forschler wrote: Hello WebKit Developers, On Tuesday, September 13th, the WebKit datacenter will be offline for a short period of time. We expect it to be back up and running Wednesday, September 14th. During this time, all build/archive and test bots will be unavailable. The source repository will still be online and accessible during our upgrade. Thanks, Lucas ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] make-script-test-wrappers not being maintained
16.08.2011, в 17:45, Alexey Proskuryakov написал(а): I think that a style bot rule complaining about new files in script-tests directories (outside fast/js) would be great. If there are no new script tests, then there are no incorrectly prepared ones. I'm proposing a change for make-script-test-wrappers to only look inside fast/js in https://bugs.webkit.org/show_bug.cgi?id=66357. In next steps, I'd like to remove TEMPLATE.html files, and then merge most or all existing split tests into their .html files. Maciej has expressed concern that making people create monolithic script tests manually is undesirable. You need to find an existing script test, copy boilerplate, and fix the number of .. path components, which involves several annoying steps. I'm proposing a make-new-script-test script for that in https://bugs.webkit.org/show_bug.cgi?id=67747. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] make-script-test-wrappers not being maintained
07.09.2011, в 16:58, Ojan Vafai написал(а): IMO, it's only undesirable because of the current amount of boilerplate. We could change script test JS code so that the only boilerplate you need is: !DOCTYPE HTML script src=path/to/test-harness.js/script I don't care much personally, and only want to unblock https://bugs.webkit.org/show_bug.cgi?id=66357. Hopefully, this patch doesn't make it harder to improve the boilerplate later, and remove the script if its benefit seems too minor at this point. That said, I haven't personally created dump-as-markup tests, and don't know if it's potentially annoying to make those manually. We could go another way, and add an option to this script to create dump-as-markup tests if desired so. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] make-script-test-wrappers not being maintained
I've written a number of dump-as-markup tests, and I wouldn't see a need for a generator. So I'm inclined to support ojan's proposal here. - Ryosuke 2011/9/7 Alexey Proskuryakov a...@webkit.org 07.09.2011, в 16:58, Ojan Vafai написал(а): IMO, it's only undesirable because of the current amount of boilerplate. We could change script test JS code so that the only boilerplate you need is: !DOCTYPE HTML script src=path/to/test-harness.js/script I don't care much personally, and only want to unblock https://bugs.webkit.org/show_bug.cgi?id=66357. Hopefully, this patch doesn't make it harder to improve the boilerplate later, and remove the script if its benefit seems too minor at this point. That said, I haven't personally created dump-as-markup tests, and don't know if it's potentially annoying to make those manually. We could go another way, and add an option to this script to create dump-as-markup tests if desired so. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] make-script-test-wrappers not being maintained
07.09.2011, в 17:15, Alexey Proskuryakov написал(а): IMO, it's only undesirable because of the current amount of boilerplate. We could change script test JS code so that the only boilerplate you need is: !DOCTYPE HTML script src=path/to/test-harness.js/script I don't care much personally, and only want to unblock https://bugs.webkit.org/show_bug.cgi?id=66357. Hopefully, this patch doesn't make it harder to improve the boilerplate later, and remove the script if its benefit seems too minor at this point. On a second thought, I think that I would likely use the script myself even if the boilerplate was simpler. That's not all that's needed - you also need at least div id=console/div, var successfullyParsed = true;, and a few structural elements. Typing all that is difficult - and if you copy/paste, it doesn't really matter how much boilerplate there is. Also, making the boilerplate more complicated and dynamic can unexpectedly affect tests. - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] How does a *Prefix.h work on other platforms?
Hi, There are some *Prefix.h files that I guess are injected as header files into *.cpp files when compiling with xcode. I guess on other platforms they are just no use and the source files should include all necessary header files, right? However, a file in question is Tools/TestWebKitAPI/TestWebKitAPIPrefix.h which injects '#include gtest/gtest.h' the unit test source files which don't have the includes. AFAIK TestWebKitAPI works on Mac and Windows, but I haven't found anything in TestWebKitAPI.vcproj for injecting TestWebKitAPIPrefix.h into the source files. How does this work on Windows? Thanks, Xianzhu ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How does a *Prefix.h work on other platforms?
On 2011-09-07, at 21:22, Xianzhu Wang (王显著) wrote: Hi, There are some *Prefix.h files that I guess are injected as header files into *.cpp files when compiling with xcode. I guess on other platforms they are just no use and the source files should include all necessary header files, right? However, a file in question is Tools/TestWebKitAPI/TestWebKitAPIPrefix.h which injects '#include gtest/gtest.h' the unit test source files which don't have the includes. AFAIK TestWebKitAPI works on Mac and Windows, but I haven't found anything in TestWebKitAPI.vcproj for injecting TestWebKitAPIPrefix.h into the source files. How does this work on Windows? Tools/TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: ForcedIncludeFiles=TestWebKitAPIPrefix.h - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
