Re: [webkit-dev] Reg. New File Inclusion Style for Webkit
On Sun, Nov 20, 2011 at 1:57 AM, Arunprasad Rajkumar ararunpra...@gmail.com wrote: Why don't we follow chrome style of file inclusions rather than the usual. For example, *#include WebCore/Page/Chrome.h* This will be more convient way of representing the inclusion. Hope it will avoid long compiler inclusion paths and file namespace issues. Here are some pros and cons I can think of: Pros: * If used pervasively, would allow us to greatly trim the compiler include search paths, possibly providing a noticeable build speedup (I have no estimated numbers). * Makes it slightly more obvious to a reader what, precisely, is being depended upon; might make it easier to notice layering violations. Cons: * Would require us to convert the existing codebase (possibly easy with the help of a script, but would at least result in touching all the files) * Generates more change noise when a header is moved around * Could pose problems for ports that need to supply particular headers from some override directory instead of the typical spot. (I'm being vague here because I think this is probably a real issue but I don't actually know the details of enough ports' build setups to be clear.) I would prefer the full-path style myself, especially if there is really a build-time win, but I strongly suspect that a lot of folks would see the benefit here as not worth the cost. PK ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Simplifying hub classes (was Cleaning up directories in WebCore)
One traditional pattern is to split a big class into a set small classes plus a hub class like how Adam has done for original Frame. In that pattern, small classes has a reference to the hub class and know its API. I hope these small classes know just a small part of its hub class via interface (abstract class.) In that way, such classes can be unit-tested independently without instantiating the hub class, whose instantiation is typically a difficult job. Personally, I feel that we don't need category-like mixin mechanism for existing hub classes. Since we have just a few or dozen of instances of these classes and the size overhead from extra pointers is negligible. It isn't case for the node family though. -- morrita On Sun, Nov 20, 2011 at 2:23 AM, Adam Roben aro...@apple.com wrote: On Nov 18, 2011, at 5:55 PM, Adam Barth wrote: Really, SQL_DATABASE just wants to store some state per ScriptExecutionContext. It seems like there should be a way to do that without making a mess of ScriptExecutionContext. IMHO, we want something like the C++ equivalent of Objective-C categories. I'm not sure how best to achieve that. Note that ObjC categories don't allow you to add extra state (i.e., ivars) to classes. They only allow you to add extra methods. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- morrita ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Simplifying hub classes (was Cleaning up directories in WebCore)
On Sun, Nov 20, 2011 at 8:36 PM, Hajime Morrita morr...@google.com wrote: One traditional pattern is to split a big class into a set small classes plus a hub class like how Adam has done for original Frame. ^^^ The work to split up Frame was largely done before I was involved with the project. In that pattern, small classes has a reference to the hub class and know its API. I hope these small classes know just a small part of its hub class via interface (abstract class.) In that way, such classes can be unit-tested independently without instantiating the hub class, whose instantiation is typically a difficult job. Personally, I feel that we don't need category-like mixin mechanism for existing hub classes. Since we have just a few or dozen of instances of these classes and the size overhead from extra pointers is negligible. It isn't case for the node family though. -- morrita On Sun, Nov 20, 2011 at 2:23 AM, Adam Roben aro...@apple.com wrote: On Nov 18, 2011, at 5:55 PM, Adam Barth wrote: Really, SQL_DATABASE just wants to store some state per ScriptExecutionContext. It seems like there should be a way to do that without making a mess of ScriptExecutionContext. IMHO, we want something like the C++ equivalent of Objective-C categories. I'm not sure how best to achieve that. Note that ObjC categories don't allow you to add extra state (i.e., ivars) to classes. They only allow you to add extra methods. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- morrita ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Confusion over over-constrained case in RenderBox::computePositionedLogicalWidthUsing
Hi all, I'm currently studying layout code in RenderBox very carefully as I work on this: https://bugs.webkit.org/show_bug.cgi?id=47738 I'm a bit confused about something fairly subtle. In the overconstrained case where logical left, logical width, and logical right are all specified, we should ignore right (in ltr and left in rtl), correct? First a clarification please: is the logical left actually the right side of the box in rtl mode? Secondly, I'm confused about the availableSpace calculation (at line 2706 in my local branch): const LayoutUnit availableSpace = containerLogicalWidth - (logicalLeftValue + logicalWidthValue + logicalRight.calcValue(containerLogicalWidth) + bordersPlusPadding); Why is logicalRight.calcValue(containerLogicalWidth) in that computation at all? It seems to me that the available space for left/right margin (in ltr) is where the box is positioned relative to the left edge of the container box plus its content width + bordersPlusPadding. I can't figure out how logicalRight plays a role here. Could someone please clarify? In fact, a couple of lines above I see the following comment: // NOTE: It is not necessary to solve for 'right' in the over constrained // case because the value is not used for any further calculations. This seems to contradict the availableSpace line. Is this a stale comment or is this a bug, or am I just misunderstanding something? Thanks, Fady ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Adding ENABLE_STYLE_SCOPED for a while
Hi all, Since style scoped requires several patches to land fully, I intend to add a ENABLE_STYLE_SCOPED flag for a while to avoid potentially shipping half-done code. See https://bugs.webkit.org/show_bug.cgi?id=72848 for the flag, and https://bugs.webkit.org/show_bug.cgi?id=49142 for the master bug for style scoped. This flag will be off by default at first, switched on by default once everything has landed, and be removed not so long thereafter provided no serious issues crop up. Cheers, - Roland ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] WML build error
Hi All, I Enabled the WML Flag in r84325 Webkit version in \WebKitLibraries\win\tools\vsprops\FeatureDefines, but it's giving error like \page\Frame.cpp(113) : fatal error C1083: Cannot open include file: 'WMLNames.h': No such file or directory. WMLNames.h file is not generating, but WMLNames.cpp file is got generated. can any one successfully built this revision by enabling WML Flag...? From r85256, WML Completely removed from the trunk. Is any build related files got modified before r84325...? Hence this error...? Please help me resolving this error... Regards, Nataraj ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WML build error
WML has been removed. https://bugs.webkit.org/show_bug.cgi?id=59678 On Sun, Nov 20, 2011 at 11:17 PM, Nataraj Bukkambudi natarajb...@gmail.com wrote: Hi All, I Enabled the WML Flag in r84325 Webkit version in \WebKitLibraries\win\tools\vsprops\FeatureDefines, but it's giving error like \page\Frame.cpp(113) : fatal error C1083: Cannot open include file: 'WMLNames.h': No such file or directory. WMLNames.h file is not generating, but WMLNames.cpp file is got generated. can any one successfully built this revision by enabling WML Flag...? From r85256, WML Completely removed from the trunk. Is any build related files got modified before r84325...? Hence this error...? Please help me resolving this error... Regards, Nataraj ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WML build error
Dear Eric Seidel, Yes WML Code removed from Webcore trunk from r85256, but we are using * r84325*. But r84325 Windows build is giving the below error for us by enabling WML flag. I m suspecting some changes went wrong in WebCore\dom\make_names.pl for generating .h files that is WMLNames.h. Even in CSS also, some .h files are not generating. WMLNames.cpp, WMLElementFactory.cpp files generating fine in Windows build. Please can any one know hw to solve this error...? We are using WML for operator Compliance. Regards, Nataraj On Mon, Nov 21, 2011 at 12:55 PM, Eric Seidel e...@webkit.org wrote: There were several earlier discussions on the list, including: https://lists.webkit.org/pipermail/webkit-dev/2011-April/016445.html -eric On Sun, Nov 20, 2011 at 11:24 PM, Eric Seidel e...@webkit.org wrote: WML has been removed. https://bugs.webkit.org/show_bug.cgi?id=59678 On Sun, Nov 20, 2011 at 11:17 PM, Nataraj Bukkambudi natarajb...@gmail.com wrote: Hi All, I Enabled the WML Flag in r84325 Webkit version in \WebKitLibraries\win\tools\vsprops\FeatureDefines, but it's giving error like \page\Frame.cpp(113) : fatal error C1083: Cannot open include file: 'WMLNames.h': No such file or directory. WMLNames.h file is not generating, but WMLNames.cpp file is got generated. can any one successfully built this revision by enabling WML Flag...? From r85256, WML Completely removed from the trunk. Is any build related files got modified before r84325...? Hence this error...? Please help me resolving this error... Regards, Nataraj ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Nataraj, Samsung india, Bangalore. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
