Re: [webkit-dev] chromium image tests on lion
On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.com wrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
Chromium lacks a builder for Lion, so I expect there are likely many failures that noone has taken the time to look into. On Mon, Jan 9, 2012 at 1:05 AM, Jochen Eisinger joc...@chromium.org wrote: On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.comwrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
For those who want to follow along, I filed http://code.google.com/p/chromium/issues/detail?id=109637 for getting a Lion chromium bot running. On Mon, Jan 9, 2012 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Chromium lacks a builder for Lion, so I expect there are likely many failures that noone has taken the time to look into. On Mon, Jan 9, 2012 at 1:05 AM, Jochen Eisinger joc...@chromium.orgwrote: On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.comwrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium image tests on lion
Thanks Ojan. There is an older issue for this that I went ahead and starred: http://code.google.com/p/chromium/issues/detail?id=101398 Thanks all for the replies. Cheers, Jarred On Mon, Jan 9, 2012 at 1:41 PM, Ojan Vafai o...@chromium.org wrote: For those who want to follow along, I filed http://code.google.com/p/chromium/issues/detail?id=109637 for getting a Lion chromium bot running. On Mon, Jan 9, 2012 at 10:38 AM, Ojan Vafai o...@chromium.org wrote: Chromium lacks a builder for Lion, so I expect there are likely many failures that noone has taken the time to look into. On Mon, Jan 9, 2012 at 1:05 AM, Jochen Eisinger joc...@chromium.orgwrote: On Mon, Jan 9, 2012 at 7:47 AM, Simon Fraser simon.fra...@apple.comwrote: This could have been me: http://trac.webkit.org/changeset/104351 That changeset does not affect the chromium port -jochen Ideally we'd turn on mock scrollbars everywhere and then regenerate all the results (checking for actual failures). Not sure if I'll have time to do that though. Simon On Jan 7, 2012, at 8:44 AM, Jarred Nicholls wrote: Hey all, I'm running the layout tests for chromium on lion, and pretty much all of them is failing. LayoutTestHelper fails to set the generic RGB color profile, but after setting it manually the image diffs are very subtle (mostly around test rendering, but not too much on color). Related to Skia change and/or just outdated expectations? Given that Lion isn't a core test runner for chromium and it's been red since who knows when, I suppose this is to be expected for now. Appreciate any comments so I can safely overlook this, thanks! Jarred ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] chromium-cg-mac results
To update webkit-dev: chromium-cg-mac is now gone.
Thanks everyone,
Adam
On Wed, Jan 4, 2012 at 8:05 AM, Elliot Poger epo...@chromium.org wrote:
Filed https://bugs.webkit.org/show_bug.cgi?id=75548 ('[rollup] remove
chromium-cg-mac baselines')
On Wed, Jan 4, 2012 at 10:37 AM, Adam Barth aba...@webkit.org wrote:
On Wed, Jan 4, 2012 at 6:10 AM, Elliot Poger epo...@chromium.org wrote:
I agree that it is reasonable (and a good idea) to remove the
chromium-cg-mac expectations from WebKit now, and I am willing to take
the
lead on doing so (although I will need help from WebKit committers).
Sounds like a good plan. I'm happy to help. Let's coordinate off-list.
Thanks,
Adam
Please let me know if anyone agrees/disagrees with the following steps
to do
so:
1. remove the following buildbots that rely on chromium-cg-mac
expectations
(otherwise, they will start failing once the CG expectations disappear):
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder%20%28CG%29%28deps%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28CG%29%28deps%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder%20%28CG%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28CG%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac%20Builder%20%28CG%29%28dbg%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29%28dbg%29%281%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29%28dbg%29%282%29
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28CG%29%28dbg%29
2. remove the LayoutTests/platform/*-cg-* directories from the WebKit
repo
3. remove any CG-specific entries from
LayoutTests/platform/chromium/test-expectations.txt
4. remove any CG-specific test code from the Tools/Scripts/webkitpy tree
On Wed, Jan 4, 2012 at 12:01 AM, David Levin le...@chromium.org wrote:
On Tue, Jan 3, 2012 at 8:33 PM, Dirk Pranke dpra...@chromium.org
wrote:
On Tue, Jan 3, 2012 at 3:28 PM, Adam Barth aba...@webkit.org wrote:
On Tue, Jan 3, 2012 at 3:22 PM, Nico Weber tha...@chromium.org
wrote:
On Tue, Jan 3, 2012 at 3:00 PM, Adam Barth aba...@webkit.org
wrote:
It looks like Chromium Mac has successfully moved to Skia.
I'd wait with this assessment until a version of Chrome with Skia
has
shipped to stable. Things are looking really good so that should be
smooth sailing, but it's a bit early to say we're successfully
moved
:-)
Fair enough. However, I believe the Skia transition plan called for
removing the chromium-cg-mac expectation much earlier than a Skia
build shipping to stable. Originally, we were only supposed to have
to maintain both sets of expectations for about a month. The
transition has taken longer than expected, but it seems like we have
sufficient confidence in Skia now that we can remove the
chromium-cg-mac expectations.
Has the skia transition hit beta yet? It seems like as soon as we get
it onto a version that is pointing to a branched version of webkit, we
should be completely safe to remove the directories on trunk (frankly,
I'd agree with Adam that it's probably safe to remove it now, since we
can always add them back in if we have to, but I can compromise as
well).
Remove it.
It is a cost on everyone who enlists in WebKit. Those of us who aren't
creating new enlistments are not affected much but that doesn't mean it
isn't costly.
dave
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Moving WTF out of JavaScriptCore
We've been talking about moving WTF out of JavaScriptCore for a long time. We believe we're nearly there. https://bugs.webkit.org/show_bug.cgi?id=75673 This will mean that WTF will be built as a separate static library on all ports. The plan is to do this move all in one piece, after work hours PST, when the tree is least active. It won't be the most beautiful transition (as we're likely to break at least one port in the process), but we'll try not to make too much of a mess. We believe all the ports are ready for the move, except AppleWin: https://bugs.webkit.org/show_bug.cgi?id=75897 Once AppleWin is ready we'll schedule a date for the transition and announce it one this thread. Thanks! -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Asking for review by pinging bugs---another approach
Title: Samsung Enterprise Portal mySingle In new port case, for example EFL port, we unfortunately don't have special reviewer for our port yet.So, we have requested to review on IRC after finishing our informal review. If we only ask some reviewers to review, the reviewers will have too many review burden. We havefound proper reviewers on IRC in order to avoid this. In this case, is there better way to find proper reviewer for EFL port patch ? - gyuyoung. On Fri, Jan 6, 2012 at 3:40 AM, Adam Barth aba...@webkit.org wrote:Sure. Feel free to add that feature. Obviously we don't want to force people to use it, but it might become popular. AdamOn Jan 5, 2012 3:12 AM, "Hajime Morrita" morr...@chromium.org wrote:Does it make sense for webkit-patch post/upload to support "--ping" toacknowledge a set of reviewers using a specific form of comment? As areviewer, some kind of specific pattern would be helpful to filtersuch ping mails which contain, for example, "ping:morrita@". Maybe this can be taken as a step backward to the "by name" reviewrequest which we had declined. But at least for me, such kind offilterable mail would be gret tool to pick bugs for review. Eventhough this won't help some high-traffic reviewers, it won't hurt atleast. I've been overwhelmed by the stream of Bugzilla mail coming... What do you think? --morrita On Thu, Jan 5, 2012 at 5:03 PM, Andreas Kling kl...@webkit.org wrote: On Thu, Jan 5, 2012 at 7:49 AM, Adam Barth aba...@webkit.org wrote: Not to pick on anyone in particular, but when reading bugmail I occasionally see messages like "pinging for review." I review a lot of patches, but I don't find these messages particularly helpful because I don't know whether I'm supposed to review the patch. Another approach that might work better for you is to address your comment at someone in particular. For example, if the message says "Adam, can you please review this patch?", then there's a pretty good chance I'll click through and try to answer your question. If you're unsure who to ask for review, one approach is to look at the svn log for the files you're changing and see who has written/reviewed patches for those files recently. You can also ask folks who've been around the project for a while to suggest someone. True that. You can also find reviewers for a particular area here on the WebKit Team wiki page: http://trac.webkit.org/wiki/WebKit%20Team (and I encourage people to keep their entry up-to-date.) -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___webkit-dev mailing listwebkit-dev@lists.webkit.orghttp://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
