Re: [webkit-dev] check-webkit-style should remind folks to update the results for run-bindings-tests

2012-04-17 Thread Kentaro Hara
 Also note Maciej's proposal about moving it to a build step.

I am for this idea, but in that case maybe I want the option to ignore
run-bindings-tests in the build.

When we change CodeGenerator*.pm, we repeat try  error many times
until build succeeds. If we needed to update run-bindings-tests for
each try, that would be troublesome:)


On Mon, Apr 9, 2012 at 9:25 AM, Ryosuke Niwa rn...@webkit.org wrote:
 Also note Maciej's proposal about moving it to a build step.

 Either way, it shouldn't be ran as a test step on build bots.

 - Ryosuke


 On Mon, Apr 9, 2012 at 9:18 AM, Ryosuke Niwa rn...@webkit.org wrote:

 We have discussed this
 before: https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html

 A better change would be for us to generate the diff on EWS, and get rid
 of binding tests step from build bots since they aren't really testing
 anything. The primary use case of run-bindings-tests is to see the diff
 before/after a code generator change and it has no business running on the
 bot or in check-webkit-style.

 - Ryosuke

 On Mon, Apr 9, 2012 at 6:39 AM, Vineet Chaudhary rgf...@motorola.com
 wrote:

 Hi All,


 It is observed that if changes are made in Codegenerator*.pm we need to
 rebase results of run-bindings-tests.

 Many times authors forgot to update these binding results.


 IMO we should add check in ./check-webkit-style  to warn/(give a chance)
 author to run run-bindings-tests if Codegenerator is modified.

 I have filed bug for this https://bugs.webkit.org/show_bug.cgi?id=83354 .


 Please let me know if any suggestions to make this change.


 Thanks,
 Vineet


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev




-- 
Kentaro Hara, Tokyo, Japan (http://haraken.info)
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


[webkit-dev] Feature announcement: Font Boosting

2012-04-17 Thread John Mellor
Hi webkit-dev,

You may have heard http://youtu.be/aCdZIHBbRV0?t=1m26s that Chrome for
Android includes a Font Boosting feature. This is similar in intent to
the text size 
adjusthttp://developer.apple.com/library/ios/DOCUMENTATION/AppleApplications/Reference/SafariWebContent/AdjustingtheTextSize/AdjustingtheTextSize.html#//apple_ref/doc/uid/TP40006510-SW16feature
in Mobile Safari, that the QT port also seems
interested in http://webkit.org/b/73546. Other mobile browsers have
corresponding features: Mobile Firefox uses font
inflationhttp://dbaron.org/log/2026-font-inflationand IE Mobile
applies text
size 
adjustmenthttp://msdn.microsoft.com/en-us/library/ff462082(v=vs.92).aspx#sectionToggle2
.

Font Boosting increases the font size in wide blocks, so that you can
easily read the text after double-tapping to fit the block to the screen,
instead of having to zoom in further then scroll from side to side for each
line you read.

The details are subtle (since web text layout is complicated), and there's
still a lot of tweaking to do. We chose to boost font sizes more than
Mobile Safari (which has various limits), producing easily legible text,
more in line with IE Mobile and Firefox Mobile.

This is core functionality for mobile browsers, so we would like to
upstream our implementation of Font Boosting to WebCore. We are keen to
share code with other ports (e.g. QT and Mobile Safari) that are interested
in this feature, and will be happy to incorporate suggestions on how to
make this easier.

I've opened webkit.org/b/84186 to track this effort.

Best wishes,
John
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev