[webkit-dev] How to use local icon for Web Notification API?
Hi, All *html *js file are located in the local. And follow the instructions from http://www.html5rocks.com/en/tutorials/notifications/quick/ I take a try for showing a notification with local icon (URL: file:///x/icon.png) like: window.webkitNotifications.createnotification(file:///icon.png, Notification, some detail...).show(); I launched by $google-chrome --allow-file-access-from-files Notification can be shown but the icon is blank BTW, Icon can be shown if URL is a with http:// prefix. How to use local icon(file://) for web notification API? Please reply if you get any suggestion for that. Thanks. Ziv ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] How to use local icon for Web Notification API?
I'm afraid this is not an appropriate list to ask. You should try stackoverflow first. If you think there is a bug in chrome, try the chrome issue tracker. Only if you're sure that all webkit browsers are affected, submit a bug to the webkit tracker. On 15 May 2012 10:16, Li-Chung Chang clc...@gmail.com wrote: Hi, All *html *js file are located in the local. And follow the instructions from http://www.html5rocks.com/en/tutorials/notifications/quick/ I take a try for showing a notification with local icon (URL: file:///x/icon.png) like: window.webkitNotifications.createnotification(file:///icon.png, Notification, some detail...).show(); I launched by $google-chrome --allow-file-access-from-files Notification can be shown but the icon is blank BTW, Icon can be shown if URL is a with http:// prefix. How to use local icon(file://) for web notification API? Please reply if you get any suggestion for that. Thanks. Ziv ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] EFL Debug Buildbot Green
Hi, On 05/10/2012 06:43 PM, Dominik Röttsches wrote: We'll [...] set up a gardening schedule to keep it green and tidy in the future. The buildbot gardening schedule has been published here: https://trac.webkit.org/wiki/EFLWebKitBuildBots Regards, Dominik -- Dominik Röttschesdominik.rottsc...@intel.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Using namespace std
Hello webkit-dev I would like to bring up an issue in the style guide that I have run into and find a little odd. In my recent patch to compile WebKit using C++11 and GCC, I had to resolve a name conflict between global and std namespace. To do this you have to avoid expanding the full std namespace, that is avoiding the call 'using namespace std'. Unfortunately it seems the WebKit style guide and style-checking script requires that call instead of more precise and safe calls such as 'using std::'. The bug in question is https://bugs.webkit.org/show_bug.cgi?id=86465 and the same problem has been encountered before in https://bugs.webkit.org/show_bug.cgi?id=59249 The issue is not about these specific bugs though. First of all I do understand the rationale behind the rule to always expand the full 'std' namespace. To me it seems like an odd practice, so I would like to ask what original rationale behind that style guideline is, and if it would be acceptable to drop that rule? Best regards. `Allan ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] paged media update?
hi Just wanted to know if Milian and Dave Hyatt spoke about the paged media updates? In the next months I might also be able to find some resources to help but just wanting to know what the current plan is... adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] TransformationMatrix rotation code and floating-point precision
If it's computing theta/2, perhaps the trig formulas are for converting from a quaternion to a matrix? Does it look like the matrix in the quaternion section of this page? http://en.wikipedia.org/wiki/Rotation_operator_(vector_space) On Mon, May 14, 2012 at 10:30 PM, Shawn Singh shawnsi...@chromium.orgwrote: Hi all, I'm looking at TransformationMatrix::rotate3d(rx, ry, rz). This code does something indirect, and I don't understand why. Instead of initializing each rotation using sin(theta), cos(theta), the code computes theta/2, and then uses trig identities to initialize the rotation matrix. I checked really quickly with fprintf, and it seems like we could actually gain 1-2 bits of precision if we avoid doing this, and use sin(theta) and cos(theta) directly. In the current code, more error seems to accumulate due to sin^2 (theta / 2). Squaring that value instantly increases the error inherent in the computation. I cannot think of any valid reason that this code uses those trig identities instead of directly using sin and cos. Does anyone else know why? Is this worth changing to gain some precision? On a secondary note, its also fishy that we are freely mixing floats and doubles in the rotation code. But, I don't think that is as significant error accumulation as the sin^2. Thanks, ~Shawn ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Access to WebElements through WebKit2 Touch API
How can we get access in Webkit2 to all WebElements x/y coordinates for a given loaded HTML page. Our problem is that the information we want is in the DOM but the DOM does not seem accessible through the WebKit2 Touch API. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] TransformationMatrix rotation code and floating-point precision
OK, I will do that. Thanks! ~Shawn OK, I will do that. Thanks! ~Shawn On Mon, May 14, 2012 at 10:52 PM, Ryosuke Niwa rn...@webkit.org wrote: I don't know anything about transformation matrix, but that sounds like a pretty simple change. I would just upload a patch to make this change on bugs.webkit.org if I were you, and cc relevant people (use trac.webkit.org to see who has authored/reviewed patches in the relevant files). - Ryosuke On Mon, May 14, 2012 at 7:30 PM, Shawn Singh shawnsi...@chromium.orgwrote: I'm looking at TransformationMatrix::rotate3d(rx, ry, rz). This code does something indirect, and I don't understand why. Instead of initializing each rotation using sin(theta), cos(theta), the code computes theta/2, and then uses trig identities to initialize the rotation matrix. I checked really quickly with fprintf, and it seems like we could actually gain 1-2 bits of precision if we avoid doing this, and use sin(theta) and cos(theta) directly. In the current code, more error seems to accumulate due to sin^2 (theta / 2). Squaring that value instantly increases the error inherent in the computation. I cannot think of any valid reason that this code uses those trig identities instead of directly using sin and cos. Does anyone else know why? Is this worth changing to gain some precision? On a secondary note, its also fishy that we are freely mixing floats and doubles in the rotation code. But, I don't think that is as significant error accumulation as the sin^2. Thanks, ~Shawn ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] TransformationMatrix rotation code and floating-point precision
Nope, the matrices in the code are just basic rotations about x/y/z/ axes. On Tue, May 15, 2012 at 9:25 AM, Shawn Singh shawnsi...@google.com wrote: Nope, the matrices in the code are just basic rotations about x/y/z/ axes. ~Shawn On Tue, May 15, 2012 at 7:57 AM, W. James MacLean wjmacl...@chromium.orgwrote: If it's computing theta/2, perhaps the trig formulas are for converting from a quaternion to a matrix? Does it look like the matrix in the quaternion section of this page? http://en.wikipedia.org/wiki/Rotation_operator_(vector_space) On Mon, May 14, 2012 at 10:30 PM, Shawn Singh shawnsi...@chromium.orgwrote: Hi all, I'm looking at TransformationMatrix::rotate3d(rx, ry, rz). This code does something indirect, and I don't understand why. Instead of initializing each rotation using sin(theta), cos(theta), the code computes theta/2, and then uses trig identities to initialize the rotation matrix. I checked really quickly with fprintf, and it seems like we could actually gain 1-2 bits of precision if we avoid doing this, and use sin(theta) and cos(theta) directly. In the current code, more error seems to accumulate due to sin^2 (theta / 2). Squaring that value instantly increases the error inherent in the computation. I cannot think of any valid reason that this code uses those trig identities instead of directly using sin and cos. Does anyone else know why? Is this worth changing to gain some precision? On a secondary note, its also fishy that we are freely mixing floats and doubles in the rotation code. But, I don't think that is as significant error accumulation as the sin^2. Thanks, ~Shawn ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using namespace std
On May 15, 2012, at 5:48 AM, Allan Sandfeld Jensen wrote: To me it seems like an odd practice, so I would like to ask what original rationale behind that style guideline is Adding a list of using declarations like using std::min to the top of each source file would give us another ongoing maintenance job. The list in each file would grow, we’d not remember to remove them when they are no longer needed, and so on. Adding using namespace std to the top of a source file deals with 99% of the issue without the trouble of maintaining another list at the top of each file. When there is a conflict, there are typically many simple ways to resolve the conflict. Removing using namespace std entirely is not the only solution and we should avoid it if possible. I see in your patch in https://bugs.webkit.org/show_bug.cgi?id=86465 that you have decided to remove it from many files, and before we do that I suggest we first investigate the other solutions. Unfortunately your patch does not say what the conflict is; I can’t make a helpful suggestion for an alternate solution without that information. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Access to WebElements through WebKit2 Touch API
On May 15, 2012, at 8:24 AM, Webkit Research wrote: How can we get access in Webkit2 to all WebElements x/y coordinates for a given loaded HTML page. Our problem is that the information we want is in the DOM but the DOM does not seem accessible through the WebKit2 Touch API. This is the wrong mailing list for your question. This list is for discussion of development of WebKit itself among those contributing patches to the WebKit open source project. Others lists are enumerated at http://www.webkit.org/contact.html. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using namespace std
On Tue, May 15, 2012 at 9:31 AM, Darin Adler da...@apple.com wrote: On May 15, 2012, at 5:48 AM, Allan Sandfeld Jensen wrote: To me it seems like an odd practice, so I would like to ask what original rationale behind that style guideline is Adding a list of using declarations like using std::min to the top of each source file would give us another ongoing maintenance job. The list in each file would grow, we’d not remember to remove them when they are no longer needed, and so on. Given how little of std:: we actually use (since WTF is used instead for most things), what about just explicitly qualifying usages with std:: directly? I realize you probably feel like these sorts of qualifications make code less readable, but the impact of that seems minor to me -- the Chromium codebase gets away with doing it and uses std:: far more often than WebKit -- and it avoids the sort of maintenance headaches you mention. It also makes it clearer to a reader when we are actually pulling in types or functions from std:: (which might not always be what we wanted), and avoids any naming conflicts from pulling in the whole std:: namespace (which is apparently the reason for this thread). PK ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using namespace std
On May 15, 2012 10:53 AM, Peter Kasting pkast...@chromium.org wrote: On Tue, May 15, 2012 at 9:31 AM, Darin Adler da...@apple.com wrote: On May 15, 2012, at 5:48 AM, Allan Sandfeld Jensen wrote: To me it seems like an odd practice, so I would like to ask what original rationale behind that style guideline is Adding a list of using declarations like using std::min to the top of each source file would give us another ongoing maintenance job. The list in each file would grow, we’d not remember to remove them when they are no longer needed, and so on. Given how little of std:: we actually use (since WTF is used instead for most things), what about just explicitly qualifying usages with std:: directly? I realize you probably feel like these sorts of qualifications make code less readable, but the impact of that seems minor to me -- the Chromium codebase gets away with doing it and uses std:: far more often than WebKit -- and it avoids the sort of maintenance headaches you mention. It also makes it clearer to a reader when we are actually pulling in types or functions from std:: (which might not always be what we wanted), and avoids any naming conflicts from pulling in the whole std:: namespace (which is apparently the reason for this thread). Can we do that if and only if we have conflicts? An alternative solution is to forward conflicting symbols from std to WTF (i.e. make decisions about namespace in WTF) so that the rest of codebase can simply use the forwarded WTF symbols instead. We could even wrap whatever function we're using with a different name if we wanted. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Using namespace std
On Tue, May 15, 2012 at 11:37 AM, Ryosuke Niwa rn...@webkit.org wrote: On May 15, 2012 10:53 AM, Peter Kasting pkast...@chromium.org wrote: Given how little of std:: we actually use (since WTF is used instead for most things), what about just explicitly qualifying usages with std:: directly? Can we do that if and only if we have conflicts? Well, I guess we can do anything we want :). It might be nice to have a consistent rule though (much like the current style rule is consistent, if sometimes problematic). An alternative solution is to forward conflicting symbols from std to WTF (i.e. make decisions about namespace in WTF) so that the rest of codebase can simply use the forwarded WTF symbols instead. We could even wrap whatever function we're using with a different name if we wanted. From the bugs linked in the root post of this thread, it looks like the common offenders are std::min(), std::max(), and std::numeric_limits, with a guest appearance by std::make_pair(). It seems like either solution above -- explicitly qualifying usages of these, or forwarding them through WTF -- would probably work. One factor that makes me still favor the explicit qualification is that I've been burned enough by various compilers/environments defining min and max that anything that results in pulling those symbols into the global scope makes me anxious. PK ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] please add EditBugs permission
Can someone please add EditBugs permission for my bugs.webkit.org account (
epo...@chromium.org)?
Another WebKit committer and I both tried it, using the steps Eric pasted
in April, but it failed... I think maybe the add-users-to-groups tool is
broken?
$ Tools/Scripts/webkit-patch add-users-to-groups epo...@chromium.org
Add users matching epo...@chromium.org which groups?
1. canconfirm
2. editbugs
Enter one or more numbers (comma-separated), or all: all
bugs.webkit.org login: epo...@google.com
bugs.webkit.org password for epo...@google.com:
Logging in as epo...@google.com...
Traceback (most recent call last):
File Tools/Scripts/webkit-patch, line 69, in module
main()
File Tools/Scripts/webkit-patch, line 64, in main
WebKitPatch(os.path.abspath(__file__)).main()
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
line 311, in main
result = command.check_arguments_and_execute(options, args, self)
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
line 120, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py,
line 50, in execute
login_userid_pairs =
tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
line 257, in fetch_login_userid_pairs_matching_substring
return
EditUsersParser().login_userid_pairs_from_edit_user_results(results_page)
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
line 72, in login_userid_pairs_from_edit_user_results
login_userid_pairs = [self._login_and_uid_from_row(row) for row in
results_table('tr')]
TypeError: 'NoneType' object is not callable
On Thu, Apr 12, 2012 at 6:47 PM, Eric Seidel e...@webkit.org wrote:
Done.
% webkit-patch add-users-to-groups shezbaig...@gmail.com
Add users matching shezbaig...@gmail.com which groups?
1. canconfirm
2. editbugs
Enter one or more numbers (comma-separated), or all:
Reading Keychain for bugs.webkit.org account and password. Click
Allow to continue...
Logging in as e...@webkit.org...
Found 1 users matching shezbaig...@gmail.com:
shezbaig...@gmail.com (17597)
Are you sure you want add 1 users to groups ['canconfirm',
'editbugs']? (This action cannot be undone using webkit-patch.)
[Y/n]:
Adding shezbaig...@gmail.com to ['canconfirm', 'editbugs']
On Thu, Apr 12, 2012 at 3:17 PM, Shezan Baig shezbaig...@gmail.com
wrote:
Hello,
When I submit a patch to bugzilla, I get an error that EditBugs is not
set
on my account. Can someone add this permission to my bugzilla account
please? I sent a message to webkit-committ...@lists.webkit.org as
instructed, but that doesn't get through.
My login is: shezbaig...@gmail.com
My patch submitted to: https://bugs.webkit.org/show_bug.cgi?id=80382
Thanks,
Shezan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] please add EditBugs permission
You have to have EditUser permission to run that script. It should
bail out with a nicer message when you dont. :(
% Tools/Scripts/webkit-patch add-users-to-groups epo...@chromium.org
Add users matching epo...@chromium.org which groups?
1. canconfirm
2. editbugs
Enter one or more numbers (comma-separated), or all:
Reading Keychain for bugs.webkit.org account and password. Click
Allow to continue...
Logging in as e...@webkit.org...
Found 1 users matching epo...@chromium.org:
epo...@chromium.org (18143)
Are you sure you want add 1 users to groups ['canconfirm',
'editbugs']? (This action cannot be undone using webkit-patch.)
[Y/n]:
Adding epo...@chromium.org to ['canconfirm', 'editbugs']
Done.
On Tue, May 15, 2012 at 1:33 PM, Elliot Poger epo...@chromium.org wrote:
Can someone please add EditBugs permission for my bugs.webkit.org account
(epo...@chromium.org)?
Another WebKit committer and I both tried it, using the steps Eric pasted in
April, but it failed... I think maybe the add-users-to-groups tool is
broken?
$ Tools/Scripts/webkit-patch add-users-to-groups epo...@chromium.org
Add users matching epo...@chromium.org which groups?
1. canconfirm
2. editbugs
Enter one or more numbers (comma-separated), or all: all
bugs.webkit.org login: epo...@google.com
bugs.webkit.org password for epo...@google.com:
Logging in as epo...@google.com...
Traceback (most recent call last):
File Tools/Scripts/webkit-patch, line 69, in module
main()
File Tools/Scripts/webkit-patch, line 64, in main
WebKitPatch(os.path.abspath(__file__)).main()
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
line 311, in main
result = command.check_arguments_and_execute(options, args, self)
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py,
line 120, in check_arguments_and_execute
return self.execute(options, args, tool) or 0
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py,
line 50, in execute
login_userid_pairs =
tool.bugs.queries.fetch_login_userid_pairs_matching_substring(search_string)
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
line 257, in fetch_login_userid_pairs_matching_substring
return
EditUsersParser().login_userid_pairs_from_edit_user_results(results_page)
File
/usr/local/google/home/epoger/src/webkit/green/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py,
line 72, in login_userid_pairs_from_edit_user_results
login_userid_pairs = [self._login_and_uid_from_row(row) for row in
results_table('tr')]
TypeError: 'NoneType' object is not callable
On Thu, Apr 12, 2012 at 6:47 PM, Eric Seidel e...@webkit.org wrote:
Done.
% webkit-patch add-users-to-groups shezbaig...@gmail.com
Add users matching shezbaig...@gmail.com which groups?
1. canconfirm
2. editbugs
Enter one or more numbers (comma-separated), or all:
Reading Keychain for bugs.webkit.org account and password. Click
Allow to continue...
Logging in as e...@webkit.org...
Found 1 users matching shezbaig...@gmail.com:
shezbaig...@gmail.com (17597)
Are you sure you want add 1 users to groups ['canconfirm',
'editbugs']? (This action cannot be undone using webkit-patch.)
[Y/n]:
Adding shezbaig...@gmail.com to ['canconfirm', 'editbugs']
On Thu, Apr 12, 2012 at 3:17 PM, Shezan Baig shezbaig...@gmail.com
wrote:
Hello,
When I submit a patch to bugzilla, I get an error that EditBugs is not
set
on my account. Can someone add this permission to my bugzilla account
please? I sent a message to webkit-committ...@lists.webkit.org as
instructed, but that doesn't get through.
My login is: shezbaig...@gmail.com
My patch submitted to: https://bugs.webkit.org/show_bug.cgi?id=80382
Thanks,
Shezan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
