[webkit-dev] Time out issue (>30s) of WebKit layout test [Mac OS]

[Horky Chen]

Hi,

On Mac OS, if one time-out larger than 30s would be used, --time-out-ms cannot 
work well.

According to the run-webkit-tests script, custom Time-Out can be assigned for 
each test case. But, unfortunately, below line in LayoutTestControllerMac.mm 
blocked the setting if it is larger than 30s (waitUntilDone & notifyDone are 
used):
static const CFTimeInterval waitToDumpWatchdogInterval = 30.0;

That is hard code, and no parameter can be accepted to adjust it. There are two 
time-out settings for one test case, is it possible to use common time-out 
setting? 

Would you please help to double check about it? 

Best Regards!
Horky
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] build.webkit.org upgrade tonight @ 5pm

[Ryosuke Niwa]

All webkit.org have gotten so much faster after the upgrade. I think this
has improved my productivity to a whole new level.

Thanks a lot for making this improvement.

- Ryosuke

On Thu, Jun 28, 2012 at 5:30 PM, William Siegrist wrote:

> Buildbot is back up. The IP address changed, so if your DNS has not
> updated yet, it is at 17.251.224.66.
>
> -Bill
>
>
>
> On Jun 28, 2012, at 5:06 PM, Lucas Forschler  wrote:
>
> > The build.webkit.org upgrade is now in progress. Stay tuned.
> > Lucas
> >
> > On Jun 28, 2012, at 10:33 AM, Lucas Forschler wrote:
> >
> >> Just a reminder…
> >>
> >> We are transitioning build.webkit.org to new hardware tonight starting
> at 5pm.  build.webkit.org will be down during the transition.  I'll be on
> #webkit working with Bill to make sure the upgrade goes smoothly.  Please
> find me there if you have any questions.
> >>
> >> Lucas
> >>
> >> On Jun 26, 2012, at 2:59 PM, Lucas Forschler wrote:
> >>
> >>> Hello all,
> >>>
> >>> We are planning to upgrade our Buildbot infrastructure to new hardware
> on Thursday, June 28th.  We would like to start this process around 5pm.
>  During the transition, build.webkit.org will be down.  If all goes
> smoothly, there would be a downtime of around half an hour.  This could be
> longer if we discover problems.
> >>>
> >>> We are hoping the bot admins can be available to help bring the slaves
> back online if they do not automatically connect.  I'd like to know if this
> timeline will work for all of you.  If not, please let me know asap so we
> can plan a more convenient time.
> >>>
> >>> Thanks,
> >>> Lucas & Bill
> >>>
> >>>
> >>> ___
> >>> webkit-dev mailing list
> >>> webkit-dev@lists.webkit.org
> >>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >>
> >> ___
> >> webkit-dev mailing list
> >> webkit-dev@lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] build.webkit.org upgrade tonight @ 5pm

[William Siegrist]

Buildbot is back up. The IP address changed, so if your DNS has not updated 
yet, it is at 17.251.224.66. 

-Bill



On Jun 28, 2012, at 5:06 PM, Lucas Forschler  wrote:

> The build.webkit.org upgrade is now in progress. Stay tuned.
> Lucas
> 
> On Jun 28, 2012, at 10:33 AM, Lucas Forschler wrote:
> 
>> Just a reminder…
>> 
>> We are transitioning build.webkit.org to new hardware tonight starting at 
>> 5pm.  build.webkit.org will be down during the transition.  I'll be on 
>> #webkit working with Bill to make sure the upgrade goes smoothly.  Please 
>> find me there if you have any questions.
>> 
>> Lucas
>> 
>> On Jun 26, 2012, at 2:59 PM, Lucas Forschler wrote:
>> 
>>> Hello all,
>>> 
>>> We are planning to upgrade our Buildbot infrastructure to new hardware on 
>>> Thursday, June 28th.  We would like to start this process around 5pm.  
>>> During the transition, build.webkit.org will be down.  If all goes 
>>> smoothly, there would be a downtime of around half an hour.  This could be 
>>> longer if we discover problems.
>>> 
>>> We are hoping the bot admins can be available to help bring the slaves back 
>>> online if they do not automatically connect.  I'd like to know if this 
>>> timeline will work for all of you.  If not, please let me know asap so we 
>>> can plan a more convenient time.
>>> 
>>> Thanks,
>>> Lucas & Bill
>>> 
>>> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] build.webkit.org upgrade tonight @ 5pm

[Lucas Forschler]

The build.webkit.org upgrade is now in progress. Stay tuned.
Lucas

On Jun 28, 2012, at 10:33 AM, Lucas Forschler wrote:

> Just a reminder…
> 
> We are transitioning build.webkit.org to new hardware tonight starting at 
> 5pm.  build.webkit.org will be down during the transition.  I'll be on 
> #webkit working with Bill to make sure the upgrade goes smoothly.  Please 
> find me there if you have any questions.
> 
> Lucas
> 
> On Jun 26, 2012, at 2:59 PM, Lucas Forschler wrote:
> 
>> Hello all,
>> 
>> We are planning to upgrade our Buildbot infrastructure to new hardware on 
>> Thursday, June 28th.  We would like to start this process around 5pm.  
>> During the transition, build.webkit.org will be down.  If all goes smoothly, 
>> there would be a downtime of around half an hour.  This could be longer if 
>> we discover problems.
>> 
>> We are hoping the bot admins can be available to help bring the slaves back 
>> online if they do not automatically connect.  I'd like to know if this 
>> timeline will work for all of you.  If not, please let me know asap so we 
>> can plan a more convenient time.
>> 
>> Thanks,
>> Lucas & Bill
>> 
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] New WK2 tests bot for the GTK port

[Sergio Villar Senin]

Hi,

as you might have noticed in http://build.webkit.org, there is a new
64-bit release GTK bot since yesterday. That new bot was setup to run
the WebKit2 tests.

As the main focus of people involved in the GTK port development is
steadily moving to WebKit2, we see this as a must for the port. There is
still stuff to tune in the bot, but in general the main pieces are
ready, and this new bot will hopefully help a lot the WebKit2 development.

Thx to all that helped setting it up.

BR
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] build.webkit.org upgrade tonight @ 5pm

[Lucas Forschler]

Just a reminder…

We are transitioning build.webkit.org to new hardware tonight starting at 5pm.  
build.webkit.org will be down during the transition.  I'll be on #webkit 
working with Bill to make sure the upgrade goes smoothly.  Please find me there 
if you have any questions.

Lucas

On Jun 26, 2012, at 2:59 PM, Lucas Forschler wrote:

> Hello all,
> 
> We are planning to upgrade our Buildbot infrastructure to new hardware on 
> Thursday, June 28th.  We would like to start this process around 5pm.  During 
> the transition, build.webkit.org will be down.  If all goes smoothly, there 
> would be a downtime of around half an hour.  This could be longer if we 
> discover problems.
> 
> We are hoping the bot admins can be available to help bring the slaves back 
> online if they do not automatically connect.  I'd like to know if this 
> timeline will work for all of you.  If not, please let me know asap so we can 
> plan a more convenient time.
> 
> Thanks,
> Lucas & Bill
> 
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Feature announcement: webkit-patch patches-to-review

[Maciej Stachowiak]

On Jun 28, 2012, at 6:44 AM, Thiago Marcos P. Santos  
wrote:

> Hi WebKit,
> 
> "webkit-patch patches-to-review" was reworked [1] and now, instead of giving 
> you the list of attachment ID of all the patches pending review, it will give 
> you the list of bugs + description + age of patches pending review that has 
> you on the CC list. The age here stands for how long in days the patch is 
> waiting for review, not to the last time the bug was changed.
> 
> Example:
> 
> $ ./Tools/Scripts/webkit-patch patches-to-review
> Logging in as usern...@webkit.org...
> Bugs with attachments pending review that has usern...@webkit.org in the CC 
> list:
> http://webkit.org/b/bugid   Description (age in days)
> http://webkit.org/b/86310   [GStreamer] 
> media/media-continues-playing-after-replace-source.html fails (14)
> http://webkit.org/b/86615   [EFL][DRT] EFL DRT needs deletebutton controller 
> (17)
> http://webkit.org/b/82864   [EFL] LayoutTestController needs implementation 
> of setTabKeyCyclesThroughElements (29)
> http://webkit.org/b/84589   [EFL][DRT] Implementation of showModalDialog 
> needed (50)
> http://webkit.org/b/68511   [EFL] Script for running WebKit-EFL Unit Tests 
> (276)
> http://webkit.org/b/54373   CSS '+' combinator with more than 2 combinations 
> doesn't work (401)
> Total: 6
> $
> 
> Try "webkit-patch help patches-to-review" for few more options.
> 
> [1] https://bugs.webkit.org/show_bug.cgi?id=89470

Very cool. I wish we had a web page that gave that same info in a similarly 
compact and convenient form.

 - Maciej


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Let's use only 'ENABLE_CUSTOM_SCHEME_HANDLER' flag, and remove 'ENABLE_REGISTER_PROTOCOL_HANDLER' flag.

[Adam Barth]

In fact, the patch you posted in
https://bugs.webkit.org/show_bug.cgi?id=88614 breaks
registerProtocolHandler in Chromium because it disables the API.
Looking in more detail, to appears that the functions enabled by
CUSTOM_SCHEME_HANDLER aren't implemented by many ports, including
Chromium, which is likely why Chromium has the feature disabled.

Adam


On Thu, Jun 28, 2012 at 8:06 AM, Adam Barth  wrote:
> According to 
> ,
> Chromium currently enables REGISTER_PROTOCOL_HANDLER but not
> CUSTOM_SCHEME_HANDLER.  Until the Chromium project decides to ship
> CUSTOM_SCHEME_HANDLER, having two ENABLE flags is valuable.  Please do
> not combine the two flags until everyone wishes to set them to the
> same value.
>
> Adam
>
>
> On Thu, Jun 28, 2012 at 1:10 AM, DongWoo Im  wrote:
>> Dear WebKit!
>>
>>
>> There are two flags in WebKit - 'ENABLE_REGISTER_PROTOCOL_HANDLER' and 
>> 'ENABLE_CUSTOM_SCHEME_HANDLER'.
>> How about delete one of them?
>>
>>
>> There is a feature named "Custom Scheme Hander" in the W3C HTML5 spec. : 
>> http://dev.w3.org/html5/spec/Overview.html#custom-handlers
>> There are three APIs in the spec. - registerProtocolHandler, 
>> isProtocolHandlerRegistered, and unregisterProtocolHandler.
>> Those three APIs are implemented in WebKit already.
>>
>> But I think there is a problem.
>> The problem is, we are using two flags for the one spec.
>>   - 'registerProtocolHandler' function have been implemented behind the 
>> 'REGISTER_PROTOCOL_HANDLER' flag.
>>   - two other functions have been implemented behind the 
>> 'ENABLE_CUSTOM_SCHEME_HANDLER' flag.
>>
>>
>> I think this could make confusion.
>>
>> Why don't we use only one flag for the one spec which has only three APIs?
>> Let's use only one flag - 'ENABLE_CUSTOM_SCHEME_HANDLER' .
>>
>> I've filed that bug already - https://bugs.webkit.org/show_bug.cgi?id=88614.
>>
>>
>> What do you think about this?
>>
>>
>>
>>
>> BR,
>> Dongwoo.
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Let's use only 'ENABLE_CUSTOM_SCHEME_HANDLER' flag, and remove 'ENABLE_REGISTER_PROTOCOL_HANDLER' flag.

[Adam Barth]

According to 
,
Chromium currently enables REGISTER_PROTOCOL_HANDLER but not
CUSTOM_SCHEME_HANDLER.  Until the Chromium project decides to ship
CUSTOM_SCHEME_HANDLER, having two ENABLE flags is valuable.  Please do
not combine the two flags until everyone wishes to set them to the
same value.

Adam


On Thu, Jun 28, 2012 at 1:10 AM, DongWoo Im  wrote:
> Dear WebKit!
>
>
> There are two flags in WebKit - 'ENABLE_REGISTER_PROTOCOL_HANDLER' and 
> 'ENABLE_CUSTOM_SCHEME_HANDLER'.
> How about delete one of them?
>
>
> There is a feature named "Custom Scheme Hander" in the W3C HTML5 spec. : 
> http://dev.w3.org/html5/spec/Overview.html#custom-handlers
> There are three APIs in the spec. - registerProtocolHandler, 
> isProtocolHandlerRegistered, and unregisterProtocolHandler.
> Those three APIs are implemented in WebKit already.
>
> But I think there is a problem.
> The problem is, we are using two flags for the one spec.
>   - 'registerProtocolHandler' function have been implemented behind the 
> 'REGISTER_PROTOCOL_HANDLER' flag.
>   - two other functions have been implemented behind the 
> 'ENABLE_CUSTOM_SCHEME_HANDLER' flag.
>
>
> I think this could make confusion.
>
> Why don't we use only one flag for the one spec which has only three APIs?
> Let's use only one flag - 'ENABLE_CUSTOM_SCHEME_HANDLER' .
>
> I've filed that bug already - https://bugs.webkit.org/show_bug.cgi?id=88614.
>
>
> What do you think about this?
>
>
>
>
> BR,
> Dongwoo.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Feature announcement: webkit-patch patches-to-review

[Thiago Marcos P. Santos]

Hi WebKit,

"webkit-patch patches-to-review" was reworked [1] and now, instead of
giving you the list of attachment ID of all the patches pending review, it
will give you the list of bugs + description + age of patches pending
review that has you on the CC list. The age here stands for how long in
days the patch is waiting for review, not to the last time the bug was
changed.

Example:

$ ./Tools/Scripts/webkit-patch patches-to-review
Logging in as usern...@webkit.org...
Bugs with attachments pending review that has usern...@webkit.org in the CC
list:
http://webkit.org/b/bugid   Description (age in days)
http://webkit.org/b/86310   [GStreamer]
media/media-continues-playing-after-replace-source.html fails (14)
http://webkit.org/b/86615   [EFL][DRT] EFL DRT needs deletebutton
controller (17)
http://webkit.org/b/82864   [EFL] LayoutTestController needs implementation
of setTabKeyCyclesThroughElements (29)
http://webkit.org/b/84589   [EFL][DRT] Implementation of showModalDialog
needed (50)
http://webkit.org/b/68511   [EFL] Script for running WebKit-EFL Unit Tests
(276)
http://webkit.org/b/54373   CSS '+' combinator with more than 2
combinations doesn't work (401)
Total: 6
$

Try "webkit-patch help patches-to-review" for few more options.

[1] https://bugs.webkit.org/show_bug.cgi?id=89470

Enjoy.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Let's use only 'ENABLE_CUSTOM_SCHEME_HANDLER' flag, and remove 'ENABLE_REGISTER_PROTOCOL_HANDLER' flag.

[DongWoo Im]

Dear WebKit!


There are two flags in WebKit - 'ENABLE_REGISTER_PROTOCOL_HANDLER' and 
'ENABLE_CUSTOM_SCHEME_HANDLER'.
How about delete one of them?


There is a feature named "Custom Scheme Hander" in the W3C HTML5 spec. : 
http://dev.w3.org/html5/spec/Overview.html#custom-handlers
There are three APIs in the spec. - registerProtocolHandler, 
isProtocolHandlerRegistered, and unregisterProtocolHandler.
Those three APIs are implemented in WebKit already.

But I think there is a problem.
The problem is, we are using two flags for the one spec. 
   - 'registerProtocolHandler' function have been implemented behind the 
'REGISTER_PROTOCOL_HANDLER' flag.
   - two other functions have been implemented behind the 
'ENABLE_CUSTOM_SCHEME_HANDLER' flag.


I think this could make confusion.

Why don't we use only one flag for the one spec which has only three APIs?
Let's use only one flag - 'ENABLE_CUSTOM_SCHEME_HANDLER' .

I've filed that bug already - https://bugs.webkit.org/show_bug.cgi?id=88614.


What do you think about this?




BR, 
Dongwoo.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] How to run DumpRenderTree on MacOS in Xcode

[Horky Chen]

Hi,

I confused for this a minute ago. Put the testing file path to argument, it 
will run normally. Refer to step 4 in below link:
   http://trac.webkit.org/wiki/Debugging%20DumpRenderTree%20on%20Windows

Best Regards!
Horky
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev