date:20120802

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Ryosuke Niwa

On Thu, Aug 2, 2012 at 9:43 PM, Bruno Abinader wrote:
>
>  On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa  wrote:
> > Does the spec require to return new values in the computed style of
> > text-decoration property without authors specifying new text-decoration
> > properties and values?
> >
> > If not, then using text-decoration property is probably better because
> it'll
> > only affect those authors who have used new properties and values.
> >
> > - Ryosuke
> >
>
> If I got it right you are asking if it is necessary to designate
> values for all longhand properties from "text-decoration". The answer
> is no, based on what the specification says:
>
> "This property is a shorthand for setting ‘text-decoration-line’,
> ‘text-decoration-color’, and ‘text-decoration-style’ in one
> declaration. Omitted values are set to their initial values. A
> ‘text-decoration’ declaration that omits both the
> ‘text-decoration-color’ and ‘text-decoration-style’ values is
> backwards-compatible with CSS Levels 1 and 2."
>
> Speaking about it, I did finished a refactory on the "text-decoration"
> property that now becomes a shorthand (thus removing the necessity of
> having "-webkit-text-decoration" property), like CSS3 specifies.
> Though I haven't upstreamed it to Bugzilla yet, it is fully
> backwards-compatible with previous CSS specifications. I do have,
> however, a small set of questions to ask before publishing it for
> review:
>
> 1. I had a full layout test run and noticed a few test failures, but
> not exactly failures. The reason they failed is because the computed
> style expected something like "text-decoration: underline" and now it
> produces "text-decoration-line: underline". Is it ok to update the
> test expectations on these cases? IMO It doesn't makes sense having a
> shorthand property behaving like a longhand one anymore.
>

We need to be careful here. Computed styles are used in editing and markup
generated (including style attribute values) need to be understood properly
by old UAs. It's not sufficient that only WebKit with/without your patch
can parse it correctly.

- Ryosuke
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Bruno Abinader

Hi again,

On Thu, Aug 2, 2012 at 6:10 PM, Ryosuke Niwa  wrote:
> Does the spec require to return new values in the computed style of
> text-decoration property without authors specifying new text-decoration
> properties and values?
>
> If not, then using text-decoration property is probably better because it'll
> only affect those authors who have used new properties and values.
>
> - Ryosuke
>

If I got it right you are asking if it is necessary to designate
values for all longhand properties from "text-decoration". The answer
is no, based on what the specification says:

"This property is a shorthand for setting ‘text-decoration-line’,
‘text-decoration-color’, and ‘text-decoration-style’ in one
declaration. Omitted values are set to their initial values. A
‘text-decoration’ declaration that omits both the
‘text-decoration-color’ and ‘text-decoration-style’ values is
backwards-compatible with CSS Levels 1 and 2."

Speaking about it, I did finished a refactory on the "text-decoration"
property that now becomes a shorthand (thus removing the necessity of
having "-webkit-text-decoration" property), like CSS3 specifies.
Though I haven't upstreamed it to Bugzilla yet, it is fully
backwards-compatible with previous CSS specifications. I do have,
however, a small set of questions to ask before publishing it for
review:

1. I had a full layout test run and noticed a few test failures, but
not exactly failures. The reason they failed is because the computed
style expected something like "text-decoration: underline" and now it
produces "text-decoration-line: underline". Is it ok to update the
test expectations on these cases? IMO It doesn't makes sense having a
shorthand property behaving like a longhand one anymore.

2. The current WebKit implementation of "text-decoration" actually
parses the "blink" value, but does nothing with it later. On my
implementation I preserved the same behavior, but in order to avoid
complex parsing techniques I decided to treat it as a 4th bitwise
value of "text-decoration-line", which does not contemplates the
"blink" value on the CSS3 specification, but makes no harm since
nothing is done with it anyways.

Said this, I am going to suggest a change on the CSS3 specification of
"text-decoration", related to the "blink" value. But first, we need to
ask ourselves if this is really needed, it seems that only Firefox and
Opera implements this, and to not implement it satisfies the
checkpoint 3.3 of WAI-UAAG (
http://www.w3.org/TR/UAAG/guidelines.html#tech-on-off-blinking-text ).
I imagine two scenarios for this:

2.1 Abolish usage of "blink" value, since the same behavior is
achievable with rgba() alpha animation.

2.2 Make "blink" become a shorthand, not just a valid value inside
"text-decoration" property, so "text-property" acceptable values
become like this:
 ||  ||
 || 

Where "text-decoration-blink" would accept either "blink" or "fixed"
values, for example. In this approach, "text-decoration-blink" could
be even a shorthand property itself covering more complex instructions
like time delay between blinks, whether or not blinking animates or
only changes states from visible to hidden, etc.

I really ask for feedback on the questions above and appreciate your feedback!

Best regards,

-- 
Bruno de Oliveira Abinader
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Question about Floating-point operations base SH4 JIT

2012-08-02 Thread talking1239

Firstly, Thanks for your help.
I find that  describe() function  was call only in the 
Interpreter::dumpRegisters function, and dumpCallFrame will call the  
dumpRegisters , but i cann't find the place that call the  dumpCallFrame .


--

BGs/Felix Shi

At 2012-08-02 15:06:38,"Filip Pizlo"  wrote:
I would still suggest you look at the tag/payload ordering.  If it's flipped, 
you'll see this error.


Try using the describe() function in jsc in addition to using print().  That 
will do a dump of the internal structure of the JSValue.  If it's flipped, then 
you'll know where to look.



-F




On Aug 2, 2012, at 12:00 AM, 石梦军  wrote:


My platform use the  little-endian.  
 

--

BGs/Felix Shi

At 2012-08-02 14:51:48,"Filip Pizlo"  wrote:
What is the endianness of your platform?  I think that the big endian code in 
JavaScriptCore may have rotted.


This smells to me like the tag and payload getting flipped around, which might 
happen if there are parts of the code that are assuming little endian and your 
hardware is big endian.


-F






On Aug 1, 2012, at 11:47 PM, talking1...@gmail.com wrote:



Hi,

I have test with follow case, and cann't get correct reslut. I find that 
Floating-point operations  is error, and I don't know where shold start to 
fixed this question. so if anybody can give some information for which function 
i should to check. 




Any help explaining this would be much appreciated!




My Compiler:MSVS

ARCH:SH4

Feature:JIT







Javascript code of test case

function jitTestCode() {

  var tmp = -1*0;

  debug("tmp:" + tmp); 

  var result = tmp + 1;

  debug("The result should be 1,result:" + result);   //print

  var item1 =  result - 1;

  debug("The item1 should be 0,item1:" + item1); //print

  var item2 =  result - 2;

  debug("The item2 should be -1,item2:" + item2); //print

}

 

And the log information are:

[CONSOLE-DEBUG]Message is :'tmp:0'

[CONSOLE-DEBUG]Message is :'The result should be 1,result:0.0078125'

[CONSOLE-DEBUG]Message is :'The item1 should be 0,item1:0'

[CONSOLE-DEBUG]Message is :'The item2 should be -1,item2:-0.0078125'



--

BGs/Felix Shi





___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev







___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

2012-08-02 Thread Bruno Abinader

Hi again,

I too think so, but I thought it was a general rule to not make
non-prefixed properties follow candidate recommendation strictly. If
it is a general consensus that it is ok to accept prefixed keywords,
then I'll happily change the implementation to do so :)

On Wed, Aug 1, 2012 at 9:53 PM, Maciej Stachowiak  wrote:
>
> On Aug 1, 2012, at 4:36 PM, Elliott Sprehn  wrote:
>
>
> On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader 
> wrote:
>>
>> Hi all :)
>>
>> As suggested by Ojan, I am writing a mail to you about my intention to
>> implement all updated and missing text-decoration* properties from
>> CSS3 spec (currently in development), named below:
>>
>> -webkit-text-decoration ( https://bugs.webkit.org/show_bug.cgi?id=92000 )
>> CSS3 dev spec: http://dev.w3.org/csswg/css3-text/#text-decoration
>> Mozilla ref: https://developer.mozilla.org/en/CSS/text-decoration
>> Status: Proposed patch / pending review
>
>
> It seems weird to have a prefixed version of text-decoration instead of just
> making text-decoration allow the new prefixed keywords.
>
> What's the reason for having a whole new prefixed property?
>
>
> Making regular text-decoration accept prefixed keywords for the new/unstable
> tuff sounds like a good approach to me. I too am curious why that is not
> proposed.
>
>  - Maciej
>
>



-- 
Bruno de Oliveira Abinader
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Procedure for adding new blogs to the WebKit Planet

2012-08-02 Thread Peter Beverloo

On Thu, Aug 2, 2012 at 10:00 AM, Patrick Gansterer wrote:

> On Thu, 02 Aug 2012 10:53:30 +0200, Martin Robinson wrote:
>
>> Hi all,
>>
>> What's the procedure for adding a blog to the WebKit Planet? I often
>> post material interesting to some of the WebKit community, but not
>> suitable for Surfin' Safari since it is often specific to WebKitGTK+
>> or to just a subset of ports.
>>
>
> Change http://trac.webkit.org/**browser/trunk/Websites/planet.**
> webkit.org/config.inilet
>  it review. ;-)


Yup, feel free to do so :-). More updates about WebKit-related work always
is a good thing!

I've posted a patch for removing blogs which no longer are being updated
here, of course with the involved owners cc'ed:
https://bugs.webkit.org/show_bug.cgi?id=92973

Peter
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Procedure for adding new blogs to the WebKit Planet

2012-08-02 Thread Patrick Gansterer


Hi,

On Thu, 02 Aug 2012 10:53:30 +0200, Martin Robinson wrote:

Hi all,

What's the procedure for adding a blog to the WebKit Planet? I often
post material interesting to some of the WebKit community, but not
suitable for Surfin' Safari since it is often specific to WebKitGTK+
or to just a subset of ports.


Change 
http://trac.webkit.org/browser/trunk/Websites/planet.webkit.org/config.ini 
let it review. ;-)


-- Patrick
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Procedure for adding new blogs to the WebKit Planet

2012-08-02 Thread Martin Robinson

Hi all,

What's the procedure for adding a blog to the WebKit Planet? I often
post material interesting to some of the WebKit community, but not
suitable for Surfin' Safari since it is often specific to WebKitGTK+
or to just a subset of ports.

--Martin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Question about Floating-point operations base SH4 JIT

2012-08-02 Thread Filip Pizlo

I would still suggest you look at the tag/payload ordering.  If it's flipped, 
you'll see this error.

Try using the describe() function in jsc in addition to using print().  That 
will do a dump of the internal structure of the JSValue.  If it's flipped, then 
you'll know where to look.

-F


On Aug 2, 2012, at 12:00 AM, 石梦军  wrote:

> My platform use the  little-endian.  
>  
> --
> BGs/Felix Shi
> 
> At 2012-08-02 14:51:48,"Filip Pizlo"  wrote:
> What is the endianness of your platform?  I think that the big endian code in 
> JavaScriptCore may have rotted.
> 
> This smells to me like the tag and payload getting flipped around, which 
> might happen if there are parts of the code that are assuming little endian 
> and your hardware is big endian.
> 
> -F
> 
> 
> 
> On Aug 1, 2012, at 11:47 PM, talking1...@gmail.com wrote:
> 
>> Hi,
>> 
>> I have test with follow case, and cann't get correct reslut. I find that 
>> Floating-point operations  is error, and I don't know where shold start to 
>> fixed this question. so if anybody can give some information for which 
>> function i should to check. 
>> 
>> 
>> Any help explaining this would be much appreciated!
>> 
>> 
>> My Compiler: MSVS
>> 
>> ARCH:SH4
>> 
>> Feature: JIT
>> 
>> 
>> 
>> 
>> 
>> Javascript code of test case
>> 
>> function jitTestCode() {
>> 
>>   var tmp = -1*0;
>> 
>>   debug("tmp:" + tmp); 
>> 
>>   var result = tmp + 1;
>> 
>>   debug("The result should be 1,result:" + result);   //print
>> 
>>   var item1 =  result - 1;
>> 
>>   debug("The item1 should be 0,item1:" + item1); //print
>> 
>>   var item2 =  result - 2;
>> 
>>   debug("The item2 should be -1,item2:" + item2); //print
>> 
>> }
>> 
>>  
>> 
>> And the log information are:
>> 
>> [CONSOLE-DEBUG]Message is :'tmp:0'
>> 
>> [CONSOLE-DEBUG]Message is :'The result should be 1,result:0.0078125'
>> 
>> [CONSOLE-DEBUG]Message is :'The item1 should be 0,item1:0'
>> 
>> [CONSOLE-DEBUG]Message is :'The item2 should be -1,item2:-0.0078125'
>> 
>> 
>> --
>> BGs/Felix Shi
>> 
>> 
>> 
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Question about Floating-point operations base SH4 JIT

2012-08-02 Thread talking1239

My platform use the  little-endian.   


--

BGs/Felix Shi

At 2012-08-02 14:51:48,"Filip Pizlo"  wrote:
What is the endianness of your platform?  I think that the big endian code in 
JavaScriptCore may have rotted.


This smells to me like the tag and payload getting flipped around, which might 
happen if there are parts of the code that are assuming little endian and your 
hardware is big endian.


-F






On Aug 1, 2012, at 11:47 PM, talking1...@gmail.com wrote:



Hi,

I have test with follow case, and cann't get correct reslut. I find that 
Floating-point operations  is error, and I don't know where shold start to 
fixed this question. so if anybody can give some information for which function 
i should to check. 




Any help explaining this would be much appreciated!




My Compiler:MSVS

ARCH:SH4

Feature:JIT







Javascript code of test case

function jitTestCode() {

  var tmp = -1*0;

  debug("tmp:" + tmp); 

  var result = tmp + 1;

  debug("The result should be 1,result:" + result);   //print

  var item1 =  result - 1;

  debug("The item1 should be 0,item1:" + item1); //print

  var item2 =  result - 2;

  debug("The item2 should be -1,item2:" + item2); //print

}

 

And the log information are:

[CONSOLE-DEBUG]Message is :'tmp:0'

[CONSOLE-DEBUG]Message is :'The result should be 1,result:0.0078125'

[CONSOLE-DEBUG]Message is :'The item1 should be 0,item1:0'

[CONSOLE-DEBUG]Message is :'The item2 should be -1,item2:-0.0078125'



--

BGs/Felix Shi





___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

Re: [webkit-dev] Question about Floating-point operations base SH4 JIT

Re: [webkit-dev] Add support for CSS3 text-decoration* properties

Re: [webkit-dev] Procedure for adding new blogs to the WebKit Planet

Re: [webkit-dev] Procedure for adding new blogs to the WebKit Planet

[webkit-dev] Procedure for adding new blogs to the WebKit Planet

Re: [webkit-dev] Question about Floating-point operations base SH4 JIT

Re: [webkit-dev] Question about Floating-point operations base SH4 JIT

9 matches

Site Navigation

Mail list logo

Footer information