Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

[Elliott Sprehn]

On Fri, Dec 21, 2012 at 6:09 AM, Antti Koivisto  wrote:

> On Fri, Dec 21, 2012 at 3:33 AM, Tab Atkins Jr. wrote:
>
>> No, it's just a refactoring on the CSS side, so we don't have to
>> repeat a bunch of stuff every time we have an at-rule that contains
>> other rules.  It just makes the WebIDL easier and less error-prone.
>>
>
> It seems bit strange to add a web-exposed type if it is just a spec
> writing helper. Each new type has non-zero cost (code size of generated
> bindings etc).
>
> Internally it obviously makes sense to share code, I'm just wondering why
> we would want to expose this via API.
>
>
It means you can add methods to the prototype across all the types, and you
can override methods across the types per the way they're described in IDL.
It also provides instanceof for type checking in JS.

If we're not going to expose it and be spec compliant then perhaps we
should take that up with the spec as an objection and see if they're
willing to use a NoInterfaceObject instead.

- E
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Allan Sandfeld Jensen is now a WebKit reviewer!

[Levi Weintraub]

Congrats Allan! :)


On Fri, Dec 21, 2012 at 8:13 AM, Kenneth Rohde Christiansen <
kenneth.christian...@gmail.com> wrote:

> Congrats Allan!
>
> On Fri, Dec 21, 2012 at 5:09 PM, Turcotte Jocelyn <
> jocelyn.turco...@digia.com> wrote:
>
>>   Before joining WebKit a year ago, Allan was spending some of his free
>> time hacking on KHTML. Since then he has been contributing in various areas
>> of the Qt port, WebKit2 and WebCore, including touch adjustment and hit
>> testing.
>>
>> Please join me in congratulating Allan on his new role as a
>> WebKit reviewer!
>> - Jocelyn
>>
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo/webkit-dev
>>
>>
>
>
> --
> Kenneth Rohde Christiansen
> Senior Engineer, WebKit, Qt, EFL
> Phone  +45 4093 0598 / E-mail kenneth at webkit. org
>
> ﹆﹆﹆
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Allan Sandfeld Jensen is now a WebKit reviewer!

[Kenneth Rohde Christiansen]

Congrats Allan!

On Fri, Dec 21, 2012 at 5:09 PM, Turcotte Jocelyn <
jocelyn.turco...@digia.com> wrote:

>   Before joining WebKit a year ago, Allan was spending some of his free
> time hacking on KHTML. Since then he has been contributing in various areas
> of the Qt port, WebKit2 and WebCore, including touch adjustment and hit
> testing.
>
> Please join me in congratulating Allan on his new role as a
> WebKit reviewer!
> - Jocelyn
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
>


-- 
Kenneth Rohde Christiansen
Senior Engineer, WebKit, Qt, EFL
Phone  +45 4093 0598 / E-mail kenneth at webkit. org

﹆﹆﹆
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Allan Sandfeld Jensen is now a WebKit reviewer!

[Rafael Brandao]

Congrats Allan! :-)

On Fri, Dec 21, 2012 at 1:09 PM, Turcotte Jocelyn <
jocelyn.turco...@digia.com> wrote:

>   Before joining WebKit a year ago, Allan was spending some of his free
> time hacking on KHTML. Since then he has been contributing in various areas
> of the Qt port, WebKit2 and WebCore, including touch adjustment and hit
> testing.
>
> Please join me in congratulating Allan on his new role as a
> WebKit reviewer!
> - Jocelyn
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
>


-- 
Rafael Brandao @ INdT
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Allan Sandfeld Jensen is now a WebKit reviewer!

[Turcotte Jocelyn]

Before joining WebKit a year ago, Allan was spending some of his free time 
hacking on KHTML. Since then he has been contributing in various areas of the 
Qt port, WebKit2 and WebCore, including touch adjustment and hit testing.

Please join me in congratulating Allan on his new role as a WebKit reviewer!
- Jocelyn
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] CSSGroupingRule and a bit of refactoring?

[Antti Koivisto]

On Fri, Dec 21, 2012 at 3:33 AM, Tab Atkins Jr. wrote:

> No, it's just a refactoring on the CSS side, so we don't have to
> repeat a bunch of stuff every time we have an at-rule that contains
> other rules.  It just makes the WebIDL easier and less error-prone.
>

It seems bit strange to add a web-exposed type if it is just a spec writing
helper. Each new type has non-zero cost (code size of generated bindings
etc).

Internally it obviously makes sense to share code, I'm just wondering why
we would want to expose this via API.


   antti


>
> ~TJ
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev