Re: [webkit-dev] Test frame size for reftests
I opened a bug for the issue https://bugs.webkit.org/show_bug.cgi?id=115114. To be continued there. Cheers, Zoltan On Tue, Apr 23, 2013 at 11:45 AM, Zoltan Horvath zol...@webkit.org wrote: Yes, that be would the cleanest solution. If there is no concerns against it, I'm going to file a bug. Zoltan On Tue, Apr 23, 2013 at 11:36 AM, Benjamin Poulain benja...@webkit.orgwrote: Hi, On Tue, Apr 23, 2013 at 11:26 AM, Zoltan Horvath zol...@webkit.orgwrote: I was debugging a test which was passing in the testrunner, but failing in the testbrowser. It was because the reftests compare only in a 800*600px frame, although we have many tests which are taller than this frame. If there was a mismatch to the expected result outside that frame and the difference doesn't affect the scrollbar then the test just passes silently. Do we have any guidelines for these cases? We could either: 1. Split up the tests concerned. 2. Increase the test frame size to a bigger fixed value. (I'm thinking only in reftests.) 3. Generate the images for the actual view. (?) 4. ? Any thoughts? I am happy you are looking into this issue! This has been bothering me for a while :) The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the viewport. Maybe it could just be an API on testrunner? Like: testRunner.dumpEntirePagePixels()? Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the viewport. Maybe it could just be an API on testrunner? Like: testRunner.dumpEntirePagePixels()? What’s the downside of just doing this for all reftests? Would it make them slower? Would it cause failures? I’d love it if we could just do it without it having to be opt-in. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 9:55 AM, Darin Adler da...@apple.com wrote: On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the viewport. Maybe it could just be an API on testrunner? Like: testRunner.dumpEntirePagePixels()? What’s the downside of just doing this for all reftests? Would it make them slower? Would it cause failures? I’d love it if we could just do it without it having to be opt-in. Some ref-tests are designed so that only the part in the viewport maters. If I remember correctly, it is for testing things like fixed elements that are attached in the viewport. It would also make testing slower but I think we have some freedom to compensate for that. Maybe we could just fix the tests that would break by rendering everything. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wednesday 2013-04-24 09:55 -0700, Darin Adler wrote: On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the viewport. Maybe it could just be an API on testrunner? Like: testRunner.dumpEntirePagePixels()? What’s the downside of just doing this for all reftests? Would it make them slower? Would it cause failures? I’d love it if we could just do it without it having to be opt-in. Tests that rely on this wouldn't be sharable with other browsers or usable in W3C test suites, at least based on current practice. (I think we had some sort of agreement within some set of people involved with W3C reftests to use 800x600. Mozilla is currently using 800x1000, though I'd like to switch to the smaller size.) -David -- 턞 L. David Baron http://dbaron.org/ 턂 턢 Mozilla http://www.mozilla.org/ 턂 ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 10:30 AM, L. David Baron dba...@dbaron.org wrote: On Wednesday 2013-04-24 09:55 -0700, Darin Adler wrote: On Apr 23, 2013, at 11:36 AM, Benjamin Poulain benja...@webkit.org wrote: The current mode works fine for some ref-tests but is really annoying for others. I would love to have a way to compare the entire page instead of the viewport. Maybe it could just be an API on testrunner? Like: testRunner.dumpEntirePagePixels()? What’s the downside of just doing this for all reftests? Would it make them slower? Would it cause failures? I’d love it if we could just do it without it having to be opt-in. Tests that rely on this wouldn't be sharable with other browsers or usable in W3C test suites, at least based on current practice. (I think we had some sort of agreement within some set of people involved with W3C reftests to use 800x600. Mozilla is currently using 800x1000, though I'd like to switch to the smaller size.) I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Alexandru Chiculita is now a WebKit reviewer
I'm happy to announce that Alex is now a WebKit reviewer. Congratulations Alex! Alex has done a lot of work in CSS Filters, amongst other places. For those who want to see him in action, here is his recent presentation at W3Conf: http://achicu.github.com/css-presentation/ http://www.youtube.com/embed/D7gsp7RnDfc Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Alexandru Chiculita is now a WebKit reviewer
Awesome! Congratulations Alex! This is really great news. Greetings, Dirk On Apr 24, 2013, at 2:42 PM, Dean Jackson d...@apple.com wrote: I'm happy to announce that Alex is now a WebKit reviewer. Congratulations Alex! Alex has done a lot of work in CSS Filters, amongst other places. For those who want to see him in action, here is his recent presentation at W3Conf: http://achicu.github.com/css-presentation/ http://www.youtube.com/embed/D7gsp7RnDfc Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Alexandru Chiculita is now a WebKit reviewer
Kudos! -- Bye, Michelangelo On Apr 24, 2013, at 2:42 PM, Dean Jackson d...@apple.com wrote: I'm happy to announce that Alex is now a WebKit reviewer. Congratulations Alex! Alex has done a lot of work in CSS Filters, amongst other places. For those who want to see him in action, here is his recent presentation at W3Conf: http://achicu.github.com/css-presentation/ http://www.youtube.com/embed/D7gsp7RnDfc Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.org wrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? I've seen tests before that have lots of form controls where a bunch were outside the viewport. - E ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? I've seen tests before that have lots of form controls where a bunch were outside the viewport. Sure, you *can* write such tests. Did you *have to*? -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? I've seen tests before that have lots of form controls where a bunch were outside the viewport. Sure, you *can* write such tests. Did you *have to*? Certainly not, I just know such tests already exist. - E ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? I've seen tests before that have lots of form controls where a bunch were outside the viewport. Sure, you *can* write such tests. Did you *have to*? No, assuming he’s talking about fast/forms/basic-textareas.html added in http://trac.webkit.org/changeset/41690. As far as I know, the intent of the test was to make sure all those textareas are rendered correctly so we should be splitting the test into multiple pieces such that every textarea enumerated in the test is visible if any. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 3:35 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? I've seen tests before that have lots of form controls where a bunch were outside the viewport. Sure, you *can* write such tests. Did you *have to*? Certainly not, I just know such tests already exist. Right, so in the absence of tests that *need* bigger viewports, I'd side w/ David and say that we should fix tests to fit within 800x600 so that they are portable to other browsers and meet the W3C's criteria. Looking at the entire page would be a bad idea, as it would let us tolerate non-conformant tests. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Apr 24, 2013, at 3:45 PM, Dirk Pranke dpra...@chromium.org wrote: in the absence of tests that *need* bigger viewports, I'd side w/ David and say that we should fix tests to fit within 800x600 so that they are portable to other browsers and meet the W3C's criteria. Makes sense. I believe the 800x600 viewport makes it easy to accidentally write incorrect ref tests that look good when you read the HTML in the test file and the expected file, but are no good. It would be nice to find a simple way to spot flawed ref tests easily so even an inexperienced beginner will notice such mistakes. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
Definitely. If we had a test that needs to be only compared for what’s visible in its viewport, we can probably just use an iframe that’s 800x600 in most cases I can think of. Also, we can always add a new testRunner or internals method clip the output if we really need such a functionality. - R. Niwa On Wed, Apr 24, 2013 at 3:45 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Apr 24, 2013 at 3:35 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 3:31 PM, Dirk Pranke dpra...@chromium.orgwrote: On Wed, Apr 24, 2013 at 3:29 PM, Elliott Sprehn espr...@chromium.orgwrote: On Wed, Apr 24, 2013 at 11:11 AM, Dirk Pranke dpra...@chromium.orgwrote: ... I think this raises two related questions, both of which would be helped by concrete examples: 1) What sort of test are you writing where 800x600 isn't big enough to test what you need to test? 2) What sort of test are you writing where there's needs to be something on the page not included in the test *and* will render differently in different browsers? I can posit the existence of both sorts of things, but I'm not sure when they arise in practice? I've seen tests before that have lots of form controls where a bunch were outside the viewport. Sure, you *can* write such tests. Did you *have to*? Certainly not, I just know such tests already exist. Right, so in the absence of tests that *need* bigger viewports, I'd side w/ David and say that we should fix tests to fit within 800x600 so that they are portable to other browsers and meet the W3C's criteria. Looking at the entire page would be a bad idea, as it would let us tolerate non-conformant tests. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 3:49 PM, Darin Adler da...@apple.com wrote: On Apr 24, 2013, at 3:45 PM, Dirk Pranke dpra...@chromium.org wrote: in the absence of tests that *need* bigger viewports, I'd side w/ David and say that we should fix tests to fit within 800x600 so that they are portable to other browsers and meet the W3C's criteria. Makes sense. I believe the 800x600 viewport makes it easy to accidentally write incorrect ref tests that look good when you read the HTML in the test file and the expected file, but are no good. It would be nice to find a simple way to spot flawed ref tests easily so even an inexperienced beginner will notice such mistakes. I'm not sure I'm understanding you here. You mean it's easy to write a test that is bigger than 800x600, and perhaps we should generate some sort of warning for this? -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Apr 24, 2013, at 3:52 PM, Dirk Pranke dpra...@chromium.org wrote: You mean it's easy to write a test that is bigger than 800x600, and perhaps we should generate some sort of warning for this? It’s easy to write a test where part of what we’re trying to test is outside 800x600, right. And it would be good if this mistake was easy to notice. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Test frame size for reftests
On Wed, Apr 24, 2013 at 4:00 PM, Darin Adler da...@apple.com wrote: On Apr 24, 2013, at 3:52 PM, Dirk Pranke dpra...@chromium.org wrote: You mean it's easy to write a test that is bigger than 800x600, and perhaps we should generate some sort of warning for this? It’s easy to write a test where part of what we’re trying to test is outside 800x600, right. And it would be good if this mistake was easy to notice. Yeah, seems like we could do either or both of modify DRT/WTR to draw a big border at 800x600 and log errors to stdout/stderr if the page wanted to be overflow that. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Alexandru Chiculita is now a WebKit reviewer
Congratulations, Alex! Well deserved! - Max On Apr 24, 2013, at 2:42 PM, Dean Jackson d...@apple.com wrote: I'm happy to announce that Alex is now a WebKit reviewer. Congratulations Alex! Alex has done a lot of work in CSS Filters, amongst other places. For those who want to see him in action, here is his recent presentation at W3Conf: http://achicu.github.com/css-presentation/ http://www.youtube.com/embed/D7gsp7RnDfc Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
