[webkit-dev] CSS Regions diagrams
Hello WebKittens, I've built two diagrams that should help contributors ramp up on the CSS Regions code. https://docs.google.com/file/d/0Bw3uLBB0FreFWC1HZVM2YnRkeFE/edit The first diagram is a class map covering the relevant parts of the regions code. Two important missing pieces are the layers code and the auto-height specific code. Hopefully I'll find some time to add those as well. The diagram is pretty large so I recommend downloading it for easier navigation. The second diagram shows the structure of the render tree for a document with two named flows having a regions dependency between them. The diagram also presents the layout order of the renderers to ensure the content in the named flows is laid out correctly. Thanks, Andrei ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CSS Regions diagrams
I can't zoom enough to see anything on the first diagram. Could you post a regular PDF or PNG/SVG somewhere? - R. Niwa On Thu, May 9, 2013 at 1:24 AM, Andrei Bucur abu...@adobe.com wrote: Hello WebKittens, I've built two diagrams that should help contributors ramp up on the CSS Regions code. https://docs.google.com/file/d/0Bw3uLBB0FreFWC1HZVM2YnRkeFE/edit The first diagram is a class map covering the relevant parts of the regions code. Two important missing pieces are the layers code and the auto-height specific code. Hopefully I'll find some time to add those as well. The diagram is pretty large so I recommend downloading it for easier navigation. The second diagram shows the structure of the render tree for a document with two named flows having a regions dependency between them. The diagram also presents the layout order of the renderers to ensure the content in the named flows is laid out correctly. Thanks, Andrei ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CSS Regions diagrams
It is a regular PDF. For some reasons zooming is limited in the browser previewer. The Google Docs toolbar should have a download button in the left (a down arrow). If it doesn't work I'll find a different place to host it. Andrei. From: ryosuke.n...@gmail.com [mailto:ryosuke.n...@gmail.com] On Behalf Of Ryosuke Niwa Sent: Thursday, May 09, 2013 11:30 AM To: Andrei Bucur Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] CSS Regions diagrams I can't zoom enough to see anything on the first diagram. Could you post a regular PDF or PNG/SVG somewhere? - R. Niwa On Thu, May 9, 2013 at 1:24 AM, Andrei Bucur abu...@adobe.commailto:abu...@adobe.com wrote: Hello WebKittens, I've built two diagrams that should help contributors ramp up on the CSS Regions code. https://docs.google.com/file/d/0Bw3uLBB0FreFWC1HZVM2YnRkeFE/edit The first diagram is a class map covering the relevant parts of the regions code. Two important missing pieces are the layers code and the auto-height specific code. Hopefully I'll find some time to add those as well. The diagram is pretty large so I recommend downloading it for easier navigation. The second diagram shows the structure of the render tree for a document with two named flows having a regions dependency between them. The diagram also presents the layout order of the renderers to ensure the content in the named flows is laid out correctly. Thanks, Andrei ___ webkit-dev mailing list webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Intent to Enable CSS Exclusions in Nightlies
Hi WebKit, The CSS Exclusions Shapes [1] feature is currently behind a runtime flag that I would like to enable by default in the WebKit nightlies. The feature work is currently being done by myself, Hans Muller, Bem Jones-Bey, and Zoltan Horvath. We are tracking the work under master bug 89256 [2]. The current implementation focuses on shape-inside [3] and shape-outside on floats [4]. I also wanted to ask if there is a preferred method for accomplishing this. The most straightforward solution would be to set the runtime enabled feature to true by default in WebCore's RuntimeEnabledFeatures.cpp. An alternative approach would be to set up a preference in WebKit2's WebPreferencesStore.h with a default true value, and wire up the necessary plumbing. Thoughts? -Bear [1] http://dev.w3.org/csswg/css-exclusions/ [2] https://bugs.webkit.org/show_bug.cgi?id=89256 [3] http://dev.w3.org/csswg/css-exclusions/#shape-inside-property [4] http://dev.w3.org/csswg/css-exclusions/#shape-outside-property ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Christophe Dumez is now a WebKit reviewer
Hi, I'm happy to announce that Christophe Dumez is now a WebKit reviewer. Chris has done great work on WebKit2 (test infrastructure, support for new device APIs) and one of the driving forces behind the EFL port. Lately he has been doing work on the Soup and GStreamer backends and the binding generators. Please join me in congratulating Chris ! Thanks, Laszlo ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies
On 2013-05-09, at 17:21, Bear Travis betra...@adobe.com wrote: Hi WebKit, The CSS Exclusions Shapes [1] feature is currently behind a runtime flag that I would like to enable by default in the WebKit nightlies. Can you clarify what it means to enable something by default in the WebKit nightlies”? Do you mean enabling it by default on tip of tree? - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies
Hi Mark, Yes, my understanding of the policy [1] was that this was done at tip of tree. -Bear [1] https://lists.webkit.org/pipermail/webkit-dev/2013-May/024850.html From: Mark Rowe mr...@apple.commailto:mr...@apple.com Date: Thursday, May 9, 2013 5:25 PM To: Adobe betra...@adobe.commailto:betra...@adobe.com Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies On 2013-05-09, at 17:21, Bear Travis betra...@adobe.commailto:betra...@adobe.com wrote: Hi WebKit, The CSS Exclusions Shapes [1] feature is currently behind a runtime flag that I would like to enable by default in the WebKit nightlies. Can you clarify what it means to enable something by default in the WebKit nightlies”? Do you mean enabling it by default on tip of tree? - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies
The only platform for which nightly builds are produced is OS X. Do you intend to enable it for all platforms on tip of tree, or just for those from which nightly builds are built? What I'm getting at is that I'm confused as to why you mentioned nightly builds at all in your initial email if you're enabling it for all platforms. - Mark On May 9, 2013, at 17:49, Bear Travis betra...@adobe.com wrote: Hi Mark, Yes, my understanding of the policy [1] was that this was done at tip of tree. -Bear [1] https://lists.webkit.org/pipermail/webkit-dev/2013-May/024850.html From: Mark Rowe mr...@apple.com Date: Thursday, May 9, 2013 5:25 PM To: Adobe betra...@adobe.com Cc: webkit-dev@lists.webkit.org webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies On 2013-05-09, at 17:21, Bear Travis betra...@adobe.com wrote: Hi WebKit, The CSS Exclusions Shapes [1] feature is currently behind a runtime flag that I would like to enable by default in the WebKit nightlies. Can you clarify what it means to enable something by default in the WebKit nightlies”? Do you mean enabling it by default on tip of tree? - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies
Got it. The goal here is to enable users to test the CSS Exclusions and Shapes feature in the WebKit nightlies. I'm fine with whatever path can best make that happen. The feature currently has both a compile-time [1] and a runtime flag [2]. My initial plan was to change the runtime flag default to true, so any platforms that have the compile flag set will enable the feature by default. The change would not affect any platforms that do not enable the feature via the compile flag (for example, it is currently turned off for Windows builds). Does that sound reasonable? -Bear [1] WebCore::FeatureDefines::CSS_EXCLUSIONS [2] WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled From: Mark Rowe mr...@apple.commailto:mr...@apple.com Date: Thursday, May 9, 2013 6:13 PM To: Adobe betra...@adobe.commailto:betra...@adobe.com Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies The only platform for which nightly builds are produced is OS X. Do you intend to enable it for all platforms on tip of tree, or just for those from which nightly builds are built? What I'm getting at is that I'm confused as to why you mentioned nightly builds at all in your initial email if you're enabling it for all platforms. - Mark On May 9, 2013, at 17:49, Bear Travis betra...@adobe.commailto:betra...@adobe.com wrote: Hi Mark, Yes, my understanding of the policy [1] was that this was done at tip of tree. -Bear [1] https://lists.webkit.org/pipermail/webkit-dev/2013-May/024850.html From: Mark Rowe mr...@apple.commailto:mr...@apple.com Date: Thursday, May 9, 2013 5:25 PM To: Adobe betra...@adobe.commailto:betra...@adobe.com Cc: webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org webkit-dev@lists.webkit.orgmailto:webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Intent to Enable CSS Exclusions in Nightlies On 2013-05-09, at 17:21, Bear Travis betra...@adobe.commailto:betra...@adobe.com wrote: Hi WebKit, The CSS Exclusions Shapes [1] feature is currently behind a runtime flag that I would like to enable by default in the WebKit nightlies. Can you clarify what it means to enable something by default in the WebKit nightlies”? Do you mean enabling it by default on tip of tree? - Mark ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Christophe Dumez is now a WebKit reviewer
Congratulation !!! Chris !! Gyuyoung On Thu, May 9, 2013 at 5:22 PM, Laszlo Gombos laszlo.gom...@gmail.comwrote: Hi, I'm happy to announce that Christophe Dumez is now a WebKit reviewer. Chris has done great work on WebKit2 (test infrastructure, support for new device APIs) and one of the driving forces behind the EFL port. Lately he has been doing work on the Soup and GStreamer backends and the binding generators. Please join me in congratulating Chris ! Thanks, Laszlo ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
