Re: [webkit-dev] Subject: Windows CE port in WebKit: status, future work
On Jan 31, 2014, at 1:36 PM, Patrick Gansterer wrote: > On 31.01.2014, at 22:10, Anders Carlsson wrote > >> looks like the last legitimate commit to the Windows CE port was on November >> 3rd November 2013, almost 3 months ago. > > What's the minimum upstream interval for downstream fixes to show ongoing > activity? I don't think we've ever discussed such a thing, but when a project has no activity for three months people are going to start to wonder; it's happened in the past without anyone responding so thanks for doing that! >> I also seem to remember that there’s no version of MSVC for Windows CE that >> can handle the C++11 features that we now use in WebKit. (Correct me if I’m >> wrong on this!) > > Windows Embedded Compact 2013 updated the compiler for CE. That's great news. > >> With this in mind, does it make sense to keep the Windows CE port in the >> tree or should we remove it? > > Does it hurt somebody in the daily workflow? If yes, where exactly? I don't think it has affected anybody's daily workflow seriously. If it does in the future we can cross that bridge when we get to it. Thanks, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Subject: Windows CE port in WebKit: status, future work
I was also wondering how the new requirements for svg and accelerated compositing affected the wince port. Alex Christensen > On Jan 31, 2014, at 2:36 PM, Patrick Gansterer wrote: > > On 31.01.2014, at 22:10, Anders Carlsson wrote > >> looks like the last legitimate commit to the Windows CE port was on November >> 3rd November 2013, almost 3 months ago. > > What's the minimum upstream interval for downstream fixes to show ongoing > activity? > >> I also seem to remember that there’s no version of MSVC for Windows CE that >> can handle the C++11 features that we now use in WebKit. (Correct me if I’m >> wrong on this!) > > Windows Embedded Compact 2013 updated the compiler for CE. > >> With this in mind, does it make sense to keep the Windows CE port in the >> tree or should we remove it? > > Does it hurt somebody in the daily workflow? If yes, where exactly? > I'm still working on getting rid of WebKit/wince by merging it into > WebKit/win (with only a few #if WINCE) to reduce the impact of the WinCE > port, but it's hard if there is nobody who finds time for reviewing patches. > :-/ (e.g. webkit.org/b/119518 or webkit.org/b/123803 waiting for months - but > I don't want to blame somebody by this!) > > -- > Patrick > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Subject: Windows CE port in WebKit: status, future work
On 31.01.2014, at 22:10, Anders Carlsson wrote > looks like the last legitimate commit to the Windows CE port was on November > 3rd November 2013, almost 3 months ago. What's the minimum upstream interval for downstream fixes to show ongoing activity? > I also seem to remember that there’s no version of MSVC for Windows CE that > can handle the C++11 features that we now use in WebKit. (Correct me if I’m > wrong on this!) Windows Embedded Compact 2013 updated the compiler for CE. > With this in mind, does it make sense to keep the Windows CE port in the tree > or should we remove it? Does it hurt somebody in the daily workflow? If yes, where exactly? I'm still working on getting rid of WebKit/wince by merging it into WebKit/win (with only a few #if WINCE) to reduce the impact of the WinCE port, but it's hard if there is nobody who finds time for reviewing patches. :-/ (e.g. webkit.org/b/119518 or webkit.org/b/123803 waiting for months - but I don't want to blame somebody by this!) -- Patrick ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Subject: Windows CE port in WebKit: status, future work
Hi floks, looks like the last legitimate commit to the Windows CE port was on November 3rd November 2013, almost 3 months ago. I also seem to remember that there’s no version of MSVC for Windows CE that can handle the C++11 features that we now use in WebKit. (Correct me if I’m wrong on this!) With this in mind, does it make sense to keep the Windows CE port in the tree or should we remove it? Regards, - Anders ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Nesting a new CSS_SHAPES flag
Hi Floks! We currently have flags for both CSS_SHAPES and CSS_EXCLUSIONS. In the former, shape-outside is nearly complete (thanks to hard work from Adobe contributors and others), but shape-inside is still waiting on a layout implementation, and is dependent on future specification work in CSS Exclusions. In order to make it easy for ports to ship the bits that are stable (shape-outside) while disabling the bits that are not (shape-inside), I'm going to add a CSS_SHAPE_INSIDE flag. It will be dependent on CSS_SHAPES. Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
On Fri, Jan 31, 2014 at 12:43:16PM +0100, Osztrogonác Csaba wrote: > The --no-svg build is broken now, and the change broke it is 11 > months old change Not in the GTK+ port at least, I've been able to do builds without SVG perfectly fine, so there's probably something else wrong in your environment or the port you're using. Anyway, I'm also fine with removing it. Berto ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Proposal: Remove ENABLE(SVG)
Hi, +1 for removing ENABLE(SVG) guards. The --no-svg build is broken now, and the change broke it is 11 months old change - https://trac.webkit.org/changeset/145450, so --no-svg build isn't maintained at all and nobody can use it on trunk. Let's go forward and remove the guards: https://bugs.webkit.org/show_bug.cgi?id=127991 (I started to prepare a patch, not yet finished.) Ossy no-svg build log: -- In file included from /Users/oszi/WebKit/Source/WebCore/css/BasicShapeFunctions.cpp:35: /Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2670:27: error: use of undeclared identifier 'CSSValueAlphabetic' m_value.valueID = CSSValueAlphabetic; ^ /Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:2687:10: error: use of undeclared identifier 'CSSValueAlphabetic' case CSSValueAlphabetic: ^ /Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4300:27: error: use of undeclared identifier 'CSSValueAlphabetic' m_value.valueID = CSSValueAlphabetic; ^ /Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4334:10: error: use of undeclared identifier 'CSSValueAlphabetic' case CSSValueAlphabetic: ^ /Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4846:27: error: use of undeclared identifier 'CSSValueAlphabetic' m_value.valueID = CSSValueAlphabetic; ^ /Users/oszi/WebKit/Source/WebCore/css/CSSPrimitiveValueMappings.h:4872:10: error: use of undeclared identifier 'CSSValueAlphabetic' case CSSValueAlphabetic: ^ 6 errors generated. -- On 01/29/2014 01:13 AM, Sam Weinig wrote: Hi Everyone, While we are discussing removing #ifdefs that everyone has enabled, I’d like to propose removing ENABLE(SVG), as every port has SVG enabled. The only argument I have heard for keeping it around is to keep a “minimal build” working, but I don’t think the clutter of the #ifdefs is worth that. -Sam ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
