[webkit-dev] Keep ResourceBuffer?
Hi folks. I’ve noticed that we have an unused abstraction in the loader code. ResourceBuffer is a cover for a SharedBuffer, with comments and remnants of an older effort to make it some kind of abstraction. But at the moment it’s just overhead and no abstraction. Does anyone object to my eliminating ResourceBuffer for now and changing code to use SharedBuffer directly instead? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Keep ResourceBuffer?
I think Brady explained to me — a year ago? — what ResourceBuffer’s goal was. Brady, do you remember? Geoff On Oct 23, 2014, at 9:42 AM, Darin Adler da...@apple.com wrote: Hi folks. I’ve noticed that we have an unused abstraction in the loader code. ResourceBuffer is a cover for a SharedBuffer, with comments and remnants of an older effort to make it some kind of abstraction. But at the moment it’s just overhead and no abstraction. Does anyone object to my eliminating ResourceBuffer for now and changing code to use SharedBuffer directly instead? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Keep ResourceBuffer?
Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2 side. ShareableResource exists to do memory mapped IPC. The current factoring is confusing and cleaning this up is definitely a good idea. However it will require a bit more than just changing ResourceBuffers to SharedBuffers. antti On Thu, Oct 23, 2014 at 9:42 AM, Darin Adler da...@apple.com wrote: Hi folks. I’ve noticed that we have an unused abstraction in the loader code. ResourceBuffer is a cover for a SharedBuffer, with comments and remnants of an older effort to make it some kind of abstraction. But at the moment it’s just overhead and no abstraction. Does anyone object to my eliminating ResourceBuffer for now and changing code to use SharedBuffer directly instead? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Fuzzinator reloaded
Hi Folks, I only needed a year to write the second chapter of the first Fuzzinator blogpost, but now it is out! If you are interested you can read it here: http://webkit.sed.hu/blog/20141023/fuzzinator-reloaded Cheers, Reni ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Keep ResourceBuffer?
On Oct 23, 2014, at 9:56 AM, Geoffrey Garen gga...@apple.com wrote: I think Brady explained to me — a year ago? — what ResourceBuffer’s goal was. Brady, do you remember? Two goals. Use #1: On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2 side. ShareableResource exists to do memory mapped IPC. Use #2: There was also plans for a NetworkProcess based memory cache and ResourceBuffer was part of those plans. As Antti also mentioned, the currently factoring is messy and can definitely be cleaned up, but it must maintain use case #1. If we ever get around to implementing #2, we can add what we need at that time. Brady ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CSS4 Media Queries
On Fri, Oct 17, 2014 at 4:55 PM, Dean Jackson d...@apple.com wrote: Hi floks, I'm going to start implementing a small part of CSS4 Media Queries. I'll put it behind a feature flag. I'm starting with http://dev.w3.org/csswg/mediaqueries-4/#inverted because Apple wants to discuss it at the W3C TPAC meetings. We don't have any intention to ship the feature yet - it's just for experimentation and evaluation. I suggest other ports disable it if they plan on releasing from trunk. I've put MQ stuff related to the inversion/high-contrast/etc on the agenda wiki, so it'll definitely be discussed. ~TJ ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] CSS4 Media Queries
On 23 Oct 2014, at 5:08 pm, Tab Atkins Jr. jackalm...@gmail.com wrote: On Fri, Oct 17, 2014 at 4:55 PM, Dean Jackson d...@apple.com wrote: Hi floks, I'm going to start implementing a small part of CSS4 Media Queries. I'll put it behind a feature flag. I'm starting with http://dev.w3.org/csswg/mediaqueries-4/#inverted because Apple wants to discuss it at the W3C TPAC meetings. We don't have any intention to ship the feature yet - it's just for experimentation and evaluation. I suggest other ports disable it if they plan on releasing from trunk. I've put MQ stuff related to the inversion/high-contrast/etc on the agenda wiki, so it'll definitely be discussed. As a followup, inverted-colors and monochrome are now implemented on Apple ports. I ended up not using a prefix or feature flag because I’m hoping that there won’t be any breaking changes. Dean ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Keep ResourceBuffer?
On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2 side. ShareableResource exists to do memory mapped IPC. Really? I don’t see any code actually creating the class in WebKit2. There is a class named WebResourceBuffer, but no instance of it is ever created. Also, not enough of the functions in ResourceBuffer are virtual to make this actually work. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Keep ResourceBuffer?
In that case remove away. Did I mention this code is confusing? antti On Thu, Oct 23, 2014 at 8:11 PM, Darin Adler da...@apple.com wrote: On Oct 23, 2014, at 10:13 AM, Antti Koivisto koivi...@iki.fi wrote: Note that ResourceBuffer is virtual and wraps a ShareableResource on WebKit2 side. ShareableResource exists to do memory mapped IPC. Really? I don’t see any code actually creating the class in WebKit2. There is a class named WebResourceBuffer, but no instance of it is ever created. Also, not enough of the functions in ResourceBuffer are virtual to make this actually work. — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
