Re: [webkit-dev] EFL port?

2017-02-15 Thread Gyuyoung Kim 
Hi Konstantin and Gustavo,

I'm gonna upload latest WebKit source code to the repo.
Let me use the methods you guys recommend(script or git command) in order
to make EFL tarball.

Gyuyoung.


On Thu, Feb 16, 2017 at 12:18 AM, Gustavo Sverzut Barbieri <
barbi...@profusion.mobi> wrote:

> On Wed, Feb 15, 2017 at 12:48 PM, Konstantin Tokarev 
> wrote:
> >
> >
> > 15.02.2017, 17:18, "Gustavo Sverzut Barbieri" :
> >> On Wed, Feb 15, 2017 at 3:19 AM, Gyuyoung Kim 
> wrote:
> >>>  Hi,
> >>>
> >>>  If there is no other active maintainer for EFL port, unfortunately I
> have to
> >>>  agree to drop EFL port in mainline
> >>>  because EFL port should not be an obstacle. I will maintain WebKitEFL
> like
> >>>  the QT port in
> >>>  https://github.com/Gyuyoung/ewebkit and http://www.ewebkit.org.
> >>
> >> Okay, we can continue based on that.
> >>
> >> Just a small observation for your fork is to avoid releases to remove
> >> non-EFL port files like was done for 1.18, instead keep just our
> >> patchset on top and if you want to produce smaller archives just use
> >> git-archive ignore files (which can be in the git repo)... likely good
> >> to produce smaller downloads without layouttests and the likes.
> >
> > There is small but very useful script, Tools/gtk/make-dist.py. It allows
> to remove
> > unwanted files by using patterns, listed in manifests file (like
> Tools/gtk/manifest.txt.in)
> >
> > For Qt port I use this script both to make release tarballs and for
> snapshots repo [1].
> > This allows me to have full-fledged main repo with all tests and
> sources, and users
> > can clone small snapshots repo to get latest updates.
> >
> > [1] https://github.com/annulen/qtwebkit-snapshots
>
> well, cpack could do that kind of stuff, no? I recall the first port
> of cmake used that.
>
> I'm not sure why Gyuyoung did that approach, likely to get the
> tarballs-from-git-tags feature of github in a lightweight mode... then
> using git-archive features may do (it's kinda of simple to blacklist
> tests stuff and slim the tarball to 50mb or so)
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN, GTalk, FaceTime: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (16) 99354-9890
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EFL port?

2017-02-15 Thread ryuan Choi 
gyuyoung,

If you want, I can share https://github.com/ewebkit organization just for
better repository name.
There is also some script to make archive smaller.(but not maintained)


2017-02-16 0:18 GMT+09:00 Gustavo Sverzut Barbieri 
:

> On Wed, Feb 15, 2017 at 12:48 PM, Konstantin Tokarev 
> wrote:
> >
> >
> > 15.02.2017, 17:18, "Gustavo Sverzut Barbieri" :
> >> On Wed, Feb 15, 2017 at 3:19 AM, Gyuyoung Kim 
> wrote:
> >>>  Hi,
> >>>
> >>>  If there is no other active maintainer for EFL port, unfortunately I
> have to
> >>>  agree to drop EFL port in mainline
> >>>  because EFL port should not be an obstacle. I will maintain WebKitEFL
> like
> >>>  the QT port in
> >>>  https://github.com/Gyuyoung/ewebkit and http://www.ewebkit.org.
> >>
> >> Okay, we can continue based on that.
> >>
> >> Just a small observation for your fork is to avoid releases to remove
> >> non-EFL port files like was done for 1.18, instead keep just our
> >> patchset on top and if you want to produce smaller archives just use
> >> git-archive ignore files (which can be in the git repo)... likely good
> >> to produce smaller downloads without layouttests and the likes.
> >
> > There is small but very useful script, Tools/gtk/make-dist.py. It allows
> to remove
> > unwanted files by using patterns, listed in manifests file (like
> Tools/gtk/manifest.txt.in)
> >
> > For Qt port I use this script both to make release tarballs and for
> snapshots repo [1].
> > This allows me to have full-fledged main repo with all tests and
> sources, and users
> > can clone small snapshots repo to get latest updates.
> >
> > [1] https://github.com/annulen/qtwebkit-snapshots
>
> well, cpack could do that kind of stuff, no? I recall the first port
> of cmake used that.
>
> I'm not sure why Gyuyoung did that approach, likely to get the
> tarballs-from-git-tags feature of github in a lightweight mode... then
> using git-archive features may do (it's kinda of simple to blacklist
> tests stuff and slim the tarball to 50mb or so)
>
>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN, GTalk, FaceTime: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (16) 99354-9890
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Importing tests from web-platform-tests

2017-02-15 Thread youenn fablet 
Hi Yoav,

For existing preload tests, you may want to use DumpJSConsoleLogInStdErr if
the warnings appear in the console log.
For testing unused preloads warnings, it may be better to use non WPT tests
atm.

   y

Le mer. 15 févr. 2017 à 05:00, Yoav Weiss  a écrit :

> I'm trying to import tests from web-platform-tests/preload
> , but
> having trouble getting them to run without requiring expected results and
> while using wptserve.
>
> I looked at the WPT import tutorial
>  but failed to find a way
> to do what I need.
>
> The reason I don't want to rely on expected tests is that I'm trying to
> add a warning for unused preloads
> , and these warnings can
> make expected results flaky. While I can work around it in most cases (by
> using the preloads in my layout tests), a way to stop relying on
> expected.txt for tests that don't need it would be cleaner.
>
> Thanks,
> Yoav
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EFL port?

2017-02-15 Thread Gustavo Sverzut Barbieri 
On Wed, Feb 15, 2017 at 12:48 PM, Konstantin Tokarev  wrote:
>
>
> 15.02.2017, 17:18, "Gustavo Sverzut Barbieri" :
>> On Wed, Feb 15, 2017 at 3:19 AM, Gyuyoung Kim  
>> wrote:
>>>  Hi,
>>>
>>>  If there is no other active maintainer for EFL port, unfortunately I have 
>>> to
>>>  agree to drop EFL port in mainline
>>>  because EFL port should not be an obstacle. I will maintain WebKitEFL like
>>>  the QT port in
>>>  https://github.com/Gyuyoung/ewebkit and http://www.ewebkit.org.
>>
>> Okay, we can continue based on that.
>>
>> Just a small observation for your fork is to avoid releases to remove
>> non-EFL port files like was done for 1.18, instead keep just our
>> patchset on top and if you want to produce smaller archives just use
>> git-archive ignore files (which can be in the git repo)... likely good
>> to produce smaller downloads without layouttests and the likes.
>
> There is small but very useful script, Tools/gtk/make-dist.py. It allows to 
> remove
> unwanted files by using patterns, listed in manifests file (like 
> Tools/gtk/manifest.txt.in)
>
> For Qt port I use this script both to make release tarballs and for snapshots 
> repo [1].
> This allows me to have full-fledged main repo with all tests and sources, and 
> users
> can clone small snapshots repo to get latest updates.
>
> [1] https://github.com/annulen/qtwebkit-snapshots

well, cpack could do that kind of stuff, no? I recall the first port
of cmake used that.

I'm not sure why Gyuyoung did that approach, likely to get the
tarballs-from-git-tags feature of github in a lightweight mode... then
using git-archive features may do (it's kinda of simple to blacklist
tests stuff and slim the tarball to 50mb or so)


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN, GTalk, FaceTime: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (16) 99354-9890
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EFL port?

2017-02-15 Thread Konstantin Tokarev 


15.02.2017, 17:18, "Gustavo Sverzut Barbieri" :
> On Wed, Feb 15, 2017 at 3:19 AM, Gyuyoung Kim  wrote:
>>  Hi,
>>
>>  If there is no other active maintainer for EFL port, unfortunately I have to
>>  agree to drop EFL port in mainline
>>  because EFL port should not be an obstacle. I will maintain WebKitEFL like
>>  the QT port in
>>  https://github.com/Gyuyoung/ewebkit and http://www.ewebkit.org.
>
> Okay, we can continue based on that.
>
> Just a small observation for your fork is to avoid releases to remove
> non-EFL port files like was done for 1.18, instead keep just our
> patchset on top and if you want to produce smaller archives just use
> git-archive ignore files (which can be in the git repo)... likely good
> to produce smaller downloads without layouttests and the likes.

There is small but very useful script, Tools/gtk/make-dist.py. It allows to 
remove
unwanted files by using patterns, listed in manifests file (like 
Tools/gtk/manifest.txt.in)

For Qt port I use this script both to make release tarballs and for snapshots 
repo [1].
This allows me to have full-fledged main repo with all tests and sources, and 
users
can clone small snapshots repo to get latest updates.

[1] https://github.com/annulen/qtwebkit-snapshots

>
> --
> Gustavo Sverzut Barbieri
> http://profusion.mobi embedded systems
> --
> MSN, GTalk, FaceTime: barbi...@gmail.com
> Skype: gsbarbieri
> Mobile: +55 (16) 99354-9890
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] EFL port?

2017-02-15 Thread Gustavo Sverzut Barbieri 
On Wed, Feb 15, 2017 at 3:19 AM, Gyuyoung Kim  wrote:
> Hi,
>
> If there is no other active maintainer for EFL port, unfortunately I have to
> agree to drop EFL port in mainline
> because EFL port should not be an obstacle. I will maintain WebKitEFL like
> the QT port in
> https://github.com/Gyuyoung/ewebkit and http://www.ewebkit.org.

Okay, we can continue based on that.

Just a small observation for your fork is to avoid releases to remove
non-EFL port files like was done for 1.18, instead keep just our
patchset on top and if you want to produce smaller archives just use
git-archive ignore files (which can be in the git repo)... likely good
to produce smaller downloads without layouttests and the likes.


-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--
MSN, GTalk, FaceTime: barbi...@gmail.com
Skype: gsbarbieri
Mobile: +55 (16) 99354-9890
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Importing tests from web-platform-tests

2017-02-15 Thread Yoav Weiss 
I'm trying to import tests from web-platform-tests/preload
, but having
trouble getting them to run without requiring expected results and while
using wptserve.

I looked at the WPT import tutorial
 but failed to find a way to
do what I need.

The reason I don't want to rely on expected tests is that I'm trying to add
a warning for unused preloads
, and these warnings can
make expected results flaky. While I can work around it in most cases (by
using the preloads in my layout tests), a way to stop relying on
expected.txt for tests that don't need it would be cleaner.

Thanks,
Yoav
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] CSS Parse error in element.

2017-02-15 Thread Konstantin Tokarev 
  15.02.2017, 11:40, "Atul Sowani" :Hi, I am wondering about the behavioural difference of the same code on two different platforms, under same conditions. For example, consider following code in css/CSSCalculationValue.cpp (under class CSSCalcBinaryOperation): static PassRefPtr create(PassRefPtr leftSide, PassRefPtr rightSide, CalcOperator op)    {    ASSERT(leftSide->category() != CalcOther && rightSide->category() != CalcOther);    CalculationCategory newCategory = determineCategory(*leftSide, *rightSide, op);    if (newCategory == CalcOther)    return 0;    return adoptRef(new CSSCalcBinaryOperation(leftSide, rightSide, op, newCategory));    } The values in question are as follows:calling CSSCalcBinaryOperation::create from parseAdditiveValueExpressionoperatorCharacter 2 = -lhs = 1 rhs = 1in CSSCalcBinaryOperation::createleftSide category = 5rightSide category = 1 Now exactly same values cause ASSERT on ppc64le, causing a crash whereas it just passes smoothly on x86_64. It can be that you are using release build on x86_64, where asserts are disabled The C/C++ compiler is identical on both the platforms: on x86_64:# g++ -vUsing built-in specs.COLLECT_GCC=g++COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapperTarget: x86_64-linux-gnuConfigured with: ../src/configure -v --with-pkgversion='Ubuntu 5.4.0-6ubuntu1~16.04.4' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64 --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64 --with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnuThread model: posixgcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4) on ppc64le:# g++ -vUsing built-in specs.COLLECT_GCC=g++COLLECT_LTO_WRAPPER=/usr/lib/gcc/powerpc64le-linux-gnu/5/lto-wrapperTarget: powerpc64le-linux-gnuConfigured with: ../src/configure -v --with-pkgversion='Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4' --with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs --enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr --program-suffix=-5 --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libquadmath --enable-plugin --with-system-zlib --disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo --with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-ppc64el/jre --enable-java-home --with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-ppc64el --with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-ppc64el --with-arch-directory=ppc64le --with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc --enable-secureplt --with-cpu=power8 --enable-targets=powerpcle-linux --disable-multilib --enable-multiarch --disable-werror --with-long-double-128 --enable-checking=release --build=powerpc64le-linux-gnu --host=powerpc64le-linux-gnu --target=powerpc64le-linux-gnuThread model: posixgcc version 5.4.0 20160609 (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4)  On Mon, Feb 13, 2017 at 4:26 PM, Atul Sowani  wrote:@Konstantin Thanks for the update and it is definitely relieving to know that those were known issues and have been fixed in later version of QtWebKit. I will work with PhantomJS maintainers to get the QtWebKit version upgraded in the latest PhantomJS version. Thanks! On Mon, Feb 13, 2017 at 3:41 PM, Konstantin Tokarev  wrote: 13.02.2017, 11:52, "Atul Sowani" :> I am using Qt 5.5.1.It ships with obsolete WebKit version based on trunk from 2013. Indeed it is known to have assertion failures related to calc like those you've posted, which were fixed since that times.Please upgrade to QtWebKit TP5 [1]. It is much closer to trunk, and will be a hard requirement for Phantom JS 2.5[1] https://github.com/annulen/webkit/releases/tag/qtwebkit-tp5>> On Thu, Feb 9, 2017 at 10:15 PM, Simon Fraser  wrote:>> What WebKit revision

Re: [webkit-dev] CSS Parse error in element.

2017-02-15 Thread Atul Sowani 
Hi,

I am wondering about the behavioural difference of the same code on two
different platforms, under same conditions. For example, consider following
code in css/CSSCalculationValue.cpp (under class CSSCalcBinaryOperation):

static PassRefPtr
create(PassRefPtr leftSide,
PassRefPtr rightSide, CalcOperator op)
{
ASSERT(leftSide->category() != CalcOther && rightSide->category()
!= CalcOther);
CalculationCategory newCategory = determineCategory(*leftSide,
*rightSide, op);
if (newCategory == CalcOther)
return 0;
return adoptRef(new CSSCalcBinaryOperation(leftSide, rightSide, op,
newCategory));
}

The values in question are as follows:
calling CSSCalcBinaryOperation::create from parseAdditiveValueExpression
operatorCharacter 2 = -
lhs = 1 rhs = 1
in CSSCalcBinaryOperation::create
leftSide category = 5
rightSide category = 1

Now exactly same values cause ASSERT on ppc64le, causing a crash whereas it
just passes smoothly on x86_64. The C/C++ compiler is identical on both the
platforms:

on x86_64:
# g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/5/lto-wrapper
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu
5.4.0-6ubuntu1~16.04.4'
--with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs
--enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-5 --enable-shared --enable-linker-build-id
--libexecdir=/usr/lib --without-included-gettext --enable-threads=posix
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes
--with-default-libstdcxx-abi=new --enable-gnu-unique-object
--disable-vtable-verify --enable-libmpx --enable-plugin --with-system-zlib
--disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-amd64/jre --enable-java-home
--with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-amd64
--with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-amd64
--with-arch-directory=amd64 --with-ecj-jar=/usr/share/java/eclipse-ecj.jar
--enable-objc-gc --enable-multiarch --disable-werror --with-arch-32=i686
--with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib
--with-tune=generic --enable-checking=release --build=x86_64-linux-gnu
--host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)

on ppc64le:
# g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/powerpc64le-linux-gnu/5/lto-wrapper
Target: powerpc64le-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/IBM
5.4.0-6ubuntu1~16.04.4'
--with-bugurl=file:///usr/share/doc/gcc-5/README.Bugs
--enable-languages=c,ada,c++,java,go,d,fortran,objc,obj-c++ --prefix=/usr
--program-suffix=-5 --enable-shared --enable-linker-build-id
--libexecdir=/usr/lib --without-included-gettext --enable-threads=posix
--libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu
--enable-libstdcxx-debug --enable-libstdcxx-time=yes
--with-default-libstdcxx-abi=new --enable-gnu-unique-object
--disable-libquadmath --enable-plugin --with-system-zlib
--disable-browser-plugin --enable-java-awt=gtk --enable-gtk-cairo
--with-java-home=/usr/lib/jvm/java-1.5.0-gcj-5-ppc64el/jre
--enable-java-home
--with-jvm-root-dir=/usr/lib/jvm/java-1.5.0-gcj-5-ppc64el
--with-jvm-jar-dir=/usr/lib/jvm-exports/java-1.5.0-gcj-5-ppc64el
--with-arch-directory=ppc64le
--with-ecj-jar=/usr/share/java/eclipse-ecj.jar --enable-objc-gc
--enable-secureplt --with-cpu=power8 --enable-targets=powerpcle-linux
--disable-multilib --enable-multiarch --disable-werror
--with-long-double-128 --enable-checking=release
--build=powerpc64le-linux-gnu --host=powerpc64le-linux-gnu
--target=powerpc64le-linux-gnu
Thread model: posix
gcc version 5.4.0 20160609 (Ubuntu/IBM 5.4.0-6ubuntu1~16.04.4)


On Mon, Feb 13, 2017 at 4:26 PM, Atul Sowani  wrote:

> @Konstantin Thanks for the update and it is definitely relieving to know
> that those were known issues and have been fixed in later version of
> QtWebKit. I will work with PhantomJS maintainers to get the QtWebKit
> version upgraded in the latest PhantomJS version.
>
> Thanks!
>
> On Mon, Feb 13, 2017 at 3:41 PM, Konstantin Tokarev 
> wrote:
>
>>
>>
>> 13.02.2017, 11:52, "Atul Sowani" :
>> > I am using Qt 5.5.1.
>>
>> It ships with obsolete WebKit version based on trunk from 2013. Indeed it
>> is known to have assertion failures related to calc like those you've
>> posted, which were fixed since that times.
>>
>> Please upgrade to QtWebKit TP5 [1]. It is much closer to trunk, and will
>> be a hard requirement for Phantom JS 2.5
>>
>> [1] https://github.com/annulen/webkit/releases/tag/qtwebkit-tp5
>>
>> >
>> > On Thu, Feb 9, 2017 at 10:15 PM, Simon Fraser 
>> wrote:
>> >> What WebKit revision are your