Re: [webkit-dev] WebKit nightly stops

[Yusuke SUZUKI]

Thanks! It works fine to me :D

Regards,
Yusuke Suzuki

On Tue, Jun 20, 2017 at 9:05 AM, Ling Ho  wrote:

> Hello Yusuke,
>
> Thanks for reporting the problem! I believe the issue is now fixed.
>
> ...
> ling
>
>
> On 6/16/17 12:23 PM, Yusuke SUZUKI wrote:
>
> Hi WebKittens!
>
> I've found that WebKit nightly build stops after June 13.
> Is there any issues?
>
> And thank you for maintainers of the buildbots!
> WebKit nigthly is very helpful to me :)
>
> Best regards,
> Yusuke Suzuki
>
>
> ___
> webkit-dev mailing 
> listwebkit-dev@lists.webkit.orghttps://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

[Yusuke SUZUKI]

Feel free to review it :)
https://bugs.webkit.org/show_bug.cgi?id=173582

Regards,
Yusuke Suzuki

On Tue, Jun 20, 2017 at 1:48 PM, JF Bastien  wrote:

> Ours was imported from: https://github.com/akrzemi1/Optional
> at: 727c729dd1d9f06f225868280e50154594d7e59d
>
> And it was subsequently added in: https://github.com/
> akrzemi1/Optional/commit/8993daae3e9ed90be98ffb2517315f43fe9f09e4#diff-
> b7e55535b5ac355f0d683d30b3c87f86
>
>
>
> On Jun 19, 2017, at 21:45, Darin Adler  wrote:
>
> I noticed we don’t have has_value() in our version of std::optional. Does
> anyone know why?
>
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

[JF Bastien]

Ours was imported from: https://github.com/akrzemi1/Optional 

at: 727c729dd1d9f06f225868280e50154594d7e59d

And it was subsequently added in: 
https://github.com/akrzemi1/Optional/commit/8993daae3e9ed90be98ffb2517315f43fe9f09e4#diff-b7e55535b5ac355f0d683d30b3c87f86
 




> On Jun 19, 2017, at 21:45, Darin Adler  wrote:
> 
> I noticed we don’t have has_value() in our version of std::optional. Does 
> anyone know why?
> 
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Why does our std::optional lack the has_value() function?

[Yusuke SUZUKI]

I think it is just missing in the original code.

Seeing the original repository, we can find that these things are added.
We can rebaseline our copy by applying these changes.

https://github.com/akrzemi1/Optional/commits/master

Regards,
Yusuke Suzuki

On Tue, Jun 20, 2017 at 1:45 PM, Darin Adler  wrote:

> I noticed we don’t have has_value() in our version of std::optional. Does
> anyone know why?
>
> — Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Why does our std::optional lack the has_value() function?

[Darin Adler]

I noticed we don’t have has_value() in our version of std::optional. Does 
anyone know why?

— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebKit nightly stops

[Ling Ho]

Hello Yusuke,

Thanks for reporting the problem! I believe the issue is now fixed.

...
ling

On 6/16/17 12:23 PM, Yusuke SUZUKI wrote:

Hi WebKittens!

I've found that WebKit nightly build stops after June 13.
Is there any issues?

And thank you for maintainers of the buildbots!
WebKit nigthly is very helpful to me :)

Best regards,
Yusuke Suzuki


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

[Geoffrey Garen]

 Another minor comment: it seems like this new API returns raw data. It 
 seems like the native way to use this would result in running untrusted 
 data from the network through image decoders outside the Web Process 
 sandbox. Do we have a way to avoid that?
>>> 
>>> This came up while implementing it for Safari, too. In practice we didn't 
>>> decode icons out-of-process before so this model was not a regression. I 
>>> see value in offering this, but it's also something conscientious clients 
>>> can do on their own with the raw data.
>> 
>> Didn’t we need to create the Safari ImageDecoder service to work around the 
>> problem of decoding untrusted icon images?
> 
> That’s not going to be available to other participants in the WebKit Open 
> Source projects.

Sorry — I don't mean to suggest that other projects should adopt Safari's 
ImageDecoder service. I just want to clarify that Maciej’s concern is more than 
theoretical.

I would add that I don’t like the idea that it’s the client’s job to be 
“conscientious” in order to achieve safe rendering of web content. The point of 
Modern WebKit as a framework is that all clients should get safe rendering by 
default.

Therefore, I think it’s a flaw that the current API vends only raw encoded data.

Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

[Dan Bernstein]

On Jun 19, 2017, at 10:20 AM, Geoffrey Garen  wrote:

>>> Another minor comment: it seems like this new API returns raw data. It 
>>> seems like the native way to use this would result in running untrusted 
>>> data from the network through image decoders outside the Web Process 
>>> sandbox. Do we have a way to avoid that?
>> 
>> This came up while implementing it for Safari, too. In practice we didn't 
>> decode icons out-of-process before so this model was not a regression. I see 
>> value in offering this, but it's also something conscientious clients can do 
>> on their own with the raw data.
> 
> Didn’t we need to create the Safari ImageDecoder service to work around the 
> problem of decoding untrusted icon images?

That’s not going to be available to other participants in the WebKit Open 
Source projects.

> 
> Geoff
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Intent to remove the WebCore::IconDatabase (GTK needs to make a decision)

[Geoffrey Garen]

>> Another minor comment: it seems like this new API returns raw data. It seems 
>> like the native way to use this would result in running untrusted data from 
>> the network through image decoders outside the Web Process sandbox. Do we 
>> have a way to avoid that?
> 
> This came up while implementing it for Safari, too. In practice we didn't 
> decode icons out-of-process before so this model was not a regression. I see 
> value in offering this, but it's also something conscientious clients can do 
> on their own with the raw data.

Didn’t we need to create the Safari ImageDecoder service to work around the 
problem of decoding untrusted icon images?

Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev