Re: [webkit-dev] C++17 is here. Should we use it?

[Sam Weinig]

> On Jun 17, 2019, at 8:45 AM, Guillaume Emont  wrote:
> 
> Quoting Sam Weinig (2019-06-17 03:25:15)
>> Did we ever land on conclusion here? 
>> 
>> I tried to use c++17 structured bindings (see 
>> https://bugs.webkit.org/show_bug.cgi?id=198905 
>> ) and it looks like most of 
>> the EWS bots are ok with it, but the jsc-mips and jsc-armv7 bots are not 
>> into it.  Looking at the output, it seems like those bots may still be using 
>> GCC 6.4.0 (but I could be wrong here).
>> 
>> If the issue is getting these bots updated, can we do that? Are there any 
>> other bots that might need updating as well?
> 
> Sorry, yes indeed, jsc-mips and jsc-armv7 still use an old gcc. I've
> been working on updating this but got sidetracked. This is now on top of
> my priority list for this week. Thank you for your patience.
> 
> Guillaume
> 

Thanks Guillaume.

>> 
>> - Sam
>> 
>>> On May 11, 2019, at 7:48 AM, Michael Catanzaro  
>>> wrote:
>>> 
>>> On Fri, May 10, 2019 at 6:47 PM, Yusuke Suzuki  wrote:
 1. We can use GCC 7
 2. We can use libstdc++7
 Is my understanding correct? Basically, this means that we can use cool 
 C++17 features super aggressively :)
>>> 
>>> I would say you can use cool C++ 17 features cautiously, enjoying those 
>>> features when they work, and expecting the possibility of libstdc++7 bugs 
>>> causing them to not work.
>>> 
>>> I think our EWS bots are not yet on GCC 7, but that should be addressed 
>>> soon.
>>> 
>>> Michael
>>> 
>>> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>> 
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org 
>> https://lists.webkit.org/mailman/listinfo/webkit-dev 
>> 
>> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org 
> https://lists.webkit.org/mailman/listinfo/webkit-dev 
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Requesting feedback about EWS comments on Bugzilla bugs

[Keith Rollin]

> On Jun 16, 2019, at 11:14, Darin Adler  wrote:
> 
> If we want to augment it, we should think of what we are aiming at. I do find 
> it useful to see which tests are failing, and when I click on the red bubble 
> I don’t see that information. I have to click once to see the “log of 
> activities” then click on “results”, then see a confusing giant file with 
> lots of other information. At the bottom of that file the one thing I want to 
> know.

We might want to also start turning those failure into action items. We could 
have an automatic mechanism that gathers the failures, records them in a 
database, and then — with sufficient data — makes determinations about the 
flakiness or other status of the test. It could then mark the test as flaky or 
raise it as an issue to some responsible (and responsive) party.

We could also have a relatively manual process. The failures are surfaced in 
Bugzilla or in a Bugzilla-accessible page. The engineer posting the patch could 
then review the failures and mark them as “Flag as flaky”, “Flag as failing and 
should be fixed by someone else”, “Flag as failing and should be ignored”, etc. 
These responses could then be turned into action items for some responsible 
(and responsive) party to address.

As Michael says, there’s a big issue with ignoring test results. Putting a 
frictionless process in place to address test results would help make them more 
effective. When I make a change to an Xcode project and Windows builds throw up 
errors, that’s not something caused by my immediate patch, but I would like to 
see the flaky test fixed.

— Keith

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] C++17 is here. Should we use it?

[Guillaume Emont]

Quoting Sam Weinig (2019-06-17 03:25:15)
> Did we ever land on conclusion here? 
> 
> I tried to use c++17 structured bindings (see 
> https://bugs.webkit.org/show_bug.cgi?id=198905) and it looks like most of the 
> EWS bots are ok with it, but the jsc-mips and jsc-armv7 bots are not into it. 
>  Looking at the output, it seems like those bots may still be using GCC 6.4.0 
> (but I could be wrong here).
> 
> If the issue is getting these bots updated, can we do that? Are there any 
> other bots that might need updating as well?

Sorry, yes indeed, jsc-mips and jsc-armv7 still use an old gcc. I've
been working on updating this but got sidetracked. This is now on top of
my priority list for this week. Thank you for your patience.

Guillaume

> 
> - Sam
> 
> > On May 11, 2019, at 7:48 AM, Michael Catanzaro  
> > wrote:
> > 
> > On Fri, May 10, 2019 at 6:47 PM, Yusuke Suzuki  wrote:
> >> 1. We can use GCC 7
> >> 2. We can use libstdc++7
> >> Is my understanding correct? Basically, this means that we can use cool 
> >> C++17 features super aggressively :)
> > 
> > I would say you can use cool C++ 17 features cautiously, enjoying those 
> > features when they work, and expecting the possibility of libstdc++7 bugs 
> > causing them to not work.
> > 
> > I think our EWS bots are not yet on GCC 7, but that should be addressed 
> > soon.
> > 
> > Michael
> > 
> > 
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] C++17 is here. Should we use it?

[Michael Catanzaro]

Alex already switched all WebKit ports to building with C++17 enabled 
in https://bugs.webkit.org/show_bug.cgi?id=197131.


On Sun, Jun 16, 2019 at 8:25 PM, Sam Weinig  wrote:
If the issue is getting these bots updated, can we do that? Are there 
any other bots that might need updating as well?


We've previously agreed that we can increase the GCC version limit to 
GCC 7, but nobody ever implemented this. Reported 
https://bugs.webkit.org/show_bug.cgi?id=198914.


The easiest way to sniff out which bots should be upgraded is to just 
land the change and see which bots break. But I'll ask internally to 
ensure all remaining Igalia bots are upgraded to GCC 7 soon.


Be aware that while GCC 7 has basic support for structured bindings, 
there are limitations documented at 
https://gcc.gnu.org/projects/cxx-status.html which are not supported 
until GCC 8.


Michael


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev