Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

[Chris Dumez via webkit-dev]

Sounds good to me.Chris DumezOn Oct 5, 2022, at 9:04 PM, Kirsling, Ross via webkit-dev  wrote:




I've always kind of liked that `for (;;)` doesn't involve an explicit constant, but I too like consistency even more. :)

From: Ryosuke Niwa via webkit-dev 
Sent: Thursday, October 6, 2022 1:01:01 PM
To: Yusuke Suzuki ; Tim Nguyen ; WebKit Development 
Subject: Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`
 

I do prefer
for (;;) because of less typing but if the existing code mostly uses
while (true) then we should go with it.


On Oct 5, 2022, at 8:58 PM, Yusuke Suzuki via webkit-dev  wrote:


+1

-Yusuke

On Oct 5, 2022, at 5:07 PM, Tim Nguyen via webkit-dev  wrote:

Hi everyone,

The WebKit codebase has an inconsistent mix of `while (true)` and `for (;;)`. Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` from code search, I would suggest enforcing `while (true)`. I also think it is generally more explicit and readable
 than `for (;;)`. If everyone agrees, I’ll enforce this via webkit-style, so we can end up in a consistent place.

What does everyone think?

Cheers,
Tim
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev








___webkit-dev mailing listwebkit-dev@lists.webkit.orghttps://lists.webkit.org/mailman/listinfo/webkit-dev___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

[Kirsling, Ross via webkit-dev]

I've always kind of liked that `for (;;)` doesn't involve an explicit constant, 
but I too like consistency even more. :)

From: Ryosuke Niwa via webkit-dev 
Sent: Thursday, October 6, 2022 1:01:01 PM
To: Yusuke Suzuki ; Tim Nguyen ; 
WebKit Development 
Subject: Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

I do prefer for (;;) because of less typing but if the existing code mostly 
uses while (true) then we should go with it.

On Oct 5, 2022, at 8:58 PM, Yusuke Suzuki via webkit-dev 
mailto:webkit-dev@lists.webkit.org>> wrote:

+1

-Yusuke

On Oct 5, 2022, at 5:07 PM, Tim Nguyen via webkit-dev 
mailto:webkit-dev@lists.webkit.org>> wrote:

Hi everyone,

The WebKit codebase has an inconsistent mix of `while (true)` and `for (;;)`. 
Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` from code 
search, I would suggest enforcing `while (true)`. I also think it is generally 
more explicit and readable than `for (;;)`. If everyone agrees, I’ll enforce 
this via webkit-style, so we can end up in a consistent place.

What does everyone think?

Cheers,
Tim
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

[Ryosuke Niwa via webkit-dev]

I do prefer for (;;) because of less typing but if the existing code mostly 
uses while (true) then we should go with it.

> On Oct 5, 2022, at 8:58 PM, Yusuke Suzuki via webkit-dev 
>  wrote:
> 
> +1
> 
> -Yusuke
> 
>> On Oct 5, 2022, at 5:07 PM, Tim Nguyen via webkit-dev 
>>  wrote:
>> 
>> Hi everyone,
>> 
>> The WebKit codebase has an inconsistent mix of `while (true)` and `for 
>> (;;)`. Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` 
>> from code search, I would suggest enforcing `while (true)`. I also think it 
>> is generally more explicit and readable than `for (;;)`. If everyone agrees, 
>> I’ll enforce this via webkit-style, so we can end up in a consistent place.
>> 
>> What does everyone think?
>> 
>> Cheers,
>> Tim
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Style guide: enforce `while (true)` over `for (; ; )`

[Yusuke Suzuki via webkit-dev]

+1

-Yusuke

> On Oct 5, 2022, at 5:07 PM, Tim Nguyen via webkit-dev 
>  wrote:
> 
> Hi everyone,
> 
> The WebKit codebase has an inconsistent mix of `while (true)` and `for (;;)`. 
> Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` from 
> code search, I would suggest enforcing `while (true)`. I also think it is 
> generally more explicit and readable than `for (;;)`. If everyone agrees, 
> I’ll enforce this via webkit-style, so we can end up in a consistent place.
> 
> What does everyone think?
> 
> Cheers,
> Tim
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Style guide: enforce `while (true)` over `for (;;)`

[Tim Nguyen via webkit-dev]

Hi everyone,

The WebKit codebase has an inconsistent mix of `while (true)` and `for (;;)`. 
Given 2/3 of the usages are `while (true)` and only 1/3 is `for (;;)` from code 
search, I would suggest enforcing `while (true)`. I also think it is generally 
more explicit and readable than `for (;;)`. If everyone agrees, I’ll enforce 
this via webkit-style, so we can end up in a consistent place.

What does everyone think?

Cheers,
Tim
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev