Re: [webkit-dev] Fwd: ［GTK］Scr oll deficiency
Hi Xiong, My platform is WebKiton gtk+directfb. I am noticing that the issue is still present in the current Webkit nightly R-44111 build. I saw your sugested patch : In function ChromeClient::scroll() // gdk_window_move_region(window, moveRegion, delta.width(), delta.height()); // gdk_region_offset(moveRegion, delta.width(), delta.height()); gdk_window_move_region(window, moveRegion, moveRect.width, moveRect.height); gdk_region_offset(moveRegion, moveRect.width, moveRect.height); After applying it, I am not finding the scroll deficiency issue. I wish to know if this fix is working, why is it not landed yet. What is the plan for this bug. What is the bug number for Gtk+Directfb platform. Thanks and regards, Srinivas Rao.M http://msrinirao.blogspot.com On Wed, Apr 22, 2009 at 8:04 AM, Xiong browse...@gmail.com wrote: -- Forwarded message -- From: Xiong browse...@gmail.com Date: Wed, Apr 22, 2009 at 9:42 AM Subject: Re: [webkit-dev] ［GTK］Scroll deficiency To: Frank Thomsen f...@trifork.com Cc: Brent Fulgham bfulg...@gmail.com Hi Frank I am working on gtk+directfb and Brent working on Window+cairo, and you ? As you see, Brent and i have two separate bugs, because the workarounds he described do not help me. For now, i have resolved the problem in my platform. The reason why the screen display confusion is that GDK do not refresh the overlapping region when scrolling. So, change the codes as following: In function ChromeClient::scroll() // gdk_window_move_region(window, moveRegion, delta.width(), delta.height()); // gdk_region_offset(moveRegion, delta.width(), delta.height()); gdk_window_move_region(window, moveRegion, moveRect.width, moveRect.height); gdk_region_offset(moveRegion, moveRect.width, moveRect.height); After do that, the problem was gone, at least in my platform(Gtk+directfb). Good luck. -xiong 2009/4/17 Frank Thomsen f...@trifork.com Hi guys Yesterday I wrote that I had solved the problem - at least on my machine. Well, I was wrong. Apparently the redraw-problem only exists in release-mode. Could you please tell me what you have done to circumvent this problem? You have talked about both commenting out code and doing something with the ... background..? Whatever it is I cannot find it in the mailing list, so I would really appreciate if you could enlighten me. And do you know if this has been reported as a bug? Can't seem to find that either... Thanks in advance! Frank -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto: webkit-dev-boun...@lists.webkit.org] On Behalf Of Brent Fulgham Sent: 31. marts 2009 01:04 To: xiong Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] ［GTK］Scroll deficiency Hi Xiong, Thanks for trying these suggestions. On Sun, Mar 29, 2009 at 8:24 PM, xiong browse...@gmail.com wrote: Brent, In my platform, all the hack as you metioned are valueless. Bad news to me. Now, i only have a clue on cario for the scroll problem. I think we may have two separate (but perhaps related) bugs, because the workarounds I described do not help your problem. Furthermore, the change you suggested (comment out the if (contentChanged) test in ChromeClient::repaint ()) does not resolve my problem, while it does fix yours. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Srinivas Rao M Hamse ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Fwd: ［GTK］Scr oll deficiency
Hi Gustavo/Xiong, Is the patch discussed in this thread is acceptable for Gtk+Directfb platform ? Its very annoying that UI goes bad when we use scroll feature. Also is there a bug already logged on this issue, Can we log a fresh bug report if its not done ? regards, Srinivas Rao. M http://msrinirao.blogspot.com On Tue, Jun 2, 2009 at 2:27 PM, Xiong browse...@gmail.com wrote: Hi, I am happy to hear that you solve the issue. I am also sorry to say i can not search the bug report, and never submit the patch with my sloth. -Xiong 2009/6/2 Srinivas Rao M Hamse msrini...@gmail.com Hi Xiong, My platform is WebKiton gtk+directfb. I am noticing that the issue is still present in the current Webkit nightly R-44111 build. I saw your sugested patch : In function ChromeClient::scroll() // gdk_window_move_region(window, moveRegion, delta.width(), delta.height()); // gdk_region_offset(moveRegion, delta.width(), delta.height()); gdk_window_move_region(window, moveRegion, moveRect.width, moveRect.height); gdk_region_offset(moveRegion, moveRect.width, moveRect.height); After applying it, I am not finding the scroll deficiency issue. I wish to know if this fix is working, why is it not landed yet. What is the plan for this bug. What is the bug number for Gtk+Directfb platform. Thanks and regards, Srinivas Rao.M http://msrinirao.blogspot.com On Wed, Apr 22, 2009 at 8:04 AM, Xiong browse...@gmail.com wrote: -- Forwarded message -- From: Xiong browse...@gmail.com Date: Wed, Apr 22, 2009 at 9:42 AM Subject: Re: [webkit-dev] ［GTK］Scroll deficiency To: Frank Thomsen f...@trifork.com Cc: Brent Fulgham bfulg...@gmail.com Hi Frank I am working on gtk+directfb and Brent working on Window+cairo, and you ? As you see, Brent and i have two separate bugs, because the workarounds he described do not help me. For now, i have resolved the problem in my platform. The reason why the screen display confusion is that GDK do not refresh the overlapping region when scrolling. So, change the codes as following: In function ChromeClient::scroll() // gdk_window_move_region(window, moveRegion, delta.width(), delta.height()); // gdk_region_offset(moveRegion, delta.width(), delta.height()); gdk_window_move_region(window, moveRegion, moveRect.width, moveRect.height); gdk_region_offset(moveRegion, moveRect.width, moveRect.height); After do that, the problem was gone, at least in my platform(Gtk+directfb). Good luck. -xiong 2009/4/17 Frank Thomsen f...@trifork.com Hi guys Yesterday I wrote that I had solved the problem - at least on my machine. Well, I was wrong. Apparently the redraw-problem only exists in release-mode. Could you please tell me what you have done to circumvent this problem? You have talked about both commenting out code and doing something with the ... background..? Whatever it is I cannot find it in the mailing list, so I would really appreciate if you could enlighten me. And do you know if this has been reported as a bug? Can't seem to find that either... Thanks in advance! Frank -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto: webkit-dev-boun...@lists.webkit.org] On Behalf Of Brent Fulgham Sent: 31. marts 2009 01:04 To: xiong Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] ［GTK］Scroll deficiency Hi Xiong, Thanks for trying these suggestions. On Sun, Mar 29, 2009 at 8:24 PM, xiong browse...@gmail.com wrote: Brent, In my platform, all the hack as you metioned are valueless. Bad news to me. Now, i only have a clue on cario for the scroll problem. I think we may have two separate (but perhaps related) bugs, because the workarounds I described do not help your problem. Furthermore, the change you suggested (comment out the if (contentChanged) test in ChromeClient::repaint ()) does not resolve my problem, while it does fix yours. Thanks, -Brent ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Srinivas Rao M Hamse -- Srinivas Rao M Hamse ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NWFPE: GtkLauncher takes exception
Hi, After a bit of code study and analysing map files found out from where these exceptions are generated. Also my ARM does not have any floating point hardware .. also the toolchain in Not Soft float ! I guess The kernel should fixes these using FPE, But when kernel is handling these exceptions, it results in performance hit. They are being generated from two places from JavaScriptCore/kjs modules: 1. *static JSObject* constructDate(ExecState* exec, JSObject*, const ArgList args)* 7NWFPE: GtkLauncher[1456] takes exception 0001 at c0034290 from 40ae12a0 - 0xAC32A0 - and - 2. *int32_t JSValue::toInt32SlowCase(double d, bool ok)* 7NWFPE: GtkLauncher[1456] takes exception 0001 at c00346dc from 40aada60 0xA8FA60 - These modules call floating point library functions such as fmod(), floor(), etc., Any help available to fix these exceptions ? regards, Srinivas Rao. M On Sat, Dec 13, 2008 at 6:30 PM, Srinivas Rao M Hamse msrini...@gmail.comwrote: Hi, I am using WebKit on Gtk Directfb on ARM platform. I am getting couple NWFPE exception thrown on console. 7NWFPE: GtkLauncher[1456] takes exception 0001 at c0034290 from 40ae12a0 Has anyone got this exception. How to resolve this issue. Also when this exception happen, does this slow processor execution. regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com -- Srinivas Rao M Hamse ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] NWFPE: GtkLauncher takes exception
Hi, I am using WebKit on Gtk Directfb on ARM platform. I am getting couple NWFPE exception thrown on console. 7NWFPE: GtkLauncher[1456] takes exception 0001 at c0034290 from 40ae12a0 Has anyone got this exception. How to resolve this issue. Also when this exception happen, does this slow processor execution. regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] WebKit partial rendering issue
Thanks Paul,
I have logged this issue in
https://bugs.webkit.org/show_bug.cgi?id=22540
regards,
Srinivas Rao. M
On Fri, Nov 28, 2008 at 2:04 PM, Paul Pedriana [EMAIL PROTECTED] wrote:
The ScrollView::paint function seems wrong to me too.
The function source is shown below. I don't understand why it uses
context-clip(visibleContentRect()) without accounting for
documentDirtyRect. Shouldn't it make a union of visibleContentRect and
documentDirtyRect? I am writing my own graphics back-end and this lack of
clipping is messing up the view drawing.
An simple example of how the screen gets messed up is when you go to
www.google.com and once the page is drawn you simply mouse over one of its
two buttons. WebKit calls ScrollView::paint with a rect of the button area
and during its rendering in paintContents it proceeds to draw a
button-height/screen-width white rectangle before drawing that one button
and without pushing a graphics context with the clip rect. This white
rectangle is thus not clipped and blows away all pixels to the left and
right of the button area, including the other button. If documentDirtyRect
clipping was done then this wouldn't happen. Doing it seems to fix it for me
though my testing is meager and it may be that somehow there's a more
correct solution.
void ScrollView::paint(GraphicsContext* context, const IntRect rect)
{
if (platformWidget()) {
Widget::paint(context, rect);
return;
}
if (context-paintingDisabled() !context-updatingControlTints())
return;
IntRect documentDirtyRect = rect;
documentDirtyRect.intersect(frameRect());
context-save();
context-translate(x(), y());
documentDirtyRect.move(-x(), -y());
context-translate(-scrollX(), -scrollY());
documentDirtyRect.move(scrollX(), scrollY());
context-clip(visibleContentRect());
Seems wrong to me.
paintContents(context, documentDirtyRect);
context-restore();
.
.
.
}
I've seen similar issues on a non-DirectFB port, but it turned out to be
related to a bug in the ScrollView::paint() method. It wasn't properly
clipping the drawing and when Google was blinking the cursor in the text
box, it ends up erasing the whole window instead of just the inner textbox.
Anything that forces a redraw of the widget, of course, fixes it as it will
then render the whole area, not just the cursor. I saw it when going to
www.apple.com and watching the updating news area, the headlines change
and the title Hot New Headlines would get erased everytime it updated.
dunno if that's helpful or not.
On Nov 27, 2008, at 9:35 AM, Srinivas Rao M Hamse wrote:
Hi,
I am using WebKit+Gtk on DirectFB 1.2.0 ported on an arm platform. I am
noticing that the render of text input widget is not complete. Attaching a
snapshot of google page. In this google text input text box in not drawn.
Also seen this issue while rendering other widgets also. WebKit misses some
of them at first go. It slowly draws as and when that part of the
screen/widget gets refreshed(say by pressing TAB keys)
Any idea how to fix this issue ?
regards,
Srinivas Rao M.
--
Srinivas Rao M Hamse
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
--
Srinivas Rao M Hamse
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Font problems with WebKit port for GTK-DirectFB
This means that the application is unable to find fonts. configure pango modules by running pango-query modules and update your font cache by running fc-cache This should help Srinivas On Wed, May 21, 2008 at 10:15 AM, Yair Raz [EMAIL PROTECTED] wrote: Hi, After a lot of struggle, I was able to build WebKit targeting GTK DirectFB. (I used the Safari-3-1-stable branch on Ubuntu 8.04). When I ran it (GtkLauncher) I got the following screen: If you notice, the text and text box are almost invisible. Any idea why? How can I fix that? Thanks, Yair -- Yair Raz Raztek Solutions, Inc. www.raztek-inc.com [EMAIL PROTECTED] Phone: (408) 499-7025 Fax: (408) 746-2806 -- ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Srinivas Rao M Hamse http://msrinirao.blogspot.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] _blank hrefs and new windows
Hi David,
Updated https://bugs.webkit.org/show_bug.cgi?id=16562 buglog with my
observations as comments.
regards,
Srinivas Rao. M
On Wed, Apr 16, 2008 at 8:29 PM, David Kilzer [EMAIL PROTECTED] wrote:
is there a way to get this patch working on the latest builds ?
Please add these comments to the bug itself. Perhaps the author of the
patch
will revise it for a later revision.
Dave
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote:
Hi David,
Have you tried applying the patch to see if it fixes the issue on your
local
tree?
First of all the patch file was not compatible with the latest
nightlies(r31848). Hence i manually applied the those hunks that were
failing to respective files. I could compile and build GtkLauncher. I
was
unable to open any new window/popup when i click on the following href
links
html
body
HTML version
a href=a.html target=_blankOpen window/a
br
Javascript version
a href=javascript:window.open('a.html', '_blank')Open window/a
/body
/html
On the console i got the following error messages, This came only for
the
first time:
for HTML Version i got :
UNIMPLEMENTED:
(../WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:770 virtual
WebCore::Frame* WebKit::FrameLoaderClient::dispatchCreatePage())
UNIMPLEMENTED:
(../WebCore/page/gtk/EventHandlerGtk.cpp:85 bool
WebCore::EventHandler::eventActivatedView(const
WebCore::PlatformMouseEvent) const)
for JavaScript Version I got:
UNIMPLEMENTED:
(../WebKit/gtk/webkit/webkitwebview.cpp:488 void
webkit_web_view_real_window_object_cleared(WebKitWebView*,
WebKitWebFrame*,
OpaqueJSContext*, OpaqueJSValue*))
UNIMPLEMENTED:
(../WebCore/platform/gtk/PlatformScreenGtk.cpp:73 WebCore::FloatRect
WebCore::screenAvailableRect(WebCore::Widget*))
UNIMPLEMENTED:
(../WebKit/gtk/webkit/webkitwebview.cpp:481 WebKitWebView*
webkit_web_view_real_create_web_view(WebKitWebView*))
is there a way to get this patch working on the latest builds ?
regards,
Srinivas Rao. M
Dave
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote:
Hi David,
Do you have any updates on this bug
(#16562http://bugs.webkit.org/show_bug.cgi?id=16562)?
When do we get the working version of this feature ?
regards,
Srinivas Rao. M
On Fri, Apr 11, 2008 at 9:27 PM, David Kilzer [EMAIL PROTECTED]
wrote:
Great! I just didn't recall seeing that listed before.
Dave
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote:
Hi David,
There is already a logged bug. Is this not sufficient ?
http://bugs.webkit.org/show_bug.cgi?id=16562
regards,
Srinivas.
On Fri, Apr 11, 2008 at 7:53 PM, David Kilzer
[EMAIL PROTECTED]
wrote:
Artem,
Please file a bug on https://bugs.webkit.org/ with a
reproducible
test
case.
Thanks!
Dave
Artem Ananiev [EMAIL PROTECTED] wrote:
I have just tried GtkLauncher and it doesn't handle _blank
target
also.
Thus, it looks like a problem in a shared WebKit code, not
specific
to
out Java port...
Thanks,
Artem
Artem Ananiev wrote:
Hi,
I have experienced the following problem with WebKit (Java
port).
The
page code is simple:
a href=a.html target=_blankOpen window/a
a href=javascript:window.open('a.html',
'_blank')Open
window/a
When I right-click on the first link and select 'Open in a
new
window'
from context menu, a new window is created and shown -
that's
fine.
However, left-click on the first link loads the page
'a.html'
in
the
same window - this looks strange to me as the target is
_blank.
The second link behaves as expected: it opens a new window
with
left-click and does nothing with right click.
I suppose target=_blank is handled completely
differently
than
opening
a new window with a context menu. Is it related to popup
blocking
and
different policies in FrameLoaderClient class? Another
strange
thing
is
that I couldn't find any references to
ChromeClient::createWindow()
method - it is responsible for creating a new window, at
least
triggered
from context menu - other than from
ContextMenuController...
Thanks,
Artem
--
Srinivas Rao M Hamse
--
Srinivas Rao M Hamse
--
Srinivas Rao M Hamse http://msrinirao.blogspot.com
--
Srinivas Rao M Hamse http://msrinirao.blogspot.com
Re: [webkit-dev] _blank hrefs and new windows
Hi David,
Have you tried applying the patch to see if it fixes the issue on your local
tree?
First of all the patch file was not compatible with the latest
nightlies(r31848). Hence i manually applied the those hunks that were
failing to respective files. I could compile and build GtkLauncher. I was
unable to open any new window/popup when i click on the following href links
html
body
HTML version
a href=a.html target=_blankOpen window/a
br
Javascript version
a href=javascript:window.open('a.html', '_blank')Open window/a
/body
/html
On the console i got the following error messages, This came only for the
first time:
for HTML Version i got :
UNIMPLEMENTED:
(../WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:770 virtual
WebCore::Frame* WebKit::FrameLoaderClient::dispatchCreatePage())
UNIMPLEMENTED:
(../WebCore/page/gtk/EventHandlerGtk.cpp:85 bool
WebCore::EventHandler::eventActivatedView(const
WebCore::PlatformMouseEvent) const)
for JavaScript Version I got:
UNIMPLEMENTED:
(../WebKit/gtk/webkit/webkitwebview.cpp:488 void
webkit_web_view_real_window_object_cleared(WebKitWebView*, WebKitWebFrame*,
OpaqueJSContext*, OpaqueJSValue*))
UNIMPLEMENTED:
(../WebCore/platform/gtk/PlatformScreenGtk.cpp:73 WebCore::FloatRect
WebCore::screenAvailableRect(WebCore::Widget*))
UNIMPLEMENTED:
(../WebKit/gtk/webkit/webkitwebview.cpp:481 WebKitWebView*
webkit_web_view_real_create_web_view(WebKitWebView*))
is there a way to get this patch working on the latest builds ?
regards,
Srinivas Rao. M
Dave
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote:
Hi David,
Do you have any updates on this bug
(#16562http://bugs.webkit.org/show_bug.cgi?id=16562)?
When do we get the working version of this feature ?
regards,
Srinivas Rao. M
On Fri, Apr 11, 2008 at 9:27 PM, David Kilzer [EMAIL PROTECTED]
wrote:
Great! I just didn't recall seeing that listed before.
Dave
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote:
Hi David,
There is already a logged bug. Is this not sufficient ?
http://bugs.webkit.org/show_bug.cgi?id=16562
regards,
Srinivas.
On Fri, Apr 11, 2008 at 7:53 PM, David Kilzer [EMAIL PROTECTED]
wrote:
Artem,
Please file a bug on https://bugs.webkit.org/ with a
reproducible
test
case.
Thanks!
Dave
Artem Ananiev [EMAIL PROTECTED] wrote:
I have just tried GtkLauncher and it doesn't handle _blank
target
also.
Thus, it looks like a problem in a shared WebKit code, not
specific
to
out Java port...
Thanks,
Artem
Artem Ananiev wrote:
Hi,
I have experienced the following problem with WebKit (Java
port).
The
page code is simple:
a href=a.html target=_blankOpen window/a
a href=javascript:window.open('a.html', '_blank')Open
window/a
When I right-click on the first link and select 'Open in a new
window'
from context menu, a new window is created and shown - that's
fine.
However, left-click on the first link loads the page 'a.html'
in
the
same window - this looks strange to me as the target is
_blank.
The second link behaves as expected: it opens a new window
with
left-click and does nothing with right click.
I suppose target=_blank is handled completely differently
than
opening
a new window with a context menu. Is it related to popup
blocking
and
different policies in FrameLoaderClient class? Another strange
thing
is
that I couldn't find any references to
ChromeClient::createWindow()
method - it is responsible for creating a new window, at least
triggered
from context menu - other than from ContextMenuController...
Thanks,
Artem
--
Srinivas Rao M Hamse
--
Srinivas Rao M Hamse
--
Srinivas Rao M Hamse http://msrinirao.blogspot.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Patch for compilation error while building with gcc 4.x compilers on latest nightlies
Thanks Darin David for inputs.
Patches for review should go in bugs.webkit.org, but I think it's worth
mentioning a couple problems I see immediately.
This incorrectly removes the protected for non-GCC compilers and in fact
may not even compile there because __GNUC__ is not defined and there's no
check of it. And the check here says 4, which means the protected is
included only for GCC 5 and newer.
-- Darin
I have logged this issue here:
https://bugs.webkit.org/show_bug.cgi?id=18507
Please review the attached patch file contents:
--- a/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-12
04:28:00.0 +0530
+++ b/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-14
19:04:26.0 +0530
@@ -207,7 +207,9 @@
// Used to optimize those nodes that do extra work when returning a
result, even if the result has no semantic relevance
virtual void optimizeForUnnecessaryResult() { }
+#if !COMPILER(GCC) || (COMPILER(GCC) __GNUC__ = 4)
protected:
+#endif
typedef enum { EvalOperator, FunctionCall } CallerType;
template CallerType, bool inline JSValue*
resolveAndCall(ExecState*, const Identifier, ArgumentsNode*, size_t = 0);
};
regards,
Srinivas Rao. M
--
Srinivas Rao M Hamse http://msrinirao.blogspot.com
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] _blank hrefs and new windows
Hi David,
Do you have any updates on this bug
(#16562http://bugs.webkit.org/show_bug.cgi?id=16562)?
When do we get the working version of this feature ?
regards,
Srinivas Rao. M
On Fri, Apr 11, 2008 at 9:27 PM, David Kilzer [EMAIL PROTECTED] wrote:
Great! I just didn't recall seeing that listed before.
Dave
Srinivas Rao M Hamse [EMAIL PROTECTED] wrote:
Hi David,
There is already a logged bug. Is this not sufficient ?
http://bugs.webkit.org/show_bug.cgi?id=16562
regards,
Srinivas.
On Fri, Apr 11, 2008 at 7:53 PM, David Kilzer [EMAIL PROTECTED]
wrote:
Artem,
Please file a bug on https://bugs.webkit.org/ with a reproducible
test
case.
Thanks!
Dave
Artem Ananiev [EMAIL PROTECTED] wrote:
I have just tried GtkLauncher and it doesn't handle _blank target
also.
Thus, it looks like a problem in a shared WebKit code, not specific
to
out Java port...
Thanks,
Artem
Artem Ananiev wrote:
Hi,
I have experienced the following problem with WebKit (Java port).
The
page code is simple:
a href=a.html target=_blankOpen window/a
a href=javascript:window.open('a.html', '_blank')Open
window/a
When I right-click on the first link and select 'Open in a new
window'
from context menu, a new window is created and shown - that's
fine.
However, left-click on the first link loads the page 'a.html' in
the
same window - this looks strange to me as the target is _blank.
The second link behaves as expected: it opens a new window with
left-click and does nothing with right click.
I suppose target=_blank is handled completely differently than
opening
a new window with a context menu. Is it related to popup blocking
and
different policies in FrameLoaderClient class? Another strange
thing
is
that I couldn't find any references to
ChromeClient::createWindow()
method - it is responsible for creating a new window, at least
triggered
from context menu - other than from ContextMenuController...
Thanks,
Artem
--
Srinivas Rao M Hamse
--
Srinivas Rao M Hamse
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Patch for compilation error while building with gcc 4.x compilers on latest nightlies
*'
increases required alignment of target type
In file included from ../JavaScriptCore/kjs/AllInOneFile.cpp:55:
../JavaScriptCore/kjs/nodes.cpp: At global scope:
../JavaScriptCore/kjs/nodes.h:213: error: `typedef enum
KJS::ExpressionNode::CallerType KJS::ExpressionNode::CallerType' is
protected
../JavaScriptCore/kjs/nodes.cpp:1090: error: within this context
make[1]: *** [JavaScriptCore/kjs/libJavaScriptCore_la-AllInOneFile.lo] Error
1
make[1]: Leaving directory `/home/srinirao/webkit/WebKit-r31848/objdir'
make: *** [all] Error 2
Patch file contains:
--- a/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-12
04:28:00.0 +0530
+++ b/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-14
19:04:26.0 +0530
@@ -207,7 +207,9 @@
// Used to optimize those nodes that do extra work when returning a
result, even if the result has no semantic relevance
virtual void optimizeForUnnecessaryResult() { }
+#if __GNUC__ 4
protected:
+#endif
typedef enum { EvalOperator, FunctionCall } CallerType;
template CallerType, bool inline JSValue*
resolveAndCall(ExecState*, const Identifier, ArgumentsNode*, size_t = 0);
};
regards,
Srinivas Rao. M
--
Srinivas Rao M Hamse http://msrinirao.blogspot.com
--- a/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-12 04:28:00.0 +0530
+++ b/WebKit-r31848/JavaScriptCore/kjs/nodes.h 2008-04-14 19:04:26.0 +0530
@@ -207,7 +207,9 @@
// Used to optimize those nodes that do extra work when returning a result, even if the result has no semantic relevance
virtual void optimizeForUnnecessaryResult() { }
+#if __GNUC__ 4
protected:
+#endif
typedef enum { EvalOperator, FunctionCall } CallerType;
template CallerType, bool inline JSValue* resolveAndCall(ExecState*, const Identifier, ArgumentsNode*, size_t = 0);
};
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Opening New Window doesn't work in Gtk port of Webkit.
Hi, I am using the latest build r31738. My intention is to being able to open the href link on the same window, instead of opening a fresh window for it. When i click New Window! button available at: http://www.pageresource.com/jscript/jwinopen.htm I get nothing changed on screen. I see most of these functions in FrameLoaderClientGtk.cpp are unimplemented for GTK, But their respective counterpart functions for mac and windows architecture are implemented. I saw a bug being logged to handle this issue. http://bugs.webkit.org/show_bug.cgi?id=16562 Also applied the Proposed patch http://bugs.webkit.org/attachment.cgi?id=19530action=view . After applying this patch, i see that the function * FrameLoaderClient::dispatchDecidePolicyForNewWindowAction* is still not being called, when i click on New Window! button in the above mentioned link. IS there a different patch available for this feature to work on the latest builds ? Am i missing something trivial here. regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Webkit with directfb on linux
Mike, Finally if your using this for thumbnails I also have so zooming patches. What do you mean by zooming patches ?. Is the full page zooming works ? Do you have it for Gtk+DirectFB builds ? regards, Srinivas On Thu, Apr 3, 2008 at 11:34 PM, Mike Emmel [EMAIL PROTECTED] wrote: Yes if you need help with your setup i.e no X11 I have some patches. Also I have some pure memory driver patches for DirectFB itself that I need to push. Finally if your using this for thumbnails I also have so zooming patches. On Thu, Apr 3, 2008 at 10:06 AM, Giri Rao [EMAIL PROTECTED] wrote: Hello, I was wondering if anyone has successfully built webkit with target set to directfb (as opposed to X11) on linux. I have a successful gtk build which is running fine. However, I would like to run webkit on a headless linux machine hence the question. Thanks Giri ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- Srinivas Rao M Hamse http://msrinirao.blogspot.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] https pages crashes WebKit(GTK+DFB) on ARM
Hi I am trying to run WebKit-r30790 build on ARM target. I have disabled server Peer certification by setting the environment variable WEBKIT_IGNORE_SSL_ERRORS while running. with this setup, I am able to open simple https sites like *https://horizon.opensrs.net* But webkit crashes when i open sites like * https://opensrs.net https://sourceforge.net* * https://mail.google.com* It segfaults after dumping the following log on console: # pwd /sr/docs/webkit/WebKit-r30790.davinci.directfb/debugbuild/Programs/.libs # # ./GtkLauncher https://sourceforge.net ===| DirectFB 1.1.1 |=== (c) 2001-2007 The DirectFB Organization (directfb.org) (c) 2000-2004 Convergence (integrated media) GmbH (*) DirectFB/Core: Single Application Core. (2008-02-26 11:33) (*) Direct/Thread: Running 'VT Switcher' (CRITICAL, 2945)... init_ir_loop Inintializing IR msp430lib_set_params: success (*) Direct/Thread: Running 'LiRC Input' (INPUT, 2952)... (*) DirectFB/Input: LIRC Device 0.2 (directfb.org) (!) Direct/Modules: Could not open module directory `/home/srinirao/directfb/lib/directfb-1.1-0-pure/gfxdrivers'! -- No such file or directory (*) DirectFB/Graphics: Generic Software Rasterizer 0.6 (directfb.org) (*) DirectFB/Core/WM: Default 0.3 (directfb.org) (*) FBDev/Mode: Testing 720x480 RGB16 (*) FBDev/Mode: Preparing switch to 720x480 RGB16 (*) FBDev/Mode: Testing 720x480 RGB16 (*) FBDev/Mode: Preparing switch to 720x480 RGB16 (*) FBDev/Mode: Testing 720x480 RGB16 (*) FBDev/Mode: Preparing switch to 720x480 RGB16 (*) FBDev/Mode: Testing 720x480 RGB16 (*) FBDev/Mode: Preparing switch to 720x480 RGB16 (*) FBDev/Mode: Testing 720x480 RGB16 (*) FBDev/Mode: Preparing switch to 720x480 RGB16 (*) FBDev/Surface: Allocated 720x480 16bit RGB16 buffer at offset 0 and pitch 1440. (*) FBDev/Mode: (Post)Setting 720x480 RGB16 (*) FBDev/Mode: Switched to 720x480 (720x480) at 16 bit RGB16 (wanted RGB16). (*) FBDev/Mode: Testing 720x480 RGB16 (*) FBDev/Mode: Preparing switch to 720x480 RGB16 (*) FBDev/Mode: (Post)Setting 720x480 RGB16 gdkdisplay-directfb.c:122: Getting the return value as 0 (*) Direct/Thread: Running 'EventBufferFeed' (MESSAGING, 2953)... (GtkLauncher:2921): GdkPixbuf-WARNING **: Cannot open pixbuf loader module file '/home/srinirao/gtk/etc/gtk-2.0/gdk-pixbuf.loaders': No such file or director y (GtkLauncher:2921): Gdk-DirectFB-WARNING **: gdk_display_request_selection_notification Unimplemented function (GtkLauncher:2921): Gdk-DirectFB-WARNING **: gdk_window_set_keep_above() not implemented. (GtkLauncher:2921): Gdk-DirectFB-WARNING **: gdk_window_set_keep_below() not implemented. (!) [ 2921:0.000] -- Caught signal 11 (at 0x3000, invalid address) -- (!!!) *** WARNING [still objects in 'Layer Region Pool'] *** [object.c:241 in fusion_object_pool_destroy()] (!!!) *** WARNING [still objects in 'Layer Context Pool'] *** [object.c:241 in fusion_object_pool_destroy()] (!!!) *** WARNING [setting window-stack = NULL] *** [default.c:2894 in wm_close_stack()] (!!!) *** WARNING [setting window-stack = NULL] *** [default.c:2894 in wm_close_stack()] (!!!) *** WARNING [setting window-stack = NULL] *** [default.c:2894 in wm_close_stack()] (!!!) *** WARNING [still objects in 'Window Pool'] *** [object.c:241 in fusion_object_pool_destroy()] (!!!) *** WARNING [still objects in 'Surface Pool'] *** [object.c:241 in fusion_object_pool_destroy()] Aborted # But curl application on board with -k option(Does the same thing) for these URLs, fetches these pages properly. I feel the crash is happening at some other module. Has any one faced the similar issue with https pages ?. Please help. regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Full page zooming support on WebKit over GTK
Hi Alp, I was trying to enable the full page zooming support on WebKit (on Gtk build over DirectFB). While searching the previous archives i found that there is already a bug logged http://bugs.webkit.org/show_bug.cgi?id=14998 . Presently it is in un-assigned state. I found a couple of patches suggested to implement the Full Page zooming support. I am presently using the latest builds. The patch(attached with this bug log) does not seem to be compatible with the current versions. Has anyone tried adding this support with the existing code releases ? Any pointers will be greatly helpful. regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] issue with Webkit on gtkdirectfb
Hi, I tried to build latest webkit (r30082) on ARM using gtkdirectfb with input driver as LIRC. I am able to get the GtkLauncher up and running. I have a problem with this configuration in typing keys in the input text box widget of html pages. ISSUE1: HTML Input Element not working The default web page www.google.com page opens up. I am able to key in characters through the remote when the focus is present in the webkit's address bar(where we enter URLs). But i am not able to key in any input through remote when i bring the focus to the text input box ( where we enter search strings). The key inputs are sensed at the driver level. I have found through the gdb the keyed inputs are coming till HTMLInputElement::defaultEventHandler(Event* evt) function. But it will never get displayed into the input text box. From the code I couldn't decipher where and how the flow for character inputs. When i switch back to the address bar( using TAB key press), the key pressed characters continue to display. Do you have any idea as to where i should look for sorting this issue. I guess the key press events are not getting dispatched. The similar issue was present in earlier build r26699 also. ISSUE 2: Font rendering: The output is as seen at: http://msrinirao.blogspot.com/search/label/webkit Please give me pointers to solve this issue. regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Issues with font rendering on DirectFB build
I am posting the same question to everybody on the list. Any updates on this ? regards, Srinivas Rao. M On Feb 11, 2008 10:08 AM, Sriram Neelakandan [EMAIL PROTECTED] wrote: Hi Are u seeing problems similar to this : http://msrinirao.blogspot.com/search/label/webkit If u notice closely the pictures attached have tiny fonts. Have u found a solution to your problem ? Just wondering if both of you could be seeing the same problem. regards Sriram On Feb 8, 2008 8:07 PM, Rachel Bassett [EMAIL PROTECTED] wrote: Hi, I'm working on a cross compiled build using DirectFB, gtk+, WebKit build too, however I get no fonts at all! I get images, buttons, etc but no text. I've tested gtk+ with gtk-demo and fonts appear correctly there, I've rebuilt my fontconfig cache and checked (using strace) all the font files get found and opened as expected, however I see no text. Any hints welcome. Thanks Rachel ___ Yahoo! Answers - Got a question? Someone out there knows the answer. Try it now. http://uk.answers.yahoo.com/ ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev -- Sriram Neelakandan Author - Embedded Linux System Design And Development ( http://tinyurl.com/2doosu) -- Srinivas Rao M Hamse ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Issues with font rendering on DirectFB build
Hi, Compiled the latest WebKit-r30082 for both X11 and DirectFB targets on Linux PC. The X11 worked fine but the build with Directfb showed the font rendering problem. Has anyone faced this problem ? Am i missing out anything trivial here ? I have posted the screen snapshot at : http://msrinirao.blogspot.com/search/label/webkit regards, Srinivas Rao. M -- Srinivas Rao M Hamse http://msrinirao.blogspot.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
