Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)
On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote: Step (2) here involves coming up with a good solution for export control in both the WTF and platform cases. Today we use an explicit .exp file for JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple Windows WebKit port. So there might be a necessary first step of moving to a different export approach. And I know someone has been working on that. If you guys want to go the route of finishing up the export macros work, let me know and I'll see what I can do. I probably can't devote a lot of time to it for the next week or two, but I'd like to see this fixed regardless of if it's used to move forward the WTF split, obviously, so I can put a higher priority on it if I know there are reviewers waiting to land things. :) FWIW, I did distinguish between JS and WTF symbol export macros in the work I've been doing, so the macros approach will support the split as-is. If WTF is to be a static library, there's no need to change anything in the .def file on Windows. .def files apply only to DLLs. FWIW, WTF is already a static library in Apple's Windows port, just self-contained inside the JavaScriptCore project. See: http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj -steve ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] The tree is on fire
Fixed in http://trac.webkit.org/changeset/53743 -steve On Jan 22, 2010, at 5:37 PM, Jian Li wrote: There is another show stopper caused by http://trac.webkit.org/changeset/53740. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Towards a More Convenient IWebUIDelegate
On Dec 2, 2009, at 9:53 PM, Brent Fulgham wrote: To add insult to injury, all of these interface classes also require each concrete implementation to implement a stub QueryInterface, AddRef, and RemoveRef method. Yes, this is one of the downsides of COM. Some COM developers use ATL (or similar) to avoid boilerplate implementations of AddRef/Release/ QueryInterface. For my own purposes, I created a concrete class WebUIDelegate that stubs all methods as E_NOTIMPL and provides the boilerplate QueryInterface, AddRef, etc.. I subclass from *this* class as my delegate, which allows me to simply write one method that does the menu customization. Sounds similar to what we do. Couldn't the Windows version of WebKit either stub the IWebUIDelegate with the requisite E_NOTIMPL stubs, or perhaps ship with a set of pre-generated stub classes like the one I just created, to avoid this kind of drudgery? COM interfaces are pure virtual, so there is no implementation of IWebUIDelegate in WebKit. We could provide a concrete CLSID_WebUIDelegate that was instantiatable via (our version of) CoCreateInstance but you wouldn't be able to subclass it. We don't export any of the WebKit COM API directly through DLL exports. All of these conventions were critically important when the COM API was remotable via DCOM in order for Drosera (Web Inspector in its previous iteration) to work out-of-process. Some of this isn't as important now, but we'd like to maintain compatibility for existing clients. -steve ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] New requirement for building on Windows coming
On Nov 24, 2009, at 11:12 AM, Alexey Proskuryakov wrote: Can we make a local copy of those? For internal developers, we should just submit the SDK into BI and then it can be included in the SDK we install already to C:\AppleInternal. Probably we can just submit what we have checked into the internal tree here: https://trac-safari.apple.com/repository/safari/browser/trunk/Safari/Libraries/win/DirectX-SDK-2004-12 -steve ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] New requirement for building on Windows coming
On Nov 24, 2009, at 11:17 AM, Steve Falkenburg wrote: Probably we can just submit what we have checked into the internal treees/win/DirectX-SDK-2004-12 Of course that wouldn't help open source contributors, so installing the SDK as a prerequisite for development makes sense. -steve ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] VS2005 debugger complains that webkit.pdb does not match with webkit.dll
You can use registry free COM to do this in that older revision. I believe WinLauncher and/or DumpRenderTree did this during that time. Or, just update to the newer rev or merge the changes yourself. -steve Brent Fulgham wrote: Hi, Thanks Brent. But I searched my webkit source for WebKitCreateInstance and found nothing. My source is r41121 Nightly Build. Is WebKitCreateInstance unavailable in r41121? I'm sorry -- you are correct. http://trac.webkit.org/browser/trunk/WebKit/win/WebKitCOMAPI.h; shows me that it was added in @r42726. -Brent 原始信息 主题: Re: [webkit-dev] VS2005 debugger complains that webkit.pdb does not match with webkit.dll 发件人: Brent Fulgham bfulg...@gmail.com 收件人: 张雷 zhang@kortide.com.cn 抄送: WebKit Development webkit-dev@lists.webkit.org 日期: 2009-6-20 12:18 Hi, I would suggest that you avoid using the CoCreateInstance mechanism for instantiation of the WebKit types, and instead use the new 1. Include the header WebKit/WebKitCOMAPI.h 2. Link against the WebKitGUID.lib and WebKit.lib 3. Create your object like so: HRESULT hr = WebKitCreateInstance(CLSID_WebView, 0, IID_IWebView, (void**)gWebView); The advantages are: 1. No need to manipulate Internal COM or other manifest stuff. 2. No more errors that COM can't find your WebKit objects. 3. Your application will not get confused about Safari's DLL's and your own DLL's (assuming you put your WebKit.dll in the same path with your application.) Good luck! -Brent On Jun 19, 2009, at 8:47 PM, 张雷 wrote: Sorry, I didn't notice that the webkit.dll was not the one I built but the one under Safari install dir. What's more, I missed to make it clear that I writes a minibrowser of my own, not the WinLauncher demo. And I find that CoCreateInstance(CLSID_WebView, 0, CLSCTX_ALL, IID_IWebView, (void**)m_webView); always locates the webkit.dll under Safary install dir rather than the one I compiled no matter what path env I set. If I rename the one under Safari dir, then CoCreateInstance(CLSID_WebView, ...) fails! Do I need to register my webkit.dll as a COM server every time I launch my minibrowser for debug? However, I also want my Safari working without effects. So, any suggestions? 原始信息 主题: [webkit-dev] VS2005 debugger complains that webkit.pdb does not match with webkit.dll 发件人: 张雷 zhang@kortide.com.cn 收件人: WebKit Development webkit-dev@lists.webkit.org 日期: 2009-6-20 10:45 Hey, dear friends. I succeeded building WebKit from within VS2005 IDE with your helps. But I encountered another problem: when I was debugging with webkit.dll, no symbols for that dll was loaded and the debugger complained that no proper PDB found for webkit.dll, though webkit.pdb was placed exactly in the same folder with webkit.dll. I tried manually specifying the webkit.pdb file for the webkt.dll. But the compiler refused the pdb file for mismatch. My platform and compliler tools are: WinXP with sp3 Visual Studio 2005 Professional with sp1 I followed exactyly what the building instructions says and set WEBKITOUTPUTDIR and WEBKITLIBRARIESDIR and did no change to any build script. Did you ever enconter this problem before and how did you fix it? Many thanks for any help :) ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] JS_EXPORT addition
The Apple Windows port uses a JavaScriptCore.def file to specify the remaining exports. -steve On Apr 25, 2009, at 2:42 PM, Kevin Ollivier kev...@theolliviers.com wrote: Hi all, I'm trying to update the wx port after the addition of JS_EXPORT and the idea of exporting symbols. However, I'm noticing that jsc.cpp, for example, uses numerous functions / classes which are not part of JavaScriptCore/API and are not declared with JS_EXPORT. How is it that jsc.exe is being linked properly while using private functions of JavaScriptCore.dll on the Apple / GTK ports? Thanks, Kevin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Successful Webkit Build on Windows but Error Running Webkit
We don't support VC++ Express 2008 at this point. 2005 is still available for download, and can be installed alongside 2008. There's a link to the 2005 download at: http://webkit.org/building/tools.html 2008 doesn't work at the moment since we haven't converted all of the dependent DLLs to 2008. That conversion is necessary since 2008 uses a newer version of the C runtime library. (Before someone asks, yes, we could load both versions into memory, but some of the dependent DLLs are missing manifests, and can't locate the 2005 C runtime lib themselves.) -steve On Mar 14, 2008, at 10:32 AM, Tiger Code wrote: Hi All, I am and experienced Java developer and new to Windows programming (VC++). I have installed Cygwin and VC++ 2008 Express Edition. I have checked out Webkit source I converted WebKit project to VC++ Visual Studio 9.0 project I have compiled Webkit successfully. However when I run : ~/webkit-src/WebKit/WebKitTools/Scripts/run-safari I get the following Output and Error Message in Windows Dialog Box: Output: $ WebKitTools/Scripts/run-safari 0 File(s) copied 0 File(s) copied 0 File(s) copied Error Message in Windows Dialog Box: Safari cannot open a browser window and may be missing important resources. Try installing Safari again. Safari installation is fine and use it well. Why is this happening and how can I get around this problem? Thanks, TC ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
