Re: [webkit-dev] Who are the EFL reviewers?

[Tomasz Morawski]

Hi,
Is it possible to promote some other peoples to reviewers in the EFL
port?

Tomasz


The problem is that as I am not working on the port myself, I find it
quite hard to review their API's without getting input from someone
else working on EFL.

I think Antonio feels likewise.

Kenneth

On Mon, Apr 11, 2011 at 2:13 AM, Antonio Gomestoniki...@gmail.com  wrote:

Mostly myself and Kenneth. We do what we can, but we also to work on our
stuff (as everybody else :). It really needs other reviewers to help out
with reviewing, since EFL port guys are working really hard on it.

On Sun, Apr 10, 2011 at 7:51 PM, Eric Seidele...@webkit.org  wrote:


We seem to have a zillion EFL patches up for review.
Who are the EFL reviewers?
(I think part of the trouble is that it seems the EFL port is trying to do
too much in WebKit.  I'm not sure where the EFL browser is, but some of the
patches look like they should be re-directed to that project instead of
WebKit.)
-eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev





--
--Antonio Gomes

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev








___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] InspectorDebuggerAgent::didPause function

[Tomasz Morawski]

Hi,
Is there any way to get know if InspectorDebuggerAgent::didPause call 
was due to an exception or not? I have tried to use 
scriptState-hadException() inside this function but it seems that the 
hadException function always returns false.


Thanks,
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] InspectorDebuggerAgent::didPause function

[Tomasz Morawski]

Hi Jamey,
Yes, I am using JSC.


I have a patch for JavaScriptCore to let you determine if an exception
happened and what it was, if you're using JSC instead of V8.

Could you provide this patch?


We found that users of the front-end wanted to know if the pause was due
to an exception, and if so, what it was.

Yes, it is very useful. Is there any plans to add this feature into
WebKit?

Thanks,



Jamey

On Oct 19, 2010, at 9:12 AM, ext Yury Semikhatsky wrote:


Hi Tomasz,

There is no need to differentiate between pause due to an exception
and due to a breakpoint hit and there are no means to determine that
in InspectorDebuggerAgent::didPause. Detailed information about the
break event is available in
WebCore/bindings/v8/ScriptDebugServer::handleV8DebugEvent(I believe it
can be retrieved in WebCore/bindings/js/ScriptDebugServer too) where
we can say whether it was an exception or not, we just don't push it
to InspectorDebuggerAgent since we don't need it in the front-end.

-yury

On Tue, Oct 19, 2010 at 5:01 PM, Tomasz Morawski
t.moraw...@samsung.com mailto:t.moraw...@samsung.com wrote:

Hi,
Is there any way to get know if InspectorDebuggerAgent::didPause
call was due to an exception or not? I have tried to use
scriptState-hadException() inside this function but it seems that
the hadException function always returns false.

Thanks,
___
webkit-dev mailing list
webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


ATT1..txt




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Inspector module

[Tomasz Morawski]

Hi,
I have a few questions about inspector/JS debugging feature. I am trying 
to get a JS frame after
pausing script execution due to breakpoint reach. If I understand good 
the „pausedScript” event  that  is send to my InspectorClient class via 
the sendMessageToFrontend function should has JS frame that I looking for.


{type:event,event:pausedScript,data:{callFrames:null}}

But the callFrames field is null. The “callFrames” field is filed by an 
InspectorDebuggerAgent::currentCallFrames() function.  Could you tell me 
what is an InjectedScriptHost class what is the purpose of this class 
and how I should use this object to get a callFrame? Maybe I have 
forgotten to dispatch some commands?
What commands should be dispatched via an InspectorBackendDispatcher 
object to get a callFrame after JS execution pause?


For test purpose I have written a code:

InspectorDebuggerAgent::currentCallFrames()
{
JavaScriptCallFrame* frame = 
ScriptDebugServer::shared().currentCallFrame();

if (!frame)
{
fprintf(stderr, source: %d\n, frame-sourceID());
fprintf(stderr, line:   %d\n, frame-line());
fprintf(stderr, function:   %s\n, 
frame-functionName().ascii().data());


JSC::JSGlobalObject *gobject = frame-dynamicGlobalObject();
JSC::ExecState* exec = gobject-JSGlobalObject::globalExec();
if (exec)
fprintf(stderr, function parameters: %d \n, 
exec-argumentCount());

}

But exec-argumentCount returns invalid parameters count.

Best regards,
Tomasz Morawski 
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev