Re: [webkit-dev] Table layout does not clear setNeedsLayout flag for rows?
Since I don't understand table layout well, I'm sorry if I said wrong. RenderTable::layout() calls RenderTableSection::layout() at [1]. RenderTableSection::layout() calls RenderTableRow::layout() at [2]. RenderTableRow::layout() clears its setNeedsLayout flag at [3]. Therefore, I think the flag is cleared. [1]: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTable.cpp#L465 [2]: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTableSection.cpp#L420 [3]: http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderTableRow.cpp#L192 On Thu, Mar 13, 2014 at 11:39 PM, Mayur K emineme...@gmail.com wrote: Hi, I am checking the layout and rendering of the table element in webkit. In the process I figured out that the link of renderers is as follows: RenderTable has RenderTableSection has RenderTableRow has RenderTableCell The layout of the table rows is done in RenderTableSection::layoutRows. I did not see any code to specifically set RenderTableRow::setNeedsLayout(false) at the end of the function. While there is a call to RenderTableCell::layout , which will then clear the layout flag for RenderTableCell. So is a RenderTableRow::setNeedsLayout(false) needed at the end of the layout of each row in RenderTableSection::layoutRows? If not then where is the RenderTableRow layout flag cleared? Regards, Mayur Kankanwadi. -- Symbiangeek,Codekata Webkitwiki all in one - http://flaminghorns.com ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Implement ruby-align
Hi, I'd like to add support for ruby-align. The spec for this feature can be found here: http://www.w3.org/TR/css3-ruby/#rubyalign I'm working it at this bug https://bugs.webkit.org/show_bug.cgi?id=115149 I know that CSS3 ruby is outdated, but ruby-align is important feature for Japanese typography. IE implemented this property except start and end value, and the property works well. Other browsers don't support this property. Any comments and suggestions are welcome. -- Yuki Sekiguchiyuki.sekigu...@access-company.com ACCESS Co., Ltd. -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Implement ruby-overhang
Thank you for your advice. I'll change the patch and suggest that the author change initial value. On Thu, Apr 18, 2013 at 3:36 AM, David Hyatt hy...@apple.com wrote: On Apr 17, 2013, at 2:26 AM, Yuki Sekiguchi yuki.sekigu...@access-company.com wrote: Hi, I'd like to add support for ruby-overhang. The spec for this feature can be found here: http://www.w3.org/TR/css3-ruby/#rubyover I'm working it at this bug https://bugs.webkit.org/show_bug.cgi?id=114678 My concern is that this patch changes the default behavior of overhanging ruby text. CSS spec says that initial value is none, but current behavior is like auto. I believe auto is a better initial value than none. We should make the initial value auto for now and try to get the spec changed. dave (hy...@apple.com) -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Implement ruby-overhang
I didn't contacted the author. However, I checked the editor's draft(editor's copy)[1], but it was older than working draft. I'm contacting the author, and thank you for forwarding this mail to the author. [1]: http://dev.w3.org/csswg/css-ruby/ On Thu, Apr 18, 2013 at 1:27 AM, Glenn Adams gl...@skynav.com wrote: On Wed, Apr 17, 2013 at 1:26 AM, Yuki Sekiguchi yuki.sekigu...@access-company.com wrote: Hi, I'd like to add support for ruby-overhang. The spec for this feature can be found here: http://www.w3.org/TR/css3-ruby/#rubyover I'm working it at this bug https://bugs.webkit.org/show_bug.cgi?id=114678 My concern is that this patch changes the default behavior of overhanging ruby text. CSS spec says that initial value is none, but current behavior is like auto. Firefox doesn't support this property. IE says it supports this property[1], but values don't match CSS spec, and the property doesn't affect layout. Any comments and suggestions are welcome. [1]: http://msdn.microsoft.com/ja-jp/library/ie/ms531151(v=vs.85).aspx -- Yuki Sekiguchiyuki.sekigu...@access-company.com ACCESS Co., Ltd. I see that the CSS Ruby draft is now almost two years old and that the CSS Drafts page [1] indicates it is Outdated and majorly [sic] undefined. Have you checked with the author or the CSS WG to determine if this work is moving forward as presently drafted? Have you checked with them on this specific issue? [1] http://www.w3.org/Style/CSS/current-work -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Implement ruby-overhang
Hi, I'd like to add support for ruby-overhang. The spec for this feature can be found here: http://www.w3.org/TR/css3-ruby/#rubyover I'm working it at this bug https://bugs.webkit.org/show_bug.cgi?id=114678 My concern is that this patch changes the default behavior of overhanging ruby text. CSS spec says that initial value is none, but current behavior is like auto. Firefox doesn't support this property. IE says it supports this property[1], but values don't match CSS spec, and the property doesn't affect layout. Any comments and suggestions are welcome. [1]: http://msdn.microsoft.com/ja-jp/library/ie/ms531151(v=vs.85).aspx -- Yuki Sekiguchiyuki.sekigu...@access-company.com ACCESS Co., Ltd. -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Implement ruby-overhang
Is this behavior change likely to affect any existing Web content, or other important content that uses html ruby markup such as books in EPUB format? Yes. All Web and EPUB contents which use ruby are affected by this change. I have no strong opinion about initial value of ruby-overhang. If you have any concern, I can change the initial value to none. IE's behavior is ruby-overhang: none. On Wed, Apr 17, 2013 at 4:40 PM, Maciej Stachowiak m...@apple.com wrote: Is this behavior change likely to affect any existing Web content, or other important content that uses html ruby markup such as books in EPUB format? - Maciej On Apr 17, 2013, at 12:26 AM, Yuki Sekiguchi yuki.sekigu...@access-company.com wrote: Hi, I'd like to add support for ruby-overhang. The spec for this feature can be found here: http://www.w3.org/TR/css3-ruby/#rubyover I'm working it at this bug https://bugs.webkit.org/show_bug.cgi?id=114678 My concern is that this patch changes the default behavior of overhanging ruby text. CSS spec says that initial value is none, but current behavior is like auto. Firefox doesn't support this property. IE says it supports this property[1], but values don't match CSS spec, and the property doesn't affect layout. Any comments and suggestions are welcome. [1]: http://msdn.microsoft.com/ja-jp/library/ie/ms531151(v=vs.85).aspx -- Yuki Sekiguchiyuki.sekigu...@access-company.com ACCESS Co., Ltd. -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] PSA: committers.py is now contributors.json
Changed the link from committers.py to contributors.json in https://trac.webkit.org/wiki/WebKit%20Team :) On Wed, Apr 17, 2013 at 4:05 AM, Ryosuke Niwa rn...@webkit.org wrote: As of http://trac.webkit.org/changeset/148527, the list of contributors, committers, and reviewers in committers.py have been replaced by those of contributors.json in the same directory. Relevant documentation has been updated in the same changeset. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Adding hanging-punctuation: allow-end
Hi, I'd like to add support for hanging-punctuation: allow-end. The spec for this feature can be found here: http://www.w3.org/TR/css3-text/#hanging-punctuation0 I work at this bug: https://bugs.webkit.org/show_bug.cgi?id=104996 Any comments and suggestions are welcome. -- Yuki Sekiguchiyuki.sekigu...@access-company.com ACCESS Co., Ltd. -- . The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any. Thank you for your cooperation. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
