Re: [webkit-dev] About code reviews outside bugzilla
On Tue, 2012-01-10 at 14:48 +, Peter Beverloo wrote: > The bugzilla bug is here, it's just not referenced in the message > (which it should be): > https://bugs.webkit.org/show_bug.cgi?id=75956 > Ah, thanks Peter! Too bad the EWS wasn't not used though :( Philippe signature.asc Description: This is a digitally signed message part ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] About code reviews outside bugzilla
The bugzilla bug is here, it's just not referenced in the message (which it should be): https://bugs.webkit.org/show_bug.cgi?id=75956 Peter On Tue, Jan 10, 2012 at 14:44, Philippe Normand wrote: > Hi, > > I thought any substantial code contribution was to be reviewed in a > proper bugzilla entry? > > This commit broke the WebKit2 build earlier today: > > http://trac.webkit.org/changeset/104557 > > No mention of a bugzilla entry... > > Hopefully Kenneth was quick coming up with a build fix, but please let's > use Bugzilla... In the case of this patch, the build breakage would have > been detected upfront by the EWS. > > Philippe > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] About code reviews outside bugzilla
Hi, I thought any substantial code contribution was to be reviewed in a proper bugzilla entry? This commit broke the WebKit2 build earlier today: http://trac.webkit.org/changeset/104557 No mention of a bugzilla entry... Hopefully Kenneth was quick coming up with a build fix, but please let's use Bugzilla... In the case of this patch, the build breakage would have been detected upfront by the EWS. Philippe signature.asc Description: This is a digitally signed message part ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
