[webkit-dev] EWS commenting about ancient patches
On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
Hi, EWS picks up all patches with r? flag. Mac WK2 EWS is a brand new EWS bot, that's why it tested ancient patches and commented their bugs. It finished processing ancient patches, so it won't be problem in the future. br, Ossy Alexey Proskuryakov írta: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS queue has either has a result for each patch, or adds it to each individual queue. Since there are some ancient patches still marked r?, new queues will process ancient patches. :) (The feeder-queue is then smart enough to keep an in-memory list of what it's sent to queues.webkit.org, so it only send incremental lists until it restarts itself again in 2 hours.) -eric On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
Maybe we shouldn't bother feeding the bots patches that are over a certain age (perhaps a week)? Adam On Thu, Jan 17, 2013 at 11:50 AM, Eric Seidel e...@webkit.org wrote: I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS queue has either has a result for each patch, or adds it to each individual queue. Since there are some ancient patches still marked r?, new queues will process ancient patches. :) (The feeder-queue is then smart enough to keep an in-memory list of what it's sent to queues.webkit.org, so it only send incremental lists until it restarts itself again in 2 hours.) -eric On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] EWS commenting about ancient patches
That seems totally reasonable, and simple to implement: https://bugs.webkit.org/show_bug.cgi?id=107152 On Thu, Jan 17, 2013 at 11:55 AM, Adam Barth aba...@webkit.org wrote: Maybe we shouldn't bother feeding the bots patches that are over a certain age (perhaps a week)? Adam On Thu, Jan 17, 2013 at 11:50 AM, Eric Seidel e...@webkit.org wrote: I believe the queue was actually cleared when they were brought online. As Ossy notes, this is expected behavior. Every time the feeder queue boots up (which is every 2 hours), it sends *all* patches marked for review to queues.webkit.org. queues.webkit.org makes sure that each individual EWS queue has either has a result for each patch, or adds it to each individual queue. Since there are some ancient patches still marked r?, new queues will process ancient patches. :) (The feeder-queue is then smart enough to keep an in-memory list of what it's sent to queues.webkit.org, so it only send incremental lists until it restarts itself again in 2 hours.) -eric On Thu, Jan 17, 2013 at 11:43 AM, Ryosuke Niwa rn...@webkit.org wrote: Sorry, that's my fault. I added Mac-WK2 EWS to the EWS queue much earlier than we added bots. So we ended up having 1000+ backlogs of patches. As Ossy points out, Mac WK2 EWS bots have caught up with patches so this shouldn't be a problem in the future. - R. Niwa On Thu, Jan 17, 2013 at 8:40 AM, Alexey Proskuryakov a...@webkit.org wrote: On several occasions over the last few days, I noticed EWS commenting in bugs that didn't have any recent activity, e.g. https://bugs.webkit.org/show_bug.cgi?id=87527. Is EWS picking ancient patches, or is it posting comments to wrong bugs? - WBR, Alexey Proskuryakov ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
