Re: [webkit-dev] Enable MICRODATA feature by default
Arko,
You might already be aware, but I wanted to mention this to make sure
your expectations are set correctly. At least for the Chromium port,
there's a difference between enabling a feature on trunk and promoting
the feature to the beta and/or stable channel. We make the former
decision via WebKit's code review process. For the latter decision,
however, there's also an additional review process that's internal to
the Chromium project.
Adam
On Mon, Aug 6, 2012 at 12:23 AM, Arko Saha wrote:
> I have filed a bug to address W3C failed test-cases :
> https://bugs.webkit.org/show_bug.cgi?id=92986
> This issue will track all investigation related to Microdata test failures
> and make sure that we pass as many test as possible.
>
> Regards,
> Arko
>
>
> On Wed, Aug 1, 2012 at 12:16 AM, Ian Hickson wrote:
>>
>> On Tue, 31 Jul 2012, Arko Saha wrote:
>> >
>> > test(function () {
>> > assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
>> > window.undefined );
>> > }, 'itemType[index] must be undefined for out-of-range index');
>> >
>> > DOMSettableTokenList returns null for out-of-range index.
>>
>> This is incorrect. While it is true that item() returns null when
>> called with an out-of-range index, item() is never invoked in the example
>> above. See Web IDL for details.
>>
>> I highly doubt that the other 80+ failing tests are implementation-
>> specific either. If any of them _are_, then before ignoring them, you
>> should ask for them to be corrected in the test suite.
>>
>> --
>> Ian Hickson U+1047E)\._.,--,'``.fL
>> http://ln.hixie.ch/ U+263A/, _.. \ _\ ;`._ ,.
>> Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.'
>
>
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
I have filed a bug to address W3C failed test-cases :
https://bugs.webkit.org/show_bug.cgi?id=92986
This issue will track all investigation related to Microdata test failures
and make sure that we pass as many test as possible.
Regards,
Arko
On Wed, Aug 1, 2012 at 12:16 AM, Ian Hickson wrote:
> On Tue, 31 Jul 2012, Arko Saha wrote:
> >
> > test(function () {
> > assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
> > window.undefined );
> > }, 'itemType[index] must be undefined for out-of-range index');
> >
> > DOMSettableTokenList returns null for out-of-range index.
>
> This is incorrect. While it is true that item() returns null when
> called with an out-of-range index, item() is never invoked in the example
> above. See Web IDL for details.
>
> I highly doubt that the other 80+ failing tests are implementation-
> specific either. If any of them _are_, then before ignoring them, you
> should ask for them to be corrected in the test suite.
>
> --
> Ian Hickson U+1047E)\._.,--,'``.fL
> http://ln.hixie.ch/ U+263A/, _.. \ _\ ;`._ ,.
> Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.'
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
On Tue, 31 Jul 2012, Arko Saha wrote:
>
> test(function () {
> assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
> window.undefined );
> }, 'itemType[index] must be undefined for out-of-range index');
>
> DOMSettableTokenList returns null for out-of-range index.
This is incorrect. While it is true that item() returns null when
called with an out-of-range index, item() is never invoked in the example
above. See Web IDL for details.
I highly doubt that the other 80+ failing tests are implementation-
specific either. If any of them _are_, then before ignoring them, you
should ask for them to be corrected in the test suite.
--
Ian Hickson U+1047E)\._.,--,'``.fL
http://ln.hixie.ch/ U+263A/, _.. \ _\ ;`._ ,.
Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.'
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
Has anything been done to verify security and stability of the feature, for example, fuzz testing? I'd like to request that before enabling for Apple's ports. - Maciej On Jul 30, 2012, at 11:35 PM, Arko Saha wrote: > I am planning to enable MICRODATA feature by default in WebKit. > > Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 > Microdata spec: > http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html > > Currently we have support for Microdata DOM API's to interacting with > microdata using microdata attributes like itemscope, itemtype, itemprop, > itemref, itemid through JavaScript. > Also we have added support for HTMLPropertiesCollection, PropertyNodeList > interfaces to intract with microdata item-properties. > > As of now, WebKit EFL and Blackberry port has already enabled MICRODATA by > default. > Mozilla and Opera has also enabled the support for Microdata DOM API. > > Please let me know your thoughts on the same. > > Thanks and Regards, > Arko > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
On Tue, Jul 31, 2012 at 12:55 AM, Arko Saha wrote:
> For an example :
>
> test(function () {
> assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
> window.undefined );
> }, 'itemType[index] must be undefined for out-of-range index');
>
> makeEl method creates an element with empty itemtype(0 tokens). Test
> expects itemTpye[0] should return undefined, in our case it returns null.
>
> According to the spec itemtpye attribute is a space-separated list.
> http://www.whatwg.org/specs/web-apps/current-work#attr-itemtype
> We have defined itemtype attribute as :
> readonly attribute [Conditional=MICRODATA] DOMSettableTokenList itemType;
>
> DOMSettableTokenList returns null for out-of-range index.
> So I thought it is specific to DOMSettableTokenList implementation. Or is
> this the bug in our DOMSettableTokenList implementation? There are many
> tests failing because of this.
>
Either that the spec is out of date or that the test is wrong. It's
possible that the spec has recently changed after they had submitted the
test case.
Do you think, we should first resolve all these test issues and then think
> of enabling feature by default? In that case I will raise a new bug and we
> can then discuss the failed tests there.
>
It seems like this particular problem isn't specific to micro data so it's
probably okay. But we should investigate other failures and make sure our
implementation interoperate with Opera and Firefox.
- Ryosuke
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
For an example :
test(function () {
assert_equals( makeEl('div',{itemtype:' '}).itemType[0],
window.undefined );
}, 'itemType[index] must be undefined for out-of-range index');
makeEl method creates an element with empty itemtype(0 tokens). Test
expects itemTpye[0] should return undefined, in our case it returns null.
According to the spec itemtpye attribute is a space-separated list.
http://www.whatwg.org/specs/web-apps/current-work/#attr-itemtype
We have defined itemtype attribute as :
readonly attribute [Conditional=MICRODATA] DOMSettableTokenList itemType;
DOMSettableTokenList returns null for out-of-range index.
So I thought it is specific to DOMSettableTokenList implementation. Or is
this the bug in our DOMSettableTokenList implementation? There are many
tests failing because of this.
Do you think, we should first resolve all these test issues and then think
of enabling feature by default? In that case I will raise a new bug and we
can then discuss the failed tests there.
Regards,
Arko
On Tue, Jul 31, 2012 at 12:51 PM, Ryosuke Niwa wrote:
> On Mon, Jul 30, 2012 at 11:51 PM, Arko Saha wrote:
>
>> I have tested the test :
>> http://w3c-test.org/html/tests/submission/Opera/microdata/001.html
>> 255 Pass
>> 82 Fail
>>
>> Most of the failed cases are specific to their implementation and for
>> others, I need to check.
>>
>
> What do you mean by "specific to their implementation"? I would expect any
> test submitted to the W3C test suite to be cross browser. Tests shouldn't
> include vendor prefixes for example.
>
> - Ryosuke
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
On Mon, Jul 30, 2012 at 11:51 PM, Arko Saha wrote: > I have tested the test : > http://w3c-test.org/html/tests/submission/Opera/microdata/001.html > 255 Pass > 82 Fail > > Most of the failed cases are specific to their implementation and for > others, I need to check. > What do you mean by "specific to their implementation"? I would expect any test submitted to the W3C test suite to be cross browser. Tests shouldn't include vendor prefixes for example. - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
I have tested the test : http://w3c-test.org/html/tests/submission/Opera/microdata/001.html 255 Pass 82 Fail Most of the failed cases are specific to their implementation and for others, I need to check. Regards, Arko On Tue, Jul 31, 2012 at 12:07 PM, Ryosuke Niwa wrote: > Do we pass tests W3C submitted by Opera & Mozilla? > > - Ryosuke > > On Mon, Jul 30, 2012 at 11:35 PM, Arko Saha wrote: > >> I am planning to enable MICRODATA feature by default in WebKit. >> >> Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 >> Microdata spec: >> http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html >> >> Currently we have support for Microdata DOM API's to interacting with >> microdata using microdata attributes like itemscope, itemtype, itemprop, >> itemref, itemid through JavaScript. >> Also we have added support for HTMLPropertiesCollection, PropertyNodeList >> interfaces to intract with microdata item-properties. >> >> As of now, WebKit EFL and Blackberry port has already enabled MICRODATA >> by default. >> Mozilla and Opera has also enabled the support for Microdata DOM API. >> >> Please let me know your thoughts on the same. >> >> Thanks and Regards, >> Arko >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> http://lists.webkit.org/mailman/listinfo/webkit-dev >> >> > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable MICRODATA feature by default
Do we pass tests W3C submitted by Opera & Mozilla? - Ryosuke On Mon, Jul 30, 2012 at 11:35 PM, Arko Saha wrote: > I am planning to enable MICRODATA feature by default in WebKit. > > Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 > Microdata spec: > http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html > > Currently we have support for Microdata DOM API's to interacting with > microdata using microdata attributes like itemscope, itemtype, itemprop, > itemref, itemid through JavaScript. > Also we have added support for HTMLPropertiesCollection, PropertyNodeList > interfaces to intract with microdata item-properties. > > As of now, WebKit EFL and Blackberry port has already enabled MICRODATA by > default. > Mozilla and Opera has also enabled the support for Microdata DOM API. > > Please let me know your thoughts on the same. > > Thanks and Regards, > Arko > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Enable MICRODATA feature by default
I am planning to enable MICRODATA feature by default in WebKit. Microdata master bug: https://bugs.webkit.org/show_bug.cgi?id=68609 Microdata spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html Currently we have support for Microdata DOM API's to interacting with microdata using microdata attributes like itemscope, itemtype, itemprop, itemref, itemid through JavaScript. Also we have added support for HTMLPropertiesCollection, PropertyNodeList interfaces to intract with microdata item-properties. As of now, WebKit EFL and Blackberry port has already enabled MICRODATA by default. Mozilla and Opera has also enabled the support for Microdata DOM API. Please let me know your thoughts on the same. Thanks and Regards, Arko ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-dev
