Re: [webkit-dev] Enable build for CSS3_TEXT
I agree with Dirk about not enabling flags that don’t actually change rendering. I’m not sure if waiting until CR, specifically, is absolutely necessary, though. For example, the Mac port has CSS3 text decorations enabled. —Myles > On May 21, 2014, at 9:49 AM, Dirk Schulze wrote: > > > On May 21, 2014, at 6:32 PM, Zoltan Horvath wrote: > >> >> Hi there, >> >> We have 2 properties under CSS3_TEXT macro: >> >> -webkit-text-align-last (http://trac.webkit.org/changeset/162213) >> -> parsing&rendering are implemented >> >> -webkit-text-justify (https://bugs.webkit.org/show_bug.cgi?id=99945) >> -> only parsing is implemented >> >> Spec : http://dev.w3.org/csswg/css-text-3/ >> >> CSS3_TEXT is disabled by default for our builds. Since we've got the proper >> testing for the existing code, I'd like to enable the flag by default. > > I object to enable -webkit-text-justify if it doesn’t actually have any > functionality. This is poor behavior for authors since they can not feature > test. > > It would be great to wait for CR of the spec and enable > -webkit-text-align-last unprefixed. (Assuming that is isn't shipped in Safari > yet.) > > So in general, I would vote for not enabling the flag at this point. > > Greetings, > Dirk > >> >> Let me know if you have any objections. >> >> Cheers, >> >> ___ >> webkit-dev mailing list >> webkit-dev@lists.webkit.org >> https://lists.webkit.org/mailman/listinfo/webkit-dev > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
Re: [webkit-dev] Enable build for CSS3_TEXT
On May 21, 2014, at 6:32 PM, Zoltan Horvath wrote: > > Hi there, > > We have 2 properties under CSS3_TEXT macro: > > -webkit-text-align-last (http://trac.webkit.org/changeset/162213) > -> parsing&rendering are implemented > > -webkit-text-justify (https://bugs.webkit.org/show_bug.cgi?id=99945) > -> only parsing is implemented > > Spec : http://dev.w3.org/csswg/css-text-3/ > > CSS3_TEXT is disabled by default for our builds. Since we've got the proper > testing for the existing code, I'd like to enable the flag by default. I object to enable -webkit-text-justify if it doesn’t actually have any functionality. This is poor behavior for authors since they can not feature test. It would be great to wait for CR of the spec and enable -webkit-text-align-last unprefixed. (Assuming that is isn't shipped in Safari yet.) So in general, I would vote for not enabling the flag at this point. Greetings, Dirk > > Let me know if you have any objections. > > Cheers, > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > https://lists.webkit.org/mailman/listinfo/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
[webkit-dev] Enable build for CSS3_TEXT
Hi there, We have 2 properties under CSS3_TEXT macro: -webkit-text-align-last (http://trac.webkit.org/changeset/162213) -> parsing&rendering are implemented -webkit-text-justify (https://bugs.webkit.org/show_bug.cgi?id=99945) -> only parsing is implemented Spec : http://dev.w3.org/csswg/css-text-3/ CSS3_TEXT is disabled by default for our builds. Since we've got the proper testing for the existing code, I'd like to enable the flag by default. Let me know if you have any objections. Cheers, ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev
