Re: [webkit-dev] GTK+ port's help needed to get rid of FAIL test expectation
On 2012-06-10 19:09, Žan Doberšek wrote: I think it would suffice to replace all the FAIL occurrences with TEXT, except for the failing reftests - those should have FAIL turned into IMAGE. Gtk bots don't run pixel tests yet so any other IMAGE failures could perhaps be addressed at later time. I agree with that approach. Philippe ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] GTK+ port's help needed to get rid of FAIL test expectation
I think it would suffice to replace all the FAIL occurrences with TEXT, except for the failing reftests - those should have FAIL turned into IMAGE. Gtk bots don't run pixel tests yet so any other IMAGE failures could perhaps be addressed at later time. I'd like some approval on this from the senior maintainers, after that FAIL should disappear from Gtk's TestExpectations pretty soon. Regards, Zan On Sat, Jun 9, 2012 at 9:35 PM, Ryosuke Niwa rn...@webkit.org wrote: On Sat, Jun 9, 2012 at 12:27 PM, Ojan Vafai o...@chromium.org wrote: Can you just expand out FAIL to it's equivalent longform? FAIL == TEXT IMAGE IMAGE+TEXT. I don't see a need to block the infrastructure change on this as the semantics are exactly the same. You can just find/replace every instance of FAIL. I could. But it appears that most entries in GTK+'s test expectations file has FAIL expectation so I'd rather make sure it's not intentional, etc... - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] GTK+ port's help needed to get rid of FAIL test expectation
Can you just expand out FAIL to it's equivalent longform? FAIL == TEXT IMAGE IMAGE+TEXT. I don't see a need to block the infrastructure change on this as the semantics are exactly the same. You can just find/replace every instance of FAIL. On Fri, Jun 8, 2012 at 10:12 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, In the discussion to rename FAIL to DIFF, the consensus appeared that we should get rid of it altogether in the favor of more specific test failure expectations. I've done that in http://trac.webkit.org/changeset/119892 and http://trac.webkit.org/changeset/119889 for all but GTK+ ports. However, GTK+ port's test expectation file contains hundreds of FAIL test expectations, of which I'm not comfortable replacing all by myself. Could someone from GTK+ port assist me in replacing those with more specific test expectations? Best, Ryosuke Niwa Software Engineer Google Inc. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] GTK+ port's help needed to get rid of FAIL test expectation
On Sat, Jun 9, 2012 at 12:27 PM, Ojan Vafai o...@chromium.org wrote: Can you just expand out FAIL to it's equivalent longform? FAIL == TEXT IMAGE IMAGE+TEXT. I don't see a need to block the infrastructure change on this as the semantics are exactly the same. You can just find/replace every instance of FAIL. I could. But it appears that most entries in GTK+'s test expectations file has FAIL expectation so I'd rather make sure it's not intentional, etc... - Ryosuke ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] GTK+ port's help needed to get rid of FAIL test expectation
Hi, In the discussion to rename FAIL to DIFF, the consensus appeared that we should get rid of it altogether in the favor of more specific test failure expectations. I've done that in http://trac.webkit.org/changeset/119892 and http://trac.webkit.org/changeset/119889 for all but GTK+ ports. However, GTK+ port's test expectation file contains hundreds of FAIL test expectations, of which I'm not comfortable replacing all by myself. Could someone from GTK+ port assist me in replacing those with more specific test expectations? Best, Ryosuke Niwa Software Engineer Google Inc. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
