Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-12-01 Thread Gustavo Noronha Silva
On Sun, 2008-11-30 at 18:32 -0600, ying lcs wrote:
 Thank to both of you.
 
 I apply the patch. And now I see 'Inspect element' in the context
 element. But when I load www.google.com, the inspect window is just
 blank.
 
 Can you please tell me what am I missing?

You probably forgot a 'make install', and WebKit is not finding the
HTML/CSS/Javascript files needed to run the inspector.

See you,

-- 
Gustavo Noronha Silva [EMAIL PROTECTED]
GNOME contributor: http://www.gnome.org/

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-30 Thread Kalle Vahlman
2008/11/30 ying lcs [EMAIL PROTECTED]:
 On Sat, Nov 29, 2008 at 3:29 AM, Kalle Vahlman [EMAIL PROTECTED] wrote:
 2008/11/29 ying lcs [EMAIL PROTECTED]:
 From this entry, it said Inspector is ported to  Webkit/GTK
 http://blog.kov.eti.br/?p=25

 Can you please tell me how can I enable it?

 There's a patch attached to the original bug that enables the
 inspector for the GtkLauncher test program:

  https://bugs.webkit.org/show_bug.cgi?id=19392

 That should give an idea what needs to be done in a client application
 to enable the inspector.

 On a related note, I just submitted a patch for an API to enable
 client applications to start the inspector (eg. from a keyboard
 shortcut):

  https://bugs.webkit.org/show_bug.cgi?id=22551

 --
 Kalle Vahlman, [EMAIL PROTECTED]
 Powered by http://movial.fi
 Interesting stuff at http://sandbox.movial.com
 See also http://syslog.movial.fi

 Thank you , Kalle,

 So should I apply this patch :
 https://bugs.webkit.org/attachment.cgi?id=24756 from the 1st bug that
 you mentioned?

No, that's already included in the WebKit code, the one I meant is

  https://bugs.webkit.org/attachment.cgi?id=22365

which only adds the support to GtkLauncher.

 And then https://bugs.webkit.org/attachment.cgi?id=25590 from the 2nd
 bug that you mentioned?

No, you don't need this one. You will get the context menu item with
the patch mentioned above, this one only adds a button to launch the
inspector from the client toolbar (and it depends on the other patch
in that bug).

Sorry for the confusion :)

-- 
Kalle Vahlman, [EMAIL PROTECTED]
Powered by http://movial.fi
Interesting stuff at http://sandbox.movial.com
See also http://syslog.movial.fi
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-30 Thread Holger Freyther
On Sunday 30 November 2008 06:58:27 ying lcs wrote:

Ni-Hao Ying,

why do you want to apply the patch? If you go to the related bug report [1] 
you see that the bug is closed and if you look at the last comment you also 
see the revision it was applied at.

You need a patch to GtkLauncher[2] (referenced from the bug report) or can 
consult the API documentation on how to enable and embed the inspector[3]

z.

[1] https://bugs.webkit.org/show_bug.cgi?id=19392
[2] https://bugs.webkit.org/attachment.cgi?id=22365
[3] http://oe.linuxtogo.org/~zecke/webkit-gtk-api/webkitgtk-
WebKitWebInspector.html


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-30 Thread ying lcs
Thank to both of you.

I apply the patch. And now I see 'Inspect element' in the context
element. But when I load www.google.com, the inspect window is just
blank.

Can you please tell me what am I missing?




On Sun, Nov 30, 2008 at 8:51 AM, Holger Freyther [EMAIL PROTECTED] wrote:
 On Sunday 30 November 2008 06:58:27 ying lcs wrote:

 Ni-Hao Ying,

 why do you want to apply the patch? If you go to the related bug report [1]
 you see that the bug is closed and if you look at the last comment you also
 see the revision it was applied at.

 You need a patch to GtkLauncher[2] (referenced from the bug report) or can
 consult the API documentation on how to enable and embed the inspector[3]

 z.

 [1] https://bugs.webkit.org/show_bug.cgi?id=19392
 [2] https://bugs.webkit.org/attachment.cgi?id=22365
 [3] http://oe.linuxtogo.org/~zecke/webkit-gtk-api/webkitgtk-
 WebKitWebInspector.html


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-30 Thread Kalle Vahlman
2008/12/1 ying lcs [EMAIL PROTECTED]:
 Thank to both of you.

 I apply the patch. And now I see 'Inspect element' in the context
 element. But when I load www.google.com, the inspect window is just
 blank.

 Can you please tell me what am I missing?

I think the GTK+ port tries to find the inspector files only from the
install location currently, so if you didn't run 'make install', that
would explain why it doesn't find them.

-- 
Kalle Vahlman, [EMAIL PROTECTED]
Powered by http://movial.fi
Interesting stuff at http://sandbox.movial.com
See also http://syslog.movial.fi
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-29 Thread Kalle Vahlman
2008/11/29 ying lcs [EMAIL PROTECTED]:
 From this entry, it said Inspector is ported to  Webkit/GTK
 http://blog.kov.eti.br/?p=25

 Can you please tell me how can I enable it?

There's a patch attached to the original bug that enables the
inspector for the GtkLauncher test program:

  https://bugs.webkit.org/show_bug.cgi?id=19392

That should give an idea what needs to be done in a client application
to enable the inspector.

On a related note, I just submitted a patch for an API to enable
client applications to start the inspector (eg. from a keyboard
shortcut):

  https://bugs.webkit.org/show_bug.cgi?id=22551

-- 
Kalle Vahlman, [EMAIL PROTECTED]
Powered by http://movial.fi
Interesting stuff at http://sandbox.movial.com
See also http://syslog.movial.fi
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-29 Thread ying lcs
On Sat, Nov 29, 2008 at 3:29 AM, Kalle Vahlman [EMAIL PROTECTED] wrote:
 2008/11/29 ying lcs [EMAIL PROTECTED]:
 From this entry, it said Inspector is ported to  Webkit/GTK
 http://blog.kov.eti.br/?p=25

 Can you please tell me how can I enable it?

 There's a patch attached to the original bug that enables the
 inspector for the GtkLauncher test program:

  https://bugs.webkit.org/show_bug.cgi?id=19392

 That should give an idea what needs to be done in a client application
 to enable the inspector.

 On a related note, I just submitted a patch for an API to enable
 client applications to start the inspector (eg. from a keyboard
 shortcut):

  https://bugs.webkit.org/show_bug.cgi?id=22551

 --
 Kalle Vahlman, [EMAIL PROTECTED]
 Powered by http://movial.fi
 Interesting stuff at http://sandbox.movial.com
 See also http://syslog.movial.fi

Thank you , Kalle,

So should I apply this patch :
https://bugs.webkit.org/attachment.cgi?id=24756 from the 1st bug that
you mentioned?
And then https://bugs.webkit.org/attachment.cgi?id=25590 from the 2nd
bug that you mentioned?

There are multiple patches in each bug, I am not sure which patch i
need to apply.

Thank you.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] How to enable Inspector in Webkit/GTK

2008-11-29 Thread ying lcs
On Sat, Nov 29, 2008 at 3:29 AM, Kalle Vahlman [EMAIL PROTECTED] wrote:
 2008/11/29 ying lcs [EMAIL PROTECTED]:
 From this entry, it said Inspector is ported to  Webkit/GTK
 http://blog.kov.eti.br/?p=25

 Can you please tell me how can I enable it?

 There's a patch attached to the original bug that enables the
 inspector for the GtkLauncher test program:

  https://bugs.webkit.org/show_bug.cgi?id=19392

 That should give an idea what needs to be done in a client application
 to enable the inspector.

 On a related note, I just submitted a patch for an API to enable
 client applications to start the inspector (eg. from a keyboard
 shortcut):

  https://bugs.webkit.org/show_bug.cgi?id=22551

 --
 Kalle Vahlman, [EMAIL PROTECTED]
 Powered by http://movial.fi
 Interesting stuff at http://sandbox.movial.com
 See also http://syslog.movial.fi



I try to apply this patch to my WebKit (check out on 11/27 from trunk):
https://bugs.webkit.org/attachment.cgi?id=24756

but I get these errors:

$ patch -p1  0001-2008-10-29-Gustavo-Noronha-Silva-gns-gnome.org.patch
patching file ChangeLog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file ChangeLog.rej
patching file GNUmakefile.am
Reversed (or previously applied) patch detected!  Assume -R? [n] n
Apply anyway? [n] y
Hunk #1 FAILED at 307.
Hunk #2 FAILED at 339.

Can you please tell me how to apply the patch?

Thank you.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev