[webkit-dev] Interpreting LEAK: on Shutdown

2010-06-22 Thread Alex Milowski
I looked at this document on the wiki:

   http://trac.webkit.org/wiki/Memory%20Use

and I'm curious about how to interpret the output on the console when
running via Safari.  For example, here's one output when I just
quit with windows open:

   LEAK: 2 WebCoreNode
   LEAK: 29 CachedResource

Here's another when all the windows were closed:

   No leak checking done: At least one WebView is still open.

I'm particularly interested in whether the MathML code is leaking.  I
don't have any direct concerns but I want to understand how to
check my rendering object implementations.


-- 
--Alex Milowski
The excellence of grammar as a guide is proportional to the paucity of the
inflexions, i.e. to the degree of analysis effected by the language
considered.

Bertrand Russell in a footnote of Principles of Mathematics
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Interpreting LEAK: on Shutdown

2010-06-22 Thread Geoffrey Garen
Hi Alex.

 I looked at this document on the wiki:
 
   http://trac.webkit.org/wiki/Memory%20Use
 
 and I'm curious about how to interpret the output on the console when
 running via Safari.  For example, here's one output when I just
 quit with windows open:
 
   LEAK: 2 WebCoreNode
   LEAK: 29 CachedResource

Those messages indicate that some objects were not deleted before shutdown.

Ensuring that all known references are released before shutdown, and then 
verifying that all objects are deleted, is an aid to debugging memory leaks. 
But the mechanism to ensure that all known references are released before 
shutdown seems to have bit-rotted a bit. Maybe you can fix it.

Best,
Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Interpreting LEAK: on Shutdown

2010-06-22 Thread Alex Milowski
On Tue, Jun 22, 2010 at 6:06 PM, Geoffrey Garen gga...@apple.com wrote:


 Those messages indicate that some objects were not deleted before shutdown.

 Ensuring that all known references are released before shutdown, and then 
 verifying that all objects are deleted, is an aid to debugging memory leaks. 
 But the mechanism to ensure that all known references are released before 
 shutdown seems to have bit-rotted a bit. Maybe you can fix it.


OK.  But how do you avoid this:

   No leak checking done: At least one WebView is still open.

If you quit all the windows you still get it.

In general, the documentation on all this is a little sparse.

-- 
--Alex Milowski
The excellence of grammar as a guide is proportional to the paucity of the
inflexions, i.e. to the degree of analysis effected by the language
considered.

Bertrand Russell in a footnote of Principles of Mathematics
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Interpreting LEAK: on Shutdown

2010-06-22 Thread Darin Adler
On Jun 22, 2010, at 1:30 PM, Alex Milowski wrote:

 But how do you avoid this:
 
   No leak checking done: At least one WebView is still open.

There’s no real need to avoid that one. It’s just advisory.

 If you quit all the windows you still get it.

If you get it even after closing all windows, it’s probably a bug.

 In general, the documentation on all this is a little sparse.

There is no documentation that I’m aware of.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Interpreting LEAK: on Shutdown

2010-06-22 Thread Geoffrey Garen
 OK.  But how do you avoid this:
 
   No leak checking done: At least one WebView is still open.

Originally, this message was about fast shutdown. An application choosing not 
to close all windows / WebViews before termination would emit this message, 
which was slightly clearer than mysterious LEAK messages.

 If you quit all the windows you still get it.

Seems like a bug. Like I said, I think there's been some bitrot in this area.

The best way to track down this bug is probably to set a breakpoint on WebView 
allocation and destruction, and log backtraces.

Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev