Re: [webkit-dev] JSC EWS being too optimistic

2019-10-09 Thread Caio Lima
Hi Aakash.

Thank you very much for this fix!

BR,
Caio.

Em qua, 9 de out de 2019 às 12:35, Aakash Jain  escreveu:
>
> Hi Caio,
>
> Thanks for reporting this issue.
>
> Jonathan fixed the bug you reported 
> (https://bugs.webkit.org/show_bug.cgi?id=202419). It was a regression from a 
> recent change.
>
> I verified the fix using the same patch you tested with earlier. jsc EWS is 
> now (correctly) failing on that patch 
> (https://bugs.webkit.org/show_bug.cgi?id=202140). Please let me know if you 
> notice any issue.
>
> Thanks
> Aakash
>
> On Oct 3, 2019, at 10:14 AM, Caio Lima  wrote:
>
> Hi all.
>
> I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are
> marking every patch as success, even if there is a build failure (see
> https://bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for
> https://bugs.webkit.org/show_bug.cgi?id=202140). Is it already in
> someone's radar?If not, could anybody take a look on this? I tried to
> investigate, but I'm lacking knowledge of EWS code base. This already
> caused some noise into JSC patches that broke ARMv7 and MIPS ports. I
> opened this bug to report it
> https://bugs.webkit.org/show_bug.cgi?id=202419.
>
> Thanks in advance,
> Caio Lima.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] JSC EWS being too optimistic

2019-10-09 Thread Aakash Jain
Hi Caio,

Thanks for reporting this issue.

Jonathan fixed the bug you reported 
(https://bugs.webkit.org/show_bug.cgi?id=202419 
). It was a regression from a 
recent change.

I verified the fix using the same patch you tested with earlier. jsc EWS is now 
(correctly) failing on that patch 
(https://bugs.webkit.org/show_bug.cgi?id=202140 
). Please let me know if you 
notice any issue.

Thanks
Aakash

> On Oct 3, 2019, at 10:14 AM, Caio Lima  wrote:
> 
> Hi all.
> 
> I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are
> marking every patch as success, even if there is a build failure (see
> https://bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for
> https://bugs.webkit.org/show_bug.cgi?id=202140). Is it already in
> someone's radar?If not, could anybody take a look on this? I tried to
> investigate, but I'm lacking knowledge of EWS code base. This already
> caused some noise into JSC patches that broke ARMv7 and MIPS ports. I
> opened this bug to report it
> https://bugs.webkit.org/show_bug.cgi?id=202419.
> 
> Thanks in advance,
> Caio Lima.
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] JSC EWS being too optimistic

2019-10-03 Thread Caio Lima
Hi all.

I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are
marking every patch as success, even if there is a build failure (see
https://bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for
https://bugs.webkit.org/show_bug.cgi?id=202140). Is it already in
someone's radar?If not, could anybody take a look on this? I tried to
investigate, but I'm lacking knowledge of EWS code base. This already
caused some noise into JSC patches that broke ARMv7 and MIPS ports. I
opened this bug to report it
https://bugs.webkit.org/show_bug.cgi?id=202419.

Thanks in advance,
Caio Lima.
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev