Re: [webkit-dev] Layout test

[Nagendra K]

Hi,

So can we run unit tests without any port as in

Tools/TestWebKitAPI
 When I tried to build it is breaking and when I checked it is looking for
Apple macros to build.
Build script I picked from Tools/Script/build-api-tests.
Thanks,
Nags

On 29 Jun 2017 9:23 p.m., "Konstantin Tokarev"  wrote:



29.06.2017, 18:46, "Nagendra K" :

My port is not ready yet as we decide to port module by module once we
cross compile base webit on device. So is possible to test the WebKit built
without the port, at least some tests without any UI.


You can run some tests manually, by opening their html files in your
browser.
Also you can run unit tests (Tools/TestWebKitAPI)

For running LayoutTests, you can copy implementation of other port (e.g.
gtk.py, or restore efl.py before it was removed), and adjust paths and
settings to your port




Thanks,
Nagendra

On 29 Jun 2017 8:50 p.m., "Konstantin Tokarev"  wrote:



29.06.2017, 18:18, "Nagendra K" :
> Hi,
>
> I have a requirement to check if a particular WebKit or latest WebKit
works on the embedded platform. They have custom port which is complex, so
plan to build the new WebKit as a separate process to check build works
fine and then bring their changes later. Once we build WebKit I want to
check if this working by running some layout tests.
> But I found that layout tests required some port like gtk to run, is this
mandatory or can we run the tests without any port.

You should add implementation for your port under
Tools/Scripts/webkitpy/port/

>
> Thanks and Regards,
> Nags
> ,
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


-- 
Regards,
Konstantin



-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Layout test

[Nagendra K]

Hi,

So can we run unit tests without any port as in
Tools/TestWebKitAPI
 When I tried to build it is breaking and when I checked in build script it
is looking for Apple macros to build.
Build script I picked from Tools/Script/build-api-tests.

Thanks,
Nagendra

On 29 Jun 2017 9:23 p.m., "Konstantin Tokarev"  wrote:



29.06.2017, 18:46, "Nagendra K" :

My port is not ready yet as we decide to port module by module once we
cross compile base webit on device. So is possible to test the WebKit built
without the port, at least some tests without any UI.


You can run some tests manually, by opening their html files in your
browser.
Also you can run unit tests (Tools/TestWebKitAPI)

For running LayoutTests, you can copy implementation of other port (e.g.
gtk.py, or restore efl.py before it was removed), and adjust paths and
settings to your port




Thanks,
Nagendra

On 29 Jun 2017 8:50 p.m., "Konstantin Tokarev"  wrote:



29.06.2017, 18:18, "Nagendra K" :
> Hi,
>
> I have a requirement to check if a particular WebKit or latest WebKit
works on the embedded platform. They have custom port which is complex, so
plan to build the new WebKit as a separate process to check build works
fine and then bring their changes later. Once we build WebKit I want to
check if this working by running some layout tests.
> But I found that layout tests required some port like gtk to run, is this
mandatory or can we run the tests without any port.

You should add implementation for your port under
Tools/Scripts/webkitpy/port/

>
> Thanks and Regards,
> Nags
> ,
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


-- 
Regards,
Konstantin



-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Layout test

[Konstantin Tokarev]

  29.06.2017, 18:46, "Nagendra K" :My port is not ready yet as we decide to port module by module once we cross compile base webit on device. So is possible to test the WebKit built without the port, at least some tests without any UI.You can run some tests manually, by opening their html files in your browser.Also you can run unit tests (Tools/TestWebKitAPI) For running LayoutTests, you can copy implementation of other port (e.g. gtk.py, or restore efl.py before it was removed), and adjust paths and settings to your port   Thanks,Nagendra On 29 Jun 2017 8:50 p.m., "Konstantin Tokarev"  wrote: 29.06.2017, 18:18, "Nagendra K" :> Hi,>> I have a requirement to check if a particular WebKit or latest WebKit works on the embedded platform. They have custom port which is complex, so plan to build the new WebKit as a separate process to check build works fine and then bring their changes later. Once we build WebKit I want to check if this working by running some layout tests.> But I found that layout tests required some port like gtk to run, is this mandatory or can we run the tests without any port.You should add implementation for your port under Tools/Scripts/webkitpy/port/>> Thanks and Regards,> Nags> ,>> ___> webkit-dev mailing list> webkit-dev@lists.webkit.org> https://lists.webkit.org/mailman/listinfo/webkit-dev-- Regards,Konstantin  -- Regards,Konstantin ___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Layout test

[Nagendra K]

My port is not ready yet as we decide to port module by module once we
cross compile base webit on device. So is possible to test the WebKit built
without the port, at least some tests without any UI.

Thanks,
Nagendra

On 29 Jun 2017 8:50 p.m., "Konstantin Tokarev"  wrote:

>
>
> 29.06.2017, 18:18, "Nagendra K" :
> > Hi,
> >
> > I have a requirement to check if a particular WebKit or latest WebKit
> works on the embedded platform. They have custom port which is complex, so
> plan to build the new WebKit as a separate process to check build works
> fine and then bring their changes later. Once we build WebKit I want to
> check if this working by running some layout tests.
> > But I found that layout tests required some port like gtk to run, is
> this mandatory or can we run the tests without any port.
>
> You should add implementation for your port under
> Tools/Scripts/webkitpy/port/
>
> >
> > Thanks and Regards,
> > Nags
> > ,
> >
> > ___
> > webkit-dev mailing list
> > webkit-dev@lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
>
>
> --
> Regards,
> Konstantin
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Layout test

[Konstantin Tokarev]

29.06.2017, 18:18, "Nagendra K" :
> Hi,
>
> I have a requirement to check if a particular WebKit or latest WebKit works 
> on the embedded platform. They have custom port which is complex, so plan to 
> build the new WebKit as a separate process to check build works fine and then 
> bring their changes later. Once we build WebKit I want to check if this 
> working by running some layout tests.
> But I found that layout tests required some port like gtk to run, is this 
> mandatory or can we run the tests without any port.

You should add implementation for your port under Tools/Scripts/webkitpy/port/

>
> Thanks and Regards,
> Nags
> ,
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev


-- 
Regards,
Konstantin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] Layout test

[Nagendra K]

Hi,

I have a requirement to check if a particular WebKit or latest WebKit works
on the embedded platform. They have custom port which is complex, so plan
to build the new WebKit as a separate process to check build works fine and
then bring their changes later. Once we build WebKit I want to check if
this working by running some layout tests.
But I found that layout tests required some port like gtk to run, is this
mandatory or can we run the tests without any port.

Thanks and Regards,
Nags
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev

[webkit-dev] layout test expectation files without tests

[Shinichiro Hamaji]

Hi WebKit,

I found there are several expectation files which don't have
corresponding tests. Most of them are fine. People just forgot to remove
expectation files when they removed the tests. However, there are some
cases in which people forgot to add test files. For such cases, I
think we should add the test files if possible.

Here is the list of such cases. I hope original authors will put these tests.

- editing/execCommand/5482524
author: justing
trac: http://trac.webkit.org/changeset/26558

- editing/execCommand/outdent-blockquote-test5
author: kmccullough
trac: http://trac.webkit.org/changeset/43729

- editing/pasteboard/4944770
author: justing
trac: http://trac.webkit.org/changeset/19036

- fast/dynamic/8952-reduction
author: darin
trac: http://trac.webkit.org/changeset/15459
comment: now the png file is in platform/mac

- fast/forms/basic-textareas-quirks
author: ojan
trac: http://trac.webkit.org/changeset/41792

Thanks!
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] layout test expectation files without tests

[Darin Adler]

On Oct 21, 2009, at 2:17 AM, Shinichiro Hamaji wrote:

However, there are some cases in which people forgot to add test  
files.


Thanks for tackling this!


- fast/dynamic/8952-reduction
author: darin
trac: http://trac.webkit.org/changeset/15459
comment: now the png file is in platform/mac


In this case, I believe what actually happened (3 years ago! it's hard  
to remember) was that my test was originally named 8952-reduction in  
my local directory and I renamed it to move-node-with-selection before  
checking in, but forgot to rename the PNG file.


We should definitely removeLayoutTests/fast/dynamic/8952-reduction- 
expected.png -- there is no reason to keep it around. I did not forget  
to add a test file in this case.


-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] layout test expectation files without tests

[Ojan Vafai]

On Wed, Oct 21, 2009 at 2:17 AM, Shinichiro Hamaji ham...@chromium.orgwrote:

 - fast/forms/basic-textareas-quirks
 author: ojan
 trac: http://trac.webkit.org/changeset/41792


Doh. The quirks version of this test was rolled into the
basic-textareas.html test before checking in. I'll remove the extra
expectations later today.

Ojan
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Layout test failure

[Rui Jiang]

Hi all,

Pardon me for this newbie problem. I just followed instructions on 
webkit.org, got a clean svn checkout yesterday, did a build and all 
successful. However, when I ran the layout test, they all failed.


I could run safari, it works mostly when browsing webpages, however, 
whenever I type in the address bar, it crashes.


I build and run on WinXP SP2. I tried to make it work numerous times before 
but still couldn't get it right...


I have put sample output below, and attached diffs of first 3 tests in 
css1/basic.


Thanks and I appreciate your help!
Rui


Sample output:

$ run-webkit-tests css1/basic
Building results into: /cygdrive/c/code/webkit/WebKit/WebKitBuild
WEBKITOUTPUTDIR is set to: c:\code\webkit\WebKit\WebKitBuild
WEBKITLIBRARIESDIR is set to: c:\code\webkit\WebKit\WebKitLibraries\win
/cygdrive/c/Program Files/Microsoft Visual Studio 8/Common7/IDE/devenv.com 
DumpRenderTree.sln /build Release


Microsoft (R) Visual Studio Version 8.0.50727.762.
Copyright (C) Microsoft Corp 1984-2005. All rights reserved.
== Build: 0 succeeded, 0 failed, 4 up-to-date, 0 skipped ==
Running tests from /cygdrive/c/code/webkit/WebKit/LayoutTests
Testing 6 test cases.
css1/basic .
css1/basic/class_as_selector.html - failed
.
css1/basic/comments.html - failed
.
css1/basic/containment.html - failed
.
css1/basic/grouping.html - failed
.
css1/basic/id_as_selector.html - failed
.
css1/basic/inheritance.html - failed

1.42s total testing time

6 test cases (100%) had incorrect layout

--- /tmp/layout-test-results/css1/basic/class_as_selector-expected.txt  
2007-12-12 11:11:50.52075 -0800
+++ /tmp/layout-test-results/css1/basic/class_as_selector-actual.txt
2007-12-12 11:11:50.52075 -0800
@@ -1,12 +1,12 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-RenderBody {BODY} at (8,8) size 784x584 [bgcolor=#CC]
-  RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 355x18
+layer at (0,0) size 785x615
+  RenderView at (0,0) size 785x600
+layer at (0,0) size 785x615
+  RenderBlock {HTML} at (0,0) size 785x615
+RenderBody {BODY} at (8,8) size 769x599 [bgcolor=#CC]
+  RenderBlock {P} at (0,0) size 769x21
+RenderText {#text} at (0,0) size 355x20
  text run at (0,0) width 355: The style declarations which apply to the 
text below are:
-  RenderBlock {PRE} at (0,34) size 784x60
+  RenderBlock {PRE} at (0,37) size 769x60
RenderText {#text} at (0,0) size 176x60
  text run at (0,0) width 160: .one {color: green;}
  text run at (160,0) width 0:  
@@ -16,58 +16,58 @@
  text run at (152,30) width 0:  
  text run at (0,45) width 176: P.two {color: purple;}
  text run at (176,45) width 0:  
-  RenderBlock {HR} at (0,107) size 784x2 [border: (1px inset #00)]
-  RenderBlock {P} at (0,125) size 784x18 [color=#008000]
-RenderText {#text} at (0,0) size 194x18
+  RenderBlock {HR} at (0,110) size 769x2 [border: (1px inset #00)]
+  RenderBlock {P} at (0,128) size 769x21 [color=#008000]
+RenderText {#text} at (0,0) size 194x20
  text run at (0,0) width 194: This sentence should be green.
-  RenderBlock {P} at (0,159) size 784x18
-RenderText {#text} at (0,0) size 559x18
+  RenderBlock {P} at (0,165) size 769x21
+RenderText {#text} at (0,0) size 559x20
  text run at (0,0) width 559: This sentence should be black, not red-- 
class selectors cannot begin with digits in CSS1.
-  RenderBlock {P} at (0,193) size 784x18 [color=#008000]
-RenderText {#text} at (0,0) size 194x18
+  RenderBlock {P} at (0,202) size 769x21 [color=#008000]
+RenderText {#text} at (0,0) size 194x20
  text run at (0,0) width 194: This sentence should be green.
-  RenderBlock {P} at (0,227) size 784x18 [color=#800080]
-RenderText {#text} at (0,0) size 199x18
+  RenderBlock {P} at (0,239) size 769x21 [color=#800080]
+RenderText {#text} at (0,0) size 199x20
  text run at (0,0) width 199: This sentence should be purple.
-  RenderBlock {PRE} at (0,261) size 784x15
+  RenderBlock {PRE} at (0,276) size 769x15
RenderText {#text} at (0,0) size 280x15
  text run at (0,0) width 280: This sentence should NOT be purple.
  text run at (280,0) width 0:  
-  RenderBlock {UL} at (0,292) size 784x18
-RenderListItem {LI} at (40,0) size 744x18
-  RenderListMarker at (-17,0) size 7x18: bullet
-  RenderText {#text} at (0,0) size 237x18
+  RenderBlock {UL} at (0,307) size 769x21
+RenderListItem {LI} at (40,0) size 729x21
+  RenderListMarker at (-19,0) size 8x20: bullet
+  RenderText {#text} at (0,0) size 237x20
text run at (0,0) width 237: This sentence should NOT be purple.
-  RenderTable {TABLE} at (0,326) size 

Re: [webkit-dev] Layout test failure

[Alexey Proskuryakov]

on 12.12.2007 22:22, Rui Jiang at [EMAIL PROTECTED] wrote:

 Pardon me for this newbie problem. I just followed instructions on
 webkit.org, got a clean svn checkout yesterday, did a build and all
 successful. However, when I ran the layout test, they all failed.
 
 I could run safari, it works mostly when browsing webpages, however,
 whenever I type in the address bar, it crashes.

  This was a bug introduced yesterday and already fixed - please update
again!

  As for layout test failures - I think that on Windows, this is expected
behavior, because of how tests are set up internally by Apple. Maybe I'm
missing something though.

- WBR, Alexey Proskuryakov.


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev