Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

The move appears to be a success.

Mac, CrMac, CrWin, CrLinux, Gtk and Qt are all back building again.

Win, CrAndroid and EFL are in progress.

HUGE thank you to Mark Rowe, Tony Chang, Jessie Berlin, Martin
Robinson, Csaba Osztrogonac, Carlos Garcia Campos, Michael Saboff, and
Filip Pizlo for all their help with their respective platforms!

If I can be of further help, let me know.

-eric

On Thu, Mar 22, 2012 at 3:50 PM, Eric Seidel  wrote:
> Going ahead with the land now.
>
> Will be around for several hours fixing builds.  I'm sorry for any breaks.
>
> -eric
>
> On Wed, Mar 21, 2012 at 7:08 PM, Eric Seidel  wrote:
>> I've posted my first-draft patch to:
>> https://bugs.webkit.org/show_bug.cgi?id=81844
>>
>> If port maintainers would like to apply it locally and upload improved
>> versions (or upload diffs on top of that version) that would be most
>> welcome.
>>
>>
>> svn-apply seems to be having trouble with the "adds" for the WTF
>> files, thus causing all the EWS bots to fail.
>>
>> I'm also working on getting a git branch (on github) of my changes, to
>> make it easier for port maintainers to send me updates (instead of
>> passing around 5MB diffs).
>>
>>
>> At this point it may be best to just land the change tomorrow and fix
>> all the buildbots after the fact.  We should be very close, with all
>> the header work which has been done over the last month.
>>
>> -eric
>>
>> On Tue, Mar 20, 2012 at 5:18 PM, Eric Seidel  wrote:
>>> We're ready to complete the move.
>>>
>>> https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this
>>> evening, moving JavaScriptCore/wtf/Platform.h to Source/WTF/Platform.h
>>>
>>> Tomorrow (Weds) I will move a .cpp file in the same way.
>>>
>>> Thursday, I will move all the rest of the WTF files.  I will also
>>> update svn-apply so that in-flight patches should transparently patch
>>> the right files post-move.
>>>
>>> Let me know if you have questions or concerns.
>>>
>>> -eric
>>>
>>> On Tue, Feb 28, 2012 at 3:53 PM, Eric Seidel  wrote:
 I'm going to push off the move, probably until next week.

 Thank you for the Qt patch!

 I'll post a patch for Mark and we can discuss further from there.

 -eric

 On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba  
 wrote:
> Hi,
>
> I uploaded the necessary buildfix for Qt to the bugzilla:
> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>
> Please be careful with moving JavaScriptCore/wtf to WTF, because we
> need zillion trivial fixes for case sensitive file systems. (~4000 
> files!!!)
>
> I made it locally to be able prepare the Qt buildfix and I had to replace
> all
> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, 
> ...)
> The patch is huge, ~2Mb and ~4000 files are affected.
>
> I suggest landing the following patches separately:
> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
> - s/wtf/WTF/g patch :)
> - platform buildfixes
>
> Please let me know if you have the new date for landing these patches. I
> would be happier with a more CET timezone friendly timing. - 08:00-00:00 
> in
> CET.
>
> br,
> Ossy
>
> Eric Seidel írta:
>
>> We've been talking about moving WTF out of JavaScriptCore for a long
>> time.  We believe we're nearly there.
>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>
>> This will mean that WTF will be built as a separate static library on all
>> ports.
>>
>> The plan is to do this move all in one piece, after work hours PST,
>> when the tree is least active.
>>
>> It won't be the most beautiful transition (as we're likely to break at
>> least one port in the process), but we'll try not to make too much of
>> a mess.
>>
>> We believe all the ports are ready for the move, except AppleWin:
>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>
>> Once AppleWin is ready we'll schedule a date for the transition and
>> announce it one this thread.
>>
>> Thanks!
>>
>> -eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

Going ahead with the land now.

Will be around for several hours fixing builds.  I'm sorry for any breaks.

-eric

On Wed, Mar 21, 2012 at 7:08 PM, Eric Seidel  wrote:
> I've posted my first-draft patch to:
> https://bugs.webkit.org/show_bug.cgi?id=81844
>
> If port maintainers would like to apply it locally and upload improved
> versions (or upload diffs on top of that version) that would be most
> welcome.
>
>
> svn-apply seems to be having trouble with the "adds" for the WTF
> files, thus causing all the EWS bots to fail.
>
> I'm also working on getting a git branch (on github) of my changes, to
> make it easier for port maintainers to send me updates (instead of
> passing around 5MB diffs).
>
>
> At this point it may be best to just land the change tomorrow and fix
> all the buildbots after the fact.  We should be very close, with all
> the header work which has been done over the last month.
>
> -eric
>
> On Tue, Mar 20, 2012 at 5:18 PM, Eric Seidel  wrote:
>> We're ready to complete the move.
>>
>> https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this
>> evening, moving JavaScriptCore/wtf/Platform.h to Source/WTF/Platform.h
>>
>> Tomorrow (Weds) I will move a .cpp file in the same way.
>>
>> Thursday, I will move all the rest of the WTF files.  I will also
>> update svn-apply so that in-flight patches should transparently patch
>> the right files post-move.
>>
>> Let me know if you have questions or concerns.
>>
>> -eric
>>
>> On Tue, Feb 28, 2012 at 3:53 PM, Eric Seidel  wrote:
>>> I'm going to push off the move, probably until next week.
>>>
>>> Thank you for the Qt patch!
>>>
>>> I'll post a patch for Mark and we can discuss further from there.
>>>
>>> -eric
>>>
>>> On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba  
>>> wrote:
 Hi,

 I uploaded the necessary buildfix for Qt to the bugzilla:
 https://bugs.webkit.org/show_bug.cgi?id=79783 .

 Please be careful with moving JavaScriptCore/wtf to WTF, because we
 need zillion trivial fixes for case sensitive file systems. (~4000 
 files!!!)

 I made it locally to be able prepare the Qt buildfix and I had to replace
 all
 "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
 The patch is huge, ~2Mb and ~4000 files are affected.

 I suggest landing the following patches separately:
 - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
 - s/wtf/WTF/g patch :)
 - platform buildfixes

 Please let me know if you have the new date for landing these patches. I
 would be happier with a more CET timezone friendly timing. - 08:00-00:00 in
 CET.

 br,
 Ossy

 Eric Seidel írta:

> We've been talking about moving WTF out of JavaScriptCore for a long
> time.  We believe we're nearly there.
> https://bugs.webkit.org/show_bug.cgi?id=75673
>
> This will mean that WTF will be built as a separate static library on all
> ports.
>
> The plan is to do this move all in one piece, after work hours PST,
> when the tree is least active.
>
> It won't be the most beautiful transition (as we're likely to break at
> least one port in the process), but we'll try not to make too much of
> a mess.
>
> We believe all the ports are ready for the move, except AppleWin:
> https://bugs.webkit.org/show_bug.cgi?id=75897
>
> Once AppleWin is ready we'll schedule a date for the transition and
> announce it one this thread.
>
> Thanks!
>
> -eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

I've posted my first-draft patch to:
https://bugs.webkit.org/show_bug.cgi?id=81844

If port maintainers would like to apply it locally and upload improved
versions (or upload diffs on top of that version) that would be most
welcome.


svn-apply seems to be having trouble with the "adds" for the WTF
files, thus causing all the EWS bots to fail.

I'm also working on getting a git branch (on github) of my changes, to
make it easier for port maintainers to send me updates (instead of
passing around 5MB diffs).


At this point it may be best to just land the change tomorrow and fix
all the buildbots after the fact.  We should be very close, with all
the header work which has been done over the last month.

-eric

On Tue, Mar 20, 2012 at 5:18 PM, Eric Seidel  wrote:
> We're ready to complete the move.
>
> https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this
> evening, moving JavaScriptCore/wtf/Platform.h to Source/WTF/Platform.h
>
> Tomorrow (Weds) I will move a .cpp file in the same way.
>
> Thursday, I will move all the rest of the WTF files.  I will also
> update svn-apply so that in-flight patches should transparently patch
> the right files post-move.
>
> Let me know if you have questions or concerns.
>
> -eric
>
> On Tue, Feb 28, 2012 at 3:53 PM, Eric Seidel  wrote:
>> I'm going to push off the move, probably until next week.
>>
>> Thank you for the Qt patch!
>>
>> I'll post a patch for Mark and we can discuss further from there.
>>
>> -eric
>>
>> On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba  
>> wrote:
>>> Hi,
>>>
>>> I uploaded the necessary buildfix for Qt to the bugzilla:
>>> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>>>
>>> Please be careful with moving JavaScriptCore/wtf to WTF, because we
>>> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>>>
>>> I made it locally to be able prepare the Qt buildfix and I had to replace
>>> all
>>> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
>>> The patch is huge, ~2Mb and ~4000 files are affected.
>>>
>>> I suggest landing the following patches separately:
>>> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
>>> - s/wtf/WTF/g patch :)
>>> - platform buildfixes
>>>
>>> Please let me know if you have the new date for landing these patches. I
>>> would be happier with a more CET timezone friendly timing. - 08:00-00:00 in
>>> CET.
>>>
>>> br,
>>> Ossy
>>>
>>> Eric Seidel írta:
>>>
 We've been talking about moving WTF out of JavaScriptCore for a long
 time.  We believe we're nearly there.
 https://bugs.webkit.org/show_bug.cgi?id=75673

 This will mean that WTF will be built as a separate static library on all
 ports.

 The plan is to do this move all in one piece, after work hours PST,
 when the tree is least active.

 It won't be the most beautiful transition (as we're likely to break at
 least one port in the process), but we'll try not to make too much of
 a mess.

 We believe all the ports are ready for the move, except AppleWin:
 https://bugs.webkit.org/show_bug.cgi?id=75897

 Once AppleWin is ready we'll schedule a date for the transition and
 announce it one this thread.

 Thanks!

 -eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

We're ready to complete the move.

https://bugs.webkit.org/show_bug.cgi?id=80911 should land later this
evening, moving JavaScriptCore/wtf/Platform.h to Source/WTF/Platform.h

Tomorrow (Weds) I will move a .cpp file in the same way.

Thursday, I will move all the rest of the WTF files.  I will also
update svn-apply so that in-flight patches should transparently patch
the right files post-move.

Let me know if you have questions or concerns.

-eric

On Tue, Feb 28, 2012 at 3:53 PM, Eric Seidel  wrote:
> I'm going to push off the move, probably until next week.
>
> Thank you for the Qt patch!
>
> I'll post a patch for Mark and we can discuss further from there.
>
> -eric
>
> On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba  
> wrote:
>> Hi,
>>
>> I uploaded the necessary buildfix for Qt to the bugzilla:
>> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>>
>> Please be careful with moving JavaScriptCore/wtf to WTF, because we
>> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>>
>> I made it locally to be able prepare the Qt buildfix and I had to replace
>> all
>> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
>> The patch is huge, ~2Mb and ~4000 files are affected.
>>
>> I suggest landing the following patches separately:
>> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
>> - s/wtf/WTF/g patch :)
>> - platform buildfixes
>>
>> Please let me know if you have the new date for landing these patches. I
>> would be happier with a more CET timezone friendly timing. - 08:00-00:00 in
>> CET.
>>
>> br,
>> Ossy
>>
>> Eric Seidel írta:
>>
>>> We've been talking about moving WTF out of JavaScriptCore for a long
>>> time.  We believe we're nearly there.
>>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>>
>>> This will mean that WTF will be built as a separate static library on all
>>> ports.
>>>
>>> The plan is to do this move all in one piece, after work hours PST,
>>> when the tree is least active.
>>>
>>> It won't be the most beautiful transition (as we're likely to break at
>>> least one port in the process), but we'll try not to make too much of
>>> a mess.
>>>
>>> We believe all the ports are ready for the move, except AppleWin:
>>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>>
>>> Once AppleWin is ready we'll schedule a date for the transition and
>>> announce it one this thread.
>>>
>>> Thanks!
>>>
>>> -eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2012-02-28, at 17:11, Eric Seidel  wrote:

> I'm fine with Source/wtf.  Very easy to implement.

I think this has the potential to cause problems.  It would lead to adding the 
Source directory to the header search path for some build systems, which would 
cause all sorts of weird #include styles to work even though we don't want to 
support them.  I'd suggest sticking with Source/WTF and the code inside a wtf 
subdirectory, and we can consider further reorganisation down the line if 
necessary.

- Mark

> 
> On Tue, Feb 28, 2012 at 4:59 PM, Geoffrey Garen  wrote:
>> My current plan is to have a WTF/wtf directory to avoid this exact issue. :)
>> 
>> 
>> "WTF/wtf" makes the think, "WTF?" -- which is a fun mental onomatopoeia, but
>> probably not a great design.
>> 
>> Just plain "Source/wtf" looks better to me.
>> 
>> And to avoid the annoyance of 131 files in the root WTF directory.
>> 
>> 
>> I'd prefer to solve this problem -- if it is a problem -- orthogonally.
>> 
>> Geoff

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

I'm fine with Source/wtf.  Very easy to implement.

On Tue, Feb 28, 2012 at 4:59 PM, Geoffrey Garen  wrote:
> My current plan is to have a WTF/wtf directory to avoid this exact issue. :)
>
>
> "WTF/wtf" makes the think, "WTF?" -- which is a fun mental onomatopoeia, but
> probably not a great design.
>
> Just plain "Source/wtf" looks better to me.
>
> And to avoid the annoyance of 131 files in the root WTF directory.
>
>
> I'd prefer to solve this problem -- if it is a problem -- orthogonally.
>
> Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Geoffrey Garen]

> My current plan is to have a WTF/wtf directory to avoid this exact issue. :)

"WTF/wtf" makes the think, "WTF?" -- which is a fun mental onomatopoeia, but 
probably not a great design.

Just plain "Source/wtf" looks better to me.

> And to avoid the annoyance of 131 files in the root WTF directory.

I'd prefer to solve this problem -- if it is a problem -- orthogonally.

Geoff
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

My current plan is to have a WTF/wtf directory to avoid this exact issue. :)

And to avoid the annoyance of 131 files in the root WTF directory.

I'm open to other suggestions if folks have them.

-eric

On Tue, Feb 28, 2012 at 3:59 PM, Mark Rowe  wrote:
>
> On 2012-02-28, at 07:38, Osztrogonac Csaba  wrote:
>
>> Hi,
>>
>> I uploaded the necessary buildfix for Qt to the bugzilla: 
>> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>>
>> Please be careful with moving JavaScriptCore/wtf to WTF, because we
>> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>>
>> I made it locally to be able prepare the Qt buildfix and I had to replace all
>> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
>> The patch is huge, ~2Mb and ~4000 files are affected.
>>
>> I suggest landing the following patches separately:
>> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
>> - s/wtf/WTF/g patch :)
>
> I hadn't considered this issue of case before.  Having to replace all 
> instances of #include  with #include  will make this 
> much, much more likely to cause breakages than if we left the original case 
> alone. It also seems somewhat tangential to the goal of moving WTF out of 
> JavaScriptCore.
>
> - Mark
>
>> Eric Seidel írta:
>>> We've been talking about moving WTF out of JavaScriptCore for a long
>>> time.  We believe we're nearly there.
>>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>> This will mean that WTF will be built as a separate static library on all 
>>> ports.
>>> The plan is to do this move all in one piece, after work hours PST,
>>> when the tree is least active.
>>> It won't be the most beautiful transition (as we're likely to break at
>>> least one port in the process), but we'll try not to make too much of
>>> a mess.
>>> We believe all the ports are ready for the move, except AppleWin:
>>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>> Once AppleWin is ready we'll schedule a date for the transition and
>>> announce it one this thread.
>>> Thanks!
>>> -eric
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Adam Barth]

2012/2/28 Mark Rowe :
>
> On 2012-02-28, at 07:38, Osztrogonac Csaba  wrote:
>
>> Hi,
>>
>> I uploaded the necessary buildfix for Qt to the bugzilla: 
>> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>>
>> Please be careful with moving JavaScriptCore/wtf to WTF, because we
>> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>>
>> I made it locally to be able prepare the Qt buildfix and I had to replace all
>> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
>> The patch is huge, ~2Mb and ~4000 files are affected.
>>
>> I suggest landing the following patches separately:
>> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
>> - s/wtf/WTF/g patch :)
>
> I hadn't considered this issue of case before.  Having to replace all 
> instances of #include  with #include  will make this 
> much, much more likely to cause breakages than if we left the original case 
> alone. It also seems somewhat tangential to the goal of moving WTF out of 
> JavaScriptCore.

Would it be better to use Source/wtf to avoid the capitalization change?

Adam


>> Eric Seidel írta:
>>> We've been talking about moving WTF out of JavaScriptCore for a long
>>> time.  We believe we're nearly there.
>>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>> This will mean that WTF will be built as a separate static library on all 
>>> ports.
>>> The plan is to do this move all in one piece, after work hours PST,
>>> when the tree is least active.
>>> It won't be the most beautiful transition (as we're likely to break at
>>> least one port in the process), but we'll try not to make too much of
>>> a mess.
>>> We believe all the ports are ready for the move, except AppleWin:
>>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>> Once AppleWin is ready we'll schedule a date for the transition and
>>> announce it one this thread.
>>> Thanks!
>>> -eric
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2012-02-28, at 07:38, Osztrogonac Csaba  wrote:

> Hi,
> 
> I uploaded the necessary buildfix for Qt to the bugzilla: 
> https://bugs.webkit.org/show_bug.cgi?id=79783 .
> 
> Please be careful with moving JavaScriptCore/wtf to WTF, because we
> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
> 
> I made it locally to be able prepare the Qt buildfix and I had to replace all
> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
> The patch is huge, ~2Mb and ~4000 files are affected.
> 
> I suggest landing the following patches separately:
> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
> - s/wtf/WTF/g patch :)

I hadn't considered this issue of case before.  Having to replace all instances 
of #include  with #include  will make this much, much 
more likely to cause breakages than if we left the original case alone. It also 
seems somewhat tangential to the goal of moving WTF out of JavaScriptCore.

- Mark

> Eric Seidel írta:
>> We've been talking about moving WTF out of JavaScriptCore for a long
>> time.  We believe we're nearly there.
>> https://bugs.webkit.org/show_bug.cgi?id=75673
>> This will mean that WTF will be built as a separate static library on all 
>> ports.
>> The plan is to do this move all in one piece, after work hours PST,
>> when the tree is least active.
>> It won't be the most beautiful transition (as we're likely to break at
>> least one port in the process), but we'll try not to make too much of
>> a mess.
>> We believe all the ports are ready for the move, except AppleWin:
>> https://bugs.webkit.org/show_bug.cgi?id=75897
>> Once AppleWin is ready we'll schedule a date for the transition and
>> announce it one this thread.
>> Thanks!
>> -eric
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

I'm going to push off the move, probably until next week.

Thank you for the Qt patch!

I'll post a patch for Mark and we can discuss further from there.

-eric

On Tue, Feb 28, 2012 at 7:38 AM, Osztrogonac Csaba  wrote:
> Hi,
>
> I uploaded the necessary buildfix for Qt to the bugzilla:
> https://bugs.webkit.org/show_bug.cgi?id=79783 .
>
> Please be careful with moving JavaScriptCore/wtf to WTF, because we
> need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)
>
> I made it locally to be able prepare the Qt buildfix and I had to replace
> all
> "wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
> The patch is huge, ~2Mb and ~4000 files are affected.
>
> I suggest landing the following patches separately:
> - Moving Sources/JavaScriptCore/wtf --> Sources/WTF
> - s/wtf/WTF/g patch :)
> - platform buildfixes
>
> Please let me know if you have the new date for landing these patches. I
> would be happier with a more CET timezone friendly timing. - 08:00-00:00 in
> CET.
>
> br,
> Ossy
>
> Eric Seidel írta:
>
>> We've been talking about moving WTF out of JavaScriptCore for a long
>> time.  We believe we're nearly there.
>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>
>> This will mean that WTF will be built as a separate static library on all
>> ports.
>>
>> The plan is to do this move all in one piece, after work hours PST,
>> when the tree is least active.
>>
>> It won't be the most beautiful transition (as we're likely to break at
>> least one port in the process), but we'll try not to make too much of
>> a mess.
>>
>> We believe all the ports are ready for the move, except AppleWin:
>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>
>> Once AppleWin is ready we'll schedule a date for the transition and
>> announce it one this thread.
>>
>> Thanks!
>>
>> -eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Osztrogonac Csaba]

Hi,

I uploaded the necessary buildfix for Qt to the bugzilla: 
https://bugs.webkit.org/show_bug.cgi?id=79783 .

Please be careful with moving JavaScriptCore/wtf to WTF, because we
need zillion trivial fixes for case sensitive file systems. (~4000 files!!!)

I made it locally to be able prepare the Qt buildfix and I had to replace all
"wtf" to "WTF includes everywhere. (*.cpp, *.h, *.y, *.py, *.pl, *.pm, ...)
The patch is huge, ~2Mb and ~4000 files are affected.

I suggest landing the following patches separately:
- Moving Sources/JavaScriptCore/wtf --> Sources/WTF
- s/wtf/WTF/g patch :)
- platform buildfixes

Please let me know if you have the new date for landing these patches. I
would be happier with a more CET timezone friendly timing. - 08:00-00:00 in CET.

br,
Ossy

Eric Seidel írta:

We've been talking about moving WTF out of JavaScriptCore for a long
time.  We believe we're nearly there.
https://bugs.webkit.org/show_bug.cgi?id=75673

This will mean that WTF will be built as a separate static library on all ports.

The plan is to do this move all in one piece, after work hours PST,
when the tree is least active.

It won't be the most beautiful transition (as we're likely to break at
least one port in the process), but we'll try not to make too much of
a mess.

We believe all the ports are ready for the move, except AppleWin:
https://bugs.webkit.org/show_bug.cgi?id=75897

Once AppleWin is ready we'll schedule a date for the transition and
announce it one this thread.

Thanks!

-eric

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

On Mon, Feb 27, 2012 at 3:47 PM, Mark Rowe  wrote:
>
> On 2012-02-27, at 15:46, Eric Seidel  wrote:
>
>> The patch will be large (and thus likely un-reviewable/readable). But
>> sure.  I'll make sure to have a Mac-only patch for you by EOD
>> tomorrow.
>
> Mac-only in what sense?  We'd like to ensure it doesn't break our Windows 
> builds too!

Understandable.  I'll see what I can do.  I'll update you tomorrow,
and we can push the date back again depending on our findings.

-eric

>> I'll email this list with a link to the patch.
>
> Thanks!
>
> - Mark
>
>> On Mon, Feb 27, 2012 at 3:43 PM, Mark Rowe  wrote:
>>> This will require some coordination to ensure that it doesn't break Apple's 
>>> internal builds. It would be great if you could post a patch ahead of time 
>>> so that we have some time to test and prepare for the changes on our side.
>>>
>>> Thanks,
>>>
>>> - Mark
>>>
>>> On 2012-02-27, at 15:27, Eric Seidel  wrote:
>>>
 Thank you, particularly to the Qt/Gtk folks who further readied their
 ports for this move over the last month.

 We're ready to go forward with this.


 We will be moving Source/JavaScriptCore/wtf to Source/WTF (and
 associated build files) this Wednesday, Feb 27th, 5PM PST.


 The move will likely break a couple bots, but I'll be watching the
 bots and will pick up any pieces.

 Let me know if you have issues with this specific timeframe, and
 thanks again for all your help.

 -eric

 On Tue, Jan 10, 2012 at 10:35 AM, Eric Seidel  wrote:
> If a Qt person wants to make this move even less error-prone for Qt,
> adding a newwtf.a library which just builds WTF/Stub.cpp and links it
> into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
> then there won't need to be any guess work on my part when moving
> wtf.a  I'll have newwtf.a as an example.
>
> If you look in Source/WTF/ you can see examples of how Gtk, Mac and
> Chromium build/link in newwtf.a today.
>
> On Tue, Jan 10, 2012 at 7:41 AM, Jarred Nicholls  
> wrote:
>> On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard 
>> 
>> wrote:
>>>
>>> On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
>>>  wrote:
 On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
> We've been talking about moving WTF out of JavaScriptCore for a long
> time.  We believe we're nearly there.
> https://bugs.webkit.org/show_bug.cgi?id=75673
>
> This will mean that WTF will be built as a separate static library on
> all ports.
>
> The plan is to do this move all in one piece, after work hours PST,
> when the tree is least active.
>
> It won't be the most beautiful transition (as we're likely to break at
> least one port in the process), but we'll try not to make too much of
> a mess.
>
> We believe all the ports are ready for the move, except AppleWin:
> https://bugs.webkit.org/show_bug.cgi?id=75897
>
> Once AppleWin is ready we'll schedule a date for the transition and
> announce it one this thread.

 Hi Eric,

 Is there a patch somewhere or you are still working on it? The bug
 link contains nothing.

 I would like to apply it here and test the Qt port so you'll get a bit
 more confidence before landing it. I believe other ports are
 interested too.
>>>
>>> Nevermind wtf is already a static lib for Qt :D.
>>>
>>> /me is going to hide himself for not opening wtf.pro for a while.
>>
>>
>> To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
>> Source/WTF, there would still be project file changes necessary to 
>> support
>> that move, so testing it wouldn't hurt :)
>>
>> -Jarred
>>
>>>
>>>

 Thanks.

>
> Thanks!
>
> -eric
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



 --
 Alexis Menard (darktears)
 Software Engineer
 INdT Recife Brazil
>>>
>>>
>>>
>>> --
>>> Alexis Menard (darktears)
>>> Software Engineer
>>> INdT Recife Brazil
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.we

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2012-02-27, at 15:46, Eric Seidel  wrote:

> The patch will be large (and thus likely un-reviewable/readable). But
> sure.  I'll make sure to have a Mac-only patch for you by EOD
> tomorrow.

Mac-only in what sense?  We'd like to ensure it doesn't break our Windows 
builds too!

> I'll email this list with a link to the patch.

Thanks!

- Mark

> On Mon, Feb 27, 2012 at 3:43 PM, Mark Rowe  wrote:
>> This will require some coordination to ensure that it doesn't break Apple's 
>> internal builds. It would be great if you could post a patch ahead of time 
>> so that we have some time to test and prepare for the changes on our side.
>> 
>> Thanks,
>> 
>> - Mark
>> 
>> On 2012-02-27, at 15:27, Eric Seidel  wrote:
>> 
>>> Thank you, particularly to the Qt/Gtk folks who further readied their
>>> ports for this move over the last month.
>>> 
>>> We're ready to go forward with this.
>>> 
>>> 
>>> We will be moving Source/JavaScriptCore/wtf to Source/WTF (and
>>> associated build files) this Wednesday, Feb 27th, 5PM PST.
>>> 
>>> 
>>> The move will likely break a couple bots, but I'll be watching the
>>> bots and will pick up any pieces.
>>> 
>>> Let me know if you have issues with this specific timeframe, and
>>> thanks again for all your help.
>>> 
>>> -eric
>>> 
>>> On Tue, Jan 10, 2012 at 10:35 AM, Eric Seidel  wrote:
 If a Qt person wants to make this move even less error-prone for Qt,
 adding a newwtf.a library which just builds WTF/Stub.cpp and links it
 into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
 then there won't need to be any guess work on my part when moving
 wtf.a  I'll have newwtf.a as an example.
 
 If you look in Source/WTF/ you can see examples of how Gtk, Mac and
 Chromium build/link in newwtf.a today.
 
 On Tue, Jan 10, 2012 at 7:41 AM, Jarred Nicholls  wrote:
> On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard 
> 
> wrote:
>> 
>> On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
>>  wrote:
>>> On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
 We've been talking about moving WTF out of JavaScriptCore for a long
 time.  We believe we're nearly there.
 https://bugs.webkit.org/show_bug.cgi?id=75673
 
 This will mean that WTF will be built as a separate static library on
 all ports.
 
 The plan is to do this move all in one piece, after work hours PST,
 when the tree is least active.
 
 It won't be the most beautiful transition (as we're likely to break at
 least one port in the process), but we'll try not to make too much of
 a mess.
 
 We believe all the ports are ready for the move, except AppleWin:
 https://bugs.webkit.org/show_bug.cgi?id=75897
 
 Once AppleWin is ready we'll schedule a date for the transition and
 announce it one this thread.
>>> 
>>> Hi Eric,
>>> 
>>> Is there a patch somewhere or you are still working on it? The bug
>>> link contains nothing.
>>> 
>>> I would like to apply it here and test the Qt port so you'll get a bit
>>> more confidence before landing it. I believe other ports are
>>> interested too.
>> 
>> Nevermind wtf is already a static lib for Qt :D.
>> 
>> /me is going to hide himself for not opening wtf.pro for a while.
> 
> 
> To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
> Source/WTF, there would still be project file changes necessary to support
> that move, so testing it wouldn't hurt :)
> 
> -Jarred
> 
>> 
>> 
>>> 
>>> Thanks.
>>> 
 
 Thanks!
 
 -eric
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>> 
>>> 
>>> 
>>> --
>>> Alexis Menard (darktears)
>>> Software Engineer
>>> INdT Recife Brazil
>> 
>> 
>> 
>> --
>> Alexis Menard (darktears)
>> Software Engineer
>> INdT Recife Brazil
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> 
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

The patch will be large (and thus likely un-reviewable/readable). But
sure.  I'll make sure to have a Mac-only patch for you by EOD
tomorrow.

I'll email this list with a link to the patch.

On Mon, Feb 27, 2012 at 3:43 PM, Mark Rowe  wrote:
> This will require some coordination to ensure that it doesn't break Apple's 
> internal builds. It would be great if you could post a patch ahead of time so 
> that we have some time to test and prepare for the changes on our side.
>
> Thanks,
>
> - Mark
>
> On 2012-02-27, at 15:27, Eric Seidel  wrote:
>
>> Thank you, particularly to the Qt/Gtk folks who further readied their
>> ports for this move over the last month.
>>
>> We're ready to go forward with this.
>>
>>
>> We will be moving Source/JavaScriptCore/wtf to Source/WTF (and
>> associated build files) this Wednesday, Feb 27th, 5PM PST.
>>
>>
>> The move will likely break a couple bots, but I'll be watching the
>> bots and will pick up any pieces.
>>
>> Let me know if you have issues with this specific timeframe, and
>> thanks again for all your help.
>>
>> -eric
>>
>> On Tue, Jan 10, 2012 at 10:35 AM, Eric Seidel  wrote:
>>> If a Qt person wants to make this move even less error-prone for Qt,
>>> adding a newwtf.a library which just builds WTF/Stub.cpp and links it
>>> into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
>>> then there won't need to be any guess work on my part when moving
>>> wtf.a  I'll have newwtf.a as an example.
>>>
>>> If you look in Source/WTF/ you can see examples of how Gtk, Mac and
>>> Chromium build/link in newwtf.a today.
>>>
>>> On Tue, Jan 10, 2012 at 7:41 AM, Jarred Nicholls  wrote:
 On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard 
 
 wrote:
>
> On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
>  wrote:
>> On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
>>> We've been talking about moving WTF out of JavaScriptCore for a long
>>> time.  We believe we're nearly there.
>>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>>
>>> This will mean that WTF will be built as a separate static library on
>>> all ports.
>>>
>>> The plan is to do this move all in one piece, after work hours PST,
>>> when the tree is least active.
>>>
>>> It won't be the most beautiful transition (as we're likely to break at
>>> least one port in the process), but we'll try not to make too much of
>>> a mess.
>>>
>>> We believe all the ports are ready for the move, except AppleWin:
>>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>>
>>> Once AppleWin is ready we'll schedule a date for the transition and
>>> announce it one this thread.
>>
>> Hi Eric,
>>
>> Is there a patch somewhere or you are still working on it? The bug
>> link contains nothing.
>>
>> I would like to apply it here and test the Qt port so you'll get a bit
>> more confidence before landing it. I believe other ports are
>> interested too.
>
> Nevermind wtf is already a static lib for Qt :D.
>
> /me is going to hide himself for not opening wtf.pro for a while.


 To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
 Source/WTF, there would still be project file changes necessary to support
 that move, so testing it wouldn't hurt :)

 -Jarred

>
>
>>
>> Thanks.
>>
>>>
>>> Thanks!
>>>
>>> -eric
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
>>
>> --
>> Alexis Menard (darktears)
>> Software Engineer
>> INdT Recife Brazil
>
>
>
> --
> Alexis Menard (darktears)
> Software Engineer
> INdT Recife Brazil
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

This will require some coordination to ensure that it doesn't break Apple's 
internal builds. It would be great if you could post a patch ahead of time so 
that we have some time to test and prepare for the changes on our side.

Thanks,

- Mark

On 2012-02-27, at 15:27, Eric Seidel  wrote:

> Thank you, particularly to the Qt/Gtk folks who further readied their
> ports for this move over the last month.
> 
> We're ready to go forward with this.
> 
> 
> We will be moving Source/JavaScriptCore/wtf to Source/WTF (and
> associated build files) this Wednesday, Feb 27th, 5PM PST.
> 
> 
> The move will likely break a couple bots, but I'll be watching the
> bots and will pick up any pieces.
> 
> Let me know if you have issues with this specific timeframe, and
> thanks again for all your help.
> 
> -eric
> 
> On Tue, Jan 10, 2012 at 10:35 AM, Eric Seidel  wrote:
>> If a Qt person wants to make this move even less error-prone for Qt,
>> adding a newwtf.a library which just builds WTF/Stub.cpp and links it
>> into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
>> then there won't need to be any guess work on my part when moving
>> wtf.a  I'll have newwtf.a as an example.
>> 
>> If you look in Source/WTF/ you can see examples of how Gtk, Mac and
>> Chromium build/link in newwtf.a today.
>> 
>> On Tue, Jan 10, 2012 at 7:41 AM, Jarred Nicholls  wrote:
>>> On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard 
>>> wrote:
 
 On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
  wrote:
> On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
>> We've been talking about moving WTF out of JavaScriptCore for a long
>> time.  We believe we're nearly there.
>> https://bugs.webkit.org/show_bug.cgi?id=75673
>> 
>> This will mean that WTF will be built as a separate static library on
>> all ports.
>> 
>> The plan is to do this move all in one piece, after work hours PST,
>> when the tree is least active.
>> 
>> It won't be the most beautiful transition (as we're likely to break at
>> least one port in the process), but we'll try not to make too much of
>> a mess.
>> 
>> We believe all the ports are ready for the move, except AppleWin:
>> https://bugs.webkit.org/show_bug.cgi?id=75897
>> 
>> Once AppleWin is ready we'll schedule a date for the transition and
>> announce it one this thread.
> 
> Hi Eric,
> 
> Is there a patch somewhere or you are still working on it? The bug
> link contains nothing.
> 
> I would like to apply it here and test the Qt port so you'll get a bit
> more confidence before landing it. I believe other ports are
> interested too.
 
 Nevermind wtf is already a static lib for Qt :D.
 
 /me is going to hide himself for not opening wtf.pro for a while.
>>> 
>>> 
>>> To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
>>> Source/WTF, there would still be project file changes necessary to support
>>> that move, so testing it wouldn't hurt :)
>>> 
>>> -Jarred
>>> 
 
 
> 
> Thanks.
> 
>> 
>> Thanks!
>> 
>> -eric
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> 
> 
> 
> --
> Alexis Menard (darktears)
> Software Engineer
> INdT Recife Brazil
 
 
 
 --
 Alexis Menard (darktears)
 Software Engineer
 INdT Recife Brazil
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>> 
>>> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

Thank you, particularly to the Qt/Gtk folks who further readied their
ports for this move over the last month.

We're ready to go forward with this.


We will be moving Source/JavaScriptCore/wtf to Source/WTF (and
associated build files) this Wednesday, Feb 27th, 5PM PST.


The move will likely break a couple bots, but I'll be watching the
bots and will pick up any pieces.

Let me know if you have issues with this specific timeframe, and
thanks again for all your help.

-eric

On Tue, Jan 10, 2012 at 10:35 AM, Eric Seidel  wrote:
> If a Qt person wants to make this move even less error-prone for Qt,
> adding a newwtf.a library which just builds WTF/Stub.cpp and links it
> into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
> then there won't need to be any guess work on my part when moving
> wtf.a  I'll have newwtf.a as an example.
>
> If you look in Source/WTF/ you can see examples of how Gtk, Mac and
> Chromium build/link in newwtf.a today.
>
> On Tue, Jan 10, 2012 at 7:41 AM, Jarred Nicholls  wrote:
>> On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard 
>> wrote:
>>>
>>> On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
>>>  wrote:
>>> > On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
>>> >> We've been talking about moving WTF out of JavaScriptCore for a long
>>> >> time.  We believe we're nearly there.
>>> >> https://bugs.webkit.org/show_bug.cgi?id=75673
>>> >>
>>> >> This will mean that WTF will be built as a separate static library on
>>> >> all ports.
>>> >>
>>> >> The plan is to do this move all in one piece, after work hours PST,
>>> >> when the tree is least active.
>>> >>
>>> >> It won't be the most beautiful transition (as we're likely to break at
>>> >> least one port in the process), but we'll try not to make too much of
>>> >> a mess.
>>> >>
>>> >> We believe all the ports are ready for the move, except AppleWin:
>>> >> https://bugs.webkit.org/show_bug.cgi?id=75897
>>> >>
>>> >> Once AppleWin is ready we'll schedule a date for the transition and
>>> >> announce it one this thread.
>>> >
>>> > Hi Eric,
>>> >
>>> > Is there a patch somewhere or you are still working on it? The bug
>>> > link contains nothing.
>>> >
>>> > I would like to apply it here and test the Qt port so you'll get a bit
>>> > more confidence before landing it. I believe other ports are
>>> > interested too.
>>>
>>> Nevermind wtf is already a static lib for Qt :D.
>>>
>>> /me is going to hide himself for not opening wtf.pro for a while.
>>
>>
>> To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
>> Source/WTF, there would still be project file changes necessary to support
>> that move, so testing it wouldn't hurt :)
>>
>> -Jarred
>>
>>>
>>>
>>> >
>>> > Thanks.
>>> >
>>> >>
>>> >> Thanks!
>>> >>
>>> >> -eric
>>> >> ___
>>> >> webkit-dev mailing list
>>> >> webkit-dev@lists.webkit.org
>>> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>> >
>>> >
>>> >
>>> > --
>>> > Alexis Menard (darktears)
>>> > Software Engineer
>>> > INdT Recife Brazil
>>>
>>>
>>>
>>> --
>>> Alexis Menard (darktears)
>>> Software Engineer
>>> INdT Recife Brazil
>>> ___
>>> webkit-dev mailing list
>>> webkit-dev@lists.webkit.org
>>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>>
>>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

If a Qt person wants to make this move even less error-prone for Qt,
adding a newwtf.a library which just builds WTF/Stub.cpp and links it
into JavaScriptCore (similar to what Mac, Gtk, and Chromium do today),
then there won't need to be any guess work on my part when moving
wtf.a  I'll have newwtf.a as an example.

If you look in Source/WTF/ you can see examples of how Gtk, Mac and
Chromium build/link in newwtf.a today.

On Tue, Jan 10, 2012 at 7:41 AM, Jarred Nicholls  wrote:
> On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard 
> wrote:
>>
>> On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
>>  wrote:
>> > On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
>> >> We've been talking about moving WTF out of JavaScriptCore for a long
>> >> time.  We believe we're nearly there.
>> >> https://bugs.webkit.org/show_bug.cgi?id=75673
>> >>
>> >> This will mean that WTF will be built as a separate static library on
>> >> all ports.
>> >>
>> >> The plan is to do this move all in one piece, after work hours PST,
>> >> when the tree is least active.
>> >>
>> >> It won't be the most beautiful transition (as we're likely to break at
>> >> least one port in the process), but we'll try not to make too much of
>> >> a mess.
>> >>
>> >> We believe all the ports are ready for the move, except AppleWin:
>> >> https://bugs.webkit.org/show_bug.cgi?id=75897
>> >>
>> >> Once AppleWin is ready we'll schedule a date for the transition and
>> >> announce it one this thread.
>> >
>> > Hi Eric,
>> >
>> > Is there a patch somewhere or you are still working on it? The bug
>> > link contains nothing.
>> >
>> > I would like to apply it here and test the Qt port so you'll get a bit
>> > more confidence before landing it. I believe other ports are
>> > interested too.
>>
>> Nevermind wtf is already a static lib for Qt :D.
>>
>> /me is going to hide himself for not opening wtf.pro for a while.
>
>
> To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
> Source/WTF, there would still be project file changes necessary to support
> that move, so testing it wouldn't hurt :)
>
> -Jarred
>
>>
>>
>> >
>> > Thanks.
>> >
>> >>
>> >> Thanks!
>> >>
>> >> -eric
>> >> ___
>> >> webkit-dev mailing list
>> >> webkit-dev@lists.webkit.org
>> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>> >
>> >
>> >
>> > --
>> > Alexis Menard (darktears)
>> > Software Engineer
>> > INdT Recife Brazil
>>
>>
>>
>> --
>> Alexis Menard (darktears)
>> Software Engineer
>> INdT Recife Brazil
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Jarred Nicholls]

On Tue, Jan 10, 2012 at 5:41 AM, Alexis Menard
wrote:

> On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
>  wrote:
> > On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
> >> We've been talking about moving WTF out of JavaScriptCore for a long
> >> time.  We believe we're nearly there.
> >> https://bugs.webkit.org/show_bug.cgi?id=75673
> >>
> >> This will mean that WTF will be built as a separate static library on
> all ports.
> >>
> >> The plan is to do this move all in one piece, after work hours PST,
> >> when the tree is least active.
> >>
> >> It won't be the most beautiful transition (as we're likely to break at
> >> least one port in the process), but we'll try not to make too much of
> >> a mess.
> >>
> >> We believe all the ports are ready for the move, except AppleWin:
> >> https://bugs.webkit.org/show_bug.cgi?id=75897
> >>
> >> Once AppleWin is ready we'll schedule a date for the transition and
> >> announce it one this thread.
> >
> > Hi Eric,
> >
> > Is there a patch somewhere or you are still working on it? The bug
> > link contains nothing.
> >
> > I would like to apply it here and test the Qt port so you'll get a bit
> > more confidence before landing it. I believe other ports are
> > interested too.
>
> Nevermind wtf is already a static lib for Qt :D.
>
> /me is going to hide himself for not opening wtf.pro for a while.
>

To be clear, if we're talking about moving Source/JavaScriptCore/wtf =>
Source/WTF, there would still be project file changes necessary to support
that move, so testing it wouldn't hurt :)

-Jarred


>
> >
> > Thanks.
> >
> >>
> >> Thanks!
> >>
> >> -eric
> >> ___
> >> webkit-dev mailing list
> >> webkit-dev@lists.webkit.org
> >> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
> >
> >
> >
> > --
> > Alexis Menard (darktears)
> > Software Engineer
> > INdT Recife Brazil
>
>
>
> --
> Alexis Menard (darktears)
> Software Engineer
> INdT Recife Brazil
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Alexis Menard]

On Tue, Jan 10, 2012 at 7:07 AM, Alexis Menard
 wrote:
> On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
>> We've been talking about moving WTF out of JavaScriptCore for a long
>> time.  We believe we're nearly there.
>> https://bugs.webkit.org/show_bug.cgi?id=75673
>>
>> This will mean that WTF will be built as a separate static library on all 
>> ports.
>>
>> The plan is to do this move all in one piece, after work hours PST,
>> when the tree is least active.
>>
>> It won't be the most beautiful transition (as we're likely to break at
>> least one port in the process), but we'll try not to make too much of
>> a mess.
>>
>> We believe all the ports are ready for the move, except AppleWin:
>> https://bugs.webkit.org/show_bug.cgi?id=75897
>>
>> Once AppleWin is ready we'll schedule a date for the transition and
>> announce it one this thread.
>
> Hi Eric,
>
> Is there a patch somewhere or you are still working on it? The bug
> link contains nothing.
>
> I would like to apply it here and test the Qt port so you'll get a bit
> more confidence before landing it. I believe other ports are
> interested too.

Nevermind wtf is already a static lib for Qt :D.

/me is going to hide himself for not opening wtf.pro for a while.

>
> Thanks.
>
>>
>> Thanks!
>>
>> -eric
>> ___
>> webkit-dev mailing list
>> webkit-dev@lists.webkit.org
>> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
>
>
> --
> Alexis Menard (darktears)
> Software Engineer
> INdT Recife Brazil



-- 
Alexis Menard (darktears)
Software Engineer
INdT Recife Brazil
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Alexis Menard]

On Mon, Jan 9, 2012 at 8:36 PM, Eric Seidel  wrote:
> We've been talking about moving WTF out of JavaScriptCore for a long
> time.  We believe we're nearly there.
> https://bugs.webkit.org/show_bug.cgi?id=75673
>
> This will mean that WTF will be built as a separate static library on all 
> ports.
>
> The plan is to do this move all in one piece, after work hours PST,
> when the tree is least active.
>
> It won't be the most beautiful transition (as we're likely to break at
> least one port in the process), but we'll try not to make too much of
> a mess.
>
> We believe all the ports are ready for the move, except AppleWin:
> https://bugs.webkit.org/show_bug.cgi?id=75897
>
> Once AppleWin is ready we'll schedule a date for the transition and
> announce it one this thread.

Hi Eric,

Is there a patch somewhere or you are still working on it? The bug
link contains nothing.

I would like to apply it here and test the Qt port so you'll get a bit
more confidence before landing it. I believe other ports are
interested too.

Thanks.

>
> Thanks!
>
> -eric
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev



-- 
Alexis Menard (darktears)
Software Engineer
INdT Recife Brazil
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

We've been talking about moving WTF out of JavaScriptCore for a long
time.  We believe we're nearly there.
https://bugs.webkit.org/show_bug.cgi?id=75673

This will mean that WTF will be built as a separate static library on all ports.

The plan is to do this move all in one piece, after work hours PST,
when the tree is least active.

It won't be the most beautiful transition (as we're likely to break at
least one port in the process), but we'll try not to make too much of
a mess.

We believe all the ports are ready for the move, except AppleWin:
https://bugs.webkit.org/show_bug.cgi?id=75897

Once AppleWin is ready we'll schedule a date for the transition and
announce it one this thread.

Thanks!

-eric
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Adam Barth]

On Fri, Nov 4, 2011 at 12:04 PM, Mark Rowe  wrote:
> On 2011-11-04, at 11:56, Adam Barth wrote:
>> I've created a "stub" WTF library at
>> http://trac.webkit.org/browser/trunk/Source/WTF
>>
>> Would you be willing to create an appropriate xcodeproj file that
>> builds Stub.h and Stub.cpp (and integrates with whatever magic is
>> needed internally at Apple)?  I'm also happy to attempt webkit.org
>> side of that change if you'd prefer, but I suspect you know better
>> what the contrains are.
>
> Yup, it's on my list.

Thanks!

Adam


>> On Wed, Nov 2, 2011 at 4:47 PM, Adam Barth  wrote:
>>> On Wed, Nov 2, 2011 at 4:35 PM, Mark Rowe  wrote:
 On 2011-11-02, at 16:32, Adam Barth wrote:
> On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe  wrote:
>> On 2011-11-02, at 13:23, Adam Barth wrote:
>>> As discussed previously, I think it would benefit the project to move
>>> WTF out of JavaScriptCore:
>>>
>>> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
>>> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
>>>
>>> Previously, we've been unable to do this because of Apple's internal
>>> build process.  In thinking about this problem again recently, I
>>> wonder if the following would work:
>>>
>>> 1) Move JavaScriptCore.xcodeproj from
>>> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
>>> Source/JavaScriptCore.xcodeproj.
>>> 2) Change how Apple submits JavaScriptCore to the internal build
>>> process to submit Source as the code for "JavaScriptCore" instead of
>>> Source/JavaScriptCore.
>>> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
>>>
>>> Mark, do you have a sense for whether this plan is feasible?  If not,
>>> is there another approach that would work better?
>>>
>>> (If my understanding is correct, we could also apply this approach to
>>> the other xcodeproj files, which would let us get rid of
>>> ForwardingHeaders and move Source/WebCore/platform to
>>> Source/Platform.)
>>
>> There are a few related goals here that I'm aware of:
>> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
>> there, but was simply a convenient home for it.
>> b) Separate WebCore/platform out of WebCore to help avoid layering 
>> violations.
>> c) Rework the Mac build process so that we can eliminate forwarding 
>> headers and remove the duplication of .xcconfig files.
>
> Yes.  These are the goals.
>
>> The process for addressing a) and b) will be similar:
>> 1) Move the relevant code from its current location to the new location.
>> 2) Create a new Xcode project that builds the desired output in the 
>> appropriate fashion. Update other build systems as is applicable.
>> 3) Apple starts including the new project in our build process.
>>
>> I don't see any benefit or need to move existing Xcode projects as part 
>> of this process.  Can you expand on why you included this in your 
>> proposal?
>
> Based on our previous discussions, I was unsure how difficult (3) was
> on your end.  If we can make (a) and (b) happen in the near term
> without moving xcodeproj files around, that would make me a happy
> camper.

 The code moving and the new Xcode project is relatively easy. I'm not sure 
 what will be involved in updating all of the other build systems though.
>>>
>>> I'm happy to coordinate that part of the effort.
>>>
>> I'm not entirely clear on what we'll need to do to tackle c). My current 
>> feeling is that it will mainly involve reshuffling of Apple's build 
>> processes rather than any significant changes to WebKit.
>
> Maybe we should aim to do (a) first, then (b), and then work on (c)
> once we've figured out what needs to happen on Apple's end?

 My recollection of the situation with WebCore/platform is that there are a 
 number of existing layering violations in some ports.  Given the approach 
 outlined above I suspect they may need to be addressed before we can start 
 making progress on b).
>>>
>>> Yes.  Fixing these issues is going to be a fair amount of work.
>>> Perhaps it would make sense to create a stub Platform project for now,
>>> which will let us move code from WebCore/platform into Platform as we
>>> clean up the dependencies.
>>>
>>> Adam
>>>
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Mark Rowe]

On 2011-11-04, at 11:56, Adam Barth wrote:

> Mark,
> 
> I've created a "stub" WTF library at
> http://trac.webkit.org/browser/trunk/Source/WTF
> 
> Would you be willing to create an appropriate xcodeproj file that
> builds Stub.h and Stub.cpp (and integrates with whatever magic is
> needed internally at Apple)?  I'm also happy to attempt webkit.org
> side of that change if you'd prefer, but I suspect you know better
> what the contrains are.

Yup, it's on my list.

- Mark

> 
> On Wed, Nov 2, 2011 at 4:47 PM, Adam Barth  wrote:
>> On Wed, Nov 2, 2011 at 4:35 PM, Mark Rowe  wrote:
>>> On 2011-11-02, at 16:32, Adam Barth wrote:
 On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe  wrote:
> On 2011-11-02, at 13:23, Adam Barth wrote:
>> As discussed previously, I think it would benefit the project to move
>> WTF out of JavaScriptCore:
>> 
>> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
>> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
>> 
>> Previously, we've been unable to do this because of Apple's internal
>> build process.  In thinking about this problem again recently, I
>> wonder if the following would work:
>> 
>> 1) Move JavaScriptCore.xcodeproj from
>> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
>> Source/JavaScriptCore.xcodeproj.
>> 2) Change how Apple submits JavaScriptCore to the internal build
>> process to submit Source as the code for "JavaScriptCore" instead of
>> Source/JavaScriptCore.
>> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
>> 
>> Mark, do you have a sense for whether this plan is feasible?  If not,
>> is there another approach that would work better?
>> 
>> (If my understanding is correct, we could also apply this approach to
>> the other xcodeproj files, which would let us get rid of
>> ForwardingHeaders and move Source/WebCore/platform to
>> Source/Platform.)
> 
> There are a few related goals here that I'm aware of:
> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
> there, but was simply a convenient home for it.
> b) Separate WebCore/platform out of WebCore to help avoid layering 
> violations.
> c) Rework the Mac build process so that we can eliminate forwarding 
> headers and remove the duplication of .xcconfig files.
 
 Yes.  These are the goals.
 
> The process for addressing a) and b) will be similar:
> 1) Move the relevant code from its current location to the new location.
> 2) Create a new Xcode project that builds the desired output in the 
> appropriate fashion. Update other build systems as is applicable.
> 3) Apple starts including the new project in our build process.
> 
> I don't see any benefit or need to move existing Xcode projects as part 
> of this process.  Can you expand on why you included this in your 
> proposal?
 
 Based on our previous discussions, I was unsure how difficult (3) was
 on your end.  If we can make (a) and (b) happen in the near term
 without moving xcodeproj files around, that would make me a happy
 camper.
>>> 
>>> The code moving and the new Xcode project is relatively easy. I'm not sure 
>>> what will be involved in updating all of the other build systems though.
>> 
>> I'm happy to coordinate that part of the effort.
>> 
> I'm not entirely clear on what we'll need to do to tackle c). My current 
> feeling is that it will mainly involve reshuffling of Apple's build 
> processes rather than any significant changes to WebKit.
 
 Maybe we should aim to do (a) first, then (b), and then work on (c)
 once we've figured out what needs to happen on Apple's end?
>>> 
>>> My recollection of the situation with WebCore/platform is that there are a 
>>> number of existing layering violations in some ports.  Given the approach 
>>> outlined above I suspect they may need to be addressed before we can start 
>>> making progress on b).
>> 
>> Yes.  Fixing these issues is going to be a fair amount of work.
>> Perhaps it would make sense to create a stub Platform project for now,
>> which will let us move code from WebCore/platform into Platform as we
>> clean up the dependencies.
>> 
>> Adam
>> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Adam Barth]

Mark,

I've created a "stub" WTF library at
http://trac.webkit.org/browser/trunk/Source/WTF

Would you be willing to create an appropriate xcodeproj file that
builds Stub.h and Stub.cpp (and integrates with whatever magic is
needed internally at Apple)?  I'm also happy to attempt webkit.org
side of that change if you'd prefer, but I suspect you know better
what the contrains are.

Thanks,
Adam


On Wed, Nov 2, 2011 at 4:47 PM, Adam Barth  wrote:
> On Wed, Nov 2, 2011 at 4:35 PM, Mark Rowe  wrote:
>> On 2011-11-02, at 16:32, Adam Barth wrote:
>>> On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe  wrote:
 On 2011-11-02, at 13:23, Adam Barth wrote:
> As discussed previously, I think it would benefit the project to move
> WTF out of JavaScriptCore:
>
> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
>
> Previously, we've been unable to do this because of Apple's internal
> build process.  In thinking about this problem again recently, I
> wonder if the following would work:
>
> 1) Move JavaScriptCore.xcodeproj from
> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
> Source/JavaScriptCore.xcodeproj.
> 2) Change how Apple submits JavaScriptCore to the internal build
> process to submit Source as the code for "JavaScriptCore" instead of
> Source/JavaScriptCore.
> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
>
> Mark, do you have a sense for whether this plan is feasible?  If not,
> is there another approach that would work better?
>
> (If my understanding is correct, we could also apply this approach to
> the other xcodeproj files, which would let us get rid of
> ForwardingHeaders and move Source/WebCore/platform to
> Source/Platform.)

 There are a few related goals here that I'm aware of:
 a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
 there, but was simply a convenient home for it.
 b) Separate WebCore/platform out of WebCore to help avoid layering 
 violations.
 c) Rework the Mac build process so that we can eliminate forwarding 
 headers and remove the duplication of .xcconfig files.
>>>
>>> Yes.  These are the goals.
>>>
 The process for addressing a) and b) will be similar:
 1) Move the relevant code from its current location to the new location.
 2) Create a new Xcode project that builds the desired output in the 
 appropriate fashion. Update other build systems as is applicable.
 3) Apple starts including the new project in our build process.

 I don't see any benefit or need to move existing Xcode projects as part of 
 this process.  Can you expand on why you included this in your proposal?
>>>
>>> Based on our previous discussions, I was unsure how difficult (3) was
>>> on your end.  If we can make (a) and (b) happen in the near term
>>> without moving xcodeproj files around, that would make me a happy
>>> camper.
>>
>> The code moving and the new Xcode project is relatively easy. I'm not sure 
>> what will be involved in updating all of the other build systems though.
>
> I'm happy to coordinate that part of the effort.
>
 I'm not entirely clear on what we'll need to do to tackle c). My current 
 feeling is that it will mainly involve reshuffling of Apple's build 
 processes rather than any significant changes to WebKit.
>>>
>>> Maybe we should aim to do (a) first, then (b), and then work on (c)
>>> once we've figured out what needs to happen on Apple's end?
>>
>> My recollection of the situation with WebCore/platform is that there are a 
>> number of existing layering violations in some ports.  Given the approach 
>> outlined above I suspect they may need to be addressed before we can start 
>> making progress on b).
>
> Yes.  Fixing these issues is going to be a fair amount of work.
> Perhaps it would make sense to create a stub Platform project for now,
> which will let us move code from WebCore/platform into Platform as we
> clean up the dependencies.
>
> Adam
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Adam Barth]

On Fri, Nov 4, 2011 at 11:12 AM, Kevin Ollivier  wrote:
> So I'm assuming that dynamic library would be JSCore, then? Is the idea
> basically just to have a clean separation between WTF and JSCore build
> projects?

Yes.  Conceptually, WTF is a separate layer from JavaScriptCore.

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Kevin Ollivier]

Hi Mark,

On Nov 4, 2011, at 10:59 AM, Mark Rowe wrote:

> 
> On 2011-11-04, at 10:57, Kevin Ollivier wrote:
> 
>> Hi Steve,
>> 
>> On Nov 4, 2011, at 9:12 AM, Steve Falkenburg wrote:
>> 
>>> 
>>> On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:
>>> 
> Step (2) here involves coming up with a good solution for export control 
> in both the WTF and platform cases. Today we use an explicit .exp file 
> for JavaScriptCore and WebCore on Mac and I believe a .def file in the 
> Apple Windows WebKit port. So there might be a necessary first step of 
> moving to a different export approach. And I know someone has been 
> working on that.
 
 If you guys want to go the route of finishing up the export macros work, 
 let me know and I'll see what I can do. I probably can't devote a lot of 
 time to it for the next week or two, but I'd like to see this fixed 
 regardless of if it's used to move forward the WTF split, obviously, so I 
 can put a higher priority on it if I know there are reviewers waiting to 
 land things. :) 
 
 FWIW, I did distinguish between JS and WTF symbol export macros in the 
 work I've been doing, so the macros approach will support the split as-is.
>>> 
>>> If WTF is to be a static library, there's no need to change anything in the 
>>> .def file on Windows.
>>> .def files apply only to DLLs.
>> 
>> Yes, I know, just saying I'd be willing to help if they wanted to go the DLL 
>> route. Making it static would make life easier for me also by allowing us to 
>> remove the need for WTF symbol exports entirely, of course, so either way is 
>> a plus for me.
> 
> WTF being a static library doesn't change anything with respect to exports.  
> It will still only be linked by a single dynamic library, and that library 
> will be expected to export the necessary symbols for other clients. Doing 
> otherwise would cause problems due to multiple instances of WTF's data being 
> created (e.g., separate FastMalloc heaps for each library that linked 
> directly to WTF).

So I'm assuming that dynamic library would be JSCore, then? Is the idea 
basically just to have a clean separation between WTF and JSCore build projects?

Thanks,

Kevin

> - Mark
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Mark Rowe]

On 2011-11-04, at 10:57, Kevin Ollivier wrote:

> Hi Steve,
> 
> On Nov 4, 2011, at 9:12 AM, Steve Falkenburg wrote:
> 
>> 
>> On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:
>> 
 Step (2) here involves coming up with a good solution for export control 
 in both the WTF and platform cases. Today we use an explicit .exp file for 
 JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
 Windows WebKit port. So there might be a necessary first step of moving to 
 a different export approach. And I know someone has been working on that.
>>> 
>>> If you guys want to go the route of finishing up the export macros work, 
>>> let me know and I'll see what I can do. I probably can't devote a lot of 
>>> time to it for the next week or two, but I'd like to see this fixed 
>>> regardless of if it's used to move forward the WTF split, obviously, so I 
>>> can put a higher priority on it if I know there are reviewers waiting to 
>>> land things. :) 
>>> 
>>> FWIW, I did distinguish between JS and WTF symbol export macros in the work 
>>> I've been doing, so the macros approach will support the split as-is.
>> 
>> If WTF is to be a static library, there's no need to change anything in the 
>> .def file on Windows.
>> .def files apply only to DLLs.
> 
> Yes, I know, just saying I'd be willing to help if they wanted to go the DLL 
> route. Making it static would make life easier for me also by allowing us to 
> remove the need for WTF symbol exports entirely, of course, so either way is 
> a plus for me.

WTF being a static library doesn't change anything with respect to exports.  It 
will still only be linked by a single dynamic library, and that library will be 
expected to export the necessary symbols for other clients. Doing otherwise 
would cause problems due to multiple instances of WTF's data being created 
(e.g., separate FastMalloc heaps for each library that linked directly to WTF).

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Kevin Ollivier]

Hi Steve,

On Nov 4, 2011, at 9:12 AM, Steve Falkenburg wrote:

> 
> On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:
> 
>>> Step (2) here involves coming up with a good solution for export control in 
>>> both the WTF and platform cases. Today we use an explicit .exp file for 
>>> JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
>>> Windows WebKit port. So there might be a necessary first step of moving to 
>>> a different export approach. And I know someone has been working on that.
>> 
>> If you guys want to go the route of finishing up the export macros work, let 
>> me know and I'll see what I can do. I probably can't devote a lot of time to 
>> it for the next week or two, but I'd like to see this fixed regardless of if 
>> it's used to move forward the WTF split, obviously, so I can put a higher 
>> priority on it if I know there are reviewers waiting to land things. :) 
>> 
>> FWIW, I did distinguish between JS and WTF symbol export macros in the work 
>> I've been doing, so the macros approach will support the split as-is.
> 
> If WTF is to be a static library, there's no need to change anything in the 
> .def file on Windows.
> .def files apply only to DLLs.

Yes, I know, just saying I'd be willing to help if they wanted to go the DLL 
route. Making it static would make life easier for me also by allowing us to 
remove the need for WTF symbol exports entirely, of course, so either way is a 
plus for me.

Thanks,

Kevin

> FWIW, WTF is already a static library in Apple's Windows port, just 
> self-contained inside the JavaScriptCore project. See: 
> http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj
> 
> -steve
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Steve Falkenburg]

On Nov 4, 2011, at 8:48 AM, Kevin Ollivier wrote:

>> Step (2) here involves coming up with a good solution for export control in 
>> both the WTF and platform cases. Today we use an explicit .exp file for 
>> JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
>> Windows WebKit port. So there might be a necessary first step of moving to a 
>> different export approach. And I know someone has been working on that.
> 
> If you guys want to go the route of finishing up the export macros work, let 
> me know and I'll see what I can do. I probably can't devote a lot of time to 
> it for the next week or two, but I'd like to see this fixed regardless of if 
> it's used to move forward the WTF split, obviously, so I can put a higher 
> priority on it if I know there are reviewers waiting to land things. :) 
> 
> FWIW, I did distinguish between JS and WTF symbol export macros in the work 
> I've been doing, so the macros approach will support the split as-is.

If WTF is to be a static library, there's no need to change anything in the 
.def file on Windows.
.def files apply only to DLLs.

FWIW, WTF is already a static library in Apple's Windows port, just 
self-contained inside the JavaScriptCore project. See: 
http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj

-steve

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Kevin Ollivier]

Hi Darin,

On Nov 2, 2011, at 4:42 PM, Darin Adler wrote:

> On Nov 2, 2011, at 4:09 PM, Mark Rowe wrote:
> 
>> There are a few related goals here that I'm aware of:
>> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
>> there, but was simply a convenient home for it.
>> b) Separate WebCore/platform out of WebCore to help avoid layering 
>> violations.
>> c) Rework the Mac build process so that we can eliminate forwarding headers 
>> and remove the duplication of .xcconfig files.
>> 
>> The process for addressing a) and b) will be similar:
>> 1) Move the relevant code from its current location to the new location.
>> 2) Create a new Xcode project that builds the desired output in the 
>> appropriate fashion. Update other build systems as is applicable.
>> 3) Apple starts including the new project in our build process.
> 
> Step (2) here involves coming up with a good solution for export control in 
> both the WTF and platform cases. Today we use an explicit .exp file for 
> JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
> Windows WebKit port. So there might be a necessary first step of moving to a 
> different export approach. And I know someone has been working on that.

If you guys want to go the route of finishing up the export macros work, let me 
know and I'll see what I can do. I probably can't devote a lot of time to it 
for the next week or two, but I'd like to see this fixed regardless of if it's 
used to move forward the WTF split, obviously, so I can put a higher priority 
on it if I know there are reviewers waiting to land things. :) 

FWIW, I did distinguish between JS and WTF symbol export macros in the work 
I've been doing, so the macros approach will support the split as-is.

Thanks,

Kevin

> -- Darin
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Adam Barth]

On Wed, Nov 2, 2011 at 4:35 PM, Mark Rowe  wrote:
> On 2011-11-02, at 16:32, Adam Barth wrote:
>> On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe  wrote:
>>> On 2011-11-02, at 13:23, Adam Barth wrote:
 As discussed previously, I think it would benefit the project to move
 WTF out of JavaScriptCore:

 https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
 https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html

 Previously, we've been unable to do this because of Apple's internal
 build process.  In thinking about this problem again recently, I
 wonder if the following would work:

 1) Move JavaScriptCore.xcodeproj from
 Source/JavaScriptCore/JavaScriptCore.xcodeproj to
 Source/JavaScriptCore.xcodeproj.
 2) Change how Apple submits JavaScriptCore to the internal build
 process to submit Source as the code for "JavaScriptCore" instead of
 Source/JavaScriptCore.
 3) Move Source/JavaScriptCore/WTF to Source/WTF.

 Mark, do you have a sense for whether this plan is feasible?  If not,
 is there another approach that would work better?

 (If my understanding is correct, we could also apply this approach to
 the other xcodeproj files, which would let us get rid of
 ForwardingHeaders and move Source/WebCore/platform to
 Source/Platform.)
>>>
>>> There are a few related goals here that I'm aware of:
>>> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
>>> there, but was simply a convenient home for it.
>>> b) Separate WebCore/platform out of WebCore to help avoid layering 
>>> violations.
>>> c) Rework the Mac build process so that we can eliminate forwarding headers 
>>> and remove the duplication of .xcconfig files.
>>
>> Yes.  These are the goals.
>>
>>> The process for addressing a) and b) will be similar:
>>> 1) Move the relevant code from its current location to the new location.
>>> 2) Create a new Xcode project that builds the desired output in the 
>>> appropriate fashion. Update other build systems as is applicable.
>>> 3) Apple starts including the new project in our build process.
>>>
>>> I don't see any benefit or need to move existing Xcode projects as part of 
>>> this process.  Can you expand on why you included this in your proposal?
>>
>> Based on our previous discussions, I was unsure how difficult (3) was
>> on your end.  If we can make (a) and (b) happen in the near term
>> without moving xcodeproj files around, that would make me a happy
>> camper.
>
> The code moving and the new Xcode project is relatively easy. I'm not sure 
> what will be involved in updating all of the other build systems though.

I'm happy to coordinate that part of the effort.

>>> I'm not entirely clear on what we'll need to do to tackle c). My current 
>>> feeling is that it will mainly involve reshuffling of Apple's build 
>>> processes rather than any significant changes to WebKit.
>>
>> Maybe we should aim to do (a) first, then (b), and then work on (c)
>> once we've figured out what needs to happen on Apple's end?
>
> My recollection of the situation with WebCore/platform is that there are a 
> number of existing layering violations in some ports.  Given the approach 
> outlined above I suspect they may need to be addressed before we can start 
> making progress on b).

Yes.  Fixing these issues is going to be a fair amount of work.
Perhaps it would make sense to create a stub Platform project for now,
which will let us move code from WebCore/platform into Platform as we
clean up the dependencies.

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Mark Rowe]

On 2011-11-02, at 16:42, Darin Adler wrote:

> On Nov 2, 2011, at 4:09 PM, Mark Rowe wrote:
> 
>> There are a few related goals here that I'm aware of:
>> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
>> there, but was simply a convenient home for it.
>> b) Separate WebCore/platform out of WebCore to help avoid layering 
>> violations.
>> c) Rework the Mac build process so that we can eliminate forwarding headers 
>> and remove the duplication of .xcconfig files.
>> 
>> The process for addressing a) and b) will be similar:
>> 1) Move the relevant code from its current location to the new location.
>> 2) Create a new Xcode project that builds the desired output in the 
>> appropriate fashion. Update other build systems as is applicable.
>> 3) Apple starts including the new project in our build process.
> 
> Step (2) here involves coming up with a good solution for export control in 
> both the WTF and platform cases. Today we use an explicit .exp file for 
> JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
> Windows WebKit port. So there might be a necessary first step of moving to a 
> different export approach. And I know someone has been working on that.

My current line of thinking was that WTF would build as a static library. 
JavaScriptCore's existing mechanism for exporting symbols should be sufficient 
to ensure that the necessary WTF symbols are still exposed.

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Darin Adler]

On Nov 2, 2011, at 4:42 PM, Darin Adler wrote:

> Step (2) here involves coming up with a good solution for export control in 
> both the WTF and platform cases. Today we use an explicit .exp file for 
> JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
> Windows WebKit port. So there might be a necessary first step of moving to a 
> different export approach. And I know someone has been working on that.

Or maybe these will be statically linked libraries?

-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Darin Adler]

On Nov 2, 2011, at 4:09 PM, Mark Rowe wrote:

> There are a few related goals here that I'm aware of:
> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
> there, but was simply a convenient home for it.
> b) Separate WebCore/platform out of WebCore to help avoid layering violations.
> c) Rework the Mac build process so that we can eliminate forwarding headers 
> and remove the duplication of .xcconfig files.
> 
> The process for addressing a) and b) will be similar:
> 1) Move the relevant code from its current location to the new location.
> 2) Create a new Xcode project that builds the desired output in the 
> appropriate fashion. Update other build systems as is applicable.
> 3) Apple starts including the new project in our build process.

Step (2) here involves coming up with a good solution for export control in 
both the WTF and platform cases. Today we use an explicit .exp file for 
JavaScriptCore and WebCore on Mac and I believe a .def file in the Apple 
Windows WebKit port. So there might be a necessary first step of moving to a 
different export approach. And I know someone has been working on that.

-- Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Mark Rowe]

On 2011-11-02, at 16:32, Adam Barth wrote:

> On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe  wrote:
>> On 2011-11-02, at 13:23, Adam Barth wrote:
>>> As discussed previously, I think it would benefit the project to move
>>> WTF out of JavaScriptCore:
>>> 
>>> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
>>> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
>>> 
>>> Previously, we've been unable to do this because of Apple's internal
>>> build process.  In thinking about this problem again recently, I
>>> wonder if the following would work:
>>> 
>>> 1) Move JavaScriptCore.xcodeproj from
>>> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
>>> Source/JavaScriptCore.xcodeproj.
>>> 2) Change how Apple submits JavaScriptCore to the internal build
>>> process to submit Source as the code for "JavaScriptCore" instead of
>>> Source/JavaScriptCore.
>>> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
>>> 
>>> Mark, do you have a sense for whether this plan is feasible?  If not,
>>> is there another approach that would work better?
>>> 
>>> (If my understanding is correct, we could also apply this approach to
>>> the other xcodeproj files, which would let us get rid of
>>> ForwardingHeaders and move Source/WebCore/platform to
>>> Source/Platform.)
>> 
>> There are a few related goals here that I'm aware of:
>> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
>> there, but was simply a convenient home for it.
>> b) Separate WebCore/platform out of WebCore to help avoid layering 
>> violations.
>> c) Rework the Mac build process so that we can eliminate forwarding headers 
>> and remove the duplication of .xcconfig files.
> 
> Yes.  These are the goals.
> 
>> The process for addressing a) and b) will be similar:
>> 1) Move the relevant code from its current location to the new location.
>> 2) Create a new Xcode project that builds the desired output in the 
>> appropriate fashion. Update other build systems as is applicable.
>> 3) Apple starts including the new project in our build process.
>> 
>> I don't see any benefit or need to move existing Xcode projects as part of 
>> this process.  Can you expand on why you included this in your proposal?
> 
> Based on our previous discussions, I was unsure how difficult (3) was
> on your end.  If we can make (a) and (b) happen in the near term
> without moving xcodeproj files around, that would make me a happy
> camper.

The code moving and the new Xcode project is relatively easy. I'm not sure what 
will be involved in updating all of the other build systems though.

>> I'm not entirely clear on what we'll need to do to tackle c). My current 
>> feeling is that it will mainly involve reshuffling of Apple's build 
>> processes rather than any significant changes to WebKit.
> 
> Maybe we should aim to do (a) first, then (b), and then work on (c)
> once we've figured out what needs to happen on Apple's end?

My recollection of the situation with WebCore/platform is that there are a 
number of existing layering violations in some ports.  Given the approach 
outlined above I suspect they may need to be addressed before we can start 
making progress on b).

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Adam Barth]

On Wed, Nov 2, 2011 at 4:09 PM, Mark Rowe  wrote:
> On 2011-11-02, at 13:23, Adam Barth wrote:
>> As discussed previously, I think it would benefit the project to move
>> WTF out of JavaScriptCore:
>>
>> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
>> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
>>
>> Previously, we've been unable to do this because of Apple's internal
>> build process.  In thinking about this problem again recently, I
>> wonder if the following would work:
>>
>> 1) Move JavaScriptCore.xcodeproj from
>> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
>> Source/JavaScriptCore.xcodeproj.
>> 2) Change how Apple submits JavaScriptCore to the internal build
>> process to submit Source as the code for "JavaScriptCore" instead of
>> Source/JavaScriptCore.
>> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
>>
>> Mark, do you have a sense for whether this plan is feasible?  If not,
>> is there another approach that would work better?
>>
>> (If my understanding is correct, we could also apply this approach to
>> the other xcodeproj files, which would let us get rid of
>> ForwardingHeaders and move Source/WebCore/platform to
>> Source/Platform.)
>
> There are a few related goals here that I'm aware of:
> a) Separate WTF out of JavaScriptCore since it doesn't logically belong 
> there, but was simply a convenient home for it.
> b) Separate WebCore/platform out of WebCore to help avoid layering violations.
> c) Rework the Mac build process so that we can eliminate forwarding headers 
> and remove the duplication of .xcconfig files.

Yes.  These are the goals.

> The process for addressing a) and b) will be similar:
> 1) Move the relevant code from its current location to the new location.
> 2) Create a new Xcode project that builds the desired output in the 
> appropriate fashion. Update other build systems as is applicable.
> 3) Apple starts including the new project in our build process.
>
> I don't see any benefit or need to move existing Xcode projects as part of 
> this process.  Can you expand on why you included this in your proposal?

Based on our previous discussions, I was unsure how difficult (3) was
on your end.  If we can make (a) and (b) happen in the near term
without moving xcodeproj files around, that would make me a happy
camper.

> I'm not entirely clear on what we'll need to do to tackle c). My current 
> feeling is that it will mainly involve reshuffling of Apple's build processes 
> rather than any significant changes to WebKit.

Maybe we should aim to do (a) first, then (b), and then work on (c)
once we've figured out what needs to happen on Apple's end?

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Mark Rowe]

On 2011-11-02, at 13:23, Adam Barth wrote:

> As discussed previously, I think it would benefit the project to move
> WTF out of JavaScriptCore:
> 
> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
> 
> Previously, we've been unable to do this because of Apple's internal
> build process.  In thinking about this problem again recently, I
> wonder if the following would work:
> 
> 1) Move JavaScriptCore.xcodeproj from
> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
> Source/JavaScriptCore.xcodeproj.
> 2) Change how Apple submits JavaScriptCore to the internal build
> process to submit Source as the code for "JavaScriptCore" instead of
> Source/JavaScriptCore.
> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
> 
> Mark, do you have a sense for whether this plan is feasible?  If not,
> is there another approach that would work better?
> 
> (If my understanding is correct, we could also apply this approach to
> the other xcodeproj files, which would let us get rid of
> ForwardingHeaders and move Source/WebCore/platform to
> Source/Platform.)

There are a few related goals here that I'm aware of:
a) Separate WTF out of JavaScriptCore since it doesn't logically belong there, 
but was simply a convenient home for it.
b) Separate WebCore/platform out of WebCore to help avoid layering violations.
c) Rework the Mac build process so that we can eliminate forwarding headers and 
remove the duplication of .xcconfig files.

The process for addressing a) and b) will be similar:
1) Move the relevant code from its current location to the new location.
2) Create a new Xcode project that builds the desired output in the appropriate 
fashion. Update other build systems as is applicable.
3) Apple starts including the new project in our build process.

I don't see any benefit or need to move existing Xcode projects as part of this 
process.  Can you expand on why you included this in your proposal?

I'm not entirely clear on what we'll need to do to tackle c). My current 
feeling is that it will mainly involve reshuffling of Apple's build processes 
rather than any significant changes to WebKit.

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Jarred Nicholls]

On Wed, Nov 2, 2011 at 4:23 PM, Adam Barth  wrote:

> As discussed previously, I think it would benefit the project to move
> WTF out of JavaScriptCore:
>
> https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
> https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html
>
> Previously, we've been unable to do this because of Apple's internal
> build process.  In thinking about this problem again recently, I
> wonder if the following would work:
>
> 1) Move JavaScriptCore.xcodeproj from
> Source/JavaScriptCore/JavaScriptCore.xcodeproj to
> Source/JavaScriptCore.xcodeproj.
> 2) Change how Apple submits JavaScriptCore to the internal build
> process to submit Source as the code for "JavaScriptCore" instead of
> Source/JavaScriptCore.
> 3) Move Source/JavaScriptCore/WTF to Source/WTF.
>
> Mark, do you have a sense for whether this plan is feasible?  If not,
> is there another approach that would work better?
>
> (If my understanding is correct, we could also apply this approach to
> the other xcodeproj files, which would let us get rid of
> ForwardingHeaders and move Source/WebCore/platform to
> Source/Platform.)
>

That'd be most excellent.  ChangeLog would be cleanly split out as a nice
side effect to doing this, as well as w/ WTF vs. JavaScriptCore.


>
> Thanks,
> Adam
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>



-- 


*Sencha*
Jarred Nicholls, Senior Software Architect
@jarrednicholls

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Moving WTF out of JavaScriptCore (revisited)

[Adam Barth]

As discussed previously, I think it would benefit the project to move
WTF out of JavaScriptCore:

https://lists.webkit.org/pipermail/webkit-dev/2010-December/015427.html
https://lists.webkit.org/pipermail/webkit-dev/2011-February/015940.html

Previously, we've been unable to do this because of Apple's internal
build process.  In thinking about this problem again recently, I
wonder if the following would work:

1) Move JavaScriptCore.xcodeproj from
Source/JavaScriptCore/JavaScriptCore.xcodeproj to
Source/JavaScriptCore.xcodeproj.
2) Change how Apple submits JavaScriptCore to the internal build
process to submit Source as the code for "JavaScriptCore" instead of
Source/JavaScriptCore.
3) Move Source/JavaScriptCore/WTF to Source/WTF.

Mark, do you have a sense for whether this plan is feasible?  If not,
is there another approach that would work better?

(If my understanding is correct, we could also apply this approach to
the other xcodeproj files, which would let us get rid of
ForwardingHeaders and move Source/WebCore/platform to
Source/Platform.)

Thanks,
Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Kevin Ollivier]

On Feb 9, 2011, at 4:28 PM, Mark Rowe wrote:

> 
> On 2011-02-09, at 16:21, Kevin Ollivier wrote:
> 
>> 
>> On Feb 9, 2011, at 3:11 PM, Mark Rowe wrote:
>> 
>>> 
>>> On 2011-02-09, at 14:51, Kevin Ollivier wrote:
>>> 
 On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
 
> 
> On 2011-02-09, at 14:05, Adam Barth wrote:
> 
>> On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
>>> On 2011-02-09, at 13:06, Adam Barth wrote:
 On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  
 wrote:
> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>>> On 2010-12-22, at 10:34, Adam Barth wrote:
 As an aside, would creating the Sources directory make it easier to
 move WTF out of JavaScriptCore?
>>> 
>>> I don't think that the location of the source on disk is a big 
>>> factor in
>>> WTF's presence in JavaScriptCore.
>> 
>> Oh, I thought the main involved in creating a new top-level source
>> directory was the main thing causing WTF to live inside
>> JavaScriptCore.  I know we've talked about moving it out of
>> JavaScriptCore for a while now.  Is that just a matter of someone
>> (e.g., me) doing the work or are there other limiting factors?
> 
> If we switch to a top-level Sources directory, and on the 
> Apple-internal side switch to submitting WebKit to the OS build using 
> this single top-level sources directory, then it's easy to make new 
> top-level directories without disrupting anything.
> 
> If we don't do the above, we'd have to set things up so we can submit 
> WTF separately to the build to cope, and we'd need to make it build a 
> static library and install private headers.
> 
> So I think it is easier to make this change if we do the Sources/ 
> change first.
 
 Now that we've moved all the source code into Source, I'd like to try
 moving WTF out of JavaScriptCore.  Is there anything on the
 Apple-internal side that needs to happen first?
>>> 
>>> Maciej's response above mentions that we need to make some internal 
>>> process changes before it's easy to add new top-level projects without 
>>> disrupting things.  Unless there's some urgent reason to move WTF I'd 
>>> prefer that you hold off on doing this.
>> 
>> Would it make sense to set a target date in the future for making
>> these internal changes?  I'm certainly not in a rush, but I'd also
>> like to make progress on this at some point.
> 
> I don't think that would be useful.  The changes that block this are the 
> same changes that prevent us from removing the concept of forwarding 
> headers. We're as interested as you are in seeing them done.
 
 I'm also very interested in seeing this done, as it affects the wx port 
 too, and I know from trying to make header changes to WTF (and watching 
 all the breakages) that almost all ports have hacks along the lines of 
 forwarding headers that deal with the issue of WTF being a separate 
 project in theory, but a private implementation detail of JSC in practice. 
 Pulling WTF out of JSC would, I think, go a long way to undoing a lot of 
 those hacks and reducing the time and maintenance cost of making changes 
 to WTF.
>>> 
>>> As far as I'm aware only the Mac and Windows ports have anything along the 
>>> lines of forwarding headers.  No other port that I'm aware of needs 
>>> anything similar.
>>> 
 Is the problem here that these internal changes are very difficult and/or 
 time consuming to implement? I wish I could help somehow because I'd much 
 rather spend time trying to fix this problem the right way and for good 
 than spending that time sorting out all the build breakages every time I 
 try to do something like add a new header to WTF that I want to be widely 
 available among ports and projects in WebKit. 
>>> 
>>> If you can point me at changes where you've had issues with forwarding 
>>> headers I can provide suggestions as to how you can avoid problems with 
>>> them in the future.  A quick look through SVN history doesn't reveal any 
>>> changes related to forwarding headers from you.
>> 
>> Actually, I'm referring to what is still an open bug. 
>> (https://bugs.webkit.org/show_bug.cgi?id=27551) The issue in question is a 
>> change to try and move the definition of JSC / WTF export symbols into the 
>> headers rather than using the current export definition files. Resolving 
>> this issue is a pre-requisite for wx DRT support, and also blocks a bug 
>> related to defining export macros for C++ DOM bindings as well.
>> 
>> Part of what fixing this bug entailed was adding a new header to WTF, I 
>> called it wtf/ExportMacros.h, which define

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2011-02-09, at 16:21, Kevin Ollivier wrote:

> 
> On Feb 9, 2011, at 3:11 PM, Mark Rowe wrote:
> 
>> 
>> On 2011-02-09, at 14:51, Kevin Ollivier wrote:
>> 
>>> On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
>>> 
 
 On 2011-02-09, at 14:05, Adam Barth wrote:
 
> On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
>> On 2011-02-09, at 13:06, Adam Barth wrote:
>>> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  
>>> wrote:
 On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>> On 2010-12-22, at 10:34, Adam Barth wrote:
>>> As an aside, would creating the Sources directory make it easier to
>>> move WTF out of JavaScriptCore?
>> 
>> I don't think that the location of the source on disk is a big 
>> factor in
>> WTF's presence in JavaScriptCore.
> 
> Oh, I thought the main involved in creating a new top-level source
> directory was the main thing causing WTF to live inside
> JavaScriptCore.  I know we've talked about moving it out of
> JavaScriptCore for a while now.  Is that just a matter of someone
> (e.g., me) doing the work or are there other limiting factors?
 
 If we switch to a top-level Sources directory, and on the 
 Apple-internal side switch to submitting WebKit to the OS build using 
 this single top-level sources directory, then it's easy to make new 
 top-level directories without disrupting anything.
 
 If we don't do the above, we'd have to set things up so we can submit 
 WTF separately to the build to cope, and we'd need to make it build a 
 static library and install private headers.
 
 So I think it is easier to make this change if we do the Sources/ 
 change first.
>>> 
>>> Now that we've moved all the source code into Source, I'd like to try
>>> moving WTF out of JavaScriptCore.  Is there anything on the
>>> Apple-internal side that needs to happen first?
>> 
>> Maciej's response above mentions that we need to make some internal 
>> process changes before it's easy to add new top-level projects without 
>> disrupting things.  Unless there's some urgent reason to move WTF I'd 
>> prefer that you hold off on doing this.
> 
> Would it make sense to set a target date in the future for making
> these internal changes?  I'm certainly not in a rush, but I'd also
> like to make progress on this at some point.
 
 I don't think that would be useful.  The changes that block this are the 
 same changes that prevent us from removing the concept of forwarding 
 headers. We're as interested as you are in seeing them done.
>>> 
>>> I'm also very interested in seeing this done, as it affects the wx port 
>>> too, and I know from trying to make header changes to WTF (and watching all 
>>> the breakages) that almost all ports have hacks along the lines of 
>>> forwarding headers that deal with the issue of WTF being a separate project 
>>> in theory, but a private implementation detail of JSC in practice. Pulling 
>>> WTF out of JSC would, I think, go a long way to undoing a lot of those 
>>> hacks and reducing the time and maintenance cost of making changes to WTF.
>> 
>> As far as I'm aware only the Mac and Windows ports have anything along the 
>> lines of forwarding headers.  No other port that I'm aware of needs anything 
>> similar.
>> 
>>> Is the problem here that these internal changes are very difficult and/or 
>>> time consuming to implement? I wish I could help somehow because I'd much 
>>> rather spend time trying to fix this problem the right way and for good 
>>> than spending that time sorting out all the build breakages every time I 
>>> try to do something like add a new header to WTF that I want to be widely 
>>> available among ports and projects in WebKit. 
>> 
>> If you can point me at changes where you've had issues with forwarding 
>> headers I can provide suggestions as to how you can avoid problems with them 
>> in the future.  A quick look through SVN history doesn't reveal any changes 
>> related to forwarding headers from you.
> 
> Actually, I'm referring to what is still an open bug. 
> (https://bugs.webkit.org/show_bug.cgi?id=27551) The issue in question is a 
> change to try and move the definition of JSC / WTF export symbols into the 
> headers rather than using the current export definition files. Resolving this 
> issue is a pre-requisite for wx DRT support, and also blocks a bug related to 
> defining export macros for C++ DOM bindings as well.
> 
> Part of what fixing this bug entailed was adding a new header to WTF, I 
> called it wtf/ExportMacros.h, which defined WTF_EXPORT and WTF_IMPORT so we 
> could consolidate the export symbol attribute definition macros into one 
> place in the tree, instead of copying a

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Kevin Ollivier]

On Feb 9, 2011, at 3:11 PM, Mark Rowe wrote:

> 
> On 2011-02-09, at 14:51, Kevin Ollivier wrote:
> 
>> On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
>> 
>>> 
>>> On 2011-02-09, at 14:05, Adam Barth wrote:
>>> 
 On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
> On 2011-02-09, at 13:06, Adam Barth wrote:
>> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  
>> wrote:
>>> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
 On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
> On 2010-12-22, at 10:34, Adam Barth wrote:
>> As an aside, would creating the Sources directory make it easier to
>> move WTF out of JavaScriptCore?
> 
> I don't think that the location of the source on disk is a big factor 
> in
> WTF's presence in JavaScriptCore.
 
 Oh, I thought the main involved in creating a new top-level source
 directory was the main thing causing WTF to live inside
 JavaScriptCore.  I know we've talked about moving it out of
 JavaScriptCore for a while now.  Is that just a matter of someone
 (e.g., me) doing the work or are there other limiting factors?
>>> 
>>> If we switch to a top-level Sources directory, and on the 
>>> Apple-internal side switch to submitting WebKit to the OS build using 
>>> this single top-level sources directory, then it's easy to make new 
>>> top-level directories without disrupting anything.
>>> 
>>> If we don't do the above, we'd have to set things up so we can submit 
>>> WTF separately to the build to cope, and we'd need to make it build a 
>>> static library and install private headers.
>>> 
>>> So I think it is easier to make this change if we do the Sources/ 
>>> change first.
>> 
>> Now that we've moved all the source code into Source, I'd like to try
>> moving WTF out of JavaScriptCore.  Is there anything on the
>> Apple-internal side that needs to happen first?
> 
> Maciej's response above mentions that we need to make some internal 
> process changes before it's easy to add new top-level projects without 
> disrupting things.  Unless there's some urgent reason to move WTF I'd 
> prefer that you hold off on doing this.
 
 Would it make sense to set a target date in the future for making
 these internal changes?  I'm certainly not in a rush, but I'd also
 like to make progress on this at some point.
>>> 
>>> I don't think that would be useful.  The changes that block this are the 
>>> same changes that prevent us from removing the concept of forwarding 
>>> headers. We're as interested as you are in seeing them done.
>> 
>> I'm also very interested in seeing this done, as it affects the wx port too, 
>> and I know from trying to make header changes to WTF (and watching all the 
>> breakages) that almost all ports have hacks along the lines of forwarding 
>> headers that deal with the issue of WTF being a separate project in theory, 
>> but a private implementation detail of JSC in practice. Pulling WTF out of 
>> JSC would, I think, go a long way to undoing a lot of those hacks and 
>> reducing the time and maintenance cost of making changes to WTF.
> 
> As far as I'm aware only the Mac and Windows ports have anything along the 
> lines of forwarding headers.  No other port that I'm aware of needs anything 
> similar.
> 
>> Is the problem here that these internal changes are very difficult and/or 
>> time consuming to implement? I wish I could help somehow because I'd much 
>> rather spend time trying to fix this problem the right way and for good than 
>> spending that time sorting out all the build breakages every time I try to 
>> do something like add a new header to WTF that I want to be widely available 
>> among ports and projects in WebKit. 
> 
> If you can point me at changes where you've had issues with forwarding 
> headers I can provide suggestions as to how you can avoid problems with them 
> in the future.  A quick look through SVN history doesn't reveal any changes 
> related to forwarding headers from you.

Actually, I'm referring to what is still an open bug. 
(https://bugs.webkit.org/show_bug.cgi?id=27551) The issue in question is a 
change to try and move the definition of JSC / WTF export symbols into the 
headers rather than using the current export definition files. Resolving this 
issue is a pre-requisite for wx DRT support, and also blocks a bug related to 
defining export macros for C++ DOM bindings as well.

Part of what fixing this bug entailed was adding a new header to WTF, I called 
it wtf/ExportMacros.h, which defined WTF_EXPORT and WTF_IMPORT so we could 
consolidate the export symbol attribute definition macros into one place in the 
tree, instead of copying and pasting the same logic (just with different 
XYZ_EXPORT and IMPORT names) into every config.h file. However, when I tried 
adding the WTF header, almost eve

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2011-02-09, at 14:51, Kevin Ollivier wrote:

> On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:
> 
>> 
>> On 2011-02-09, at 14:05, Adam Barth wrote:
>> 
>>> On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
 On 2011-02-09, at 13:06, Adam Barth wrote:
> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  wrote:
>> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
>>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
 On 2010-12-22, at 10:34, Adam Barth wrote:
> As an aside, would creating the Sources directory make it easier to
> move WTF out of JavaScriptCore?
 
 I don't think that the location of the source on disk is a big factor 
 in
 WTF's presence in JavaScriptCore.
>>> 
>>> Oh, I thought the main involved in creating a new top-level source
>>> directory was the main thing causing WTF to live inside
>>> JavaScriptCore.  I know we've talked about moving it out of
>>> JavaScriptCore for a while now.  Is that just a matter of someone
>>> (e.g., me) doing the work or are there other limiting factors?
>> 
>> If we switch to a top-level Sources directory, and on the Apple-internal 
>> side switch to submitting WebKit to the OS build using this single 
>> top-level sources directory, then it's easy to make new top-level 
>> directories without disrupting anything.
>> 
>> If we don't do the above, we'd have to set things up so we can submit 
>> WTF separately to the build to cope, and we'd need to make it build a 
>> static library and install private headers.
>> 
>> So I think it is easier to make this change if we do the Sources/ change 
>> first.
> 
> Now that we've moved all the source code into Source, I'd like to try
> moving WTF out of JavaScriptCore.  Is there anything on the
> Apple-internal side that needs to happen first?
 
 Maciej's response above mentions that we need to make some internal 
 process changes before it's easy to add new top-level projects without 
 disrupting things.  Unless there's some urgent reason to move WTF I'd 
 prefer that you hold off on doing this.
>>> 
>>> Would it make sense to set a target date in the future for making
>>> these internal changes?  I'm certainly not in a rush, but I'd also
>>> like to make progress on this at some point.
>> 
>> I don't think that would be useful.  The changes that block this are the 
>> same changes that prevent us from removing the concept of forwarding 
>> headers. We're as interested as you are in seeing them done.
> 
> I'm also very interested in seeing this done, as it affects the wx port too, 
> and I know from trying to make header changes to WTF (and watching all the 
> breakages) that almost all ports have hacks along the lines of forwarding 
> headers that deal with the issue of WTF being a separate project in theory, 
> but a private implementation detail of JSC in practice. Pulling WTF out of 
> JSC would, I think, go a long way to undoing a lot of those hacks and 
> reducing the time and maintenance cost of making changes to WTF.

As far as I'm aware only the Mac and Windows ports have anything along the 
lines of forwarding headers.  No other port that I'm aware of needs anything 
similar.

> Is the problem here that these internal changes are very difficult and/or 
> time consuming to implement? I wish I could help somehow because I'd much 
> rather spend time trying to fix this problem the right way and for good than 
> spending that time sorting out all the build breakages every time I try to do 
> something like add a new header to WTF that I want to be widely available 
> among ports and projects in WebKit. 

If you can point me at changes where you've had issues with forwarding headers 
I can provide suggestions as to how you can avoid problems with them in the 
future.  A quick look through SVN history doesn't reveal any changes related to 
forwarding headers from you.

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Kevin Ollivier]

On Feb 9, 2011, at 2:08 PM, Mark Rowe wrote:

> 
> On 2011-02-09, at 14:05, Adam Barth wrote:
> 
>> On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
>>> On 2011-02-09, at 13:06, Adam Barth wrote:
 On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  wrote:
> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>>> On 2010-12-22, at 10:34, Adam Barth wrote:
 As an aside, would creating the Sources directory make it easier to
 move WTF out of JavaScriptCore?
>>> 
>>> I don't think that the location of the source on disk is a big factor in
>>> WTF's presence in JavaScriptCore.
>> 
>> Oh, I thought the main involved in creating a new top-level source
>> directory was the main thing causing WTF to live inside
>> JavaScriptCore.  I know we've talked about moving it out of
>> JavaScriptCore for a while now.  Is that just a matter of someone
>> (e.g., me) doing the work or are there other limiting factors?
> 
> If we switch to a top-level Sources directory, and on the Apple-internal 
> side switch to submitting WebKit to the OS build using this single 
> top-level sources directory, then it's easy to make new top-level 
> directories without disrupting anything.
> 
> If we don't do the above, we'd have to set things up so we can submit WTF 
> separately to the build to cope, and we'd need to make it build a static 
> library and install private headers.
> 
> So I think it is easier to make this change if we do the Sources/ change 
> first.
 
 Now that we've moved all the source code into Source, I'd like to try
 moving WTF out of JavaScriptCore.  Is there anything on the
 Apple-internal side that needs to happen first?
>>> 
>>> Maciej's response above mentions that we need to make some internal process 
>>> changes before it's easy to add new top-level projects without disrupting 
>>> things.  Unless there's some urgent reason to move WTF I'd prefer that you 
>>> hold off on doing this.
>> 
>> Would it make sense to set a target date in the future for making
>> these internal changes?  I'm certainly not in a rush, but I'd also
>> like to make progress on this at some point.
> 
> I don't think that would be useful.  The changes that block this are the same 
> changes that prevent us from removing the concept of forwarding headers. 
> We're as interested as you are in seeing them done.

I'm also very interested in seeing this done, as it affects the wx port too, 
and I know from trying to make header changes to WTF (and watching all the 
breakages) that almost all ports have hacks along the lines of forwarding 
headers that deal with the issue of WTF being a separate project in theory, but 
a private implementation detail of JSC in practice. Pulling WTF out of JSC 
would, I think, go a long way to undoing a lot of those hacks and reducing the 
time and maintenance cost of making changes to WTF.

Is the problem here that these internal changes are very difficult and/or time 
consuming to implement? I wish I could help somehow because I'd much rather 
spend time trying to fix this problem the right way and for good than spending 
that time sorting out all the build breakages every time I try to do something 
like add a new header to WTF that I want to be widely available among ports and 
projects in WebKit. 

Kevin

> - Mark
> 
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2011-02-09, at 14:05, Adam Barth wrote:

> On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
>> On 2011-02-09, at 13:06, Adam Barth wrote:
>>> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  wrote:
 On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>> On 2010-12-22, at 10:34, Adam Barth wrote:
>>> As an aside, would creating the Sources directory make it easier to
>>> move WTF out of JavaScriptCore?
>> 
>> I don't think that the location of the source on disk is a big factor in
>> WTF's presence in JavaScriptCore.
> 
> Oh, I thought the main involved in creating a new top-level source
> directory was the main thing causing WTF to live inside
> JavaScriptCore.  I know we've talked about moving it out of
> JavaScriptCore for a while now.  Is that just a matter of someone
> (e.g., me) doing the work or are there other limiting factors?
 
 If we switch to a top-level Sources directory, and on the Apple-internal 
 side switch to submitting WebKit to the OS build using this single 
 top-level sources directory, then it's easy to make new top-level 
 directories without disrupting anything.
 
 If we don't do the above, we'd have to set things up so we can submit WTF 
 separately to the build to cope, and we'd need to make it build a static 
 library and install private headers.
 
 So I think it is easier to make this change if we do the Sources/ change 
 first.
>>> 
>>> Now that we've moved all the source code into Source, I'd like to try
>>> moving WTF out of JavaScriptCore.  Is there anything on the
>>> Apple-internal side that needs to happen first?
>> 
>> Maciej's response above mentions that we need to make some internal process 
>> changes before it's easy to add new top-level projects without disrupting 
>> things.  Unless there's some urgent reason to move WTF I'd prefer that you 
>> hold off on doing this.
> 
> Would it make sense to set a target date in the future for making
> these internal changes?  I'm certainly not in a rush, but I'd also
> like to make progress on this at some point.

I don't think that would be useful.  The changes that block this are the same 
changes that prevent us from removing the concept of forwarding headers. We're 
as interested as you are in seeing them done.

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Adam Barth]

On Wed, Feb 9, 2011 at 1:30 PM, Mark Rowe  wrote:
> On 2011-02-09, at 13:06, Adam Barth wrote:
>> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  wrote:
>>> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
 On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
> On 2010-12-22, at 10:34, Adam Barth wrote:
>> As an aside, would creating the Sources directory make it easier to
>> move WTF out of JavaScriptCore?
>
> I don't think that the location of the source on disk is a big factor in
> WTF's presence in JavaScriptCore.

 Oh, I thought the main involved in creating a new top-level source
 directory was the main thing causing WTF to live inside
 JavaScriptCore.  I know we've talked about moving it out of
 JavaScriptCore for a while now.  Is that just a matter of someone
 (e.g., me) doing the work or are there other limiting factors?
>>>
>>> If we switch to a top-level Sources directory, and on the Apple-internal 
>>> side switch to submitting WebKit to the OS build using this single 
>>> top-level sources directory, then it's easy to make new top-level 
>>> directories without disrupting anything.
>>>
>>> If we don't do the above, we'd have to set things up so we can submit WTF 
>>> separately to the build to cope, and we'd need to make it build a static 
>>> library and install private headers.
>>>
>>> So I think it is easier to make this change if we do the Sources/ change 
>>> first.
>>
>> Now that we've moved all the source code into Source, I'd like to try
>> moving WTF out of JavaScriptCore.  Is there anything on the
>> Apple-internal side that needs to happen first?
>
> Maciej's response above mentions that we need to make some internal process 
> changes before it's easy to add new top-level projects without disrupting 
> things.  Unless there's some urgent reason to move WTF I'd prefer that you 
> hold off on doing this.

Would it make sense to set a target date in the future for making
these internal changes?  I'm certainly not in a rush, but I'd also
like to make progress on this at some point.

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Mark Rowe]

On 2011-02-09, at 13:06, Adam Barth wrote:

> On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  wrote:
>> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
>>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
 On 2010-12-22, at 10:34, Adam Barth wrote:
> As an aside, would creating the Sources directory make it easier to
> move WTF out of JavaScriptCore?
 
 I don't think that the location of the source on disk is a big factor in
 WTF's presence in JavaScriptCore.
>>> 
>>> Oh, I thought the main involved in creating a new top-level source
>>> directory was the main thing causing WTF to live inside
>>> JavaScriptCore.  I know we've talked about moving it out of
>>> JavaScriptCore for a while now.  Is that just a matter of someone
>>> (e.g., me) doing the work or are there other limiting factors?
>> 
>> If we switch to a top-level Sources directory, and on the Apple-internal 
>> side switch to submitting WebKit to the OS build using this single top-level 
>> sources directory, then it's easy to make new top-level directories without 
>> disrupting anything.
>> 
>> If we don't do the above, we'd have to set things up so we can submit WTF 
>> separately to the build to cope, and we'd need to make it build a static 
>> library and install private headers.
>> 
>> So I think it is easier to make this change if we do the Sources/ change 
>> first.
> 
> Now that we've moved all the source code into Source, I'd like to try
> moving WTF out of JavaScriptCore.  Is there anything on the
> Apple-internal side that needs to happen first?

Maciej's response above mentions that we need to make some internal process 
changes before it's easy to add new top-level projects without disrupting 
things.  Unless there's some urgent reason to move WTF I'd prefer that you hold 
off on doing this.

- Mark

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Adam Barth]

On Thu, Dec 23, 2010 at 1:32 PM, Maciej Stachowiak  wrote:
> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>>> On 2010-12-22, at 10:34, Adam Barth wrote:
 As an aside, would creating the Sources directory make it easier to
 move WTF out of JavaScriptCore?
>>>
>>> I don't think that the location of the source on disk is a big factor in
>>> WTF's presence in JavaScriptCore.
>>
>> Oh, I thought the main involved in creating a new top-level source
>> directory was the main thing causing WTF to live inside
>> JavaScriptCore.  I know we've talked about moving it out of
>> JavaScriptCore for a while now.  Is that just a matter of someone
>> (e.g., me) doing the work or are there other limiting factors?
>
> If we switch to a top-level Sources directory, and on the Apple-internal side 
> switch to submitting WebKit to the OS build using this single top-level 
> sources directory, then it's easy to make new top-level directories without 
> disrupting anything.
>
> If we don't do the above, we'd have to set things up so we can submit WTF 
> separately to the build to cope, and we'd need to make it build a static 
> library and install private headers.
>
> So I think it is easier to make this change if we do the Sources/ change 
> first.

Now that we've moved all the source code into Source, I'd like to try
moving WTF out of JavaScriptCore.  Is there anything on the
Apple-internal side that needs to happen first?

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Darin Adler]

On Dec 24, 2010, at 9:51 AM, Eric Seidel wrote:

> I guess all of those could move into Sources/Scripts if Sources becomes the 
> single directory which is submitted to Apple's build team.

I see what you mean. Good point.

I don’t think we really need to outlaw tools required for the building process 
from the Source directory. We’ve historically had the tools required for 
building in with the source code in the WebKit project. It’s the other tools 
used in the development process that were in a separate tools directory.

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

Generation code was what first came to mind.  I know WebKit2 has its
own set of python code which can't reside in webkitpy due to
submission restrictions.  I believe WebCore has its own set of
bindings, make_names, and other CSS generator scripts as well.  I
guess all of those could move into Sources/Scripts if Sources becomes
the single directory which is submitted to Apple's build team.

On Fri, Dec 24, 2010 at 11:40 AM, Darin Adler  wrote:
> On Dec 24, 2010, at 12:37 AM, Eric Seidel wrote:
>
>> There may end up being some fancy foot-work in your submission script to 
>> include parts of Tools.
>
> No, we don’t submit anything in Tools as part of Apple build procedures. What 
> did you have in mind?
>
>    -- Darin
>
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Darin Adler]

On Dec 24, 2010, at 12:37 AM, Eric Seidel wrote:

> There may end up being some fancy foot-work in your submission script to 
> include parts of Tools.

No, we don’t submit anything in Tools as part of Apple build procedures. What 
did you have in mind?

-- Darin

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Eric Seidel]

On Thu, Dec 23, 2010 at 3:32 PM, Maciej Stachowiak  wrote:
>
> On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:
>
>> [Forking the thread]
>>
>> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>>> On 2010-12-22, at 10:34, Adam Barth wrote:
 As an aside, would creating the Sources directory make it easier to
 move WTF out of JavaScriptCore?
>>>
>>> I don't think that the location of the source on disk is a big factor in
>>> WTF's presence in JavaScriptCore.
>>
>> Oh, I thought the main involved in creating a new top-level source
>> directory was the main thing causing WTF to live inside
>> JavaScriptCore.  I know we've talked about moving it out of
>> JavaScriptCore for a while now.  Is that just a matter of someone
>> (e.g., me) doing the work or are there other limiting factors?
>
> If we switch to a top-level Sources directory, and on the Apple-internal side 
> switch to submitting WebKit to the OS build using this single top-level 
> sources directory, then it's easy to make new top-level directories without 
> disrupting anything.

There may end up being some fancy foot-work in your submission script
to include parts of Tools.  I suspect such may already exist, at least
for submitting WebKit2 (which I suspect you're already having to do
for Lion).

> If we don't do the above, we'd have to set things up so we can submit WTF 
> separately to the build to cope, and we'd need to make it build a static 
> library and install private headers.
>
> So I think it is easier to make this change if we do the Sources/ change 
> first.
>
> Regards,
> Maciej
>
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org
> http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
>
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Moving WTF out of JavaScriptCore

[Maciej Stachowiak]

On Dec 22, 2010, at 12:06 PM, Adam Barth wrote:

> [Forking the thread]
> 
> On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
>> On 2010-12-22, at 10:34, Adam Barth wrote:
>>> As an aside, would creating the Sources directory make it easier to
>>> move WTF out of JavaScriptCore?
>> 
>> I don't think that the location of the source on disk is a big factor in
>> WTF's presence in JavaScriptCore.
> 
> Oh, I thought the main involved in creating a new top-level source
> directory was the main thing causing WTF to live inside
> JavaScriptCore.  I know we've talked about moving it out of
> JavaScriptCore for a while now.  Is that just a matter of someone
> (e.g., me) doing the work or are there other limiting factors?

If we switch to a top-level Sources directory, and on the Apple-internal side 
switch to submitting WebKit to the OS build using this single top-level sources 
directory, then it's easy to make new top-level directories without disrupting 
anything.

If we don't do the above, we'd have to set things up so we can submit WTF 
separately to the build to cope, and we'd need to make it build a static 
library and install private headers.

So I think it is easier to make this change if we do the Sources/ change first.

Regards,
Maciej

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Moving WTF out of JavaScriptCore

[Adam Barth]

[Forking the thread]

On Wed, Dec 22, 2010 at 10:40 AM, Mark Rowe  wrote:
> On 2010-12-22, at 10:34, Adam Barth wrote:
>> As an aside, would creating the Sources directory make it easier to
>> move WTF out of JavaScriptCore?
>
> I don't think that the location of the source on disk is a big factor in
> WTF's presence in JavaScriptCore.

Oh, I thought the main involved in creating a new top-level source
directory was the main thing causing WTF to live inside
JavaScriptCore.  I know we've talked about moving it out of
JavaScriptCore for a while now.  Is that just a matter of someone
(e.g., me) doing the work or are there other limiting factors?

Adam
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev