Re: [webkit-dev] No coverage of pixel tests

2013-09-09 Thread Ryosuke Niwa
I'd love to see pixel tests being re-enabled on Mac port.

However, we're currently experiencing some color profiling issues with
reftests so we'll probably need to resolve that before we can re-enable
pixel tests.


- R. Niwa


On Mon, Sep 9, 2013 at 2:41 PM, Robert Hogan robho...@gmail.com wrote:

 Hi there,

 Since Blink forked none of the build bots are running pixel tests.

 This means that we are not catching painting regressions where the
 rendertree text dump is unaffected by the regression.

 Given that in the vast majority of cases a rebaseline to the pixel result
 also entails a rebaseline to the rendertree result and vice versa the
 additional overhead of enabling pixel tests and keeping them up to date is
 not the 'current effort x 2'. In most cases the rebaselining needs to be
 done anyway, the rebaseliner just needs to update the png result while
 they're at it.

 So are we likely to see this situation change in the near future?

 If not, reviewers and patch authors take note I guess!

 Thanks,
 Robert

 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 https://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] No coverage of pixel tests

2013-09-09 Thread Robert Hogan
Hi there,

Since Blink forked none of the build bots are running pixel tests.

This means that we are not catching painting regressions where the
rendertree text dump is unaffected by the regression.

Given that in the vast majority of cases a rebaseline to the pixel result
also entails a rebaseline to the rendertree result and vice versa the
additional overhead of enabling pixel tests and keeping them up to date is
not the 'current effort x 2'. In most cases the rebaselining needs to be
done anyway, the rebaseliner just needs to update the png result while
they're at it.

So are we likely to see this situation change in the near future?

If not, reviewers and patch authors take note I guess!

Thanks,
Robert
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev