Re: [webkit-dev] Removing support for the RVCT compiler
On Sunday, December 11, 2011 02:55:40 AM ext Andreas Kling wrote: Hola WebKittens! Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. I believe some other folks (Brew? Blackberry?) have been compiling WebKit with RVCT. Generally speaking I think it's a pretty decent compiler provided a recent version is used. There are versions available for Linux for example, so it's not a Symbian specific compiler at all. The Qt builds were largely based on RVCT 2.2, which had its fair share of issues (not as bad as WINSCW though). I believe the majority of compiler workarounds in WebKit related to RVCT are because of this ancient version. I think any RVCT related compiler workarounds could probably be removed, because there's a very high chance that they're due to 2.2. But I think if COMPILER(RVCT) is kept, then I can imagine that it would require very little maintenance to keep supporting it. (Interestingly enough grep in WebCore doesn't show anything RVCT related, only JavaScriptCore seems to have some serious workarounds for it) Simon ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing support for the RVCT compiler
Yes, Blackberry uses RVCT (4.1 currently, so I believe 2.2 workarounds can be removed from our point of view.) -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Simon Hausmann Sent: Monday, December 12, 2011 6:47 AM To: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Removing support for the RVCT compiler On Sunday, December 11, 2011 02:55:40 AM ext Andreas Kling wrote: Hola WebKittens! Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. I believe some other folks (Brew? Blackberry?) have been compiling WebKit with RVCT. Generally speaking I think it's a pretty decent compiler provided a recent version is used. There are versions available for Linux for example, so it's not a Symbian specific compiler at all. The Qt builds were largely based on RVCT 2.2, which had its fair share of issues (not as bad as WINSCW though). I believe the majority of compiler workarounds in WebKit related to RVCT are because of this ancient version. I think any RVCT related compiler workarounds could probably be removed, because there's a very high chance that they're due to 2.2. But I think if COMPILER(RVCT) is kept, then I can imagine that it would require very little maintenance to keep supporting it. (Interestingly enough grep in WebCore doesn't show anything RVCT related, only JavaScriptCore seems to have some serious workarounds for it) Simon ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing support for the RVCT compiler
On 12/11/2011 05:56 AM, Benjamin Poulain wrote: On Sat, Dec 10, 2011 at 8:47 PM, Eric Seidele...@webkit.org wrote: I'm curious what the practical implications of this are? Are there 500 #ifdefs for RVCT or 5? I think a dozen of #ifdef, plus a dozen of workarounds for compiler bugs. I know about a lot of ifdefs for the JIT at least. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
[webkit-dev] Removing support for the RVCT compiler
Hola WebKittens! Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. -Kling ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing support for the RVCT compiler
On Sat, Dec 10, 2011 at 6:55 PM, Andreas Kling kl...@webkit.org wrote: Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. It looks like there are two usage of RVCT: Symbian and Linux. It would be interesting to have feedback on both. The Linux patches might still be used by someone. Cheers, Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing support for the RVCT compiler
I'm curious what the practical implications of this are? Are there 500 #ifdefs for RVCT or 5? If it doesn't have a build bot, I'm sure it is broken anyway, and can just be removed regardless. :) -eric On Sat, Dec 10, 2011 at 7:24 PM, Benjamin Poulain benja...@webkit.org wrote: On Sat, Dec 10, 2011 at 6:55 PM, Andreas Kling kl...@webkit.org wrote: Are there any objections to removing support for the RVCT compiler (ARM RealView) in WebKit? As far as I know, the only user has been the Symbian port which is no longer present on WebKit trunk. It looks like there are two usage of RVCT: Symbian and Linux. It would be interesting to have feedback on both. The Linux patches might still be used by someone. Cheers, Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] Removing support for the RVCT compiler
On Sat, Dec 10, 2011 at 8:47 PM, Eric Seidel e...@webkit.org wrote: I'm curious what the practical implications of this are? Are there 500 #ifdefs for RVCT or 5? I think a dozen of #ifdef, plus a dozen of workarounds for compiler bugs. Benjamin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
