Re: [webkit-dev] Style guidelines for braced initialization

2018-04-26 Thread Filip Pizlo


> On Apr 26, 2018, at 10:35 AM, ross.kirsl...@sony.com wrote:
> 
> Hi everybody,
>  
> A simple question regarding https://webkit.org/code-style-guidelines/ 
> :
>  
> I've currently got a clang-format patch up (https://reviews.llvm.org/D46024) 
>  to support our space-before-brace style 
> for object initialization (i.e. `Foo foo { bar };` and not `Foo foo{ bar };`).
> Although we’re enforcing this with check-webkit-style, the guidelines page 
> currently makes no mention of braced initialization in particular. Should we 
> add a clause for this?

Yeah, sounds like we should!

-Filip


>  
> Thanks!
> Ross
> ___
> webkit-dev mailing list
> webkit-dev@lists.webkit.org 
> https://lists.webkit.org/mailman/listinfo/webkit-dev 
> 

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


[webkit-dev] Style guidelines for braced initialization

2018-04-26 Thread Ross.Kirsling
Hi everybody,

A simple question regarding https://webkit.org/code-style-guidelines/:

I've currently got a clang-format patch up (https://reviews.llvm.org/D46024) to 
support our space-before-brace style for object initialization (i.e. `Foo foo { 
bar };` and not `Foo foo{ bar };`).
Although we’re enforcing this with check-webkit-style, the guidelines page 
currently makes no mention of braced initialization in particular. Should we 
add a clause for this?

Thanks!
Ross
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev